Follow-up Comment #11, bug #13810 (project freeciv):
This way I can use
pset_scategory(i)
else I would have
pset_scategory(setting_by_number(i))
There is an example of how to create an iteration
macro when the array pointer is not available in
the header in the patch in bug #13793.
On 30/06/2009, Madeline Book no-reply.invalid-addr...@gna.org wrote:
Follow-up Comment #8, bug #13726 (project freeciv):
(Book, why don't I receive your message on my e-mail account?)
I have no idea, maybe it was just late in arriving?
Maybe your spam filter got tired of reading through
my
Follow-up Comment #4, bug #13848 (project freeciv):
Some rules I was just reminded of:
- No more than 2 empty lines between any sections
in the code.
- #include the header corresponding to the current
c source file after all other headers.
Follow-up Comment #3, bug #13848 (project freeciv):
Could you add assert() rule that instead of
assert(FALSE) assert with more verbose error
message should be used when possible: [...]
There is the die() function which can be used
if the assert condition is not descriptive
enough. I'll add a
Follow-up Comment #1, bug #13811 (project freeciv):
Some general notes:
- The #include shared.h in iterator.h can be
committed separately immediately if desired.
- The string vector header+implementation and
the changes in common/tech.c should be separate
patch submissions.
- Use 8 spaces
Follow-up Comment #8, bug #13810 (project freeciv):
I meant pset only for the variable names; functions
structs, etc. should have setting. The variable name
should usually give some hint as to what it stands for.
So cmd, when the type is struct setting *, would
not be a good variable name
Follow-up Comment #9, bug #13810 (project freeciv):
_(pset_short_help(i))
Why not put the _() in setting_short_help() and write
in the comment header that it returns the translated
version? This goes for all such dupicated expressions.
Why do you use the setting number as first argument
to
On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
Those are the 3 that are being actively developed. My
longterm goal is to merge them all into one project.
Looking through the patches of longturn and warclient I found the
patch 'Setting to control distance of
On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
I did rename op_* to pset_* as it matches the purpose of the variable: a
pointer to a setting struct
Do this for variable names whose type is 'struct setting *' or 'const
struct setting *' only, not function names.
How
Follow-up Comment #4, bug #13846 (project freeciv):
Please no static variables. Use a context argument
and a wrapper/recursive function pair. Ask if you
need an example.
なんじゃそりゃ。
On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
You don't need to. As I said the 3 GB size is not a problem. I think I will
also get warclient and longturn to compare ...
The 3 GB is just silly. The entire history of the trunk and S2_1
branches when cloned from
URL:
http://gna.org/bugs/?13848
Summary: [Patch] More detailed coding style guidelines
Project: Freeciv
Submitted by: mbook
Submitted on: Thursday 07/02/2009 at 02:33
Category: docs
Severity: 4 -
Update of bug #13790 (project freeciv):
Status: Confirmed = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
On 30/06/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
I would rename settings as options, ...
In the client the name option is already used for settings that
are client-only (client/options.[ch]), so I don't think renaming to
this in the server would be very helpful or useful.
Follow-up Comment #9, bug #13814 (project freeciv):
It would appear to affect only 32-bit systems...
シーピーユー差別なんです。
___
Reply to this item at:
http://gna.org/bugs/?13814
On 30/06/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
Am Tuesday 30 June 2009 22:36:11 schrieben Sie:
On 30/06/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
I would rename settings as options, ...
In the client the name option is already used for settings
Follow-up Comment #7, bug #13726 (project freeciv):
Hm, reading the coding style manual, it doesn't say
to avoid the usage of tabs.
Yes, existing coding style allows use of tabs. However,
I agree with book that spaces should be used, so coding
style should be changed. Patch welcome.
Follow-up Comment #8, bug #13726 (project freeciv):
(Book, why don't I receive your message on my e-mail account?)
I have no idea, maybe it was just late in arriving?
Maybe your spam filter got tired of reading through
my drivel.
Was it just the last one, or all my comments on the
gna
Update of bug #13817 (project freeciv):
Status:None = Fixed
Open/Closed:Open = Closed
___
Follow-up Comment #1:
The patch in
Follow-up Comment #2, bug #13559 (project freeciv):
I just noticed that I completely omitted
Per's name from the Patch by: field in
the commit messages for this patch. Sorry
Per. :)
Patch by: Per Inge Mathisen per.mathi...@gmail.com
URL:
http://gna.org/bugs/?13814
Summary: segfault in assess_danger_player
Project: Freeciv
Submitted by: mbook
Submitted on: Monday 06/29/2009 at 18:07
Category: general
Severity: 4 - Important
Follow-up Comment #2, bug #13802 (project freeciv):
It is really needed? Couldn't it be performed by adding
a test in the iterating marco like: if (NULL != hash)?
If you mean in the specific iteration macros like
hash_keys_iterate, this would need to be repeated each
time a new macro like
Follow-up Comment #1, bug #13814 (project freeciv):
The crash seems to occur when a hut is entered...
どうぞ、小屋にお入りください。
___
Reply to this item at:
Follow-up Comment #3, bug #13814 (project freeciv):
It just occurred to me that my recent barbarian.c commit
was buggy in case barbarian player is created midturn. It
could explain this crash if barbarian player is create from
hut. But does it happen already before onsetbarbs turn?
Yes.
On 29/06/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
Am Thursday 18 June 2009 01:50:53 schrieb Madeline Book:
On 17/06/2009, Bernd Jendrissek bernd.jendris...@gmail.com wrote:
[...]
My experience (we did it with git-svn here at work) is that it's a bit
of an impedance
Follow-up Comment #5, bug #13814 (project freeciv):
I tested many times, I really cannot reproduce any crash.
When I put printfs that access the city pointer in assess_danger_player(),
the exactly reproducible
crashes go away. :(
Maybe this is another compiler bug (I will try
various compiler
Update of bug #13817 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13817
___
Message sent
Update of bug #13819 (project freeciv):
Status: In Progress = None
___
Reply to this item at:
http://gna.org/bugs/?13819
___
Message sent
I just made a git repository on gitorious mirroring the
trunk branch in gna svn. Try it out:
$ git clone git://gitorious.org/freeciv-svn-mirror/freeciv-svn-mirror.git
Web page: http://gitorious.org/freeciv-svn-mirror
It should be a bit faster than via git-svn. ;)
On 29/06/2009, Madeline Book madeline.b...@gmail.com wrote:
I just made a git repository on gitorious mirroring the
trunk branch in gna svn. Try it out:
$ git clone git://gitorious.org/freeciv-svn-mirror/freeciv-svn-mirror.git
And when that finishes do
$ git-checkout -b trunk origin/trunk
URL:
http://gna.org/bugs/?13803
Summary: [Patch] Start position cleanup and extension
Project: Freeciv
Submitted by: mbook
Submitted on: Sunday 06/28/2009 at 06:07
Category: editor
Severity: 3 - Normal
Update of bug #13805 (project freeciv):
Assigned to:None = mbook
___
Follow-up Comment #1:
This patch is good, but you can reduce references to the
global variable 'settings' even more
Follow-up Comment #2, bug #13805 (project freeciv):
In case you want git to use your public name and
email address (instead of using information from the
local machine), use
git config --global user.name Your Name Comes Here
git config --global user.email y...@yourdomain.example.com
to set
Update of bug #13807 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13807
___
Message sent
Follow-up Comment #1, bug #13807 (project freeciv):
I'm not sure that we need to get rid of the static
'settings' array and use dynamic memory for settings,
since even with your approach there will still be at
least one variable global to the settings.c file.
If you are worried that you cannot
Follow-up Comment #4, bug #13807 (project freeciv):
This will help! The 'static initializers' error message
was the reason for me to try it with a function. Is an
union portable to win, ...?
Struct/union initializers are part of the c language
(but not c++ apparently), so it should work with
Update of bug #13810 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13810
___
Message sent
Follow-up Comment #3, bug #13810 (project freeciv):
It looks really better and understandable to me. More
over, it should take the minimal size of the whole
structure, and not an addition of all of them.
I agree with pepeto, the union of structs would
probably make more sense, since what we
Follow-up Comment #4, bug #13810 (project freeciv):
static inline bool setting_boolval(conct struct setting_s *op)
That should be const of course.
I'm also not sure about the naming scheme, since
with the full setting_ prefix this makes it a
little awkward to use in expressions.
Perhaps just
Update of bug #13811 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13811
___
Message sent
Update of bug #13559 (project freeciv):
Priority: 1 - Later = 5 - Normal
Status:None = In Progress
Assigned to:None = mbook
Follow-up Comment #1, bug #13799 (project freeciv):
I agree that the client should distinguished between
being connected in pregame, and being disconnected.
If I recall correctly, right now there are some hacks
that check if aconnection is connected to know if
the game data should be reset. A
URL:
http://gna.org/bugs/?13800
Summary: [Patch] Hash table copy constructor and equality
test
Project: Freeciv
Submitted by: mbook
Submitted on: Sunday 06/28/2009 at 05:06
Category: general
Severity: 3 -
URL:
http://gna.org/bugs/?13801
Summary: [Patch] Stub invalid iterator implementation
Project: Freeciv
Submitted by: mbook
Submitted on: Sunday 06/28/2009 at 05:12
Category: general
Severity: 3 - Normal
URL:
http://gna.org/bugs/?13802
Summary: [Patch] Invalid iterator for NULL hash tables
Project: Freeciv
Submitted by: mbook
Submitted on: Sunday 06/28/2009 at 05:25
Category: general
Severity: 3 - Normal
Update of bug #13727 (project freeciv):
Status:None = Ready For Test
___
Follow-up Comment #5:
Here's a quick port for trunk, which appears to
work well. Testing would be appreciated.
URL:
http://gna.org/bugs/?13790
Summary: [Patch] Fix diplomat_success_vs_defender() chance
Project: Freeciv
Submitted by: mbook
Submitted on: Thursday 06/25/2009 at 23:12
Category: general
Severity: 4 -
URL:
http://gna.org/bugs/?13793
Summary: [Patch] Use generic iterator for nation iteration
Project: Freeciv
Submitted by: mbook
Submitted on: Friday 06/26/2009 at 00:13
Category: general
Severity: 3 -
Update of bug #13763 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13763
___
Message sent
Update of bug #13736 (project freeciv):
Priority: 5 - Normal = 7 - High
Assigned to:None = mbook
___
Follow-up Comment #1:
I think we should
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40821
[ju...@williamsonclan.us - Sun Jun 21 03:09:21 2009]:
I am using 2.1.9
Alright, another ticket for the air patrol bug in 2.1.9
has already been started on the gna bug tracker:
https://gna.org/bugs/index.php?13736
I will close this
Update of bug #13732 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13732
___
Message sent
Update of bug #13733 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13733
___
Message sent
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40821
[ju...@williamsonclan.us - Fri Jun 19 19:23:19 2009]:
Hello,
Whenever I try to send my AWACS on Patrol, I receive the following:
File: ../../utility/shared.c
Line: 754
Hi,
Thanks for the report, but could you provide
Follow-up Comment #3, bug #13727 (project freeciv):
There is an other oddity. It seems that the client
absolutly needs to receive the C_S_RUNNING state to
switch to the game page. So, is it better to send
2 states consecutively (C_S_RUNNING and C_S_OVER)
or to allow the client to handle
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40697
[jmarda...@ifrance.com - Thu Jan 29 18:53:19 2009]:
I have made a patch for the gtk client of freeciv adding
a TradeRoute tab in the CityDialog.
The patch was made on rev 15454 of trunk
3 files attached :
- A svn diff patch
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40710
I will close this ticket; if you want to try submitting
a corrected patch for this feature, please use the gna
bugtracker:
https://gna.org/bugs/?func=additemgroup=freeciv
Update of bug #13652 (project freeciv):
Status: Ready For Test = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13715 (project freeciv):
Status: Ready For Test = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #14, bug #13498 (project freeciv):
Can someone using latest S2_1 from svn confirm if
this crash still occurs? There were a number of
fixes committed in the meantime, in particular
one dealing with some nasty potential memory
corruption, so the bug might be absent now.
Update of bug #13719 (project freeciv):
Status:None = Confirmed
Assigned to:None = mbook
___
Reply to this item at:
Update of bug #13727 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13727
___
Message sent
returns
an int value that could be either a setting id or
a command id (help_command?); if it is too much
trouble to fix this too then just use ids.
Some questions:
Am Thursday 18 June 2009 03:45:29 schrieb Madeline Book:
- Sometimes you cmd_reply (= notify_conn) in the
set_command_
Update of bug #13719 (project freeciv):
Open/Closed:Open = Closed
___
Reply to this item at:
http://gna.org/bugs/?13719
___
Message sent
Update of bug #13587 (project freeciv):
Status: In Progress = Postponed
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #1, bug #13727 (project freeciv):
Do we really need to send_diplomatic_meetings() after
the game is over?
終わりの後には外交対話できるか。
___
Reply to this item at:
Update of bug #13713 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13713
___
Message sent
On 17/06/2009, Bernd Jendrissek bernd.jendris...@gmail.com wrote:
I found my agent crashing on tile-related callbacks. Turns out
handle_tile_info() was passing a struct tile *, but enqueue_call() was
taking x and y coordinates. This couldn't have helped the core dumps
and memory corruption
URL:
http://gna.org/bugs/?13714
Summary: [PATCH] Fix type of argument extracted from varargs
list.
Project: Freeciv
Submitted by: mbook
Submitted on: Wednesday 06/17/2009 at 17:31
Category: agents
URL:
http://gna.org/bugs/?13715
Summary: [PATCH] Simplify editor copy and paste handling
Project: Freeciv
Submitted by: mbook
Submitted on: Wednesday 06/17/2009 at 18:23
Category: editor
Severity: 3 -
On 17/06/2009, Bernd Jendrissek bernd.jendris...@gmail.com wrote:
On Thu, Jun 18, 2009 at 12:54 AM, Matthias
Pfafferodtmatthias.pfaffer...@mapfa.de wrote:
at the moment I use svn to work with the freeciv code. For each patchset I
create a copy of the svn repo using 'cp -lr'. It is not the best
Update of bug #13652 (project freeciv):
Status:None = Ready For Test
___
Follow-up Comment #1:
Minimal patchfix. Is there really any current reason
to keep the 'explain' command around?
Follow-up Comment #8, bug #13587 (project freeciv):
Updated to recent trunk.
逃げ出してるよ！
(file #5993)
___
Additional Item Attachment:
File name:
Follow-up Comment #8, bug #13621 (project freeciv):
version 5; changes:
Some slight problems with this version:
- A better name would be load_ruleset_game_settings().
- 'astr' should not be static.
- 'astr' should not even be an astring, a stack
allocated char array would suffice (just pass
Update of bug #13713 (project freeciv):
Status:None = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13714 (project freeciv):
Status: Confirmed = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
On 15/06/2009, Bernd Jendrissek bernd.jendris...@gmail.com wrote:
On Tue, Jun 9, 2009 at 3:44 AM, Madeline Bookmadeline.b...@gmail.com
wrote:
You should know that the agents framework suffers from
a number of design problems and has not been actively
maintained by anyone in a long time, the
Follow-up Comment #5, bug #13621 (project freeciv):
The attached version has some minor style and
formatting improvements and is more or less
good enough to commit, I think. There is though
the obvious problem that ruleset_set_cmd() does
not handle setting side-effects like the
set_command()
Follow-up Comment #7, bug #13587 (project freeciv):
I made some minor improvements to your patch, see
the attached version. This would be the version that
I commit, if nobody sees anything wrong with it.
I made unit_description() only append the upkeep
information if the unit is owned by the
On 08/06/2009, Alexis Scheuer alexis.sche...@free.fr wrote:
Bonjour.
Je tiens à vous indiquer un soucis que j'ai rencontré avec FreeCiv v.
2.1.5-2 sous Ubuntu 8.10, auquel je joue en local avec des IA. Je dois
avoir des fichiers de sauvegarde vérolés : tout marche avec une
sauvegarde
Update of bug #13652 (project freeciv):
Category:None = general
Assigned to:None = mbook
___
Reply to this item at:
Update of bug #13653 (project freeciv):
Status:None = Duplicate
Open/Closed:Open = Closed
___
Reply to this item at:
On 08/06/2009, Bernd Jendrissek bernd.jendris...@gmail.com wrote:
While trying to add an agent, I've found this patch necessary. This is
against 2.1.9, as I have nothing closer to HEAD available.
Your patch looks alright, as far as I can tell and as far as I
know about the intended behaviour
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40809
[ugo.degri...@yahoo.fr - Sun Jun 07 18:41:23 2009]:
I try to connect to the bugtracker of freeciv but the guest account
with the password doens't work. can I have an account or maybe can I
submit the bug elsewhere ?
Use the gna
Update of bug #13586 (project freeciv):
Status: In Progress = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40767
[cazf...@gmail.com - Sat Jun 06 18:41:15 2009]:
2009/4/13 Madeline Book madeline.b...@gmail.com:
[guest - Mon Apr 13 18:37:54 2009]:
I've created and tested a rollback patch, which removes
all update22* references/code
Follow-up Comment #6, bug #13586 (project freeciv):
The extra 'upkeep_info' field is needed for homeless
units because even for the player who owns them they
have no upkeep.
Would it be so bad just to show zero upkeep for those
units? Are there any other circumstances when the extra
URL:
http://gna.org/bugs/?13643
Summary: [RFC] Use lua for customizable database access
Project: Freeciv
Submitted by: mbook
Submitted on: Sunday 06/07/2009 at 04:44
Category: general
Severity: 3 - Normal
Update of bug #13621 (project freeciv):
Assigned to:None = mbook
___
Follow-up Comment #3:
A better and more c compiler friendly style would
be to either declare the variables before the
Follow-up Comment #4, bug #13587 (project freeciv):
Alright, I was not sufficiently clear in my
last comments, so I will explain what I meant.
I wanted you to change unit_upkeep_text() to
take an astring parameter:
void unit_upkeep_text(const struct unit *punit, struct astring *astr);
and
Follow-up Comment #4, bug #13586 (project freeciv):
I think we can safely adopt the convention that
upkeep information will only be available for
the player's own units. So we do not need the
extra 'upkeep_info' boolean field; just check
that the owner is the same the client's player.
if the
Follow-up Comment #1, bug #13621 (project freeciv):
Some basic things I noticed looking at the
patch:
You can just use the simpler
for (op = settings; op-name; op++)
instead of 'do {} while' to iterate over
settings. (Maybe there should be a settings
_iterate macro.)
You probably do not
Update of bug #13583 (project freeciv):
Status: In Progress = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13585 (project freeciv):
Status: In Progress = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13542 (project freeciv):
Status: Ready For Test = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13543 (project freeciv):
Status: Ready For Test = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13546 (project freeciv):
Status: Ready For Test = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13550 (project freeciv):
Status: Ready For Test = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13525 (project freeciv):
Status: Ready For Test = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13540 (project freeciv):
Status: Ready For Test = Confirmed
Open/Closed:Open = Closed
___
Reply to this item at:
1 - 100 of 659 matches
Mail list logo
