Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39849 Now I got this same error in Ubuntu system. It seems that user has to define _GNU_SOURCE for __USE_GNU to be defined. ( export CFLAGS=-D_GNU_SOURCE ./autogen.sh make) works No idea how it always gets set at configure time.

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39849 On 27/11/2007, Marko Lindqvist wrote: Now I got this same error in Ubuntu system. It seems that user has to define _GNU_SOURCE for __USE_GNU to be defined. No idea how it always gets set at configure time. Patch to define

Re: [Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39849 On 27/11/2007, Jason Short [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] - Tue Nov 27 17:48:50 2007]: On 27/11/2007, Marko Lindqvist wrote: Now I got this same error in Ubuntu system. It seems that user has to define

[Freeciv-Dev] (PR#39921) [Patch] Fix gettext checks

2007-11-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39921 Output of recent 'xgettext --version' differs from what configure check expects. Attached patch works for me. - ML diff -Nurd -X.diff_ignore freeciv/configure.ac freeciv/configure.ac --- freeciv/configure.ac 2007-11-27

[Freeciv-Dev] (PR#40018) [Patch] Security fix: Add ' to illegal characters

2008-01-14 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40018 Auth enabled server had died because of nasty SQL. Will commit attached fix immediately. - ML diff -Nurd -X.diff_ignore freeciv/utility/shared.c freeciv/utility/shared.c --- freeciv/utility/shared.c 2008-01-15 04:04:10.0

Re: [Freeciv-Dev] (PR#40018) [Patch] Security fix: Add ' to illegal characters

2008-01-14 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40018 On 15/01/2008, Marko Lindqvist wrote: Auth enabled server had died because of nasty SQL. Will commit attached fix immediately. Of course, in a number of situations it should be allowed character. Proper fix would be escaping nasty

[Freeciv-Dev] (PR#40035) [Patch] Fix S2_2 xaw compilation

2008-01-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40035 These includes fix S2_2 xaw-client compilation (that doesn't necessarily mean that resulting binary is any way usable - xaw-client wasn't when I last tested last autumn). Fixing TRUNK compilation will require more than that. - ML

Re: [Freeciv-Dev] (PR#40049) Losing message is not shown

2008-01-26 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40049 On 26/01/2008, Joan Creus [EMAIL PROTECTED] wrote: I have noticed lately that, for failed attacks, the usual message Your attacking whatever failed against the %s %s doesn't appear. I don't see why, because it even happens in squares

[Freeciv-Dev] (PR#40051) [Patch] LUA_CFLAGS

2008-01-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40051 Instead of hardcoding lua tolua paths to Makefiles, they are defined by configure (hardcoded there as long as we are using our own lua source tree, trivial to replace with pkg-config check later) - ML diff -Nurd -X.diff_ignore

[Freeciv-Dev] (PR#40052) [Patch] Simplify ser civ scripts

2008-01-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40052 Minor cleanup for ser civ scripts. We already require new enough autoconf to depend on it to provide abs_top_srcdir and abs_top_builddir. autogen.sh set obsolete (otherwise unused) variable FC_USE_NEWAUTOCONF - ML diff -Nurd

Re: [Freeciv-Dev] (PR#40054) Percentages in helpdata.c

2008-01-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40054 On 27/01/2008, Joan Creus wrote: How do you remove the c-format? Not really answering your question, but related news: I just today stumbled upon script fragment in the end of configure.ac that does some postprocessing for

[Freeciv-Dev] (PR#40056) [Patch] Configure checks for compiler commandline flags

2008-01-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40056 - This adds new file compiler.m4 containing macros for testing if compiler supports some comamndline option or not. Main use for this will probably be setting tighter warning-options when compiler supports it instead of using only those

Re: [Freeciv-Dev] (PR#40020) Segfault in server aiunit.c ai_manage_units = plrhand.c maybe_make_contact()

2008-01-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40020 On 27/01/2008, William Allen Simpson wrote: So, let's consider this a temporary patch until bounce_unit() -- or its caller -- is fixed. OTOH. I have spent hundreds of hours during last three years hunting bugs that have turned out

Re: [Freeciv-Dev] (PR#39620) [Bug] trunk, gtk-client: Cannot sell buildings

2008-01-28 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39620 On 27/08/2007, Marko Lindqvist wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39620 Nothing happens when one tries to sell buildings in current trunk using gtk-client. Fix. Includes some generic cleanup-style

Re: [Freeciv-Dev] (PR#39620) [Bug] gtk2: Cannot sell buildings

2008-01-28 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39620 On 28/01/2008, William Allen Simpson wrote: The generic interface somehow didn't cause a compile error. That's why I don't like GTK's generic APIs. You don't have type checking with them. Your original report didn't include a

Re: [Freeciv-Dev] (PR#39620) [Bug] gtk2: Cannot sell buildings

2008-01-30 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39620 On 30/01/2008, William Allen Simpson wrote: Marko, the requisite time has passed -- are you committing this, or am I? I can commit tonight - but go ahead if you have opportunity earlier. - ML

Re: [Freeciv-Dev] (PR#40057) strerror-mystrerror

2008-01-31 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40057 On 27/01/2008, Jason Dorje Short [EMAIL PROTECTED] wrote: mystrerror is included in support.c. Two places don't use this but access strerror directly. This patch fixes it (for 2.1). That broke compilation. mystrerror() takes no

Re: [Freeciv-Dev] (PR#40074) civserver non-error spam

2008-02-04 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40074 On 04/02/2008, Jason Dorje Short wrote: Falling back - didn't want to build soldiers, workers, caravans, settlers, or buildings! There are a massive number of such messages every turn. If this is an error it should be fixed. If,

[Freeciv-Dev] (PR#40090) city.ai should be pointer

2008-02-10 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40090 city.ai should be pointer, and value should be NULL in client side. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-10 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 Fix to actual bug. Needs some more testing to check if this is the only problem. - ML diff -Nurd -X.diff_ignore freeciv/ai/aitools.c freeciv/ai/aitools.c --- freeciv/ai/aitools.c 2008-01-20 04:02:14.0 +0200 +++

Re: [Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-10 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 On 10/02/2008, William Allen Simpson wrote: Here's my proposed patch to rid us of this troublesome beast I'd rather keep the function. Even though 'better' choice is currently determined simply by comparing want value, that's

[Freeciv-Dev] (PR#40163) [Patch] Add missing includes to C99 test

2008-03-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40163 $subject - ML diff -Nurd -X.diff_ignore freeciv/m4/c99.m4 freeciv/m4/c99.m4 --- freeciv/m4/c99.m4 2007-08-04 18:36:07.0 +0300 +++ freeciv/m4/c99.m4 2008-03-21 09:25:30.0 +0200 @@ -35,7 +35,10 @@

[Freeciv-Dev] (PR#40164) [Patch] Fix serious release build warnings

2008-03-23 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40164 I looked through compiler warnings for release style build (--disable-debug). Most were just warnings about unused variables (used only when debugging enabled). Two cases turned out to be real bugs: Some dio_get_uintX()

[Freeciv-Dev] (PR#40165) Re: Expanded terrain set, request for info

2008-03-23 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40165 On 16/03/2008, Marko Lindqvist wrote: If there has been no other changes, custom ruleset defined terrains should still work. I tried to make ruleset with just two ocean types, as the plan for the new trireme rules was (I wonder

Re: [Freeciv-Dev] Expanded terrain set, request for info

2008-03-23 Thread Marko Lindqvist
On 16/03/2008, Marko Lindqvist wrote: If there has been no other changes, custom ruleset defined terrains should still work. I tried to make ruleset with just two ocean types, as the plan for the new trireme rules was (I wonder how new trireme move restrictions work with current default

Re: [Freeciv-Dev] (PR#35708) [Patch] Triremes cannot enter Deep Ocean

2008-03-24 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=35708 On 11/02/2007, Marko Lindqvist wrote: Untested patch to limit Triremes to Ocean tiles. Applies on top of Deep Ocean patch #34265. Also, Triremes do not get move bonus from Nuclear Power. Updated against S2_2 svn

[Freeciv-Dev] (PR#40166) Failing assert on scenario load

2008-03-24 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40166 Current S2_2 svn, trying to start Tutorial, results in server crash. rand.c:87: myrand_debug: Assertion `rand_state.is_init' failed. - ML ___ Freeciv-dev mailing list

Re: [Freeciv-Dev] (PR#39668) [Patch] Fix some potential crashes after script_signal_emit()

2008-03-24 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39668 On 04/09/2007, Marko Lindqvist wrote: Calling script_signal_emit() means that almost anything can happen. Most definitely cities or units can disappear. Actually, they can't disappear just yet. Scripting improvements allowing

[Freeciv-Dev] (PR#40167) Client crash on scenario load

2008-03-24 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40167 With #40166 fixing server crash, scenario load now ends to client crash. Once I enter game, there's only explorer unit visible on otherwise black screen. It moves around (autoexplore in the beginning of the first turn?) and then client

[Freeciv-Dev] (PR#40168) [Patch] Fix svnrev path

2008-03-25 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40168 Path received from commandline can be relative one. Use absolute path instead. - ML diff -Nurd -X.diff_ignore freeciv/bootstrap/fc_svnrev_gen.h.in freeciv/bootstrap/fc_svnrev_gen.h.in --- freeciv/bootstrap/fc_svnrev_gen.h.in

Re: [Freeciv-Dev] (PR#40148) handle_unit_upgrade() invalid unit

2008-03-26 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40148 On 12/03/2008, Marko Lindqvist wrote: Running S2_2 r14463 autogames, almost all games have 1: handle_unit_upgrade() invalid unit errors AI was trying to upgrade allied units. Fix attached. - ML diff -Nurd -X.diff_ignore

Re: [Freeciv-Dev] (PR#40163) [Patch] Add missing includes to C99 test

2008-03-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40163 Committed to TRUNK revision 14521 Other branches will follow, if there's no problems reported against this in a couple of days. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#40170) Sending logmessages to clients should be optional

2008-03-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40170 From the security point of view I don't like sending of logmessages to clients, introduced in #40087. Those messages can potentially contain information about server machine internals I'd rather not broadcast to everyone. At least

Re: [Freeciv-Dev] (PR#40170) Sending logmessages to clients should be optional

2008-03-28 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40170 On 28/03/2008, Madeline Book wrote: At least commandline switch to disable this feature is required. Or it could be disabled automatically if the server is not being used to run a local single player game It might get

Re: [Freeciv-Dev] (PR#40167) Client crash on scenario load

2008-03-29 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40167 On 24/03/2008, Marko Lindqvist wrote: With #40166 fixing server crash, scenario load now ends to client crash. Actually, this is not limited to scenario load. Same happens quite often for any savegame load. (scenario load crashes

Re: [Freeciv-Dev] (PR#40167) Client crash on scenario load

2008-03-29 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40167 On 29/03/2008, Pepeto _ wrote: It seems linked with the new code that forbid partially detached connections, doesn't it? You type faster than I do :-) ... Uh. I'm not too sure if rearranged sequences of ruleset loads, game

Re: [Freeciv-Dev] (PR#40171) bug in gtk client - select CMA none

2008-03-30 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40171 On 28/03/2008, [EMAIL PROTECTED] wrote: This is because cmafec_preset_get_parameter gets CMA_NONE as an argument. It can be fixed by testing idx != CMA_NONE before calling cmafec_preset_get_parameter. It is correct because if the

Re: [Freeciv-Dev] (PR#35708) [Patch] Triremes cannot enter Deep Ocean

2008-03-30 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=35708 On 24/03/2008, Marko Lindqvist wrote: On 11/02/2007, Marko Lindqvist wrote: Untested patch to limit Triremes to Ocean tiles. Applies on top of Deep Ocean patch #34265. Also, Triremes do not get move bonus from

[Freeciv-Dev] (PR#40173) Assertion `pteam != ((void *)0)' failed.

2008-03-30 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40173 Current S2_2. Client crashed when trying to reconnect game I just left. Another way of detached connections problem to show itself? - ML ___ Freeciv-dev mailing list

Re: [Freeciv-Dev] (PR#40173) Assertion `pteam != ((void *)0)' failed.

2008-03-31 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40173 On 31/03/2008, Madeline Book wrote: Current S2_2. Client crashed when trying to reconnect game I just left. I can't seem to reproduce this. :( Neither can I myself. Later I found out that there was another civserver

[Freeciv-Dev] (PR#40176) map_distance_vector() crash

2008-04-01 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40176 S2_2 revision 14528. Note that backtrace is from optimized (-O2) build. This is not reproducible without optimization. Program received signal SIGSEGV, Segmentation fault. map_distance_vector (dx=0x7fffa5833924, dy=0x7fffa5833920,

[Freeciv-Dev] (PR#40177) [Patched] Shared common library

2008-04-01 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40177 utility + common - libfreeciv.so server parts common to server manual - libfreeciv-srv.so Main difficulty was to get both --disable-shared and --enable-shared to work correctly. - ML diff -Nurd -X.diff_ignore

Re: [Freeciv-Dev] (PR#40175) [Patch] Fix generate_players() illegal memory access

2008-04-01 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40175 On 30/03/2008, Marko Lindqvist wrote: S2_1 code differs from S2_2 TRUNK. It seems that some earlier bugfix is missing. Committed TRUNK (r14538) and S2_2 (r14539). S2_1 situation requires further investigation. - ML

[Freeciv-Dev] (PR#40178) Fortress crashes game

2008-04-01 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40178 New borders code has several comments to the effect that fortresses are not currently supported, and indeed building one immediately crashes game. maphand.c:1807 assert(NULL != pcity); /* FIXME: temporary IDENTITY_NUMBER_ZERO

[Freeciv-Dev] (PR#40179) [Patch] Fix take - crash

2008-04-01 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40179 If there is no free player slots, detached connection doing take - crashes server. To reproduce S2_1: 1. Connect client A to server 2. A: /set aifill 30 3. Connect client B to server (connection is not automatically

Re: [Freeciv-Dev] (PR#40179) [Patch] Fix take - crash

2008-04-01 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40179 On 01/04/2008, Marko Lindqvist wrote: S2_1: 1. Connect client A to server 2. A: /set aifill 30 3. Connect client B to server (connection is not automatically attached) 4. B: /take - S2_2 and TRUNK: 1. Connect

Re: [Freeciv-Dev] (PR#40177) [Patched] Shared common library

2008-04-01 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40177 On 01/04/2008, Per I. Mathisen wrote: Why, though? Are you really sure you want to risk your sanity by using libtool? This was originally part of #40144, where I first almost lost my sanity because of not using libtool. Libtool

Re: [Freeciv-Dev] (PR#40147) create command names get overwritten

2008-04-01 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40147 On 12/03/2008, William Allen Simpson [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40147 Confirmed and tested. Redid the comments some more. Committed trunk revision 14464. Committed S2_2

Re: [Freeciv-Dev] (PR#40176) map_distance_vector() crash

2008-04-02 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40176 On 01/04/2008, Marko Lindqvist wrote: #1 0x0040be1c in sq_map_distance (tile0=0x14, tile1=0xbf9638) As interesting value of tile0 indicates... #2 0x0048f1f4 in map_claim_border (ptile=0xbfb1b8, powner

Re: [Freeciv-Dev] (PR#40170) Sending logmessages to clients should be optional

2008-04-02 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40170 On 28/03/2008, Madeline Book wrote: Actually, in the meantime, I thought of a better way: send the error messages only to connections with hack access. Sounds sensible. Patch wanted. - ML

Re: [Freeciv-Dev] (PR#40180) Uninitialized datas in city structure

2008-04-02 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40180 On 02/04/2008, Pepeto _ wrote: There are many #if 0 ... #endif added at revisions 13911 to 13913 in create_city_virtual() in common/city.c. Now, there are lot of uninitialized data in the structure, including notably the trade

Re: [Freeciv-Dev] (PR#40176) map_distance_vector() crash

2008-04-02 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40176 On 03/04/2008, Marko Lindqvist wrote: This should be fixable simply by adding ref_count for vision sites. Patch attached. - ML diff -Nurd -X.diff_ignore freeciv/common/vision.c freeciv/common/vision.c --- freeciv/common

Re: [Freeciv-Dev] (PR#40180) Uninitialized datas in city structure

2008-04-03 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40180 On 03/04/2008, Pepeto _ wrote: [EMAIL PROTECTED] - Jeu. Avr. 03 00:09:30 2008]: Memory for city structure is allocated with fc_calloc(). It takes care of zero initializations. Ok, thank you. I didn't know about it. Is it

[Freeciv-Dev] (PR#40181) Manpages outdated regarding commandline options

2008-04-03 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40181 Outdated gamelog documentation noticed in forum thread http://forum.freeciv.org/viewtopic.php?t=4883 Comparing manpages to ./ser --help and ./civ --help reveals more errors. - ML

Re: [Freeciv-Dev] 2.1.4

2008-04-04 Thread Marko Lindqvist
On 04/04/2008, Daniel Markstedt wrote: So what do you say about a 2.1.4 maintenance release? We need one :-) I can take care of the details when I get back home from working in Frankfurt, in about two weeks or so. Good. Will you announce this on translator list? - ML

Re: [Freeciv-Dev] (PR#40182) Scenario ruleset ignored

2008-04-04 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40182 On 03/04/2008, Marko Lindqvist wrote: S2_1: I loaded mongols-modpack to server, but when game started it was using default rulesets. Update: It works when everything works. Bug is that error is silently ignored. 1

[Freeciv-Dev] (PR#40185) [Patch] Fix AI crash when city destroyed during trade negotiation

2008-04-04 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40185 $subject There was attempt to log city name even when there was no city. Found from all branches starting from S2_1. - ML diff -Nurd -X.diff_ignore freeciv/ai/advdiplomacy.c freeciv/ai/advdiplomacy.c --- freeciv/ai/advdiplomacy.c

Re: [Freeciv-Dev] (PR#40183) wall command sends wrong event type

2008-04-04 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40183 On 04/04/2008, Madeline Book wrote: [book - Thu Apr 03 22:58:49 2008]: As per my off-topic comment in PR#40170, the /wall command should not be E_LOG_FATAL. A patch will be coming soon... And here it is. Hopefully I have

Re: [Freeciv-Dev] (PR#40187) Configure fails in 2.1

2008-04-05 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40187 On 05/04/2008, Joan Creus wrote: ./configure: line 2074: syntax error near unexpected token ` Copyright (C) 2004 Freeciv team ' ./configure: line 2074: `FREECIV_VERSION_COMMENT( Copyright (C) 2004 Freeciv team

[Freeciv-Dev] (PR#40189) Pregame disconnect - reconnect leaves player under AI control

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40189 S2_2 and TRUNK 1. Start server 2. Connect client to it: /list: List of players: /list: -- /list: cazfi (user cazfi, Human, Team 0, not ready) 1 connection:

[Freeciv-Dev] (PR#40190) [Patch] Rewritten handle_event()

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40190 Functional changes: - Popup for server operator message is shown to all clients, even those attached to AI mode player - Always show messages that are configured to be shown somewhere. If it cannot be shown where configured, show in

Re: [Freeciv-Dev] (PR#39777) Command line options

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39777 On 14/10/2007, Christian Knoke wrote: ~$ civclient -- --help The last line (for bug reports) should appear in the output of ~$ civclient --help instead! At the current place, no one will find it. Attached patch adds bug

Re: [Freeciv-Dev] (PR#40077) S2_2 memory leak in readline code

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40077 On 04/02/2008, Jason Dorje Short wrote: Pretty minor but the readline code may need some sort of function call for cleanup. There's no cleanup function in readline API. This leak is most likely in readline (at least from our

Re: [Freeciv-Dev] (PR#39965) Uncompressed Compressed savegames use differing whitespace

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39965 On 13/12/2007, [EMAIL PROTECTED] wrote: I noticed that savegames using no compression (level 0) and savegames using compression (at least the default level 6) use completely different line end whitespace, and so the the two files

[Freeciv-Dev] (PR#40191) [Patch] Do not resend Edit Mode message to everyone when client connects

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40191 When new client connects, send Edit Mode notification only to that connection. - ML diff -Nurd -X.diff_ignore freeciv/server/connecthand.c freeciv/server/connecthand.c --- freeciv/server/connecthand.c 2008-04-05 00:49:30.0

Re: [Freeciv-Dev] (PR#40184) [editor] Toolbar GUI front-end preliminary work

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40184 On 04/04/2008, Madeline Book wrote: A small preview of the editor toolbar in action, as described in the editor wikia page. I have also attached a screenshot if you do not have the time (or the means) to apply a git binary diff

[Freeciv-Dev] (PR#40192) [Patch] Fix civ1 ruleset syntax

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40192 Attempt to load civ1 ruleset fails because of illegal format. Fix attached. Non-fatal error about Airbase remains as there currently is no legal format for disabling Airbases completely. - ML diff -Nurd -X.diff_ignore

[Freeciv-Dev] (PR#40194) Start button skips checks

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40194 start_game() is called from two distinct places. 1) Command /start 2) All human players indicate that they are ready by using Start -button There is some functionality in first that is never executed for case two. Number of players

[Freeciv-Dev] (PR#40195) [Patch] Fix several crashes if there's less nations than MAX_PLAYERS

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40195 If modpack has less than MAX_PLAYERS playable nations, server can run out of nations to assign to players and crash. Attached patch prevents several such cases. - There's no duplicate code for handling both start methods. #40194

[Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 S2_2 1. Start server 2. Connect client A with username 'cazfi' - There will be users 'cazfi' and 4 * easy AI 3. Connect client B with username 'cazfi2' - Related to #40189, new user is under AI control and shown by name

Re: [Freeciv-Dev] (PR#40194) Start button skips checks

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40194 On 07/04/2008, Marko Lindqvist wrote: start_game() is called from two distinct places. 1) Command /start 2) All human players indicate that they are ready by using Start -button There is some functionality in first

[Freeciv-Dev] (PR#40197) [Patch] Fix terrain/resource memory leak

2008-04-07 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40197 $subject, at least S2_1 affected. Change affecting all games is in terrains_free(). Client side changes are more protection against bad network data. - ML diff -Nurd -X.diff_ignore freeciv/client/packhand.c

[Freeciv-Dev] (PR#40199) [Patch] Do not include libintl.h when nls disabled

2008-04-08 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40199 Some versions of libintl.h break --disable-nls compile (maybe also: when it compiles, nls is not really disabled) Fix attached. - ML diff -Nurd -X.diff_ignore freeciv/utility/fcintl.h freeciv/utility/fcintl.h ---

[Freeciv-Dev] (PR#40200) Helpdata.c needs unhardcoding

2008-04-08 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40200 helpdata.c has never reached totally modpack/ruleset independent state. At very least, 2.2 should not be farther from that goal than 2.1. Information provided by #39831 should be read/generated from rulesets. Another problem with

Re: [Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-08 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 On 07/04/2008, Pepeto _ wrote: Try with this patch. Bugs I reported cannot be reproduced when this patch is applied. Still, I don't think patch is correct. At the very least changes you make should not be required (if other parts

Re: [Freeciv-Dev] (PR#39614) client connection list in start page

2008-04-08 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39614 On 12/10/2007, Pepeto _ wrote: First step: clean up in stdinhand. /aitoggle, /remove, /cmdlevel and /cut support the arguments between quote marks. I believe this is redundant after #40196 patch. #40196 fixes lowlevel quoted

Re: [Freeciv-Dev] (PR#39614) client connection list in start page

2008-04-09 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39614 On 09/04/2008, Pepeto _ wrote: [EMAIL PROTECTED] - Mar. Avr. 08 20:14:47 2008]: On 12/10/2007, Pepeto _ wrote: First step: clean up in stdinhand. /aitoggle, /remove, /cmdlevel and /cut support the arguments between

Re: [Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-09 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 On 09/04/2008, Madeline Book wrote: As far as I can see the mystrncasequotecmp function is only used by find_player_by_name_prefix. Why would the player names in the internal server/client data structures (i.e. in game.players[])

Re: [Freeciv-Dev] (PR#39614) client connection list in start page

2008-04-09 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39614 On 09/04/2008, Pepeto _ wrote: As you said, it's not as good as tokenize the command lines. So, would your patch for #40196 will be a temporary change or be a long stable way? It will be rewritten when somebody decides to do so.

Re: [Freeciv-Dev] (PR#39614) client connection list in start page

2008-04-10 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39614 On 09/04/2008, Pepeto _ wrote: Agreed, that's why I was asking. So maybe an other ticket would be needed? #40202 Isn't the first patch of this ticket a good first step? It's adding tokenization separately for several commands. I

[Freeciv-Dev] I'll be away from my development machine

2008-04-10 Thread Marko Lindqvist
I'll be away from my Freeciv development machine several days. I'll try to read email and look (but not test) some of the recent patches. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40167) Client crash on scenario load

2008-04-10 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40167 On 10/04/2008, Ulrik Sverdrup wrote: data/scenario/hagworld-120x60-v1.2.sav:server_state=2 This means that hargworld is not scenario at all (in the Freeciv internal terminology) That is about as much of a clue I have. It seems

Re: [Freeciv-Dev] (PR#40194) Start button skips checks

2008-04-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40194 On 07/04/2008, Marko Lindqvist wrote: start_game() is called from two distinct places. 1) Command /start 2) All human players indicate that they are ready by using Start -button There is some functionality in first

[Freeciv-Dev] (PR#40204) Client side connection access_level not updating

2008-04-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40204 S2_1, gtk client 1. Start server 2. Start two clients and connect them to server 3. From client A, check that connection menu for client B contains Give info access and Give ctrl access (indicating that client A has 'hack' access

Re: [Freeciv-Dev] (PR#40196) String comparison problems

2008-04-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 On 08/04/2008, Marko Lindqvist wrote: - Only strings both starting and ending with '' are considered quoted and these starting and ending quotes are only ones ignored during matching - Correct string length comparison

Re: [Freeciv-Dev] (PR#39614) client connection list in start page

2008-04-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39614 On 12/10/2007, Pepeto _ wrote: + /cmdlevel and /cut send the username to the server, not the player name which can be different. + the /cmdlevel ctrl menu item really makes it, no /cut. This one committed. Remaining patch in

Re: [Freeciv-Dev] (PR#39821) Global Lists Bug... Can't Add to top of list?

2008-04-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39821 On 10/04/2008, Ulrik Sverdrup wrote: Can someone test this? I can't find any other case than the global worklist editor where pcity is NULL. I don't think pcity can be NULL in any other case. Checking against such case is still

Re: [Freeciv-Dev] (PR#39938) paratroopers disappear

2008-04-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39938 On 10/04/2008, Ulrik Sverdrup wrote: Trivial patch looks like this. Tested on trunk but is probably harmless on any branch, including 2.1 Yes, this one should go to S2_1 (and other branches for now). For S2_2 and TRUNK we should

[Freeciv-Dev] (PR#40205) [Patch] Execute windows binaries by correct name

2008-04-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40205 Add suffix (.exe) to program names to launch. - ML diff -Nurd -X.diff_ignore freeciv/bootstrap/civ.in freeciv/bootstrap/civ.in --- freeciv/bootstrap/civ.in 2008-03-09 01:26:53.0 +0200 +++ freeciv/bootstrap/civ.in 2008-04-15

Re: [Freeciv-Dev] (PR#39413) Effects-ize the calender

2008-04-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39413 On 09/04/2008, Ulrik Sverdrup wrote: I realize this bug has distinct parts 1. /set startyear 2. MinYear 3. Use Slow_Down_Timeline to effects-ize the calendar The first one is the least intrusive. It seems to me that number

Re: [Freeciv-Dev] (PR#40181) Manpages outdated regarding commandline options

2008-04-16 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40181 Patch - ML diff -Nurd -X.diff_ignore freeciv/doc/man/civclient.6 freeciv/doc/man/civclient.6 --- freeciv/doc/man/civclient.6 2007-08-10 17:09:36.0 +0300 +++ freeciv/doc/man/civclient.6 2008-04-16 22:32:34.0 +0300 @@

[Freeciv-Dev] (PR#40206) minplayers meaningless

2008-04-16 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40206 Even with #40194 restoring check for minplayers -setting, it is not same as it used to be. Now that aifill players are created before game starts, they count toward minplayers. - ML ___

[Freeciv-Dev] (PR#40208) New orders to AI settler on citybuild mission crashes game

2008-04-20 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40208 First investigated as 2.1.3 server crash, reproducible with current S2_1: - /take AI player who has settlers on city build mission - Give new goto-command to settler Goto tile will be set to NULL, but ai_unit_new_role() later

Re: [Freeciv-Dev] (PR#40208) New orders to AI settler on citybuild mission crashes game

2008-04-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40208 On 21/04/2008, Marko Lindqvist wrote: Goto tile will be set to NULL, but ai_unit_new_role() later attempts to access it in order to cancel city build mission. Attached patch fixes all similar crashes and some related non-crash

Re: [Freeciv-Dev] (PR#40208) New orders to AI settler on citybuild mission crashes game

2008-04-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40208 On 21/04/2008, Marko Lindqvist wrote: On 21/04/2008, Marko Lindqvist wrote: Goto tile will be set to NULL, but ai_unit_new_role() later attempts to access it in order to cancel city build mission. Attached patch fixes

Re: [Freeciv-Dev] (PR#40209) A minor memory leak

2008-04-21 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40209 On 21/04/2008, Elmo Todurov wrote: Now I want a cookie! $ svn diff Index: server/sernet.c === --- server/sernet.c (revision 14605) +++ server/sernet.c

[Freeciv-Dev] (PR#40210) Problems compiling ggz support

2008-04-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40210 I cannot build ggz-support to Freeciv. I added ggz -enabled configuration to builds listed in http://vcust127.louhi.net/freeciv/testing/compilation.php ggz-packets are currently installed to Debian Unstable and Ubuntu Gutsy Gibbon

Re: [Freeciv-Dev] (PR#40210) Problems compiling ggz support

2008-04-25 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40210 On 22/04/2008, Marko Lindqvist wrote: checking for GGZ configuration tool: ggz-config... yes (dismissed due to different prefix) configure: error: Could not configure GGZ client support. See above messages. It just required

Re: [Freeciv-Dev] (PR#40212) [Patch] Fix observer crash with invisible cities

2008-04-26 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40212 On 27/04/2008, Marko Lindqvist wrote: Reason was that ptile-city-tile is NULL when fill_city_overlays_sprite_array() calls city_base_to_city_map(). With current structure field names: ptile-worked-tile Worked is city that has

[Freeciv-Dev] (PR#40213) No way to turn worker display from main map

2008-04-27 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40213 S2_2 TRUNK, gtk-client There seems to be no way to turn off city worker display from main map. At least it's not among other such options in View -menu. In S2_1 and earlier it is controlled by 't' -key (and is off by default) -

<    1   2   3   4   5   6   7   8   9   10   >