On May 5, 2014, 3:44 p.m., Andreas Hansson wrote:
It was my intention for all of this to be all required for ISA splitting;
these changes just address one aspect of the solution. If one single
changeset is desired, this should be folded into the other ISA splitting
changes.
Steve
changeset 82d8f37e5b57 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=82d8f37e5b57
description:
arm: allow DC instructions by default so SE mode works
diffstat:
src/arch/arm/isa.cc | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diffs (12 lines):
diff
changeset 3b9e1fa3da47 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=3b9e1fa3da47
description:
sim, arm: implement more of the at variety syscalls
Needed for new AArch64 binaries
diffstat:
src/arch/arm/linux/process.cc | 4 ++--
src/sim/syscall_emul.cc
changeset 3ca67d0e0e7e in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=3ca67d0e0e7e
description:
arm: Make sure UndefinedInstructions are properly initialized
diffstat:
src/arch/arm/faults.hh | 12 +++-
src/arch/arm/isa/insts/data64.isa | 9
There is the profile parameter on the BaseCPU that samples the current
location of the PC at a given interval. However, I think this only works
with FS mode, so you'd need to make sore changes so it woudl work with
SE mode (mostly around finding the symbol table I think). Additionally,
the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2272/#review5096
---
Ship it!
Ship It!
- Ali Saidi
On May 14, 2014, 5:46 a.m., Steve
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2273/#review5097
---
Ship it!
This looks fine to me, but I'm going to guess Andreas will
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2274/#review5098
---
Ship it!
Ship It!
- Ali Saidi
On May 14, 2014, 5:46 a.m., Steve
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2275/#review5099
---
Ship it!
Ship It!
- Ali Saidi
On May 14, 2014, 5:46 a.m., Steve
I don't think this is really something you can half do, or at least the
time to break it into multiple pieces and individually test each one far
exceeds any possible gain. While it might be somewhat more annoying to
thumb though 15 pages of diffs in one sitting vs 3 pages of diffs 5
times, I'd
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2278/#review5103
---
Ship it!
Ship It!
- Ali Saidi
On May 15, 2014, 4:03 p.m., Anthony
On April 30, 2014, 3:13 a.m., Ali Saidi wrote:
Thanks for the patch Andrew.
My only hesitation is that this does seem to create another issue (probably
a less likely one) where the simulator could try to really exit here and
fail. That said it's probably good to fix this for now as
I think 4.6 is a good target for the moment.
Ali
On 29.05.2014 13:05, Steve Reinhardt via gem5-dev wrote:
Sounds good to me. I'm still running Ubuntu 12.04 on my home machine,
which has 4.6, so I wouldn't want to push any further than that though.
Steve
On Thu, May 29, 2014 at
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2279/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2228/#review5116
---
Ship it!
Ship It!
- Ali Saidi
On May 30, 2014, 2:20 p.m., Andrew
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2281/#review5122
---
Ship it!
Ship It!
- Ali Saidi
On June 1, 2014, 12:47 a.m., Steve
The KvmCpu is used to fast-forward the simulation using Kvm as the
execution host, not gem5 hosting a Kvm. In theory much of the support
for virtualization has been added to ARM (32-bit) support in gem5, but I
can't say it's been throughly tested. You could always try to boot a
kernel with KVM
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2288/#review5131
---
Ship it!
Ship It!
- Ali Saidi
On June 7, 2014, 10 p.m., Joel
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2287/#review5132
---
Ship it!
Ship It!
- Ali Saidi
On June 7, 2014, 10:02 p.m., Joel
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2290/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2295/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2279/
---
(Updated June 17, 2014, 5:03 p.m.)
Review request for Default.
Repository: gem5
Hi Antonio,
Simulating ARM x86 at the same time won’t work today. If you wanted to make
it work, you’d need to teach the build system how to generate compile all the
architectures into a single binary, and fix some places in the code where we
use #defines based on the architecture to
(i.e. between the two QEMU
processes I have shared memory). Hope this short description make sense.
Do you think I can apply a similar approach here?
thanks again,
Antonio
On Sun, Jun 22, 2014 at 12:06 PM, Ali Saidi via gem5-dev gem5-dev@gem5.org
wrote:
Hi Antonio,
Simulating ARM
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2295/
---
(Updated June 24, 2014, 2:19 p.m.)
Review request for Default.
Repository: gem5
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2298/
---
(Updated June 24, 2014, 4:28 p.m.)
Review request for Default.
Repository: gem5
On June 25, 2014, 2 p.m., Andreas Hansson wrote:
Perhaps I am missing something, but why would Ruby forward the packet to
the iobus in the first place if the address is not valid?
Steve Reinhardt wrote:
This is an FS thing, where you misspeculate in the kernel and generate a
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2304/#review5167
---
Ship it!
Ship It!
- Ali Saidi
On June 26, 2014, 9:49 p.m., Anthony
On June 30, 2014, 8:34 p.m., Amin Farmahini wrote:
After applying this patch, the minimum number of float regs should be 160,
even for ARMv7 ISA. If you set the number of numPhysFloatRegs to lower than
160, you get an assertion error from cpu/o3/cpu.cc:
assert(params-numPhysFloatRegs
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2279/#review5171
---
Last chance for comments?
- Ali Saidi
On June 17, 2014, 5:03 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2307/#review5178
---
Ship it!
Ship It!
- Ali Saidi
On July 3, 2014, 5:13 p.m., Steve
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2306/#review5179
---
Ship it!
Ship It!
- Ali Saidi
On July 3, 2014, 5:12 p.m., Steve
I think the assert isn’t quite strict enough, it should really be +1 of what it
is now so that forward progress can be made. Remember that all these registers
are taking up physical registers. I think you’re worried about the idea that
there are 160 register is the PRF, and really you should be
Context switches are handled by the linux kernel that is running on the
simulator. When it gets an interrupt (timer) it checks if it needs to context
switch and does.
The kernel is going to set up softIRQs for itself, if you wanted to trigger one
from the simulator you’d either need to go
We've talked about this before, but I'd like to bring it up again. I'd l
like to switch the style to 100 character lines. I think it's far
clearer when the majority of the time all the function arguments end up
on a single line and while sometimes you can get around that with
temporaries it's
On May 4, 2014, 11:56 p.m., Steve Reinhardt wrote:
src/python/m5/simulate.py, line 117
http://reviews.gem5.org/r/2246/diff/1/?file=39626#file39626line117
for all these 'if hasattr()' changes (here and below, and in
simulate.py): seems like it would be much cleaner to make sure
On May 4, 2014, 11:56 p.m., Steve Reinhardt wrote:
src/python/m5/SimObject.py, line 654
http://reviews.gem5.org/r/2246/diff/1/?file=39624#file39624line654
This seems kind of complicated, but I'm going to wait for a
higher-level description of what it's doing before I dig into it.
On July 15, 2014, 2:47 p.m., Andreas Sandberg wrote:
Overall, I think this patch looks good and the refactoring is a well-needed
change to the way we implement replacement policies.
At a high level, I'd really appreciate it if you could split this patch
into two patches so the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2167/#review5217
---
Ship it!
src/mem/cache/tags/lru.hh
On July 22, 2014, 2:24 p.m., Ali Saidi wrote:
src/mem/cache/tags/lru.cc, line 177
http://reviews.gem5.org/r/2167/diff/5/?file=40401#file40401line177
why not unsigned?
Anthony Gutierrez wrote:
I made it unsigned because CacheBlk's set field is an int, as well as the
fact
A patch would absolutely be welcomed. AArch32 mode still exists and gdb
should still work for 32-bit code. This was just an oversight. To be
clear gem5 will support ARMv8 going forward but we plan to support both
AArch32 and AArch64 code.
Thanks,
Ali
On 19.08.2014 18:19, Anthony Gutierrez
Looking through the change sets between now and 10231 there are a number
of compiler and bug fixes along with a few big changes. I think the big
changes are quite contained, so I'd be in favor for making changeset
10283 79fde1c67ed8 the new stable if others were ok with that.
Ali
On
of this? I personally prefer keeping a buffer of about 2-3 months
between gem5-dev and gem5-stable.
--
Nilay
On Tue, 19 Aug 2014, Ali Saidi via gem5-dev wrote:
Looking through the change sets between now and 10231 there are a number
of compiler and bug fixes along with a few big changes
changeset 1aff1376921e in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=1aff1376921e
description:
arm: Assume we have a kernel that supports pci devices
Change the default kernel for AArch64 and since it supports PCI devices
remove the hack that made
changeset 1e2f39859382 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=1e2f39859382
description:
dev: seperate legacy io offsets from PCI offset
The PC platform has a single IO range that is used both legacy IO and
PCI IO
while other platforms may
changeset 644b615fbe6a in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=644b615fbe6a
description:
arm: Support 2GB of memory for AArch64 systems
diffstat:
configs/common/FSConfig.py | 27 +++
src/dev/arm/RealView.py| 9 +
2
changeset 198dfef33403 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=198dfef33403
description:
dev, arm: Add support for linux generic pci host driver
This change adds support for a generic pci host bus driver that
has been included in recent Linux
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2400/#review5326
---
Thanks for finding this Andrew. Could you try to change the order of the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2400/#review5331
---
Ship it!
Ship It!
- Ali Saidi
On Sept. 15, 2014, 6:29 p.m., Andrew
On Sept. 15, 2014, 8:34 p.m., Ali Saidi wrote:
Ship It!
Thanks for making the change Andrew.
Ali
- Ali
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2400/#review5331
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2409/#review5349
---
Ship it!
Ship It!
- Ali Saidi
On Sept. 23, 2014, 7:46 p.m., Steve
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2411/#review5351
---
Ship it!
Ship It!
- Ali Saidi
On Sept. 23, 2014, 7:47 p.m., Steve
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2412/#review5352
---
Ship it!
Ship It!
- Ali Saidi
On Sept. 23, 2014, 7:47 p.m., Steve
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2463/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
Hi Everyone,
We've noticed an issue with the WriteInvalidate patch where the cpu
reads or writes the same cache line that is being write invalidated.
We're working on a fix and hope to have it out next week. If not we'll
disable the code for the time being.
Thanks,
Ali
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2468/#review5431
---
thanks for the patch. it looks good, but I'm not sure if the ruby change
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2468/#review5432
---
src/cpu/o3/lsq_impl.hh
http://reviews.gem5.org/r/2468/#comment4912
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2468/#review5435
---
src/cpu/o3/lsq_impl.hh
http://reviews.gem5.org/r/2468/#comment4915
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2470/#review5436
---
Ship it!
Ship It!
- Ali Saidi
On Oct. 29, 2014, 3:01 p.m., Andrew
changeset aa46a8ae3487 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=aa46a8ae3487
description:
arm: Fix multi-system AArch64 boot w/caches.
Automatically extract cpu release address from DTB file.
Check SCTLR_EL1 to verify all caches are enabled.
changeset aa23216161fa in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=aa23216161fa
description:
arm: Mark some miscregs (timer counter) registers at unverifiable.
The checker can't verify timer registers, so it should just grab the
version
from the
changeset 38c7a9ea7729 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=38c7a9ea7729
description:
cpu: Add support to checker for CACHE_BLOCK_ZERO commands.
The checker didn't know how to properly validate these new commands.
diffstat:
changeset d5554f97c451 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=d5554f97c451
description:
arm, mem: Fix drain bug and provide drain prints for more components.
diffstat:
src/arch/arm/table_walker.cc | 5 ++---
src/mem/cache/mshr_queue.cc | 3 +++
changeset b423e1d0735e in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=b423e1d0735e
description:
arm, tests: Update config files to more recent kernels and create
64-bit regressions.
This changes the default ARM system to a Versatile Express-like system
changeset 2b416ef3b400 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=2b416ef3b400
description:
automated merge
diffstat:
src/arch/alpha/linux/process.cc |4 +-
src/arch/arm/linux/process.cc|4 +-
src/arch/mips/linux/process.cc |4 +-
changeset f33fab6214c4 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=f33fab6214c4
description:
arm: fix bare-metal memory setup.
The bare-metal configuration option still configured memory with the
old scheme
that no-longer works. This change
changeset ca4438b6e39a in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=ca4438b6e39a
description:
tests: Update regressions for the new kernels and various preceeding
fixes.
diffstat:
tests/long/fs/10.linux-boot/ref/alpha/linux/tsunami-minor/config.ini
changeset bd7c2aa12122 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=bd7c2aa12122
description:
arm, tests: Add 64-bit ARM regression tests
diffstat:
tests/long/fs/10.linux-boot/ref/arm/linux/realview64-minor-dual/config.ini
| 2431 +++
changeset cae494887847 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=cae494887847
description:
arm, tests: Forgot the system.terminal files for the new regressions.
diffstat:
tests/long/fs/10.linux-boot/ref/arm/linux/realview64-minor-dual/system.terminal
changeset ba51f8572571 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=ba51f8572571
description:
tests: Update stats no match.
Bootloader I had on my sytem was an older version with a couple of
instruction differences.
diffstat:
These should now be fixed.
Thanks,
Ali
On 11/2/14, 3:20 PM, Cron Daemon via gem5-dev gem5-dev@gem5.org wrote:
*
build/SPARC/tests/opt/long/fs/80.solaris-boot/sparc/solaris/t1000-simple-a
tomic CHANGED!
*
build/ARM/tests/opt/long/fs/10.linux-boot/arm/linux/realview-minor-dual
CHANGED!
On Nov. 6, 2014, 7:48 p.m., Cagdas Dirik wrote:
This patch seems to be broken for X86 when restoring from checkpoints. A
sample test crashes with segmentation fault. Here are the steps:
0. Sample test program does int array manipulation and creates a checkpoint
before computation.
On Nov. 6, 2014, 7:48 p.m., Cagdas Dirik wrote:
This patch seems to be broken for X86 when restoring from checkpoints. A
sample test crashes with segmentation fault. Here are the steps:
0. Sample test program does int array manipulation and creates a checkpoint
before computation.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2468/#review5448
---
Ship it!
the o3 change seems fine. . someone more familiar with ruby
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2474/#review5450
---
Ship it!
Ship It!
- Ali Saidi
On Nov. 10, 2014, 5:20 p.m., Andrew
changeset d1dce0b728b6 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=d1dce0b728b6
description:
arm: Fix timing wakeup with LLSC
diffstat:
src/cpu/simple/timing.cc | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diffs (29 lines):
diff -r
What compiler and version are you using?
Ali
On 11/17/14, 2:37 PM, Urmish Ajit Thakker via gem5-dev
gem5-dev@gem5.org wrote:
Hi,
I pulled up the latest copy of gem5 and got the following error while
building gem5.fast.
build/ARM/proto/protoio.fo (symbol from plugin): warning: memset used
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2513/#review5461
---
This will break compilation on non-linux platforms, so if we need
Looking at the code it looks like it would be possible for there to be 12
bytes in the socket, so the read will return less that 12 bytes (because
you got very unlucky and the bytes were split across two packets).
Looking at the code fixing that assumption will be a bit of a pain.
Ali
On
daystrom is very low on ram at the moment with the various services we’re
running. We have a new machine that has substantially more ram that we’ll be
switching to in the near term which should address the issue. For the moment
I’ve restarted tomcat and it seems to be working.
Ali
On Nov 28,
There are functions that correspond to this functionality although they’re
poorly named for the purpose, but memWriteback() - beginning of KVM
simulation; memInvalidate - end of KVM simulation. Another option would be to
check for the memory time atomic_noncaching which I believe only KVM uses.
On Nov 26, 2014, at 12:11 PM, Steve Reinhardt via gem5-dev gem5-dev@gem5.org
wrote:
On Wed, Nov 26, 2014 at 4:30 AM, Gabe Black via gem5-dev gem5-dev@gem5.org
wrote:
Just to make sure we're all on the same page, I removed the spaces here
because these are default values for arguments.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2521/#review5561
---
Ship it!
Ship It!
- Ali Saidi
On Nov. 22, 2014, 1:36 p.m., Gabe
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2517/#review5562
---
Ship it!
Ship It!
- Ali Saidi
On Nov. 22, 2014, 11:39 a.m., Gabe
On Nov. 25, 2014, 10:02 p.m., Nilay Vaish wrote:
configs/common/Options.py, line 155
http://reviews.gem5.org/r/2516/diff/1/?file=42704#file42704line155
Can you explain why we need this separate option for restoring from a
checkpoint taken using the take-simpoint-checkpoints?
The
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2548/#review5616
---
Ship it!
Ship It!
- Ali Saidi
On Dec. 3, 2014, 7:10 p.m., mike upton
Hi Gabe/Steve,
As Steve mentioned I¹ve been working on a new take on the regression
system in my spare-time.
I want to get it a bit more complete before I show it to the world, but
some of the goals I set out with align with yours.
In particular I¹m targeting the following:
(1) Success/Failure
On Dec. 4, 2014, 3:03 p.m., Nilay Vaish wrote:
src/sim/syscall_emul.hh, line 201
http://reviews.gem5.org/r/2548/diff/1/?file=42865#file42865line201
How will the compiler choose between the two versions of unlinkFunc? I
think we should either drop the default argument or drop the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2554/#review5639
---
Ship it!
Ship It!
- Ali Saidi
On Dec. 5, 2014, 10 a.m., Gabe Black
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2555/#review5640
---
Ship it!
src/base/remote_gdb.hh
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2556/#review5641
---
Ship it!
looks like a substantial improvement... visually seems fine
I think it’s fine that a device wants to do this, I’d just like it to use an
thin interface on the System object as a matter of clean interfaces in the
object hierarchy, so unrelated objects don’t have to know about each other.
Ali
On Dec 3, 2014, at 11:54 AM, Gabe Black via gem5-dev
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2558/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2559/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2560/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2561/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2562/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2563/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
The in-order cpu model is deprecated and will soon be removed from the tree. Id
you'd like an in order cpu model use the minor cpu model which supports ARM.
Ali
Sent from my ARM powered mobile device
On Dec 17, 2014, at 2:18 PM, Anastasiia via gem5-dev gem5-dev@gem5.org
wrote:
Hi,
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2519/#review5700
---
Ship it!
seems fine to me, although I can't say I know the code well
-
1 - 100 of 114 matches
Mail list logo
