Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11992 ) Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: actualize both GSUP_SM_RP_{DA|OA}

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12304 ) Change subject: library/GSUP_Types.ttcn: actualize both GSUP_SM_RP_{DA|OA} .. Patch Set 1: Code-Review+1 Looks like you know what you're

Change in osmo-sysmon[master]: ctrl: make config structure public

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12316 ) Change subject: ctrl: make config structure public .. Patch Set 1: Feels like this patch wouldn't be needed if you stored a copy

Change in osmo-sysmon[master]: ctrl: log host/port on errors

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12318 ) Change subject: ctrl: log host/port on errors .. Patch Set 1: > What would be the right approach to make host:port available for logg

Change in osmo-sysmon[master]: Use absolute path for default config

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12319 ) Change subject: Use absolute path for default config .. Patch Set 1: > Login shell has already been added through a script, so no is

Change in osmocom-bb[master]: mobile: Use new VTY telnet API to allow binding to random port

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12326 ) Change subject: mobile: Use new VTY telnet API to allow binding to random port .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: vty: Introduce telnet_init_default and make vty port configurable

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12321 ) Change subject: vty: Introduce telnet_init_default and make vty port configurable .. Patch Set 1: Code-Review+1 (1 comment) https

Change in osmo-msc[master]: Store subscriber's cell identity

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11746 ) Change subject: Store subscriber's cell identity .. Patch Set 3: Code-Review+1 I don't see any harm from this but it would be nice

Change in osmo-msc[master]: Store subscriber's cell identity

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11746 ) Change subject: Store subscriber's cell identity .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11746/2/src/libmsc

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

2018-12-14 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11069 ) Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages .. Patch Set 11: Code-Review+1 (3 comments) https://gerrit.osmocom.org

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

2018-12-14 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11751 ) Change subject: GSUP/SMS: introduce READY-FOR-SM message .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/11751/6/src/gsm

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

2018-12-14 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11751 ) Change subject: GSUP/SMS: introduce READY-FOR-SM message .. Patch Set 6: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11751

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

2018-12-14 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 5: (3 comments) https://gerrit.osmocom.org/#/c

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document READY-FOR-SM message

2018-12-14 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11837 ) Change subject: chapters/gsup.adoc: document READY-FOR-SM message .. Patch Set 5: Code-Review+1 (1 comment) https://gerrit.osmocom.org

Change in osmo-hlr[master]: gsupclient: add osmo_gsup_msg_enc_send()

2018-12-14 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11989 ) Change subject: gsupclient: add osmo_gsup_msg_enc_send() .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-msc[master]: msc_vty.c: configurable retrieval of IMEI, IMEISV

2018-12-14 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12302 ) Change subject: msc_vty.c: configurable retrieval of IMEI, IMEISV .. Patch Set 1: > Patch Set 1: > > (osmotestvty.py run

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-14 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12243/3/src

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

2018-12-13 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12242 ) Change subject: remove pointless declaration of struct gsm_network .. Patch Set 2: > Patch Set 2: > > Good, but now commi

Change in osmo-msc[master]: require 'ipa-name' option to be set via config file

2018-12-13 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12293 Change subject: require 'ipa-name' option to be set via config file .. require 'ipa-name' option to be set via config file The 'ipa-name

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-13 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 3: For reasons I outlined above, patch set 3 adds

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-13 Thread Stefan Sperling
https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-13 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 2: > Patch Set 2: > > > They can be left a

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 2: I forgot one important point: There are routes which

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 2: > Patch Set 2: Code-Review-1 > > Some people

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-12 Thread Stefan Sperling
, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12243/1/src

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 1: > Patch Set 1: > > actually, the sam

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

2018-12-12 Thread Stefan Sperling
: Ib4151afa5bff01e63b462cca517fb60ac0503759 Gerrit-Change-Number: 12242 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Stefan Sperling

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

2018-12-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12242 ) Change subject: remove pointless declaration of struct gsm_network .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12242/1

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-12 Thread Stefan Sperling
Stefan Sperling has abandoned this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Abandoned Fair enough. I've made my point. -- To view, visit https

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-11 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12243 Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. make gsup ipa name configurable in osmo-sgsn.cfg Add a 'ipa-name' VTY

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

2018-12-11 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12242 Change subject: remove pointless declaration of struct gsm_network .. remove pointless declaration of struct gsm_network Stop passing

Change in libosmocore[master]: port rest octets encoding code from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10189 ) Change subject: port rest octets encoding code from osmo-bsc .. Patch Set 5: Marking as WIP until we get a written statement by Jolly

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 7: Marked as WIP until we get a written statement by Jolly

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 7: Please don't merge this yet. There has been no written

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
: Stefan Sperling Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Holger Freyther

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 6: (3 comments) https://gerrit.osmocom.org/#/c/10185/6/tests

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-11 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12177 ) Change subject: make gsup ipa name configurable in osmo-msc.cfg .. make gsup ipa name configurable in osmo-msc.cfg Add a 'ipa

Change in osmo-msc[master]: provide software version information to gsup peer

2018-12-11 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12178 ) Change subject: provide software version information to gsup peer .. provide software version information to gsup peer Provide

Change in osmo-bsc[master]: trigger acc ramping based on trx rf-locked state

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/7732 ) Change subject: trigger acc ramping based on trx rf-locked state .. Patch Set 4: (4 comments) https://gerrit.osmocom.org/#/c/7732/1/src

Change in libosmocore[master]: port rest octets encoding code from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10189 ) Change subject: port rest octets encoding code from osmo-bsc .. Patch Set 3: > Patch Set 3: > > has anything changed about the

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
: 10185 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Holger Freyther

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 5: (3 comments) https://gerrit.osmocom.org/#/c/10185/5/src

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-11 Thread Stefan Sperling
, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317d6c59f77e92fbb2b875a83dc0ec2fa5cb6006 Gerrit-Change-Number: 12177 Gerrit-PatchSet: 8 Gerrit-Owner: Stefan Sperling Gerrit

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12177 ) Change subject: make gsup ipa name configurable in osmo-msc.cfg .. Patch Set 7: (2 comments) https://gerrit.osmocom.org/#/c/12177/6/src

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-11 Thread Stefan Sperling
, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317d6c59f77e92fbb2b875a83dc0ec2fa5cb6006 Gerrit-Change-Number: 12177 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Sperling Gerrit

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Holger Freyther

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11751 ) Change subject: GSUP/SMS: introduce READY-FOR-SM message .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12221 ) Change subject: Use explicit parameter for sgsn_auth_init() .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-bsc[master]: Add VTY option to avoid sending empty Full BCCH Info for disabled SI

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12133 ) Change subject: Add VTY option to avoid sending empty Full BCCH Info for disabled SI .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12236 ) Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI .. Patch Set 1: Code-Review+1 (1 comment) ht

Change in osmo-msc[master]: tweak comment to indicate sub_pres_vlr fsm as dead code

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12234 ) Change subject: tweak comment to indicate sub_pres_vlr fsm as dead code .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-msc[master]: LU: do not always invoke sub_pres_vlr_fsm_start()

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12233 ) Change subject: LU: do not always invoke sub_pres_vlr_fsm_start() .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-msc[master]: detach cancelled subscribers from VLR

2018-12-11 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12232 ) Change subject: detach cancelled subscribers from VLR .. detach cancelled subscribers from VLR When a subscriber is cancelled

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12227 ) Change subject: ACL: integrate sanitize check into sgsn_acl_* functions .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c

Change in osmo-sgsn[master]: Add tests for IMSI ACLs

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12226 ) Change subject: Add tests for IMSI ACLs .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c File

Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12221 ) Change subject: Use explicit parameter for sgsn_auth_init() .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12221/1/tests

Change in osmo-bsc[master]: set gscon FSM instances' log level to DEBUG

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12211 ) Change subject: set gscon FSM instances' log level to DEBUG .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-msc[master]: move ASS-COMPL MGCP handling out of a_iface_bssap.c

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12201 ) Change subject: move ASS-COMPL MGCP handling out of a_iface_bssap.c .. Patch Set 3: Code-Review+1 (1 comment) https

Change in osmo-bsc[master]: Add VTY option to avoid sending empty Full BCCH Info for disabled SI

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12133 ) Change subject: Add VTY option to avoid sending empty Full BCCH Info for disabled SI .. Patch Set 2: Code-Review+1 (4 comments) https

Change in osmo-ttcn3-hacks[master]: bsc: TC_chan_exhaustion: Send correct RA to alloc all different channels

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12215 ) Change subject: bsc: TC_chan_exhaustion: Send correct RA to alloc all different channels .. Patch Set 1: Code-Review+1 (1 comment

Change in osmo-msc[master]: drop gsm48 RR ciph mode compl from permitted initial messages

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12207 ) Change subject: drop gsm48 RR ciph mode compl from permitted initial messages .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in libosmo-netif[master]: logging: fix typo in stream.c

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12217 ) Change subject: logging: fix typo in stream.c .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12217

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11827 ) Change subject: LCLS, TS 29.205: add GCR routines .. Patch Set 23: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11827/23

Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12020 ) Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding .. Patch Set 17: (1 comment) https://gerrit.osmocom.org/#/c/12020/13

Change in libosmocore[master]: stats.h: Fix build on MacOS

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12212 ) Change subject: stats.h: Fix build on MacOS .. Patch Set 1: Code-Review+1 Oooohh! a non-Linux platform! :) -- To view, visit https

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 4: Please don't merge this before Harald has had a chance

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/12228/3/src

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
: newpatchset Gerrit-Change-Id: I2f18b5ddc9b4b8e1174c6dea71cddf1c8d2230df Gerrit-Change-Number: 12228 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling

Change in osmo-msc[master]: detach cancelled subscribers from VLR

2018-12-10 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12232 Change subject: detach cancelled subscribers from VLR .. detach cancelled subscribers from VLR When a subscriber is cancelled, fake

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12228/3/src

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12228/3/src

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Gerrit-Change-Id: I2f18b5ddc9b4b8e1174c6dea71cddf1c8d2230df Gerrit-Change-Number: 12228 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Pau Espin Pedrol

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12228/2/src

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12228/2/src

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-10 Thread Stefan Sperling
, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317d6c59f77e92fbb2b875a83dc0ec2fa5cb6006 Gerrit-Change-Number: 12177 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Sperling Gerrit

Change in osmo-hlr[master]: display last location update timestamp in vty

2018-12-10 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12202 ) Change subject: display last location update timestamp in vty .. display last location update timestamp in vty Read

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
-Change-Id: I2f18b5ddc9b4b8e1174c6dea71cddf1c8d2230df Gerrit-Change-Number: 12228 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-hlr[master]: disable recording of LU timestamps by default

2018-12-10 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12228 Change subject: disable recording of LU timestamps by default .. disable recording of LU timestamps by default Add VTY commands which

Change in osmo-hlr[master]: display last location update timestamp in vty

2018-12-10 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12202 ) Change subject: display last location update timestamp in vty .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/12202/1/src

Change in osmo-hlr[master]: display last location update timestamp in vty

2018-12-10 Thread Stefan Sperling
Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie180c434f02ffec0d4b2f651a73258a8126b2e1a Gerrit-Change-Number: 12202 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Ger

Change in osmo-msc[master]: ASS-COMPL: do not fire Sec Mode Compl event

2018-12-07 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12200 ) Change subject: ASS-COMPL: do not fire Sec Mode Compl event .. Patch Set 1: Code-Review+1 The log message could provide a bit more

Change in osmocom-bb[master]: trx_toolkit: introduce logging configuration arguments

2018-12-07 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12192 ) Change subject: trx_toolkit: introduce logging configuration arguments .. Patch Set 2: Code-Review+1 (2 comments) https

Change in osmocom-bb[master]: trx_toolkit: merge copyright.py into app_common.py

2018-12-07 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12193 ) Change subject: trx_toolkit: merge copyright.py into app_common.py .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: MSC_Test: Test what happens when Paging for SMS is unanswered

2018-12-07 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11897 ) Change subject: MSC_Test: Test what happens when Paging for SMS is unanswered .. Patch Set 7: Code-Review+1 -- To view, visit https

Change in osmo-hlr[master]: add whitespace around PRId64 constants

2018-12-07 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12206 Change subject: add whitespace around PRId64 constants .. add whitespace around PRId64 constants Avoid string concatenations without

Change in osmo-hlr[master]: display last location update timestamp in vty

2018-12-07 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12202 Change subject: display last location update timestamp in vty .. display last location update timestamp in vty Read the subscriber's last

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-07 Thread Stefan Sperling
mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317d6c59f77e92fbb2b875a83dc0ec2fa5cb6006 Gerrit-Change-Number: 12177 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-07 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12177 ) Change subject: make gsup ipa name configurable in osmo-msc.cfg .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12177/3

Change in osmo-hlr[master]: store a timestamp of the last location update seen from a subscriber

2018-12-07 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12121 ) Change subject: store a timestamp of the last location update seen from a subscriber .. store a timestamp of the last location

Change in osmo-hlr[master]: store a timestamp of the last location update seen from a subscriber

2018-12-07 Thread Stefan Sperling
ner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Neels Hofmeyr

Change in osmo-hlr[master]: store timestamp of last location update seen from subscriber

2018-12-07 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12121 ) Change subject: store timestamp of last location update seen from subscriber .. Patch Set 5: (4 comments) https://gerrit.osmocom.org

Change in osmo-msc[master]: provide software version information to gsup peer

2018-12-07 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12178 ) Change subject: provide software version information to gsup peer .. Patch Set 4: > Patch Set 4: Verified-1 > > Build Failed

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12177 ) Change subject: make gsup ipa name configurable in osmo-msc.cfg .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12177/2/src

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-06 Thread Stefan Sperling
mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317d6c59f77e92fbb2b875a83dc0ec2fa5cb6006 Gerrit-Change-Number: 12177 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins

Change in libosmocore[master]: gsm0408_test: test encoding and decoding Mobile Identity

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12151 ) Change subject: gsm0408_test: test encoding and decoding Mobile Identity .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: add osmo_bcd2str()

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12153 ) Change subject: add osmo_bcd2str() .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12153 To unsubscribe

Change in libosmocore[master]: gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12154 ) Change subject: gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: gsm48_mi_to_string(): guard against zero length output buffer

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12156 ) Change subject: gsm48_mi_to_string(): guard against zero length output buffer .. Patch Set 5: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: gsm48_generate_mid(): mask out ODD flag from mi_type

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12155 ) Change subject: gsm48_generate_mid(): mask out ODD flag from mi_type .. Patch Set 4: Code-Review+1 -- To view, visit https

<    1   2   3   4   5   6   7   8   9   10   >