Change in libosmocore[master]: port rest octets encoding code from osmo-bsc

2019-01-07 Thread Stefan Sperling
/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I47888965ab11bba1186c21987f1365c9270abeab Gerrit-Change-Number: 10189 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (1

Change in libosmocore[master]: port rest octets encoding code from osmo-bsc

2019-01-07 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10189 ) Change subject: port rest octets encoding code from osmo-bsc .. Patch Set 6: (2 comments) https://gerrit.osmocom.org/#/c/10189/6

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2019-01-07 Thread Stefan Sperling
Owner: Stefan Sperling Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Holger Freyther

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2019-01-07 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 8: (3 comments) https://gerrit.osmocom.org/#/c/10185/8

Change in libosmocore[master]: port rest octets encoding code from osmo-bsc

2018-12-30 Thread Stefan Sperling
/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I47888965ab11bba1186c21987f1365c9270abeab Gerrit-Change-Number: 10189 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (1

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-30 Thread Stefan Sperling
Owner: Stefan Sperling Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Holger Freyther

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-30 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 7: Licence change has been cleared. -- To view, visit https

Change in libosmocore[master]: port rest octets encoding code from osmo-bsc

2018-12-30 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10189 ) Change subject: port rest octets encoding code from osmo-bsc .. Patch Set 5: Licence change has been cleared. -- To view, visit https

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2018-12-29 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11504 ) Change subject: gsm0808: add BSSMAP Cell Identifier matching API .. Patch Set 4: https://gerrit.osmocom.org/#/c/osmo-msc/+/12446 depends

Change in osmo-msc[master]: add BSC/MSC neighbor VTY commands for inter-MSC HO

2018-12-29 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12446 ) Change subject: add BSC/MSC neighbor VTY commands for inter-MSC HO .. Patch Set 2: Build will of ocurse fail until

Change in osmo-msc[master]: add BSC/MSC neighbor VTY commands for inter-MSC HO

2018-12-29 Thread Stefan Sperling
Stefan Sperling has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/12446 ) Change subject: add BSC/MSC neighbor VTY commands for inter-MSC HO .. add BSC/MSC neighbor VTY commands for inter-MSC HO Allow

Change in osmo-msc[master]: add BSC/MSC neighbor VTY commands for inter-MSC HO

2018-12-29 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12446 Change subject: add BSC/MSC neighbor VTY commands for inter-MSC HO .. add BSC/MSC neighbor VTY commands for inter-MSC HO Allow

Change in osmo-ttcn3-hacks[master]: mgw: Tear down all RTP flows to avoid race condition on tear down

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12297 ) Change subject: mgw: Tear down all RTP flows to avoid race condition on tear down .. Patch Set 1: Code-Review+1 (1 comment) https

Change in osmo-mgw[master]: mgcp_client: make domain part of endpoint configurable

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12357 ) Change subject: mgcp_client: make domain part of endpoint configurable .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c

Change in libosmocore[master]: tests/gsm0808: use new msgb comparison API

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12271 ) Change subject: tests/gsm0808: use new msgb comparison API .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-20 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. make gsup ipa name configurable in osmo-sgsn.cfg Add a '

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 7: Code-Review+2 -- To view, visit https

Change in libosmo-sccp[master]: fix ipa_asp_fsm down state transition

2018-12-20 Thread Stefan Sperling
oject: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb8e7bd1c74a4b47080fe32ebe0161c503ead571 Gerrit-Change-Number: 12364 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Ho

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/12243/5/src

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-20 Thread Stefan Sperling
or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Sperling

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 6: (2 comments) https://gerrit.osmocom.org/#/c/12243/5

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-20 Thread Stefan Sperling
or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Sperling

Change in osmo-ttcn3-hacks[master]: wait for subscriber conn in TC_cipher_complete_with_invalid_cipher

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12346 ) Change subject: wait for subscriber conn in TC_cipher_complete_with_invalid_cipher .. Patch Set 1: > Patch Set 1: > > >

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-20 Thread Stefan Sperling
or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Sperling

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 4: > Patch Set 4: Code-Review-1 > > Please s

Change in osmo-msc[master]: vty cfg: move 'ipa-name' from 'msc' to 'hlr' section

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12387 ) Change subject: vty cfg: move 'ipa-name' from 'msc' to 'hlr' section .. Patch Set 1: Also please add thi

Change in osmo-msc[master]: vty cfg: move 'ipa-name' from 'msc' to 'hlr' section

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12387 ) Change subject: vty cfg: move 'ipa-name' from 'msc' to 'hlr' section .. Patch Set 1: Please update ex

Change in libosmo-sccp[master]: fix ipa_asp_fsm down state transition

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12364 ) Change subject: fix ipa_asp_fsm down state transition .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/12364/1/src

Change in osmo-msc[master]: libmsc/VTY: introduce kill-switch for routing SMS over GSUP

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11918 ) Change subject: libmsc/VTY: introduce kill-switch for routing SMS over GSUP .. Patch Set 8: Code-Review+1 -- To view, visit https

Change in osmo-msc[master]: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11920 ) Change subject: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP .. Patch Set 8: (3 comments) https://gerrit.osmocom.org/#/c/11920

Change in osmo-msc[master]: libmsc/gsm_04_11.c: forward MO SMS messages over GSUP

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11919 ) Change subject: libmsc/gsm_04_11.c: forward MO SMS messages over GSUP .. Patch Set 8: (1 comment) https://gerrit.osmocom.org/#/c/11919

Change in libosmocore[master]: LCLS: use proper types for value_string wrappers

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12367 ) Change subject: LCLS: use proper types for value_string wrappers .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: LCLS: fix LCLS-CONNECT-CONTROL encoder

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12376 ) Change subject: LCLS: fix LCLS-CONNECT-CONTROL encoder .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12376

Change in libosmocore[master]: LCLS: don't encode incorrect values

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12375 ) Change subject: LCLS: don't encode incorrect values .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/123

Change in osmo-bsc[master]: LCLS: use enum values instead of magic numbers

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12378 ) Change subject: LCLS: use enum values instead of magic numbers .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: LCLS: don't send invalid status in HO messages

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12377 ) Change subject: LCLS: don't send invalid status in HO messages .. Patch Set 5: Code-Review+1 -- To view, visit

Change in libosmocore[master]: tests/gsm0808: use new msgb comparison API

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12271 ) Change subject: tests/gsm0808: use new msgb comparison API .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c

Change in osmo-bsc[master]: LCLS: log config/control update

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12366 ) Change subject: LCLS: log config/control update .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12366 To

Change in osmo-ttcn3-hacks[master]: add a test for LU with invalid LAI

2018-12-20 Thread Stefan Sperling
it-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I676894358259b9cc0f973769ce552ba58a2a58a1 Gerrit-Change-Number: 12380 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Stefan Sperling

Change in osmo-ttcn3-hacks[master]: add a test for LU with invalid LAI

2018-12-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12380 ) Change subject: add a test for LU with invalid LAI .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12380/1/msc

Change in osmo-ttcn3-hacks[master]: add a test for LU with invalid LAI

2018-12-19 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12380 Change subject: add a test for LU with invalid LAI .. add a test for LU with invalid LAI Verify that the MSC rejects a location update

Change in libosmocore[master]: rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI

2018-12-19 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12374 Change subject: rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI .. rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI The name "LAI AN

Change in osmo-hlr[master]: gsupclient: introduce osmo_gsup_client_enc_send()

2018-12-19 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11989 ) Change subject: gsupclient: introduce osmo_gsup_client_enc_send() .. Patch Set 9: Code-Review+1 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error

2018-12-19 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12298 ) Change subject: MSC: adjust gsup log level to error .. Patch Set 1: Then perhaps the best course of action is to just leave things as

Change in osmo-msc[master]: MNCC: use log wrapper for call processing

2018-12-19 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12329 ) Change subject: MNCC: use log wrapper for call processing .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-hlr[master]: gsupclient: introduce osmo_gsup_client_enc_send()

2018-12-19 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11989 ) Change subject: gsupclient: introduce osmo_gsup_client_enc_send() .. Patch Set 7: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

2018-12-19 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12271 ) Change subject: Use msgb helper instead of local #define for debug print .. Patch Set 2: > Patch Set 2: > > > Ok, if there

Change in libosmo-sccp[master]: fix ipa_asp_fsm down state transition

2018-12-19 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12364 Change subject: fix ipa_asp_fsm down state transition .. fix ipa_asp_fsm down state transition Properly transition into IPA_ASP_S_DOWN

Change in osmo-msc[master]: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

2018-12-19 Thread Stefan Sperling
tefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Stefan Sperling

Change in osmo-msc[master]: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

2018-12-19 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12349 ) Change subject: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE .. Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c

Change in osmo-ttcn3-hacks[master]: wait for subscriber conn in TC_cipher_complete_with_invalid_cipher

2018-12-19 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12346 ) Change subject: wait for subscriber conn in TC_cipher_complete_with_invalid_cipher .. Patch Set 1: > Patch Set 1: Code-Review+1 >

Change in osmo-msc[master]: use vty->type instead of local variable

2018-12-18 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12353 Change subject: use vty->type instead of local variable .. use vty->type instead of local variable We can check if we're

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-18 Thread Stefan Sperling
iting mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer:

Change in osmocom-bb[master]: host/layer23: don't init SAP interface by default

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12350 ) Change subject: host/layer23: don't init SAP interface by default .. Patch Set 1: > Patch Set 1: > > > There is

Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error

2018-12-18 Thread Stefan Sperling
Stefan Sperling has removed a vote on this change. Change subject: MSC: adjust gsup log level to error .. Removed Code-Review+1 by Stefan Sperling -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help

Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12298 ) Change subject: MSC: adjust gsup log level to error .. Patch Set 1: Code-Review+1 > Patch Set 1: > > I am not sure if this

Change in osmo-bsc[master]: LCLS: update parameter representation

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11820 ) Change subject: LCLS: update parameter representation .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11820

Change in libosmocore[master]: add to osmo_sock_get_name*() API

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12268 ) Change subject: add to osmo_sock_get_name*() API .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12268/2/src/socket.c File

Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12343 ) Change subject: msc_vty: also show IMEI and IMEISV .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12343/2/src

Change in osmo-msc[master]: msc_vty: display current RAN type

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12345 ) Change subject: msc_vty: display current RAN type .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12345 To

Change in osmo-msc[master]: msc_vty: display subscriber flags

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12344 ) Change subject: msc_vty: display subscriber flags .. Patch Set 2: -Code-Review -- To view, visit https://gerrit.osmocom.org/12344 To

Change in osmo-msc[master]: msc_vty: display subscriber flags

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12344 ) Change subject: msc_vty: display subscriber flags .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12344/2/src

Change in osmo-bts[master]: sysmobts_mgr: Add support for gpsd < 2.96

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12340 ) Change subject: sysmobts_mgr: Add support for gpsd < 2.96 .. Patch Set 4: Code-Review+1 Silly of them to break the API without backwa

Change in osmo-bts[master]: sysmobts_mgr: Prepare code for gpsd < 2.96 support

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12339 ) Change subject: sysmobts_mgr: Prepare code for gpsd < 2.96 support .. Patch Set 2: Code-Review+1 -- To view, visit ht

Change in osmocom-bb[master]: host/layer23: don't init SAP interface by default

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12350 ) Change subject: host/layer23: don't init SAP interface by default .. Patch Set 1: Code-Review+1 There is code which calls sap_open

Change in osmocom-bb[master]: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE()

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12351 ) Change subject: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE() .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-msc[master]: VLR: drop unused struct members

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12335 To

Change in osmo-msc[master]: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

2018-12-18 Thread Stefan Sperling
49 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3260bee43cfe135ebfc33c13aee3c4ba43466c81 Gerrit-Change-Number: 12349 Gerrit-PatchSet: 2 Gerrit-Owner: S

Change in osmo-msc[master]: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

2018-12-18 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12349 Change subject: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE .. improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

Change in osmo-ttcn3-hacks[master]: add three tests for CIPHER MODE COMPLETE without algo

2018-12-18 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12347 Change subject: add three tests for CIPHER MODE COMPLETE without algo .. add three tests for CIPHER MODE COMPLETE without algo Add three

Change in osmo-ttcn3-hacks[master]: wait for subscriber conn in TC_cipher_complete_with_invalid_cipher

2018-12-18 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12346 Change subject: wait for subscriber conn in TC_cipher_complete_with_invalid_cipher .. wait for subscriber conn in

Change in osmo-msc[master]: VLR: drop unused struct members

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12335/3/include/osmocom/msc

Change in osmo-msc[master]: Use proper type for tch_rtp_connect() parameter

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12330 ) Change subject: Use proper type for tch_rtp_connect() parameter .. Patch Set 2: Code-Review+1 Yeah ok. -- To view, visit https

Change in osmo-msc[master]: MNCC: use log wrapper for call processing

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12329 ) Change subject: MNCC: use log wrapper for call processing .. Patch Set 2: Yep, looks fine. -- To view, visit https

Change in osmo-msc[master]: Remove redundancy in LAC processing

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12338 ) Change subject: Remove redundancy in LAC processing .. Patch Set 3: Code-Review+1 Yes makes sense. -- To view, visit https

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11069 ) Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages .. Patch Set 12: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11751 ) Change subject: GSUP/SMS: introduce READY-FOR-SM message .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/11751/6/src/gsm

Change in libosmocore[master]: add/clean big-endian packed structs (struct_endianess.py)

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11787 ) Change subject: add/clean big-endian packed structs (struct_endianess.py) .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in osmo-msc[master]: VLR tests: add logging macro with explicit value description

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12336 ) Change subject: VLR tests: add logging macro with explicit value description .. Patch Set 1: Code-Review+1 (1 comment) https

Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12337 ) Change subject: VLR tests: avoid leaking LAC access details .. Patch Set 1: Code-Review+1 (1 comment) Yes I agree this is better

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 7: Code-Review+1 -- To view, visit https

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document READY-FOR-SM message

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11837 ) Change subject: chapters/gsup.adoc: document READY-FOR-SM message .. Patch Set 8: Code-Review+1 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: add MSC test for an invalid CIPHER MODE COMPLETE command

2018-12-18 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12332 ) Change subject: add MSC test for an invalid CIPHER MODE COMPLETE command .. add MSC test for an invalid CIPHER MODE COMPLETE

Change in osmo-ttcn3-hacks[master]: add MSC test for an invalid CIPHER MODE COMPLETE command

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12332 ) Change subject: add MSC test for an invalid CIPHER MODE COMPLETE command .. Patch Set 2: Code-Review+2 > Patch Set 2: Code-Revie

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12243/3/src

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 3: > Not necessarily. I think I already described it.

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

2018-12-17 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12242 ) Change subject: remove pointless declaration of struct gsm_network .. remove pointless declaration of struct gsm_network We were

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 3: > I was just replying that I still lack a "no

Change in osmo-ttcn3-hacks[master]: add MSC test for an invalid CIPHER MODE COMPLETE command

2018-12-17 Thread Stefan Sperling
er: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling

Change in osmo-ttcn3-hacks[master]: add MSC test for an invalid CIPHER MODE COMPLETE command

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12332 ) Change subject: add MSC test for an invalid CIPHER MODE COMPLETE command .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12243/3/src

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 3: > Patch Set 3: > > > I don't see a be

Change in osmo-ttcn3-hacks[master]: add MSC test for an invalid CIPHER MODE COMPLETE command

2018-12-17 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12332 Change subject: add MSC test for an invalid CIPHER MODE COMPLETE command .. add MSC test for an invalid CIPHER MODE COMPLETE command Add

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12236 ) Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI .. Patch Set 2: Code-Review+1 -- To view, visit ht

Change in libosmocore[master]: add/clean big-endian packed structs (struct_endianess.py)

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11787 ) Change subject: add/clean big-endian packed structs (struct_endianess.py) .. Patch Set 3: Code-Review+1 I agree with Max: More

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document READY-FOR-SM message

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11837 ) Change subject: chapters/gsup.adoc: document READY-FOR-SM message .. Patch Set 7: Code-Review+1 Looks good to me now. -- To view

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 6: Code-Review+1 -- To view, visit https

Change in osmo-hlr[master]: gsupclient: add osmo_gsup_msg_enc_send()

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11989 ) Change subject: gsupclient: add osmo_gsup_msg_enc_send() .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-msc[master]: libmsc/gsm_04_80.c: HACK: reimplement GSM 04.08 RELEASE COMPLETE

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11991 ) Change subject: libmsc/gsm_04_80.c: HACK: reimplement GSM 04.08 RELEASE COMPLETE .. Patch Set 4: Code-Review+1 I also think updating

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mo_smma for MO SMMA over GSUP

2018-12-17 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11776 ) Change subject: MSC_Tests.ttcn: introduce TC_gsup_mo_smma for MO SMMA over GSUP .. Patch Set 5: Code-Review+1 (2 comments) https

  1   2   3   4   5   6   7   8   9   10   >