On Tue, Sep 20, 2011 at 10:18 PM, S. H. Lee smil...@korea.ac.kr wrote:
Hi,
I have a SV7-2186 server with a S5500WBV motherboard and a Xeon processor.
Its power supply is TDPS-600EB from DELTA.
I am planning to develop a software checking the power consumption of a
server.
According to
not sure what I could come up
with. Hmm if you check BMC/SP web interface,
can you see readings of sensors there? Can you see readings of power
supply there?
I'm sorry I was not much of help.
Z.
-Original Message-
From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com]
Sent: Wednesday
Hi,
I'm wondering whether it was just me, because I was unable to build
IPMItool from CVS
nor I've found how-to do it(on the other hand, I didn't give searching
too much time).
I'm not even sure whether there is some how-to. Well, there is now.
1] check-out IPMItool from CVS
2] patch
Hey,
On Thu, Oct 20, 2011 at 5:19 AM, Harshad Prabhu (hprabhu)
hpra...@cisco.com wrote:
Hi All
There are lot of changes from 1.8.11 release (which was released in
02/2009) to what is available in CVS currently.
indeed. And check bugs and feature requests at SF.net.
When is the plan for
On Mon, Oct 17, 2011 at 5:43 PM, Harshad Prabhu (hprabhu)
hpra...@cisco.com wrote:
[...]
Hi Zdenek,
Sorry could not reply to your previous mail.
Yes when I added the patch, had used the same way as it was already there in
the file.
Please add the patch contents and make the changes for
Hello,
as of now, it is possible to cause uint8_t overflows via parameters to ipmitool.
Example code to blame from 'lib/ipmi_main.c':
~~~ SNIP ~~~
case 't':
target_addr = (uint8_t)strtol(optarg, NULL, 0);
break;
~~~ SNIP ~~~
No check is being made whether only numerical input
, RC 2 for overflow/invalid input, RC 3 when input
fits long, yet is out of range of uchar?
Z.
My $.02
Andy
-Original Message-
From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com]
Sent: Monday, October 24, 2011 2:25 PM
To: ipmitool-devel
Subject: [Ipmitool-devel] multiple uint8_t
On Mon, Oct 24, 2011 at 8:25 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
[...]
Ok, thanks to Andy's comments, here goes version 2.
~~~ 'lib/helper.c' ~~~
#include limits.h
[...]
/* Desc: Convert array of chars into uint8_t and check for overflows
* @str: array of chars to parse from
the output byte will be
sane/default.
- remove || arg_long 0 before return 2, since arg_long is unsigned and
this could generate a compile warning
Andy
-Original Message-
From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com]
Sent: Wednesday, October 26, 2011 3:09 PM
To: ipmitool
On Mon, Oct 24, 2011 at 5:53 AM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
[...]
1] check-out IPMItool from CVS
2] patch configure.in and Makefile.am
3] $ libtoolize --force ;
4] $ aclocal ;
5] $ touch NEWS; which is required by $ automake;, yet missing!!!
6] $ automake --force-missing
Styblik [mailto:zdenek.styb...@gmail.com]
Sent: Thursday, November 10, 2011 9:07 AM
To: ipmitool-devel
Subject: Re: [Ipmitool-devel] How-to build IPMItool from CVS
On Mon, Oct 24, 2011 at 5:53 AM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
[...]
1] check-out IPMItool from CVS
2] patch
On Thu, Nov 10, 2011 at 4:48 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
Hi,
I'm thinking what would be the best way to get rid of atoi() in
'lib/ipmi_main.c' which is used for parsing of 'd', 'p' and 'C'
arguments.
It seems to me to be a good idea to implement function in
'lib
On Tue, Nov 22, 2011 at 5:44 AM, Harshad Prabhu (hprabhu)
hpra...@cisco.com wrote:
Hi
We have provided 2 patches but there has been no response from owners
Hello,
owners? Do you mean designated maintainers of SF.net project, right?
when will this be included in CVS. Our customers are
On Tue, Nov 22, 2011 at 11:04 AM, Garrett Cooper yaneg...@gmail.com wrote:
[...]
when will this be included in CVS. Our customers are waiting for this
patch to be approved upstream. And this has become very very important.
Customers? Customers of Cisco? Eh. Not the best argument I would use
Hey,
I'm looking at 'lib/ipmi_chassis.c' and there seems to be an unused
variable on line 1143, or am I just wrong and blind?
Part of the code in question is pasted bellow. Variable in question is
i. And op resp. struct options has field i. Thus I assume
variable i is not used anywhere.
~~~
Thanks for confirmation. I've removed it from the code and logged it.
I haven't done ``-Wall'' yet.
Z.
On Wed, Dec 7, 2011 at 6:23 PM, Harshad Prabhu (hprabhu)
hpra...@cisco.com wrote:
-Original Message-
From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com]
Sent: Wednesday, December
On Mon, Dec 12, 2011 at 1:51 PM, Nandisha H. M nandi...@gmail.com wrote:
Thanks for the information Zdenek.
However, if you search this mailing list couple weeks back, you will
find patch from Harshad Prabhu which implements this feature. I think
you should be safe with this patch and
On Mon, Dec 12, 2011 at 2:16 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
On Mon, Dec 12, 2011 at 1:51 PM, Nandisha H. M nandi...@gmail.com wrote:
Thanks for the information Zdenek.
However, if you search this mailing list couple weeks back, you will
find patch from Harshad Prabhu which
On Wed, Dec 14, 2011 at 4:39 PM, Harshad Prabhu (hprabhu)
hpra...@cisco.com wrote:
Hi Zdenek,
Please find my comments below.
[...]
That would be good if we can add some default timeout also if the user has
not given any timeout.
Else we will always be blocked if there is no response on
On Thu, Dec 15, 2011 at 3:29 PM, Corey Minyard tcminy...@gmail.com wrote:
[...]
~~~ 'src/plugins/open/open.c' ~~~
if (select(intf-fd+1,rset, NULL, NULL, NULL) 0) {
lperror(LOG_ERR, I/O Error);
return NULL;
}
~~~ 'src/plugins/open/open.c' ~~~
Using
On Thu, Dec 15, 2011 at 5:33 AM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
[...]
That would be good if we can add some default timeout also if the user has
not given any timeout.
Else we will always be blocked if there is no response on that fd if the
user has not provided.
Like
Hello,
as subject suggests, my question is why ipmitool doesn't display Record ID
anywhere in its output. Or have I only failed to look more thoroughly?
The only thing it displays is Logical Number, if that's correct term,
eg. ``Sensor ID: T_AMB (0xa5)''
which is not the same thing.
Why am I
to extend output of # ipmitool sdr -v
list all; rather than
extending # ipmitool sdr list; as I've mentioned earlier?
I'm looking for a way which would be acceptable(the current one doesn't seem so
to me).
Thanks,
Z.
On Tue, Jan 3, 2012 at 10:13 AM, Zdenek Styblik zdenek.styb...@gmail.com
wrote
(0x1)
Entity ID : 3.1
snip
Al
Hank
JBlade
On Tue, Jan 3, 2012 at 10:13 AM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
Hello,
as subject suggests, my question
Hi all,
as I was checking CVE-2011-4339
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2011-4339
I've noticed other things as well.
#1 As for CVE in question, I think it can be solved by using umask(022).
#2 ipmievd shouldn't start at all if it is unable to create PID file.
However, such
On Thu, Jan 19, 2012 at 3:05 PM, Adhithacholan
adhithacho...@kodiaknetworks.com wrote:
[root@localhost kodiak]# ipmitool event 1
Sending SAMPLE event: Temperature - Upper Critical - Going High
0 | Pre-Init Time-stamp | Temperature #0x30 | Upper Critical going high
Platform Event
On Thu, Jan 19, 2012 at 3:09 PM, Johannes Rothe
johannes.ro...@unbelievable-machine.com wrote:
[...]
Did anyone experience similar behaviour before and could help us out
with some hints what we could check / look out for?
Thanks and regards,
Johannes Rothe.
Hello,
on side note, I remember
Hello all,
attached is proposal for input validation which is purely numeric. It
introduces new functions in 'lib/helper.c' to handle conversion of
input and checks around. Main focus is on two functions - str2long()
and str2ulong(). The rest which, I'm sure is going to grow, is using
these two
On Mon, Jan 16, 2012 at 4:27 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
Hi all,
as I was checking CVE-2011-4339
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2011-4339
I've noticed other things as well.
#1 As for CVE in question, I think it can be solved by using umask(022
Hello folks,
I'm wondering why are these functions, ipmi_lan_stats_get() and
ipmi_lan_stats_clear(), in 'lib/ipmi_lanp.c' returning 0 on, what
seems to me, errors?
Is there some specific reason I'm missing?
Code in question:
~~~ SNIP ~~~
rsp = intf-sendrecv(intf, req);
if (rsp ==
On Wed, Feb 8, 2012 at 5:37 PM, Jim Mank jm...@hp.com wrote:
All,
Hey,
I would like to start contributing to the ipmitool project and as a
initial task I thought I would resolve the open bug associated with
ipmitool's inability to display percentage units correctly
On Thu, Feb 9, 2012 at 11:06 PM, carl brunning ca...@cblinux.co.uk wrote:
I just want to know if the –P for Password is missing or broken
Hello.
What version of ipmitool?
What's the source aka where did it come from aka where did you get it?
Is it specific build eg. without LAN/LAN+
Hi,
it looks fine by me. One thing though. Since it returns pointer to
static char, should it be:
static char *
ipmi_sdr_get_unit_string(uint8_t pct, uint8_t type, uint8_t base,
uint8_t modifier)
{ ... }
as well?
Regards,
Z.
On Thu, Feb 9, 2012 at 10:01 PM, Jim Mank jm...@hp.com wrote:
[...]
this option.
What does configure say in the end summary?
Z.
-Original Message-
From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com]
Sent: 10 February 2012 05:12
To: carl brunning
Cc: ipmitool-devel@lists.sourceforge.net
Subject: Re: [Ipmitool-devel] -P switch missing
On Thu, Feb 9
Hello,
wouldn't it make more sense to ask person whom has merged patches into CVS?
Also, if these patches are already merged in, would it be possible to
close feature requests in question at SF.net?
Thanks and regards,
Z.
On Mon, Feb 13, 2012 at 5:48 AM, srinivas_g_go...@dell.com wrote:
Not
Hello,
could somebody, please, ACK or NAK attached patch.
Thanks,
Z.
--
Zdenek Styblik
email: zdenek.styb...@gmail.com
jabber: zdenek.styb...@gmail.com
@@ -447,7 +459,7 @@
uint8_t chan, uint8_t * ival)
{
struct lan_param *lp;
- uint8_t interval;
+ uint8_t interval = 0;
int rc = 0
{
snprintf(unitstr, sizeof (unitstr), %s%s,
pctstr, unit_desc[base]);
}
break;
}
return unitstr;
}
-- Jim Mankovich | jm...@hp.com --
On 2/9/2012 10:18 PM, Zdenek Styblik wrote:
Hi,
it looks fine by me. One thing though. Since it returns pointer
On Thu, Feb 16, 2012 at 3:21 PM, Andy Cress andy.cr...@us.kontron.com wrote:
Zdenek,
RE: 'lib/ipmi_main.c'
I presume '-t' should accept either FQDN or IP address, thus lines
above are wrong, aren't they? Or is it a hex as in case of '-m'?
The -t option supplies an IPMI slave address (one
On Fri, Aug 3, 2012 at 3:10 PM, Jan Safranek jsafr...@redhat.com wrote:
Hi,
I've encountered some problems with running ipmievd under systemd - it does
not
understand the way how ipmievd forks and times out when starting the service.
This patch adds 'Type=notify' support to ipmievd and
On Wed, Aug 8, 2012 at 3:19 AM, Carson Gaspar
carson+ipmit...@taltos.org wrote:
No - it looks like lib/ipmi_mc.c has been gcc only for a long time now :-(
lib/ipmi_mc.c hasn't been touched for 2 years and 3 months.
ipmitool-1.8.11 is out for 3 years and 6 months. Actually, which
version of
On Wed, Aug 8, 2012 at 8:29 AM, Jan Safranek jsafr...@redhat.com wrote:
On 08/07/2012 10:21 PM, Zdenek Styblik wrote:
On Fri, Aug 3, 2012 at 3:10 PM, Jan Safranek jsafr...@redhat.com wrote:
Hi,
I've encountered some problems with running ipmievd under systemd - it does
not
understand
On Mon, Sep 10, 2012 at 3:37 PM, Steffen Grunewald
steffen.grunew...@aei.mpg.de wrote:
On Fri, Sep 07, 2012 at 08:02:32AM -0700, Andy Cress wrote:
Steffen,
Sounds like a firmware bug to me. Is there a later firmware version for
this board?
Nothing I'm aware of - as I said, those boxen are
On Mon, Sep 17, 2012 at 3:46 PM, dick.detwei...@emerson.com wrote:
Hello all,
I lead a group that uses ipmitool in server control software we write and
maintain. We have uncovered a curious issue with ipmitool's 'sel set time'
and 'exec' commands. This is using ipmitool version 1.8.10.
On Tue, Sep 18, 2012 at 1:21 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
On Mon, Sep 17, 2012 at 3:46 PM, dick.detwei...@emerson.com wrote:
Hello all,
I lead a group that uses ipmitool in server control software we write and
maintain. We have uncovered a curious issue
On Mon, Sep 24, 2012 at 11:06 PM, Jim Mankovich jm...@hp.com wrote:
All,
I've attached a fix for this based on what was reported in Bug #3568976 and I
verified
this fix resolved the reported problem.
If no one has an problem with this fix, I'll commit the change to TOB at the
end of this
On Tue, Sep 25, 2012 at 5:15 AM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
On Mon, Sep 24, 2012 at 11:06 PM, Jim Mankovich jm...@hp.com wrote:
All,
I've attached a fix for this based on what was reported in Bug #3568976 and
I verified
this fix resolved the reported problem.
If no one
On Tue, Sep 25, 2012 at 5:37 AM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
On Tue, Sep 25, 2012 at 5:15 AM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
On Mon, Sep 24, 2012 at 11:06 PM, Jim Mankovich jm...@hp.com wrote:
All,
I've attached a fix for this based on what was reported
On Wed, Sep 26, 2012 at 7:20 AM, Raghavan K kraghav...@gmail.com wrote:
[...]
But ncurses-5.5-24.20060715 ncurses-devel-5.5-24.20060715 are installed
in our linux machine (CentOS5).
Hello,
I've been there couple days ago and I dare to say I found it to be
stupid. What follows is list of
On Wed, Oct 10, 2012 at 11:40 AM, Raghavan K kraghav...@gmail.com wrote:
Hi All,
I try to upgrade the IPMC using ipmitool-1-8-11 lanplus. I have
found the ipmitool receives the packets in wrong order. The problem is
following:
The ipmitool receives “Initiate upgrade action”
On Mon, Oct 8, 2012 at 8:19 AM, charles_r...@dell.com wrote:
[...]
A startup script that can do these:
1. Set OS Name, Version, System Hostname in BMC
2. Get BMC URL/IP address from BMC
Would benefit:
1. users who would like to fetch hostname/OS Name/Version.
2. launch web-interface to
You're welcome. Please, explain problem right away next time ;) You'll
get more responses and faster conclusion.
As for issue you're experiencing. Please, try to instal readline and
termcap packages(lib and devel; I'm not familiar with exact names) as
well. I believe that's the problem you're
On Mon, Oct 29, 2012 at 9:02 AM, charles_r...@dell.com wrote:
[...]
Uploaded both script and config files to Feature Tracker.
http://sourceforge.net/tracker/?func=detailaid=3571445group_id=95200atid=610553
The only concern I have what happens if somebody doesn't have gettext
installed,
On Mon, Nov 5, 2012 at 5:26 PM, ^..^ zenf...@gmail.com wrote:
The lan command will set up a connection with the remote
system on anything but the help command (stats, get, etc.),
but will appear to the user that they simply typed the command
wrong and show the usage data.
(Tested with
On Tue, Nov 6, 2012 at 11:54 AM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
Hi,
attached is my take on mending of ipmi_fru_main(). Main objectives were:
* printf() - lprintf() where appropriate
* return codes
* clean up ipmi_fru_main() a bit
[...]
Hello,
attached is a second version
wrote:
Z,
Way too much bloat.
Put all that in one subroutine.
Andy
-Original Message-
From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com]
Sent: Thursday, November 15, 2012 1:03 AM
To: ipmitool-devel
Subject: [Ipmitool-devel] Code Review - ID: 3528347 - 'lib/ipmi_raw.c
Here we go. Final.
Z.
On Thu, Nov 15, 2012 at 10:21 PM, Andy Cress andy.cr...@us.kontron.com wrote:
Z,
Yes, that would allow all of the logic to be in the subroutine.
Andy
-Original Message-
From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com]
Sent: Thursday, November 15, 2012
On Fri, Nov 16, 2012 at 4:26 PM, charles_r...@dell.com wrote:
On 11/05/2012 05:00 PM, Rose, Charles wrote:
On 11/01/2012 11:23 PM, ^..^ wrote:
Agree w. Z; you could check for success/fail on that line. A few minor
additional comments (I
didn't run it, just looked at it, since I didn't
On Fri, Nov 16, 2012 at 4:26 PM, charles_r...@dell.com wrote:
On 11/05/2012 05:00 PM, Rose, Charles wrote:
On 11/01/2012 11:23 PM, ^..^ wrote:
Agree w. Z; you could check for success/fail on that line. A few minor
additional comments (I
didn't run it, just looked at it, since I didn't
On Mon, Nov 19, 2012 at 9:44 AM, charles_r...@dell.com wrote:
[...]
``# v1.8.12 plus patches are required for getsysinfo support''
what patches???
http://sourceforge.net/mailarchive/message.php?msg_id=29647222
I have added this URL to the comment.
Since the patches in question are already
On Mon, Nov 19, 2012 at 1:00 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
On Mon, Nov 19, 2012 at 11:02 AM, charles_r...@dell.com wrote:
On 11/19/2012 02:57 PM, Zdenek Styblik wrote:
On Mon, Nov 19, 2012 at 9:44 AM, charles_r...@dell.com wrote:
[...]
``# v1.8.12 plus patches
On Tue, Dec 4, 2012 at 1:44 PM, Ales Ledvinka aledv...@redhat.com wrote:
Hello,
I'd like to verify whether it's something with my setup or the sf side. I am
getting this:
Hi,
this seems to be SF.net issue. Please, remain calm and seated.
Regards,
Z.
http://ipmitool.cvs.sourceforge.net/viewvc/ipmitool/?view=tar
Z.
- Original Message -
From: Zdenek Styblik zdenek.styb...@gmail.com
To: Ales Ledvinka aledv...@redhat.com
Cc: ipmitool-devel ipmitool-devel@lists.sourceforge.net
Sent: Tuesday, December 4, 2012 2:32:50 PM
Subject: Re
Hi,
attached is a patch for proper print outs in 'lib/ipmi_picmg.c'.
Please, don't mistake it with clean up which should follow up -
sometime. Only changes there are where output should go and modify
some messages.
I intend to commit this in like ~ 10 hours.
Thanks to whoever has time to look it
=detailaid=3597781group_id=95200atid=610550
*
https://sourceforge.net/tracker/?func=detailaid=3597782group_id=95200atid=610550
*
https://sourceforge.net/tracker/?func=detailaid=3598203group_id=95200atid=610550
Best regards,
Z.
--
Zdenek Styblik
email: zdenek.styb...@gmail.com
jabber: zdenek.styb
On Fri, Dec 28, 2012 at 9:44 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
On Fri, Dec 28, 2012 at 4:39 PM, jordan_hargr...@dell.com wrote:
Why change the ordering of the arguments in getsysinfo/setsysinfo?
I like it the way it was originally since intf/param/block/set are part
On Fri, Jan 4, 2013 at 5:48 PM, Ales Ledvinka aledv...@redhat.com wrote:
I don't know how much I can help with the
fixing, but if I have
time I'll do what I can.
You are welcome. Send me mail with the list of files you are going to touch.
I hope you two will find a better way than this.
On Fri, Jan 4, 2013 at 8:10 PM, Ales Ledvinka aledv...@redhat.com wrote:
[...]
Per issue, file or defect type group?
It's hard to say in a general way. Sometimes one is better than
another and sometimes it's better to edit hell out of .c file.
[...]
Reasonable minimal fix. If further
On Mon, Jan 7, 2013 at 12:25 PM, Ales Ledvinka aledv...@redhat.com wrote:
[...]
Then it's about effort to generate the report,
effort to check the reported item
whether it's security issue or not and effort to fix it. These are
not the same thing.
Right. And if you want to do it all
On Mon, Jan 7, 2013 at 3:02 PM, Ales Ledvinka aledv...@redhat.com wrote:
Hi,
The lib/ipmi_sdr.c above comment /* SR2300, non-redundant, PSx present */
The missing break is intentional due to redundancy, right?
Hello,
yes, it seems like it(= it is not a bug). One line of comment wouldn't
On Thu, Jan 10, 2013 at 3:49 PM, Ales Ledvinka aledv...@redhat.com wrote:
In src/plugins/lanplus/lanplus.c the second if ends with ;
Any idea if that is intentional to fail after the second get auth cap
regardless of return code?
* I'm not sure why we accept a failure for the first
Hello,
attached is a patch to prompt for password only once. As for now,
ipmitool prompts for password as many times as, eg. '-a', option has
been passed.
Ales, please note, attached patch is different from the one you've
proposed. Is this workable? Another option would be to put the whole
solution over the weekend.
Z.
- Original Message -
From: Zdenek Styblik zdenek.styb...@gmail.com
To: ipmitool-devel ipmitool-devel@lists.sourceforge.net
Cc: Ales Ledvinka aledv...@redhat.com
Sent: Friday, January 11, 2013 1:32:37 PM
Subject: Code Review - ID: 3595612 - ask
On Fri, Jan 11, 2013 at 5:32 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
[...]
Anyway, I'll try to think of some elegant solution over the weekend.
Another solution is attached.
Z.
- Original Message -
From: Zdenek Styblik zdenek.styb...@gmail.com
To: ipmitool-devel
compatibility has to be broken.
Z.
- Original Message -
From: Zdenek Styblik zdenek.styb...@gmail.com
To: Ales Ledvinka aledv...@redhat.com
Cc: ipmitool-devel ipmitool-devel@lists.sourceforge.net
Sent: Saturday, January 12, 2013 6:31:43 AM
Subject: Re: Code Review - ID: 3595612 - ask
On Tue, Jan 15, 2013 at 3:03 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
On Tue, Jan 15, 2013 at 2:54 PM, Ales Ledvinka aledv...@redhat.com wrote:
[...]
Sure. For the specific corner cases that I overlooked. Unlikely
to be used by anyone. Rather then dropping the compatibility
Hello,
attached is a re-work of # ipmitool sensor get NACname; output. As
written in the ticket on SF.net, output is inconsistent and broken
now. Most likely due to changes in 'lib/ipmi_sdr.c'. Output will be
exactly the same as of '-v sdr list' output after this change, but
only for specific
Hello Jordan,
attached are changes to ipmi_lcd_get_platform_model_name(), resp.
'lib/ipmi_delloem.c'. These changes are based upon ticket ID#3600910
at SF.net(link below).
Changes are:
* ipmi_lcd_get_platform_model_name() returns integer now
* if there is an error in ipmi_mc_getsysinfo(), then
Ales,
what's the reason for changes to 'lib/ipmi_chassis.c'???
Thanks,
Zdenek
On Wed, Feb 20, 2013 at 3:35 PM, Ales Ledvinka
le...@users.sourceforge.net wrote:
Update of /cvsroot/ipmitool/ipmitool/lib
In directory sfp-cvs-1.v30.ch3.sourceforge.com:/tmp/cvs-serv19457/lib
Modified Files:
Got it. It looks awkward though :)
Zdenek
On Wed, Feb 20, 2013 at 3:55 PM, Ales Ledvinka aledv...@redhat.com wrote:
Compile time error.
- Original Message -
From: Zdenek Styblik zdenek.styb...@gmail.com
To: Ales Ledvinka aledv...@redhat.com
Cc: ipmitool-devel@lists.sourceforge.net
Jim,
would you care to explain why this isn't a bug and why is it correct,
please? Because I don't get it as well and I'd like to know.
I sat down, I did binary/hex/whatever thing and came up with the
following values for '' . Order of the values is as in IPMI spec PDF
p. 391:
* 0xEF - OEM
* 0xF7
add some comment to the code for reference. It could make life much
easier(imo).
I'm sorry for bringing up even more questions and issues to the table,
Z.
On Tue, Feb 26, 2013 at 2:05 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
Jim,
would you care to explain why this isn't a bug and why
be checking the bits for zero and not one. I
had only
verified that it was looking at the right bits.
-- Jim Mankovich | jm...@hp.com (MST) --
On 2/26/2013 6:56 AM, Zdenek Styblik wrote:
And actually if you convert 0x10, 0x08 etc. into binary you can see
these have '1' set exactly where
On Tue, Jan 8, 2013 at 12:57 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
On Tue, Jan 8, 2013 at 12:42 PM, Liebig, Holger
holger.lie...@ts.fujitsu.com wrote:
Hi,
The lib/ipmi_sdr.c above comment /* SR2300, non-redundant, PSx present
*/
The missing break is intentional due
On Wed, Feb 27, 2013 at 9:37 AM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
[...]
I've logged SF.net ticket for this. Link:
https://sourceforge.net/tracker/?group_id=95200atid=610550
Z.
Grh! Correct link:
https://sourceforge.net/tracker/?func=detailaid=3606181group_id=95200atid=610550
:
Hi all,
Thanks for your response.
Hi Zdenek,
I just want to study this command. Then I try it and find out it. And
thanks for your response and explain.
ian
--- 13/2/27 (三)，Zdenek Styblik zdenek.styb...@gmail.com 寫道：
寄件者: Zdenek Styblik zdenek.styb...@gmail.com
主旨: Re: [Ipmitool
Jim,
I have two questions for you.
1] can you post a diff of changes?
2] Is there any plan to document(= real use example?) this feature
or how it works? Also, perhaps document change in behaviour as well?
Perhaps, it's done already. This feature is already documented, I
mean, not the changes.
Ok Jim, sounds good to me.
Thanks,
Z.
--
Zdenek Styblik
email: zdenek.styb...@gmail.com
jabber: zdenek.styb...@gmail.com
On Wed, Feb 27, 2013 at 7:14 PM, Jim Mankovich jm...@hp.com wrote:
Z,
This change will make ipmitool work as it is currently documented so no new
documentation
Hello all,
this is a low hanging fruit bug and pretty much the only reason I'm
asking for review is the change in error message that will be printed
out.
Are we happy with the changes?
Thanks,
Z.
ipmi_dcmi.c-wasted_resources.diff
Description: Binary data
Hi all,
attached is a patch which is, in a fact, a re-work of
ipmi_fru_get_multirec_from_file() in 'lib/ipmi_fru.c'. It began as a
check for return value of a seek(), but more than just thing seemed
wrong with this function. So I took the liberty and modified couple
things, as you can see in
since you already checked this above. This is on line 44 in your patch
file.
-- Jim Mankovich | jm...@hp.com --
On 3/8/2013 12:08 AM, Zdenek Styblik wrote:
Hi all,
attached is a patch which is, in a fact, a re-work of
ipmi_fru_get_multirec_from_file() in 'lib/ipmi_fru.c'. It began
Hello all,
attached is a diff of proposed change to 'lib/ipmi_lanp.c'. This bug
has been reported by Ales Ledvinka a the problem is this ``if (p ==
NULL)'' condition is never met, because struct is on heap, if I
understood and writing it correctly.
Comments? Ideas? I've tested it on small snippet
Hello all,
attached is a patch to possible integer *flows in
'lib/ipmi_delloem.c'. Patch removes function make_int() and replaces
its use with calls to str2int() from 'lib/helper.c'.
Are we happy with the patch?
Regards,
Z.
ipmi_delloem.c-fix_flows.diff
Description: Binary data
like
it's just a dust coming out of your mouth.
Best regards,
Zdenek
- Original Message -
From: Ales Ledvinka aledv...@redhat.com
To: Zdenek Styblik zdenek.styb...@gmail.com
Cc: ipmitool-devel ipmitool-devel@lists.sourceforge.net
Sent: Monday, March 11, 2013 6:32:09 PM
Subject: Re
the latter. If it's not today, it's
going to be tomorrow. Just because some values aren't used and can be
replaced doesn't truly solve the problem, does it?
My $0.02 USD.
Best regards,
Zdenek
- Original Message -
From: Zdenek Styblik zdenek.styb...@gmail.com
To: Ales Ledvinka aledv
(Compilation? Huh?).
Anyway, if you have better suggestion for error message, please, log
new SF.net ticket.
Thanks,
Z.
- Original Message -
From: Zdenek Styblik zdenek.styb...@gmail.com
To: ipmitool-devel ipmitool-devel@lists.sourceforge.net
Sent: Thursday, March 7, 2013 8:49:37 PM
Subject
Hello all,
attached is a patch for possible NULL reference in 'lib/ipmi_lanp.c'
caused by not checking return value of get_lan_param_select(). I'd say
it's pretty straightforward patch. Error messages are printed by
get_lan_param_select() itself, just in case somebody was wondering.
Regards,
Z.
Hi all,
attached is a patch to replace atoi() calls with appropriate str2*()
calls in 'lib/ipmi_lanp.c'. 'ival' parameter to lan_set_arp_interval()
got changed and that's about it.
Perhaps the following is worth of the thought:
~~~
- interval = ((uint8_t)atoi((const char *)ival) *
On Fri, Mar 15, 2013 at 11:28 AM, Ales Ledvinka aledv...@redhat.com wrote:
Hi,
Question about having tracker for everything. Not sure whether that's
review policy or part of someone's workflow. Should we have a tracker for
everything or apply common sense filtering?
I am thinking of
:)
Happy to see that there are no functionality changes ;)
Wanted to know if there was any type of sanity test carried out with
this patch ?
Thanks,
G
On 03/20/2013 01:56 PM, Zdenek Styblik wrote:
Hello,
attached is a diff which changes code formatting in
'lib/ipmi_delloem.c' and some typos
On Fri, Mar 22, 2013 at 2:42 PM, Corey Minyard tcminy...@gmail.com wrote:
The event data and SDRs support assertions and deassertions for
threshold events as well as
discrete events. So print out assertion and deassertion on all events.
Corey,
is it possible to change coding style to ``if
1 - 100 of 244 matches
Mail list logo
