KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/106/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 03 Feb 2018 07:19:37 + Build duration: 26 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 164 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/164/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 03 Feb 2018 07:19:37 + Build duration: 22 min and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/87/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 07:19:37 + Build duration: 20 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/107/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Feb 2018 07:19:37 + Build duration: 15 min and counting JUnit Tests Name: (root)

D10245: Add more default user locations to Places model/panel

spoorun added a comment. In https://phabricator.kde.org/D10245#199691, @rkflx wrote: > In https://phabricator.kde.org/D10245#199688, @ngraham wrote: > > > I don't think almost any users use or know about that because the two most obvious methods of adding something to the Places

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/105/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 03 Feb 2018 02:28:49 + Build duration: 16 min and counting JUnit Tests Name: (root)

D9966: [KIO] Fix issues with sharing of file descriptor

thiago added a comment. Why do you ask for a rewview then not wait for the review? Belated -1. No actual review of the change done, because I can't tell what you've done. INLINE COMMENTS > fdreceiver.cpp:34 > { > +SocketAddress addr(m_path.toStdString()); > +if

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/104/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 03 Feb 2018 01:47:44 + Build duration: 41 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/106/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Feb 2018 02:06:41 + Build duration: 10 min and counting JUnit Tests Name: (root)

D10233: [KIO] Remove PrivilegeExecution job flag

chinmoyr added a comment. Try copying org.kde.kio.file.conf and .service file to dbus-1 directory. It worked for me. On a completely different note, do all jobs have a uidelgate or does passing HideProgressInfo flag prevent it from being created? REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/105/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Feb 2018 01:47:44 + Build duration: 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/86/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 01:53:46 + Build duration: 12 min and counting JUnit Tests Name: (root)

D10257: KUrlMimeData: fix handling of PreferLocalUrls

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks OK to me. Had to read up on the KDE urls and local urls first though :) Funny side note. Those that text/uri-list can contain comments!

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 163 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/163/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 03 Feb 2018 01:54:51 + Build duration: 9 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 162 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/162/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 03 Feb 2018 01:47:44 + Build duration: 6 min 48 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/85/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 01:47:44 + Build duration: 5 min 50 sec and counting JUnit Tests Name:

D10233: [KIO] Remove PrivilegeExecution job flag

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ecaf513ed3cd: [KIO] Remove PrivilegeExecution job flag (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10233?vs=26326=26404 REVISION DETAIL

D9966: [KIO] Fix issues with sharing of file descriptor

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8d8f3025dffd: [KIO] Fix issues with sharing of file descriptor (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9966?vs=26220=26403 REVISION

D10261: Use the KFileItemListProperties copy constructor instead of the conversion from KFileItemList to KFileItemListProperties. This saves re-evaluating all items.

markg created this revision. markg added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY As the title says. Minor optimization. TEST PLAN Ran the

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/84/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 00:31:46 + Build duration: 35 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/104/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Feb 2018 00:25:30 + Build duration: 37 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/103/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 03 Feb 2018 00:35:14 + Build duration: 20 min and counting JUnit Tests Name: (root)

D10155: Use the much faster urls() method from QMimeData

dfaure added inline comments. INLINE COMMENTS > kurlmimedata.cpp:75 > +QByteArray ba = mimeData->data(firstMimeType); > +if (ba.isEmpty() || firstMimeType == QStringLiteral("text/uri-list")) { > // Extracting uris from text/uri-list, use the much faster QMimeData > method

D10257: KUrlMimeData: fix handling of PreferLocalUrls

dfaure updated this revision to Diff 26397. dfaure added a comment. remove unrelated change REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10257?vs=26396=26397 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10257 AFFECTED FILES

D10257: KUrlMimeData: fix handling of PreferLocalUrls

dfaure created this revision. dfaure added reviewers: mwolff, jtamate. Restricted Application added a project: Frameworks. dfaure requested review of this revision. REVISION SUMMARY https://phabricator.kde.org/R244:18e4d245d3d595cdc17ad40aa88495d6d2c30bf7 didn't quite have the right logic

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 102 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/102/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Fri, 02 Feb 2018 23:45:21 + Build duration: 49 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/83/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 02 Feb 2018 23:45:21 + Build duration: 46 min and counting JUnit Tests Name: (root)

D9672: Don't emit error signal before we tried all list commands.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. ERR_* is KIO-wide, and isn't technically an enum. But the proper error code for no error is KJob::NoError (which is 0). Can you switch to that, and adjust the second comment,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 103 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/103/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 02 Feb 2018 23:45:21 + Build duration: 40 min and counting JUnit Tests Name: (root)

D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c44784c98fcb: Dont cache the targetUrlList() result locally, return them from the locally… (authored by markg). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. If urlList() is called often, then this is actually slower (targetUrlList() has to iterate and convert). But yeah I doubt it is called often... REPOSITORY R241 KIO BRANCH

D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'

markg edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10256 To: markg, dfaure Cc: #frameworks, michaelh, ngraham

D10256: Don't cache the targetUrlList() result locally, return them from the locally cached m_items. Minor performance improvement as targetUrlList() is now only called (and the list created) when it'

markg created this revision. markg added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY Small performance improvement of just not caching the targetUrlList()

D10233: [KIO] Remove PrivilegeExecution job flag

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks for remembering to clean this up in time. Indeed not many people tested it, since it's still disabled... I tried to revert

D10172: KRun: allow executing "add network folder" without confirmation prompt

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10172 To: dfaure, mwolff, dhaumann Cc: elvisangelaccio, ngraham, #dolphin, #frameworks, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thiago, Ossi, looks ok to you too? (Tagging tomorrow...) INLINE COMMENTS > dfaure wrote in sharefd_p.h:51 > Is strlen needed? It seems to me that sun_path will be null if make_address

Re: Adding application to KDE and getting image of current cursor under wayland

Damir Porobic ha scritto: > Sorry, one more question regarding the incubator process. It's not obvious to > me how one application/project becomes a Candidate? > On the link https://community.kde.org/Incubator/Incubation_Process it is > mentioned what a Candidate needs to provide, but not where

Re: Adding application to KDE and getting image of current cursor under wayland

On Fri, 02 Feb 2018 11:50:13 -0800 Damir Porobic wrote > Sorry, one more question regarding the incubator process. It's not obvious > to me how one application/project becomes a Candidate? > On the link https://community.kde.org/Incubator/Incubation_Process

Re: Adding application to KDE and getting image of current cursor under wayland

Am 2018-02-02 19:04, schrieb Damir Porobic: 2. Is there a way to get an image of the current mouse cursor under KWin Wayland? No. Cheers Martin Wayland Maintainer

Re: save and restore the geometry of KMainWindow

On 01.02.2018 20:52, Albert Astals Cid wrote: El dimarts, 30 de gener de 2018, a les 21:06:02 CET, Alexander Semke va escriure: The state is already saved and restored there. Why not to do the same for the geometry? I think that it's generally frowned upon putting your position on screen

Re: Adding application to KDE and getting image of current cursor under wayland

Sorry, one more question regarding the incubator process. It's not obvious to me how one application/project becomes a Candidate? On the link https://community.kde.org/Incubator/Incubation_Process it is mentioned what a Candidate needs to provide, but not where and in what form. Regards, Damir  

Re: Adding application to KDE and getting image of current cursor under wayland

Thanks for the Link, will have a look at it. Spectacle can take screenshots with or without mouse cursor on it. In the X11 implementation the cursor image is added as part of post processing to the screenshot. With Wayland you have to request the screenshot from the Compositor and while making

D10245: Add more default user locations to Places model/panel

rkflx added a comment. Also, I feel a bit sorry for you. If I had realized the problem when Search For was added I would've added the same comment. I'd be glad if we could fix that again and remove the mimetype dependent items from the standard places model (or make it more intelligent

D10245: Add more default user locations to Places model/panel

rkflx added a comment. In https://phabricator.kde.org/D10245#199688, @ngraham wrote: > I don't think almost any users use or know about that because the two most obvious methods of adding something to the Places panel--drag-and-drop and the file's "Add to places" context menu item--make

D10245: Add more default user locations to Places model/panel

ngraham added a comment. In https://phabricator.kde.org/D10245#199673, @rkflx wrote: > In https://phabricator.kde.org/D10245#199671, @ngraham wrote: > > > Keeping Pictures but removing Music would seem to be a compromise, no? But since this has proved controversial, it's obviously

D10245: Add more default user locations to Places model/panel

rkflx added a comment. > file open/save dialogs I'd assume the use case of those is quite broad, so those should be opt-in. However, I'm not sure whether an app can change it's file dialog's places model? That may be a deficiency, but then the deficiency should be solved instead of

D10251: [RFC] Use mipmap filtering in window thumbnails

hein added a comment. It's definitely nicer, but could we go for the full thing and make it crisper too? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot,

D10245: Add more default user locations to Places model/panel

rkflx added a comment. In https://phabricator.kde.org/D10245#199671, @ngraham wrote: > Keeping Pictures but removing Music would seem to be a compromise, no? But since this has proved controversial, it's obviously not going in anytime soon, so no need to worry about that. Well,

Re: Adding application to KDE and getting image of current cursor under wayland

On Friday, 2 February 2018 19:04:52 CET Damir Porobic wrote: > Hi Folks, > > I've got two questions related to KDE which you could eventually answer: > 1. Is there a process for adding applications to the KDE family or do you > always start writing applications specifically for KDE? There are

Re: Adding application to KDE and getting image of current cursor under wayland

On Fri, 02 Feb 2018 10:04:52 -0800 Damir Porobic wrote > Hi Folks, > > I've got two questions related to KDE which you could eventually answer: > 1. Is there a process for adding applications to the KDE family or do you > always start writing

D10245: Add more default user locations to Places model/panel

ngraham added a comment. Keeping Pictures but removing Music would seem to be a compromise, no? But since this has proved controversial, it's obviously not going in anytime soon, so no need to worry about that. Since the places model is now in KIO, once a user adds a location in

Adding application to KDE and getting image of current cursor under wayland

Hi Folks, I've got two questions related to KDE which you could eventually answer: 1. Is there a process for adding applications to the KDE family or do you always start writing applications specifically for KDE? 2. Is there a way to get an image of the current mouse cursor under KWin Wayland?

Re: Plasma5 user sessions

On Mon, Jan 15, 2018 at 9:37 PM, Max Harmathy wrote: > Am 15.01.2018 um 20:07 schrieb Kai Uwe Broulik: > > Hi, > > Thanks for your replay > > We found out, that running a process with a systemd inhibitor as root e.g > > > # systemd-inhibit --what=shutdown --mode=block sleep

D10245: Add more default user locations to Places model/panel

rkflx added a comment. In https://phabricator.kde.org/D10245#199564, @ngraham wrote: > I could see removing Music and Pictures, maybe. In https://phabricator.kde.org/D10245#199578, @rkflx wrote: > - Remove "Pictures" and "Music" again. In

D10124: Faster simplejob start

jtamate added a comment. In https://phabricator.kde.org/D10124#199645, @mwolff wrote: > can you test and make sure that q and slave actually get destroyed? If that is the case, then the slotobj should get destroyed too. If not then this is a bug in Qt, which would make me wonder... Do

D10124: Faster simplejob start

mwolff added a comment. can you test and make sure that q and slave actually get destroyed? If that is the case, then the slotobj should get destroyed too. If not then this is a bug in Qt, which would make me wonder... Do you have a selfcompiled Qt, or one shipped by your distro? There was

D10245: Add more default user locations to Places model/panel

ngraham added a comment. In https://phabricator.kde.org/D10245#199578, @rkflx wrote: > Suggestion which would resolve most of my issues: > > - Remove "Pictures" and "Music" again. Music, maybe. Pictures no, for the reasons that @spoorun gave. Also, the Pictures item is useful

D10250: track the validity of the texture

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Good analysis on the plotter. Thanks for looking into it. > but in some rare cases, it can be deleted too by some external cause, usually when a widget

D10124: Faster simplejob start

jtamate added a comment. In https://phabricator.kde.org/D10124#199601, @mwolff wrote: > only that one, not the others? strange, why should that be the case? are you sure `q` and `slave` get destroyed? Yes, only that one. I've tried with const parámeters in the lambdas, same

D10245: Add more default user locations to Places model/panel

markg added a comment. Ha, funny. I would say +1 :) Your idea is good and the default user places could imho be more then what is there by default right now. I personally would only add: - Desktop - Downloads Pictures, music and documents are in my case rarely used items. I

D10245: Add more default user locations to Places model/panel

spoorun added a comment. In https://phabricator.kde.org/D10245#199562, @rkflx wrote: > -1 from my side because: > > - Dolphin: By default, the sidebar now has an ugly scrollbar. (The screenshot is "staged" in that regard.) > - Gwenview: This clutters the Places list on the Start

D10245: Add more default user locations to Places model/panel

spoorun added a comment. I'm afraid that removing pictures would be a bad idea. The majority of users would find Pictures in particular essential - and lots of software and services automatically store images in the Pictures folder (for example when plugging in an SD card or camera, when

D10124: Faster simplejob start

mwolff added a comment. only that one, not the others? strange, why should that be the case? are you sure `q` and `slave` get destroyed? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks, mwolff Cc: mwolff, broulik, ngraham, anthonyfieroni,

D10250: track the validity of the texture

broulik added inline comments. INLINE COMMENTS > managedtexturenode.cpp:42 > +{ > +if (s_d.contains(this)) { > +delete s_d[this]; `delete s_d.take(this);` > managedtexturenode.cpp:50 > +{ > +if (s_d.contains(this)) { > +return s_d[this]; auto *d = s_d.value(this); if

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik added a comment. Before and after: F5688790: before-after.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: plasma-devel, #frameworks, michaelh, ZrenBot,

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik created this revision. fredrik added reviewers: Plasma, VDG. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. REVISION SUMMARY Blit the contents of the window texture

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham added a comment. If this is only a change for the "disconnected wifi" icon, then maybe we should mimic the "disconnected wired network" icon and make the color red, rather than fiddling with the lightness, which will never satisfy everyone (if this merged, I predict bug reports that

D10245: Add more default user locations to Places model/panel

rkflx added a comment. In https://phabricator.kde.org/D10245#199564, @ngraham wrote: > The scrollbar issue is real, though I don't think scrollbars are as awful as you do. :-) Something to think about. Not awful per se, but a huge problem if they hide important stuff below the

D10250: track the validity of the texture

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY the texture of ManagedTextureNode gets deleted by

D10245: Add more default user locations to Places model/panel

ngraham added a comment. The scrollbar issue is real, though I don't think scrollbars are as awful as you do. :-) Something to think about. I could see removing Music and Pictures, maybe. But Desktop, Documents, and Downloads are heavily used by ordinary regular users and I think it makes

D10245: Add more default user locations to Places model/panel

rkflx added a comment. -1 from my side because: - Dolphin: By default, the sidebar now has an ugly scrollbar. (The screenshot is "staged" in that regard.) - Gwenview: This clutters the Places list on the Start Page with a bunch of stuff not relevant for users (e.g. Music). I'm still

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham added a comment. Thanks @andreask. Could we also see what it looks like next to the icon with all bars filled, or with only a few filled? This looks better for disconnected ones, but without seeing those use cases, it do worry that the presentation becomes too muddy for weak

D10124: Faster simplejob start

jtamate added a comment. Unfortunately, the last connect creates a memory leak: 1018== 10,152 (72 direct, 10,080 indirect) bytes in 1 blocks are definitely lost in loss record 928 of 943

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/47/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Fri, 02 Feb 2018 13:32:09 + Build duration: 5 min 54 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/47/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Fri, 02 Feb 2018 13:32:09 + Build duration: 2 min 48 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/45/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 02 Feb 2018 13:32:09 + Build duration: 2 min 16 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/46/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Fri, 02 Feb 2018 12:51:14 + Build duration: 15 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/46/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Fri, 02 Feb 2018 12:51:14 + Build duration: 10 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/44/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 02 Feb 2018 12:51:14 + Build duration: 4 min 1 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/45/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Fri, 02 Feb 2018 12:31:14 + Build duration: 7 min 49 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/43/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 02 Feb 2018 12:31:13 + Build duration: 4 min 16 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Fri, 02 Feb 2018 12:31:14 + Build duration: 1 min 45 sec and counting JUnit

D4911: add Baloo DBus signals for moved or removed files

cullmann added a comment. @cullmann: https://phabricator.kde.org/T7860 lists some of my observations wrt samba shares. I don't know NFS, can you enlighten me regarding deviceids and inodes on NFS? I can only tell that baloo can't work at all on NFS/SMB home dirs with the current DB and

D4911: add Baloo DBus signals for moved or removed files

michaelh added a comment. Considering that I'm more or less the only one working on baloo, I'd prefer to postpone this for a while instead of adding more complexity. At least until I have understood the inner workings of baloo. Also the list of bugs reporting baloo's crashes is quite long.

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/44/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Fri, 02 Feb 2018 10:05:03 + Build duration: 9 min 50 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Fri, 02 Feb 2018 10:05:03 + Build duration: 5 min 39 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/42/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 02 Feb 2018 10:05:03 + Build duration: 2 min 3 sec and counting JUnit

D10243: Improve visibility of disconnected Wi-Fi icons

andreask added a comment. F5688471: wifi icon.png top after - breeze(light) - breeze-dark bottom before - breeze(light) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask,

D5209: Load translations from KPackage files if bundled

ltoscano removed a dependency: D10215: Make KReport use marble component, KEXI & KEXI frameworks stable is 3.1. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: ltoscano, Zren, plasma-devel, #frameworks,

D5400: new class, KActionRunner

tcanabrava abandoned this revision. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D5400 To: tcanabrava, #frameworks, ltoscano Cc: ltoscano, michaelh, ngraham

D10243: Improve visibility of disconnected Wi-Fi icon

andreask retitled this revision from "Disconnected wi-fi icons are almost invisible BUG:384018" to "Improve visibility of disconnected Wi-Fi icon". andreask edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243

D10243: Improve visibility of disconnected Wi-Fi icons

andreask retitled this revision from "Improve visibility of disconnected Wi-Fi icon" to "Improve visibility of disconnected Wi-Fi icons". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask, #plasma, #plasma_accessibility, sebas,

D7909: Add syntax support for Crystal Programming Language

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Sorry for the late reply. Please do the following changes: - remove hard-coded colors from itemDatas. This way, your highlighting will look good in all color themes.