D29347: KAuthorized: export method to reload restrictions

mdawson added a comment. One suggestion for this change: Instead of exporting a method that takes no parameters and always loads from configuration file, why not make a new method with the implementation that takes in a given KConfigGroup. That way unit tests can pass in a KConfigGroup

D22979: Security: remove support for $(...) in config keys with [$e] marker.

mdawson accepted this revision. REPOSITORY R237 KConfig BRANCH security_kill_popen REVISION DETAIL https://phabricator.kde.org/D22979 To: dfaure, mdawson, aacid, broulik, davidedmundson, kossebau, apol, sitter, security-team Cc: ZaWertun, rikmills, fvogt, ngraham, kde-frameworks-devel,

D22979: Security: remove support for $(...) in config keys with [$e] marker.

mdawson added a comment. LGTM. Regarding the test, if we want to get this change in asap due to the security focus I can submit a follow up patch re-adding it. INLINE COMMENTS > kconfigtest.cpp:530 > << "URL[$e]=file://${HOME}/foo" << endl > -<<

D13947: Honor BUILD_TESTING

mdawson accepted this revision. mdawson added a comment. This revision is now accepted and ready to land. LGTM, thanks! REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D13947 To: arojas, mdawson, dfaure Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham,

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

mdawson added a comment. +1 LGTM. Before submitting, can you poke the usability people about this change please? If they are also happy, then it's got a ship it from me. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D6553 To: dfaure, mdawson Cc: ltoscano, apol,

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

mdawson accepted this revision. mdawson added a comment. This revision is now accepted and ready to land. LGTM! Thanks for working on this. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D5502 To: wbauer, #frameworks, mdawson Cc: mdawson, #frameworks

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

mdawson requested changes to this revision. mdawson added a comment. This revision now requires changes to proceed. Excellent! Could you add 4 more rows to the tests, to ensure a path without a folder (ex. systemConfigLocation + "/test.desktop") works correctly? Once that's done, it's a

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

mdawson added a comment. In https://phabricator.kde.org/D5502#103322, @wbauer wrote: > In https://phabricator.kde.org/D5502#103316, @mdawson wrote: > > > Can you please add some unit tests for this, to ensure it doesn't break in the future? I think just three extra tests, one for a

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

mdawson requested changes to this revision. mdawson added a comment. This revision now requires changes to proceed. +1 This definitely looks like the correct fix. Can you please add some unit tests for this, to ensure it doesn't break in the future? I think just three extra tests, one

[Differential] [Accepted] D4604: KConfig: stop exporting and installing KConfigBackend.

mdawson accepted this revision. mdawson added a comment. This revision is now accepted and ready to land. Ship it! REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D4604 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D4604: KConfig: stop exporting and installing KConfigBackend.

mdawson added inline comments. INLINE COMMENTS > dfaure wrote in kconfigbackend.h:210 > In general I agree that leaving dead code is bad. > > In this particular case, though, the other side of the plugin code is still > there > ("#if 0 // TODO port to Qt5 plugin loading" in

[Differential] [Requested Changes] D4604: KConfig: stop exporting and installing KConfigBackend.

mdawson requested changes to this revision. mdawson added a comment. This revision now requires changes to proceed. I agree, this can't be used so removing it from the API can't hurt anything. Just to be sure, let's take this change for the next release, but not change KConfigBackend'

Re: KConfig issues prevent compiling KDE applications under Windows

On Thursday, February 2, 2017 10:08:53 PM EST Jaroslaw Staniek wrote: > On 1 February 2017 at 14:34, David Faure wrote: > > One note though: this is a failure to link a unittest, your release isn't > > blocked, you can just disable the building of unittests in kconfig. > > > > The

[Differential] [Accepted] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

mdawson accepted this revision. mdawson added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R237 KConfig BRANCH kconfigcompiler-instance-ksharedconfig REVISION DETAIL https://phabricator.kde.org/D3386 EMAIL PREFERENCES

Re: Review Request 129450: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129450/#review100975 --- Ship it! Ship It! - Matthew Dawson On Nov. 20, 2016

Re: Review Request 129453: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129453/#review100974 --- Ship it! Ship It! - Matthew Dawson On Nov. 20, 2016

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

ill behave as expected in just about every application. Thoughts? - Matthew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129251/#review100230 --

Re: Review Request 128608: Add Donate entry to KStandardShortcut

> On Aug. 9, 2016, 11:23 p.m., Matthew Dawson wrote: > > LGTM. I can't speak for the other review. Sorry, one other thing: Please make sure to put a CHANGELOG: entry in the commit message. Thanks!

Re: Review Request 128608: Add Donate entry to KStandardShortcut

. - Matthew Dawson On Aug. 8, 2016, 5:05 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128019: Remove F1 as standard shortcut for Help

> On May 26, 2016, 11:37 a.m., Matthew Dawson wrote: > > While I appreciate the source of this change (I've almost never hit F1 > > intending to open the doucmentation myself), I don't think a RR is the > > right place to discuss changes to our default shortcuts. Th

Re: Review Request 128019: Remove F1 as standard shortcut for Help

. People annoyed at F1 can fix their issue now without code changes while we figure out the best plan forward. - Matthew Dawson On May 25, 2016, 7:01 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generat

Re: Review Request 127948: Avoid skipping KAuthorized check

d like it is testing TryExec in general, which is being tested above. That name is hopefully a little more descriptive of the issue under test. - Matthew Dawson On May 19, 2016, 4:17 p.m., David Edmundson wrote: > > --- > This is a

Re: Review Request 127948: Avoid skipping KAuthorized check

for this behaviour? Otherwise looks good to go. - Matthew Dawson On May 17, 2016, 3:57 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127813: Process paths just once

have no problem taking it. - Matthew Dawson On May 4, 2016, 9:02 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127765: RFC: Cache global config files

. - Matthew Dawson On April 27, 2016, 12:14 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127462: Add support for get QStandardPaths locations.

llback strategy if the environment variable is not set. They instead map to a location from QStanardPaths. They are: docs/options.md (line 96) <https://git.reviewboard.kde.org/r/127462/#comment64059> Nitpick: s/QStandardsPath/QStandardPaths/ - Matthew Dawson On March 28, 201

Re: Review Request 127462: Add support for get QStandardPaths locations.

> On March 28, 2016, 1:39 a.m., Matthew Dawson wrote: > > Much better! I don't think this should handle XDG* variables explicitly, > > as they won't be used on other platforms and may cause confusion there. On > > platforms using XDG* variables, Qt handles this

Re: Review Request 127462: Add support for get QStandardPaths locations.

ldn't be using those variables as they have their own standard we should integrate against. - Matthew Dawson On March 27, 2016, 10:22 a.m., Sandro Knauß wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

-- On March 22, 2016, 11:23 a.m., Sandro Knauß wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127462/ >

Re: kconfig question

On Wednesday, January 27, 2016 10:32:50 AM EST Boudewijn Rempt wrote: > On Sat, 23 Jan 2016, David Faure wrote: > > (I don't mean "it's called KConfig" ;-) I mean what does the code using > > it, look like? I think this needs some debugging to find out where this > > "local" string comes from)

Re: kconfig question

On Saturday, January 23, 2016 11:54:56 AM EST David Faure wrote: > On Monday 18 January 2016 10:28:18 Matthew Dawson wrote: > > On Monday, January 18, 2016 8:53:22 AM EST Boudewijn Rempt wrote: > > > On Sun, 17 Jan 2016, Matthew Dawson wrote: > > > > It appears

Re: kconfig question

On Monday, January 18, 2016 8:53:22 AM EST Boudewijn Rempt wrote: > On Sun, 17 Jan 2016, Matthew Dawson wrote: > > It appears this is the desired behaviour. On most platforms, > > GenericConfigLocation and ConfigLocation are the same things, except > > Windows. Acco

Re: kconfig question

On Friday, January 15, 2016 9:46:00 AM EST Boudewijn Rempt wrote: > I noticed that krita on windows wrote its kritarc to Roaming\local\ or > Local\local instead of Roaming\krita\kritarc, and I was wondering why that > was. I now think it's because KConfig's default is to write to >

Re: Review Request 126556: Ensure group is unescaped properly in kconf_update.

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Changes --- Submitted with commit 55bf90ff787f4e84947a5df833f66082e54016df by Matthew Dawson to branch master. Repository: kconfig Description --- During a kconf_update run, an invalid group name may

Re: Review Request 126555: Remove unused variable in KConfigPrivate

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Changes --- Submitted with commit df3440f328405623de927595b4555e06600d5626 by Matthew Dawson to branch master. Repository: kconfig Description --- This seems to be left over from KDE 3.5 times, and isn't

Review Request 126555: Remove unused variable in KConfigPrivate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126555/ --- Review request for KDE Frameworks and Matthew Dawson. Repository

Review Request 126556: Ensure group is unescaped properly in kconf_update.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126556/ --- Review request for KDE Frameworks and Matthew Dawson. Repository

Re: Review Request 126161: OS X housekeeping

On November 27, 2015 01:02:31 PM Alexander Richardson wrote: > Has anyone done measurements on a recent system? Does it give any > noticable benefit? I have not, nor are my machines good representations. I don't think considering machines with 2G of memory with older processors to be out of line

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0f1e67051dae0c9b1f23461f7caed594795e8a27 by Matthew Dawson to branch master. Repository: kconfig Description --- Due to https://codereview.qt-project.org/#/c/106473/, Qt 5.6 keeps null

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

/git.reviewboard.kde.org/r/126001/#review88177 --- On Nov. 8, 2015, 7:23 p.m., Matthew Dawson wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

ing --- Tested on both Qt 5.5.1 and Qt 5.6 (commit e996d68f6130847637ba287518cff1289cfa48e5), tests all pass now. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-framewo

Re: Qt 5.6 behavior change with QByteArray(str, size) and QFile::encodeName()

On November 7, 2015 08:07:11 PM David Faure wrote: > KTar's unittests detected a behavior change in Qt. > Thiago, is it intentional, or should it be fixed in Qt ? > > KTar does > > QString name = QFile::decodeName(QByteArray(buffer, 100)); > > where buffer is e.g. "filename\0\0\0\0\0\0[...]" >

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

something else. - Matthew Dawson On Oct. 13, 2015, 2:20 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: ksycoca and kbuildsycoca, the next step

On September 6, 2015 01:52:37 PM David Faure wrote: > As a followup to recent discussions, I'm now looking into moving the > recreating kbuildsycoca directly into the kservice library. > > The rebuild now happens on demand when using any KService API and one the > dirs with desktop files is more

Re: ksycoca and kbuildsycoca, the next step

On September 7, 2015 12:03:59 AM you wrote: > On Sunday 06 September 2015 17:59:13 Matthew Dawson wrote: > > On September 6, 2015 01:52:37 PM David Faure wrote: > > > As a followup to recent discussions, I'm now looking into moving the > > > recreating kbuildsycoca

Re: Review Request 124138: Install kconfig_compiler into libexec

as well. - Matthew Dawson On June 21, 2015, 12:15 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124138

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

just one minor nitpick below (no need to repost the patch). Also please be sure to include a Changelog: line in the commit message. autotests/kconfig_compiler/test_translation.kcfg (line 4) https://git.reviewboard.kde.org/r/123872/#comment55962 Nitpick: trailing space - Matthew Dawson

Re: Review Request 124129: Fix KAuthorized config file loading

/ --- (Updated June 19, 2015, 3:20 p.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- This was broken in porting, it used to be KGlobal::config() which opens the kdeglobals file, KSharedConfig::openConfig() opens a config file

Re: Review Request 124138: Install kconfig_compiler into libexec

. Otherwise looks fine to me, but I'd prefer someone to check off the CMake part. - Matthew Dawson On June 20, 2015, 8:30 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

On June 15, 2015, 11:12 p.m., Matthew Dawson wrote: src/kconfig_compiler/CMakeLists.txt, line 16 https://git.reviewboard.kde.org/r/124104/diff/1/?file=380232#file380232line16 Does this mean a cross-compiled KConfig won't be built right for development on the target

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

? If this happens regardless, is the cross compiling still possible? My CMake foo is weak, so if no one knows an alternative, I'm fine. I'd just prefer KConfig to work on the target for development too. - Matthew Dawson On June 15, 2015, 1:59 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

On May 21, 2015, 11:29 a.m., Matthew Dawson wrote: LGTM in general, but could you please add/update a unit test to test all the possible cominbations of the translation? Chusslove Illich wrote: That would make the test depend on the Ki18n framework, which is not acceptable

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

to test all the possible cominbations of the translation? - Matthew Dawson On May 21, 2015, 11:21 a.m., Chusslove Illich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123872

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79510 --- Ship it! Ship It! - Matthew Dawson On April 25, 2015, 3

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

it anyways. Also, I don't mind commiting the removal of that signal after this lands, as long as it happens before the release. As long as that is true, no user code would be broken. Doing it now is preferred :) - Matthew Dawson On April 24, 2015, 9:39 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

to signals at the moment. autotests/kconfig_compiler/test_signal.cpp.ref (line 41) https://git.reviewboard.kde.org/r/123367/#comment54296 Here is an example of KConfigCompilerSignallingItem in use. - Matthew Dawson On April 23, 2015, 8:53 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

time this has taken, I'd be ok leaving the brightnessChanged signal alone for this review, and removing it later. - Matthew Dawson On April 24, 2015, 9:39 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

/test13.cpp.ref (line 33) https://git.reviewboard.kde.org/r/123367/#comment54309 Is there a reason this got moved back? - Matthew Dawson On April 24, 2015, 12:56 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

for this change would be useful. - Matthew Dawson On April 23, 2015, 12:50 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

On April 23, 2015, 12:55 p.m., Milian Wolff wrote: How are kf5 releases handled btw? Do I need to push this into some branch? There are none in kcoreaddons. This patch here should probably be put into a patch release (if we do this for kf5). Luigi Toscano wrote: The current

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

from someone else. - Matthew Dawson On April 23, 2015, 1:19 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

, AFAICS. I think just moving the emission of brightnessModified to itemChanged would work, along with an equality check. Thanks for bearing with me on all these changes :) - Matthew Dawson On April 22, 2015, 9:20 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

visibility. - Matthew Dawson On April 22, 2015, 10:51 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

On April 22, 2015, 10:53 a.m., Matthew Dawson wrote: src/kconfig_compiler/kconfig_compiler.cpp, line 100 https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100 Is there a reason not to generate Q_PROPERTIES for all classes, or at least do it by default

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

On April 22, 2015, 10:53 a.m., Matthew Dawson wrote: src/kconfig_compiler/kconfig_compiler.cpp, line 100 https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100 Is there a reason not to generate Q_PROPERTIES for all classes, or at least do it by default

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

on if statements. src/kconfig_compiler/kconfig_compiler.cpp (line 1452) https://git.reviewboard.kde.org/r/123367/#comment54203 Nitpick: braces here too. - Matthew Dawson On April 22, 2015, 12:07 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 22, 2015, 12:07 p.m.) Review request for KDE Frameworks and Matthew

Re: [Kde-games-devel] Data migration issue

On March 24, 2015 12:59:26 AM Albert Astals Cid wrote: El Dilluns, 23 de març de 2015, a les 00:25:14, Matthew Dawson va escriure: On March 22, 2015 06:19:46 PM David Faure wrote: Any input? I'm generally fine with this implementation, it seems like it would fix the problem. I

Re: [Kde-games-devel] Data migration issue

On March 22, 2015 06:19:46 PM David Faure wrote: On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: Too late for KDE Applications 15.04 though now that i think, so maybe we actually have to suggest everybody using the migrator to add those extra lines? OK, that means: ---

Re: [Kde-games-devel] Data migration issue

On March 21, 2015 04:00:11 PM Mathias Kraus wrote: === KConfig config(QLatin1String(kminesrc)); config.reparseConfiguration(); === Sorry, my suggestion of using reparseConfiguration wasn't clear. I meant using it against the global KSharedConfig, not a newly created KConfig.

Re: [Kde-games-devel] Data migration issue

On March 21, 2015 04:29:25 PM Mathias Kraus wrote: Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson: On March 21, 2015 04:00:11 PM Mathias Kraus wrote: === KConfig config(QLatin1String(kminesrc)); config.reparseConfiguration(); === Sorry, my suggestion

Re: [Kde-games-devel] Data migration issue

On March 3, 2015 10:59:21 PM Mathias Kraus wrote: Hi, I noticed a problem with the data migration in the kdegames transition from kdelibs4 to kf5 and Albert Astals Cid suggested to ask frameworks devel for advice. In short, when the migration is run after the QCoreApplication is created,

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

On Feb. 21, 2015, 3:19 p.m., Matthew Dawson wrote: Everything looked good, but when I tried to rerun the tests to make sure everything is ok the kconfig_in_global_object test I'm getting an abort with the same error message. Backtrace: ``` #5 0x7791b630 in qAppName

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

not exist before the program executes, which may be why we missed it from the earlier patches. - Matthew Dawson On Feb. 21, 2015, 2:58 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Extra patch for KConfig 5.7 release

On February 14, 2015 11:16:42 AM David Faure wrote: This is rather a behavior-incompatible change (and another one to revert). So, to avoid the packagers killing me for updating 5.7 two days *after* the supposed public release day (*), I would rather make a 5.7.1 kconfig release with this

Extra patch for KConfig 5.7 release

Hi all, If it is not too late to sneak an extra patch into KConfig's 5.7 release, could commit 9eee15917e01a89d937d1cba2eebbe9d65daeb72 ( http://commits.kde.org/kconfig/9eee15917e01a89d937d1cba2eebbe9d65daeb72 ) be added in? This change reverts a SIC, which will break updating of

Re: strange problem with KConfig

On February 5, 2015 08:49:16 PM Marco Martin wrote: Hi all, I was investigating this bug.. https://bugs.kde.org/show_bug.cgi?id43583 but after digging and digging, it looks like more and more an issue in KConfig.. basically if there is a config file in a system-wide location (to give

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

On Jan. 27, 2015, 3:55 p.m., Matthew Dawson wrote: Unforunately, this cause test system failures in the the kconfigskeletontest test suite. I'm not sure why this should create issues there. However, I have a partial solution that avoids creating a full KSharedConfig. Instead

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

. 27, 2015, 3:10 a.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- kconfig_in_global_object.cpp comes from kdelibs4support (after porting to Q_GLOBAL_STATIC) ksharedconfig_in_global_object.cpp is new (but works with kdelibs4

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

? Otherwise, everything looked go to me. autotests/ksharedconfig_in_global_object.cpp https://git.reviewboard.kde.org/r/122232/#comment51847 Line to comment out. For the final version this should work without this line. - Matthew Dawson On Jan. 26, 2015, 3:11 a.m., David Faure wrote

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

On Jan. 24, 2015, 12:12 p.m., Matthew Dawson wrote: autotests/kconfig_in_global_object.cpp, line 56 https://git.reviewboard.kde.org/r/122232/diff/1/?file=33#file33line56 This doesn't actually trigger anything when run without the fix below. Since a name is provided

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

stay empty. Maybe add another conditional checking its empty in this if statement, and if it still is add some random value? - Matthew Dawson On Jan. 23, 2015, 5:39 p.m., David Faure wrote: --- This is an automatically

Re: Review Request 122206: [kio] Make tests optional

On Jan. 23, 2015, 8:43 a.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

tests must always pass. Matthew Dawson wrote: This is mostly useful on source based distributions (specifically, this patch comes from Gentoo). While in general running tests everywhere would be great, source distro users may not have the cpu time to compile/run tests. Also, some test

Re: Review Request 122206: [kio] Make tests optional

tests must always pass. Matthew Dawson wrote: This is mostly useful on source based distributions (specifically, this patch comes from Gentoo). While in general running tests everywhere would be great, source distro users may not have the cpu time to compile/run tests. Also, some test

Re: Review Request 122206: [kio] Make tests optional

tests must always pass. Matthew Dawson wrote: This is mostly useful on source based distributions (specifically, this patch comes from Gentoo). While in general running tests everywhere would be great, source distro users may not have the cpu time to compile/run tests. Also, some test

Re: Review Request 121908: Fix unit test failure on machines with an empty ~/.qttest.

cc17ef6e3f3c0db3c4597105b32320f0aeb52b0f autotests/kstyle_unittest.cpp e0e0046100acc195b1a3c36bbbe67e5861d7b7ee Diff: https://git.reviewboard.kde.org/r/121908/diff/ Testing --- Executing the test suite locally now succeeds. Thanks, Matthew Dawson

Review Request 121908: Fix unit test failure on machines with an empty ~/.qttest.

e0e0046100acc195b1a3c36bbbe67e5861d7b7ee Diff: https://git.reviewboard.kde.org/r/121908/diff/ Testing --- Executing the test suite locally now succeeds. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

the unit test refactoring out to a separate commit just before the bug fix commit? If not, just push it as is. - Matthew Dawson On Jan. 6, 2015, 5:41 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

the read call. Matthew Dawson wrote: The read call was removed to avoid changing the KCoreConfigSekleton during the save call, as it wasn't documented as doing that and may surprise some people that flushing their changes may load other unrelated changes. I would prefer to keep

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/ --- (Updated Jan. 4, 2015, 11:04 a.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121372/#review71585 --- On Dec. 6, 2014, 3:49 p.m., Matthew Dawson wrote

Review Request 121372: Differeniate between bookmarks for documents and the web

) and Matthew Dawson. Bugs: 1164383 https://bugs.kde.org/show_bug.cgi?id=1164383 Repository: kconfig Description --- As requested in bug #1164383, this adds a new standard shortcut for adding bookmarks for web pages. BUG: 1164383 I'm not sure if this is the best approach

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

, Localization and Translation (l10n) and Matthew Dawson. Changes --- Copy+paste error on bug number. Bugs: 341279 https://bugs.kde.org/show_bug.cgi?id=341279 Repository: kconfig Description --- As requested in bug #1164383, this adds a new standard shortcut for adding bookmarks

Re: FAM in kdirwatch

On November 28, 2014 01:16:02 PM Jonathan Riddell wrote: At Kubuntu we're trying to work out if we want kcoreaddons to build-dep on FAM. FAM isn't used if inotify is available and kdelibs never built against FAM. But we had this bug report about FAM being needed for NFS

Re: Review Request 121272: Fix link to KSharedConfig::openConfig in apidoc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121272/#review71044 --- Ship it! Thanks! Will push shortly. - Matthew Dawson

Re: Review Request 120283: make KConfigLoader more predictable by exposing a getter to KConfig's OpenFlags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120283/#review66958 --- Ship it! Ship It! - Matthew Dawson On Sept. 19, 2014, 7

Re: Non-coinstallable frameworks

On September 18, 2014 01:15:51 PM Aleix Pol wrote: Hi Ivan, I've just learned that the KActivities framework is not co-installable with kdelibs4. Are you sure about this? I just double checked, and my distribution (Gentoo) has both installed right now, in the same prefix. And I'm running

Re: Review Request 119991: Use Juvia to add comments on the API class pages

On September 12, 2014 03:19:13 AM Ben Cooksley wrote: On Sept. 8, 2014, 10:22 p.m., Ben Cooksley wrote: Matthew Dawson wrote: I don't think upstream would be happy with the patch, as it hijacks the moderator emails (which should link to the admin page) to send out

Re: Review Request 119991: Use Juvia to add comments on the API class pages

On Sept. 8, 2014, 6:22 p.m., Ben Cooksley wrote: What is the status of this? Is there anything blocking it being shipped and made available on api.kde.org? Denis Steckelmacher wrote: It works locally, so I'm just waiting for a ship-it or other comments :-) Aleix Pol Gonzalez

  1   2   >