Re: ops-qc_defer not invoked on ata_exec_internal_sg() paths ?

2008-02-26 Thread Mark Lord
Alan Cox wrote: On Mon, 25 Feb 2008 19:20:59 -0500 Mark Lord [EMAIL PROTECTED] wrote: The optional .qc_defer() methods don't seem to be called on the ata_exec_internal_sg() path. At present, this is probably okay. But in the future, as we add functionality for link power management

Re: [ugly patch] Save .15W-.5W by AHCI powersaving

2008-02-26 Thread Mark Lord
Pavel Machek wrote: Hi! This is a patch (very ugly, assumes you have just one disk) to bring powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch as a base. It saves .5W compared to config with disk spinning, and even .15W compared to hdparm -y... on my thinkpad x60 anyway.

Re: Sata-MV, Intergated Sata Device Support

2008-02-26 Thread Mark Lord
saeed wrote: On Mon, 25 Feb 2008, Jeff Garzik wrote: ... Saeed: isn't this what your SOC patches already implemented for us? As near as I can tell, sata_mv now already has support for the 60x1C0. Saeed's stuff didn't support PCI though, and Jon Li is definitely talking about PCI... yes, my

Re: libata .sg_tablesize: why always dividing by 2 ?

2008-02-26 Thread Mark Lord
Benjamin Herrenschmidt wrote: On Tue, 2008-02-26 at 00:43 -0500, Mark Lord wrote: I suppose so. I don't remember all of the details, but iirc, it has to do with crossing 64K boundaries. Some controllers can't handle it. It's not only the _size_ of the segments, it's their alignment. The iommu

Re: libata .sg_tablesize: why always dividing by 2 ?

2008-02-26 Thread Mark Lord
Mark Lord wrote: Benjamin Herrenschmidt wrote: On Tue, 2008-02-26 at 00:43 -0500, Mark Lord wrote: I suppose so. I don't remember all of the details, but iirc, it has to do with crossing 64K boundaries. Some controllers can't handle it. It's not only the _size_ of the segments, it's

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-25 Thread Mark Lord
Tejun Heo wrote: Mark Lord wrote: .. But no big deal. I can clone code and not bother you any more. In fact, some of the cloned code was already in sata_mv, and I removed it this past week in my local working copy. I'll just restore that, along with another big blob so that we can select pm

Re: Old errata docs

2008-02-25 Thread Mark Lord
Alan Cox wrote: Does anyone have in their posession the old errata docs for the HPT370 controller. I'm seeing two reports now where there is some kind of FIFO corruption pattern (shifted data and duplicated dwords) on the drives which are UDMA100 blacklisted, so presumably more is required for

Re: [ugly patch] Save .15W-.5W by AHCI powersaving

2008-02-25 Thread Mark Lord
Pavel Machek wrote: Hi! This is a patch (very ugly, assumes you have just one disk) to bring powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch as a base. It saves .5W compared to config with disk spinning, and even .15W compared to hdparm -y... on my thinkpad x60 anyway.

libata .sg_tablesize: why always dividing by 2 ?

2008-02-25 Thread Mark Lord
Jeff, We had a discussion here today about IOMMUs, and they *never* split sg list entries -- they only ever *merge*. And this happens only after the block layer has already done merging while respecting q-seg_boundary_mask. So worst case, the IOMMU may merge everything, and then in libata we

Re: Sata-MV, Intergated Sata Device Support

2008-02-25 Thread Mark Lord
Jeff Garzik wrote: Jon Li wrote: Hello, I am curious as to whether there are plans to add support for integrated sata devices. I personally want to add support for a 60x1C0 based device (pci:id = 0x5182). I think adding support should be relatively simple, except for a few issues outlined

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-25 Thread Mark Lord
Tejun Heo wrote: libata doesn't really put much restrictions on what a LLD should do on entering EH and if the controller's behavior is predictable, there's no reason to freeze the port. If the problem is that the DMA engine isn't usable after PMP error but it's known that the controller isn't

ops-qc_defer not invoked on ata_exec_internal_sg() paths ?

2008-02-25 Thread Mark Lord
The optional .qc_defer() methods don't seem to be called on the ata_exec_internal_sg() path. At present, this is probably okay. But in the future, as we add functionality for link power management and hotplug polling, this could be a problem. I think. Or is it possibly also a problem today

Re: libata .sg_tablesize: why always dividing by 2 ?

2008-02-25 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: Jeff, We had a discussion here today about IOMMUs, and they *never* split sg list entries -- they only ever *merge*. And this happens only after the block layer has already done merging while respecting q-seg_boundary_mask. So worst case, the IOMMU may

Re: libata .sg_tablesize: why always dividing by 2 ?

2008-02-25 Thread Mark Lord
Jeff Garzik wrote: As an aside, ISTR tomo-san was working on eliminating the need for the /2 by tackling the details on the IOMMU side... .. Yes, tomo-san just led a nice detailed discussion of it here at LSF'08, and he agrees that even today it shouldn't affect us that way. Cheers - To

Re: libata .sg_tablesize: why always dividing by 2 ?

2008-02-25 Thread Mark Lord
Benjamin Herrenschmidt wrote: On Mon, 2008-02-25 at 19:15 -0500, Jeff Garzik wrote: Mark Lord wrote: Jeff, We had a discussion here today about IOMMUs, and they *never* split sg list entries -- they only ever *merge*. And this happens only after the block layer has already done merging while

Re: libata .sg_tablesize: why always dividing by 2 ?

2008-02-25 Thread Mark Lord
Mark Lord wrote: Benjamin Herrenschmidt wrote: .. The split wasn't done by the iommu. The split was done by the IDE code itself to handle the stupid 64k crossing thingy. If it's done differently now, it might be possible to remove it, I haven't looked. .. The block layer uses

Re: libata .sg_tablesize: why always dividing by 2 ?

2008-02-25 Thread Mark Lord
Benjamin Herrenschmidt wrote: James B. suggests that we stick a WARN_ON() into libata to let us know if that precondition is violated. Sounds like an easy thing to do for a couple of -rc cycles someday. If the block layer gives us a 32k block aligned on a 32k boundary (aligned), we have no

Re: libata .sg_tablesize: why always dividing by 2 ?

2008-02-25 Thread Mark Lord
Benjamin Herrenschmidt wrote: On Mon, 2008-02-25 at 23:38 -0500, Mark Lord wrote: Benjamin Herrenschmidt wrote: James B. suggests that we stick a WARN_ON() into libata to let us know if that precondition is violated. Sounds like an easy thing to do for a couple of -rc cycles someday

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-24 Thread Mark Lord
Tejun Heo wrote: Hello, Mark. Mark Lord wrote: Mark Lord wrote: An alternative to all this, might be to expose the select_pmp() function shown in the sample code, and have libata-pmp.c call that, instead of having the new new .pmp_{read,write} functions. .. I wonder if this might be more

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-24 Thread Mark Lord
Jeff Garzik wrote: Tejun Heo wrote: Yeah, exactly. I think what needs to be done is to separate out SFF assumptions from core layer, factor out SFF-proper helpers and use them to implement LLDs for quasi-SFF controllers. Thinking long term, I continue to hope that SFF support can eventually

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-24 Thread Mark Lord
Tejun Heo wrote: Hello, Mark. Mark Lord wrote: Mark Lord wrote: An alternative to all this, might be to expose the select_pmp() function shown in the sample code, and have libata-pmp.c call that, instead of having the new new .pmp_{read,write} functions. .. I wonder if this might be more

Re: [PATCH] libata: automatically use DMADIR if drive/bridge requires it

2008-02-22 Thread Mark Lord
() is converted to check ATA_DFLAG_DMADIR before setting DMADIR. Original patch is from Mark Lord. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Mark Lord [EMAIL PROTECTED] --- I don't have a bridge which sets DMADIR but so only checked atapi_dmadir parameter. Thanks. The patch looks good

Re: [PATCH] libata: automatically use DMADIR if drive/bridge requires it

2008-02-22 Thread Mark Lord
Mark Lord wrote: I have a funky looking thing here that says SataLink SPiF223A on it (). I wonder what it does? .. Well, after some experimentation, this one appears to be ATA-only, with no ATAPI support at all. Cheers - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Mark Lord
Mark Lord wrote: Tejun, Here's a first cut at this for discussion. You may prefer different names for the invoking functions inside libata-pmp.c, rather than simply pmp_read() and pmp_write(), but I've been up too long and couldn't think of a better name. An alternative to all this, might

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Mark Lord
Mark Lord wrote: Note that, while this does work for sata_mv, I'm still thinking about it. I'm not totally clear yet (more reading to do) as to how/when the ATA shadow/taskfile registers get updated to reflect those for the currently selected pmp.. It would seem that with other parts

Re: ata-piix.c (and libata.ko) in RHEL5.1 (build 78 currently) - this kernel is 2.6.18 baqsed

2008-02-22 Thread Mark Lord
Alan Cox wrote: On Fri, Feb 22, 2008 at 09:52:45AM -0500, Richardson, Charlotte wrote: There is a hack in its probe routine that disables this. I've disabled the hack and ran a long test of hotplugs yesterday (added and removed a DVD drive connected to the ESB2 IDE - this is Intel device

Re: ata-piix.c (and libata.ko) in RHEL5.1 (build 78 currently) - this kernel is 2.6.18 baqsed

2008-02-22 Thread Mark Lord
Alan Cox wrote: 3) It is critical to ensure that the ATA ctl register is never written to when no drive is attached. This means bracketing the SRST sequence to first do a PCS detection before permitting the SRST. If ctl is accessed with no drive attached, the machine locks up hard. At least

Re: 2.6.25-rc2 + smartd = hang

2008-02-22 Thread Mark Lord
Anders Eriksson wrote: [EMAIL PROTECTED] said: The sysrq-e output is probably just standard ext3 journalling unrelated to the problem... what does dmesg say? lspci? What's your hardware setup? dmesg ; smartd ; dmesg yields no new entries in dmesg. It seems on disk accesses are dead.

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: ... And for that matter, is it possible for sata_pmp_read() to be called while the link is active with another command ? Not today, it seems, but what about when hotplug polling gets implemented ? .. That's the one I'm most concerned about. Should I

Re: new ata_port_operations for .pmp_{read,write} ?

2008-02-22 Thread Mark Lord
Mark Lord wrote: An alternative to all this, might be to expose the select_pmp() function shown in the sample code, and have libata-pmp.c call that, instead of having the new new .pmp_{read,write} functions. .. I wonder if this might be more viable than first thought. Say the LLD

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Tejun Heo wrote: Hello, Mark. Mark Lord wrote: Tejun, I've added PMP to sata_mv, and am now trying to get it to work with a Marvell PM attached. And the behaviour I see is very bizarre. After hard+soft resets, the PM signature is found, and libata interrogates the PM registers

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Tejun Heo wrote: The following things are needed for a LLD to support PMP. .. I think that's about it. Feel free to ask if something isn't clear. .. I think we need better semantics around sata_scr_{read,write}(), or more specifically These need to be moved into ata_port_operations so

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Mark Lord wrote: Tejun Heo wrote: The following things are needed for a LLD to support PMP. .. I think that's about it. Feel free to ask if something isn't clear. .. I think we need better semantics around sata_scr_{read,write}(), or more specifically These need to be moved

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Tejun Heo wrote: Mark Lord wrote: Heh... I never thought a PMP aware controller would use TF SRST, so what you want to do is set pmp value in the register and calling ata_std_softreset(), right? I think the correct thing to do is to separate out SRST sequence proper from ata_std_softreset

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Mark Lord wrote: Tejun Heo wrote: Mark Lord wrote: Heh... I never thought a PMP aware controller would use TF SRST, so what you want to do is set pmp value in the register and calling ata_std_softreset(), right? I think the correct thing to do is to separate out SRST sequence proper from

Re: What's needed for PMP support?

2008-02-21 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: .. We already have .pmp_scr_{read,write} operations. If NULL, then default to the built-ins that are there now. .. Mmm.. lost some lines there, try again: We already have .scr_{read,write} operations, and what I think we need are .pmp_scr_{read,write

Re: hdparm-8.2 now available

2008-02-20 Thread Mark Lord
it in there, then the kernel would have to get rebuilt with that config option to enable the feature. Or just switch to the modern libata drivers for IDE/SATA drives. Note also that hdparm has now been updated to version 8.4, with some unrelated bug fixes. Cheers -- Mark Lord Real-Time Remedies Inc

Re: What's needed for PMP support?

2008-02-20 Thread Mark Lord
, including for the PM register accesses. Ever seen anything like this before? Cheers -- Mark Lord Real-Time Remedies Inc. [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] libata-scsi: automatically use DMADIR if drive/bridge requires it

2008-02-20 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: Back in 2.6.17-rc2, a libata module parameter was added for atapi_dmadir. That's nice, but most SATA devices which need it will tell us about it in their IDENTIFY PACKET response, as bit-15 of word-62 of the returned data (as per ATA7, ATA8 specifications

Re: sata_sil24 stability and performance

2008-02-19 Thread Mark Lord
Jim Paris wrote: .. As you may have noticed on this list, power supplies are very frequently a problem. .. Actually, no, I haven't noticed that. :) I do see them more frequently being suggested as a possible problem, and then after some time and expense on the part of the reporters it nearly

atapi_dmadir: why do we not (also) auto-detect it from IDENTIFY PACKET ??

2008-02-18 Thread Mark Lord
Albert / Jeff, Way back in 2.6.17-rc2, you guys signed-off on 95de719adc94392a95c3c4d0a2d6b8b1ea39d236, which added a libata module parameter for atapi_dmadir. That's nice, but many modern drives (or bridge chips) flag this in their IDENTIFY PACKET response, as bit-15 of word-62 of the

Re: [PATCH] libata-scsi: automatically use DMADIR if drive/bridge requires it

2008-02-18 Thread Mark Lord
Alan Cox wrote: On Mon, Feb 18, 2008 at 03:53:46PM -0500, Mark Lord wrote: + /* some SATA bridges need us to indicate data xfer direction */ + if (atapi_dmadir || (dev-id[62] 0x8000)) The rest of the code uses ata_ inlines/defines in ata.h for things like this and religiously

hdparm-8.2 now available

2008-02-18 Thread Mark Lord
devices were unaffected, but drivers/ide devices could misbehave or even be corrupted by some operations. hdparm-8.2 is available at http://sourceforge.net/projects/hdparm/ Upgrading from any earlier 7.x or 8.x version is strongly recommended for all users. Cheers -- Mark Lord Real-Time Remedies

Re: ST31000340NS (1000G) Capacity equal 33MB issue.

2008-02-17 Thread Mark Lord
Richard Liu wrote: Dear Mark: 2008/2/16, Mark Lord [EMAIL PROTECTED]: Mark Lord wrote: Richard Liu wrote: Thanks. By running the above data through hdparm --Istdin, I see that the drive is indeed identifying itself as a 33MB drive. Probably because it has been told to do so by either

Re: ST31000340NS (1000G) Capacity equal 33MB issue.

2008-02-17 Thread Mark Lord
Mark Lord wrote: Richard Liu wrote: .. I downloaded hdparm-8.1 and here is output information. # ./hdparm -N /dev/sdc /dev/sdc: max sectors = 65134/1953525168, HPA is enabled .. Yes, pretty much as expected there. You can safely now try this: ./hdparm -N1953525168 /dev/sdc

Re: ST31000340NS (1000G) Capacity equal 33MB issue.

2008-02-17 Thread Mark Lord
Greg Freemyer wrote: .. Very cool new functionality in [hdparm] 8.1 Looking forward to testing it this week. Thanks for your efforts. I assume DCO is still able to hide sectors from us? .. I'm not sure (haven't tried it here yet). But the way I read the ATA8 specification, it sounds like

Re: [PATCH 1/2] sata_mv: use hpriv-base instead of the host-iomap

2008-02-16 Thread Mark Lord
indicators, if any */ .. This one looks fine. Acked-by: Mark Lord [EMAIL PROTECTED] Cheers - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Spurious completions during NCQ

2008-02-16 Thread Mark Lord
Hugo Mills wrote: I'm getting these on my Dell Latitude D830: Feb 15 13:06:00 willow kernel: ata1.00: exception Emask 0x2 SAct 0x4 SErr 0x0 action 0x2 frozen Feb 15 13:06:00 willow kernel: ata1.00: spurious completions during NCQ issue=0x0 SAct=0x4 FIS=004040a1:0002 Feb 15 13:06:00

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #3

2008-02-16 Thread Mark Lord
Tejun Heo wrote: Andrew Morton wrote: So, I guess it's NACK w/o suggested alternatives, right? I wouldn't nack without good reasons, and I have none here. I don't have very strong opinions either way. I was just wondering whether I should just go with snprintf dancing in eh_link_report,

Re: ST31000340NS (1000G) Capacity equal 33MB issue.

2008-02-16 Thread Mark Lord
Mark Lord wrote: Richard Liu wrote: Dear Mark: 2008/2/15, Mark Lord [EMAIL PROTECTED]: Richard Liu wrote: Hello all: I bought a Seagate ES.2 ST31000340NS (1000GB) and run at Gentoo Linux kernel 2.6.24. But Linux kernel report the disk size only 33MB. I tried Intel ICH5

Re: [PATCH] sata_mv: Define module alias for platform device

2008-02-16 Thread Mark Lord
); #ifdef CONFIG_PCI module_param(msi, int, 0444); .. Acked-by: Mark Lord [EMAIL PROTECTED] Looks safe enough. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ST31000340NS (1000G) Capacity equal 33MB issue.

2008-02-15 Thread Mark Lord
Richard Liu wrote: Dear Mark: 2008/2/15, Mark Lord [EMAIL PROTECTED]: Richard Liu wrote: Hello all: I bought a Seagate ES.2 ST31000340NS (1000GB) and run at Gentoo Linux kernel 2.6.24. But Linux kernel report the disk size only 33MB. I tried Intel ICH5 and Sil3112, but get

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #3

2008-02-14 Thread Mark Lord
Tejun Heo wrote: .. * For timeouts, result TF isn't available and thus res printout is misleading. res shouldn't be printed after timeouts. This would require allocating yest another temp buf and separating out res printing into separate snprintf. .. And snprintf() is buggy, by the way. It

Re: [PATCH 2/2] sata_mv: remove iounmap in mv_platform_remove

2008-02-14 Thread Mark Lord
saeed bishara wrote: this will fix crash bug when doing rmmod to the driver, this is because the port_stop function get called later and it could access the device's registers. Where does the iounmap() now get done instead of that place? nowhere, the /proc/iomem still shows that

Re: [PATCH #upstream] libata: implement libata.force module parameter

2008-02-14 Thread Mark Lord
Tejun Heo wrote: Mark Lord wrote: Tejun Heo wrote: This patch implements libata.force module parameter which can selectively override ATA port, link and device configurations including cable type, SATA PHY SPD limit, transfer mode and NCQ. ... +libata.force=[LIBATA] Force

Re: ST31000340NS (1000G) Capacity equal 33MB issue.

2008-02-14 Thread Mark Lord
Richard Liu wrote: Hello all: I bought a Seagate ES.2 ST31000340NS (1000GB) and run at Gentoo Linux kernel 2.6.24. But Linux kernel report the disk size only 33MB. I tried Intel ICH5 and Sil3112, but get the same result. I don't know this issue was caused by libsata or scsi layer . ..

Re: [PATCH 2/2] sata_mv: remove iounmap in mv_platform_remove

2008-02-14 Thread Mark Lord
saeed bishara wrote: Mmm.. sounds like a bug to me. Possibly two bugs: 1. the ioremap() should fail if the range is already mapped, and 2. we should free the resources on module unload. I suppose this would be mostly automatic if the code simply were to use devm_ioremap() instead of

Re: [PATCH #upstream] libata: implement libata.force module parameter

2008-02-13 Thread Mark Lord
Tejun Heo wrote: This patch implements libata.force module parameter which can selectively override ATA port, link and device configurations including cable type, SATA PHY SPD limit, transfer mode and NCQ. ... + libata.force= [LIBATA] Force configurations. The format is comma +

Re: [PATCH 2/2] sata_mv: remove iounmap in mv_platform_remove

2008-02-13 Thread Mark Lord
; struct ata_host *host = dev_get_drvdata(dev); - struct mv_host_priv *hpriv = host-private_data; - void __iomem *base = hpriv-base; ata_host_detach(host); - iounmap(base); return 0; } .. Where does the iounmap() now get done instead of that place? -- Mark

Re: [PATCH] sata_mv: fix loop with last port

2008-02-07 Thread Mark Lord
later. Signed-off-by: Yinghai Lu [EMAIL PROTECTED] .. Yup, obvious bug fixes, thanks. Signed-off-by: Mark Lord [EMAIL PROTECTED] Index: linux-2.6/drivers/ata/sata_mv.c === --- linux-2.6.orig/drivers/ata/sata_mv.c +++ linux-2.6

Re: sata_mv: problems using it as a platform_driver

2008-02-07 Thread Mark Lord
driver is used as a platform driver, mv_create_dma_pools() is never called so it fails when trying to alloc in mv_pool_start(). Signed-off-by: Byron Bradley [EMAIL PROTECTED] .. Signed-off-by: Mark Lord [EMAIL PROTECTED] diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index f5333ce

Re: sata_mv: problems using it as a platform_driver

2008-02-07 Thread Mark Lord
Byron Bradley wrote: On Fri, 8 Feb 2008, Byron Bradley wrote: I'm having problems getting the sata_mv driver working as a platform driver on the QNAP TS-209 and the Linkstation/Kurobox (both are Marvell Orion 88f5182 based devices). First of all it would oops in mv_port_start() while calling

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-04 Thread Mark Lord
Gene Heskett wrote: On Sunday 03 February 2008, Ingo Molnar wrote: * Gene Heskett [EMAIL PROTECTED] wrote: I believe its the same, but lemme paste it for sure, yes: [ 26.339926] ENABLING IO-APIC IRQs [ 26.340119] ..TIMER: vector=0x31 apic1=0 pin1=0 apic2=-1 pin2=-1 [ 26.350129] ..MP-BIOS

Re: libata pm

2008-02-01 Thread Mark Lord
[EMAIL PROTECTED] wrote: Sorry for my late answer, but i had to sort this out first. After replacing the first PSU with a new Corsair 650W the power no longer fluctuated more than 0,01 V (and this only when booting up the drives...) I did a full resync on both raid arrays and got no more errors

Re: Add one more HITACHI SATA disk to NCQ blacklist

2008-01-31 Thread Mark Lord
Mark Lord wrote: Simos Xenitellis wrote: Hi, The hard disk with model num: HITACHI HTS541616J9SA00 model rev: SB4IC7UP is causing NCQ errors and should be blacklisted. .. https://bugs.edge.launchpad.net/ubuntu/+source/linux-source-2.6.22/+bug/137470 .. That one is for 2.6.22. We

Re: Add one more HITACHI SATA disk to NCQ blacklist

2008-01-31 Thread Mark Lord
Simos Xenitellis wrote: Hi, The hard disk with model num: HITACHI HTS541616J9SA00 model rev: SB4IC7UP is causing NCQ errors and should be blacklisted. Currently the blacklist for Hitachi hard disks includes { HITACHI HDS7250SASUN500G*, NULL,ATA_HORKAGE_NONCQ }, {

Re: DMA mapping on SCSI device?

2008-01-30 Thread Mark Lord
Robert Hancock wrote: Luben Tuikov wrote: --- On Mon, 1/28/08, Robert Hancock [EMAIL PROTECTED] wrote: The trick is that if an ATAPI device is connected, we (as far as I'm aware) can't use ADMA mode, so we have to switch that port into legacy mode. Can you double check this with the HW

Re: [PATCH 09/13] sata_mv ncq Use DMA memory pools for hardware memory tables

2008-01-30 Thread Mark Lord
Jeff Garzik wrote: Nope, not corrupted in transit or on this side. It falls into a familiar pattern: * git-am(1) fails * patch(1) succeeds * when applying patch, patch(1) drops a .orig turd .. Okay, I figured it out. There's a 1-line offset difference between what is used in patch 10,

Re: [PATCH 5/9] libata: implement and use SHT initializers and ops inheritance

2008-01-30 Thread Mark Lord
Tejun Heo wrote: libata lets low level drivers build scsi_host_template and ata_port_operations tables and register them with upper layers. This allows low level drivers high level of flexibility but also burdens them with lots of boilerplate entries in thoes data structures. .. diff --git

Re: [PATCH 09/13] sata_mv ncq Use DMA memory pools for hardware memory tables

2008-01-30 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: Meanwhile, no further action required here. ACK :) And thanks for rounding out the NCQ work. sata_mv has needed love and attention for a while (well, really, its entire life). .. Well, it's going to be getting plenty of TLC over the next few months

Re: DMA mapping on SCSI device?

2008-01-30 Thread Mark Lord
Mark Lord wrote: .. Commands which were not ADMA compatible (eg. MODE_SENSE, TEST_UNIT_READY, ..) were simply handled with PIO (in the driver) rather than any form of DMA, which is okay because those commands are relatively infrequent. .. A slight correction there: TEST_UNIT_READY was fine

Re: [PATCH 09/13] sata_mv ncq Use DMA memory pools for hardware memory tables

2008-01-30 Thread Mark Lord
Tejun Heo wrote: .. I'm skeptical about the benefit of IRQ coalescing on storage controllers. Coalescing improves performance when there are many small requests to complete and if you put a lot of small non-consecutive requests to a disk, it gets really really really slow and IRQ coalescing

Re: [PATCH 5/9] libata: implement and use SHT initializers and ops inheritance

2008-01-30 Thread Mark Lord
Tejun Heo wrote: Mark Lord wrote: Tejun Heo wrote: libata lets low level drivers build scsi_host_template and ata_port_operations tables and register them with upper layers. This allows low level drivers high level of flexibility but also burdens them with lots of boilerplate entries in thoes

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Mark Lord
Gene Heskett wrote: .. Does anyone know why my dvdwriter isn't being assigned a '/dev/sdx' number when dmesg says its found ok at ata2.00? I've turned on an option that says something about using the bios for device access this build, but I'll be surprised if that's it. :) .. It should

Re: [PATCH 1/2] [libata] sata_mv: Remove PCI dependency

2008-01-29 Thread Mark Lord
saeed bishara wrote: Hi Jeff, what is the status of this patch? I'd like to have this patch, and a second part that adds support for the SoC devices, to be merged into 2.6.25. please note that my patch collides with Mark's patches, I don't mind to rebase mine above Mark's patches, but, in that

Re: Make_bad_sector

2008-01-29 Thread Mark Lord
Greg Freemyer wrote: On Jan 28, 2008 3:43 PM, Mark Lord [EMAIL PROTECTED] wrote: Gene Heskett wrote: On Monday 28 January 2008, Mark Lord wrote: .. Another way is to use the make_bad_sector utility that is included in the source tarball for hdparm-7.7, as follows: make_bad_sector

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Mark Lord
rgheck wrote: Alan Cox wrote: not one problem but lots---is sufficiently widespread that a Mini HOWTO, say, would be really welcome and, I'm guessing, widely used. We don't see very many libata problems at the distro level and they for the most part boil down to - sata_nv with 4GB of

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Mark Lord
Gene Heskett wrote: On Tuesday 29 January 2008, Mark Lord wrote: Gene Heskett wrote: .. Does anyone know why my dvdwriter isn't being assigned a '/dev/sdx' number when dmesg says its found ok at ata2.00? I've turned on an option that says something about using the bios for device access

Re: [PATCH 09/13] sata_mv ncq Use DMA memory pools for hardware memory tables

2008-01-29 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: Create host-owned DMA memory pools, for use in allocating/freeing per-port command/response queues and SG tables. This gives us a way to guarantee we meet the hardware address alignment requirements, and also reduces memory that might otherwise be wasted

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Mark Lord
rgheck wrote: Mark Lord wrote: rgheck wrote: Alan Cox wrote: not one problem but lots---is sufficiently widespread that a Mini HOWTO, say, would be really welcome and, I'm guessing, widely used. We don't see very many libata problems at the distro level and they for the most part boil

Re: Problem with ata layer in 2.6.24

2008-01-29 Thread Mark Lord
Gene Heskett wrote: I doubt libata has that capability now, or ever will, cuz these ide/atapi devices are generally dumber than rocks about that. But any device claiming to be scsi-II is supposed to be able to do those sorts of things while the cpu is off crunching numbers for BOINC or

Re: Problem with ata layer in 2.6.24

2008-01-28 Thread Mark Lord
Added Alan to CC: list. [ 30.703188] scsi0 : pata_amd [ 30.709313] scsi1 : pata_amd [ 30.710076] ata1: PATA max UDMA/133 cmd 0x1f0 ctl 0x3f6 bmdma 0xf000 irq 14 [ 30.710079] ata2: PATA max UDMA/133 cmd 0x170 ctl 0x376 bmdma 0xf008 irq 15 [ 30.864753] ata1.00: ATA-6: WDC

Re: Problem with ata layer in 2.6.24

2008-01-28 Thread Mark Lord
Gene Heskett wrote: Greeting; I had to reboot early this morning due to a freezeup, and I had a bunch of these in the messages log: == Jan 27 19:42:11 coyote kernel: [42461.915961] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen Jan 27 19:42:11 coyote kernel:

Re: Problem with ata layer in 2.6.24

2008-01-28 Thread Mark Lord
Gene Heskett wrote: On Monday 28 January 2008, Mark Lord wrote: .. Another way is to use the make_bad_sector utility that is included in the source tarball for hdparm-7.7, as follows: make_bad_sector --readback /dev/sda 474507 Apparently not in the rpm, darnit. .. That's okay. It should

Re: Problem with ata layer in 2.6.24

2008-01-28 Thread Mark Lord
Mark Lord wrote: Gene Heskett wrote: .. And so far no one has tried to comment on those 2 dmesg lines I've quoted a couple of times now, here's another: [0.00] Nvidia board detected. Ignoring ACPI timer override. [0.00] If you got timer trouble try acpi_use_timer_override what

Re: Problem with ata layer in 2.6.24

2008-01-28 Thread Mark Lord
Alan Cox wrote: On Mon, Jan 28, 2008 at 01:38:40PM -0500, Mark Lord wrote: [ 31.195305] ata2.00: ATAPI: LITE-ON DVDRW SHM-165H6S, HS06, max UDMA/66 [ 31.243813] ata2.01: ATA-7: MAXTOR STM3320620A, 3.AAE, max UDMA/100 [ 31.243816] ata2.01: 625142448 sectors, multi 16: LBA48 [ 31.243825

Re: Problem with ata layer in 2.6.24

2008-01-28 Thread Mark Lord
[ 64.037975] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x0 [ 64.038102] ata1.00: BMDMA stat 0x65 [ 64.038227] ata1.00: cmd c8/00:58:89:3d:07/00:00:00:00:00/e0 tag 0 dma 45056 in [ 64.038229] res 51/40:58:8b:3d:07/00:00:00:00:00/e0 Emask 0x9 (media error) [

Re: Problem with ata layer in 2.6.24

2008-01-28 Thread Mark Lord
Gene Heskett wrote: .. That's ok, dd seemed to do the job also. .. The two programs operate entirely differently from each other, so it may still be worth trying the make_bad_sector utility there. dd goes through the regular kernel I/O calls, whereas make_bad_sector sends raw ATA commands

Re: No DMA on a Dell Latitude D820 with 2.6.20

2008-01-27 Thread Mark Lord
Mikel Olasagasti wrote: Hi, I'm having problems with my disk on a Latitude D820 after upgrading kernel to any 2.6.20 No DMA support can be activated, giving me a very poor I/O performance. I'm using ata_piix driver on a ICH7 system with no AHCI support AFAIK .. Actually, no. You are really

Re: [PATCH 02/14] sata_mv Mask transient IRQs.

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: sata_mv Mask transient IRQs. The chips can handle many transient errors internally without a software IRQ. We now mask/ignore those interrupts here. This is necessary for NCQ, later on. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata

Re: [PATCH 05/14] sata_mv Fix EDMA configuration

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: sata_mv Fix EDMA configuration. Simplify and fix EDMA configuration setup to match Marvell specificiations. The chip documentation gives a specific (re)init sequence, which we now follow. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata

Re: [PATCH 07/14] sata_mv Use hqtag instead of ioid

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: sata_mv Use hqtag instead of ioid. Simplify tag handling by using the cid/hqtag field instead of ioid, as recommended by Marvell. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c2008-01-24 12:07:16.0 -0500 +++ new

Re: [PATCH 10/14] sata_mv Use DMA memory pools for hardware memory tables

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: .. static int __init mv_init(void) { +/* Ideally, a device (second parameter) would own these pools. + * But for maximum memory efficiency, we really need one global + * set of each, shared among all like devices. As below

Re: [PATCH 10/14] sata_mv Use DMA memory pools for hardware memory tables

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: .. The amount of memory used in the pre-existing configuration is small, it is already allocated on a per-device basis, and it is statically allocated -- meaning no worry about allocations failing inside of interrupts or similar nastiness. .. Note that there's also no

Re: [PATCH 13/14] sata_mv No soft resets

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: sata_mv No soft resets. Soft resets rarely have significant effect with these chips, so always do a hard reset instead. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c2008-01-24 14:49:28.0 -0500 +++ new/drivers/ata

Re: [PATCH 10/14] sata_mv Use DMA memory pools for hardware memory tables

2008-01-26 Thread Mark Lord
Mark Lord wrote: Jeff Garzik wrote: Mark Lord wrote: .. static int __init mv_init(void) { +/* Ideally, a device (second parameter) would own these pools. + * But for maximum memory efficiency, we really need one global + * set of each, shared among all like devices. As below

Re: [PATCH 10/14] sata_mv Use DMA memory pools for hardware memory tables

2008-01-26 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: Just say exactly what you require here. .. .. repost the whole thing .. .. Okay, will do in a couple of days. -ml - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 02/13] sata_mv ncq Mask transient IRQs

2008-01-26 Thread Mark Lord
The chips can handle many transient errors internally without a software IRQ. We now mask/ignore those interrupts here. This is necessary for NCQ, later on. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-24 11:11:26.0 -0500 +++ new/drivers/ata

[PATCH 03/13] sata_mv ncq Rename base to port mmio

2008-01-26 Thread Mark Lord
Use naming consistent with elsewhere in this driver. This will keep things less confusing when we later add hc_mmio in this function. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-24 11:23:05.0 -0500 +++ new/drivers/ata/sata_mv.c 2008-01-24 11:26

[PATCH 04/13] sata_mv ncq Fix EDMA configuration

2008-01-26 Thread Mark Lord
Simplify and fix EDMA configuration setup to match Marvell specificiations. The chip documentation gives a specific (re)init sequence, which we now follow. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- old/drivers/ata/sata_mv.c 2008-01-24 12:06:25.0 -0500 +++ new/drivers/ata

  1   2   3   4   5   6   >