Re: [osg-submissions] Multi-threaded usage of textures

2017-10-26 Thread Ulrich Hertlein
Hi Anish, Looking at the fix I don't think this works in all cases, it only makes it less likely to occur. The check and the set are still done non-atomically, so another thread could be scheduled inbetween and one update would be lost. My preferred solution would be to use std::atomic with

[osg-submissions] GLDefines typo causing warnings on OS X

2015-03-01 Thread Ulrich Hertlein
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Robert, I believe there is a typo that is causing a 'already defined' compiler warnings on OS X (clang): - --- a/include/osg/GLDefines +++ b/include/osg/GLDefines @@ -177,7 +177,7 @@ typedef char GLchar; #define GL_FRAMEBUFFER_SRGB

[osg-submissions] Patch for FindAVFoundation to work with OS X 10.9

2013-09-07 Thread Ulrich Hertlein
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Index: CMakeModules/FindAVFoundation.cmake === - --- CMakeModules/FindAVFoundation.cmake (revision 13771) +++ CMakeModules/FindAVFoundation.cmake (working copy) @@ -32,7 +32,7 @@

[osg-submissions] Leak fixes for shp loader

2013-07-24 Thread Ulrich Hertlein
Hi Robert, Based on the exchange on osg-users I went ahead and reworked shp/XBaseParser to avoid weird behaviour (closing stdin) and leaking file descriptors, as well as some const-ness. Cheers, /ulrich Index: ESRIShapeReaderWriter.cpp

Re: [osg-submissions] Fix for debug compile; src/osg/glu/libutil/mipmap.cpp

2013-07-02 Thread Ulrich Hertlein
Hi Robert, Quoting Robert Osfield robert.osfi...@gmail.com: Oh forgot to mention, I've checked in my fix to mipmap.c and am currently doing a debug build to make sure the OSG compiles fine. Odd; the 'assert' is in a #ifdef GLES1/2_AVAILABLE, maybe that's different on OS X? I feel the

[osg-submissions] clang++ compiler warning fixed

2013-05-31 Thread Ulrich Hertlein
Hi Robert, attached is a patch that fixes another clang++ compiler warning when returning std::vector::size() as 'unsigned int'. Cheers, /ulrich Index: include/osgGA/GUIEventAdapter === --- include/osgGA/GUIEventAdapter

Re: [osg-submissions] CMakeLists.txt changes for OS X 10.8 (Mountain Lion)

2012-09-07 Thread Ulrich Hertlein
Hi Robert, On 5/09/12 18:51, Robert Osfield wrote: On 21 August 2012 11:50, Ulrich Hertlein u.hertl...@sandbox.de wrote: I realize that there are a lot of commits in the pipeline regarding OS X and iOS Do you mean in the pipeline as about to be posted to osg-submissions by yourself

Re: [osg-submissions] ReaderWriter X reworked

2012-09-07 Thread Ulrich Hertlein
Hi Sukender, hi Robert, After using this patch on a fresh checkout it doesn't build for me on OS X 10.8 with clang++: Linking CXX shared module ../../../lib/osgPlugins-3.1.3/osgdb_x.so Undefined symbols for architecture x86_64: VTT for WriterNodeVisitorDirectX, referenced from:

Re: [osg-submissions] ReaderWriter X reworked

2012-06-14 Thread Ulrich Hertlein
Hi Sukender, I had a quick look at the patch and checked that it still works with the various .x files I have flying around. One thing I did notice in the code is that you're passing 'const std::string' in some places. For the sake of efficiency these chould be replaced with 'const

Re: [osg-submissions] DirectX loader improvement to readIndexList

2012-06-12 Thread Ulrich Hertlein
Hi Michael, On 11/06/12 13:07 , Michael Bach Jensen wrote: Included is an improvement to the DirectX loader to support multiple indexes on the same line. The change is in readIndexList and it uses the same code construction as readMeshFace. Is this patch based on the trunk or the

Re: [osg-submissions] Fix for MatrixTemplate compile errors (OS X, clang++, svn r13050)

2012-04-05 Thread Ulrich Hertlein
Hi David, On 5/04/12 18:16 , David Callu wrote: Patch for this error was already submit by Jordi Torres in Uniform update to OpenGL 420 and Atomic Counter Buffer/Uniform thread Drat, missed that. Can you confirm it work for you ? Yes, the change to Uniform.cpp compiles for me. My patch

Re: [osg-submissions] Automatic version detection of Platform SDK on OS X

2012-03-23 Thread Ulrich Hertlein
Hi Robert, On 23/03/12 21:40 , Robert Osfield wrote: Thanks Erik, I have merged and checked in your changes. I think Ulrich's suggestion of the change APPLE_PLATFORM_SDK_CANONICAL_NAME is sensible so I'll apply this change next. I don't object against changing this name, but you might want

Re: [osg-submissions] Fix warnings on OS X with clang

2012-03-19 Thread Ulrich Hertlein
Hi Erik, On 20/03/12 9:20 , Erik den Dekker wrote: There is still a similar warning that points to a fishy piece of code in the DXF plugin: [ 75%] Building CXX object src/osgPlugins/dxf/CMakeFiles/osgdb_dxf.dir/dxfEntity.cpp.o

Re: [osg-submissions] OSG current working directory

2012-01-04 Thread Ulrich Hertlein
Hi guys, I remember running into this issue as well (a file with the same name in the cwd was picked up instead of the one I was after). It sounds like there's a special case in place to check for the cwd. Could we maybe remove that and instead put . (the cwd) in the first position of the

Re: [osg-submissions] Problem with ShapeDrawable

2011-11-07 Thread Ulrich Hertlein
Hi Klaus, osg-submissions is for code submissions, please re-post to osg-users. Cheers, /ulrich On 5/11/11 0:55 , Klaus Madeira wrote: Hi, I used to draw some spheres in my osg-qt application without problems in 2.8.3 osg version. Yesterday I updated the version to 3.0.1, and then, all

[osg-submissions] mdl reader/writer cleanups so that it works with Unix paths

2011-09-29 Thread Ulrich Hertlein
Hi Robert, attached is a patch for osgPlugins/mdl/MDLReader.cpp that improves its functionality on Unix filesystems. It also includes code cleanups/refactoring. Cheers, /ulrich #include osg/BlendFunc #include osg/BoundingSphere #include osg/Geometry #include osg/Group #include osg/Object

[osg-submissions] Fix for OS X Lion SDK 10.7

2011-08-29 Thread Ulrich Hertlein
Hi, the OS X 10.7 SDK removed the deprecated CGDisplayBitsPerPixel() call. The attached patch provides a fall-back method. Cheers, /ulrich Index: src/osgViewer/DarwinUtils.mm === --- src/osgViewer/DarwinUtils.mm(revision

Re: [osg-submissions] Fix compiling errors in osgSim/ShapeAttribute (rev 12611)

2011-06-24 Thread Ulrich Hertlein
On 24/06/11 15:09 , Martins Innus wrote: I don't use this class, just looking at the patch, but is the change from INTEGER to UNKNOWN intended? Not, that wasn't intended. Thanks for spotting this. /ulrich ___ osg-submissions mailing list

[osg-submissions] osgSim compile fix for OS X

2011-06-23 Thread Ulrich Hertlein
Hi Robert, I had to change this in include/osgSim/ShapeAttribute Index: include/osgSim/ShapeAttribute === --- include/osgSim/ShapeAttribute (revision 12618) +++ include/osgSim/ShapeAttribute (working copy) @@ -96,7 +96,7

Re: [osg-submissions] OS X/Cocoa key remapping quietened

2011-06-17 Thread Ulrich Hertlein
Hi Robert, On 17/06/11 10:31 , Robert Osfield wrote: (Also GraphicsWindowCocoa.mm is still marked as executable, even though I'm up-to-date.) GraphicsWindowCocoa.mm is not an executable on my system and svn::executable property isn't set on it. What happens if you remove the file and

Re: [osg-submissions] minor memory leak in class osg::Shader

2011-03-01 Thread Ulrich Hertlein
Hi Johannes, On 1/03/11 20:29 , Johannes Baeuerle wrote: I agree to the thought of completely avoiding manual memory management. Is the following portable over different stl implementations? std::vectorGLint formats; formats.reserve(numFormats); glGetIntegerv(GL_SHADER_BINARY_FORMATS,

Re: [osg-submissions] minor memory leak in class osg::Shader

2011-02-28 Thread Ulrich Hertlein
Hi Johannes, On 1/03/11 2:53 , Johannes Baeuerle wrote: The problem only arises in a gles2 environment (#if defined(OSG_GLES2_AVAILABLE)). At the beginning of the method a variable 'formats' (a GLint pointer) is declared. In the case when a binary shader could be successfully loaded, the

Re: [osg-submissions] dae/domSourceReader.h build error on OS X, gcc-4.2

2011-01-29 Thread Ulrich Hertlein
template specialization inside the class scope. /ulrich On Fri, Jan 28, 2011 at 4:43 AM, Ulrich Hertlein u.hertl...@sandbox.de wrote: Hi, the changes from r12126 (see below) in dae/domSourceReader.h cause compiler errors on OS X with gcc-4.2.1: In file included from /Users/uli/Projects/osg

[osg-submissions] dae/domSourceReader.h build error on OS X, gcc-4.2

2011-01-27 Thread Ulrich Hertlein
Hi, the changes from r12126 (see below) in dae/domSourceReader.h cause compiler errors on OS X with gcc-4.2.1: In file included from /Users/uli/Projects/osg/OpenSceneGraph/src/osgPlugins/dae/daeRAnimations.cpp:3: /Users/uli/Projects/osg/OpenSceneGraph/src/osgPlugins/dae/domSourceReader.h:43:

Re: [osg-submissions] OpenThreads/win32/Win32Condition.h

2010-12-23 Thread Ulrich Hertlein
Hi Robert, On 23/12/2010, at 21:02, Robert Osfield robert.osfi...@gmail.com wrote: Is the win32/OpenThreads.make and win32/Makefile needed now we have win32/CMakeLists.txt? No, they're not needed for cmake building. Might just be lava from ye olde age. Cheers, -ulrich

[osg-submissions] OpenThreads/win32/Win32Condition.h

2010-12-21 Thread Ulrich Hertlein
Hi Robert, OpenThreads/win32/Win32Condition.h is not used anymore and could be removed from the repository and win32/OpenThreads.mak and win32/CMakeLists.txt. Cheers, /ulrich ___ osg-submissions mailing list osg-submissions@lists.openscenegraph.org

[osg-submissions] osgTerrain typos and docs

2010-12-07 Thread Ulrich Hertlein
Hi Robert, attached are patches to osgTerrain that fix some typos and add a bit of documentation. Cheers, /ulrich Index: include/osgTerrain/Terrain === --- include/osgTerrain/Terrain (revision 11987) +++ include/osgTerrain/Terrain

Re: [osg-submissions] IOS-support (part 2)

2010-12-01 Thread Ulrich Hertlein
Hi guys, On 1/12/10 20:01 , Robert Osfield wrote: I can dive in a merge Ulrich changes right away, bit I'd prefer to have some testing of it by other iOS dev's before merging as I really don't want to risk fixing one set of problems to introduce another. Ulrich, if you think the risk of the

Re: [osg-submissions] IOS-support (part 2)

2010-11-30 Thread Ulrich Hertlein
Hi Robert, hi Stephan, On 30/11/10 20:29 , Robert Osfield wrote: Changes now merged and submitted to svn/trunk, I've created yourself and Ulrich. Does this now mean that svn/trunk is up to par with your git repository? Is it an appropriate time to announce on osg-users that iOS support

Re: [osg-submissions] IOS-support (part 2)

2010-11-30 Thread Ulrich Hertlein
Hi guys, On 30/11/10 20:36 , Ulrich Hertlein wrote: I made some more tweaks to the cmake files, to build for the simulator. I'll test with the merged changes post them after some cleanups. Attached; here's a summary of the changes: - CMakeLists.txt -- don't look for GL when compiling

Re: [osg-submissions] IOS-support (part 2)

2010-11-27 Thread Ulrich Hertlein
Hi Stephan, On 27/11/10 22:55 , Stephan Huber wrote: I think the problem is the addition of the flag -mmacosx-version-min to CMAKE_CXX_FLAGS. When building for IOS, it doesn't make sense, neither for device nor for the simulator. I think this must be some cmake-automatism, as the block in

Re: [osg-submissions] IOS-support (part 2)

2010-11-26 Thread Ulrich Hertlein
Hi guys, On 27/11/10 5:21 , Robert Osfield wrote: I moved the IOS/IPhone blocks in the CMakeLists.txt files into the exisiting IF (APPLE) blocks in a attempt to keep the build on other platforms clean from any of the extra IOS specific variables and CMake script. Fingers crossed I haven't

Re: [osg-submissions] IOS-support (part 1)

2010-11-25 Thread Ulrich Hertlein
On 25/11/10 22:16 , Stephan Maximilian Huber wrote: attached you'll find part one of iphone-support. It includes * support for NPOT-textures on IOS * support for FBOs (only renderToTexture for now) on IOS (should work for other OpenGL ES 1/2 targets, too) * FileUtils-support for IOS Does

[osg-submissions] ReaderWriterFFmpeg.cpp tweaks

2010-11-03 Thread Ulrich Hertlein
Hi Robert, attached is a tiny cleanup for ReaderWriterFFmpeg that provides more accurate descriptions for some extensions and also adds 'm2ts' for MPEG-2 transport streams. Cheers, /ulrich Index: ReaderWriterFFmpeg.cpp === ---

Re: [osg-submissions] Swap Method

2010-09-27 Thread Ulrich Hertlein
Hi Wojciech, On 27/09/10 22:28 , Wojciech Lewandowski wrote: As promised I prepared a patch to expose WGL_SWAP_METHOD / PFD_SWAP_METHOD selection via GraphicsContext::Traits. Since Traits don't define any enums (I guess to be simple to use) I tried to keep it that way and have added two

[osg-submissions] 3ds writer code review

2010-09-20 Thread Ulrich Hertlein
Hi guys, while fixing compiler warnings for the OS X build I noticed this bit in osgPlugins/3ds/WriterNodeVisitor.cpp: code /// Tests if the given string is a path supported by 3DS format (8.3, 63 chars max). bool is3DSpath(const std::string s, bool extendedFilePaths) { ... // For each

[osg-submissions] 3ds writer fixes

2010-09-18 Thread Ulrich Hertlein
Hi Robert, attached is a fix that addresses these compiler warnings from the 64-bit OS X build: /Users/uli/Projects/osg/OpenSceneGraph/src/osgPlugins/3ds/WriterNodeVisitor.cpp: In function ‘std::string getFileName(const std::string)’:

Re: [osg-submissions] [osg-users] osgFX Outline Patch

2010-09-16 Thread Ulrich Hertlein
Hi Robert, On 15/09/10 20:53 , Robert Osfield wrote: that the fix works, but I didn't feel the modifications for the example were appropriate to become the default of this example, as it rather complicates the setup and the final view. Perhaps one could add an command line option to the

Re: [osg-submissions] [osg-users] osgFX Outline Patch

2010-09-15 Thread Ulrich Hertlein
Hi Robertm On 15/09/10 20:53 , Robert Osfield wrote: Hi Ulrich and Todd, I've now reviewed, merged and checked in the changes to src/osgFX/Outline.cpp. Great timing, I was just about to re-post if this ever made it onto osg-submissions, since I didn't get a copy. I did test the modified

Re: [osg-submissions] [osg-users] osgFX Outline Patch

2010-09-04 Thread Ulrich Hertlein
Hi Todd and Robert, On 4/09/10 0:21 , Todd J. Furlong wrote: I made a couple of changes to the osgFX::Outline class (SVN patch attached). I had a couple of issues with it that I was trying to resolve: 1. When an outline object was occluded by another object, the backfacing wireframe was

Re: [osg-submissions] replaced non-portable asprintf()

2010-04-28 Thread Ulrich Hertlein
Hi Mark, On 28/04/10 5:38 , Mark Brand wrote: const char* user_home = xine_get_homedir(); if(user_home) { -char* cfgfile = NULL; -int result = asprintf((cfgfile), %s/.xine/config, user_home); -if

Re: [osg-submissions] toggling vsync support, fix for

2010-04-20 Thread Ulrich Hertlein
Hi Robert, On 20/04/10 21:26 , Robert Osfield wrote: Could you guys provide the required changes? I requested tweaked changes from Ulrich, but appropriate changes from Chris would be just fine too. Sorry, that dropped off my stack. I'll have a look at it tonight. /ulrich

Re: [osg-submissions] toggling vsync support, fix for

2010-03-24 Thread Ulrich Hertlein
On 20/03/10 21:42 , Ulrich Hertlein wrote: W.r.t SCOPE local variable definition, I believe this will lead to warnings about an unused variable when the OSG is built with notification disabled. Perhaps a local #define would do the trick on providing the local SCOPE. Personally though I'm

Re: [osg-submissions] toggling vsync support, fix for

2010-03-20 Thread Ulrich Hertlein
Hi Robert, On 20/03/10 20:51 , Robert Osfield wrote: For now I've just merged the change from init() to _init() as this a bug fix. The vsync enable/disable I'll merged next, but right now I have family life to get on with. Sure, no worries. W.r.t SCOPE local variable definition, I believe

Re: [osg-submissions] osgFX stencil-based outline

2009-12-09 Thread Ulrich Hertlein
Hi Robert, did you forget to commit/add src/osgPlugins/osgFX/IO_Outline.cpp? /ulrich ___ osg-submissions mailing list osg-submissions@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Re: [osg-submissions] osgFX stencil-based outline

2009-12-04 Thread Ulrich Hertlein
On 16/11/09 5:59 PM, Ulrich Hertlein wrote: Hi Robert, attached is a stencil buffer-based constant-width outline f/x with example. I've also modified osgfxbrowser to setup the stencil buffer accordingly. May I 'ping' this submission for the upcoming release? Cheers, /ulrich

Re: [osg-submissions] Vec_n_df unary multiply/divide by vector

2009-11-24 Thread Ulrich Hertlein
On 24/11/09 2:30 PM, Robert Osfield wrote: -/** Unary multiply by vector. */ -inline Vec4f operator *= (const Vec4f rhs) -{ -_v[0]*=rhs[0]; -_v[1]*=rhs[1]; -_v[2]*=rhs[2]; -_v[3]*=rhs[3]; -return *this; -

[osg-submissions] osgFX stencil-based outline

2009-11-16 Thread Ulrich Hertlein
Hi Robert, attached is a stencil buffer-based constant-width outline f/x with example. I've also modified osgfxbrowser to setup the stencil buffer accordingly. Cheers, /ulrich OutlineFX_20091116.tar.bz2 Description: Binary data ___

Re: [osg-submissions] Shared GraphicsContext resources

2009-08-21 Thread Ulrich Hertlein
Hi Colin, nice work! It makes for so much cleaner code just there and would help me immensely with a similar problem. Cheers, /ulrich On 20/08/09 5:00 PM, Colin McDonald wrote: In my application I have a custom graphics context class, derived from osg::GraphicsContext, in order to give

Re: [osg-submissions] fixed (Re: [osg-users] trunk : ffmpeg plugin OS X build error: error: ‘::s trcoll’ has not been declared)

2009-06-25 Thread Ulrich Hertlein
On 24/6/09 7:10 PM, Robert Osfield wrote: Hi Ulrich, I've just made a fix to the FindFFmpeg.cmake, could you do an svn update and double check that it's working fine on your system. Just checked r10406 and the ffmpeg is completely broken, it doesn't even find the header files anymore. cd

Re: [osg-submissions] fixed (Re: [osg-users] trunk : ffmpeg plugin OS X build error: error: ‘::s trcoll’ has not been declared)

2009-06-25 Thread Ulrich Hertlein
Hi Robert, On 25/6/09 12:50 PM, Robert Osfield wrote: Sorry to hear it's broken - mostly likely broken by the previous change, as the last one I checked in just re-enable the build of the plugins as it was accidentally disabled by the previous check-in. Could you try removing your

Re: [osg-submissions] fixed (Re: [osg-users] trunk : ffmpeg plugin OS X build error: error: ‘::s trcoll’ has not been declared)

2009-06-25 Thread Ulrich Hertlein
On 25/6/09 4:14 PM, Robert Osfield wrote: OK, I think I under a bit more now... the change which has broke things for you fixed things under Windows so I'm a bit stuck with exactly what to do about it. I may need to just revert the changes and work out what else to do under Windows.

Re: [osg-submissions] fixed (Re: [osg-users] trunk : ffmpeg plugin OS X build error: error: ‘::s trcoll’ has not been declared)

2009-06-25 Thread Ulrich Hertlein
On 25/6/09 4:27 PM, Robert Osfield wrote: On Thu, Jun 25, 2009 at 3:25 PM, Ulrich Hertleinu.hertl...@sandbox.de wrote: What I do not understand is why this Windows fix, which has IF(WINDOWS) around it, would break anything on OS X? There were two changes. The addition of finding the

Re: [osg-submissions] fixed (Re: [osg-users] trunk : ffmpeg plugin OS X build error: error: ‘::s trcoll’ has not been declared)

2009-06-25 Thread Ulrich Hertlein
Hi Robert and J-S, On 25/6/09 6:13 PM, Jean-Sébastien Guay wrote: Just to tell you I did the following test: - updated OSG to SVN trunk/head. - deleted CMakeCache.txt - re-ran the CMake setup, it found my ffmpeg fine using FFMPEG_DIR environment variable. - built the ffmpeg plugin (which

[osg-submissions] fixed (Re: [osg-users] trunk : ffmpeg plugin OS X build error: error: ‘::s trcoll’ has not been declared)

2009-06-24 Thread Ulrich Hertlein
Hi Robert, On 23/6/09 6:54 PM, Robert Osfield wrote: Thanks for tracking down the issue... sorry about the stdint.h being the cause... hopefully we'll be able to find a solution that works across the board. On Tue, Jun 23, 2009 at 3:41 PM, Ulrich Hertleinu.hertl...@sandbox.de wrote: ...

Re: [osg-submissions] fixed (Re: [osg-users] trunk : ffmpeg plugin OS X build error: error: ‘::s trcoll’ has not been declared)

2009-06-24 Thread Ulrich Hertlein
Hi Robert, On 24/6/09 4:48 PM, Robert Osfield wrote: I haven't had a chance to look at your change yet, but independently made a revision to th FindFFmpeg.cmake to try and resolve this problem and find other problems under Windows. The revision I made disables the search for the stdint.h on

Re: [osg-submissions] local filename takes preference over URL

2009-06-08 Thread Ulrich Hertlein
Hi Robert, On 8/6/09 4:22 PM, Jason Beverage wrote: I just tested with osgEarth and everything looks good to me. Thanks! Same here, looks good. Thanks, /ulrich I have gone for the approach of returning an empty string from findDataFile() when there is a server address at the front

Re: [osg-submissions] local filename takes preference over URL

2009-06-05 Thread Ulrich Hertlein
Hi Jason, On 5/6/09 1:30 AM, Jason Beverage wrote: My workaround in both projects was to add a prefix to the server based URL's like server:http://www.server.com/test.earth;. This caused the CURL plugin to be bypassed b/c it didn't realize it was a URL and the Earth plugin could investigate

[osg-submissions] local filename takes preference over URL

2009-06-04 Thread Ulrich Hertlein
Hi Robert, imagine the following situation: - there is a file earth.ive somewhere in the search path - run osgviewer http://www.openscenegraph.org/data/earth_bayarea/earth.ive; What will happen is that the local file earth.ive is loaded instead of the URL. IMHO this is a bug. The bug is caused

Re: [osg-submissions] local filename takes preference over URL

2009-06-04 Thread Ulrich Hertlein
Hi Robert, On 4/6/09 5:44 PM, Robert Osfield wrote: I'm aware of this issue but re-order the call to the CURL plugin so it goes before other plugins will break other NodeKits such as osgEarth as they rely upon their own plugins catching http calls. By coincidence I had exactly the same problem

Re: [osg-submissions] local filename takes preference over URL

2009-06-04 Thread Ulrich Hertlein
Hi Robert, On 4/6/09 6:26 PM, Robert Osfield wrote: On Thu, Jun 4, 2009 at 5:13 PM, Ulrich Hertleinu.hertl...@sandbox.de wrote: Good point, I thought they only look at filenames like .earth They do, but their plugin still hasn't be called first. Ah, so for things like

[osg-submissions] DirectX stream reading patch

2009-05-26 Thread Ulrich Hertlein
Hi Robert, please find a patch for the DirectX loader to use std::istreams. This will make it usable with the zip plugin. Cheers, /ulrich DirectX-stream.tar.gz Description: GNU Zip compressed data ___ osg-submissions mailing list

[osg-submissions] fix for TrackballManipulator with SCROLL_2D (MacBook Pro touchpad), GUIEventAdapter cleanup

2009-04-27 Thread Ulrich Hertlein
Hi Robert, please find attached a patch for TrackballManipulator to fix zooming using the MBP touchpad. The old code would always zoom-in even when using the gesture to zoom-out. Also attached are some code and documentation cleanups for GUIEventAdapter that collect related values (e.g.

Re: [osg-submissions] fix for TrackballManipulator with SCROLL_2D (MacBook Pro touchpad), GUIEventAdapter cleanup

2009-04-27 Thread Ulrich Hertlein
On 27/4/09 7:03 PM, Ulrich Hertlein wrote: please find attached a patch for TrackballManipulator to fix zooming using the MBP touchpad. The old code would always zoom-in even when using the gesture to zoom-out. I just realised I left some debug printf() in the code. Attached is the cleaned

Re: [osg-submissions] Would like to contribute osg-plugin for ply file (Stanford Triangle Format)

2009-04-01 Thread Ulrich Hertlein
Hi Santosh, On 2/4/09 4:44 AM, Santosh wrote: Attached is the osg-plugin for reading ply ( Stanford Triangle Format ) file. I have written the plugin according to OSG standard and have also added cmake build system. The plugin is working fine on both Linux and Windows and should behave

Re: [osg-submissions] DirectX plugin minor fixes

2009-03-24 Thread Ulrich Hertlein
Hi Aric, On 25/3/09 3:24 AM, Aric Aumann wrote: According to this spec, the frame can contain objects of the type Mesh and a FrameTransformMatrix. I might end up needing to handle the matrices, but at this point I think it's more likely that our modeler can just export models without the

Re: [osg-submissions] FindFFmpeg - the adventure continues ;-)

2009-03-23 Thread Ulrich Hertlein
On 24/3/09 2:44 AM, Robert Osfield wrote: Thanks David, changes look sensible, I've tested then against ffmpeg installed from Ubuntu repositories and svn/trunk of ffmpeg and both are picked up fine. Fingers crossed things will continue working fine under other platforms as well.

Re: [osg-submissions] DirectX plugin minor fixes

2009-03-20 Thread Ulrich Hertlein
Hi Aric, On 20/3/09 9:02 AM, Aric Aumann wrote: I ran into some issues with the directX loader plugin, here's some minor tweaks that helped. ... In directx.cpp: Changed a call from parseFrame to parseSection. The call to the parseFrame function was breaking the recursive brace-tracking

Re: [osg-submissions] FindFFmpeg - the adventure continues ;-)

2009-03-07 Thread Ulrich Hertlein
I need to withdraw the changes to FindFFmpeg.cmake There's something really odd going on with cmake: it detects the proper include directories (like /opt/local/include/ffmpeg for libavformat and /opt/local/include/libavdevice for avdevice) but stores /opt/local/include in CMakeCache so it

Re: [osg-submissions] FindFFmpeg - the adventure continues ;-)

2009-03-07 Thread Ulrich Hertlein
,Hi Robert, On 7/3/09 8:46 PM, Robert Osfield wrote: There's something really odd going on with cmake: it detects the proper include directories (like /opt/local/include/ffmpeg for libavformat and /opt/local/include/libavdevice for avdevice) but stores /opt/local/include in CMakeCache so it

[osg-submissions] FindFFmpeg - the adventure continues ;-)

2009-03-06 Thread Ulrich Hertlein
Hi list, after the latest change away from pkg-config I today found that ffmpeg wouldn't compile anymore on my OS X/DarwinPorts setup. What was happening was that: - first it would search /opt/local/include for avcodec.h not finding anything - then it would search search /opt/local/include

Re: [osg-submissions] Bounds/normals handler

2008-12-14 Thread Ulrich Hertlein
Hi Robert, thanks for having a look through the code and your comments. Quoting Robert Osfield robert.osfi...@gmail.com: If one want to create a custom Node for doing this, then it's place would be in osgFX sitting alongside osgFX::Scribe, and something that acts as a decorator of the

Re: [osg-submissions] OpenEXR / OS X build failure

2008-11-30 Thread Ulrich Hertlein
Quoting Robert Osfield [EMAIL PROTECTED]: didn't merge the changes to the exr/CMakeLists.txt as clearly they were hacked from another CMakeLists.txt file without leaving the orignal entries... Sorry 'bout that. Yes, trunk compiles fine, thanks. /ulrich

[osg-submissions] OpenEXR / OS X build failure

2008-11-29 Thread Ulrich Hertlein
# This module defines # ZLIB_LIBRARY # ZLIB_FOUND, if false, do not try to link to zlib # ZLIB_INCLUDE_DIR, where to find the headers # # $ZLIB_DIR is an environment variable that would # correspond to the ./configure --prefix=$ZLIB_DIR # used in building zlib. # # Created by Ulrich Hertlein

[osg-submissions] .x Reader asciiToFloat

2008-11-25 Thread Ulrich Hertlein
Attached is a patched version that replaces calls to atof() with osg::asciiToFloat(). /ulrich // -*-c++-*- /* * $Id: types.cpp 7747 2007-12-24 15:19:52Z robert $ * * Loader for DirectX .x files. * Copyright (c)2002-2006 Ulrich Hertlein [EMAIL PROTECTED] * * This library is free software

Re: [osg-submissions] BMP loader regression

2008-11-21 Thread Ulrich Hertlein
On 21/11/08 4:29 AM, Robert Osfield wrote: I've just reviewed your bmp fixes and note that you've kept the old code in place but effectively #ifdef'd out. Given the function that you've replace is rather long I think it would be a easy to make Attached is a cleaned-up version of the BMP

Re: [osg-submissions] Saving of stl -ASCII files

2008-11-21 Thread Ulrich Hertlein
On 22/11/08 10:43 AM, [EMAIL PROTECTED] wrote: attached a proposal for an extension for the the stl-File ReaderWriter. It allows saving of an osg node tree as stl file in ASCII-Format. Reminds me that I also have an uncommitted STL writer ... only I'm writing binary files. Would make sense to

Re: [osg-submissions] BMP loader regression

2008-11-20 Thread Ulrich Hertlein
Hi Robert, Quoting Robert Osfield [EMAIL PROTECTED]: is not used at all. My preference would be to remove the old code completely and just use the svn repository as the place for the previous version of the code. I agree, it doesn't make sense to keep dead code in the repository. (What was

[osg-submissions] BMP loader regression

2008-11-17 Thread Ulrich Hertlein
Hi all, on the weekend I noticed some regression in the BMP loader - some 8-bit (paletted) files wouldn't load anymore but simply crash. After taking a look at the current state of the BMP loader I decided it might be worth a shot at reimplementing that part. For example: the current loader

[osg-submissions] examples/CMakeLists.txt osgviewerGLUT

2008-11-03 Thread Ulrich Hertlein
Hi Robert, cmake 2.6 is having trouble on Mac OS X because example/CMakeLists.txt addes subdirectory osgviewerGLUT twice. I took the liberty to remove the second occurrence. Index: CMakeLists.txt === --- CMakeLists.txt

Re: [osg-submissions] Better (?) support for multitexture in OBJ loader

2008-11-03 Thread Ulrich Hertlein
On 31/10/08 9:20 PM, David Spilling wrote: 4) I _think_ the use of the scale and offset parameters on a texture is the reciprocal of what it should be, but I've left it for the moment as none of the packages I have produce files with it in. I have one file (the only one I have that contains

Re: [osg-submissions] ref_ptr that supports safe conversions from ref_ptr instances of other types

2008-10-02 Thread Ulrich Hertlein
Hi, On 2/10/08 4:27 PM, Mathias Fröhlich wrote: Code like this: shared_ptrNode node(new Node); Node* rawNode = node.get(); shared_ptrNode nodePointerWithDifferentReferenceCountObject(rawNode); This will end up with two different reference count instances for a single object instance. Yes,

[osg-submissions] Patch for osgVolume OS X build, ImageStream copy ctor

2008-09-21 Thread Ulrich Hertlein
Hi Robert, attached are a few patches that: - add missing osgUtil link dependency for OS X - fix ImageStream copy constructor - reduce OperationThread verbosity Index: src/osg/ImageStream.cpp === --- src/osg/ImageStream.cpp

Re: [osg-submissions] BUG FIX: osgdb_qt

2008-08-21 Thread Ulrich Hertlein
Guerrero, Michael (CIV) wrote: QuicktimeInitializer() :osg::Referenced() { ... static bool registered = false; if (!registered){ registerQTReader(); } } You forgot to set 'registered=true' after 'registerQTReader()'. (This all feels like it could use a singleton...) /ulrich

Re: [osg-submissions] osgPlugins/obj fix for spacey filenames

2008-07-25 Thread Ulrich Hertlein
Hi Robert, as I hinted at on osg-users in the obj loader: map_* only reads last component thread, this submission broke material/texture loading for some files I have that specify texture matrix scaling. The following link shows a very comprehensive list of .mtl file options:

[osg-submissions] VPB patches for Mac OS X

2008-03-20 Thread Ulrich Hertlein
Hi Robert, attached are two patches to the cmake files and one tweak to Date.cpp to make it compile under Mac OS X. Cheers and have a good Easter, /ulrich vpb-patch.tar.gz Description: GNU Zip compressed data Index: src/vpb/Date.cpp

[osg-submissions] cfg CMakeLists on MacOS X

2007-12-05 Thread Ulrich Hertlein
Hi, attached is a fix I had to make to osgPlugins/cfg/CMakeLists.txt to compile under MacOS X. It was complaining about an undefined reference to osgViewer. /ulrichSET(TARGET_SRC CameraConfig.cpp Camera.cpp ConfigLexer.cpp ConfigParser.cpp ReaderWriterCFG.cpp RenderSurface.cpp