På lørdag 09. april 2016 kl. 06:34:39, skrev Tom Lane >:
Andreas Joseph Krogh writes:
> Any reason $subject didn't make it (commited but reverted)?
See the thread on -committers.
Ah, thanks.
-- Andreas Joseph Krogh
Andreas Joseph Krogh writes:
> Any reason $subject didn't make it (commited but reverted)?
See the thread on -committers.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
Any reason $subject didn't make it (commited but reverted)?
This is a great feature and lots of work seems to have been put into this
patch along with quite some reviewing. It would be nice to know why -hackers
think it's not ready for 9.6.
Thanks.
-- Andreas Joseph Krogh
Jeff Janes writes:
> When I compile now without cassert, I get the compiler warning:
> syncrep.c: In function 'SyncRepUpdateConfig':
> syncrep.c:878:6: warning: variable 'parse_rc' set but not used
> [-Wunused-but-set-variable]
If there's a good reason for that to be an
On April 8, 2016 8:05:31 PM PDT, Tom Lane wrote:
>Alvaro Herrera writes:
>> Robert Haas wrote:
>>> woodlouse and thrips failed like this (and mastodon in a similar but
>>> not identical way):
>>>
>>>
Robert Haas writes:
> prairiedog is not happy about the new plpython error stuff.
Yeah, see my complaint here:
http://www.postgresql.org/message-id/12559.1460141...@sss.pgh.pa.us
I think it's just a matter of avoiding invented-in-this-decade
Pythonisms. The feature
Alvaro Herrera writes:
> Robert Haas wrote:
>> woodlouse and thrips failed like this (and mastodon in a similar but
>> not identical way):
>>
>> "C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1) ->
>>
On 04/08/2016 10:38 PM, Andrew Dunstan wrote:
On 04/08/2016 07:57 PM, Robert Haas wrote:
bowerbird and lorikeet are complaining about the git tree being dirty.
bowerbird is fixed and rebuilding.
lorikeet should be fixed, too.
But bowerbird failed compiling an Assert from commit
Alvaro Herrera wrote:
> Robert Haas wrote:
>
> > crake failed 'make check':
> >
> > *** /home/bf/bfr/root/HEAD/pgsql.build/src/test/regress/expected/misc.out
> > Fri Apr 8 19:38:58 2016
> > --- /home/bf/bfr/root/HEAD/pgsql.build/src/test/regress/results/misc.out
> > Fri Apr 8 19:39:12 2016
> >
On 04/08/2016 07:57 PM, Robert Haas wrote:
bowerbird and lorikeet are complaining about the git tree being dirty.
bowerbird is fixed and rebuilding.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
Kevin Grittner wrote:
> Add the "snapshot too old" feature
>
> This feature is controlled by a new old_snapshot_threshold GUC. A
> value of -1 disables the feature, and that is the default. The
> value of 0 is just intended for testing. Above that it is the
> number of minutes a snapshot can
On Wed, Apr 6, 2016 at 1:23 AM, Fujii Masao wrote:
> Okay, I pushed the patch!
> Many thanks to all involved in the development of this feature!
Thanks, a nice feature.
When I compile now without cassert, I get the compiler warning:
syncrep.c: In function
On Fri, Apr 08, 2016 at 02:57:00PM -0400, Jesper Pedersen wrote:
> On 04/08/2016 02:37 PM, Robert Haas wrote:
> >On Fri, Apr 8, 2016 at 8:49 AM, Jesper Pedersen
> >wrote:
> >>Should we create an entry for the open item list [0] for this, due to the
> >>replication lag
Robert Haas wrote:
> woodlouse and thrips failed like this (and mastodon in a similar but
> not identical way):
>
> "C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1) ->
> "C:\buildfarm\buildenv\HEAD\pgsql.build\ascii_and_mic.vcxproj"
> (Standardziel) (2) ->
>
On 04/08/2016 05:05 PM, Robert Haas wrote:
CommitFest 2016-03 is now closed. I have moved "Twophase transactions
on slave", "Partial sort", and "amcheck (B-Tree integrity checking
tool)" to the next CommitFest in accordance with the policy previous
set by the release management team. I have
On 09/04/16 00:41, Michael Paquier wrote:
On Sat, Apr 9, 2016 at 1:46 AM, Christian Ullrich wrote:
* Andrew Dunstan wrote:
On 04/08/2016 11:02 AM, Christian Ullrich wrote:
src/port/chklocale.c(233): warning C4133: 'function': incompatible
types - from 'const
CommitFest 2016-03 is now closed. I have moved "Twophase transactions
on slave", "Partial sort", and "amcheck (B-Tree integrity checking
tool)" to the next CommitFest in accordance with the policy previous
set by the release management team. I have left "Replace buffer
manager spinlock with
bowerbird and lorikeet are complaining about the git tree being dirty.
prairiedog is not happy about the new plpython error stuff.
woodlouse and thrips failed like this (and mastodon in a similar but
not identical way):
"C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1) ->
On Fri, Mar 18, 2016 at 06:12:12PM -0700, Jeff Janes wrote:
> On Tue, Mar 15, 2016 at 8:36 AM, David Fetter wrote:
> >
> > Please find attached a patch that uses the float8 version to cover the
> > numeric types.
>
> Is there a well-defined meaning for having a negative weight?
Daniel Verite wrote:
> ISTM that this could be avoided by erroring out for lack of an
> explicit 3rd column as argument. IOW, we wouldn't assume
> that "no column specified" means "show all columns".
>
> About simply ripping out the possibility of having multiple
> columns into cells, it's more
From: Tomas Vondra
Subject: Re: [HACKERS] multivariate statistics v14
Date: Fri, 8 Apr 2016 20:55:24 +0200
Message-ID: <5d1d62a6-6228-188c-e079-c1be59942...@2ndquadrant.com>
> On 04/08/2016 05:55 PM, Robert Haas wrote:
>> On Tue, Mar 29, 2016 at 11:18 AM, David
On Fri, Apr 08, 2016 at 01:47:56PM -0700, David Fetter wrote:
> Sorry about the delay. This patch disallows negative weights,
> although it still has that odd difference Jeff found.
Difference corrected. It turned out that my reference was mistaken on
the calculation.
Cheers,
David.
--
David
On Sat, Apr 9, 2016 at 1:46 AM, Christian Ullrich wrote:
> * Andrew Dunstan wrote:
>
>> On 04/08/2016 11:02 AM, Christian Ullrich wrote:
>
>
>>> src/port/chklocale.c(233): warning C4133: 'function': incompatible
>>> types - from 'const char *' to 'LPCWSTR'
On Fri, Apr 8, 2016 at 2:45 PM, Kevin Grittner wrote:
> Add the "snapshot too old" feature
> src/test/modules/Makefile | 1 +
> src/test/modules/snapshot_too_old/Makefile | 47 +++
> .../snapshot_too_old/expected/sto_using_cursor.out |
Peter Eisentraut writes:
> On 01/22/2016 03:46 PM, Tom Lane wrote:
>> Add trigonometric functions that work in degrees.
> I have a host here that is having regression test failures from this commit:
> --- src/test/regress/expected/float8.out
> +++
Noah, Fujii, all,
* Noah Misch (n...@leadboat.com) wrote:
> At the C level, have a pgstattuple function and a pgstattuple_v1_4 function.
> Let them differ only in that the former has a superuser check. Binary
> upgrades will use the former, and fresh CREATE EXTENSION shall use the latter.
On 4/8/16 4:30 PM, Peter Geoghegan wrote:
> On Fri, Apr 8, 2016 at 12:55 PM, Kevin Grittner wrote:
>> Sadly, I forgot to include the reviewer information when writing the
>> commit messages. :-(
>
> Oh well. I'm just glad we got the patch over the line. I think that
> there
On Fri, Apr 8, 2016 at 4:36 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Fri, Apr 8, 2016 at 3:24 PM, David Steele wrote:
>>> Can one of the reviewers decide if this is ready to commit? I fear it
>>> will be pushed to the next
On Sun, Mar 20, 2016 at 03:38:40PM -0700, David Fetter wrote:
> On Sat, Mar 19, 2016 at 05:04:08PM +0100, Tomas Vondra wrote:
> > Hi,
> >
> > On 03/19/2016 07:34 AM, David Fetter wrote:
> > >On Fri, Mar 18, 2016 at 06:12:12PM -0700, Jeff Janes wrote:
> > >>On Tue, Mar 15, 2016 at 8:36 AM, David
Robert Haas writes:
> On Fri, Apr 8, 2016 at 3:24 PM, David Steele wrote:
>> Can one of the reviewers decide if this is ready to commit? I fear it
>> will be pushed to the next CF otherwise. I don't think the committers
>> have time to make that
On Fri, Apr 8, 2016 at 12:55 PM, Kevin Grittner wrote:
> Sadly, I forgot to include the reviewer information when writing the
> commit messages. :-(
Oh well. I'm just glad we got the patch over the line. I think that
there are some types of users that will very significantly
On Thu, Apr 7, 2016 at 6:12 PM, Peter Geoghegan wrote:
> I think that there is a good argument in favor of this patch that you
> may have failed to make yourself, which is: it limits bloat in a way
> that's analogous to how RecentGlobalDataXmin can do so for logical
> decoding
Anastasia,
Attached is the patch to fix pg_dump against older versions, which was
broken in the committed patch.
Thanks!
Stephen
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
new file mode 100644
index 7e6abd7..7c5ae31
*** a/src/bin/pg_dump/pg_dump.c
---
Robert Haas wrote:
> This seems like it might be converging on some sort of consensus, but
> I'm wondering if we shouldn't push it to 9.7, instead of rushing
> decisions that we will later have trouble changing on
> backward-compatibility grounds.
My intention is to commit this afternoon in the
On Fri, Apr 8, 2016 at 7:23 AM, Daniel Verite wrote:
> Alvaro Herrera wrote:
>
>> I wonder if the business of appending values of multiple columns
>> separated with spaces is doing us any good. Why not require that
>> there's a single column in the cell? If the
On Fri, Apr 8, 2016 at 3:24 PM, David Steele wrote:
> On 4/5/16 9:52 PM, Robert Haas wrote:
>> On Mon, Mar 21, 2016 at 3:31 AM, Haribabu Kommi
>> wrote:
>>> On Mon, Mar 21, 2016 at 2:00 PM, Alvaro Herrera
>>> wrote:
On Fri, Apr 8, 2016 at 3:13 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Fri, Apr 8, 2016 at 2:55 PM, Tomas Vondra
>> wrote:
>>> Well, me to. But my feeling is the patch received entirely insufficient
>>> amount of
On 4/5/16 9:52 PM, Robert Haas wrote:
> On Mon, Mar 21, 2016 at 3:31 AM, Haribabu Kommi
> wrote:
>> On Mon, Mar 21, 2016 at 2:00 PM, Alvaro Herrera
>> wrote:
>>> Haribabu Kommi wrote:
>>>
> Check.
>
> +} lookup_hba_line_context;
On Fri, Apr 8, 2016 at 6:52 PM, Robert Haas wrote:
> On Fri, Apr 8, 2016 at 11:00 AM, Andres Freund wrote:
> > On 2016-04-08 10:56:28 -0400, Robert Haas wrote:
> >> On Fri, Apr 8, 2016 at 10:06 AM, David Steele
> wrote:
> >> > On
On Fri, Apr 8, 2016 at 7:39 PM, Andres Freund wrote:
> On 2016-04-07 16:50:44 +0300, Alexander Korotkov wrote:
> > On Thu, Apr 7, 2016 at 4:41 PM, Andres Freund
> wrote:
> >
> > > On 2016-03-31 20:21:02 +0300, Alexander Korotkov wrote:
> > > > !
Robert Haas writes:
> On Fri, Apr 8, 2016 at 2:55 PM, Tomas Vondra
> wrote:
>> Well, me to. But my feeling is the patch received entirely insufficient
>> amount of thorough code review, considering how important part of the code
>> it touches.
2016-04-08 20:54 GMT+02:00 Andrew Dunstan :
>
>
> On 04/08/2016 02:13 PM, Robert Haas wrote:
>
>> On Tue, Apr 5, 2016 at 4:45 AM, Pavel Stehule
>> wrote:
>>
>>> here is cleaned/finished previous implementation of RAW_TEXT/RAW_BINARY
>>> formats for
On Wed, Mar 30, 2016 at 8:02 AM, Alexander Korotkov
wrote:
> Hmm... I'm not completely agree with that. In typical usage partial sort
> should definitely use quicksort. However, fallback to other sort methods is
> very useful. Decision of partial sort usage is made by
> On 08 Apr 2016, at 21:55, Jesper Pedersen wrote:
>
> On 04/08/2016 02:42 PM, Robert Haas wrote:
>> On Tue, Jan 26, 2016 at 7:43 AM, Stas Kelvich
>> wrote:
>>> Hi,
>>>
>>> Thanks for reviews and commit!
>>
>> I apologize for being
On Fri, Apr 8, 2016 at 2:55 PM, Tomas Vondra
wrote:
> Well, me to. But my feeling is the patch received entirely insufficient
> amount of thorough code review, considering how important part of the code
> it touches. I agree docs are an important part of a patch, but
> On 08 Apr 2016, at 21:42, Robert Haas wrote:
>
> On Tue, Jan 26, 2016 at 7:43 AM, Stas Kelvich
> wrote:
>> Hi,
>>
>> Thanks for reviews and commit!
>
> I apologize for being clueless here, but was this patch committed?
> It's still marked
On 04/08/2016 02:37 PM, Robert Haas wrote:
On Fri, Apr 8, 2016 at 8:49 AM, Jesper Pedersen
wrote:
On 04/07/2016 02:29 AM, Michael Paquier wrote:
So recovery is conflicting here. My guess is that this patch is
missing some lock cleanup.
With the test case attached
2016-04-08 20:52 GMT+02:00 Tom Lane :
> Pavel Stehule writes:
> > 2016-04-08 17:38 GMT+02:00 Teodor Sigaev :
> >> thank you, pushed. Pls, pay attention to buildfarm.
>
> > Thank you very much for commit.
>
> According to buildfarm
On 04/08/2016 02:13 PM, Robert Haas wrote:
On Tue, Apr 5, 2016 at 4:45 AM, Pavel Stehule wrote:
here is cleaned/finished previous implementation of RAW_TEXT/RAW_BINARY
formats for COPY statements.
The RAW with text formats means unescaped data, but with correct
On 04/08/2016 05:55 PM, Robert Haas wrote:
On Tue, Mar 29, 2016 at 11:18 AM, David Steele wrote:
On 3/28/16 4:42 AM, Tomas Vondra wrote:
Yes, those are valid omissions. I plan to address them, and I'd also
considering adding a section to 65.1 (How the Planner Uses
On 04/08/2016 02:42 PM, Robert Haas wrote:
On Tue, Jan 26, 2016 at 7:43 AM, Stas Kelvich wrote:
Hi,
Thanks for reviews and commit!
I apologize for being clueless here, but was this patch committed?
It's still marked as "Needs Review" in the CommitFest application.
Pavel Stehule writes:
> 2016-04-08 17:38 GMT+02:00 Teodor Sigaev :
>> thank you, pushed. Pls, pay attention to buildfarm.
> Thank you very much for commit.
According to buildfarm member prairiedog, there's a problem in one
of the test cases. I suspect
Oskari Saarenmaa writes:
> 24.03.2016, 18:03, Tom Lane kirjoitti:
>> I concur. Let's put the left join(s) into those views and call it
>> good.
> Added my patch to the 2016-09 commitfest
> (https://commitfest.postgresql.org/10/601/) as a bug fix as I thought
> not showing all
On Fri, Apr 8, 2016 at 11:42 AM, Tom Lane wrote:
> Seems like a reasonable thing to do, but somebody would have to do the
> legwork to produce back-branch patches.
I'll do so soon. I was waiting on Peter E to take me up on the offer.
--
Peter Geoghegan
--
Sent via
Peter Geoghegan writes:
> On Fri, Apr 8, 2016 at 11:20 AM, Peter Geoghegan wrote:
>> That seems reasonable. I'm glad we finally got this done. Thanks.
> Are we going to backpatch this?
Seems like a reasonable thing to do, but somebody would have to do the
On Tue, Jan 26, 2016 at 7:43 AM, Stas Kelvich wrote:
> Hi,
>
> Thanks for reviews and commit!
I apologize for being clueless here, but was this patch committed?
It's still marked as "Needs Review" in the CommitFest application.
--
Robert Haas
EnterpriseDB:
On Fri, Apr 8, 2016 at 2:36 PM, Stephen Frost wrote:
> While it seems like this particular patch (with myself as committer)
> would meet the requirements stated by the RMT for an extension, having
> considered it over the past day or so, I don't think we should make it a
>
2016-04-08 17:38 GMT+02:00 Teodor Sigaev :
> Thank you very much
>>
>
> thank you, pushed. Pls, pay attention to buildfarm.
>
Thank you very much for commit.
And big thanks to Iacob for big help.
Regards
Pavel
>
> --
> Teodor Sigaev
On Fri, Apr 8, 2016 at 8:49 AM, Jesper Pedersen
wrote:
> On 04/07/2016 02:29 AM, Michael Paquier wrote:
>> So recovery is conflicting here. My guess is that this patch is
>> missing some lock cleanup.
>>
>> With the test case attached in my case the COMMIT PREPARED
* Robert Haas (robertmh...@gmail.com) wrote:
> On Thu, Apr 7, 2016 at 10:17 PM, Michael Paquier
> wrote:
> > On Thu, Apr 7, 2016 at 8:20 AM, Tom Lane wrote:
> >> Robbie Harwood writes:
> >>> Tom Lane
On Fri, Apr 8, 2016 at 11:20 AM, Peter Geoghegan wrote:
> That seems reasonable. I'm glad we finally got this done. Thanks.
Are we going to backpatch this?
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
On Thu, Apr 7, 2016 at 12:20 PM, Kevin Grittner wrote:
> On Thu, Apr 7, 2016 at 8:49 AM, Thomas Munro
> wrote:
>
>> Here is a version that includes an attempt to describe the
>> situation in the documentation.
>
> Pushed with minor adjustments to
On Fri, Apr 8, 2016 at 1:38 PM, Magnus Hagander wrote:
> On Tue, Mar 29, 2016 at 11:24 PM, Christian Ullrich
> wrote:
>
>> * Magnus Hagander wrote:
>>
>> On Tue, Mar 29, 2016 at 5:09 PM, David Steele
>>> wrote:
>>>
>>
>> It seems
On Fri, Mar 18, 2016 at 06:30:35PM +1300, Thomas Munro wrote:
> On Fri, Mar 18, 2016 at 12:49 PM, Marisa Emerson wrote:
> > On 18/03/16 03:57, Thomas Munro wrote:
> >>
> >> You used one name in the docs and another in the code:
> >>
> >> +BSD Authentication on PostgreSQL uses
24.03.2016, 18:03, Tom Lane kirjoitti:
Robert Haas writes:
I am not really in favor of half-fixing this. If we can't
conveniently wait until a dropped role is completely out of the
system, then I don't see a lot of point in trying to do it in the
limited cases where we
Hey, I work with Josh Ma and we were troubleshooting this problem together.
We ended up creating a workaround by taking the dumps from different DBs,
initializing new DBs based on those dumps, and then dumping these new DBs.
This work around worked since the dumps of databases that were
On Thu, Apr 7, 2016 at 8:19 AM, Kyotaro HORIGUCHI
wrote:
> Thank you for looking this and for the comment.
>
> Since the end of this CF is quite soon and this seems in
> uncommittable state, feel free to move this to the next CF if any
> other patch with more
On Thu, Apr 7, 2016 at 10:17 PM, Michael Paquier
wrote:
> On Thu, Apr 7, 2016 at 8:20 AM, Tom Lane wrote:
>> Robbie Harwood writes:
>>> Tom Lane writes:
Wait a second. So the initial
2016-04-08 20:13 GMT+02:00 Robert Haas :
> On Tue, Apr 5, 2016 at 4:45 AM, Pavel Stehule
> wrote:
> > here is cleaned/finished previous implementation of RAW_TEXT/RAW_BINARY
> > formats for COPY statements.
> >
> > The RAW with text formats means
On Fri, Apr 8, 2016 at 11:12 AM, Peter Eisentraut wrote:
> I have committed this so that the comments are only in the first instance in
> each file. I think that should give enough information to someone who is
> curious about the details of the error handling.
>
> Also, I have
On Tue, Apr 5, 2016 at 4:45 AM, Pavel Stehule wrote:
> here is cleaned/finished previous implementation of RAW_TEXT/RAW_BINARY
> formats for COPY statements.
>
> The RAW with text formats means unescaped data, but with correct encoding -
> input/output is realised with
On 04/07/2016 09:36 PM, Peter Geoghegan wrote:
On Thu, Apr 7, 2016 at 6:08 PM, Peter Eisentraut wrote:
I wish we could avoid the huge, repeated comment blocks. Perhaps we could
put them at the top of the files once?
I'm fine with that. Do you want to take care of that, or
Marisa Emerson writes:
> Woops, fix attached.
Pushed with minor adjustments.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Apr 8, 2016 at 11:57 AM, Robert Haas wrote:
> On Wed, Apr 6, 2016 at 5:28 PM, David Rowley
> wrote:
>>> Is that everything now? I don't see anything about combining aggs in the git
>>> log and this is still showing as UnCommitted in
On Fri, Apr 8, 2016 at 12:27 PM, Paul Ramsey wrote:
> Insofar as the patch is throttling how many parallel workers you get
> based solely on your relsize, it does concern this patch, but it's a
> general issue in both the extreme and not obviously related costings
>
* Andrew Dunstan wrote:
On 04/08/2016 11:02 AM, Christian Ullrich wrote:
src/port/chklocale.c(233): warning C4133: 'function': incompatible
types - from 'const char *' to 'LPCWSTR' [...\postgres.vcxproj]
Do you have a fix for the LPCWSTR parameter issue?
As long as the locale short
On 04/08/2016 12:24 PM, Christian Ullrich wrote:
* Tom Lane wrote:
+several. Grepping for compiler warnings, for example, is really
painful
right now on any MSVC critter. I've resorted to grepping for
"warning C",
which skips the noise messages, but I'm never sure if I'm missing
On 09/04/16 02:58, Magnus Hagander wrote:
On Fri, Apr 8, 2016 at 4:56 PM, Robert Haas > wrote:
On Fri, Apr 8, 2016 at 10:06 AM, David Steele > wrote:
> On 4/8/16 10:00 AM, Tom Lane
On 2016-04-07 16:50:44 +0300, Alexander Korotkov wrote:
> On Thu, Apr 7, 2016 at 4:41 PM, Andres Freund wrote:
>
> > On 2016-03-31 20:21:02 +0300, Alexander Korotkov wrote:
> > > ! BEGIN_BUFSTATE_CAS_LOOP(bufHdr);
> > >
> > > ! Assert(BUF_STATE_GET_REFCOUNT(state) >
David Steele writes:
> On 4/8/16 11:20 AM, Robert Haas wrote:
>> Should we commit this patch?
> To summarize:
> Robert Haas and Peter Eisentraut have done code-only reviews. Thomas
> Munro has reviewed and tested with a caveat that he is no BSD expert.
> Pierre-Emmanuel
On Fri, Apr 8, 2016 at 9:06 AM, Simon Riggs wrote:
> On 8 April 2016 at 17:00, Paul Ramsey wrote:
>>
>> On Fri, Apr 8, 2016 at 8:23 AM, Robert Haas wrote:
>> > On Fri, Apr 8, 2016 at 1:22 AM, Amit Kapila
On Fri, Apr 8, 2016 at 9:00 PM, Andres Freund wrote:
>
> On 2016-03-31 15:07:22 +0530, Amit Kapila wrote:
> > I think we should change comments on top of this function. I have
changed
> > the comments as per my previous patch and attached the modified patch
with
> > this
* Tom Lane wrote:
+several. Grepping for compiler warnings, for example, is really painful
right now on any MSVC critter. I've resorted to grepping for "warning C",
which skips the noise messages, but I'm never sure if I'm missing
something.
You miss all diagnostics from other tools than
On 4/2/16 4:21 PM, Konstantin Knizhnik wrote:
> Thank you for review, Tom.
>
> I completely agree with all your arguments against this patch.
> I have proposed this patch mostly as prove of concept.
I have marked this "returned with feedback". Hopefully you can work on
the concept and resubmit
On 04/08/2016 11:02 AM, Christian Ullrich wrote:
* Michael Paquier wrote:
On Fri, Apr 8, 2016 at 10:05 PM, Andrew Dunstan
wrote:
¥> On 04/08/2016 07:15 AM, Christian Ullrich wrote:
Michael, none of your patches change this, so how does it ever
build on
your system?
On 8 April 2016 at 17:00, Paul Ramsey wrote:
> On Fri, Apr 8, 2016 at 8:23 AM, Robert Haas wrote:
> > On Fri, Apr 8, 2016 at 1:22 AM, Amit Kapila
> wrote:
> >> Other than that, patch looks good and I have marked it as
On Fri, Apr 8, 2016 at 8:23 AM, Robert Haas wrote:
> On Fri, Apr 8, 2016 at 1:22 AM, Amit Kapila wrote:
>> Other than that, patch looks good and I have marked it as Ready For
>> Committer. Hope, we get this for 9.6.
>
> Committed. I think this is
On 8 April 2016 at 16:00, Andres Freund wrote:
I've finished polishing the Pin/Unpin patch. But the final polishing
> happened on an intercontential flight, after days spent preparing my
> move to SF. I'd be glad if you would allow me to look over the patch
> again, before
On Wed, Apr 6, 2016 at 5:28 PM, David Rowley
wrote:
>> Is that everything now? I don't see anything about combining aggs in the git
>> log and this is still showing as UnCommitted in the CF app.
>
> There's just a documentation patch and two combine functions for
>
On Tue, Mar 29, 2016 at 11:18 AM, David Steele wrote:
> On 3/28/16 4:42 AM, Tomas Vondra wrote:
>> Yes, those are valid omissions. I plan to address them, and I'd also
>> considering adding a section to 65.1 (How the Planner Uses Statistics),
>> explaining more thoroughly how
On 4/8/16 11:20 AM, Robert Haas wrote:
> On Fri, Apr 8, 2016 at 6:48 AM, Pierre-Emmanuel André
> wrote:
>> On Fri, Mar 18, 2016 at 06:30:35PM +1300, Thomas Munro wrote:
>>> On Fri, Mar 18, 2016 at 12:49 PM, Marisa Emerson wrote:
On 18/03/16 03:57, Thomas
On Fri, Apr 8, 2016 at 11:00 AM, Andres Freund wrote:
> On 2016-04-08 10:56:28 -0400, Robert Haas wrote:
>> On Fri, Apr 8, 2016 at 10:06 AM, David Steele wrote:
>> > On 4/8/16 10:00 AM, Tom Lane wrote:
>> >> David Steele writes:
>>
On Fri, Apr 8, 2016 at 10:04 AM, Constantin S. Pan wrote:
> Here is a new version of the patch, which:
>
> 1. Fixes some minor stylistic issues.
>
> 2. Uses binaryheap (instead of a custom ugly stack) for merging.
I think we need to push this patch out to 9.7. This code has
Thank you very much
thank you, pushed. Pls, pay attention to buildfarm.
--
Teodor Sigaev E-mail: teo...@sigaev.ru
WWW: http://www.sigaev.ru/
--
Sent via pgsql-hackers mailing list
On 2016-04-08 13:07:05 +0530, Amit Kapila wrote:
> I think by now, we have done many tests with both approaches and we find
> that in some cases, it is slightly better and in most cases it is neutral
> and in some cases it is worse than group clog approach. I feel we should
> go with group clog
On 2016-03-31 15:07:22 +0530, Amit Kapila wrote:
> I think we should change comments on top of this function. I have changed
> the comments as per my previous patch and attached the modified patch with
> this mail, see if that makes sense.
I've applied this patch.
Regards,
Andres
--
Sent
2016-04-08 16:46 GMT+02:00 nummervet nummervet :
> That didn't work for me:
>
> ERROR: syntax error at or near "$"
> LINE 1: ...ibute_id, set_id ) (select $."151", '...
>
should be $1
Regards
Pavel
>
>
> Пятница, 8 апреля 2016, 17:25 +03:00 от Pavel Stehule <
>
On Fri, Apr 8, 2016 at 1:22 AM, Amit Kapila wrote:
> Other than that, patch looks good and I have marked it as Ready For
> Committer. Hope, we get this for 9.6.
Committed. I think this is likely to make parallel query
significantly more usable in 9.6.
--
Robert Haas
On Fri, Apr 8, 2016 at 6:48 AM, Pierre-Emmanuel André wrote:
> On Fri, Mar 18, 2016 at 06:30:35PM +1300, Thomas Munro wrote:
>> On Fri, Mar 18, 2016 at 12:49 PM, Marisa Emerson wrote:
>> > On 18/03/16 03:57, Thomas Munro wrote:
>> >>
>> >> You used one name in
08.04.2016 15:45, Anastasia Lubennikova:
08.04.2016 15:06, Teodor Sigaev:
On Wed, Apr 6, 2016 at 1:50 PM, Peter Geoghegan wrote:
Personally, I like documenting assertions, and will sometimes write
assertions that the compiler could easily optimize away. Maybe going
*that* far
1 - 100 of 150 matches
Mail list logo