from:"David Redondo"

D25086: Port to KGlobalAccel

2019-11-16 Thread David Redondo

davidre added a comment.


  No, I wanted to let David take a second look. But I can commit later.

REPOSITORY
  R103 KMenu Editor

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25191: replace bespoke xkb geometry parser with xkb

2019-11-14 Thread David Redondo

davidre added a comment.


  Is the FooBar class for testing? I don't see it used anywhere. (and would 
guess soofrom the name)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25191

To: sitter, #plasma
Cc: davidre, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-13 Thread David Redondo

davidre added a comment.


  In D25273#561847 , @ngraham wrote:
  
  > Also, the combobox's model appears to have duplicates for Breeze, Breeze 
Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for 
me: F7760168: Screenshot_20191112_221936.png 

  
  
  I think I know what's happening. Do you have Breeze installed into the same 
prefix as cuttlefish in addition to system breeze? After doing so I also see 
the duplicate color. (The same happens in Kate)

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-13 Thread David Redondo

davidre updated this revision to Diff 69667.
davidre added a comment.


  Load initial color scheme name from the respective .colors file

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25273?vs=69639=69667

BRANCH
  colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-13 Thread David Redondo

davidre added a comment.

  In D25273#561845 , @ngraham wrote:

  > Nice, it's good to get rid of so much boilerplate.
  >
  > However when I change the system's own color scheme from Breeze to anything 
else and start Cuttlefish, the app itself uses that color scheme as expected, 
but the combobox's text is blank: F7760159: Screenshot_20191112_221601.png 

  I see what's happening. I copied that code form Kate and it reads the current 
color scheme name from kdeglobals but there can be a difference between the 
stored name and the user visible name. Especially when it includes a space or 
hyphen. So it works correctly for Breeze or Oxygen but not Breeze Dark or 
Oxygen cold.

  In D25273#561847 , @ngraham wrote:

  > Also, the combobox's model appears to have duplicates for Breeze, Breeze 
Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for 
me: F7760168: Screenshot_20191112_221936.png 

  Since this directly uses KColorSchemeManager, do you also see duplicated 
entries in Kate's color scheme menu?

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> main.cpp:130
> +engine.rootContext()->setContextProperty("colorSchemes", colorSchemes);
> +engine.load(QUrl::fromLocalFile(package.filePath("mainscript")));
> +

Moving the setting of the context properties before loading of the file fixes 
these being unavailable at the beginning. => Less errors on startup and we can 
select the the current color scheme on startup because the index isn't reset 
when the color scheme model becomes available.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo

davidre updated this revision to Diff 69639.
davidre added a comment.


  Was a typo

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25273?vs=69637=69639

BRANCH
  colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo

davidre planned changes to this revision.
davidre added a comment.


  I somehow broke it before uploading

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  By using KColorSchemeManager we can enable viewing icons with all installed
  color schemes.

REPOSITORY
  R118 Plasma SDK

BRANCH
  colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25261: [sddm-theme] Fix initial focus after SDDM QQC2 Port

2019-11-12 Thread David Redondo

davidre added a comment.


  Seems to work

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25261

To: davidedmundson, #plasma
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: Port to KGlobalAccel

2019-11-11 Thread David Redondo

davidre updated this revision to Diff 69577.
davidre marked 2 inline comments as done.
davidre added a comment.


  QLatin1String

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69483=69577

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  kconf_update/CMakeLists.txt
  kconf_update/globalaccel.cpp
  kconf_update/globalaccel.upd
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

2019-11-08 Thread David Redondo

davidre updated this revision to Diff 69483.
davidre added a comment.


  update application for migration based on the one I did for spectacle

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69279=69483

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  kconf_update/CMakeLists.txt
  kconf_update/globalaccel.cpp
  kconf_update/globalaccel.upd
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25157: [Slideshow] Reenable other modes

2019-11-06 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d0df800b46f9: [Slideshow] Reenable other modes (authored 
by davidre).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25157?vs=69309=69335

REVISION DETAIL
  https://phabricator.kde.org/D25157

AFFECTED FILES
  wallpapers/image/slidefiltermodel.cpp

To: davidre, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

2019-11-06 Thread David Redondo

davidre added a comment.

  In D25086#559109 , @mlaurent wrote:

  > For me it seems ok
  >
  > Did you finish it ? is it work ? or still in progress ?

  Shortcut setting and displaying works so far in my testing.
  I still need to do the migration of existing shortcuts otherwise if user had  
set a shortcut though kmenuedit before it wouldn't be displayed in kmenuedit 
(although it would be functional).

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25157: [Slideshow] Reenable other modes

2019-11-05 Thread David Redondo

davidre created this revision.
davidre added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Was accidentally removed in 9dca7d6cd44cbb16c6d7fb1aca5588760544b1d6 


TEST PLAN
  Other sort modes work

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mode (branched from Plasma/5.17)

REVISION DETAIL
  https://phabricator.kde.org/D25157

AFFECTED FILES
  wallpapers/image/slidefiltermodel.cpp

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-05 Thread David Redondo

davidre updated this revision to Diff 69301.
davidre marked an inline comment as done.
davidre added a comment.


  - const
  - System services

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25144?vs=69287=69301

BRANCH
  categorize (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25144

AFFECTED FILES
  kcms/keys/kglobalshortcutseditor.cpp

To: davidre, #plasma, mlaurent
Cc: mlaurent, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-04 Thread David Redondo

davidre added a comment.


  In D25144#558670 , @ngraham wrote:
  
  > Hmm, I think that would be confusing. "Session" isn't the name of any 
user-facing applications. That stuff is really a part of Plasma, both 
technically speaking, and also in terms of the user expectation. Is there any 
way we could force it to live in the Plasma/System Services section?
  
  
  Hmm it seems I failed to make myself clear. The *current* kcm just reads 
whether a component's unique name end with ".desktop" and categorizes on that 
while this patch uses `KService::isApplication`. In fact David's patch inspired 
inspired me to this since I noticed this problem when thinking about it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-04 Thread David Redondo

davidre added a comment.


  In D25144#558665 , @ngraham wrote:
  
  > In D25144#558663 , @davidre 
wrote:
  >
  > > In D25144#558630 , @ngraham 
wrote:
  > >
  > > > However I see a problem with changing "Application Launchers" to 
"Applications": It implies that the items in that category will give you access 
to change all the shortcuts for those applications, which it does not do. If we 
want to make this change, I think we'd need to actually put all of each app's 
shortcuts into its item in that list, assuming that's possible.
  > >
  > >
  > > I don't think that's implied when the Settings page is titled "Global 
Shortcuts". The category is about about global shortcuts that relate to 
Application.
  >
  >
  > All right, I suppose that makes sense.
  >
  > > Also note that it will be an improvement when eventually more shortcuts 
are moved to desktop files. For example the "Lock Session" shortcut would end 
up in "Application Launchers" with D24877 .
  >
  > Under which entry? That seems odd.
  
  
  The user facing name which would be Session. As I wrote the current code only 
looks if the component name ends with .desktop so you would have "Session" 
inside "Application Launchers".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-04 Thread David Redondo

davidre added a comment.


  In D25144#558630 , @ngraham wrote:
  
  > However I see a problem with changing "Application Launchers" to 
"Applications": It implies that the items in that category will give you access 
to change all the shortcuts for those applications, which it does not do. If we 
want to make this change, I think we'd need to actually put all of each app's 
shortcuts into its item in that list, assuming that's possible.
  
  
  I don't think that's implied when the Settings page is titled "Global 
Shortcuts". The category is about about global shortcuts that relate to 
Application.
  Also note that it will be an improvement when eventually more shortcuts are 
moved to desktop files. For example the "Lock Session" shortcut would end up in 
"Application Launchers" with D24877 .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

2019-11-04 Thread David Redondo

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Currently the shortcuts are divided into two lists. "Application Launchers" 
for
  shortcuts added via .desktop files (actually components with names that end in
  ".desktop") and "Other Shortcuts" for everything else. This not only exposes 
an
  implementation detail but also is not helpful to the average user who doesn't
  know what is meant with "Application Launcher" is. It can't be about 
Applications
  since Konversation is found under "Other Shortcuts" but it is also not about
  launching since other shortcuts can also be found there (for example see
  Spectacle). Furthermore if one adds an shortcut to launch an application in
  kmenuedit the shortcut is not found in "Application Launchers" but in
  "Other Shortcuts" under KDE Daemon (addressed in D25086 
).
  This patch tries to categorize the components into Applications and Plasma by
  trying harder to get a corresponding `KService` and then deciding upon
  `isApplication` if a Component falls into the applications category. Because
  components are free to set their uniquea and friendly names themselves it is
  also checked if there is  a service with Name. With this it is possible to 
get a
  KService for konversation for example.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  categorize (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25144

AFFECTED FILES
  kcms/keys/kglobalshortcutseditor.cpp

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

2019-11-04 Thread David Redondo

davidre updated this revision to Diff 69279.
davidre marked an inline comment as done.
davidre added a comment.


  Thanks for spotting!

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69107=69279

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25100: Mark all wallpaper plugins as addons

2019-10-31 Thread David Redondo

davidre added a comment.


  I don't know how Discover works but to me looks the wrong fix. Does every 
third party wallpaper then also need to have a name with plasma in it?
  In my opinion ServiceType Plasma/Wallpaper should be enough for a Service as 
add-on and not having plasma in it's name.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25100

To: ngraham, apol, mak, #plasma
Cc: davidre, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> globalaccel.cpp:50
> +
> +QKeySequence GlobalAccel::getMenuEntryShortcut(const QString )
> +{

I think the list that is returned can have up to 2 entries. The shortcut and 
the alternate shortcut. However the currently Gui shows/configures only one 
shortcut.

> globalaccel.h:27
> +public:
> +static QKeySequence getMenuEntryShortcut(const QString );
> +static void changeMenuEntryShortcut(const QString , const 
> QKeySequence );

I just used the old names.

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread David Redondo

davidre updated this revision to Diff 69107.
davidre marked 4 inline comments as done.
davidre added a comment.


  - comments

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69105=69107

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread David Redondo

davidre marked an inline comment as done.
davidre added inline comments.

INLINE COMMENTS

> mlaurent wrote in CMakeLists.txt:39
> Why removing it ?

Accidentally

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread David Redondo

davidre updated this revision to Diff 69105.
davidre added a comment.


  - Don't delete disabled
  - Remove guards

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69095=69105

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: [WIP] Port to KGlobalAccel

2019-10-31 Thread David Redondo

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Replace KHotkeys with KGlobalAccel
  WIP because of missing migration

REPOSITORY
  R103 KMenu Editor

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24985: [wallpapers/image] Seed random number generator

2019-10-29 Thread David Redondo

davidre accepted this revision.
davidre added a comment.


  I think this is fine. Imo we can address the comments on master

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24985

To: davidedmundson, #plasma, ngraham, davidre
Cc: davidre, apol, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24986: [wallpapers/image] Randomise new batches of images in the slideshow

2019-10-28 Thread David Redondo

davidre added a comment.


  To clarify my comment refers to
  
  > The logic is fine but if we start with 0 wallpapers and then add 20 newones 
we don't shuffle anything.
  
  For the other cases shuffling the added images is probably the right thing

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24986

To: davidedmundson, #plasma, ngraham
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24986: [wallpapers/image] Randomise new batches of images in the slideshow

2019-10-28 Thread David Redondo

davidre added a comment.


  Are you sure? Shouldn't we be hitting this case:
  
https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/image.cpp#n773 ?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24986

To: davidedmundson, #plasma, ngraham
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

2019-10-23 Thread David Redondo

davidre added a comment.


  > We would need some way to hide the default _launch entry
  
  I don't think that is a problem.  I think we  could wrap 
https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n119
 in an if and only register _launch if the [Desktop Entry]  has an Exec line?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24877

To: davidedmundson, #plasma
Cc: davidre, apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24890: Report windowing system

2019-10-23 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:8b8f813620b5: Report windowing system (authored by 
davidre).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24890?vs=68607=68608

REVISION DETAIL
  https://phabricator.kde.org/D24890

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/bugzillaintegration/reportinterface.cpp
  src/systeminformation.cpp
  src/systeminformation.h

To: davidre, sitter
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D24890: Report windowing system

2019-10-23 Thread David Redondo

davidre updated this revision to Diff 68607.
davidre added a comment.


  report Unknown

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24890?vs=68604=68607

BRANCH
  windowsystem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24890

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/bugzillaintegration/reportinterface.cpp
  src/systeminformation.cpp
  src/systeminformation.h

To: davidre, sitter
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D24890: Report windowing system

2019-10-23 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> CMakeLists.txt:30
> -Notifications IdleTime)
> -if(APPLE)
> -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS WindowSystem)

I don't know but I  just moved the find_package WindowSystem out of the if 
because now it would be needed unconditionally.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D24890

To: davidre, sitter
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D24890: Report windowing system

2019-10-23 Thread David Redondo

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Sometimes applications have different code paths for X11 or Wayland. Drkonqi
  reporting that saves one "question -> wait for reply -> period until reply is
  seen"-cycle.

TEST PLAN
  Try it in test mode

REPOSITORY
  R871 DrKonqi

BRANCH
  windowsystem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24890

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/bugzillaintegration/reportinterface.cpp
  src/systeminformation.cpp
  src/systeminformation.h

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24723: Fix slideshow crashing in invalidate()

2019-10-21 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a1cf305ffb21: Fix slideshow crashing in invalidate() 
(authored by davidre).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24723?vs=68304=68407

REVISION DETAIL
  https://phabricator.kde.org/D24723

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h

To: davidre, #plasma, broulik
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

2019-10-19 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:a81d0ca787d7: Draw categories in iconview in a similiar 
style as Kirigami and new… (authored by davidre).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24533?vs=67603=68306

REVISION DETAIL
  https://phabricator.kde.org/D24533

AFFECTED FILES
  icons/CategoryDrawer.cpp
  icons/CategoryDrawer.h

To: davidre, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24723: Fix slideshow crashing in invalidate()

2019-10-19 Thread David Redondo

davidre updated this revision to Diff 68304.
davidre added a comment.


  Build the new order only after setting the source model.
  In invalidate just shuffling is enough.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24723?vs=68302=68304

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24723

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h

To: davidre, #plasma
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24723: Fix slideshow crashing in invalidate()

2019-10-19 Thread David Redondo

davidre updated this revision to Diff 68302.
davidre marked 3 inline comments as done.
davidre added a comment.


  Like this?
  I also changed the condition in image.cpp otherwise the order wouldn't have 
been random on the first run with these changes.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24723?vs=68117=68302

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24723

AFFECTED FILES
  wallpapers/image/image.cpp
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h

To: davidre, #plasma
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24723: Fix slideshow crashing in invalidate()

2019-10-17 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> slidefiltermodel.cpp:51
> +if(sourceModel) {
> +connect(sourceModel, ::rowsInserted, this, 
> ::invalidate);
> +connect(sourceModel, ::rowsRemoved, this, 
> ::invalidate);

Good point. No need to invalidate in the other cases.

Maybe. It depends where images are added in the model? Maybe we would end up 
showing pictures again because the indexes have shifted? Or the new images are 
always shown at the end because they get appended? Either way I think that*'s 
not to bad if the order is set to Random. The result could also be the result 
of a random permutation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24723

To: davidre, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24723: Fix slideshow crashing in invalidate()

2019-10-17 Thread David Redondo

davidre updated this revision to Diff 68117.
davidre added a comment.


  Simplify the logic. In configmode we don't need the random order. We just
  use the order of the underlying model.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24723?vs=68115=68117

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24723

AFFECTED FILES
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24723: Fix slideshow crashing in invalidate()

2019-10-17 Thread David Redondo

davidre updated this revision to Diff 68115.
davidre added a comment.


  Need rebuild here, rowCount could have changed

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24723?vs=68114=68115

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24723

AFFECTED FILES
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24723: Fix slideshow crashing in invalidate()

2019-10-17 Thread David Redondo

davidre created this revision.
davidre added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  QSortFilterProxyModel uses std::stable_sort internally which requires that the
  comparison function generates a strict weak ordering. Returning true or false
  randomly didn't fullfil this requirement causing a crash in some calls to 
invalidate.
  To keep the random order consistent a vector of row indices is used which 
records
  the current random order.
  
  BUG: 413018
  FIXED-IN: 5.17.1

TEST PLAN
  To reproduce the bug use a slideshow in random order with few pictures and a 
small
  time intervall.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24723

AFFECTED FILES
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

2019-10-10 Thread David Redondo

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24533

AFFECTED FILES
  icons/CategoryDrawer.cpp
  icons/CategoryDrawer.h

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-10-08 Thread David Redondo

davidre added a comment.


  > Make it possible to have an auto-hiding panel that only appears when 
clicking on a button somewhere else: https://bugs.kde.org/show_bug.cgi?id=412483
  
  I don't think the point matches the bug report entirely but maybe one could 
hack something like this together with 
  https://community.kde.org/Plasma/DeveloperGuide#DBus_autolaunched_Plasmoids.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: davidre, LeGast00n, enriqueme, mart, fabianr, Zren, mmustac, niccolove, 
rikmills, cblack, broulik, mvourlakos, plasma-devel, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:66d7bc83fc1e: [Cuttlefish] Compare an icon in different 
themes (authored by davidre).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24305?vs=67120=67124

REVISION DETAIL
  https://phabricator.kde.org/D24305

AFFECTED FILES
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> Comparison.qml:66
> +Item {
> +id: wrapper
> +Layout.preferredWidth: 128

https://doc.qt.io/qt-5/qt.html#AlignmentFlag-enum

REPOSITORY
  R118 Plasma SDK

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> Comparison.qml:66
> +Item {
> +id: wrapper
> +Layout.preferredWidth: 128

I use it for centering the icon in the middle of the 128x128 free space for the 
icon. `Qt.AlignCenter` is not enough for that. In the first version of the diff 
I tried make up for that with setting of top and bottom margins depending on 
the text height and icon size but that was to complicated and also didn't 
produce the correct result I think.

REPOSITORY
  R118 Plasma SDK

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24304: [Cuttlefish] Add 48 to the sizeslider

2019-10-01 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:37763ba7b84d: [Cuttlefish] Add 48 to the sizeslider 
(authored by davidre).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24304?vs=67052=67121

REVISION DETAIL
  https://phabricator.kde.org/D24304

AFFECTED FILES
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml

To: davidre, #plasma, cblack, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo

davidre updated this revision to Diff 67120.
davidre marked 3 inline comments as done.
davidre added a comment.


  Use paint-none directly

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24305?vs=67118=67120

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

AFFECTED FILES
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo

davidre updated this revision to Diff 67118.
davidre marked 4 inline comments as done.
davidre added a comment.


  nitpicks

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24305?vs=67070=67118

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

AFFECTED FILES
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> Comparison.qml:70
> +height: comparisonSize
> +source: modelData.iconPath
> +}

That's what I did first acutally but I didn't like that for two reasons. First 
it would scale with the other icons and when you are looking at paint-none you 
couldn't distinguish it anymore.

REPOSITORY
  R118 Plasma SDK

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

2019-10-01 Thread David Redondo

davidre added a comment.


  Thanks for accepting this so quickly! Does anyone have any comments on the 
code?  I would like to improve my qml and any suggestion/best practice is 
welcome.

REPOSITORY
  R118 Plasma SDK

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

2019-09-30 Thread David Redondo

davidre updated this revision to Diff 67070.
davidre added a comment.


  Show a symbol when a theme doesn't have the icon

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24305?vs=67053=67070

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

AFFECTED FILES
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre, #plasma, #vdg
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

2019-09-30 Thread David Redondo

davidre added a comment.


  In D24305#539727 , @filipf wrote:
  
  > LGTM. Can the overlay be spawned in the vertical center of the window as 
well or is that defined in Kirigami itself? Also what happens when there are a 
lot of themes, does the overlay remain the same size and just get a scrollbar?
  
  
  I didn't look into sizing positioning the overlay yet. But a scrollbar 
appears if the content doesn't fit into the available size.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24305: [Cuttlefish] Compare an icon in different themes

2019-09-30 Thread David Redondo

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  The icon in different installed themes is shown in an overlay sheet.

REPOSITORY
  R118 Plasma SDK

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

AFFECTED FILES
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24304: [Cuttlefish] Add 48 to the sizeslider

2019-09-30 Thread David Redondo

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  The initial icon size Cuttlefish starts with is 48 
(Kirigami.Unis.iconSizes.large).
  However this size cannot be selected using the slider. To quickly see this
  start Cuttlefish (note the slider says 64) and move the slide to some other
  value and back to 64. The icons have now a different size than before. Since 
we
  also show a preview for 48 add this size to the selectable ones.

REPOSITORY
  R118 Plasma SDK

BRANCH
  48 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24304

AFFECTED FILES
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/cuttlefish.qml

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread David Redondo

davidre added a comment.


  In D23712#525974 , @ngraham wrote:
  
  > There are some inline comments that aren't done yet. Also, the slider's 
text label still says 81 and 162 instead of 64 and 128 for the last two slider 
values.
  
  
  I also noticed that the first two values are both say 16

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> cuttlefish.qml:32
>  
> -width: units.gridUnit * 60
> -height: Math.round(width / 3 * 2)
> -
>  property int iconSize: units.iconSizes.large
>  property bool darkScheme: false

Why not Kirigami units here?

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23651: WIP: Add support for a theming in Kicker Dashboard

2019-09-02 Thread David Redondo

davidre added a comment.


  The reason it's transparent is because the clear color of the buffer is set 
to the background color when it's changed [1][2]. 
  This worked before probably because the Color was (0, 0, 0). For transparent 
windows we need to set it to `Qt::transparent`[3] and enable an  alpha 
buffer[4].
  
  F7309362: Screenshot_20190902_171545.png 

  
diff --git a/applets/kicker/plugin/dashboardwindow.cpp 
b/applets/kicker/plugin/dashboardwindow.cpp
index 6665e8df7..cc6b70c32 100644
--- a/applets/kicker/plugin/dashboardwindow.cpp
+++ b/applets/kicker/plugin/dashboardwindow.cpp
@@ -32,6 +32,8 @@ DashboardWindow::DashboardWindow(QQuickItem *parent) : 
QQuickWindow(parent ? par
 , m_visualParentWindow(nullptr)
 {
 setClearBeforeRendering(true);
+setDefaultAlphaBuffer(true);
+setColor(Qt::transparent);
 setFlags(Qt::FramelessWindowHint);
 
 setIcon(QIcon::fromTheme(QStringLiteral("plasma")));
@@ -100,8 +102,6 @@ QColor DashboardWindow::backgroundColor() const
 void DashboardWindow::setBackgroundColor(const QColor )
 {
 if (color() != c) {
-setColor(c);
-
 emit backgroundColorChanged();
 }
 }
  
  [1] 
https://cgit.kde.org/plasma-desktop.git/tree/applets/kicker/plugin/dashboardwindow.cpp#n103
  [2]https://doc.qt.io/qt-5/qquickwindow.html#color-prop
  [3]https://doc.qt.io/qt-5/qquickwidget.html#details (see Limitations)
  [4]https://doc.qt.io/qt-5/qquickwindow.html#setDefaultAlphaBuffer

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23651

To: ognarb, #plasma, #vdg
Cc: davidre, felixernst, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-12 Thread David Redondo

davidre added a comment.


  In D23080#510815 , @ngraham wrote:
  
  > IMO the ideal state of affairs would be to somehow emulate the colors of 
the standard Qt tab widget:
  >
  > F7205923: Screenshot_20190812_073407.png 

  >
  > Not too contrasty, but not too subtle either.
  
  
  +1, we should try to match breeze.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23080

To: cblack, #breeze, #vdg
Cc: davidre, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23049: Add Kirigami ListSection component

2019-08-09 Thread David Redondo

davidre added a comment.


  Should this set ` sectionDelegate: true` and not expose this to the outside?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23049

To: GB_2, #kirigami, #vdg, mart
Cc: davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, 
dkardarakos, apol, davidedmundson, mart, hein

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread David Redondo

davidre added a comment.


  Sorry my bad, I misread the diff. I thought you added a new flag (as proposed 
above) and looked at `exportGtkTheme` but that flag is an existing one. And to 
my shame it doesn't even have a green background.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma
Cc: davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread David Redondo

davidre added a comment.


  It seems the header with the new flag is missing from the diff.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22844

To: cblack, #plasma
Cc: davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Addendum to 29/07/2019 meeting

2019-07-29 Thread David Redondo

Hi,

I landed https://phabricator.kde.org/D22121 which allows sorting the wallpaper 
slideshow in a specific order. This is managed by a QSortFilterProxyModel. 
This model is now also used for the actual slideshow and the config dialog (No 
more QStringlist of the images that we want to show/are excluded). Also if you 
have a different order than Random the slideshow will continue where it 
stopped if you restart Plasmashell.
At the onboarding sprint David, David and I investigated why clipboard with 
larger data is broken under Wayland (for example images). David Edmundson has 
a qtwayland patch for that: https://codereview.qt-project.org/c/qt/qtwayland/
+/268352

David

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-25 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ea32a7611227: [Image Wallpaper Slideshow] Allow setting 
of different sorting orders (authored by davidre).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22121?vs=62529=62530#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=62529=62530

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-25 Thread David Redondo

davidre updated this revision to Diff 62529.
davidre added a comment.


  Last touches
  
  - remove QDebug
  - don't restore image if we are in random mode
  - if we have seen all images generate a new random order

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61648=62529

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-19 Thread David Redondo

davidre added a comment.


  How can we move this forward? Are there things I overlooked? Is it sill 
crashing sometimes? Code comments?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-12 Thread David Redondo

davidre updated this revision to Diff 61648.
davidre added a comment.


  - Only restore wallpaper on startup
  - Guard against empty path
  
  I couldn't understand why this was being called with an empty string so I 
just guard 
  against it at the call site. Maybe this also helps @ngrahams crash but I 
still don't know
  where it is coming from.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61335=61648

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-09 Thread David Redondo

davidre added a comment.


  So I'm crashing when I hit apply and then ok because `addURL` is called from 
qml with an empty string and I don't understand why. In main.qml I have
  
onConfiguredImageChanged: {
  if (modelImage != configuredImage) {
  console.log("configured Image" + wallpaper.configuration.Image);
  console.log(configuredImage + "!=" + modelImage)
  imageWallpaper.addUrl(configuredImage);
  }
  }
  onModelImageChanged:{
  Qt.callLater(loadImage);
  console.log("mic to "+modelImage);
  wallpaper.configuration.Image = modelImage;
  console.log("mic:" + wallpaper.configuration.Image +" configimage:" 
+configuredImage);

  }
  
  On apply :
  
qml: mic to file:///home/david/testimages/hk5lmt9qxfw21.jpg
qml: mic:file:///home/david/testimages/hk5lmt9qxfw21.jpg 
configimage:file:///home/david/testimages/hk5lmt9qxfw21.jpg
  
  Then clicking on OK
  
qml: configured Image
qml: !=file:///home/david/testimages/hk5lmt9qxfw21.jpg
  
  What I dont understand is why this happens. When pressing OK without apply 
everything works as I would expect it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo

davidre planned changes to this revision.
davidre added a comment.


  I may have introduced a similar crash or  made it easier to trigger Nate's 
crash.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo

davidre updated this revision to Diff 61335.
davidre added a comment.


  - Remember current slide between starts

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61318=61335

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo

davidre added a comment.


  In D22121#492179 , @msdobrescu 
wrote:
  
  > Thanks, selecting from any image is useful, to avoid starting always from 
the top one. But should not enable the button until a check is done.
  
  
  Ideally if you want a specific image you should use a  static wallpaper. But 
I see what you mean, I think it would be useful to remember the current slide 
between restarts.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo

davidre added a comment.


  In D22121#492173 , @msdobrescu 
wrote:
  
  > I'd say it is some half-implemented feature, probably. Could it be useful 
to navigate by keyboard and check/uncheck images, by using space, for example?
  
  
  You can still navigate by Keyboard. But selecting an image will not enable 
the apply button anymore and then when clicked set the current image to the one 
selected. 
  I like your idea that you can uncheck/check when the whole delegate is 
selected.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo

davidre updated this revision to Diff 61318.
davidre added a comment.


  Don't start if we are in config mode
  
  I had another crash here via reload -> processPaths -> endInsertRows.
  Triggered by repeatetly checking and unchecking a checkbox. My guess is that 
because of multiple
  calls to reload and beginInsertRows, endInsertRows there were some 
inconsistencies. With this
  I can't crash it anymore by checking and unchecking a checkbox.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61314=61318

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-08 Thread David Redondo

davidre updated this revision to Diff 61314.
davidre marked 2 inline comments as done.
davidre added a comment.


  Disable selecting the wallpaper in  slideshow configuration
  
  This was introduced when the gridview from the single image dialog was added 
to the 
  slideshow one. In my mind it makes no sense to have it, by clicking on a 
image the user
  doesn't change any visible setting and needlesly changes changes the state of 
the configuration
  dialog.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61116=61314

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

2019-07-08 Thread David Redondo

davidre added a comment.


  I guess one drawback is that you have to reindex all the files when the sort 
mode is changed.

REVISION DETAIL
  https://phabricator.kde.org/D22256

To: msdobrescu, ngraham, davidre, #plasma
Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-07 Thread David Redondo

davidre added a comment.


  In D22121#491833 , @davidedmundson 
wrote:
  
  > Nate's crash is due to data not code.
  >
  >   for (int i = 0; i < m_packages.size(); i++) {
  >   QString package = m_packages[i].path();
  >   if (package.at(package.length() - 1) == QChar::fromLatin1('/')) {   
<--- you know you crash on this line
  >   
  >   
  >
  > we're calling .at(length -1) unconditionally
  >
  > For an empty string our index will be -1.
  >
  > This hints towards an insertion bug rather than saying we should just add a 
guard here.
  
  
  Thanks for the hint David. @ngraham could you maybe try to get the path for 
which the crash happens (if package.length == 0) and how the folder structure 
for that image is added to your slideshow. Also it would be good to know if it 
happens if you start fresh and add it in the same way (then I could reproduce 
it) or not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-06 Thread David Redondo

davidre added inline comments.

INLINE COMMENTS

> image.cpp:600
> +m_slideshowModel->addBackground(path);
> +m_currentSlide = m_slideFilterModel->indexOf(path) - 1;
>  nextSlide();

Currently the slideshow would restart. I guess we could check here if the index 
is -1. Or alternatively don't trigger this from the qml side if the image is 
unchecked. In my mind this even better because then we enable the apply button, 
too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-04 Thread David Redondo

davidre added a comment.


  In D22121#490983 , @ngraham wrote:
  
  > I still get the same crash. :(
  
  
  Very weird I just tried it in a VM which hadn't seen the patch at all yet and 
it doesn't crash.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-04 Thread David Redondo

davidre updated this revision to Diff 61116.
davidre added a comment.


  - Sort case insensitive

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61115=61116

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-04 Thread David Redondo

davidre updated this revision to Diff 61115.
davidre added a comment.


  I couldm't crash it by clicking apply but noticed some type errors because 
the proxymodel 
  din't have all the functionality of the underlying model.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61081=61115

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-04 Thread David Redondo

davidre added a comment.


  Weird. I can't get it to crash at all but I will look at and think about it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-03 Thread David Redondo

davidre updated this revision to Diff 61081.
davidre added a comment.


  - Bool is now other way around

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61078=61081

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-07-03 Thread David Redondo

davidre updated this revision to Diff 61078.
davidre added a comment.


  - Don't invalidate if we are in the config view and the mode is set to random

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=60826=61078

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-30 Thread David Redondo

davidre added a comment.


  Ah I forgot a word there.
  I wanted to say don't change the current order if the sort order is switched 
to random. And when opened and the current mode is random whatever.
  Displaying the order for the other modes is quite good I think.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-30 Thread David Redondo

davidre added a comment.


  In D22121#488479 , @ngraham wrote:
  
  > That fixed my crash, yay!
  >
  > I see a UX issues with the Random mode though: since the list re-sorts 
itself randomly, it becomes harder to locale any given wallpaper in there (say, 
for the purposes of unchecking it). Also, when you scroll all the way to the 
bottom and then back up to the top, the order has changed to a new random 
order. While you're scrolling, the delegates are visible changing before your 
eyes. It's all a bit odd.
  >
  > I wonder if in the Random mode, we should just keep the view sorted 
alphabetically?
  
  
  Yes I had the same thoughts about random. Another way would be to not resort 
the slides at all in the config view when you change it and alphabetically/how 
we get them when you open the config view. Either way I guess I will have to 
change `filterUncheckedSlides` to a generic `isUsedinConfig` to enable that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-29 Thread David Redondo

davidre updated this revision to Diff 60826.
davidre added a comment.


  - add my copyright

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=60825=60826

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-29 Thread David Redondo

davidre updated this revision to Diff 60825.
davidre marked 4 inline comments as done.
davidre added a comment.


  - String changes and remove debug statement

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=60823=60825

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-29 Thread David Redondo

davidre updated this revision to Diff 60823.
davidre added a comment.


  Sort only if a sortmode has been specified
  
  Otherwise it could have been initialized to an invalid value which caused us 
to
  reach Q_UNREACHABLE and crash.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=60725=60823

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

2019-06-27 Thread David Redondo

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Allows setting of other sorting orders like alphabetical or last modified 
date.
  To enable this a new ProxyModel is introduced which handles the sorting and
  filtering (as indicated by the checkboxes). This is backed by the 
slideshowModel
  whcih previously as only used for the configutation. The lists of slides and  
unseen
  slides are dropped as now the slides that are shown are taken from the model.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21993: [Klipper] Always restore the last clipbboard item

2019-06-22 Thread David Redondo

davidre created this revision.
davidre added reviewers: ngraham, davidedmundson, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  D19852  intrdouced x-kde-force-image-copy 
hint for programs to specify that
  images should be set to the clipboard even if should not be included in the
  history. But when the program was closed the clipboard was restored to the 
first
  item in history in which the image was not included. To fix this introduce a 
new
  class member which holds the last clipboard item and restore it.
  Credit goes to David Edumndson

TEST PLAN
  Try it with spectacle

REPOSITORY
  R120 Plasma Workspace

BRANCH
  unify

REVISION DETAIL
  https://phabricator.kde.org/D21993

AFFECTED FILES
  klipper/klipper.cpp
  klipper/klipper.h

To: davidre, ngraham, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

2019-06-22 Thread David Redondo

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:43eb5fae5784: Set SwipeListItem implicitHeight to be the 
maximum of content and actions (authored by davidre).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21981?vs=60284=60305

REVISION DETAIL
  https://phabricator.kde.org/D21981

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: davidre, #kirigami, mart, ngraham
Cc: ngraham, mart, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, hein

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

2019-06-22 Thread David Redondo

davidre created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Otherwise if the content is smaller than the actions they will be partially
  outside out of the item

REPOSITORY
  R169 Kirigami

BRANCH
  height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21981

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: davidre
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D19745: Fix system tray UI/UX & refactor

2019-05-15 Thread David Redondo

davidre added a comment.


  In D19745#465569 , @ratijastk 
wrote:
  
  > So, I've merged done git rebase on master — just one conflicting line, 
rewritten after me in a better way.  But now I have no way to test it, because 
CMake Error `Could not find a configuration file for package "ECM" that is 
compatible with requested version "5.58.0"` and even all-up-to-date Arch Linux 
does not provide those pieces. I've installed the latest CMake from the 
`testing` repository, but other versioning issues showed up.
  >
  > I'm not a big fan of submitting without checking, but I don't see any other 
way around.
  
  
  ECM is an KDE project https://api.kde.org/ecm/ and part of frameworks. Try 
installing extra-cmake-modules (don't know the exact name on arch).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-04-16 Thread David Redondo

davidre added a comment.


  > I haven't found a way to align Kirigami.FormLayout together in a repeater.
  
  Maybe you could use twinFormLayouts like in D19873 
 and D19932 
?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D20598

To: meven, ngraham, broulik
Cc: davidre, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

2019-04-01 Thread David Redondo

davidre updated this revision to Diff 55164.
davidre added a comment.


  - Change default of cfg_UncheckedSlides to []
  - Change toggled to checked

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19687?vs=54010=55164

BRANCH
  toggleSlides

REVISION DETAIL
  https://phabricator.kde.org/D19687

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19687: Allow single images to be excluded from the slideshow

2019-03-29 Thread David Redondo

davidre added a comment.


  almost weekly ping

REPOSITORY
  R120 Plasma Workspace

BRANCH
  toggleSlides

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

2019-03-23 Thread David Redondo

davidre added a comment.


  Ping!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  toggleSlides

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19873: [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts

2019-03-21 Thread David Redondo

davidre added a comment.


  Great! I see that also  fixes the issue that the label vanished when the 
window got to narrow.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham, mart
Cc: davidre, mart, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

< 1 2 3 4 5 >

301 - 400 of 451 matches

Mail list logo