On 10 May 2011 01:39, Nigel Kersten ni...@puppetlabs.com wrote:
Facter 1.5.9rc6 is a maintenance release containing fixes and updates.
The keen-eyed observers amongst you will notice it's been a month since our
last RC5 of Facter 1.5.9, which is most certainly not our normal process.
We
On 14 March 2011 02:57, James Turnbull ja...@lovedthanlost.net wrote:
Signed-off-by: James Turnbull ja...@lovedthanlost.net
This list is kinda excessive, is there anything it doesn't work for
explicitly (ie do we need the confine).
---
Local-branch: tickets/master/6695
lib/facter/id.rb |
On 14 March 2011 15:46, James Turnbull ja...@puppetlabs.com wrote:
Paul Nasrat wrote:
On 14 March 2011 02:57, James Turnbull ja...@lovedthanlost.net wrote:
Signed-off-by: James Turnbull ja...@lovedthanlost.net
This list is kinda excessive, is there anything it doesn't work for
explicitly (ie
On 14 March 2011 16:52, Daniel Pittman dan...@puppetlabs.com wrote:
On Sun, Mar 13, 2011 at 19:57, James Turnbull ja...@lovedthanlost.net wrote:
Signed-off-by: James Turnbull ja...@lovedthanlost.net
---
Local-branch: tickets/master/6695
lib/facter/id.rb | 2 +-
1 files changed, 1
On 14 March 2011 17:30, Daniel Pittman dan...@puppetlabs.com wrote:
On Mon, Mar 14, 2011 at 10:29, Paul Nasrat pnas...@gmail.com wrote:
On 14 March 2011 15:46, James Turnbull ja...@puppetlabs.com wrote:
Paul Nasrat wrote:
On 14 March 2011 02:57, James Turnbull ja...@lovedthanlost.net wrote
On 14 March 2011 17:44, Daniel Pittman dan...@puppetlabs.com wrote:
On Mon, Mar 14, 2011 at 10:32, Paul Nasrat pnas...@gmail.com wrote:
On 14 March 2011 16:52, Daniel Pittman dan...@puppetlabs.com wrote:
On Sun, Mar 13, 2011 at 19:57, James Turnbull ja...@lovedthanlost.net
wrote
On 11 March 2011 00:52, James Turnbull ja...@lovedthanlost.net wrote:
Thanks to James Goddard for the patch
+1
Signed-off-by: James Turnbull ja...@lovedthanlost.net
---
Local-branch: ticket/master/6679
lib/facter/operatingsystem.rb | 2 ++
spec/unit/operatingsystem_spec.rb | 12
On 9 March 2011 16:55, James Turnbull ja...@puppetlabs.com wrote:
Paul Nasrat wrote:
On 8 March 2011 17:23, James Turnbull ja...@puppetlabs.com wrote:
Paul Nasrat wrote:
+1 been pending for too long
Was that a +1 on patches 2 and 3 in that series also? I largely rewrote
the whole fact
On 9 March 2011 01:32, Adrien Thebo adr...@puppetlabs.com wrote:
- Adds support for Slamd64 and Bluewhite64 for the operatingsystem
fact
- Adds support for Slamd64 and Bluewhite64 for the
operatingsystemrelease fact
+1
The duplication is a bit of a code smell, we probably should
On 8 March 2011 17:23, James Turnbull ja...@puppetlabs.com wrote:
Paul Nasrat wrote:
+1 been pending for too long
Was that a +1 on patches 2 and 3 in that series also? I largely rewrote
the whole fact.
Just on this, I need to review the arp fact in more depth. I think the
basic idea
On 8 March 2011 21:33, James Turnbull ja...@lovedthanlost.net wrote:
1. Added tested
2. Refactored to use F:U:R.exec
3. Chomp trailing newline
What happens if it gets output if no Current Mode line (think older,
think you're missing test/handling for that.
You've also changed the rule to
On 9 March 2011 14:00, Todd Zullinger t...@pobox.com wrote:
Paul Nasrat wrote:
You've also changed the rule to use Current mode not Mode from
config file, was this intentiional have you tested on rhel4, rhel5,
rhel6 and non-rhel selinux systems?
It seems like a different bug that the current
+1 been pending for too long
On 8 March 2011 10:28, James Turnbull ja...@lovedthanlost.net wrote:
From: Paul Nasrat pnas...@googlemail.com
The EC2 fact is completely broken at the moment:
* Timeout::Error isn't caught by rescue (due to how it inherits)
* The issue of wrong open semantics
On 7 March 2011 09:25, James Turnbull ja...@lovedthanlost.net wrote:
Signed-off-by: James Turnbull ja...@lovedthanlost.net
This fact probably could do with a unittest - there is selinux_spec.rb
already and you should be able to add the missing test as you are
touching it.
Perhaps use
I don't have hpux access to test, but look sane
+1
On 6 March 2011 19:52, James Turnbull ja...@lovedthanlost.net wrote:
Signed-off-by: James Turnbull ja...@lovedthanlost.net
---
Local-branch: tickets/master/6611
spec/unit/virtual_spec.rb | 23 ---
1 files changed, 12
On 15 February 2011 21:43, Richard Crowley r...@rcrowley.org wrote:
While Matt and I were pairing on getting IPv6 support into facter we
ran across some code that, on Darwin, would try and DWIM out the
main address of the system. Specifically, it assumed that the
main IP address of a machine
On 5 February 2011 15:16, Cody Herriges c.a.herri...@gmail.com wrote:
The following patch provides an ipaddress6 fact to report IP addresses
that follow the IPv6 standard, RFC 2460. Basic code structure was modeled
after the already current ipaddress facts available in facter core and are
On 1 February 2011 01:57, Daniel Pittman dan...@puppetlabs.com wrote:
On Sun, Jan 30, 2011 at 09:28, Paul Nasrat pnas...@gmail.com wrote:
On 28 January 2011 18:44, Daniel Pittman dan...@puppetlabs.com wrote:
From: Daniel Pittman dan...@rimspace.net
We have moved to rspec2 for puppet
On 28 January 2011 18:44, Daniel Pittman dan...@puppetlabs.com wrote:
From: Daniel Pittman dan...@rimspace.net
Rename all the spec tests to follow the rspec convention of *_spec.rb rather
than unadorned *.rb; this also makes it easier to work with them consistently
without using the Rakefile
On 28 January 2011 18:44, Daniel Pittman dan...@puppetlabs.com wrote:
From: Daniel Pittman dan...@rimspace.net
Because we pull in spec_helper in individual tests, we need to use a
consistent path or Ruby will evaluate it multiple times. Make the path
consistent by expanding it before
On 28 January 2011 18:44, Daniel Pittman dan...@puppetlabs.com wrote:
From: Daniel Pittman dan...@rimspace.net
We have moved to rspec2 for puppet, and facter should follow suit.
+1 with minor query
---
Rakefile | 14 --
spec/Rakefile
On 28 December 2010 12:04, Hector Rivas Gandara key...@gmail.com wrote:
Modified the facts processorN, processorcount, is_virtual and virtual:
* is_virtual=true and virtual=.zlinux. if architecture=s390x
* /proc/cpuinfo has diferent syntax, matching /processor\s+(\d+):\s+(.*)/
IIRC both
On 6 January 2011 23:22, Matt Robinson m...@puppetlabs.com wrote:
Paired-with: Jesse Wolfe
Signed-off-by: Matt Robinson m...@puppetlabs.com
---
.gitignore | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 1e6b959..a208237 100644
---
On 7 January 2011 17:12, Daniel Pittman dan...@rimspace.net wrote:
On Jan 7, 2011 8:53 AM, Matt Robinson m...@puppetlabs.com wrote:
On Fri, Jan 7, 2011 at 8:45 AM, Paul Nasrat pnas...@gmail.com wrote:
On 6 January 2011 23:22, Matt Robinson m...@puppetlabs.com wrote:
Paired-with: Jesse Wolfe
On 24 December 2010 02:52, William Van Hevelingen wva...@gmail.com wrote:
From: William Van Hevelingen w...@cs.pdx.edu
Looks good - according to this:
http://www.windowsitpro.com/article/tips/jsi-tip-7308-the-windows-xp-and-windows-server-2003-whoami-utility-.aspx
It's new in XP/2003 server.
Sure well +1 for this and we can always add more specific facts.
I'll merge for next post Xmas
Paul
On Dec 24, 2010 6:09 PM, Nigel Kersten ni...@puppetlabs.com wrote:
On Fri, Dec 24, 2010 at 12:41 AM, Paul Nasrat pnas...@gmail.com wrote:
On 24 December 2010 02:52, William Van Hevelingen wva
On 2 December 2010 23:27, Paul Berry p...@puppetlabs.com wrote:
On Tue, Nov 30, 2010 at 4:27 AM, Dominic Cleal dcl...@redhat.com wrote:
Add total memory from prtconf output, free from vmstat plus swap free and
total from swap -l listing.
Signed-off-by: Dominic Cleal dcl...@redhat.com
---
On 3 December 2010 10:54, Dominic Cleal dcl...@redhat.com wrote:
On 01/12/10 13:10, Paul Nasrat wrote:
On 1 December 2010 10:49, Dominic Cleal dcl...@redhat.com wrote:
On 01/12/10 10:32, Dominic Cleal wrote:
Memory and swap values are now given in standard units via additional facts
(e.g
On 3 December 2010 10:41, Dominic Cleal dcl...@redhat.com wrote:
On 02/12/10 23:27, Paul Berry wrote:
On Tue, Nov 30, 2010 at 4:27 AM, Dominic Cleal dcl...@redhat.com
mailto:dcl...@redhat.com wrote:
Add total memory from prtconf output, free from vmstat plus swap
free and
total
On 1 December 2010 10:49, Dominic Cleal dcl...@redhat.com wrote:
On 01/12/10 10:32, Dominic Cleal wrote:
Memory and swap values are now given in standard units via additional facts
(e.g. memorysize_mb) as well as the most appropriate unit as before.
Please note that this conflicts with the
On 30 November 2010 19:10, Matt Robinson m...@puppetlabs.com wrote:
While looking at the patch for adding parallels to the virtual types
David Schmitt noticed that it might be easier just to list the types
that are NOT virtual since there's fewer of them.
+1
Paul
Paired-with: Nick Lewis
Does a true command ship by default on Win32?
If not this will break the tests there. Unittests should be runnable -
please confirm you have a windows box in your CI pipeline by default
and the tests all pass on that platform with this change.
Paul
On Tuesday, November 23, 2010, Paul Berry
On 22 November 2010 19:27, Nick Lewis n...@puppetlabs.com wrote:
Signed-off-by: Nick Lewis n...@puppetlabs.com
Execing cat in the tests is yucky, we should be able to run the tests
on Win32 with the fixture data/stub data from commands.
Rather than hack around with shell quoting can you
On 21 November 2010 11:01, Stefan Schulte
stefan.schu...@taunusstein.net wrote:
Hi,
I wanted to write a resourcetype to manage ports in /etc/services. I did
write a type where you can do something like:
port { 'telnet',
protocol = 'tcp',
number = '22',
port_aliases =
On 19 November 2010 09:37, Dominic Cleal dcl...@redhat.com wrote:
Use prtdiag output on Solaris/SPARC to determine manufacturer and productname
as
smbios is unavailable.
I don't have a sparc box to test this against but +1
Paul
Signed-off-by: Dominic Cleal dcl...@redhat.com
---
On 18 November 2010 10:13, donavanm dona...@desinc.net wrote:
From: Donavan Miller dona...@strewth.org
Adds support for Parallels VM guest detection with existing operating
systems. Detects Parallels based on hardware vendor name and pci id. The
Parallels vendor id does not seem to be
On 18 November 2010 14:07, David Schmitt da...@dasz.at wrote:
On 11/18/2010 11:13 AM, donavanm wrote:
@@ -80,11 +103,11 @@ Facter.add(virtual) do
end
Facter.add(is_virtual) do
- confine :kernel = %w{Linux FreeBSD OpenBSD SunOS HP-UX}
+ confine :kernel = %w{Linux FreeBSD OpenBSD
+1
On 12 November 2010 18:27, Paul Berry p...@puppetlabs.com wrote:
Signed-off-by: Paul Berry p...@puppetlabs.com
---
Local-branch: maint/next/add_local_branch_to_mail_patches
tasks/rake/mail_patches.rake | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git
On 10 November 2010 00:16, Paul Berry p...@puppetlabs.com wrote:
On Wed, Nov 3, 2010 at 8:04 PM, James Turnbull ja...@lovedthanlost.net
wrote:
From: John E. Vincent lusis.org+github@gmail.com
Signed-off-by: James Turnbull ja...@lovedthanlost.net
---
bin/facter | 22
On 10 November 2010 01:13, Paul Berry p...@puppetlabs.com wrote:
On Mon, Oct 18, 2010 at 3:45 PM, Rein Henrichs r...@puppetlabs.com wrote:
Parses `/usr/sbin/xm list` and returns a comma-separated list of
domains. Based on a patch submitted by Jonas Genannt.
---
Jonas,
Thanks for sending
On 10 November 2010 06:34, Nigel Kersten ni...@puppetlabs.com wrote:
On Tue, Nov 9, 2010 at 10:22 PM, Paul Nasrat pnas...@gmail.com wrote:
On 10 November 2010 00:16, Paul Berry p...@puppetlabs.com wrote:
On Wed, Nov 3, 2010 at 8:04 PM, James Turnbull ja...@lovedthanlost.net
wrote:
From: John
On 3 November 2010 22:41, Stefan Schulte stefan.schu...@taunusstein.net wrote:
While the fact virtual recognised solaris zones before, the is_virtual
fact did not.
Before everyone thinks I'm just grumpy - before coffee and exceedingly
busy atm so a little terse.
Thanks a lot for the patches,
On 4 November 2010 04:20, James Turnbull ja...@lovedthanlost.net wrote:
From: John E. Vincent lusis.org+github@gmail.com
We need testing on 1.8.1 upwards. Do we not want json/pure rather than json?
Signed-off-by: James Turnbull ja...@lovedthanlost.net
---
bin/facter |
On 4 November 2010 16:52, Markus Roberts mar...@puppetlabs.com wrote:
We need testing on 1.8.1 upwards. Do we not want json/pure rather than
json?
i.e. PSON?
I really don't want to have to do embed that in facter.
Paul
--
You received this message because you are subscribed to the
On 29 October 2010 15:19, Nigel Kersten ni...@puppetlabs.com wrote:
On Fri, Oct 29, 2010 at 3:42 AM, R.I.Pienaar r...@devco.net wrote:
- Teyo Tyree t...@puppetlabs.com wrote:
Would you all be interested knowing what we are working on each week?
Our iterations will tend to have a
On 28 October 2010 23:39, Teyo Tyree t...@puppetlabs.com wrote:
Like to note a few things about our development shift that we
unfortunately did not communicate effectively in our initial email.
We are iterating on our internal development process in order to more
rapidly deliver complete
On 27 October 2010 21:10, Matt Robinson m...@puppetlabs.com wrote:
We've gotten feedback that a lot of the patches that are sent to the
puppet-dev list aren't terribly useful to our community to read and
tend to overwhelm the conversation.
-1. How was this survey carried out? It's pretty easy
+1
Using WMI queries where we can makes sense
On 19 October 2010 00:28, Rein Henrichs r...@puppetlabs.com wrote:
From: William Van Hevelingen wva...@gmail.com
Signed-off-by: William Van Hevelingen wva...@gmail.com
Signed-off-by: Rein Henrichs r...@puppetlabs.com
---
On 18 October 2010 23:45, Rein Henrichs r...@puppetlabs.com wrote:
Parses `/usr/sbin/xm list` and returns a comma-separated list of
domains. Based on a patch submitted by Jonas Genannt.
Looks good - is the output of xm list consistent across all known
releases of xen?
Paul
---
Jonas,
Fix is_virtual fact to return strings rather than bools.
Signed-off-by: Paul Nasrat pnas...@googlemail.com
---
lib/facter/virtual.rb |4 ++--
spec/unit/virtual.rb | 12 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/facter/virtual.rb b/lib/facter
From: Hans de Graaff h...@degraaff.org
Signed-off-by: Paul Nasrat pnas...@googlemail.com
---
spec/unit/util/virtual.rb |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/spec/unit/util/virtual.rb b/spec/unit/util/virtual.rb
index 1e31a2f..cc528d1 100644
--- a/spec/unit
On 7 October 2010 10:23, Paul Nasrat pnas...@gmail.com wrote:
From: Hans de Graaff h...@degraaff.org
Signed-off-by: Paul Nasrat pnas...@googlemail.com
+1 tested on Linux machine.
Paul
--
You received this message because you are subscribed to the Google Groups
Puppet Developers group
On 24 August 2010 22:28, Rein Henrichs r...@puppetlabs.com wrote:
Resolution.exec used to ensure that any shell errors are suppressed.
+1
As said in the bug this resolves the issue
Paul
--
You received this message because you are subscribed to the Google Groups
Puppet Developers group.
To
On 17 August 2010 19:50, Rein Henrichs r...@puppetlabs.com wrote:
Excerpts from Paul Nasrat's message of Tue Aug 17 06:40:42 -0700 2010:
The EC2 fact is completely broken at the moment:
* Timeout::Error isn't caught by rescue (due to how it inherits)
* The issue of wrong open semantics
On 19 August 2010 13:30, Daniel Pittman dan...@rimspace.net wrote:
Daniel Pittman dan...@rimspace.net writes:
This works around the interaction of Debian packaged librspec-ruby and gems.
Under Debian the library is available, but the gem support fails; this
ignores
the gem failure and
On 18 August 2010 23:58, Rein Henrichs r...@puppetlabs.com wrote:
When Facter returns operatingsystem as oel or ovs, the
operatingsystemrelease fact does not catch these properly, causing an
error.
Specs added to catch failure and case statement updated to catch oel
and ovs as well as OEL
patch fixes the first two, I'm not sure we want to take
the timeout hit, we also want to add tests as even simple ruby code can get
logic errors such as the open().
Signed-off-by: Paul Nasrat pnas...@googlemail.com
---
lib/facter/ec2.rb |5 -
1 files changed, 4 insertions(+), 1 deletions
Reviewing next branch for RC as discussed, I'm happy with all the
changes up to 6edf3199a212e6b33f9e09edbb3cb34710710326, we should
create a branch with the RC version bump and think about generating
the tarballs, documentation and release notes.
Paul
--
You received this message because you
On 17 August 2010 20:20, James Turnbull ja...@puppetlabs.com wrote:
For 40 days and 40 nights Facter wandered in the wilderness sustained
only by the occasional patch and bottle of Kool-Aid. Tanned and happy
Facter 1.5.8rc1 has now emerged from its desert retreat.
Testing on various virtual
On 17 August 2010 21:27, Nigel Kersten nig...@google.com wrote:
On Tue, Aug 17, 2010 at 1:03 PM, Jeff McCune j...@puppetlabs.com wrote:
On Tue, Aug 17, 2010 at 12:31 PM, Nigel Kersten nig...@google.com wrote:
I've implemented local caching for my computational expensive and
infrequently
On 6 August 2010 00:35, Rein Henrichs r...@puppetlabs.com wrote:
* Per #4466, Ruby has trouble reading files in /proc [1]. The
alternative is to use `bin/cat`.
* Also refactored methods to explicitly redirect standard error to
/dev/null for *nix and BSD system calls.
+1
Random thought for
On 6 August 2010 00:35, Rein Henrichs r...@puppetlabs.com wrote:
From: Rein Henrichs re...@reinh.com
Rewrite of uptime facts and supporting utility methods. Works on unix,
BSD, windows. No longer makes redundant system calls.
+1, tested locally
Uses Facter::Util::Uptime utility methods:
*
On 6 August 2010 17:55, Paul Berry p...@puppetlabs.com wrote:
On Fri, Aug 6, 2010 at 2:23 AM, Paul Nasrat pnas...@gmail.com wrote:
Random thought for 1.6 or later we could have a ProcFile and Sysctl
specific class (and dmidecode) to encapsulate the complexities of
different platforms/versions
On 3 August 2010 23:03, Rein Henrichs r...@puppetlabs.com wrote:
From: Rein Henrichs re...@reinh.com
Rewrite of uptime facts and supporting utility methods. Works on unix,
BSD, windows. No longer makes redundant system calls.
Uses Facter::Util::Uptime utility methods:
Thanks for this, not
On 8 July 2010 09:07, Kai hashe...@gmail.com wrote:
In an earlier thread on puppet-users there was a request for a patch.
This is what I could come up with without discussing much.
Points that I can think of:
- Perhaps a suffix of 'KiB' is better in this world where kB could be
interpreted
On 25 July 2010 23:50, Jiri Kubicek jiri.kubi...@kraxnet.cz wrote:
There was no support for detecting FreeBSD jails as a virtual in facter. This
patch detects jail by getting security.jail.jailed kernel state via sysctl.
Thanks, on a scan looks good, but I'll try test later today.
Paul
On 25 July 2010 23:50, Jiri Kubicek jiri.kubi...@kraxnet.cz wrote:
There was no support for detecting FreeBSD running in KVM as a virtual in
facter. This patch detects KVM by getting hw.model kernel state via sysctl.
Jails running in KVM are also correctly detected as jail not kvm.
Looks
On 15 June 2010 18:26, James Turnbull ja...@lovedthanlost.net wrote:
Thanks to Alan Barrett for the patch
I know it's a trivial change but shouldn't it have a test.
Paul
Signed-off-by: James Turnbull ja...@lovedthanlost.net
---
lib/puppet/parser/lexer.rb | 2 +-
1 files changed, 1
On 10 June 2010 07:16, James Turnbull ja...@lovedthanlost.net wrote:
Signed-off-by: James Turnbull ja...@lovedthanlost.net
-1
Hmm, there are a whole bunch of facts/commands that require root or
behave differently. I'd rather see this implemented as a confine.
---
lib/facter/memory.rb |
2010/6/10 Héctor Rivas Gándara key...@gmail.com:
I think it simply could detect that the command (swap -l ) failed and
raise an exception with the output (or first line of the output).
Potentially yes, we should change how util.exec works and enable
logging to user/exception passing to lib
On 24 April 2010 06:38, James Turnbull ja...@lovedthanlost.net wrote:
From: Jonas Genannt jo...@brachium-system.net
Signed-off-by: James Turnbull ja...@lovedthanlost.net
---
lib/facter/util/vlans.rb | 25 +
lib/facter/vlans.rb |8
On 30 April 2010 14:32, David Schmitt da...@dasz.at wrote:
On 4/30/2010 10:45 AM, James Turnbull wrote:
The following piece has a hole that triggers a spec fail on windows.
Shell-builtins are not checked although they would work when executed. I've
investigated a bit and the problem is,
This addresses #3356 and supports an arbitrary TLD with hosts in.
Signed-off-by: Paul Nasrat pnas...@googlemail.com
---
lib/facter/domain.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/facter/domain.rb b/lib/facter/domain.rb
index 5dfead0..a04d2b8 100644
On 27 May 2010 13:45, Paul Nasrat pnas...@gmail.com wrote:
This addresses #3356 and supports an arbitrary TLD with hosts in.
Signed-off-by: Paul Nasrat pnas...@googlemail.com
Actually I want to write a whole bunch of tests before I change anything
here.
Paul
--
You received this message
On 7 May 2010 08:21, Marc Fournier marc.fourn...@camptocamp.com wrote:
Splitting dmi output on the string /^Handle/ didn't work, and
caused the function to match the wrong key if it was found more
than once.
The intended behaviour of the function is restored by splitting
the dmi output on
On 7 May 2010 08:21, Marc Fournier marc.fourn...@camptocamp.com wrote:
Hello,
I'm not sure to understand the use of these trailing dots I removed with
the
2nd patch. As there isn't many tests for this function, maybe this breaks
something else and needs more work.
If I have time over the
Signed-off-by: Paul Nasrat pnas...@googlemail.com
---
spec/unit/virtual.rb |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/spec/unit/virtual.rb b/spec/unit/virtual.rb
index fe9988e..7dbd146 100644
--- a/spec/unit/virtual.rb
+++ b/spec/unit/virtual.rb
@@ -50,6 +50,7
On 30 March 2010 09:52, Pavol Dilung pavol.dil...@gmail.com wrote:
Hi Luke,
yep, those patches are same. I messed up the Subject in first post so
I've repost it again. Sorry for that ;)
OK cool - I can test here at work and validate. My home internet
should be back tomorrow (but at puppet
Meet up following training, open to all, we'll meet at The Green Man
pub again, I get off about 18h so probably there about 18:30 but feel
free to get there earlier if the class finishes up.
Green Man
36 Riding Hood St
London
W1W 7EP
http://www.thegreenmanw1.co.uk/
It's 4 mins by google maps
On 11 March 2010 18:12, Michael DeHaan mich...@reductivelabs.com wrote:
It's already on the roadmap and as an issue, but we need to fix facter
HEAD first.
Revisiting the facter bugs list, I don't see it as particularly in bad
shape now that this fact is reverted.
Yup I want to get 1.5.8 rc1
On 9 March 2010 18:13, Markus Roberts mar...@reductivelabs.com wrote:
Doh, yes, thanks. I was reading that on the train with screen glare and
missed some of the -' signs.
I've commited this now, and have started working through the 1.5.8 bug list.
Paul
--
You received this message because
On 9 March 2010 19:33, Michael DeHaan mich...@reductivelabs.com wrote:
Excellent. I also hope to help some with the code refactoring and support
for new datastructure types.
I agree bugs should come first, so those too :)
If you're doing this, we should do a testing branch and target for
On 9 March 2010 22:08, Michael DeHaan mich...@reductivelabs.com wrote:
Also cleaned up a few error messages (unrelated)
---
lib/puppet/application/puppetrun.rb | 12 ++-
lib/puppet/daemon.rb | 2 +-
lib/puppet/network/server.rb | 2 +-
On 10 March 2010 03:56, Nigel Kersten nig...@google.com wrote:
On Tue, Mar 9, 2010 at 5:52 PM, Luke Kanies l...@reductivelabs.com wrote:
On Mar 9, 2010, at 5:09 AM, Michael DeHaan wrote:
{
facts: {
network: {
interface: eth0,
ip: 192.168.0.1,
netmask: 255.255.255.0,
},
On 10 March 2010 06:41, Luke Kanies l...@reductivelabs.com wrote:
On Mar 9, 2010, at 10:35 PM, Paul Nasrat wrote:
On 10 March 2010 03:56, Nigel Kersten nig...@google.com wrote:
On Tue, Mar 9, 2010 at 5:52 PM, Luke Kanies l...@reductivelabs.com
wrote:
On Mar 9, 2010, at 5:09 AM, Michael
On 8 March 2010 20:58, Michael DeHaan mich...@reductivelabs.com wrote:
Some of us have been talking about this for a while and I'm thinking
about knocking this out soon.
The idea is you should be able to write facts in any language, and
this lowers the barrier to entry for Puppet extensions
On 8 March 2010 18:54, Michael DeHaan mich...@reductivelabs.com wrote:
These two patches are a basic attempt to enhance Puppetrun to support
shell globs.
Can you configure your mailer to send inline/use git mail_patches so
they're not attachments for easier review.
Paul
--
You received this
On 8 March 2010 21:03, Michael DeHaan mich...@reductivelabs.com wrote:
On Mon, Mar 8, 2010 at 4:01 PM, Paul Nasrat pnas...@googlemail.com wrote:
On 8 March 2010 18:54, Michael DeHaan mich...@reductivelabs.com wrote:
These two patches are a basic attempt to enhance Puppetrun to support
shell
patch fixes the first two, I'm not sure we want to take
the timeout hit, we also want to add tests as even simple ruby code can get
logic errors such as the open().
Signed-off-by: Paul Nasrat pnas...@googlemail.com
---
lib/facter/ec2.rb |5 -
1 files changed, 4 insertions(+), 1 deletions
is already in long form, it won't try to build
the fqdn fact from hostname and domain.
Signed-off-by: Paul Nasrat pnas...@googlemail.com
---
lib/facter/domain.rb |8
lib/facter/fqdn.rb |4
lib/facter/hostname.rb |7 ---
3 files changed, 12 insertions(+), 7
-by: Paul Nasrat pnas...@googlemail.com
---
lib/facter/util/resolution.rb | 23 +---
spec/unit/util/resolution.rb | 44 -
2 files changed, 6 insertions(+), 61 deletions(-)
diff --git a/lib/facter/util/resolution.rb b/lib/facter/util
On 28 February 2010 13:10, Paul Nasrat pnas...@googlemail.com wrote:
From: Ohad Levy ohad.l...@infineon.com
This patch removes the relationship between the domain fact and LDAP/NIS
domains.
domain fact relates to DNS domain - this will avoid the confusion caused
by the LDAP/NIS domain
On 18 January 2010 18:34, Luke Kanies l...@reductivelabs.com wrote:
What the heck is gnu/kfreebsd?
Code seems ok, though.
Commited
Paul
--
You received this message because you are subscribed to the Google Groups
Puppet Developers group.
To post to this group, send email to
2010/1/22 Markus Roberts mar...@reality.com:
Since libdir is also the default for the plugin handler, it needs to
be : savvy as well.
This really should be File::PATH_SEPARATOR and not ':'
Paul
--
You received this message because you are subscribed to the Google Groups
Puppet Developers
2010/1/18 Luke Kanies l...@reductivelabs.com:
On Jan 17, 2010, at 9:03 AM, Paul Nasrat wrote:
This adds a test to ensure we are not prematurely splitting on Handle
Signed-off-by: Paul Nasrat pnas...@googlemail.com
---
lib/facter/util/manufacturer.rb | 2 +-
spec/unit/util/manufacturer.rb
2010/1/11 Ohad Levy ohadl...@gmail.com:
+1
is there a reason why not to strip all facts?
I'm a little cautious about doing that in general in case someone has
a dependancy on a fact with a space in or valid but odd setups
(directories with trailing space). Although all the examples I can
2010/1/11 Thomas Bellman bell...@nsc.liu.se:
Paul Nasrat wrote:
2010/1/11 Ohad Levy ohadl...@gmail.com:
is there a reason why not to strip all facts?
I'm a little cautious about doing that in general in case someone has
a dependancy on a fact with a space in or valid but odd setups
In addition to the stripping of the output of these facts this patchset:
Refactor - Extracted function to enable easier testing.
Tests - data driven tests for the dmidecode/smbios fact.
Paul
Signed-off-by: Paul Nasrat pnas...@googlemail.com
---
lib/facter/util/manufacturer.rb| 17
2010/1/10 Markus Roberts mar...@reality.com:
The recent release of 0.25.2 contains a new method of handling communication
with execed processes to support SELinux and improve performance on other
OSes which, unfortunately, has a number of shortcomings:
Just had a quick scan through the patch
2010/1/8 Peter Meier peter.me...@immerda.ch:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi
I've shuffled a few low hanging fruit tickets to a new Facter
release - 1.5.8 - I intend to knock all of these over in the next
week or so and cut a release. The rationale is mainly that it has
1 - 100 of 266 matches
Mail list logo
