Repository options are configured as follows:
- Hosting Service: None - Custom Repository
- Repository Type: Git
- Path: git@myserver:mygroup/myproject.git
- Raw file URL
mask: http://myserver/mygroup/myproject/raw/develop/filename
For our repository:
- GitLab (7.4.3)
-
On Thu, Apr 23, 2015 at 11:49 AM James Knight james.d.kni...@live.com
wrote:
Repository options are configured as follows:
- Hosting Service: None - Custom Repository
- Repository Type: Git
- Path: git@myserver:mygroup/myproject.git
- Raw file URL mask:
Yeah, the raw file URL needs to have the revision in there somewhere. Since
you're using GitLab, you should just choose GitLab instead of None -
Custom Repository
-David
On Thu, Apr 23, 2015 at 10:52 AM Stephen Gallagher
step...@gallagherhome.com wrote:
On Thu, Apr 23, 2015 at 11:49 AM James
of the new commit, and only the new commit
will be shown.
I'm assuming that ReviewBoard just doesn't support multiple parent diffs.
My current work around is to squash the series of parent commits for a
given patch and add rebase my commits off their respective squashed
parents. This will provide
You're missing the point though. You still have to have an addressable hash
from the repo in order to establish a baseline or else none of the parent
diffs will have anything to compare against.
On Thu, Apr 23, 2015 at 5:23 PM James Knight james.d.kni...@live.com
wrote:
First of all, thanks
that. :(
On Thursday, April 23, 2015 at 6:09:41 PM UTC-4, Stephen Gallagher wrote:
You're missing the point though. You still have to have an addressable
hash from the repo in order to establish a baseline or else none of the
parent diffs will have anything to compare against.
On Thu, Apr 23
to explain it more than that. :(
On Thursday, April 23, 2015 at 6:09:41 PM UTC-4, Stephen Gallagher wrote:
You're missing the point though. You still have to have an addressable
hash from the repo in order to establish a baseline or else none of the
parent diffs will have anything to compare
on a branch that
is
not yet committed. In this case, a parent diff of the parent branch would
be provided along with the diff of the new commit, and only the new
commit
will be shown.
I'm assuming that ReviewBoard just doesn't support multiple parent
diffs. My current work around is to squash
So I wasn't using RBTools but I figured I'd try it first to see a working
solution with rbt rather than using the web interface.
After installing and invoking `rbt`, the first commit of ten (10) created
my first review for me. As soon as I try performing an `rbt posh
full_commit_index` on the
How have you configured the repository on Review Board?
-David
On Wed, Apr 22, 2015 at 1:50 PM James Knight james.d.kni...@live.com
wrote:
So I wasn't using RBTools but I figured I'd try it first to see a working
solution with rbt rather than using the web interface.
After installing and
I have the following scenario, I have a remote Git repository (powered by
GitLab) configured and working as expected with ReviewBoard (2.0.15). In my
local repository (cloned), I have a series of ten (10) commits I'm about to
push to the origin. Before I do this, I generate a (full indexed;
On Thu, 2015-04-16 at 09:07 -0700, James Knight wrote:
I have the following scenario, I have a remote Git repository
(powered by GitLab) configured and working as expected with
ReviewBoard (2.0.15). In my local repository (cloned), I have a
series of ten (10) commits I'm about to push to
I've used NSIS in the past and I really don't like it: I've found it can
lead to fragile setup packages. You may be able to use the free Visual
Studio 2013 Express with WiX after installing Update 2 to avoid having to
purchase a copy.
To build the installer, you'd just run msbuild /m
I looked into the Windows installer. I love the idea of getting one in, but at
the moment, neither of us have Visual Studio, so we need to figure out if we
want that as a dependency or if we want to evaluate something else (like NSIS).
There’s also the matter of integrating this with our build
Thanks! I've started committing .reviewboardrc files to each repo. I was
slightly worried about the server changing, but it's simple enough to add a
CNAME so things don't break.
Is there anything I can do to help get the Windows installer patch
committed and not forgotten about (presuming it's
Am I correct in thinking that a good practice would be to have users enter
the reviewboard.url setting in their mercurial.ini/.hgrc files and have a
.reviewboardrc file with just a REPOSITORY line committed to the
repository, to avoid RBTools having to search for a matching repo in RB
each time?
On 06/20/2014 03:08 PM, Bruce Cran wrote:
Am I correct in thinking that a good practice would be to have users
enter the reviewboard.url setting in their mercurial.ini/.hgrc files and
have a .reviewboardrc file with just a REPOSITORY line committed to the
repository, to avoid RBTools having to
Well, we were able to get things working with RB Tools after a fashion. The
rbt setup-repo command always failed to find the repository, returning an
error 500. If we run rbt post --repository=foo, however, everything works
fine. I think the setup-repo command either fails because we do not have
Yeah, I've found that setup-repo doesn't work for us either. For now I
always use both --server and --repository, though I should just do the
setup manually.
With RBTools 0.6.1, setup-repo asks about 3 repos (whether they're the one
I want to use) but they're all wrong.
--
Bruce
On Tue, Jun
What type of repository is it?
It’d be really helpful to have the Path and Mirror Path fields from the desired
Repository entry, and have the URL you use locally to check out the repository,
so that we can figure out what’s going wrong.
Christian
--
Christian Hammond -
Hi Christian,
All of our repos are mercurial repos.
An example Path would be /data_local/hg-repository/foo. The mirror path
is unused and unconfigured in all cases.
We clone from ssh://devel.ourserver.com//devel/src/hg-repository/foo
On Tue, Jun 17, 2014 at 2:22 PM, Christian Hammond
Hi Sara,
Okay, that’s why. ‘rbt setup-repo’ is really intended for the typical case
where the paths more or less match up. If your Path or Mirror Path looked like
the ssh:// URL, they would have been found.
Christian
--
Christian Hammond - christ...@beanbaginc.com
Review Board -
That makes sense. It would be nice to see a section in the RB Tools setup
documentation about what to do if the setup-repo command fails. I'm not
worried about it on our end.
On Tue, Jun 17, 2014 at 2:42 PM, Christian Hammond christ...@beanbaginc.com
wrote:
Hi Sara,
Okay, that’s why. ‘rbt
Isn't this covered in
http://www.reviewboard.org/docs/rbtools/0.6/rbt/configuration/ ?
--
Bruce
On Tue, Jun 17, 2014 at 1:49 PM, Sara Rayburn sararayb...@gmail.com wrote:
That makes sense. It would be nice to see a section in the RB Tools setup
documentation about what to do if the
Hi Bruce,
Nowhere does that documentation refer to the fact that setup-repo will
often fail with less than useful errors. I think that the error should be
more useful (error 500 is not super helpful for the person trying to run
the setup command) and that the docs should mention that setup-repo
I agree, http 500 isn't at all useful: I think on my setup I was always
seeing an error saying there were no matching repositories found.
Christian's mention of Mirror Path was the hint I needed to look up the
documentation - from there I realised that entering the ssh:// URL that
developers use
Hi,
Bruce, the installer works for our Windows guys just fine. Thanks for
putting that together!
Unfortunately, we can't seem to get RB Tools configured properly for
anyone, but that's a question for another day.
Sara
On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com
What’s going wrong with the configuration?
Christian
--
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote:
Hi,
Bruce, the installer works
I've put together an RBTools installer for Windows for testing that adds
only the rbt command to the environment (i.e. it doesn't pollute %PATH%
with python.exe etc.).
It's available from http://bluestop.org/rbtools/RBTools-0.6.1.exe - I'd
welcome any feedback.
It _should_ work on Windows XP and
Hi Bruce,
That’s fantastic. I just installed in a fresh VM, and had RBTools
up-and-running in just a couple minutes.
Would you be willing to contribute the source to the installer? I’d like to
ship an official installer with our future releases.
Christian
--
Christian Hammond -
Christian,
Yes, I was hoping I'd be able to contribute the code to make future
maintenance simpler.
Which repo and in which directory would it be added? I see there's a old
rb-win32-installer repository on github for Review Board - would it be
there, or under contrib/ in the rbtools repo etc.?
Awesome :)
Under rbtools/contrib/installer/ would probably be best. We may end up moving
it, but that’s ag ood starting point.
rb-win32-installer is an old repository that can be pretty much ignored at this
point.
Christian
--
Christian Hammond - christ...@beanbaginc.com
Review Board -
page. For our
workflow, parent diffs are the norm, not a complex case.
Thanks,
Sara
On Thursday, June 12, 2014 7:44:39 PM UTC-5, David Trowbridge wrote:
Sara,
Is the reluctance just that installing python stuff on Windows is hard, or
are there other concerns?
It might be nice to add
is that it
requires Python 2.7, and they are running Python 3 for other services.
They've tried having both installed with no success. I think it would be a
good decision to restore parent diff support to the New Review Request
page. For our workflow, parent diffs are the norm, not a complex case.
--
Get
decision
to restore parent diff support to the New Review Request page. For our
workflow, parent diffs are the norm, not a complex case.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com
reviews with parent diffs? The windows developers in our group would prefer
not to install RB Tools and all of its dependencies.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user
, there was an option to upload both a diff and a parent diff. This
is no longer an option. Is there still a way to use the web tool to create
reviews with parent diffs? The windows developers in our group would prefer
not to install RB Tools and all of its dependencies.
--
Get the Review Board
Comment #9 on issue 3273 by walt.jav...@gmail.com: rbt post with git-svn
and --parent diffs traces back
http://code.google.com/p/reviewboard/issues/detail?id=3273
Thanks for fixing this David!
--
You received this message because this project is configured to send all
issue notifications
Updates:
Status: New
Owner: trowb...@gmail.com
Comment #4 on issue 3273 by trowb...@gmail.com: rbt post with git-svn and
--parent diffs traces back
http://code.google.com/p/reviewboard/issues/detail?id=3273
OK, I'll spend some time setting up a git-svn environment and work
Comment #5 on issue 3273 by walt.jav...@gmail.com: rbt post with git-svn
and --parent diffs traces back
http://code.google.com/p/reviewboard/issues/detail?id=3273
When is 0.6 estimated to come out?
I can also spend some time hacking on this as well, though some of it is
above my head.
I
Comment #6 on issue 3273 by trowb...@gmail.com: rbt post with git-svn and
--parent diffs traces back
http://code.google.com/p/reviewboard/issues/detail?id=3273
I don't think we have a plan yet for an 0.6 date. It's probably soon, but
there are still some bugs to shake out.
--
You
Comment #3 on issue 3273 by walt.jav...@gmail.com: rbt post with git-svn
and --parent diffs traces back
http://code.google.com/p/reviewboard/issues/detail?id=3273
David,
That code should almost certainly be removed. Doing so just pushed the
traceback to a different part of the code
Updates:
Status: NeedInfo
Comment #2 on issue 3273 by trowb...@gmail.com: rbt post with git-svn and
--parent diffs traces back
http://code.google.com/p/reviewboard/issues/detail?id=3273
After looking at the code, I believe everything should work by just
removing these lines from
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3273 by walt.jav...@gmail.com: rbt post with git-svn and --parent
diffs traces back
http://code.google.com/p/reviewboard/issues/detail?id=3273
What version are you running?
RBTools 0.6 alpha 0 (dev)
Review Board 1.7.21
Updates:
Labels: Component-RBTools
Comment #11 on issue 3067 by trowb...@gmail.com: Parent diffs with
mercurial are still broken
http://code.google.com/p/reviewboard/issues/detail?id=3067
(No comment was entered for this change.)
--
You received this message because this project
Updates:
Status: Fixed
Comment #12 on issue 3067 by trowb...@gmail.com: Parent diffs with
mercurial are still broken
http://code.google.com/p/reviewboard/issues/detail?id=3067
This should now be completely fixed in rbtools master as of commit 5a93bb8.
This will ship in rbtools 0.6
Comment #9 on issue 3067 by scherere...@gmail.com: Parent diffs with
mercurial are still broken
http://code.google.com/p/reviewboard/issues/detail?id=3067
Possible related issue, but it may be a different bug. I attempted to use
the -o -g workaround and have encountered another edge case
Comment #10 on issue 3067 by patrick.horn: Parent diffs with mercurial are
still broken
http://code.google.com/p/reviewboard/issues/detail?id=3067
I'm using RB 1.7.12 and I had a slightly different problem with a simpler
solution (when using hg-style diffs).
The old code allowed
Comment #4 on issue 3067 by scherere...@gmail.com: Parent diffs with
mercurial are still broken
http://code.google.com/p/reviewboard/issues/detail?id=3067
This bug is extremely aggravating for us. It appears to happen whenever the
parent diff does not contain the file that is being changed
Comment #5 on issue 3067 by glind...@dynamiccontrols.com: Parent diffs with
mercurial are still broken
http://code.google.com/p/reviewboard/issues/detail?id=3067
Thanks for that. Two remarks on your work-around:
- you can still use postreview. Just use both the --master and --parent
Comment #6 on issue 3067 by jemea...@gmail.com: Parent diffs with mercurial
are still broken
http://code.google.com/p/reviewboard/issues/detail?id=3067
For postreview, I'm using the -o option in combination with -g and it is
enough to work around this bug.
-o will use a parent diff based
Comment #7 on issue 3067 by scherere...@gmail.com: Parent diffs with
mercurial are still broken
http://code.google.com/p/reviewboard/issues/detail?id=3067
I can't seem to figure out a permutation of --master and --parent to get it
to work.
file added in revision 0, trying to review
Comment #5 on issue 2971 by bruce.c...@gmail.com: Can't view Mercurial
diffs with parent diffs in recent versions
http://code.google.com/p/reviewboard/issues/detail?id=2971
This doesn't appear to be fixed - I'm still seeing this problem in 1.7.13.
--
You received this message because
Updates:
Status: Fixed
Comment #4 on issue 2971 by trowb...@gmail.com: Can't view Mercurial diffs
with parent diffs in recent versions
http://code.google.com/p/reviewboard/issues/detail?id=2971
Fixed in release-1.7.x (45faed4). Thanks!
--
You received this message because
, 2013 at 1:11 PM, Bruce Cran bruce.c...@gmail.com wrote:
There seems to be a regression in 1.7.9 with mercurial parent diffs: if
a
file is modified in the review diff that wasn't changed in the parent
diff,
then Review Board generates the error Error: The file 'file2.txt'
(r12345678) could
Comment #3 on issue 2971 by bruce.c...@gmail.com: Can't view Mercurial
diffs with parent diffs in recent versions
http://code.google.com/p/reviewboard/issues/detail?id=2971
This problem does also affect Git though - see
http://demo.reviewboard.org/r/12105/diff/#index_header
--
You
There seems to be a regression in 1.7.9 with mercurial parent diffs: if a
file is modified in the review diff that wasn't changed in the parent diff,
then Review Board generates the error *Error:* The file 'file2.txt'
(r12345678) could not be found in the repository.
--
Bruce Cran
--
Want
Comment #2 on issue 2971 by c.caug...@gmail.com: Can't view Mercurial diffs
with parent diffs in recent versions
http://code.google.com/p/reviewboard/issues/detail?id=2971
I've investigated further; the issue was introduced by this changeset here:
https://github.com/reviewboard/reviewboard
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2971 by c.caug...@gmail.com: Can't view Mercurial diffs with
parent diffs in recent versions
http://code.google.com/p/reviewboard/issues/detail?id=2971
What version are you running?
1.7.7.1
(the problem did not exist
Comment #1 on issue 2971 by c.caug...@gmail.com: Can't view Mercurial diffs
with parent diffs in recent versions
http://code.google.com/p/reviewboard/issues/detail?id=2971
Forgot to say - the repro steps use the latest version of the hgreviewboard
extension: https://bitbucket.org/ccaughie
Updates:
Status: Fixed
Comment #3 on issue 2389 by trowb...@gmail.com: Incorrect web interface
styling when using parent diffs and new files
http://code.google.com/p/reviewboard/issues/detail?id=2389
Fixed in release-1.6.x (bbcbebe). Thanks!
--
You received this message because you
Comment #2 on issue 2389 by tinayang...@gmail.com: Incorrect web interface
styling when using parent diffs and new files
http://code.google.com/p/reviewboard/issues/detail?id=2389
I'll look into this.
--
You received this message because you are subscribed to the Google Groups
reviewboard
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2389 by daniel.m...@gmail.com: Incorrect web interface styling
when using parent diffs and new files
http://code.google.com/p/reviewboard/issues/detail?id=2389
* NOTE: Do not post confidential information in this bug
Hi all. I'm using Reviewboard 1.0.7 with Mercurial. I'm using the
Mercurial postreview extension from
http://bitbucket.org/mdelagra/mercurial-reviewboard/overview/
I have three changesets: 79fe5025631a, which is the parent of
e9b2e11ee3ce, which is the parent of 4e5eb065fa77.
79fe5025631a is
On Sun, Apr 26, 2009 at 16:26, ccaughie c.caug...@googlemail.com wrote:
I just read up some more on how git works and I think I now understand
why the existing code works for git but not for Mercurial; git uses
individual IDs for every file whereas Mercurial only has revision IDs
for commits.
No replies, so I've added a review request:
http://reviews.review-board.org/r/841/
Colin
On Apr 26, 3:26 pm, ccaughie c.caug...@googlemail.com wrote:
Hello again,
I just read up some more on how git works and I think I now understand
why the existing code works for git but not for
On Tue, Apr 28, 2009 at 16:20, ccaughie c.caug...@googlemail.com wrote:
No replies, so I've added a review request:
http://reviews.review-board.org/r/841/
Hi Colin,
sorry for the gap, i will test your patch soon.
--
Sebastien Douche sdou...@gmail.com
Hi Colin,
sorry for the gap, i will test your patch soon.
No problem. That would be great, thanks.
Colin
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to
Hi,
My company is in the process of switching to Mercurial, and are using
ReviewBoard to do code reviews. I am trying to get parent diffs
working so that we can post reviews for changesets even if the source
revision is not in the master repository.
So in other words my master repository
Hello again,
I just read up some more on how git works and I think I now understand
why the existing code works for git but not for Mercurial; git uses
individual IDs for every file whereas Mercurial only has revision IDs
for commits. So my original patch would fix Mercurial but probably
break
70 matches
Mail list logo
