[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables

2022-08-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 ) Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. Patch Set 5: Code-Review+2 LGTM! -- To view,

[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables

2022-08-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 ) Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 ) Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. Patch Set 2: (3 comments) Looks good!

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 7: PS7 is only a rebase. --

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#7). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 5: (21 comments) Thanks for

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#6). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 5: (14 comments) Thanks for

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#5). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2

[Impala-ASF-CR](branch-4.1.1) IMPALA-11346: Migrated partitioned Iceberg tables might return ERROR when WHERE condition is used on partition column

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18887 ) Change subject: IMPALA-11346: Migrated partitioned Iceberg tables might return ERROR when WHERE condition is used on partition column

[Impala-ASF-CR](branch-4.1.1) IMPALA-9410: Support resolving ORC file columns by names

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18906 ) Change subject: IMPALA-9410: Support resolving ORC file columns by names .. Patch Set 1: Code-Review+2 Thanks for backporting

[Impala-ASF-CR](branch-4.1.1) IMPALA-11344: Missing slots in all cases should be allowed to be read

2022-08-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18907 ) Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR](branch-4.1.1) IMPALA-11346: Migrated partitioned Iceberg tables might return ERROR when WHERE condition is used on partition column

2022-08-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18887 ) Change subject: IMPALA-11346: Migrated partitioned Iceberg tables might return ERROR when WHERE condition is used on partition column

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#4). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18854 ) Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0 .. IMPALA-11500:

[Impala-ASF-CR] WIP: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#2). Change subject: WIP: IMPALA-11484: Create SCAN plan for Iceberg V2

[Impala-ASF-CR] [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 ) Change subject: [IMPALA-11500] Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0 .. Patch Set 1: (2

[Impala-ASF-CR](asf-site) Update 4.1.0 release notes with more items

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18845 ) Change subject: Update 4.1.0 release notes with more items .. Patch Set 1: Code-Review+2 Thanks for adding these items! I checked

[Impala-ASF-CR] IMPALA-10800: Tidy up the be/src/exec directory

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18815 ) Change subject: IMPALA-10800: Tidy up the be/src/exec directory .. Patch Set 3: Code-Review+2 Thanks for working on this change!

[Impala-ASF-CR] WIP: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#3). Change subject: WIP: IMPALA-11484: Create SCAN plan for Iceberg V2

[Impala-ASF-CR] IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num values is 0

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 ) Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0 .. Patch Set 3:

[Impala-ASF-CR] WIP: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18847 Change subject: WIP: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. WIP: IMPALA-11484: Create SCAN plan

[Impala-ASF-CR] IMPALA-11398: Ignore Flake8 rule E126

2022-08-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18836 Change subject: IMPALA-11398: Ignore Flake8 rule E126 .. IMPALA-11398: Ignore Flake8 rule E126 In Impala we use 2 spaces for

[Impala-ASF-CR] IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg tbl (col list)

2022-08-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18790 ) Change subject: IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg_tbl (col_list) .. Patch Set 4:

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#10). Change subject: IMPALA-11350: Add virtual column FILE__POSITION

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 10: (9 comments) Thanks for the

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-09 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#9). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11481: Make test runtime profile aggregate slower to avoid flakyness

2022-08-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18825 ) Change subject: IMPALA-11481: Make test_runtime_profile_aggregate slower to avoid flakyness .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 6: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 8: Code-Review+1 PS8 is only a

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#8). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg tbl (col list)

2022-08-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18790 ) Change subject: IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg_tbl (col_list) .. Patch Set 3: (3

[Impala-ASF-CR] IMPALA-11408: Fill missing partition columns with NULL when INSERT INTO iceberg tbl (col list)

2022-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18790 ) Change subject: IMPALA-11408: Fill missing partition columns with NULL when INSERT INTO iceberg_tbl (col_list) .. Patch Set 2:

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#7). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-10453: Support file pruning via runtime filters on Iceberg

2022-08-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 ) Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 5: (13 comments) Thanks for the

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-08-02 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#5). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables

2022-07-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18735 ) Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables ..

[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables

2022-07-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18735 ) Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables .. Patch Set 4:

[Impala-ASF-CR] IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables

2022-07-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18639 ) Change subject: IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables .. Patch Set 16: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-07-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#4). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11362: Add expire snapshots functionality for Iceberg tables

2022-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 ) Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables .. Patch Set 5: Code-Review+1 Nice work!

[Impala-ASF-CR] IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables

2022-07-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18639 ) Change subject: IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables .. Patch Set 14: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-11287: [DOCS] Implement cloning between Iceberg tables

2022-07-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18706 ) Change subject: IMPALA-11287: [DOCS] Implement cloning between Iceberg tables .. Patch Set 1: Code-Review+2 Thanks for writing

[Impala-ASF-CR] IMPALA-11287: [DOCS] Implement cloning between Iceberg tables

2022-07-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18706 ) Change subject: IMPALA-11287: [DOCS] Implement cloning between Iceberg tables .. IMPALA-11287: [DOCS] Implement cloning

[Impala-ASF-CR] IMPALA-11414: Off-by-one error in Parquet late materialization

2022-07-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18700 ) Change subject: IMPALA-11414: Off-by-one error in Parquet late materialization .. Patch Set 2: Thanks for the review! -- To

[Impala-ASF-CR] IMPALA-11419: Incremental build is broken

2022-07-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18708 ) Change subject: IMPALA-11419: Incremental build is broken .. Patch Set 2: Code-Review+2 (2 comments) Carry +2

[Impala-ASF-CR] IMPALA-11419: Incremental build is broken

2022-07-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Laszlo Gaal (Cloudera), Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18708 to look at the new patch set (#2). Change subject: IMPALA-11419: Incremental build is broken

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-07-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18704 to look at the new patch set (#3). Change subject: IMPALA-11350: Add virtual column FILE__POSITION for

[Impala-ASF-CR] IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables

2022-07-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18639 ) Change subject: IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables .. Patch Set 12: (6 comments) Left a

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

2022-07-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18658 ) Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables .. IMPALA-11287 (part 2): Implement

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

2022-07-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 ) Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables .. Patch Set 9: Code-Review+2 Thanks!

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

2022-07-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 ) Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables .. Patch Set 7: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated

2022-07-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 ) Change subject: IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-11419: Incremental build is broken

2022-07-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18708 Change subject: IMPALA-11419: Incremental build is broken .. IMPALA-11419: Incremental build is broken IMPALA-11384 broke

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-07-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 ) Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11414: Off-by-one error in Parquet late materialization

2022-07-06 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18700 to look at the new patch set (#2). Change subject: IMPALA-11414: Off-by-one error in Parquet late materialization

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

2022-07-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions

2022-07-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 ) Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions .. Patch Set 11: Code-Review+2 Thank

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

2022-07-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read .. Patch Set 16: Code-Review+1 Thanks for

[Impala-ASF-CR] IMPALA-11350: Add virtual column FILE POSITION for Parquet tables

2022-07-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18704 Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables .. IMPALA-11350: Add virtual column

[Impala-ASF-CR] IMPALA-11414: Off-by-one error in Parquet late materialization

2022-07-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18700 Change subject: IMPALA-11414: Off-by-one error in Parquet late materialization .. IMPALA-11414: Off-by-one error in Parquet late

[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated

2022-07-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 ) Change subject: IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated .. Patch Set 1: Code-Review+2

[Impala-ASF-CR] IMPALA-11344: Missing slots in all cases should be allowed to be read

2022-07-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions

2022-07-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 ) Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions .. Patch Set 10: Code-Review+1 (4

[Impala-ASF-CR] IMPALA-11331: Handle concurrent Iceberg INSERT OVERWRITEs

2022-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18648 ) Change subject: IMPALA-11331: Handle concurrent Iceberg INSERT OVERWRITEs .. Patch Set 3: Code-Review+2 (1 comment) One small

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

2022-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 ) Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables .. Patch Set 4: (4 comments) Thank you

[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions

2022-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 ) Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions .. Patch Set 8: (6 comments) Found a

[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone

2022-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 ) Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone .. Patch Set 5:

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set 9:

[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone

2022-06-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 ) Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone .. Patch Set 4: (1

[Impala-ASF-CR] IMPALA-11391: Fixed race condition in test drop managed kudu table

2022-06-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18667 ) Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table .. Patch Set 2: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone

2022-06-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18675 ) Change subject: IMPALA-11368: Iceberg time-travel error message should show timestamp in local timezone .. Patch Set 1: (2

[Impala-ASF-CR] IMPALA-11403: Fix cmake escaping for sed regex in common/thrift

2022-06-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18678 ) Change subject: IMPALA-11403: Fix cmake escaping for sed regex in common/thrift .. Patch Set 1: Code-Review+2 LGTM! -- To view,

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set 9:

[Impala-ASF-CR] IMPALA-11279: Optimize plain count(*) queries for Iceberg tables

2022-06-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18574 ) Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables .. Patch Set 15: Code-Review+2 Great work!

[Impala-ASF-CR] IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases

2022-06-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18649 ) Change subject: IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs

2022-06-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18648 ) Change subject: IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs .. Patch Set 1: (9 comments) Found a couple of nits,

[Impala-ASF-CR] IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases

2022-06-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18649 ) Change subject: IMPALA-11378: Allow INSERT OVERWRITE for bucket tranforms in some cases .. Patch Set 1: (2 comments) Thanks for

[Impala-ASF-CR] IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read

2022-06-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 ) Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read .. Patch Set 5:

[Impala-ASF-CR] IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions

2022-06-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 ) Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions .. Patch Set 4: (5 comments) Thanks

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11279: Optimize plain count(*) queries for Iceberg tables

2022-06-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18574 ) Change subject: IMPALA-11279: Optimize plain count(*) queries for Iceberg tables .. Patch Set 14: Code-Review+1 LGTM! -- To

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. Patch Set 3: Code-Review+2 (1 comment) One small nit,

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

2022-06-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 ) Change subject: IMPALA-11358: Fixed Kudu table's missing comment .. Patch Set 7: Code-Review+2 LGTM! Thanks for fixing this. --

[Impala-ASF-CR] IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables

2022-06-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 ) Change subject: IMPALA-11367: Fix some formatting bugs when DESCRIBE FORMATTED for Iceberg tables .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-11365: Dereferencing null pointer in TopNNode

2022-06-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18629 ) Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-11367: There should be LINE DELIM above '# Partition Transform Information'

2022-06-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18634 ) Change subject: IMPALA-11367: There should be LINE_DELIM above '# Partition Transform Information' .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

2022-06-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 ) Change subject: IMPALA-11358: Fixed Kudu table's missing comment .. Patch Set 6: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10453: Support file pruning via runtime filters on Iceberg

2022-06-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 ) Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-10453: Support file pruning via runtime filters on Iceberg

2022-06-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 ) Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables

2022-06-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18583 ) Change subject: IMPALA-11335: allocate WriteId before taking locks during INSERT to ACID tables .. Patch Set 2: Code-Review+2

[Impala-ASF-CR] IMPALA-11334: Include partition transform information in DESCRIBE FORMATTED for Iceberg tables

2022-06-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18593 ) Change subject: IMPALA-11334: Include partition transform information in DESCRIBE FORMATTED for Iceberg tables .. Patch Set 3:

[Impala-ASF-CR](3.x) IMPALA-11296: Fix infinite loop when reading orc files

2022-06-10 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18571 ) Change subject: IMPALA-11296: Fix infinite loop when reading orc files .. Patch Set 8: Code-Review+2 Thanks for fixing this! --

[Impala-ASF-CR] IMPALA-11346: Migrated partitioned Iceberg tables might return ERROR when WHERE condition is used on partition column

2022-06-09 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18605 Change subject: IMPALA-11346: Migrated partitioned Iceberg tables might return ERROR when WHERE condition is used on partition column

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-06-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18514 ) Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name .. Patch Set 8: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-06-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Tamas Mate, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18514 to look at the new patch set (#8). Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name

<    3   4   5   6   7   8   9   10   11   12   >