[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. IMPALA-6031: Fix executor node count in

[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10876 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 12: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

[Impala-ASF-CR] IMPALA-7260: Fix decimal binary predicates

2018-07-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10888 Change subject: IMPALA-7260: Fix decimal binary predicates .. IMPALA-7260: Fix decimal binary predicates When casting the inputs

[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. IMPALA-6642 (Part 2): clean up

[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate

2018-07-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10882 ) Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7216: Fix SQL generated by toSql functions in CreateViewStmt & AlterViewStmt

2018-07-06 Thread Pooja Nilangekar (Code Review)
Hello Bikramjeet Vig, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10886 to look at the new patch set (#2). Change subject: IMPALA-7216: Fix SQL generated by toSql functions in CreateViewStmt & AlterViewStmt

[Impala-ASF-CR] IMPALA-3040: Remove cache directives if a partition is dropped externally

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally .. Patch Set 7: Verified-1 Build

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-06 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. Patch Set 7: > Patch Set 6: > > (1 comment) Sorry,

[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Pooja Nilangekar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10873 to look at the new patch set (#7). Change subject: IMPALA-6031: Fix executor node count in distributed plans

[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10876 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10876 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. IMPALA-6031: Fix executor node count in distributed

[Impala-ASF-CR] IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate

2018-07-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10882 ) Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7261: Fix SQL generated by toSql functions in CreateViewStmt & AlterViewStmt

2018-07-06 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10886 Change subject: IMPALA-7261: Fix SQL generated by toSql functions in CreateViewStmt & AlterViewStmt .. IMPALA-7261: Fix SQL

[Impala-ASF-CR] IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2018-07-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10876 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. Patch Set 5: Code-Review+2 (4 comments) lgtm, only a

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. Patch Set 3: Build started:

[Impala-ASF-CR] Bump toolchain version, include libunwind

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10755 ) Change subject: Bump toolchain version, include libunwind .. Bump toolchain version, include libunwind Change-Id:

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER Alter the

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER Alter the

[Impala-ASF-CR] IMPALA-7199: Add scripts to create code coverage reports

2018-07-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10791 ) Change subject: IMPALA-7199: Add scripts to create code coverage reports .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-6642 (Part 2): clean up start-impala-cluster.py

2018-07-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10780 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2018-07-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10696 ) Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh

2018-07-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 2: (37 comments) Did a first pass. Will have

[Impala-ASF-CR] IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2018-07-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10876 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 4: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER Alter the

[Impala-ASF-CR] IMPALA-6031: Fix executor node count in distributed plans

2018-07-06 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10873 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. IMPALA-6031: Fix executor node count in distributed

[Impala-ASF-CR] IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2018-07-06 Thread Pooja Nilangekar (Code Review)
Hello Fredy Wijaya, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10876 to look at the new patch set (#4). Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

[Impala-ASF-CR] IMPALA-7251: Fix QueryMaintenance calls in Aggregators

2018-07-06 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10871 ) Change subject: IMPALA-7251: Fix QueryMaintenance calls in Aggregators .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10884 ) Change subject: IMPALA-7239: Disable smaps parsing by default .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7251: Fix QueryMaintenance calls in Aggregators

2018-07-06 Thread Thomas Marshall (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10871 to look at the new patch set (#2). Change subject: IMPALA-7251: Fix QueryMaintenance calls in Aggregators ..

[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2018-07-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 7: (3 comments) mostly nits, otherwise looks good.

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10884 ) Change subject: IMPALA-7239: Disable smaps parsing by default .. Patch Set 1: (3 comments) I don't think it's a breaking change - it

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-06 Thread Tim Armstrong (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10884 to look at the new patch set (#2). Change subject: IMPALA-7239: Disable smaps parsing by default .. IMPALA-7239:

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-07-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 17: Rebased and added javadoc. --

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 11: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-07-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. IMPALA-7106: Print rewritten SQL correctly when

[Impala-ASF-CR] IMPALA-3040: Remove cache directives if a partition is dropped externally

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally .. Patch Set 7: Code-Review+2 --

[Impala-ASF-CR] IMPALA-3040: Remove cache directives if a partition is dropped externally

2018-07-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally .. IMPALA-3040: Remove cache directives if a

[Impala-ASF-CR] IMPALA-3040: Remove cache directives if a partition is dropped externally

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-3040: Remove cache directives if a partition is dropped externally

2018-07-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally .. Patch Set 5: Code-Review+2 (1

[Impala-ASF-CR] Pick parts of recent Kudu gutil changes

2018-07-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: Pick parts of recent Kudu gutil changes .. Patch Set 11: This should be ready for review now. -- To view, visit

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-07-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10765 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 7: This should be ready for review now. --

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 7: This should be ready for review now. -- To

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 ) Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 7: This should be ready for review now. -- To view,

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-06 Thread Lars Volker (Code Review)
Lars Volker has removed Henry Robinson from this change. ( http://gerrit.cloudera.org:8080/10760 ) Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Removed reviewer Henry Robinson. -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [KSECURITY] Add security library to build

2018-07-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-4669: [KSECURITY] Add security library to build .. Patch Set 7: This should be ready for review now. -- To

[Impala-ASF-CR] IMPALA-4669: [KSECURITY] Add security library to build

2018-07-06 Thread Lars Volker (Code Review)
Lars Volker has removed Henry Robinson from this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-4669: [KSECURITY] Add security library to build .. Removed reviewer Henry Robinson. -- To view, visit

[Impala-ASF-CR] IMPALA-3040: Remove cache directives if a partition is dropped externally

2018-07-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10792 ) Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally .. IMPALA-3040: Remove cache directives if a

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 7: This should be ready for review now. -- To

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-06 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#7). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-06 Thread Lars Volker (Code Review)
Hello Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10760 to look at the new patch set (#6). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build

[Impala-ASF-CR] IMPALA-4669: [KSECURITY] Add security library to build

2018-07-06 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10759 to look at the new patch set (#6). Change subject: IMPALA-4669: [KSECURITY] Add security library to build

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10884 ) Change subject: IMPALA-7239: Disable smaps parsing by default .. Patch Set 1: (3 comments) Should this be considered incompatible? eg

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10884 Change subject: IMPALA-7239: Disable smaps parsing by default .. IMPALA-7239: Disable smaps parsing by default Accessing smaps has

[Impala-ASF-CR] Bump toolchain version, include libunwind

2018-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10755 ) Change subject: Bump toolchain version, include libunwind .. Patch Set 3: Build started:

[Impala-ASF-CR] Bump toolchain version, include libunwind

2018-07-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10755 ) Change subject: Bump toolchain version, include libunwind .. Patch Set 3: Code-Review+2 Rebased, carrying Tim's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-7140 (part 8): support views in LocalCatalog

2018-07-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10805 ) Change subject: IMPALA-7140 (part 8): support views in LocalCatalog .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7201. Support DDL with LocalCatalog enabled

2018-07-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10806 ) Change subject: IMPALA-7201. Support DDL with LocalCatalog enabled .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables

2018-07-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10798 ) Change subject: IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7140 (part 6): fetch column stats for LocalTable

2018-07-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10797 ) Change subject: IMPALA-7140 (part 6): fetch column stats for LocalTable .. Patch Set 2: Code-Review+2 (1 comment)

[native-toolchain-CR] IMPALA-7252. Backport rate limiting of fadvise calls for glog

2018-07-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10877 ) Change subject: IMPALA-7252. Backport rate limiting of fadvise calls for glog .. IMPALA-7252. Backport rate limiting of fadvise

[native-toolchain-CR] IMPALA-7252. Backport rate limiting of fadvise calls for glog

2018-07-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10877 ) Change subject: IMPALA-7252. Backport rate limiting of fadvise calls for glog .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-6994:Avoid reloading a table's HMS data for file-only operations

2018-07-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10587 ) Change subject: IMPALA-6994:Avoid reloading a table's HMS data for file-only operations .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate

2018-07-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10882 Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate .. IMPALA-7254: Inconsistent decimal behavior for

[Impala-ASF-CR] IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables

2018-07-06 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10798 to look at the new patch set (#3). Change subject: IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables

[Impala-ASF-CR] IMPALA-7201. Support DDL with LocalCatalog enabled

2018-07-06 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10806 to look at the new patch set (#2). Change subject: IMPALA-7201. Support DDL with LocalCatalog enabled

[Impala-ASF-CR] IMPALA-7140 (part 8): support views in LocalCatalog

2018-07-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10805 ) Change subject: IMPALA-7140 (part 8): support views in LocalCatalog .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables

2018-07-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10798 ) Change subject: IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Add KRPC folders from kudu@334ecafd

2018-07-06 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10757 ) Change subject: Add KRPC folders from kudu@334ecafd .. Add KRPC folders from kudu@334ecafd cp -a

[Impala-ASF-CR] IMPALA-6994:Avoid reloading a table's HMS data for file-only operations

2018-07-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10587 ) Change subject: IMPALA-6994:Avoid reloading a table's HMS data for file-only operations .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-7027: Mulitple varchar cast fails with distinct

2018-07-06 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10858 ) Change subject: IMPALA-7027: Mulitple varchar cast fails with distinct .. Patch Set 1: (2 comments)