[Impala-ASF-CR] Build a ConcatenatedStreams wrapper for ScannerContext::Stream

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/7513 ) Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream .. Abandoned Cleaning out old open reviews. -- To view, visit htt

[Impala-ASF-CR] Populate OffsetIndex and ColumnIndex of a row group and Filter pages

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/7465 ) Change subject: Populate OffsetIndex and ColumnIndex of a row_group and Filter pages .. Abandoned Cleaning out old open reviews. -- To view, vi

[Impala-ASF-CR] Add tpcds-unmodified performance workload.

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/5813 ) Change subject: Add tpcds-unmodified performance workload. .. Patch Set 1: This has been sitting idle for a long time - should we aband

[Impala-ASF-CR] IMPALA-6338: Disable flaky bloom filter test

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9822 ) Change subject: IMPALA-6338: Disable flaky bloom filter test .. Patch Set 1: Code-Review+1 (1 comment) Seems ok if we think that this

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 ) Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 5: Code-Review+1 This makes

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 5: (1 comment) http://gerr

[Impala-ASF-CR] Loosen hive-exec.jar glob pattern in copy-udfs-udas.sh.

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9925 ) Change subject: Loosen hive-exec.jar glob pattern in copy-udfs-udas.sh. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6801: Cleanup request pool

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9909 ) Change subject: IMPALA-6801: Cleanup request_pool .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9909/4/be/src/servic

[Impala-ASF-CR] IMPALA-6801: Cleanup request pool

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9909 ) Change subject: IMPALA-6801: Cleanup request_pool .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9909

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 3: Did we mean to merge this? -- To view, visit http://

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 ) Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation .. Patch Set 6: Yeah it is -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 12: (4 comments) Had some minor comments, but I'm ready t

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 6: Code-Review+1 -- To vie

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-05 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9928 to look at the new patch set (#2). Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. IMPALA-

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 13: Code-Review+2 I'm still in the process of running test

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 13: Actually I think the ASAN build is just slow - not sur

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 ) Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents() .. Patch Set 1: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-6338: Disable flaky bloom filter test

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9822 ) Change subject: IMPALA-6338: Disable flaky bloom filter test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-5607: part 1: change date part to return bigint

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9957 Change subject: IMPALA-5607: part 1: change date_part to return bigint .. IMPALA-5607: part 1: change date_part to return bigint This is

[Impala-ASF-CR] IMPALA-5607: part 1: breaking extract/date part changes

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9957 ) Change subject: IMPALA-5607: part 1: breaking extract/date_part changes .. IMPALA-5607: part 1: breaking extract/date_part changes This i

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: I pulled out the breaking parts into htt

[Impala-ASF-CR] IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9951 ) Change subject: IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents() .. Patch Set 2: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-5607: part 1: breaking extract/date part changes

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9957 ) Change subject: IMPALA-5607: part 1: breaking extract/date_part changes .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-5607: part 1: breaking extract/date part changes

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9957 ) Change subject: IMPALA-5607: part 1: breaking extract/date_part changes .. Patch Set 2: I started a dry run here an hour or two ago : h

[Impala-ASF-CR] IMPALA-5607: part 1: breaking extract/date part changes

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9957 ) Change subject: IMPALA-5607: part 1: breaking extract/date_part changes .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-5607: part 1: breaking extract/date part changes

2018-04-09 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9957 to look at the new patch set (#3). Change subject: IMPALA-5607: part 1: breaking extract/date_part changes

[Impala-ASF-CR] IMPALA-5607: part 1: breaking extract/date part changes

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9957 ) Change subject: IMPALA-5607: part 1: breaking extract/date_part changes .. Patch Set 3: Code-Review+2 Missed updating result types in s

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 1: (4 comments) There might be some opportuniti

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 8: It looks like this hit a

[Impala-ASF-CR] IMPALA-6711: loosen shell test prompt regex

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9831 ) Change subject: IMPALA-6711: loosen shell test prompt regex .. Patch Set 2: Does someone want to +2 this? It would be good to fix this

[Impala-ASF-CR] IMPALA-6711: loosen shell test prompt regex

2018-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9831 ) Change subject: IMPALA-6711: loosen shell test prompt regex .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#19) to the change originally created by Quanlong Huang. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. IMPALA-5717: Suppor

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 18: I made a couple of changes to the error handling to ma

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 20: Code-Review+2 You'll still be the author of the patch.

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9976 to look at the new patch set (#3). Change subject: Move some test_spilling debug actions to exhaustive .. Move so

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 3: Code-Review+2 carry +2 -- To view, visit http://g

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 3: And yeah, these tests are definitely time consuming

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/99

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 ) Change subject: IMPALA-5814: Remove startup flag to disable admission control .. Patch Set 2: Code-Review+2 (1 comment) This looks goo

[Impala-ASF-CR] Add tpcds-unmodified performance workload.

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/5813 ) Change subject: Add tpcds-unmodified performance workload. .. Abandoned Let's just abandon until the new version is ready for review. We can sti

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 ) Change subject: IMPALA-5814: Remove startup flag to disable admission control .. Patch Set 2: -Code-Review Actually we should separate

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 ) Change subject: IMPALA-5814: Remove startup flag to disable admission control .. Patch Set 3: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9928 to look at the new patch set (#3). Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. IMPALA-

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-4631: loosen monotonic clock DCHECK

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10026 Change subject: IMPALA-4631: loosen monotonic clock DCHECK .. IMPALA-4631: loosen monotonic clock DCHECK We saw another build failure d

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 4: Code-Review+1 carry -- To view, visit http://

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9928 to look at the new patch set (#4). Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. IMPALA-

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 4: Could you have a look at this Mike? Would be go

[Impala-ASF-CR] IMPALA-4631: loosen monotonic clock DCHECK

2018-04-11 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10026 to look at the new patch set (#2). Change subject: IMPALA-4631: loosen monotonic clock DCHECK .. IMPALA-4631: lo

[Impala-ASF-CR] IMPALA-4631: loosen monotonic clock DCHECK

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10026 ) Change subject: IMPALA-4631: loosen monotonic clock DCHECK .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10026/1/b

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 13: (9 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 10: (9 comments) Overall this is looking good. I had some

[Impala-ASF-CR] IMPALA-6837: allow multiple networks for distcc server

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10029 Change subject: IMPALA-6837: allow multiple networks for distcc server .. IMPALA-6837: allow multiple networks for distcc server Testin

[Impala-ASF-CR](2.x) IMPALA-5717: Support for reading ORC data files

2018-04-11 Thread Tim Armstrong (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9988 to review the following change. Change subject: IMPALA-5717: Support for reading ORC data files .

[Impala-ASF-CR](2.x) IMPALA-5717: Support for reading ORC data files

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9988 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR](2.x) IMPALA-5717: Support for reading ORC data files

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9988 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 1: Here's the ORC patch backported to 2.x with a minor con

[Impala-ASF-CR] IMPALA-4631: loosen monotonic clock DCHECK

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10026 ) Change subject: IMPALA-4631: loosen monotonic clock DCHECK .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4631: loosen monotonic clock DCHECK

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10026 ) Change subject: IMPALA-4631: loosen monotonic clock DCHECK .. IMPALA-4631: loosen monotonic clock DCHECK We saw another build

[Impala-ASF-CR] IMPALA-6837: allow multiple networks for distcc server

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10029 ) Change subject: IMPALA-6837: allow multiple networks for distcc server .. IMPALA-6837: allow multiple networks for distcc serve

[Impala-ASF-CR] IMPALA-6837: allow multiple networks for distcc server

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10029 ) Change subject: IMPALA-6837: allow multiple networks for distcc server .. Patch Set 1: Verified+1 Manually tested. Precommit tests don

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10052 ) Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP .. Patch Set 1: (1 comment) Are you also planning on

[Impala-ASF-CR] IMPALA-6463: [DOCS] Removed query options were deleted from docs

2018-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10055 ) Change subject: IMPALA-6463: [DOCS] Removed query options were deleted from docs .. Patch Set 1: Code-Review+2 Thanks! -- To view, v

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10052 ) Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: We also have the source code for sqlparse checked into the rep

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 2: Code-Review+2 (1 comment) LGTM so long a

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: One potential problem is that I know some people still want to

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: That seems like a good thing for use to do Fredy, but might be

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-13 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#3). Change subject: IMPALA-6847: work around high memory estimates for AC ..

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-13 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#4). Change subject: IMPALA-6847: work around high memory estimates for AC ..

[Impala-ASF-CR] IMPALA-6483: [DOCS] Document the new EXEC TIME LIMIT S query option

2018-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10043 ) Change subject: IMPALA-6483: [DOCS] Document the new EXEC_TIME_LIMIT_S query option .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#5). Change subject: IMPALA-6847: work around high memory estimates for AC ..

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#6). Change subject: IMPALA-6847: work around high memory estimates for AC ..

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#7). Change subject: IMPALA-6847: work around high memory estimates for AC .

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10052 ) Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#8). Change subject: IMPALA-6847: work around high memory estimates for AC .

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#9). Change subject: IMPALA-6847: work around high memory estimates for AC .

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#10). Change subject: IMPALA-6847: work around high memory estimates for AC

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#11). Change subject: IMPALA-6847: work around high memory estimates for AC

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 11: (6 comments) Here's the new simplified version

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-16 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#12). Change subject: IMPALA-6847: work around high memory estimates for AC

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10052 ) Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP .. Patch Set 3: (1 comment) LGTM except for one minor

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 12: (7 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#13). Change subject: IMPALA-6847: work around high memory estimates for AC

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 ) Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation .. Patch Set 6: (35 comments) I desperately need to rebase to be able

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-18 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9757 to look at the new patch set (#7). Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation ..

[Impala-ASF-CR] IMPALA-4835: switch I/O buffers to buffer pool

2018-04-18 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9679 to look at the new patch set (#11). Change subject: IMPALA-4835: switch I/O buffers to buffer pool .. IMPAL

<    3   4   5   6   7   8   9   10   11   12   >