[Impala-ASF-CR] IMPALA-12867: Filter files to OPTIMIZE based on file size (WIP)

2024-05-06 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21388 ) Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size (WIP) .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-12867: Filter files to OPTIMIZE based on file size (WIP)

2024-05-06 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21388 ) Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size (WIP) .. IMPALA-12867: Filter files to OPTIMIZE based on

[Impala-ASF-CR] IMPALA-12867: Filter files to OPTIMIZE based on file size (WIP)

2024-05-02 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21388 Change subject: IMPALA-12867: Filter files to OPTIMIZE based on file size (WIP) .. IMPALA-12867: Filter files to OPTIMIZE based on

[Impala-ASF-CR] IMPALA-13000: Document OPTIMIZE TABLE

2024-04-22 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21320 ) Change subject: IMPALA-13000: Document OPTIMIZE TABLE .. IMPALA-13000: Document OPTIMIZE TABLE Document OPTIMIZE TABLE syntax and

[Impala-ASF-CR] IMPALA-13000: Document OPTIMIZE TABLE

2024-04-18 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21320 ) Change subject: IMPALA-13000: Document OPTIMIZE TABLE .. IMPALA-13000: Document OPTIMIZE TABLE Document OPTIMIZE TABLE syntax and

[Impala-ASF-CR] IMPALA-13000: Document OPTIMIZE TABLE

2024-04-17 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21320 Change subject: IMPALA-13000: Document OPTIMIZE TABLE .. IMPALA-13000: Document OPTIMIZE TABLE Document OPTIMIZE TABLE syntax and

[Impala-ASF-CR] IMPALA-13006: Restrict Iceberg tables to Parquet

2024-04-16 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21306 Change subject: IMPALA-13006: Restrict Iceberg tables to Parquet .. IMPALA-13006: Restrict Iceberg tables to Parquet Iceberg test

[Impala-ASF-CR] IMPALA-12809: Iceberg metadata table scanner should always be scheduled to the coordinator

2024-03-19 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21138 ) Change subject: IMPALA-12809: Iceberg metadata table scanner should always be scheduled to the coordinator .. Patch Set 2:

[Impala-ASF-CR] IMPALA-12809: Iceberg metadata table scanner can be scheduled to executors

2024-03-13 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21138 ) Change subject: IMPALA-12809: Iceberg metadata table scanner can be scheduled to executors .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-11 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. Patch Set 4: (1 comment) Thank you for the review! I

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-11 Thread Noemi Pap-Takacs (Code Review)
Hello Andrew Sherman, Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21083 to look at the new patch set (#4). Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-08 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-08 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

[Impala-ASF-CR] IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table

2024-03-06 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21105 ) Change subject: IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table .. Patch Set 3: Code-Review+1 Thanks,

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-03-06 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21083 ) Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

[Impala-ASF-CR] IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table

2024-03-06 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21105 ) Change subject: IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table .. Patch Set 2: (1 comment) Just a

[Impala-ASF-CR] IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table

2024-03-06 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21105 ) Change subject: IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table .. Patch Set 2: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table

2024-03-05 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21105 ) Change subject: IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-12717: Fix error message for missing table descriptor

2024-02-29 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21084 ) Change subject: IMPALA-12717: Fix error message for missing table descriptor .. IMPALA-12717: Fix error message for missing table

[Impala-ASF-CR] IMPALA-12412: Support partition evolution in OPTIMIZE statement

2024-02-29 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/20866 ) Change subject: IMPALA-12412: Support partition evolution in OPTIMIZE statement .. IMPALA-12412: Support partition evolution in

[Impala-ASF-CR] IMPALA-12717: Fix error message for missing table descriptor

2024-02-29 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21084 Change subject: IMPALA-12717: Fix error message for missing table descriptor .. IMPALA-12717: Fix error message for missing table

[Impala-ASF-CR] IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

2024-02-28 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21083 Change subject: IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax .. IMPALA-12774: [DOCS] Document ALTER TABLE SORT BY syntax

[Impala-ASF-CR] IMPALA-12412: Support partition evolution in OPTIMIZE statement

2024-02-28 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/20866 ) Change subject: IMPALA-12412: Support partition evolution in OPTIMIZE statement .. IMPALA-12412: Support partition evolution in

[Impala-ASF-CR] IMPALA-12412: Support partition evolution in OPTIMIZE statement

2024-02-27 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/20866 ) Change subject: IMPALA-12412: Support partition evolution in OPTIMIZE statement .. IMPALA-12412: Support partition evolution in

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-02-20 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21026 ) Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. Patch Set 5: (1

[Impala-ASF-CR] IMPALA-12412: Support partition evolution in OPTIMIZE statement

2024-02-07 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20866 Change subject: IMPALA-12412: Support partition evolution in OPTIMIZE statement .. IMPALA-12412: Support partition evolution in

[Impala-ASF-CR] IMPALA-12742: (Addendum) add interop tests for DATE-partitioned Iceberg tables

2024-01-31 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20976 ) Change subject: IMPALA-12742: (Addendum) add interop tests for DATE-partitioned Iceberg tables .. Patch Set 1: Code-Review+1

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-18 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20903 ) Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables .. Patch Set 2: Code-Review+1 Thank you! --

[Impala-ASF-CR] IMPALA-11710: Table properties are not updated in Iceberg metadata files

2024-01-17 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20907 ) Change subject: IMPALA-11710: Table properties are not updated in Iceberg metadata files .. Patch Set 2: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables

2024-01-17 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20903 ) Change subject: IMPALA-12708: An UPDATE creates 2 new snapshots in Iceberg tables .. Patch Set 1: (1 comment) Thanks for the fix

[Impala-ASF-CR] IMPALA-11710: Table properties are not updated in Iceberg metadata files

2024-01-17 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20907 ) Change subject: IMPALA-11710: Table properties are not updated in Iceberg metadata files .. Patch Set 1: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-12658: UPDATE Iceberg table FROM view throws IllegalStateException

2024-01-02 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20825 ) Change subject: IMPALA-12658: UPDATE Iceberg table FROM view throws IllegalStateException .. Patch Set 1: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-21 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20818 ) Change subject: IMPALA-12653: Update documentation about the UPDATE statement .. Patch Set 6: Code-Review+1 Thank you. It looks

[Impala-ASF-CR] IMPALA-12653: Update documentation about the UPDATE statement

2023-12-19 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20818 ) Change subject: IMPALA-12653: Update documentation about the UPDATE statement .. Patch Set 2: (2 comments) Nice and clear.

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 10: Code-Review+1 Thanks, LGTM --

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties

2023-11-15 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20676 ) Change subject: IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties .. Patch Set 2: Code-Review+1 Thanks,

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-11-13 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 1: (1 comment) I could not read it

[Impala-ASF-CR] IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties

2023-11-10 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20676 ) Change subject: IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties .. Patch Set 1: (2 comments) I noticed

[Impala-ASF-CR] IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency

2023-10-20 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20604 Change subject: IMPALA-12481: Fix sorted-run-merger-ir.cc make dependency .. IMPALA-12481: Fix sorted-run-merger-ir.cc make

[Impala-ASF-CR] IMPALA-12478: Invalid length in StringValue::LeastSmallerString()

2023-10-17 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20579 ) Change subject: IMPALA-12478: Invalid length in StringValue::LeastSmallerString() .. Patch Set 1: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-10-02 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 10: (1 comment) Could you help me and explain the

[Impala-ASF-CR] IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes

2023-09-26 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20460 ) Change subject: IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes .. Patch Set 4: Code-Review+1

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-26 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 3: Code-Review+1 I agree with your solution. Thank

[Impala-ASF-CR] IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes

2023-09-25 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20460 ) Change subject: IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes .. Patch Set 3: Code-Review+1

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-25 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 2: (2 comments) Nice refactoring, thank you! There

[Impala-ASF-CR] IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE

2023-09-25 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/20405 ) Change subject: IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE .. IMPALA-12406: OPTIMIZE statement as an alias

[Impala-ASF-CR] IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE

2023-09-24 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20405 ) Change subject: IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE

2023-09-20 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/20405 ) Change subject: IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE .. IMPALA-12406: OPTIMIZE statement as an alias

[Impala-ASF-CR] IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE

2023-09-20 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20405 ) Change subject: IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE

2023-09-11 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20405 ) Change subject: IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE .. IMPALA-12406: OPTIMIZE statement as an alias

[Impala-ASF-CR] IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE

2023-08-28 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20405 Change subject: IMPALA-12406: OPTIMIZE statement as an alias for INSERT OVERWRITE .. IMPALA-12406: OPTIMIZE statement as an alias

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-23 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-12342: Erasure coding build fails on loading iceberg lineitem multiblock

2023-08-18 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20359 ) Change subject: IMPALA-12342: Erasure coding build fails on loading iceberg_lineitem_multiblock .. Patch Set 1: Code-Review+1

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

2023-06-21 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 ) Change subject: IMPALA-11949: Make backend AVRO C++ library available .. Patch Set 2: Code-Review+1 (1 comment) Thank you for the

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#27). ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. IMPALA-4530: Implement in-memory merge of quicksorted

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-07 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#25). ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. IMPALA-4530: Implement in-memory merge of quicksorted

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-06-06 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#24). ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. IMPALA-4530: Implement in-memory merge of quicksorted

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-05-09 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#22). ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. IMPALA-4530: Implement in-memory merge of quicksorted

[Impala-ASF-CR] IMPALA-4530: Implement in-memory merge of quicksorted runs

2023-05-05 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/18393 ) Change subject: IMPALA-4530: Implement in-memory merge of quicksorted runs .. IMPALA-4530: Implement in-memory merge of quicksorted

[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables

2023-04-12 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19680 ) Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables

2023-04-12 Thread Noemi Pap-Takacs (Code Review)
Hello Daniel Becker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19680 to look at the new patch set (#2). Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables

[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables

2023-04-03 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19680 Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables .. IMPALA-11878: Document that AVRO

[Impala-ASF-CR] IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK functionality

2023-03-21 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19606 ) Change subject: IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK functionality .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK functionality

2023-03-17 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19606 ) Change subject: IMPALA-11596: [DOCS] Document EXECUTE ROLLBACK functionality .. Patch Set 1: (1 comment) Thank you for fixing the

[Impala-ASF-CR] IMPALA-11983: Update stale comments in sorter.h referencing Init()

2023-03-08 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19599 ) Change subject: IMPALA-11983: Update stale comments in sorter.h referencing Init() .. Patch Set 1: Code-Review+1 Nice catch,

[Impala-ASF-CR] IMPALA-11477: Adding Codegen to sorted-run-merger

2023-03-01 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/18824 ) Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger .. IMPALA-11477: Adding Codegen to sorted-run-merger

[Impala-ASF-CR] IMPALA-11477: Adding Codegen to sorted-run-merger

2023-02-28 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/18824 ) Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger .. IMPALA-11477: Adding Codegen to sorted-run-merger

[Impala-ASF-CR] IMPALA-11477: Adding Codegen to sorted-run-merger

2023-02-23 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/18824 ) Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger .. IMPALA-11477: Adding Codegen to sorted-run-merger

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

2023-02-10 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 ) Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-11834: Error reporting addendum

2023-02-08 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19481 ) Change subject: IMPALA-11834: Error reporting addendum .. Patch Set 2: Code-Review+1 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-30 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 3: Code-Review+1

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 2: Code-Review+1

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-27 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19441 ) Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11807: Rewrite iceberg metadata if not on hdfs

2023-01-19 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19432 ) Change subject: IMPALA-11807: Rewrite iceberg metadata if not on hdfs .. Patch Set 1: Code-Review+1 Thanks for the fix! -- To

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-17 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 12:

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length and absolute paths in case of metadata rewrite

2023-01-16 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length and absolute paths in case of metadata rewrite .. Patch Set 7: (3

[Impala-ASF-CR] IMPALA-11821: Adjusting manifest length in case of metadata rewrite

2023-01-15 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19412 ) Change subject: IMPALA-11821: Adjusting manifest_length in case of metadata rewrite .. Patch Set 2: (2 comments) Looks nice. I

[Impala-ASF-CR] IMPALA-11620: Enable setting 'write.format.default'

2023-01-09 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19221 ) Change subject: IMPALA-11620: Enable setting 'write.format.default' .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-11620: Enable setting 'write.format.default'

2023-01-09 Thread Noemi Pap-Takacs (Code Review)
Hello Tamas Mate, Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19221 to look at the new patch set (#4). Change subject: IMPALA-11620: Enable setting 'write.format.default'

[Impala-ASF-CR] IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information

2023-01-09 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19396 ) Change subject: IMPALA-11819: [DOCS] Add Iceberg LOAD DATA information .. Patch Set 2: Code-Review+1 Nice and clear, LGTM! -- To

[Impala-ASF-CR] IMPALA-11620: Enable setting 'write.format.default'

2023-01-04 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19221 Change subject: IMPALA-11620: Enable setting 'write.format.default' .. IMPALA-11620: Enable setting 'write.format.default' Enable

[Impala-ASF-CR] IMPALA-11807: Fix TestIcebergTable.test avro file format and test mixed file format

2022-12-22 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19387 ) Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and test_mixed_file_format .. IMPALA-11807: Fix

[Impala-ASF-CR] IMPALA-11807: Fix TestIcebergTable.test avro file format and test mixed file format

2022-12-22 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19387 ) Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and test_mixed_file_format .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11807: Fix TestIcebergTable.test avro file format and test mixed file format

2022-12-22 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19387 ) Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and test_mixed_file_format .. IMPALA-11807: Fix

[Impala-ASF-CR] IMPALA-11807: Fix TestIcebergTable.test avro file format and test mixed file format

2022-12-21 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19387 ) Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and test_mixed_file_format .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11807: Fix TestIcebergTable.test avro file format and test mixed file format

2022-12-21 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19387 ) Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and test_mixed_file_format .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test

2022-12-21 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 ) Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test .. Patch Set 1: Code-Review+1 (1 comment) Nice, LGTM

[Impala-ASF-CR] IMPALA-11807: Fix TestIcebergTable.test avro file format and test mixed file format

2022-12-21 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19387 Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and test_mixed_file_format .. IMPALA-11807: Fix

[Impala-ASF-CR] IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format

2022-12-15 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19353 ) Change subject: IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format

2022-12-14 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19353 ) Change subject: IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format .. IMPALA-11708: Add support for mixed

[Impala-ASF-CR] IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format

2022-12-13 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19353 Change subject: IMPALA-11708: Add support for mixed Iceberg tables with AVRO file format .. IMPALA-11708: Add support for mixed

[Impala-ASF-CR] IMPALA-11158: Add support for Iceberg tables with AVRO data files

2022-12-07 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/19084 ) Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files .. IMPALA-11158: Add support for Iceberg tables

[Impala-ASF-CR] IMPALA-11158: Add support for Iceberg tables with AVRO data files

2022-12-05 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/19084 ) Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files .. IMPALA-11158: Add support for Iceberg tables

[Impala-ASF-CR] IMPALA-11158: Add support for Iceberg tables with AVRO data files

2022-11-24 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19084 ) Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-11158: Add support for Iceberg tables with AVRO data files

2022-11-23 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19084 ) Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files .. IMPALA-11158: Add support for Iceberg tables

[Impala-ASF-CR] IMPALA-11158: Add support for Iceberg tables with AVRO data files

2022-11-07 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19084 Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files .. IMPALA-11158: Add support for Iceberg tables

[Impala-ASF-CR] IMPALA-11477: Adding Codegen to sorted-run-merger

2022-10-13 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/18824 ) Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger .. IMPALA-11477: Adding Codegen to sorted-run-merger

[Impala-ASF-CR] IMPALA-11477: Adding Codegen to sorted-run-merger

2022-10-07 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/18824 ) Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger .. IMPALA-11477: Adding Codegen to sorted-run-merger

[Impala-ASF-CR] IMPALA-11477: Adding Codegen to sorted-run-merger

2022-09-15 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18824 ) Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger .. IMPALA-11477: Adding Codegen to sorted-run-merger

  1   2   >