[Impala-ASF-CR] IMPALA-12630: Deflake TestOrcStats.test orc stats

2023-12-20 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20794 ) Change subject: IMPALA-12630: Deflake TestOrcStats.test_orc_stats .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

2023-09-15 Thread Norbert Luksa (Code Review)
Norbert Luksa has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20421 ) Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user ...

[Impala-ASF-CR] IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

2023-09-15 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20421 ) Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user .. Pat

[Impala-ASF-CR] IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user

2023-09-14 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20421 ) Change subject: IMPALA-12403: Fix Kerberos authentication when connecting with a proxy user that does not delegate another user .. Pat

[Impala-ASF-CR] IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types

2023-03-10 Thread Norbert Luksa (Code Review)
Norbert Luksa has abandoned this change. ( http://gerrit.cloudera.org:8080/15152 ) Change subject: IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types .. Abandoned -- To view, visit http:/

[Impala-ASF-CR] IMPALA-10233: zorder sort node should output rows in lexical order of partition keys

2020-10-14 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/16590 ) Change subject: IMPALA-10233: zorder sort node should output rows in lexical order of partition keys .. Patch Set 2: (1 comment) htt

[Impala-ASF-CR] IMPALA-10233: zorder sort node should output rows in lexical order of partition keys

2020-10-14 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/16590 ) Change subject: IMPALA-10233: zorder sort node should output rows in lexical order of partition keys .. Patch Set 2: Code-Review+2 LG

[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default

2020-06-24 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 ) Change subject: IMPALA-8755: Unlock Z-ordering by default .. Patch Set 4: Sorry, didn't notice your comment, Zoltán. Will move the fla

[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default

2020-06-02 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16003 Change subject: IMPALA-8755: Unlock Z-ordering by default .. IMPALA-8755: Unlock Z-ordering by default Z-ordering has been around for a

[Impala-ASF-CR] IMPALA-9625: Convert the name of a TAccessEvent to lowercase

2020-04-14 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15689 ) Change subject: IMPALA-9625: Convert the name of a TAccessEvent to lowercase .. Patch Set 6: Hi Fang-Yu, thanks for restarting the ver

[Impala-ASF-CR] IMPALA-9625: Convert the name of a TAccessEvent to lowercase

2020-04-10 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15689 ) Change subject: IMPALA-9625: Convert the name of a TAccessEvent to lowercase .. Patch Set 4: Code-Review+2 (1 comment) Thanks Fang-Yu

[Impala-ASF-CR] IMPALA-9625: Convert fully-qualified table name to lowercase in getTable()

2020-04-09 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15689 ) Change subject: IMPALA-9625: Convert fully-qualified table name to lowercase in getTable() .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-9042: Milestone 1: properly scan files that has full ACID schema

2020-03-18 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15395 ) Change subject: IMPALA-9042: Milestone 1: properly scan files that has full ACID schema .. Patch Set 3: (6 comments) Thanks for work

[Impala-ASF-CR] IMPALA-6360: Don't show full query statement on Impala WebUI by default

2020-03-18 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15288 ) Change subject: IMPALA-6360: Don't show full query statement on Impala WebUI by default .. Patch Set 15: Code-Review+1 (1 comment) F

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-17 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 1: (6 comments) Thanks Quanlong and Csaba for re

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-17 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. IMPALA-6505: Min-Max predicate push down in ORC scanner This

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-11 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 1: The build should fail since we do not have the

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-11 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15403 Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. IMPALA-6505: Min-Max predicate push down in ORC scanner This

[Impala-ASF-CR] IMPALA-6360: Don't show full query statement on Impala WebUI by default

2020-03-05 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15288 ) Change subject: IMPALA-6360: Don't show full query statement on Impala WebUI by default .. Patch Set 12: Code-Review+1 (1 comment) H

[Impala-ASF-CR] IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a Config object

2020-03-05 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15281 ) Change subject: IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a Config object .. Patch Set 5: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash

2020-03-03 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15347 Change subject: IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash .. IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-02-28 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 29: Thanks Zoltan, included the header. -- To view, visit h

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-02-28 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#29). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-02-27 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 14: (2 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-02-27 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. IMPALA-9226: Improve string allocations of the ORC scanner

[Impala-ASF-CR] IMPALA-9226: Bump ORC version to 1.6.2-p7

2020-02-25 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15287 Change subject: IMPALA-9226: Bump ORC version to 1.6.2-p7 .. IMPALA-9226: Bump ORC version to 1.6.2-p7 Bump ORC version to include patc

[native-toolchain-CR] IMPALA-9226: Add patch to ORC-1.6.2 in the toolchain

2020-02-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15265 Change subject: IMPALA-9226: Add patch to ORC-1.6.2 in the toolchain .. IMPALA-9226: Add patch to ORC-1.6.2 in the toolchain This commi

[Impala-ASF-CR] IMPALA-9351: Change path in TestCreateTableLikeFileOrc

2020-02-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15266 Change subject: IMPALA-9351: Change path in TestCreateTableLikeFileOrc .. IMPALA-9351: Change path in TestCreateTableLikeFileOrc There

[Impala-ASF-CR] IMPALA-9385: Unix time conversion cleanup + ORC fix

2020-02-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15222 ) Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-9385: Unix time conversion cleanup + ORC fix

2020-02-20 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15222 ) Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix .. Patch Set 11: Code-Review+1 (3 comments) Left some comments, o

[Impala-ASF-CR] IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types

2020-02-18 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15152 ) Change subject: IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types .. Patch Set 3: Regarding C

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-02-18 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 26: The verification failed due to a the flaky test_exchange_

[Impala-ASF-CR] Add log of created files for data load

2020-02-17 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15234 Change subject: Add log of created files for data load .. Add log of created files for data load As Joe pointed out in IMPALA-9351, it

[Impala-ASF-CR] WIP: IMPALA-9385: Fix Orc scanner's TimestampValue conversion

2020-02-17 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15222 ) Change subject: WIP: IMPALA-9385: Fix Orc scanner's TimestampValue conversion .. Patch Set 2: (5 comments) Hi, left some minor commen

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-02-14 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 26: The verification failed because the AllTypeTest added too

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-14 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. Patch Set 1: (3 comments) Hi, left some comme

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-02-14 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#25). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-6663: Expose current DDL metrics on WebUI

2020-02-13 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/13806 ) Change subject: IMPALA-6663: Expose current DDL metrics on WebUI .. Patch Set 13: Code-Review+1 (2 comments) Left a small nit, but lg

[Impala-ASF-CR] IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types

2020-02-04 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15152 ) Change subject: IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types .. IMPALA-9290: ORC scanner sh

[Impala-ASF-CR] IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types

2020-02-04 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15152 ) Change subject: IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types .. Patch Set 3: (6 comments

[Impala-ASF-CR] IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types

2020-02-03 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15152 ) Change subject: IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types .. Patch Set 2: (5 comments

[Impala-ASF-CR] IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types

2020-02-03 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15152 ) Change subject: IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types .. IMPALA-9290: ORC scanner sh

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-02-03 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#22). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-02-03 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. IMPALA-9226: Improve string allocations of the ORC scanner

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-02-03 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types

2020-02-03 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15152 Change subject: IMPALA-9290: ORC scanner should support schema evolution between date and timestamp types .. IMPALA-9290: ORC scanner s

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-30 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-30 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. IMPALA-9226: Improve string allocations of the ORC scanner

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-30 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#21). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-30 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 21: (6 comments) http://gerrit.cloudera.org:8080/#/c/14080/2

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-30 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-30 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 6: (5 comments) Thank you all for taking a lo

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-30 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. IMPALA-9226: Improve string allocations of the ORC scanner

[Impala-ASF-CR] IMPALA-9324: Correctly handle ORC UNION type in scanner

2020-01-27 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15103 ) Change subject: IMPALA-9324: Correctly handle ORC UNION type in scanner .. Patch Set 5: Code-Review+1 (2 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-24 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9324: Correctly handle ORC UNION type in scanner

2020-01-24 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15103 ) Change subject: IMPALA-9324: Correctly handle ORC UNION type in scanner .. Patch Set 1: Code-Review+1 (3 comments) Left some minor co

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-24 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 4: Rebased. -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-24 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. IMPALA-9226: Improve string allocations of the ORC scanner

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-22 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-22 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 20: (5 comments) http://gerrit.cloudera.org:8080/#/c/14080/1

[Impala-ASF-CR] IMPALA-9291: MemTracker's TryConsume() should behave consistent with Consume()/Release()

2020-01-22 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15050 ) Change subject: IMPALA-9291: MemTracker's TryConsume() should behave consistent with Consume()/Release() .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-9291: MemTracker's TryConsume() should behave consistent with Consume()/Release()

2020-01-22 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15050 ) Change subject: IMPALA-9291: MemTracker's TryConsume() should behave consistent with Consume()/Release() .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. IMPALA-9226: Improve string allocations of the ORC scanner

[native-toolchain-CR] IMPALA-6772: Add ORC 1.6.2 to toolchain

2020-01-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15073 ) Change subject: IMPALA-6772: Add ORC 1.6.2 to toolchain .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15073/3/build

[native-toolchain-CR] IMPALA-6772: Add ORC 1.6.2 to toolchain

2020-01-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15073 ) Change subject: IMPALA-6772: Add ORC 1.6.2 to toolchain .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15073/3/build

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/14080/1

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-01-21 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 16: Rebased. -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-17 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. Patch Set 2: As Zoltán suggested, I tried to add an opti

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-17 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15051 Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. WIP: IMPALA-9226: Improve string allocations of the ORC sc

[Impala-ASF-CR] IMPALA-9226: Improve string allocations of the ORC scanner

2020-01-17 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15051 ) Change subject: IMPALA-9226: Improve string allocations of the ORC scanner .. IMPALA-9226: Improve string allocations of the ORC scanner

[Impala-ASF-CR] IMPALA-8801: Date type support for ORC scanner

2020-01-17 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14982 ) Change subject: IMPALA-8801: Date type support for ORC scanner .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9291: MemTracker's TryConsume() should behave consistent with Consume()/Release()

2020-01-16 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15050 ) Change subject: IMPALA-9291: MemTracker's TryConsume() should behave consistent with Consume()/Release() .. Patch Set 1: Code-Review+1

[Impala-ASF-CR] IMPALA-8046: Support CREATE TABLE from an ORC file

2020-01-10 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14811 ) Change subject: IMPALA-8046: Support CREATE TABLE from an ORC file .. Patch Set 11: Rebased. -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8046: Support CREATE TABLE from an ORC file

2020-01-10 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/14811 ) Change subject: IMPALA-8046: Support CREATE TABLE from an ORC file .. IMPALA-8046: Support CREATE TABLE from an ORC file Impala support

[Impala-ASF-CR] IMPALA-9277: Catch exception thrown from orc::ColumnSelector::updateSelectedByTypeId

2020-01-09 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14994 ) Change subject: IMPALA-9277: Catch exception thrown from orc::ColumnSelector::updateSelectedByTypeId .. Patch Set 1: Code-Review+1 Lg

[Impala-ASF-CR] [WIP]IMPALA-8778: Support Apache Hudi Read Optimized Table

2020-01-09 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: [WIP]IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 7: (3 comments) Hi! Thanks for working on thi

[Impala-ASF-CR] IMPALA-8801: Date type support for ORC scanner

2020-01-08 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14982 ) Change subject: IMPALA-8801: Date type support for ORC scanner .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-07 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 2: Code-Review+1 (4 comments) That seems a lot of work, nice job

[Impala-ASF-CR] IMPALA-8801: Date type support for ORC scanner

2020-01-07 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14982 ) Change subject: IMPALA-8801: Date type support for ORC scanner .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/14982

[Impala-ASF-CR] IMPALA-8046: Support CREATE TABLE from an ORC file

2019-12-20 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14811 ) Change subject: IMPALA-8046: Support CREATE TABLE from an ORC file .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-8046: Support CREATE TABLE from an ORC file

2019-12-20 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/14811 ) Change subject: IMPALA-8046: Support CREATE TABLE from an ORC file .. IMPALA-8046: Support CREATE TABLE from an ORC file Impala support

[Impala-ASF-CR] Fix bug in report benchmark results.py

2019-12-19 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14925 ) Change subject: Fix bug in report_benchmark_results.py .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2019-12-12 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2019-12-12 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/14080/9/

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2019-12-12 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. IMPALA-8755: Backend support for Z-ordering This change depends on gerri

[Impala-ASF-CR] IMPALA-9207: [DOCS] Documented the #Inst in exec summary

2019-12-08 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14860 ) Change subject: IMPALA-9207: [DOCS] Documented the #Inst in exec summary .. Patch Set 2: Code-Review+1 (2 comments) Found some more n

[Impala-ASF-CR] IMPALA-9207: [DOCS] Documented the #Inst in exec summary

2019-12-06 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14860 ) Change subject: IMPALA-9207: [DOCS] Documented the #Inst in exec summary .. Patch Set 1: (2 comments) Found a few more occurrences of

[Impala-ASF-CR] IMPALA-8046: Support CREATE TABLE from an ORC file

2019-12-05 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14811 ) Change subject: IMPALA-8046: Support CREATE TABLE from an ORC file .. Patch Set 8: (16 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-8046: Support CREATE TABLE from an ORC file

2019-12-05 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/14811 ) Change subject: IMPALA-8046: Support CREATE TABLE from an ORC file .. IMPALA-8046: Support CREATE TABLE from an ORC file Impala supports

[Impala-ASF-CR] IMPALA-9217: Adjust limits for TZH and TZM datetime tokens

2019-12-05 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14848 ) Change subject: IMPALA-9217: Adjust limits for TZH and TZM datetime tokens .. Patch Set 1: Code-Review+1 Had a look at other tests in

[Impala-ASF-CR] IMPALA-8184: Add timestamp validation to Orc scanner

2019-12-05 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14832 ) Change subject: IMPALA-8184: Add timestamp validation to Orc scanner .. Patch Set 2: Code-Review+1 (4 comments) Found some nits, othe

[Impala-ASF-CR] IMPALA-9215: report benchmark results.py fails with missing key

2019-12-05 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14830 ) Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key .. Patch Set 1: Code-Review+1 -- To view, visit http:

[Impala-ASF-CR] WIP: IMPALA-8046: Support CREATE TABLE from an ORC file

2019-11-29 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/14811 ) Change subject: WIP: IMPALA-8046: Support CREATE TABLE from an ORC file .. WIP: IMPALA-8046: Support CREATE TABLE from an ORC file Impal

[Impala-ASF-CR] WIP: IMPALA-8046: Support CREATE TABLE from an ORC file

2019-11-29 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14811 ) Change subject: WIP: IMPALA-8046: Support CREATE TABLE from an ORC file .. WIP: IMPALA-8046: Support CREATE TABLE from an ORC file Impal

[Impala-ASF-CR] WIP: IMPALA-8046: Support CREATE TABLE from an ORC file

2019-11-29 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14811 ) Change subject: WIP: IMPALA-8046: Support CREATE TABLE from an ORC file .. IMPALA-8046: Support CREATE TABLE from an ORC file Impala sup

[Impala-ASF-CR] WIP: IMPALA-8046: Support CREATE TABLE from an ORC file

2019-11-29 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14811 ) Change subject: WIP: IMPALA-8046: Support CREATE TABLE from an ORC file .. WIP: IMPALA-8046: Support CREATE TABLE from an ORC file Impal

[Impala-ASF-CR] IMPALA-8046: Support CREATE TABLE from an ORC file

2019-11-29 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14811 ) Change subject: IMPALA-8046: Support CREATE TABLE from an ORC file .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/1

  1   2   >