[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-26 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-5164: Fix flaky benchmarks .. IMPALA-5164: Fix flaky benchmarks Improve benchmarks by detecting involuntary context switches. If a server is heavily loaded

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5164: Fix flaky benchmarks .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6935/2/be/src/util/benchmark.cc File be/src/util/benchmark.cc:

[Impala-ASF-CR] IMPALA-4864 Speed up single slot predicates with dictionaries

2017-05-24 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries .. IMPALA-4864 Speed up single slot predicates with dictionaries When dictionaries are present we can

[Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function

2017-05-24 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5326: [DOCS] Document REPLACE() function .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6979/1/docs/topics/impala_string_functions.xml

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-22 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-5164: Fix flaky benchmarks .. IMPALA-5164: Fix flaky benchmarks Improve benchmarks by detecting involuntary context switches. If a server is heavily loaded

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5164: Fix flaky benchmarks .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6935/2/be/src/util/benchmark.cc File be/src/util/benchmark.cc:

[Impala-ASF-CR] IMPALA-4864 Speed up single slot predicates with dictionaries

2017-05-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries .. Patch Set 7: (17 comments) Thanks for looking at this!

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5164: Fix flaky benchmarks .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/6935/2/be/src/util/benchmark.cc File be/src/util/benchmark.cc:

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-20 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5164: Fix flaky benchmarks .. IMPALA-5164: Fix flaky benchmarks Improve benchmarks by detecting involuntary context switches. If a server is heavily loaded

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-19 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5164: Fix flaky benchmarks .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6935/1/be/src/benchmarks/free-lists-benchmark.cc File

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-19 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6935 Change subject: IMPALA-5164: Fix flaky benchmarks .. IMPALA-5164: Fix flaky benchmarks Improve benchmarks by detecting involuntary

[Impala-ASF-CR] IMPALA-4864 Speed up single slot predicates with dictionaries

2017-05-18 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries .. IMPALA-4864 Speed up single slot predicates with dictionaries When dictionaries are present we can

[Impala-ASF-CR] IMPALA-4864 Speed up single slot predicates with dictionaries

2017-05-18 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#6). Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries .. IMPALA-4864 Speed up single slot predicates with dictionaries When dictionaries are present we can

[Impala-ASF-CR] IMPALA-5180: Don't use non-deterministic exprs in partition pruning

2017-05-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5180: Don't use non-deterministic exprs in partition pruning .. Patch Set 12: Rebased and ran planner test

[Impala-ASF-CR] IMPALA-5127: Add history max option

2017-05-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5127: Add history_max option .. Patch Set 5: Also, ran shell tests just for completeness: impala@impala-dev:~/Impala$ tests/run-tests.py shell

[Impala-ASF-CR] IMPALA-5319: Fix error results.

2017-05-15 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. Change subject: IMPALA-5319: Fix error results. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

[Impala-ASF-CR] IMPALA-5319: Fix error results.

2017-05-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5319: Fix error results. .. Patch Set 1: I miscounted columns and thought the suspect change made column 10 into a timestamp column, in which case the

[Impala-ASF-CR] IMPALA-5319: Fix error results.

2017-05-15 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6890 Change subject: IMPALA-5319: Fix error results. .. IMPALA-5319: Fix error results. Since changing the underlying type in the column, this

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-11 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Patch Set 8: (3 comments) Thanks for taking a look!

[Impala-ASF-CR] IMPALA-5159: Optimze predicates [DRAFT]

2017-05-11 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. Change subject: IMPALA-5159: Optimze predicates [DRAFT] .. Abandoned Shelving this for now. Let's work on more important tasks and come back to inequality propagation in cases where we

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5821/8/be/src/util/bit-util.h File

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-04 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-5266 Impala ABM / LZCNT support .. IMPALA-5266 Impala ABM / LZCNT support I recently added some code that wants to do upwards power of 2 calculation. Turns

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-04 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-5266 Impala ABM / LZCNT support .. IMPALA-5266 Impala ABM / LZCNT support I recently added some code that wants to do upwards power of 2 calculation. Turns

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Patch Set 6: Updated perf results; these are as good as I could get. I removed some various 8 / 16 / 32 bit pieces

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-04 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#6). Change subject: IMPALA-5266 Impala ABM / LZCNT support .. IMPALA-5266 Impala ABM / LZCNT support I recently added some code that wants to do upwards power of 2 calculation. Turns

[Impala-ASF-CR] IMPALA-4864 Speed up single slot predicates with dictionaries

2017-05-02 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries .. IMPALA-4864 Speed up single slot predicates with dictionaries When dictionaries are present we can

[Impala-ASF-CR] IMPALA-5180: Don't use non-deterministic exprs in partition pruning

2017-05-02 Thread Zach Amsden (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6575 to look at the new patch set (#10). Change subject: IMPALA-5180: Don't use non-deterministic exprs in partition pruning

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/5/be/src/util/bit-util.h File be/src/util/bit-util.h:

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/5/be/src/util/bit-util.h File be/src/util/bit-util.h:

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/5/be/src/util/bit-util.h File be/src/util/bit-util.h:

[Impala-ASF-CR] IMPALA-5180: Don't use non-deterministic exprs in partition pruning

2017-05-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5180: Don't use non-deterministic exprs in partition pruning .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support

2017-05-01 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-5266 Impala ABM / LZCNT support .. IMPALA-5266 Impala ABM / LZCNT support I recently added some code that wants to do upwards power of 2 calculation. Turns

[Impala-ASF-CR] Impala ABM / LZCNT support

2017-05-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: Impala ABM / LZCNT support .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/3//COMMIT_MSG Commit Message: Line 7: Impala ABM / LZCNT support

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-05-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. Patch Set 21: Got a green light test run for this:

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-04-28 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Abandoned Not doing at this time. -- To view, visit http://gerrit.cloudera.org:8080/6261 To

[Impala-ASF-CR] IMPALA-5180: Don't use non-deterministic exprs in partition pruning

2017-04-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-5180: Don't use non-deterministic exprs in partition pruning .. IMPALA-5180: Don't use non-deterministic exprs in partition pruning Non-deterministic exprs

[Impala-ASF-CR] IMPALA-5180: Don't use non-deterministic exprs in partition pruning

2017-04-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-5180: Don't use non-deterministic exprs in partition pruning .. IMPALA-5180: Don't use non-deterministic exprs in partition pruning Non-deterministic exprs

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-27 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. Patch Set 25: Got some test failures attributed to databases that do no exist - I think I need to reload

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread Zach Amsden (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6389 to look at the new patch set (#25). Change subject: IMPALA-5003: Constant propagation in scan conjuncts

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. Patch Set 23: So this tripped up on an functional.alltypes_datasource test, and the first failure was

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-26 Thread Zach Amsden (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6389 to look at the new patch set (#23). Change subject: IMPALA-5003: Constant propagation in scan conjuncts

[Impala-ASF-CR] IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries

2017-04-26 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries .. IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries When dictionaries

[Impala-ASF-CR] IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries

2017-04-25 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries .. IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries When dictionaries

[Impala-ASF-CR] IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries

2017-04-25 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6726 Change subject: IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries .. IMPALA-4864 [DRAFT] Speed up single slot

[Impala-ASF-CR] IMPALA-5180: Don't use non-deterministic exprs in partition pruning

2017-04-18 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#6). Change subject: IMPALA-5180: Don't use non-deterministic exprs in partition pruning .. IMPALA-5180: Don't use non-deterministic exprs in partition pruning Non-deterministic exprs

[Impala-ASF-CR] IMPALA-5180: Don't balk at non-deterministic exprs

2017-04-18 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-5180: Don't balk at non-deterministic exprs .. IMPALA-5180: Don't balk at non-deterministic exprs HDFS partition pruning can run afoul of our logic of

[Impala-ASF-CR] IMPALA-5180: Don't balk at non-deterministic exprs

2017-04-18 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5180: Don't balk at non-deterministic exprs .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-5159: Optimze predicates [DRAFT]

2017-04-17 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5159: Optimze predicates [DRAFT] .. IMPALA-5159: Optimze predicates [DRAFT] In addition to propagating constants, we can infer bounds on slotRefs which are

[Impala-ASF-CR] IMPALA-5159: Optimze predicates

2017-04-17 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5159: Optimze predicates .. Patch Set 1: So I don't think our JVM implementation likes calling .add and .remove on the same ListIterator, despite that

[Impala-ASF-CR] IMPALA-5159: Optimze predicates

2017-04-14 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6650 Change subject: IMPALA-5159: Optimze predicates .. IMPALA-5159: Optimze predicates In addition to propagating constants, we can infer

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-04-11 Thread Zach Amsden (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6261 to look at the new patch set (#14). Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

[Impala-ASF-CR] IMPALA-5127: Add history max option

2017-04-06 Thread Zach Amsden (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6335 to look at the new patch set (#4). Change subject: IMPALA-5127: Add history_max option .. IMPALA-5127: Add

[Impala-ASF-CR] IMPALA-5127: Add history max option

2017-04-06 Thread Zach Amsden (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6335 to look at the new patch set (#3). Change subject: IMPALA-5127: Add history_max option .. IMPALA-5127: Add

[Impala-ASF-CR] IMPALA-5127: Add history max option

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5127: Add history_max option .. Patch Set 2: (1 comment) I made this a bit more friendly and tolerant as well.

[Impala-ASF-CR] IMPALA-5180: Don't balk at non-deterministic exprs

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5180: Don't balk at non-deterministic exprs .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan conjuncts

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#19). Change subject: IMPALA-5003: Constant propagation in scan conjuncts .. IMPALA-5003: Constant propagation in scan conjuncts Implements constant proopagation within conjuncts and

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#18). Change subject: IMPALA-5003: Constant propagation in scan nodes .. IMPALA-5003: Constant propagation in scan nodes When conjuncts are pushed into table refs from inline views,

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-06 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#17). Change subject: IMPALA-5003: Constant propagation in scan nodes .. IMPALA-5003: Constant propagation in scan nodes When conjuncts are pushed into table refs from inline views,

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes .. Patch Set 16: (3 comments)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes .. Patch Set 16: (4 comments)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-05 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#16). Change subject: IMPALA-5003: Constant propagation in scan nodes .. IMPALA-5003: Constant propagation in scan nodes When conjuncts are pushed into table refs from inline views,

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes .. Patch Set 15: (12 comments)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes .. Patch Set 15: (5 comments)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes

2017-04-04 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#15). Change subject: IMPALA-5003: Constant propagation in scan nodes .. IMPALA-5003: Constant propagation in scan nodes When conjuncts are pushed into table refs from inline views,

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-04-04 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#14). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-04-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. Patch Set 13: (3 comments)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-04-04 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#13). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-04-03 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. Patch Set 11: (15 comments) Thanks for the review!

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-04-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#12). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-31 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-31 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#11). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-31 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-30 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#10). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views N.B. - preview diff again. I

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-30 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6261/11/shell/impala_shell.py

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-30 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 7: While I did forget to remove the std:: on vector, but I think enough effort has gone into

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Hello Bharath Vissapragada, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6503 to look at the new patch set (#6). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Hello Bharath Vissapragada, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6503 to look at the new patch set (#5). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 4: (2 comments) I also worked out another alternative - but then noticed the Open Group

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 4: I'll leave it up to the reviewers to decide which of 3/4 is cleanest. Maybe there is a C++11

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. IMPALA-5123: Fix ASAN use after free in timezone_db The issue is that the string temporary returned by

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 3: That turned out a little uglier than expected. I think a vector is going to be the cleanest.

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. IMPALA-5123: Fix ASAN use after free in timezone_db The issue is that the string temporary returned by

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6503/1/be/src/exprs/timezone_db.cc File

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. IMPALA-5123: Fix ASAN use after free in timezone_db The issue is that the string temporary returned by

[Impala-ASF-CR] IMPALA-5132: Fix ASAN use after free in timezone db

2017-03-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6503 Change subject: IMPALA-5132: Fix ASAN use after free in timezone_db .. IMPALA-5132: Fix ASAN use after free in timezone_db The issue is

[Impala-ASF-CR] IMPALA-5128: BE Test Infrastructure

2017-03-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5128: BE Test Infrastructure .. IMPALA-5128: BE Test Infrastructure Investigating a crash in backend exprs test and this test takes a long time to run. Lets

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-28 Thread Zach Amsden (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6261 to look at the new patch set (#10). Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6261/9//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5127: Add history max option

2017-03-28 Thread Zach Amsden (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6335 to look at the new patch set (#2). Change subject: IMPALA-5127: Add history_max option .. IMPALA-5127: Add

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] IMPALA-5003: Constant propagation in scan nodes and inline views

2017-03-20 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#6). Change subject: IMPALA-5003: Constant propagation in scan nodes and inline views .. IMPALA-5003: Constant propagation in scan nodes and inline views When conjuncts are pushed into

[Impala-ASF-CR] IMPALA-5003: Generic constant propagation in planner

2017-03-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Generic constant propagation in planner .. Patch Set 3: (12 comments) I'll post a WIP update to this diff as there was some refactoring that turned

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Yes, Michael, if you could start a build, that should unbreak S3 tests. :) -- To view, visit

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-20 Thread Zach Amsden (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6261 to look at the new patch set (#8). Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/6261/7//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Yes, updated diff attached. -- To view, visit http://gerrit.cloudera.org:8080/6408 To

<    1   2   3   4   >