[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 19: Code-Review+2 (9 comments) http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/analytic-ev

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-06-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7079/1/be/src/runtime/coordinator

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-06-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7079/1/be/src/runtime/coordinator

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-06-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7079/1/be/src/runtime/coordinator

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7081/2/be/src/exprs/u

[Impala-ASF-CR] IMPALA-5357: Fix unixtime to UTC TimestampValue perf

2017-06-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7082/1/be/src/runtime/tim

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 1: > The description in the JIRA asks for a redacted profile. I pinged > the

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

2017-06-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7077 To unsubscri

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 17: please fix the pervasive non-const vector& or switch to vector* and explain why it can get upd

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 17: (62 comments) http://gerrit.cloudera.org:8080/#/c/5483/16/be/src/exec/aggregation-node.cc File

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 1: Alex and I just discussed this: the simplest approach would be to refuse ac

[Impala-ASF-CR] IMPALA-5384: Simplify coordinator locking protocol

2017-06-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5384: Simplify coordinator locking protocol .. Patch Set 2: This passes the pre-commit tests. -- To view, visit http://gerrit.cloudera.org:8080/7065

[Impala-ASF-CR] IMPALA-5384: Simplify coordinator locking protocol

2017-06-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#2). Change subject: IMPALA-5384: Simplify coordinator locking protocol .. IMPALA-5384: Simplify coordinator locking protocol This changes the locking behavior of the coordinator in

[Impala-ASF-CR] IMPALA-5384: Simplify coordinator locking protocol

2017-06-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7065 Change subject: IMPALA-5384: Simplify coordinator locking protocol .. IMPALA-5384: Simplify coordinator locking protocol This changes

[Impala-ASF-CR] IMPALA-5381: Adds DEFAULT JOIN STRATEGY query option.

2017-06-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5381: Adds DEFAULT_JOIN_STRATEGY query option. .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7059/1/common/thrift/Impa

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-06-01 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6936/4/fe/src/main/java/

[Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS

2017-06-01 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7033 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS

2017-05-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7033/1/be/src/runtime/disk-io-mgr-scan-

[Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS

2017-05-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7033/1/be/src/runtime/disk-io-mgr-scan-

[Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS

2017-05-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS .. Patch Set 1: > (2 comments) > > > (2 comments) > > > > questions: > > - what about insert stagi

[Impala-ASF-CR] IMPALA-5378: Disk IO manager needs to understand ADLS

2017-05-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS .. Patch Set 1: (2 comments) questions: - what about insert staging for adls (in coordinator.cc? - what

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5164: Fix flaky benchmarks .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6935/5/be/src/benchmarks/free-lists-benchmark.cc File be/sr

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-05-31 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. Patch Set 2: (9 comments) could you also add tosql tests? http://gerrit.cloudera.org:8080/#/c/6936/

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-26 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. Patch Set 4: > (1 comment) > > I think there would be some benefit in having ReleaseResources()

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-26 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6897 To unsubscribe,

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-26 Thread Marcel Kornacker (Code Review)
Hello Henry Robinson, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6897 to look at the new patch set (#3). Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-26 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6897/2/be/src/runtime/coordinator.cc

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-26 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6840 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. Patch Set 2: > Will wait for final patch before signing off. > > What was the reason behind movi

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/6478/17/be/src/runtime/disk-io-mgr.h File be/src/runti

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 17: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6478/17/be/src/runtime/disk-io-mgr-scan-

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.h F

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#2). Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. IMPALA-4890/5143: Coordinator race involving TearDown() TearDown() releases resources and destroys co

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.cc

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. Patch Set 1: (1 comment) > (2 comments) > > Where does ReleaseResources() get called for DML qu

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/6478/15/be/src/runtime/disk-io-mgr-scan-range.cc File

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/6840/9/testdata/workloads/functional-pl

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-05-24 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6936/1//COMMIT_MSG Commit Message: Li

[Impala-ASF-CR] IMPALA-5347: Parquet scanner microoptimizations

2017-05-24 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6950 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-5347: Parquet scanner microoptimizations

2017-05-24 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6950/8/be/src/exec/hdfs-parquet-scanner.cc Fi

[Impala-ASF-CR] IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs.

2017-05-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6868 To unsubscribe

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/6478/11/be/src/runtime/disk-io-mgr-scan-range.cc File

[Impala-ASF-CR] IMPALA-5144: Remove sortby() hint

2017-05-21 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5144: Remove sortby() hint .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6885 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (BE)

2017-05-21 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (BE) .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6792 To unsubscri

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-21 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.cc

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-05-21 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6898/1/fe/src/main/java/org/apach

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-21 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/6478/8/be/src/runtime/disk-io-mgr-handle-cache.h File

[Impala-ASF-CR] IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs.

2017-05-21 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs. .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6868/4/fe/src/main/java/org/apache

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-16 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. Patch Set 1: This passed tests in both debug and release mode. I haven't run the stress test yet.

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-16 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new change for review. http://gerrit.cloudera.org:8080/6897 Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. IMPALA-4890/5143: Coordinator race involving TearDown() Te

[Impala-ASF-CR] IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs.

2017-05-16 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs. .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/6868/3/fe/src/main/java/org/apache

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 8: (16 comments) http://gerrit.cloudera.org:8080/#/c/6478/8/be/src/runtime/disk-io-mgr-handle-cache.h File

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6840/1/common/thrift/JniCatalog.thrift

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6789/3/fe/src/main/ja

[Impala-ASF-CR] IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs.

2017-05-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs. .. Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/6868/1/fe/src/main/java/org/apach

[Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL

2017-05-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6849/4/fe/src/test/

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created

2017-05-12 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/6792/5/be/src/runtime/exec-env.cc Fil

[Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL

2017-05-12 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6849/2/fe/src/main/java/org/apac

[Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL

2017-05-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL .. Patch Set 2: (2 comments) preliminary comments http://gerrit.cloudera.org:8080/#/c/6849/2//CO

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6789/3/fe/src/main/java/org/apache/

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 25: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/6495/22/fe/src/main/java/org/apache/impal

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 6: (6 comments) quick comments http://gerrit.cloudera.org:8080/#/c/6478/5/be/src/exec/hdfs-scan-node-base

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6812/1/testdata/workloads/functional-planner/que

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 22: (13 comments) http://gerrit.cloudera.org:8080/#/c/6495/22/common/thrift/JniCatalog.thrift File common/th

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created .. Patch Set 3: How about a rebase? -- To view, visit http://gerrit.cloudera.org:8080/6792 To unsubsc

[Impala-ASF-CR] IMPALA-5294: Kudu INSERT partitioning fails with constants

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6828/2/fe/src/main/j

[Impala-ASF-CR] IMPALA-5294: Kudu INSERT partitioning fails with constants

2017-05-09 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6828/1/fe/src/main/java/org/apach

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6812/1/testdata/workloads/functional-planner/que

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6526/7/be/src/ex

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/5483/9/be/src/exec/aggregation-node.cc File be

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 14: Code-Review+2 fixing some 'unused results' warnings. -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6535 to look at the new patch set (#14). Change subject: IMPALA-2550: Switch to per-query exec rpc ..

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 9: (45 comments) first half http://gerrit.cloudera.org:8080/#/c/5483/7/be/src/exec/exec-node.h Fi

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 13: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6535 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-08 Thread Marcel Kornacker (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6535 to look at the new patch set (#13). Change subject: IMPALA-2550: Switch to per-query exec rpc .. IMPALA-2550: Switch t

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/6478/4/be/src/runtime/disk-io-mgr.cc File be/src/runti

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types

2017-05-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Write and Read Parquet Statistics for remaining types .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-07 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#12). Change subject: IMPALA-2550: Switch to per-query exec rpc .. IMPALA-2550: Switch to per-query exec rpc Coordinator: - FragmentInstanceState -> BackendState, which in turn reco

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-07 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 11: (12 comments) http://gerrit.cloudera.org:8080/#/c/6535/10/be/src/runtime/coordinator.cc File be/sr

[Impala-ASF-CR] IMPALA-5167: Use a single Kudu client across the BE

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5167: Use a single Kudu client across the BE .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6792/1/be/src/exprs/kudu-partition-expr.

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6406 To un

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/6406/5/fe/src/main/java/

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 4: (18 comments) looking good. http://gerrit.cloudera.org:8080/#/c/6478/4/be/src/exec/hdfs-scan-node-base

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/6526/6/be/src/exec/kudu-scanne

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types

2017-05-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6563/

[Impala-ASF-CR] IMPALA-5120: Default to partitioned join when stats are missing

2017-05-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5120: Default to partitioned join when stats are missing .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6803/1/testdata

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types

2017-05-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types .. Patch Set 6: (10 comments) getting close http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 5: (23 comments) when staffan did the origin analysis, he found problems with

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/6789/1/be/src/exprs/timestamp-func

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 1: i'll take this. -- To view, visit http://gerrit.cloudera.org:8080/6789 To unsubscr

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 5: (2 comments) done with the comments. http://gerrit.cloudera.org:8080/#/c/6526/

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 5: (5 comments) some more quick comments, haven't look at the logic in detail yet.

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 5: (4 comments) quick feedback just for the tests. http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#11). Change subject: IMPALA-2550: Switch to per-query exec rpc .. IMPALA-2550: Switch to per-query exec rpc Coordinator: - FragmentInstanceState -> BackendState, which in turn reco

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 10: (72 comments) http://gerrit.cloudera.org:8080/#/c/6535/10/be/src/runtime/coordinator-backend-state

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-28 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6559/7/fe/src/main/ja

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-26 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 5: (22 comments) http://gerrit.cloudera.org:8080/#/c/6559/5/be/src/exec/kudu-util.h Fil

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types

2017-04-26 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6563/

[Impala-ASF-CR] IMPALA-4856: Port ImpalaInternalService to KRPC

2017-04-24 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5888/3/be/src/runtime/data-stream-mgr.h File

  1   2   3   4   5   6   >