[kudu-CR] heavy-update-compaction-itest

2018-01-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 ) Change subject: heavy-update-compaction-itest .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2233 Add a test case for compactions in the past

2018-01-09 Thread David Ribeiro Alves (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8885 to look at the new patch set (#7). Change subject: KUDU-2233 Add a test case for compactions in the past

[kudu-CR] [mvcc] Fix watermark advancement in the absence of committed transactions

2018-01-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8964 ) Change subject: [mvcc] Fix watermark advancement in the absence of committed transactions .. Patch Set 2: Verified+1 Unrelated

[kudu-CR] [mvcc] Fix watermark advancement in the absence of committed transactions

2018-01-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has removed a vote on this change. Change subject: [mvcc] Fix watermark advancement in the absence of committed transactions .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] [tablet] Add a pre-compaction check to avoid compactions in the past

2018-01-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8887 to look at the new patch set (#6). Change subject: [tablet] Add a pre-compaction check to avoid compactions in the past

[kudu-CR] KUDU-2233 Add a test case for compactions in the past

2018-01-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8885 to look at the new patch set (#6). Change subject: KUDU-2233 Add a test case for compactions in the past

[kudu-CR] [tablet] Avoid compactions in the past

2018-01-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8965 to look at the new patch set (#3). Change subject: [tablet] Avoid compactions in the past .. [tablet]

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-08 Thread David Ribeiro Alves (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8886 to look at the new patch set (#5). Change subject: Add some DVLOG statements to help in debugging compaction issues

[kudu-CR] [mvcc] Fix watermark advancement in the absence of committed transactions

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8964 ) Change subject: [mvcc] Fix watermark advancement in the absence of committed transactions .. Patch Set 1: (2 comments)

[kudu-CR] [mvcc] Fix watermark advancement in the absence of committed transactions

2018-01-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8964 to look at the new patch set (#2). Change subject: [mvcc] Fix watermark advancement in the absence of committed transactions

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8886 ) Change subject: Add some DVLOG statements to help in debugging compaction issues .. Patch Set 4: (1 comment)

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8886 ) Change subject: Add some DVLOG statements to help in debugging compaction issues .. Patch Set 4: I've had to rewrite a version

[kudu-CR] [fuzz-itest] Add the ability to roll/gc logs and to run elections

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. ( http://gerrit.cloudera.org:8080/8884 ) Change subject: [fuzz-itest] Add the ability to roll/gc logs and to run elections .. Abandoned merged this with another patch -- To

[kudu-CR] [tablet] Avoid compactions in the past

2018-01-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8965 to look at the new patch set (#2). Change subject: [tablet] Avoid compactions in the past .. [tablet] Avoid

[kudu-CR] KUDU-2233 Add a test case for compactions in the past

2018-01-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8885 to look at the new patch set (#4). Change subject: KUDU-2233 Add a test case for compactions in the past ..

[kudu-CR] [raft] Add an EmulateElection variant that waits for one more commit

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8883 ) Change subject: [raft] Add an EmulateElection variant that waits for one more commit .. Patch Set 2: fair point, abandoning

[kudu-CR] [raft] Add an EmulateElection variant that waits for one more commit

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. ( http://gerrit.cloudera.org:8080/8883 ) Change subject: [raft] Add an EmulateElection variant that waits for one more commit .. Abandoned -- To view, visit

[kudu-CR] [mvcc] Fix watermark advancement in the absence of committed transactions

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8964 Change subject: [mvcc] Fix watermark advancement in the absence of committed transactions .. [mvcc] Fix watermark advancement in

[kudu-CR] KUDU-2233 Add a test case for compactions in the past

2018-01-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8885 to look at the new patch set (#3). Change subject: KUDU-2233 Add a test case for compactions in the past ..

[kudu-CR] [fuzz-itest] Add the ability to roll/gc logs and to run elections

2018-01-08 Thread David Ribeiro Alves (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8884 to look at the new patch set (#7). Change subject: [fuzz-itest] Add the ability to roll/gc logs and to run elections

[kudu-CR] [tablet] Add a pre-compaction check to avoid compactions in the past

2018-01-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8887 to look at the new patch set (#3). Change subject: [tablet] Add a pre-compaction check to avoid compactions in the past

[kudu-CR] [tablet] Avoid compactions in the past

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8965 Change subject: [tablet] Avoid compactions in the past .. [tablet] Avoid compactions in the past A previous patch introduced a

[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 ) Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode .. Patch Set 6: Code-Review+2 -- To view,

[kudu-CR] KUDU-2251: rowset size can overflow int in RowSetInfo

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8951 ) Change subject: KUDU-2251: rowset size can overflow int in RowSetInfo .. Patch Set 6: (2 comments)

[kudu-CR] KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8921 ) Change subject: KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader .. Patch Set 5: Code-Review+2 Ah,

[kudu-CR] KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader

2018-01-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8921 ) Change subject: KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader .. KUDU-2249 Avoid sharing

[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode

2018-01-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 ) Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode .. Patch Set 4: (3 comments) thanks for

[kudu-CR] [java client] update propagate TS for AUTO FLUSH SYNC flush mode

2018-01-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 ) Change subject: [java client] update propagate TS for AUTO_FLUSH_SYNC flush mode .. Patch Set 3: (8 comments)

[kudu-CR] KUDU-2251: rowset size can overflow int in RowSetInfo

2018-01-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8951 ) Change subject: KUDU-2251: rowset size can overflow int in RowSetInfo .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2251: rowset size can overflow int in RowSetInfo

2018-01-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8951 ) Change subject: KUDU-2251: rowset size can overflow int in RowSetInfo .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader

2018-01-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8921 ) Change subject: KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2249 Prevent race condition between getSplits() method and TableRecordReader

2018-01-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8921 ) Change subject: KUDU-2249 Prevent race condition between getSplits() method and TableRecordReader .. Patch Set 3: (3 comments)

[kudu-CR](branch-1.5.x) KUDU-2251: rowset size can overflow int in RowSetInfo

2018-01-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8941 ) Change subject: KUDU-2251: rowset size can overflow int in RowSetInfo .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) Add support for clang from XCode 9 in macOS

2018-01-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8940 ) Change subject: Add support for clang from XCode 9 in macOS .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) KUDU-2251: rowset size can overflow int in RowSetInfo

2018-01-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8941 ) Change subject: KUDU-2251: rowset size can overflow int in RowSetInfo .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2249 give the TableRecordReader their own KuduClient to use.

2018-01-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8921 ) Change subject: KUDU-2249 give the TableRecordReader their own KuduClient to use. .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1704: add c++ client support for READ OWN WRITES mode

2018-01-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 ) Change subject: KUDU-1704: add c++ client support for READ_OWN_WRITES mode .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1704: add java client support for READ OWN WRITES mode

2018-01-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8847 ) Change subject: KUDU-1704: add java client support for READ_OWN_WRITES mode .. Patch Set 1: (3 comments) I know you're

[kudu-CR] [java clien] update propagate TS for AUTO FLUSH SYNC flush mode

2018-01-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 ) Change subject: [java clien] update propagate TS for AUTO_FLUSH_SYNC flush mode .. Patch Set 2: (2 comments) does the changes

[kudu-CR] KUDU-2232. java: Remove deprecated call from KuduTable

2018-01-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8749 ) Change subject: KUDU-2232. java: Remove deprecated call from KuduTable .. Patch Set 2: (1 comment)

[kudu-CR] move configuration constants into separate class and make public

2018-01-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8920 ) Change subject: move configuration constants into separate class and make public .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2249 give the TableRecordReader their own KuduClient to use.

2018-01-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8921 ) Change subject: KUDU-2249 give the TableRecordReader their own KuduClient to use. .. Patch Set 1: (1 comment)

[kudu-CR] [fuzz-itest] Add the ability to roll/gc logs and to run elections

2017-12-22 Thread David Ribeiro Alves (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8884 to look at the new patch set (#6). Change subject: [fuzz-itest] Add the ability to roll/gc logs and to run elections

[kudu-CR] [fuzz-itest] Add the ability to roll/gc logs and to run elections

2017-12-22 Thread David Ribeiro Alves (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8884 to look at the new patch set (#5). Change subject: [fuzz-itest] Add the ability to roll/gc logs and to run elections

[kudu-CR] [fuzz-itest] Add the ability to roll/gc logs and to run elections

2017-12-22 Thread David Ribeiro Alves (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8884 to look at the new patch set (#4). Change subject: [fuzz-itest] Add the ability to roll/gc logs and to run elections

[kudu-CR] design-docs: improve cfile.md

2017-12-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8860 ) Change subject: design-docs: improve cfile.md .. Patch Set 1: (8 comments)

[kudu-CR] [raft] Add an EmulateElection variant that waits for one more commit

2017-12-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8883 to look at the new patch set (#2). Change subject: [raft] Add an EmulateElection variant that waits for one more commit

[kudu-CR] [fuzz-itest] Add the ability to roll/gc logs and to run elections

2017-12-22 Thread David Ribeiro Alves (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8884 to look at the new patch set (#3). Change subject: [fuzz-itest] Add the ability to roll/gc logs and to run elections

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2017-12-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8886 to look at the new patch set (#2). Change subject: Add some DVLOG statements to help in debugging compaction issues

[kudu-CR] [fuzz-itest] Add the ability to roll/gc logs and to run elections

2017-12-19 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8884 to look at the new patch set (#2). Change subject: [fuzz-itest] Add the ability to roll/gc logs and to run elections

[kudu-CR] [raft] Make EmulateElection wait until an OP got committed

2017-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has removed a vote on this change. Change subject: [raft] Make EmulateElection wait until an OP got committed .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] Add some DVLOG statements to help in debugging compaction issues

2017-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8886 Change subject: Add some DVLOG statements to help in debugging compaction issues .. Add some DVLOG statements to help in debugging

[kudu-CR] [tablet] Make sure compactions never happen in the past

2017-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8887 Change subject: [tablet] Make sure compactions never happen in the past .. [tablet] Make sure compactions never happen in the past

[kudu-CR] [raft] Make EmulateElection wait until an OP got committed

2017-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8883 Change subject: [raft] Make EmulateElection wait until an OP got committed .. [raft] Make EmulateElection wait until an OP got

[kudu-CR] KUDU-2233 Add a test case for compactions in the past

2017-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8885 Change subject: KUDU-2233 Add a test case for compactions in the past .. KUDU-2233 Add a test case for compactions in the past

[kudu-CR] [fuzz-itest] Add the ability to roll/gc logs and to run elections

2017-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8884 Change subject: [fuzz-itest] Add the ability to roll/gc logs and to run elections .. [fuzz-itest] Add the ability to roll/gc logs

[kudu-CR] thirdparty: fix bison compilation in macOS High Sierra

2017-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8815 ) Change subject: thirdparty: fix bison compilation in macOS High Sierra .. thirdparty: fix bison compilation in macOS High

[kudu-CR] KUDU-1704: add READ OWN WRITES scan mode

2017-12-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_OWN_WRITES scan mode .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1704: add READ OWN WRITES scan mode

2017-12-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_OWN_WRITES scan mode .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1704: add BOUNDED READ scan mode

2017-12-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add BOUNDED_READ scan mode .. Patch Set 1: (5 comments)

[kudu-CR] thirdparty: fix bison compilation in macOS High Sierra

2017-12-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8815 Change subject: thirdparty: fix bison compilation in macOS High Sierra .. thirdparty: fix bison compilation in macOS High Sierra

[kudu-CR] exactly once writes-itest for faulty disks

2017-11-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8388 ) Change subject: exactly_once_writes-itest for faulty disks .. Patch Set 3: (3 comments)

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 20: It'd be better to have a itest that stresses

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 20: (5 comments)

[kudu-CR] KUDU-2184. arena: fix max buffer size to just less than 1MB

2017-10-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8324 ) Change subject: KUDU-2184. arena: fix max buffer size to just less than 1MB .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] arena: remove second parameter for max buffer size

2017-10-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8269 ) Change subject: arena: remove second parameter for max buffer size .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2044 Tombstoned tablets show up in /metrics

2017-10-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7981 ) Change subject: KUDU-2044 Tombstoned tablets show up in /metrics .. Patch Set 7: Code-Review+2 (1 comment) xxs nit fell free to

[kudu-CR] arena: remove second parameter for max buffer size

2017-10-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8269 ) Change subject: arena: remove second parameter for max buffer size .. Patch Set 1: Thanks for doing this. Did you run a quick

[kudu-CR] KUDU-2187. Don't hold threadpool lock while creating threads

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8256 ) Change subject: KUDU-2187. Don't hold threadpool lock while creating threads .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2184. Avoid allocations larger than 1MB

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8239 ) Change subject: KUDU-2184. Avoid allocations larger than 1MB .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2184. Avoid allocations larger than 1MB

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8239 ) Change subject: KUDU-2184. Avoid allocations larger than 1MB .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1865 (part 1): reduce some cross-thread allocations

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/5905 ) Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8245 ) Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2184. Avoid allocations larger than 1MB

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8239 ) Change subject: KUDU-2184. Avoid allocations larger than 1MB .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8245 ) Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable .. Patch Set 1: (2 comments)

[kudu-CR] Add log parser script

2017-10-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8229 ) Change subject: Add log parser script .. Patch Set 1: Code-Review+1 I'd be pro merging this as is or close. better having this

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-09-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 15: (1 comment)

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-09-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 15: (3 comments)

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-09-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 15: This is one of the most tricky changes (if

[kudu-CR] WIP [consensus] introduce adding NON VOTER members

2017-09-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8138 ) Change subject: WIP [consensus] introduce adding NON_VOTER members .. Patch Set 2: (2 comments)

[kudu-CR] WIP [consensus] introduce adding NON VOTER members

2017-09-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8138 ) Change subject: WIP [consensus] introduce adding NON_VOTER members .. Patch Set 1: (1 comment)

[kudu-CR] WIP [consensus] introduce adding NON VOTER members

2017-09-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8138 ) Change subject: WIP [consensus] introduce adding NON_VOTER members .. Patch Set 1: (2 comments)

[kudu-CR] [tablet copy] end session before bootstrapping tablet

2017-09-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8133 ) Change subject: [tablet copy] end session before bootstrapping tablet .. Patch Set 1: (1 comment)

[kudu-CR] [tablet copy] end session before bootstrapping tablet

2017-09-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8133 ) Change subject: [tablet copy] end session before bootstrapping tablet .. Patch Set 1: oops, that last item should read:

[kudu-CR] [tablet copy] end session before bootstrapping tablet

2017-09-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8133 ) Change subject: [tablet copy] end session before bootstrapping tablet .. Patch Set 1: My understanding of it is the following. I

[kudu-CR] [tablet copy] end session before bootstrapping tablet

2017-09-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8133 ) Change subject: [tablet copy] end session before bootstrapping tablet .. Patch Set 1: Looking at TabletCopySession it seems

[kudu-CR] [tablet copy] end session before bootstrapping tablet

2017-09-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8133 ) Change subject: [tablet copy] end session before bootstrapping tablet .. Patch Set 1: (1 comment)

[kudu-CR] Revert "[tests] fix flakiness in catalog manager tsk-itest"

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8129 ) Change subject: Revert "[tests] fix flakiness in catalog_manager_tsk-itest" .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: (2 comments)

[kudu-CR] Prioritize freeing memory over releasing WAL segments

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. ( http://gerrit.cloudera.org:8080/8128 ) Change subject: Prioritize freeing memory over releasing WAL segments .. Abandoned Letting this go, I don't think this is an issue. -- To

[kudu-CR] Prioritize freeing memory over releasing WAL segments

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8128 ) Change subject: Prioritize freeing memory over releasing WAL segments .. Patch Set 1: (1 comment)

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 ) Change subject: thirdparty: fix to protobuf bump .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Prioritize freeing memory over releasing WAL segments

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8128 Change subject: Prioritize freeing memory over releasing WAL segments .. Prioritize freeing memory over releasing WAL segments

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

2017-09-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8127 Change subject: WIP: Pull StatusOr and related tests from protobuf .. WIP: Pull StatusOr and related tests from protobuf Needs

[kudu-CR] Add support for clang from XCode 9 in macOS

2017-09-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8119 ) Change subject: Add support for clang from XCode 9 in macOS .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 ) Change subject: thirdparty: fix to protobuf bump .. Patch Set 1: |I removed the patch level stuff in the recent Protobuf 3.3 ->

[kudu-CR] thirdparty: fix to protobuf bump

2017-09-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8115 ) Change subject: thirdparty: fix to protobuf bump .. Patch Set 1: Weren't we going to start using patch level 0 like in

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 1: (1 comment)

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: Posting a transcript of a side chat, for posterity: ... [1:12 PM] David Alves: no, no other

<    1   2   3   4   5   6   7   8   9   10   >