[kudu-CR] Clean up switch statements in column predicate.cc

2016-10-03 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Clean up switch statements in column_predicate.cc .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4599/1/src/kudu/common/column_pred

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-03 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4594 to look at the new patch set (#2). Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-03 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 1: (9 comments) TFTR Adar/Alexey, updated the patch, please see responses in

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-10-03 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 9: (5 comments) > (5 comments) > > There is one extra instance of "master_addresses" stri

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-10-03 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#10). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-03 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4594/2/src/kudu/util/subp

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-04 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4594/2/src/kudu/util/subp

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-04 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4594 to look at the new patch set (#3). Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-04 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4594/2/src/kudu/util/subp

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-05 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 3: (5 comments) TFTR Alexey, http://gerrit.cloudera.org:8080/#/c/4594/3/src

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-05 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4594 to look at the new patch set (#4). Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .

[kudu-CR] delete table-test: fix flakiness with table creation timeout

2016-10-05 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: delete_table-test: fix flakiness with table creation timeout .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4632 To unsubscribe,

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-10-07 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#12). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-10-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 12: > > Patch Set 11: Patch Set 10 was rebased > > Could you also add coverage for the new

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-10-07 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#13). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-10-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/4533/12/src/kudu/tools/tool_action_table

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-10 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/4648/7/src/kudu/util/subprocess.cc File src/kudu/util/su

[kudu-CR] [doc] added link to online Kudu C++ client API

2016-10-11 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [doc] added link to online Kudu C++ client API .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4684/2/docs/installation.adoc File do

[kudu-CR] [doc] added link to online Kudu C++ client API

2016-10-11 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [doc] added link to online Kudu C++ client API .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4684/2/docs/installation.adoc File do

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-11 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/4648/7/src/kudu/util/subprocess.cc File src/kudu/util/su

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/4648/7/src/kudu/util/subprocess.cc File src/kudu/util/su

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4648 To unsubscribe, visit http://gerrit

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4702

[kudu-CR] KUDU-1696. Daemons should dump their version info to the INFO log at startup

2016-10-18 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1696. Daemons should dump their version info to the INFO log at startup .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4733/3/src/kudu/mas

[kudu-CR] types: Correct printable name of UNIXTIME MICROS

2016-10-20 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: types: Correct printable name of UNIXTIME_MICROS .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4777 To unsubscribe, visit http:/

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4800/1/src/kudu/u

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4800/1//COMMIT_MSG Commit Messa

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4834 to review the following change. Change subject: [tools] Manual recovery tools (part 1) .. [too

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-25 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 3: Code-Review+1 (1 comment) Nice cleanups, LGTM. http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

2016-10-26 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4852 to review the following change. Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc .

[kudu-CR] KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

2016-10-26 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Will Berkeley, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4852 to look at the new patch set (#2). Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

[kudu-CR] block manager: consolidate data directory management

2016-10-26 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: block_manager: consolidate data directory management .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/4793/4/src/kudu/fs/data_dirs.cc File src/kud

[kudu-CR] KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

2016-10-27 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4852/2/src

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-27 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#2). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-27 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 1: (38 comments) http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/integration-tests/cluster_itest_util.cc F

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-27 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 2: > didn't look at any of this code, but just wanted to drop a note > saying I used the local_replica delete

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-28 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#3). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-28 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tool

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-29 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#4). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-30 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#5). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools

[kudu-CR] KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

2016-10-31 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/4852/2//

[kudu-CR] [scripts] KUDU-1566: Update jira fields automatically

2016-10-31 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Will Berkeley, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4852 to look at the new patch set (#3). Change subject: [scripts] KUDU-1566: Update jira fields automatically ...

[kudu-CR] [fs manager] Disallow write operations on read only fs handles

2016-10-31 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4891 to review the following change. Change subject: [fs_manager] Disallow write operations on read_only fs handles

[kudu-CR] block manager: consolidate data directory management

2016-11-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: block_manager: consolidate data directory management .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4793/4/src/kudu/fs/log_block_ma

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tool

[kudu-CR] [fs manager] Disallow write operations on read only fs handles

2016-11-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [fs_manager] Disallow write operations on read_only fs handles .. Patch Set 1: > I remember our discussion that led to this patch, but in retrospect > it looks li

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-02 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#6). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-02 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#7). Change subject: [tools] Manual recovery tools (part 1) ..

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 7: (16 comments) http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/integration-tests/cluster_itest_util.h Fi

[kudu-CR] Avoid extra fsyncs of tombstoned tablets during startup

2016-11-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Avoid extra fsyncs of tombstoned tablets during startup .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4915/3/src/kudu/tablet/tablet_metadata.cc

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-03 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#8). Change subject: [tools] Manual recovery tools (part 1) ..

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-03 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 8: (1 comment) Hi Mike, I have reworked the entire tablet-copy test to make it less convoluted and much simp

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-03 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#9). Change subject: [tools] Manual recovery tools (part 1) ..

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-03 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 9: (10 comments) http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/too

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-03 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#10). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-04 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 10: (2 comments) > (2 comments) > > Would you mind also adding a test that makes sure that attempting > to

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-04 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/too

[kudu-CR] [rpc] Close socket on non-linux platforms during RPC shutdown

2016-11-04 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4958 to review the following change. Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown .

[kudu-CR] Avoid extra fsyncs of tombstoned tablets during startup

2016-11-04 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Avoid extra fsyncs of tombstoned tablets during startup .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4915/3/src/kudu/tablet/tablet_metadata.cc

[kudu-CR] [rpc] Close socket on non-linux platforms during RPC shutdown

2016-11-07 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4958 to look at the new patch set (#2). Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown .

[kudu-CR] [rpc] Close socket on non-linux platforms during RPC shutdown

2016-11-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown .. Patch Set 2: (2 comments) TFTR Mike. http://gerrit.cloudera.org:8080/#/c/4958/1/src/kudu/rpc/acc

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/write_op_s

[kudu-CR] Avoid extra fsyncs of tombstoned tablets during startup

2016-11-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Avoid extra fsyncs of tombstoned tablets during startup .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4915 To unsubscribe, visit

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Patch Set 2: Code-Review+1 Nit: Is there a reason to keep the same naming convention for HybridClock::

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-07 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#11). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#12). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#13). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#14). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#15). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#16). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 15: (3 comments) Also updated COMMIT_MSG to reflect the new flag added. http://gerrit.cloudera.org:8080/#/c/4

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#17). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5012 to review the following change. Change subject: [doc] 1.1.0 release notes for tools .. [doc] 1.1.0 release note

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 1: (2 comments) I also added couple of more tools which got pushed few minutes ago. http://gerrit.cloudera.org:8

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5012 to look at the new patch set (#2). Change subject: [doc] 1.1.0 release notes for tools .. [doc]

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5012 to look at the new patch set (#3). Change subject: [doc] 1.1.0 release notes for tools .. [doc]

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5012/2/docs/release_notes.adoc File docs/release_notes.adoc:

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5012/3/docs/release_notes.adoc File docs/release_notes.adoc:

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5012 to look at the new patch set (#4). Change subject: [doc] 1.1.0 release notes for tools .

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Patch Set 3: > Dinesh: Yeah I saw that and I pondered what you are suggesting. > Ended up not doing it

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/com

[kudu-CR] [doc] mention the loadgen tool in the release notes

2016-11-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [doc] mention the loadgen tool in the release notes .. Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/5020/1/docs/release_notes.adoc

[kudu-CR] Reject CREATE TABLE ops with even replication factor

2016-11-10 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Reject CREATE TABLE ops with even replication factor .. Patch Set 5: Code-Review+1 (1 comment) LGTM, one nit. http://gerrit.cloudera.org:8080/#/c/4945/5//COMMIT_

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Add 11/15 weekly update .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5098/3/_posts/2016-11-15-weekly-update.md File _posts/2016-1

[kudu-CR] [Timestamp] use 'operator<' instead of ComesBefore

2016-11-16 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [Timestamp] use 'operator<' instead of ComesBefore .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5096/3/src/kudu/common/timestamp.h File src/ku

[kudu-CR] [consensus] KUDU-1718: Fix few bugs around replica eviction failures

2016-11-16 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5111 to review the following change. Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures

[kudu-CR] [consensus] KUDU-1718: Fix few bugs around replica eviction failures

2016-11-16 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures .. Patch Set 1: (1 comment) TFTR David, > (1 comment) > > would it be possible to split

[kudu-CR] [Timestamp] use 'operator<' instead of ComesBefore

2016-11-17 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [Timestamp] use 'operator<' instead of ComesBefore .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5096/3/src/kudu/common/timestamp.

[kudu-CR] tablet copy: Make the StartTabletCopy() RPC async

2016-11-17 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5045/2/src/kudu/tserver/ts_tablet_manager.cc Fi

[kudu-CR] [consensus] KUDU-1718: Fix few bugs around replica eviction failures

2016-11-18 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5111 to look at the new patch set (#2). Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures ..

[kudu-CR] [tools] Tombstone the tablet with "local replica delete"

2016-11-22 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5191 to review the following change. Change subject: [tools] Tombstone the tablet with "local_replica delete" ..

[kudu-CR] [tools] Tombstone the tablet with "local replica delete"

2016-11-28 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5191 to look at the new patch set (#2). Change subject: [tools] Tombstone the tablet with "local_replica delete"

[kudu-CR] [tools] Tombstone the tablet with "local replica delete"

2016-11-28 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Tombstone the tablet with "local_replica delete" .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/5191/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] [consensus] KUDU-1718: Fix few bugs around replica eviction failures

2016-11-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/5111/2/src/kudu/consensus/c

[kudu-CR] [consensus] KUDU-1718: Fix few bugs around replica eviction failures

2016-11-29 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5111 to look at the new patch set (#3). Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures ..

[kudu-CR] util: add file cache

2016-11-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: util: add file cache .. Patch Set 5: (11 comments) Excellent stuff Adar, took a first pass, still to see tests and deletion path. There are some minor comments a

[kudu-CR] block manager: start using the file cache

2016-11-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: block manager: start using the file cache .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5147/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs

[kudu-CR] [ts tablet manager] simplified WaitForAllBootstrapsToFinish

2016-11-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [ts_tablet_manager] simplified WaitForAllBootstrapsToFinish .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5301/1/src/kudu/tablet/tablet_peer.cc

[kudu-CR] [tools] Tombstone the tablet with "local replica delete"

2016-11-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Tombstone the tablet with "local_replica delete" .. Patch Set 2: (12 comments) TFTR Adar/Mike, addressed comments, one response inline below: http://gerr

<    1   2   3   4   >