Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47266/#review133251 --- Patch looks great! Reviews applied: [47265, 47266] Passed

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/ --- (Updated May 14, 2016, 4:20 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 47362: Added a test for the SSL head-of-line blocking issue in MESOS-5340.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47362/#review133250 --- 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 736)

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review133249 --- Bad patch! Reviews applied: [47374, 47216, 47150, 47215, 47214,

Re: Review Request 47198: Added labels to docker v1 spec config.

> On 五月 12, 2016, 12:25 p.m., Guangya Liu wrote: > > include/mesos/docker/v1.proto, lines 56-57 > > > > > > Why both `optional`? I found that other `Label` definition are defining > > `key` as required but `value`

Re: Review Request 47362: Added a test for the SSL head-of-line blocking issue in MESOS-5340.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47362/#review133246 --- Bad patch! Reviews applied: [47362] Failed command:

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

> On 五月 12, 2016, 12:44 p.m., Guangya Liu wrote: > > src/docker/spec.cpp, lines 226-230 > > > > > > Does there are any possiblity that there are duplicat labels in > > `config` and `container_config`? If so, how to

Re: Review Request 47209: Establish TCP connection after backing off.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47209/#review133243 --- src/slave/slave.cpp (line 1019)

Re: Review Request 47169: Windows: Implemented `killtree` using NT job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47169/#review133239 --- Patch looks great! Reviews applied: [47052, 47053, 47221, 47054,

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/ --- (Updated 五月 14, 2016, 1:33 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/ --- (Updated 五月 14, 2016, 1:29 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/ --- (Updated 五月 14, 2016, 12:58 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

> On 五月 12, 2016, 10:34 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp, line > > 174 > > > > > > since you already have the check above, why dont you return

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47360/ --- (Updated May 14, 2016, 12:39 a.m.) Review request for mesos, Bernd Mathiske

Review Request 47381: Fixed agent to properly handle killTask of unregistered executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47381/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5380

Re: Review Request 46107: Add Appc runtime spec for command, working directory and environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46107/#review133232 --- Patch looks great! Reviews applied: [46107] Passed command:

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

> On 五月 13, 2016, 6:49 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 320 > > > > > > s/bind/bind and overlay > > Gilbert Song wrote: > The overlay backend supports

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

> On 五月 13, 2016, 5:22 p.m., James Peach wrote: > > Looks fine. Consider switching to ``unique_ptr``, since we only check the > > ``fts_close`` error 1 of 3 times. @James Peach, can you please show more detail for what do you mean? How to switch to `unique_prt`? Do you want me to submit

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46182/#review133221 --- Patch looks great! Reviews applied: [46182] Passed command:

Review Request 47367: Removed references to HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47367/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5302

Review Request 47363: Introduced a driver to v1 executor shim/adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5302

Review Request 47365: Moved code from HTTP command executor to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47365/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5302

Review Request 47366: Made the command executor use the adapter interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47366/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5302

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

> On May 12, 2016, 11:33 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 375 > > > > > > You seem to only fts_close on error cases, but in the normal case > > skipped

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

> On May 12, 2016, 11:49 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 320 > > > > > > s/bind/bind and overlay The overlay backend supports multi-layered images:) -

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47266/ --- (Updated May 13, 2016, 3:16 p.m.) Review request for mesos, Avinash sridharan,

Review Request 47360: Updated dynamic reservation and persistent volume docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47360/ --- Review request for mesos, Bernd Mathiske and Neil Conway. Bugs: MESOS-5215

Review Request 47362: Added a test for the SSL head-of-line blocking issue in MESOS-5340.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47362/ --- Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Neil

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133205 --- Ship it! Ship It! - Gilbert Song On May 13, 2016, 12:09

Review Request 47359: Fixed a typo in persistent volume docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47359/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133200 --- Patch looks great! Reviews applied: [47274] Passed command:

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review133198 --- This looks good but when you mentioned the consecutive failures

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/ --- (Updated May 13, 2016, 1:49 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47198: Added labels to docker v1 spec config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/ --- (Updated May 13, 2016, 1:48 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

> On May 12, 2016, 5:44 a.m., Guangya Liu wrote: > > src/docker/spec.cpp, lines 226-230 > > > > > > Does there are any possiblity that there are duplicat labels in > > `config` and `container_config`? If so, how to

Re: Review Request 47169: Windows: Implemented `killtree` using NT job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47169/ --- (Updated May 13, 2016, 8:42 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 47168: Windows: Implemented `kill`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/ --- (Updated May 13, 2016, 8:42 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 47089: Waited for first statusUpdate before advance clock in GracePeriod test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47089/#review133196 --- src/tests/health_check_tests.cpp (line 1015)

Re: Review Request 47198: Added labels to docker v1 spec config.

> On May 12, 2016, 5:25 a.m., Guangya Liu wrote: > > include/mesos/docker/v1.proto, lines 56-57 > > > > > > Why both `optional`? I found that other `Label` definition are defining > > `key` as required but `value`

Re: Review Request 47340: Modified doc file for '/containers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47340/#review133188 --- Could you please squash this with

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

> On May 12, 2016, 11:44 p.m., Jojy Varghese wrote: > > Srinivas, thanks for taking this on. It looks like you combined your > > previous patches (https://reviews.apache.org/r/46107) here. I would advice > > you to split this patch into 2: > > - Protobuf changes > > - Other changes > > > >

Re: Review Request 47324: Update leveldb.

> On May 13, 2016, 4:38 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [47324] > > > > Failed command: ./support/apply-review.sh -n -r 47324 > > > > Error: > > 2016-05-13 04:38:10 URL:https://reviews.apache.org/r/47324/diff/raw/ > > [4739/4739] -> "47324.patch" [1] > >

Re: Review Request 47324: Update leveldb.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/ --- (Updated May 13, 2016, 7:55 p.m.) Review request for mesos, Bing Li, Benjamin

Re: Review Request 46107: Add Appc runtime spec for command, working directory and environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46107/ --- (Updated May 13, 2016, 7:52 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46182/ --- (Updated May 13, 2016, 7:52 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47222: Add authorization to /quota endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47222/#review133183 --- Patch looks great! Reviews applied: [47222] Passed command:

Re: Review Request 47340: Modified doc file for '/containers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47340/#review133182 --- Ship it! Ship It! - Till Toenshoff On May 13, 2016, 2:23

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

> On May 13, 2016, 3:27 p.m., Till Toenshoff wrote: > > I am not convinced that this test adds anything. libprocess handles the > > authentication and hence testing a single endpoint as an integration test > > seems to get us all the information we need -> "have we properly integrated > > the

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/ --- (Updated May 13, 2016, 6:48 p.m.) Review request for mesos, Adam B and

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/ --- (Updated May 13, 2016, 6:47 p.m.) Review request for mesos, Adam B and

Re: Review Request 46424: Windows: Added libprocess to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46424/#review133174 --- Bad review! Reviews applied: [46424, 47162] Error: No reviewers

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

> On May 13, 2016, 5:38 p.m., Zhitao Li wrote: > > src/master/quota_handler.cpp, line 464 > > > > > > I'd like to keep using vector because we know the expected size in the > > beginning and can reserve the

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/#review133171 --- Fix it, then Ship it! I'll fix outstanding issues for you and

Re: Review Request 47162: Libprocess: Made some of the tests work on Windows.

> On May 13, 2016, 4:33 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp, line 107 > > > > > > How about `close_fd`? > > Also, why can't we use `os::close` here? Do we

Re: Review Request 47162: Libprocess: Made some of the tests work on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47162/ --- (Updated May 13, 2016, 6:18 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46799: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/#review133170 --- Bad patch! Reviews applied: [46799, 46798, 46371, 46370, 46369]

Re: Review Request 38148: Fixed a typo when run 'mesos slave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38148/#review133169 --- Ship it! Ship It! - Vinod Kone On May 13, 2016, 10:08 a.m.,

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133164 --- src/master/quota_handler.cpp (line 464)

Re: Review Request 47339: Refactored URL path endpoint extraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/#review133162 --- Ship it! Ship It! - Alexander Rukletsov On May 13, 2016,

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133158 --- Ship it! Looks fine. Consider switching to ``unique_ptr``,

Re: Review Request 46392: Windows: Added stub implementations of `fcntl.hpp` functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/ --- (Updated May 13, 2016, 5:22 p.m.) Review request for mesos. Bugs: MESOS-5371

Re: Review Request 47169: Windows: Implemented `killtree` using NT job objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47169/#review133157 --- Fix it, then Ship it!

Re: Review Request 47168: Windows: Implemented `kill`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/#review133155 --- 3rdparty/stout/include/stout/os/windows/kill.hpp (lines 47 - 48)

Re: Review Request 46424: Windows: Added libprocess to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46424/#review133142 --- Ship it! Ship It! - Joris Van Remoortere On May 12, 2016,

Re: Review Request 46799: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/ --- (Updated May 13, 2016, 4:46 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 47162: Libprocess: Made some of the tests work on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47162/#review132487 --- 3rdparty/libprocess/src/tests/main.cpp (lines 45 - 63)

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133139 --- Ship it! Ship It! - Timothy Chen On May 13, 2016, 7:09

Re: Review Request 38148: Fixed a typo when run 'mesos slave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38148/#review133138 --- Ship it! Ship It! - Jay Guo On May 13, 2016, 10:08 a.m.,

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

> On May 13, 2016, 2:17 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 464 > > > > > > If we eliminate intermediate vector, we will be looping thorugh hashmap > > and list simultaneously. I

Re: Review Request 46392: Windows: Added stub implementations of `fcntl.hpp` functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/#review133136 --- Fix it, then Ship it!

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133135 --- Patch looks great! Reviews applied: [47222, 47274] Passed

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

> On May 13, 2016, 2:17 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 441-447 > > > > > > Do we really need this copy? Or we can directly use `master->quotas`? After a second thought,

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated May 13, 2016, 3:40 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47055/#review133122 --- src/webui/master/static/css/mesos.css (line 2)

Re: Review Request 47221: Windows: Used `os::random` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47221/#review133130 --- Fix it, then Ship it!

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/#review133129 --- Fix it, then Ship it! src/slave/slave.cpp (lines 799 - 805)

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47062/#review133126 --- I am not convinced that this test adds anything. libprocess

Re: Review Request 38148: Fixed a typo when run 'mesos slave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38148/#review133125 --- Patch looks great! Reviews applied: [38148] Passed command:

Re: Review Request 47339: Refactored URL path endpoint extraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/ --- (Updated May 13, 2016, 4:54 p.m.) Review request for mesos and Alexander

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review133120 --- Ship it! Ship It! - Till Toenshoff On May 13, 2016, 9:50

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

> On May 13, 2016, 2:59 p.m., Till Toenshoff wrote: > > Ship It! Minus the "debugging artefact?" Alex noted. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review133120

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/#review133117 --- Fix it, then Ship it! Ship It!

Re: Review Request 47339: Refactored URL path endpoint extraction.

> On May 13, 2016, 3:16 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, line 855 > > > > > > Do we need the first check given we explicitly requested `tokenize()` > > to split endpoint into two parts? > >

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47062/#review133118 --- Ship it! Ship It! - Alexander Rukletsov On May 13, 2016,

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review133114 --- Fix it, then Ship it! src/slave/slave.cpp (line 766)

Re: Review Request 47340: Modified doc file for '/containers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47340/#review133115 --- Ship it! Ship It! - Alexander Rukletsov On May 13, 2016,

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47062/ --- (Updated May 13, 2016, 2:24 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47340: Modified doc file for '/containers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47340/ --- (Updated May 13, 2016, 2:23 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47339: Refactored URL path endpoint extraction.

> On May 13, 2016, 1:16 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp, line 855 > > > > > > Do we need the first check given we explicitly requested `tokenize()` > > to split endpoint into two parts? > >

Re: Review Request 47274: Authorize what quota can be seen by GET_QUOTA_BY_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133094 --- Looks good. Could you please make this patch self-contained,

Re: Review Request 47339: Refactored URL path endpoint extraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/ --- (Updated May 13, 2016, 4:12 p.m.) Review request for mesos and Alexander

Re: Review Request 47340: Modified doc file for '/containers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47340/#review133103 --- Bad patch! Reviews applied: [47340, 47062, 47061] Failed

Re: Review Request 47336: Fixed FTS handle leak issue in xfs isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133095 --- Patch looks great! Reviews applied: [47336] Passed command:

Re: Review Request 47222: Add authorization to /quota endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47222/#review133093 --- Let's punt on the coarse-grained authz for now. - Alexander

Re: Review Request 47339: Refactored URL path endpoint extraction.

> On May 13, 2016, 10:47 a.m., Alexander Rukletsov wrote: > > src/slave/slave.hpp, line 475 > > > > > > `static`? > > Jan Schlicht wrote: > The function uses `slave->this().id` so it would be a bit inconvenient

Re: Review Request 47339: Refactored URL path endpoint extraction.

> On May 13, 2016, 12:47 p.m., Alexander Rukletsov wrote: > > src/slave/slave.hpp, line 475 > > > > > > `static`? The function uses `slave->this().id` so it would be a bit inconvenient to make it static. - Jan

Re: Review Request 47339: Refactored URL path endpoint extraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/#review133075 --- src/slave/http.cpp (line 838)

Review Request 38148: Fixed a typo when run 'mesos slave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38148/ --- Review request for mesos, Jay Guo and Vinod Kone. Summary (updated)

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

> On May 12, 2016, 8:51 p.m., Alexander Rukletsov wrote: > > Could you please update `Slave::Http::CONTAINERS_HELP()` as well? Yeah, updated. Added another RR https://reviews.apache.org/r/47340/ for the updated doc for /containers endpoint generated by running support/generate-endpoint.sh.

Review Request 47340: Modified doc file for '/containers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47340/ --- Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Till

  1   2   >