Re: Review Request 45491: Refactored subprocess options [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review149318 --- 3rdparty/libprocess/include/process/posix/subprocess.hpp (lines

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

In fact, in MVP, 'status' won't be called for nested containers. Containerizer will enforce that. On Fri, Sep 16, 2016 at 9:01 PM, Avinash Sridharan wrote: > > > On Fri, Sep 16, 2016 at 8:53 PM, Jie Yu wrote: > >> containers should be able to operate

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

On Fri, Sep 16, 2016 at 8:53 PM, Jie Yu wrote: > containers should be able to operate even if the parent container goes away > > > This should never happen. One of the nesting feature is: if the parent > container goes way, all its child containers will go away too. The >

Re: Review Request 51920: Modified `recover` to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51920/#review149317 --- Patch looks great! Reviews applied: [51857, 51871, 51920]

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

> > containers should be able to operate even if the parent container goes away This should never happen. One of the nesting feature is: if the parent container goes way, all its child containers will go away too. The containerizer will enforce it. Reason being that during recovery the

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review149316 --- Jacob, can you help rebase? - Guangya Liu On 九月 8, 2016, 10:12

Re: Review Request 45491: Refactored subprocess options [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review149196 --- 3rdparty/libprocess/include/process/subprocess_base.hpp (line

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

> On Sept. 17, 2016, 1 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 816-820 > > > > > > Any reason we need to copy the network files, instead of just using it? > > Do

Re: Review Request 50010: Added example framework for handling inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50010/#review149313 --- Patch looks great! Reviews applied: [50010] Passed command:

Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51621/ --- (Updated 九月 17, 2016, 1:29 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51981: Marke the pid namespace isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51981/ --- (Updated Sept. 17, 2016, 1:26 a.m.) Review request for mesos, Gilbert Song and

Review Request 51981: Marke the pid namespace isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51981/ --- Review request for mesos, Gilbert Song and Kevin Klues. Repository: mesos

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/#review149310 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 51975: Added a virtual function to Isolator to tell is it supports nesting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51975/ --- (Updated Sept. 17, 2016, 12:41 a.m.) Review request for mesos, Benjamin

Re: Review Request 51976: Marked cgroups isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51976/ --- (Updated Sept. 17, 2016, 12:40 a.m.) Review request for mesos, Benjamin

Re: Review Request 51977: Marked the nvidia gpu isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51977/ --- (Updated Sept. 17, 2016, 12:40 a.m.) Review request for mesos, Benjamin

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149308 --- Patch looks great! Reviews applied: [51623] Passed command:

Re: Review Request 51860: Disabled deprecated function warning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51860/#review149306 --- Ship it! Ship It! - Joseph Wu On Sept. 13, 2016, 1:56 p.m.,

Re: Review Request 51861: Removed macro redefinition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51861/#review149307 --- Ship it! Ship It! - Joseph Wu On Sept. 13, 2016, 3 p.m.,

Re: Review Request 51944: Fixed the leaking mounts in the namespaces/pid isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51944/#review149305 --- Could you rebase? - Gilbert Song On Sept. 16, 2016, 1:38 a.m.,

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/#review149304 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 51977: Marked the nvidia gpu isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51977/#review149302 --- Ship it! Ship It! - Gilbert Song On Sept. 16, 2016, 3:46

Re: Review Request 51976: Marked cgroups isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51976/#review149301 --- Ship it! Ship It! - Gilbert Song On Sept. 16, 2016, 3:46

Re: Review Request 51920: Modified `recover` to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51920/ --- (Updated Sept. 16, 2016, 11:36 p.m.) Review request for mesos, Jie Yu, Joseph

Re: Review Request 51975: Added a virtual function to Isolator to tell is it supports nesting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51975/#review149300 --- Ship it! Ship It! - Gilbert Song On Sept. 16, 2016, 3:45

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/ --- (Updated Sept. 16, 2016, 11:31 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51920: Modified `recover` to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51920/ --- (Updated Sept. 16, 2016, 11:11 p.m.) Review request for mesos, Jie Yu, Joseph

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/ --- (Updated Sept. 16, 2016, 11:10 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51683: Avoided resource validation when flatten resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review149299 --- Ship it! src/common/resources.cpp (line 1099)

Re: Review Request 51963: Refactored and simplified the pid namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51963/#review149298 --- Ship it! Ship It! - Joseph Wu On Sept. 16, 2016, 4 p.m.,

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/ --- (Updated Sept. 16, 2016, 11 p.m.) Review request for Gilbert Song, Jie Yu,

Re: Review Request 51963: Refactored and simplified the pid namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51963/ --- (Updated Sept. 16, 2016, 11 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51977: Marked the nvidia gpu isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51977/ --- (Updated Sept. 16, 2016, 10:46 p.m.) Review request for mesos, Benjamin

Re: Review Request 51976: Marked cgroups isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51976/ --- (Updated Sept. 16, 2016, 10:46 p.m.) Review request for mesos, Benjamin

Re: Review Request 51975: Added a virtual function to Isolator to tell is it supports nesting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51975/ --- (Updated Sept. 16, 2016, 10:45 p.m.) Review request for mesos, Benjamin

Re: Review Request 51975: Added a virtual function to Isolator to tell is it supports nesting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51975/#review149293 --- include/mesos/slave/isolator.hpp (line 44)

Review Request 51977: Marked the nvidia gpu isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51977/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues.

Review Request 51976: Marked cgroups isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51976/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues.

Review Request 51975: Added a virtual function to Isolator to tell is it supports nesting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51975/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues.

Re: Review Request 51968: Simplified usage of `os::pagesize` in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51968/#review149292 --- Patch looks great! Reviews applied: [51967, 51968] Passed

Re: Review Request 51963: Refactored and simplified the pid namespace isolator.

> On Sept. 16, 2016, 10:04 p.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp, lines 87-89 > > > > > > Do we care to check for the entire token? AFAIK, imported symbol names > >

Re: Review Request 51963: Refactored and simplified the pid namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51963/#review149287 --- src/slave/containerizer/mesos/isolators/namespaces/pid.cpp

Re: Review Request 51963: Refactored and simplified the pid namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51963/#review149283 --- src/slave/containerizer/mesos/isolators/namespaces/pid.cpp

Re: Review Request 51965: Updated the generic 'cgroups' isolator to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51965/ --- (Updated Sept. 16, 2016, 9:57 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 51966: Updated the 'gpu/nvidia' isolator to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51966/#review149285 --- Ship it! Ship It! - Jie Yu On Sept. 16, 2016, 9:42 p.m.,

Re: Review Request 51965: Updated the generic 'cgroups' isolator to be nested container aware.

> On Sept. 16, 2016, 9:40 p.m., Jie Yu wrote: > > YOu need to update src/Makefile.am Yup. Forgot about that. Thanks. - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 51965: Updated the generic 'cgroups' isolator to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51965/#review149282 --- Ship it! YOu need to update src/Makefile.am - Jie Yu On

Re: Review Request 50010: Added example framework for handling inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50010/ --- (Updated Sept. 16, 2016, 2:35 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50010: Added example framework for handling inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50010/ --- (Updated Sept. 16, 2016, 2:23 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51965: Updated the generic 'cgroups' isolator to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51965/ --- (Updated Sept. 16, 2016, 8:58 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 51966: Updated the 'gpu/nvidia' isolator to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51966/#review149270 --- src/slave/containerizer/mesos/isolators/gpu/isolator.cpp (lines

Re: Review Request 51963: Refactored and simplified the pid namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51963/#review149255 --- Patch looks great! Reviews applied: [51922, 51963] Passed

Re: Review Request 51968: Simplified usage of `os::pagesize` in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51968/#review149250 --- Ship it! LGTM! - Joseph Wu On Sept. 16, 2016, 12:02 p.m.,

Re: Review Request 51967: Changed return type of `os::pagesize` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51967/#review149249 --- Ship it! Confirmed that this doesn't break the Windows build.

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 16, 2016, 7:42 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, line 119 > > > > > > Instead of hand-coded JSON, this should match the TaskGroup proto. See > > `volumes` below for how to do it. Didn't

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149242 --- partial review. src/cli/execute.cpp (line 116)

Re: Review Request 51954: Removed the "strict" flag from the registry operation interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51954/ --- (Updated Sept. 16, 2016, 7:37 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/#review149243 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 51965: Updated the generic 'cgroups' isolator to be nested container aware.

> On Sept. 16, 2016, 7:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 509-514 > > > > > > Can we factor out this into a helper in > >

Re: Review Request 51965: Updated the generic 'cgroups' isolator to be nested container aware.

> On Sept. 16, 2016, 7:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 372 > > > > > > does this compile? No :/ I pushed it prematurely after running the tests, but then

Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

> On Sept. 16, 2016, 7:01 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1935 > > > > > > looks like our style is to add a comment about the unused parameter. > > > >

Re: Review Request 51965: Updated the generic 'cgroups' isolator to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51965/#review149244 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51953/ --- (Updated Sept. 16, 2016, 7:15 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51965: Updated the generic 'cgroups' isolator to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51965/ --- (Updated Sept. 16, 2016, 7:10 p.m.) Review request for mesos, Benjamin Mahler

Review Request 51965: Updated the generic 'cgroups' isolator to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51965/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-6186

Review Request 51966: Updated the 'gpu/nvidia' isolator to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51966/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-6188

Review Request 51968: Simplified usage of `os::pagesize` in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51968/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 51967: Changed return type of `os::pagesize` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51967/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51953/#review149241 --- src/master/master.hpp (line 1935)

Re: Review Request 51954: Removed the "strict" flag from the registry operation interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51954/#review149240 --- src/master/maintenance.cpp (line 45)

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- (Updated Sept. 16, 2016, 6:58 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 51957: Removed "strictness" parameter from RegistrarTest and PartitionTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51957/#review149236 --- Ship it! Ship It! - Vinod Kone On Sept. 16, 2016, 12:59

Re: Review Request 51963: Refactored and simplified the pid namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51963/ --- (Updated Sept. 16, 2016, 6:43 p.m.) Review request for mesos, Benjamin

Re: Review Request 51958: Removed "registry_strict" master command-line flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51958/#review149237 --- src/master/flags.cpp

Review Request 51963: Refactored and simplified the pid namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51963/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues.

Re: Review Request 51956: Squelched GMock warning in MasterTest.RecoveredSlaveCanReregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51956/#review149235 --- Ship it! Ship It! - Vinod Kone On Sept. 16, 2016, 12:59

Re: Review Request 51955: Removed dependency on "registry_strict" in master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51955/#review149234 --- Ship it! Ship It! - Vinod Kone On Sept. 16, 2016, 12:59

Re: Review Request 51954: Removed the "strict" flag from the registry operation interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51954/#review149233 --- Ship it! Ship It! - Vinod Kone On Sept. 16, 2016, 12:59

Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51953/#review149232 --- Fix it, then Ship it! src/master/master.hpp (line 2136)

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For

Re: Review Request 51913: Ignored agent registrations with duplicate agent IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51913/#review149230 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2016, 1:40

Re: Review Request 51869: Export "reserved_resources" in the agent HTTP endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51869/ --- (Updated Sept. 16, 2016, 11:24 a.m.) Review request for mesos, Anindya Sinha

Re: Review Request 51867: Add a member variable for the agent's total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51867/ --- (Updated Sept. 16, 2016, 11:23 a.m.) Review request for mesos, Anindya Sinha

Re: Review Request 51866: Made the agent verify resource compatibility in checkpointResources().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51866/ --- (Updated Sept. 16, 2016, 11:22 a.m.) Review request for mesos, Anindya Sinha

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/#review149224 --- Patch looks great! Reviews applied: [51857, 51871] Passed

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For

Re: Review Request 51948: Waited for `TASK_RUNNING` in `CGROUPS_ROOT_PidNamespaceBackward`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51948/#review149220 --- YOu want to fix the foward test as well.

Re: Review Request 51869: Export "reserved_resources" in the agent HTTP endpoint.

> On Sept. 14, 2016, 5:10 p.m., Anindya Sinha wrote: > > src/slave/http.cpp, line 986 > > > > > > Add this new field `reserved_resources` in `string > > Slave::Http::STATE_HELP()`. Should we punt on this until

Review Request 51920: Modified `recover` to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51920/ --- Review request for mesos. Repository: mesos Description --- Modified

Re: Review Request 51868: Expose full reservation info in the agent's http endpoint.

> On Sept. 14, 2016, 4:56 p.m., Anindya Sinha wrote: > > src/slave/http.cpp, line 986 > > > > > > Add this new field in the output of help, i.e. `string > > Slave::Http::STATE_HELP()`? Should we punt on this until

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/ --- (Updated Sept. 16, 2016, 4:49 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51867: Add a member variable for the agent's total resources.

> On Sept. 14, 2016, 4:56 p.m., Anindya Sinha wrote: > > src/slave/slave.hpp, line 671 > > > > > > nitpik: totalResources is the same as `info.resources()` with > > checkpointed resources applied (and nothing

Re: Review Request 51857: Modified the `prepare` method to be aware of nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/ --- (Updated Sept. 16, 2016, 4:21 p.m.) Review request for Gilbert Song, Jie Yu,

Re: Review Request 51919: Added test to validate capability of SHARED_RESOURCES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51919/#review149206 --- Ship it! Ship It! - Jiang Yan Xu On Sept. 15, 2016, 9:14

Re: Review Request 51958: Removed "registry_strict" master command-line flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51958/#review149203 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Review Request 51956: Squelched GMock warning in MasterTest.RecoveredSlaveCanReregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51956/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5951

Review Request 51957: Removed "strictness" parameter from RegistrarTest and PartitionTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51957/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5951

Review Request 51958: Removed "registry_strict" master command-line flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51958/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5951

  1   2   >