Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review103360 --- src/master/quota_handler.cpp (lines 29 - 31)

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

> On Oct. 20, 2015, 2:55 p.m., Marco Massenzio wrote: > > support/apply-review.sh, line 3 > > > > > > I really dislike this style of conditional running stuff in bash (it > > also violates Google's style, but that's a

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Oct. 20, 2015, 11:04 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Oct. 19, 2015, 10:06 p.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 47 > > > > > > could you please add an @param and explain what `options` is and what > > does it look like? > > (also an @

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 20, 2015, 11:04 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39502/#review103362 --- Patch looks great! Reviews applied: [39502] All tests passed. -

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/#review103357 --- Patch looks great! Reviews applied: [39220] All tests passed. -

Re: Review Request 39507: Check message.empty() in Slave::shutdown before log it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39507/#review103356 --- Ship it! Ship It! - Till Toenshoff On Oct. 21, 2015, 2:39 a.m.,

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review103355 --- 3rdparty/libprocess/src/tests/http_tests.cpp (lines 1391 - 1392) <

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103329 --- src/master/flags.cpp (line 442)

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/ --- (Updated Oct. 20, 2015, 9:02 p.m.) Review request for mesos, Adam B and Dave Le

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

> On Oct. 20, 2015, 3:02 p.m., Adam B wrote: > > support/site-docker/Dockerfile, line 3 > > > > > > Where'd this version number come from? What does it mean? When do we > > increment it? I removed the comment line.

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39360/#review103351 --- Patch looks great! Reviews applied: [39360] All tests passed. -

Re: Review Request 37999: Implemented http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/#review103347 --- 3rdparty/libprocess/src/process.cpp (lines 841 - 842)

Re: Review Request 39494: Added libevent and ssl flags to config docs.

> On Oct. 20, 2015, 9:55 p.m., Joseph Wu wrote: > > Not really related, but do you know if markdown-style tables are supported > > here? > > Greg Mann wrote: > Hmmm... not sure. I seem the document [middleman](https://middlemanapp.com/basics/template_engine_options/), seems should suppor

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103344 --- Patch looks great! Reviews applied: [39452] All tests passed. -

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 20, 2015, 10:03 p.m., Ben Whitehead wrote: > > docs/scheduler-http-api.md, lines 36-48 > > > > > > The proposed grammar I made was based of the ABNF of the HTTP 1.1 spec > > here: http://www.w3.org/Protocol

Review Request 39507: Check message.empty() in Slave::shutdown before log it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39507/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-3769 https://issue

Review Request 39506: Remove unnecessary exec in post-rewrite hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39506/ --- Review request for mesos, Joris Van Remoortere and Vinod Kone. Bugs: MESOS-2953

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/ --- (Updated Oct. 21, 2015, 2:37 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 39494: Added libevent and ssl flags to config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103341 --- Ship it! Ship It! - haosdent huang On Oct. 20, 2015, 9:58 p.m.,

Re: Review Request 39494: Added libevent and ssl flags to config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103340 --- docs/configuration.md (line 1655)

Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review103339 --- src/tests/fault_tolerance_tests.cpp (line 728)

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/#review103337 --- 3rdparty/libprocess/README.md (line 371)

Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review103336 --- 3rdparty/libprocess/src/process.cpp (line 2339)

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review103338 --- Patch looks great! Reviews applied: [39194] All tests passed. -

Re: Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39502/#review103334 --- Ship it! Ship It! - Guangya Liu On 十月 21, 2015, 1:04 a.m., Jose

Review Request 39502: Sync v1/mesos.proto with docker, QoS, and AppC changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39502/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review103331 --- Hey Mandeep, Thanks for taking on this important work! Some high le

Re: Review Request 39496: Clarified libevent config error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39496/#review103332 --- Patch looks great! Reviews applied: [39496] All tests passed. -

Re: Review Request 39457: Document messages in messages.proto.

> On Oct. 20, 2015, 8:23 a.m., Guangya Liu wrote: > > > > Joseph Wu wrote: > For now, I'll keep "agent". I'm fairly certain we refer to agents as > agents now. > > Guangya Liu wrote: > Joseph, do you have any reasons for why not update "slave" to "agent" in > the comments? When I was

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review103327 --- Patch looks great! Reviews applied: [39331] All tests passed. -

Re: Review Request 39457: Document messages in messages.proto.

> On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote: > > > > Joseph Wu wrote: > For now, I'll keep "agent". I'm fairly certain we refer to agents as > agents now. > > Guangya Liu wrote: > Joseph, do you have any reasons for why not update "slave" to "agent" in > the comments? When I was

Re: Review Request 39457: Document messages in messages.proto.

> On Oct. 20, 2015, 8:23 a.m., Guangya Liu wrote: > > > > Joseph Wu wrote: > For now, I'll keep "agent". I'm fairly certain we refer to agents as > agents now. Joseph, do you have any reasons for why not update "slave" to "agent" in the comments? When I was fixing https://reviews.apache.

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review103320 --- src/slave/slave.cpp (line 1938)

Re: Review Request 39493: Added yum update to CentOS 6.6 install docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/#review103321 --- Patch looks great! Reviews applied: [39493] All tests passed. -

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/ --- (Updated Oct. 20, 2015, 10:27 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39494: Added libevent and ssl flags to config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103319 --- Ship it! Ship It! - Gilbert Song On Oct. 20, 2015, 2:58 p.m., G

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

> On Oct. 19, 2015, 2:05 p.m., Cong Wang wrote: > > You probably want to move src/tests/containerizer too? Seems too much things under src/tests/, we may want to rearrange all of them together. - Gilbert --- This is an automatically ge

Re: Review Request 39494: Added libevent and ssl flags to config docs.

> On Oct. 20, 2015, 9:55 p.m., Joseph Wu wrote: > > Not really related, but do you know if markdown-style tables are supported > > here? Hmmm... not sure. > On Oct. 20, 2015, 9:55 p.m., Joseph Wu wrote: > > docs/configuration.md, line 1768 > >

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

> On Oct. 19, 2015, 1:05 p.m., Jie Yu wrote: > > This is great! Thanks! The current patch does not apply, can you do a > > rebase? Thanks. Rebased. - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://revie

Review Request 39497: Fixed quotation of interpolated variables in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3772 https:/

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103314 --- docs/scheduler-http-api.md (lines 29 - 34)

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review103315 --- support/site-docker/Dockerfile (line 1)

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39360/ --- (Updated Oct. 20, 2015, 3 p.m.) Review request for mesos, Ben Mahler, Jie Yu, J

Re: Review Request 39494: Added libevent and ssl flags to config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/ --- (Updated Oct. 20, 2015, 9:58 p.m.) Review request for mesos, haosdent huang, Jo

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Oct. 20, 2015, 9:58 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 39494: Added libevent and ssl flags to config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103313 --- Ship it! Not really related, but do you know if markdown-style tab

Re: Review Request 39494: Added libevent and ssl flags to config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/ --- (Updated Oct. 20, 2015, 9:55 p.m.) Review request for mesos, haosdent huang, Jo

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103312 --- Ship it! I guess you want to retain apply-reviews.sh for backward

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 20, 2015, 9:38 a.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 66 > > > > > > Do we need this line anymore now ? This can be killed in favor of the > > following lines that we added around

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 19, 2015, 3:34 p.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 59 > > > > > > Should we also mention why just encoding one event per chunk won't > > suffice and why we needed this ? > >

Review Request 39496: Clarified libevent config error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39496/ --- Review request for mesos, Joris Van Remoortere and Neil Conway. Bugs: MESOS-350

Review Request 39495: Fix SSL flag cleanup for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39495/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Repositor

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review103309 --- Patch looks great! Reviews applied: [39463, 39325] All tests pass

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Oct. 20, 2015, 9:30 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 20, 2015, 4:38 p.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 66 > > > > > > Do we need this line anymore now ? This can be killed in favor of the > > following lines that we added around

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/ --- (Updated Oct. 20, 2015, 2:22 p.m.) Review request for mesos, Anand Mazumdar, Jo

Re: Review Request 39457: Document messages in messages.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/#review103307 --- Ship it! This looks great Joseph! Can you stay consistent with the

Re: Review Request 39494: Added libevent and ssl flags to config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103306 --- Ship it! Ship It! docs/configuration.md (line 1661)

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/ --- (Updated Oct. 20, 2015, 1:51 p.m.) Review request for mesos, Adam B and Dave Le

Review Request 39494: Added libevent and ssl flags to config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/ --- Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil Conway.

Review Request 39493: Added yum update to CentOS 6.6 install docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/ --- Review request for mesos, Adam B and haosdent huang. Bugs: MESOS-3506 https

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Oct. 20, 2015, 8:45 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39490: Always create non-IP egress filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/#review103304 --- Patch looks great! Reviews applied: [39490] All tests passed. -

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39463/#review103303 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 20, 2015, 8:11

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

> On Oct. 20, 2015, 7 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/owned.hpp, lines 202-203 > > > > > > In libprocess we use `snake_case`. > > You can also consider removing the tempo

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/ --- (Updated Oct. 20, 2015, 8:18 p.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

> On Oct. 20, 2015, 7:13 p.m., Joris Van Remoortere wrote: > > It might be worth splitting out the "logical" changes from the textual. > > As in the dispatch and test position variable. > > Otherwise we should update the commit message as that is not all that is > > happening in this patch. I r

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39463/ --- (Updated Oct. 20, 2015, 8:10 p.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 38978: Add post-rewrite hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38978/#review103299 --- Ship it! Thanks so much haosdent! This will save many people hours

Re: Review Request 39380: Windows: Added support for `stout/flags/flags.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39380/#review103281 --- Ship it! - Joris Van Remoortere On Oct. 19, 2015, 11:27 p.m., Al

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review103283 --- Ship it! I added a patch before this similar to the other "prepare

Re: Review Request 39379: Windows: Prepared agent for Windows changes to `stout/flags/flags.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39379/#review103280 --- Ship it! - Joris Van Remoortere On Oct. 19, 2015, 11:27 p.m., Al

Re: Review Request 39376: Windows: Prepared agent for Windows support of `process/socket.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39376/#review103275 --- Ship it! - Joris Van Remoortere On Oct. 19, 2015, 11:25 p.m., Al

Re: Review Request 39375: Windows: Introduced socket flag interop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39375/#review103272 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/windows

Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39378/#review103279 --- Ship it! - Joris Van Remoortere On Oct. 19, 2015, 11:31 p.m., Al

Re: Review Request 39377: Windows: Add Windows support to `process/socket.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39377/#review103273 --- Ship it! 3rdparty/libprocess/include/process/socket.hpp (lines 30

Re: Review Request 39457: Document messages in messages.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/#review103297 --- Patch looks great! Reviews applied: [39457] All tests passed. -

Re: Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39381/ --- (Updated Oct. 20, 2015, 7:21 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- (Updated Oct. 20, 2015, 7:20 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39381/#review103296 --- This review is no longer necessary. - Joris Van Remoortere On Oc

Re: Review Request 39463: Fixed typos in log messages and comments in replicated log code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39463/#review103293 --- It might be worth splitting out the "logical" changes from the text

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 20, 2015, 7:06 p.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/#review103292 --- Ship it! 3rdparty/libprocess/include/process/owned.hpp (lines 202

Review Request 39490: Always create non-IP egress filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos Descriptio

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review103291 --- Sorry for not finding the below in the first pass ... 3rdparty/li

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39484/#review103288 --- Patch looks great! Reviews applied: [39484] All tests passed. -

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/ --- (Updated Oct. 20, 2015, 10:48 a.m.) Review request for Anand Mazumdar, Jojy Var

Re: Review Request 39457: Document messages in messages.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/ --- (Updated Oct. 20, 2015, 10:26 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39457: Document messages in messages.proto.

> On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote: > > For now, I'll keep "agent". I'm fairly certain we refer to agents as agents now. > On Oct. 20, 2015, 1:23 a.m., Guangya Liu wrote: > > src/messages/messages.proto, lines 132-137 > >

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103276 --- Patch looks great! Reviews applied: [39452] All tests passed. -

Re: Review Request 39211: Check for trailing characters in JSON::parse().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/ --- (Updated Oct. 20, 2015, 5:13 p.m.) Review request for mesos, Adam B and Joseph

Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39484/ --- Review request for mesos, Michael Park and Timothy Chen. Bugs: MESOS-3113 h

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103267 --- Ship it! docs/scheduler-http-api.md (line 36)

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Oct. 20, 2015, 4:34 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 39472: Added the helper container InheritanceTree where nodes inherit values from their ancestors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39472/#review103266 --- Ship it! This code has already been reviewed in this RR: https://

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 19, 2015, 10:34 p.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 44 > > > > > > Nit: Can we just check for `200` here (since the response from > > `Subscribe` should be `200` for a good resp

Re: Review Request 39211: Check for trailing characters in JSON::parse().

> On Oct. 20, 2015, 7:28 a.m., Adam B wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, lines 744-748 > > > > > > I'm getting confused between `last_char` and `end`, since `end` isn't > > really

Re: Review Request 39211: Check for trailing characters in JSON::parse().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/ --- (Updated Oct. 20, 2015, 4:22 p.m.) Review request for mesos, Adam B and Joseph

  1   2   >