://reviews.apache.org/r/43630/diff/
Testing
---
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
rsistentVolume
% = MemoryPressureMesosTest.CGROUPS_ROOT_Statistics
^ = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
& = LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable
* = LinuxFilesystemIsolatorTest.ROOT_MultipleContainers
```
Thanks,
Joseph Wu
/ Maybe a comment here.
Try> slave = StartSlave(detector.get(), ...);
ASSERT_SOME(slave);
```
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/#review12
> On March 3, 2016, 2:15 p.m., Joseph Wu wrote:
> > src/master/contender.hpp, lines 17-18
> > <https://reviews.apache.org/r/44288/diff/3/?file=1279703#file1279703line17>
> >
> > This whole file seems like a pretty substantial change. I'd recommend
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44258/#review122610
---
Ship it!
Ship It!
- Joseph Wu
On March 4, 2016, 5:23 p.m
ache.org/r/43920/#comment184724>
Nit: add one newline preceding this line.
- Joseph Wu
On March 8, 2016, 6:22 a.m., Disha Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
which is used in the
`Slave` destructor, the `detector` is merely passed into the `slave::Slave`
object and left alone afterwards.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
---
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
entVolume
@ = ProvisionerDockerRegistryPullerTest.ROOT_INTERNET_CURL_ShellCommand
# = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
$ = LinuxFilesystemIsolatorTest.ROOT_MultipleContainers
% = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
```
Thanks,
Joseph Wu
bd7b94f3f1fac6705e5bf14c6f6103b540cde56c
Diff: https://reviews.apache.org/r/43629/diff/
Testing
---
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
://reviews.apache.org/r/43630/diff/
Testing
---
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
/diff/
Testing
---
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
> On March 9, 2016, 10:46 a.m., Michael Park wrote:
> > src/tests/cluster.hpp, line 88
> > <https://reviews.apache.org/r/43613/diff/8/?file=1278081#file1278081line88>
> >
> > Why do we need to return `Try>` as opposed to
> > `Try`?
>
> Jos
ommand
# = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
$ = LinuxFilesystemIsolatorTest.ROOT_MultipleContainers
% = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
```
Thanks,
Joseph Wu
posted in the description of MESOS-4831.
Diffs (updated)
-
src/tests/master_maintenance_tests.cpp
3faa8136cf57276295553910319480028f433e4c
Diff: https://reviews.apache.org/r/44537/diff/
Testing
---
make check OSX
Thanks,
Joseph Wu
is no other
> > events after the Clock::settle()?
>
> Joseph Wu wrote:
> This is actually a "best-effort" check rather than a guarantee. It's
> essentially a guard against sending 2 inverse offers right after another (the
> bug you fixed in the previou
Containerizer + Mesos launched via UnifiedContainerizer ???
- Joseph Wu
On March 10, 2016, 5:46 a.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
://reviews.apache.org/r/43630/diff/
Testing
---
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
correctly via `support/site-docker/...`.
docs/ssl.md (line 101)
<https://reviews.apache.org/r/44620/#comment185368>
Tiny nit on the last sentence:
s/the executors container./the executor's container./
- Joseph Wu
On March 11, 2016, 7:21 a.m., Jan Sch
creates a module. Any
configuration for this method should live in the `--modules` flag as a
`Parameters` object.
- `createFromModule` can return the Standalone type, or any other type
(assuming you convert the Zookeeper one into an example module).
Ditto for the detector.
- Joseph
ou've deleted the original
`src/master/detector.*` and `src/master/contender.*` files.
Am I missing something? (The patch here only appears to add new files.)
- Joseph Wu
On March 10, 2016, 3:46 p.m., Anurag Singh wrote:
>
>
185404>
Nit: We usually prefer this spacing:
```
} else if (label.isSome() &&
label.get() == mesos::internal::master::MASTER_INFO_LABEL) {
```
Ditto below.
src/slave/slave.hpp (lines 84 - 85)
<https://reviews.apache.org/r/44288/#comment185408>
er/detectors/standalone.cpp (line 46)
<https://reviews.apache.org/r/44545/#comment185421>
Ditto: Fully qualify this.
src/master/detectors/standalone.cpp (lines 58 - 60)
<https://reviews.apache.org/r/44545/#comment185422>
I don't see where these he
tps://reviews.apache.org/r/44289/#comment185423>
Do you really need these new includes?
- Joseph Wu
On March 10, 2016, 3:46 p.m., Anurag Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://reviews.apache.org/r/44669/#comment185424>
This should look more like:
```
if (type.isNone()) {
// return Standalone.
}
// return Module.
```
src/master/detectors/detector.cpp (line 127)
<https://reviews.apache.org/r/44669/#comment185425>
Ditto here.
tion above.
src/slave/main.cpp (lines 268 - 279)
<https://reviews.apache.org/r/44670/#comment185428>
Ditto code re-organization above.
- Joseph Wu
On March 10, 2016, 3:46 p.m., Anurag Singh wrote:
>
> ---
> This is
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
chain.
Thanks,
Joseph Wu
fa42fb42f2d18060a867ade547cebbdcaead07d4
Diff: https://reviews.apache.org/r/43630/diff/
Testing
---
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
OOT_MultipleContainers
% = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
```
Thanks,
Joseph Wu
0bad45dd1dabecc88fef1ab46e8ea26718070b33
src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c
Diff: https://reviews.apache.org/r/43629/diff/
Testing
---
Tests are run at the end of this review chain.
Thanks,
Joseph Wu
laveRecovery
$ = LinuxFilesystemIsolatorTest.ROOT_MultipleContainers
% = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
```
Thanks,
Joseph Wu
rl/to/long-lived-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```
Thanks,
Joseph Wu
be manually `->appoint()`d later. It
will be better to return an `Error` here instead.
- Joseph Wu
On March 17, 2016, 5:29 p.m., Anurag Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
> On March 18, 2016, 2:05 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/include/process/collect.hpp, line 260
> > <https://reviews.apache.org/r/44547/diff/8/?file=1304700#file1304700line260>
> >
> > Missed a couple extranous spaces here (i.e. `>* >*`)
ated e-mail. To reply, visit:
https://reviews.apache.org/r/43629/#review123863
-------
On March 15, 2016, 1:48 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4
ot;key-value pairs". Since the `Parameters` are
parsed as protobuf, the JSON ends up looking like:
```
"parameters" : [
{
"key" : "foo",
"value" : "bar"
}, {
"key" : "other_key",
you :|
src/master/contender.cpp (line 91)
<https://reviews.apache.org/r/44288/#comment186748>
Another spacing change seems to have snuck in.
- Joseph Wu
On March 17, 2016, 5:29 p.m., Anurag Singh wrote:
>
> ---
)
<https://reviews.apache.org/r/44547/#comment186751>
Missed a couple extranous spaces here (i.e. `>* >*`).
- Joseph Wu
On March 17, 2016, 5:29 p.m., Anurag Singh wrote:
>
> ---
> This is an automatically generated e-
> On March 18, 2016, 2:03 p.m., Joseph Wu wrote:
> > src/master/contender.hpp, lines 16-17
> > <https://reviews.apache.org/r/44543/diff/8/?file=1304655#file1304655line16>
> >
> > You might have missed my earlier comment (because I didn't make it a
tps://reviews.apache.org/r/44543/#comment186755>
You might have missed my earlier comment (because I didn't make it a RB
"issue"). Are these two files deleted somewhere else?
I can't seem to find where you deleted them.
- Joseph Wu
On March 17, 2016, 5:2
built without
`--with-network-isolator`.
- Joseph Wu
On March 16, 2016, 11:05 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
=zk://localhost:2181/mesos
--executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```
Thanks,
Joseph Wu
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45067/#review124377
---
On March 23, 2016, 3:50 p.m., Joseph Wu wrote:
>
> -
I thought that used an internal header. Added it back.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45067/#review124351
---
O
> On March 21, 2016, 7:35 p.m., haosdent huang wrote:
> > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain
> > the binary file correctly after I apply this patch.
> >
> > ```
> > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz
> > b/3rdparty/libproces
--master=zk://localhost:2181/mesos
--executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```
Thanks,
Joseph Wu
metrics
which are "counters".
Diffs
-
src/examples/long_lived_framework.cpp
ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
Diff: https://reviews.apache.org/r/45440/diff/
Testing
---
make check
Also deployed this version on a test cluster. See the previous review.
Thanks,
Joseph Wu
aveID to None() if one
> > executor is lost. isn't it still possible for other executors to be running
> > on that slave? do we want to launch new executors on a different slave in
> > that case?
> >
> > I would recommend to keep track of runnin
epeat=1000 --gtest_break_on_failure
Thanks,
Joseph Wu
---
Also, you can compare an Option without checking `.isSome()`.
- Joseph Wu
On March 29, 2016, 10:35 a.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45749/#review127165
---
Ship it!
Ship It!
- Joseph Wu
On April 5, 2016, 9:01 a.m
hould be ok to do something like this in the destructor:
```
if (containerizer == nullptr) {
return;
}
```
The call to `terminate()` only matters if the `cluster::Slave` is created
successfully.
- Joseph Wu
On April 4, 2016, 10:31 a.m., James
--
On April 4, 2016, 10:31 a.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45689/
> ---
mesos
--executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```
Thanks,
Joseph Wu
Testing
---
make check
Also deployed this version on a test cluster. See the previous review.
Thanks,
Joseph Wu
://localhost:2181/mesos
--executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```
Thanks,
Joseph Wu
)
<https://reviews.apache.org/r/45800/#comment190648>
Would be nice to log something here.
src/examples/long_lived_framework.cpp (line 590)
<https://reviews.apache.org/r/45800/#comment190652>
Does the HTTP scheduler driver initialize glog (like the old scheduler
driver does)
> On April 6, 2016, 10:10 a.m., Joseph Wu wrote:
> > src/examples/long_lived_framework.cpp, lines 217-221
> > <https://reviews.apache.org/r/45800/diff/1/?file=1327282#file1327282line217>
> >
> > Would be nice to log something here.
>
> Anand Mazumdar w
ds in a non-libprocess-process class since they are
called via `defer` by the gauges.
- Joseph
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45440/#review127404
---
=zk://localhost:2181/mesos
--executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```
Thanks,
Joseph Wu
)
-
src/examples/long_lived_framework.cpp
ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
Diff: https://reviews.apache.org/r/45440/diff/
Testing
---
make check
Also deployed this version on a test cluster. See the previous review.
Thanks,
Joseph Wu
Testing
---
make check
Also deployed this version on a test cluster. See the previous review.
Thanks,
Joseph Wu
this on the master node on a Mesos cluster:
```
./long-lived-framework --master=zk://localhost:2181/mesos
--executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```
Thanks,
Joseph Wu
Testing
---
make check
Also deployed this version on a test cluster. See the previous review.
Thanks,
Joseph Wu
://localhost:2181/mesos
--executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```
Thanks,
Joseph Wu
not OOM:
./balloon-framework --master=zk://localhost:2181/mesos --checkpoint
--balloon_limit=256MB --task_memory=256MB
--executor_uri="https://s3.amazonaws.com/url/to/balloon-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
```
Thanks,
Joseph Wu
`
Thanks,
Joseph Wu
g you might want to add gauge type metrics to this endpoint
> > in the future?
> >
> > More importantly, I didn't understand why you need to add a special
> > endpoint for these 2 counters. Why can't they just be part of the
> > "/metrics/snapsho
scheduler.
Diffs
-
src/examples/long_lived_framework.cpp
ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
Diff: https://reviews.apache.org/r/45910/diff/
Testing
---
make check
Deployed on a test cluster (see the first review in the chain.)
Thanks,
Joseph Wu
e 99)
<https://reviews.apache.org/r/45926/#comment191206>
s/shell command, an/shell command, or an/
src/cli/execute.cpp (line 108)
<https://reviews.apache.org/r/45926/#comment191208>
This format (`/path/to/file`) is deprecated, so I'd vote for removing it
from the descriptio
` output to use `LOG(INFO)`.
- Joseph Wu
On April 8, 2016, 5:39 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
tps://reviews.apache.org/r/45927/#comment191209>
Given how these flags are pretty much all passed into the
`CommandScheduler`, can you add another patch that changes the constructor
signature to something like:
```
Command(const Flags& _flags)
: flags(flags)
{ ... }
```
- Jose
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/45910/#review127845
-----------
On April 8, 2016, 1:29 p.m., Joseph Wu wrote:
>
> ---
>
on a test cluster (see the first review in the chain.)
Thanks,
Joseph Wu
://reviews.apache.org/r/45604/diff/
Testing
---
```
make check
sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
```
Thanks,
Joseph Wu
sk_memory=256MB
--executor_uri="https://s3.amazonaws.com/url/to/balloon-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
```
Thanks,
Joseph Wu
15c45612b777edaf97aea9b953439d4ad56920f3
src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d
Diff: https://reviews.apache.org/r/45604/diff/
Testing
---
```
make check
sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
```
Thanks,
Joseph Wu
ework"
```
Thanks,
Joseph Wu
1/mesos --checkpoint
--balloon_limit=256MB --task_memory=256MB
--executor_uri="https://s3.amazonaws.com/url/to/balloon-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
```
Thanks,
Joseph Wu
> On April 8, 2016, 11:10 a.m., Joseph Wu wrote:
> > src/cli/execute.cpp, lines 97-100
> > <https://reviews.apache.org/r/45926/diff/1/?file=1337076#file1337076line97>
> >
> > Might be nice to note that this is ignored if `flags.shell` is false.
>
> Ale
.
- Joseph Wu
On April 11, 2016, 9:55 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46044/
> ---
>
> (Updated April 11, 2016, 12:01 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
idea of moving everything to 'flag'. A `CommandScheduler` object should
> > have some properties like `command`, `master`, `name`. Others like 'image'
> > information should be moved to its own class/struct (say `ContainerInfo`).
> > Just my 2 cents.
>
&g
hould move that helper (and possibly others) into public
headers?
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/#review128539
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45991/#review128954
---
Ship it!
Ship It!
- Joseph Wu
On April 10, 2016, 6:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45995/#review128955
---
Ship it!
Ship It!
- Joseph Wu
On April 10, 2016, 6:39 p.m
(lines 489 - 490)
<https://reviews.apache.org/r/45996/#comment192409>
This is now effectively managed by the `ProcessManager`, so you could bring
it into the `ProcessManager` 's scope (which would still be global).
- Joseph Wu
On April 10, 2016, 6:41 p.m., Neil C
x27;s reference to the global metrics singleton.
Diffs (updated)
-
src/tests/scheduler_driver_tests.cpp 217185780e3576faf633dd9629ae93a275fac284
Diff: https://reviews.apache.org/r/40411/diff/
Testing
---
Tests done in a subsequent review.
Thanks,
Joseph Wu
ke check` (libev)
`make check` (--enable-libevent --enable-ssl)
Thanks,
Joseph Wu
://reviews.apache.org/r/40268/diff/
Testing
---
Some test cleanup issues were uncovered by this change; fixed here:
https://reviews.apache.org/r/40453/
Thanks,
Joseph Wu
3rdparty/libprocess/src/process.cpp afeddec20495bb9621c3e26b0d425c9419654739
3rdparty/libprocess/src/reap.cpp 110386842d5eeccfbc4e48bfca88d79a9d087fb0
Diff: https://reviews.apache.org/r/40413/diff/
Testing
---
Tests done in a subsequent review.
Thanks,
Joseph Wu
://reviews.apache.org/r/40410/diff/
Testing
---
Tests done in a subsequent review.
Thanks,
Joseph Wu
::reinitialize` in several tests, such as `HTTPTest`,
`MetricsTest`, and `ReapTest` can called `process::reinitialize` before and
after tests. Confirmed that this did not have side effects on other tests (See
https://reviews.apache.org/r/40453/ ).
Thanks,
Joseph Wu
in point).
Note: This change was moved into a prior commit in the chain.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40266/#review108650
-------
On April 14, 2016, 1:28 p.m., Joseph Wu
15c45612b777edaf97aea9b953439d4ad56920f3
src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d
Diff: https://reviews.apache.org/r/45604/diff/
Testing
---
```
make check
sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
```
Thank
--task_memory=256MB
--executor_uri="https://s3.amazonaws.com/url/to/balloon-executor";
--executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
```
Thanks,
Joseph Wu
or memory (--executor_memory).
> >
> > Also s/balloon_limit/executor_memory_usage/ for clarity.
>
> Joseph Wu wrote:
> I did it this way to maintain the existing behavior (which I agree
> doesn't make very much sense).
Note: I renamed to
> On April 14, 2016, 12:10 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 489-490
> > <https://reviews.apache.org/r/45996/diff/1/?file=1338532#file1338532line489>
> >
> > This is now effectively managed by the `ProcessManager`, so
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46375/#review129614
---
Ship it!
Ship It!
- Joseph Wu
On April 19, 2016, 12:51 a.m
101 - 200 of 2923 matches
Mail list logo
