fd4de4d0d9c3e9617408022d10b5e161bdc911e1
Diff: https://reviews.apache.org/r/36425/diff/
Testing
---
make check
Thanks,
Marco Massenzio
://reviews.apache.org/r/36425/#review91496
---
On July 13, 2015, 4:35 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
On July 13, 2015, 8:18 p.m., Benjamin Hindman wrote:
include/mesos/mesos.proto, lines 108-110
https://reviews.apache.org/r/36450/diff/1/?file=1009619#file1009619line108
Why not also add an Endpoint message to capture this part? Or a URL/I?
message Endpoint {
)
https://reviews.apache.org/r/36450/#comment144966
nit: I think you need an extra space between ; and /
- Marco Massenzio
On July 13, 2015, 5:55 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit
/
---
(Updated July 9, 2015, 10:34 p.m.)
Review request for mesos, Anand Mazumdar, Benjamin Hindman, Ben Mahler, Marco
Massenzio, and Vinod Kone.
Bugs: MESOS-2860
https://issues.apache.org/jira/browse/MESOS-2860
Repository
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91242
---
Ship it!
Ship It!
- Marco Massenzio
On July 9, 2015, 10:34 p.m
On July 9, 2015, 10:24 p.m., Marco Massenzio wrote:
src/master/http.cpp, lines 311-316
https://reviews.apache.org/r/36318/diff/2/?file=1003768#file1003768line311
unless you know for a fact that none of this will be `None()` you
*must* check, or this will crash Mesos: hence
- Marco Massenzio
On July 9, 2015, 6:49 p.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36318/
---
(Updated
On July 8, 2015, 4:35 p.m., Marco Massenzio wrote:
Thanks for doing this!
It seems to me that this is just a 'prettified' form of the `--help`
output? perhaps we could automate its generation, removing the need of
manually double-checking.
Just a thought.
Adam B wrote
* that the singular form is *not* allowed (`1mins`
in the default) but it would be nice to spell it out for the unwary
- Marco Massenzio
On July 8, 2015, 8:18 a.m., Adam B wrote:
---
This is an automatically generated e-mail. To reply
On July 7, 2015, 9:32 p.m., Marco Massenzio wrote:
support/post-reviews.py, line 173
https://reviews.apache.org/r/35777/diff/2/?file=1001308#file1001308line173
note that here you will be printing the whole commit message, which in
this case is not appropriate.
I
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35777/
---
(Updated July 7, 2015, 3:19 p.m.)
Review request for mesos, Benjamin Hindman, Marco Massenzio, and Till
Toenshoff
these
constants aren't adding value (CLOSE - close) for the added indirection,
and our existing code doesn't follow this pattern.
(b) Pull out the change to src/tests/mesos.hpp, since it is independent.
Marco Massenzio wrote:
All good.
However, I beg to disagree on this point
:
...
print ...format(message[pos:])
```
should make the error message clearer.
- Marco Massenzio
On July 7, 2015, 3:19 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On July 6, 2015, 6:06 p.m., Joseph Wu wrote:
Can you comment on the use of the `@copydoc` tag?
I used it in the associated review (36141), but it isn't mentioned in the
Doxygen style guide.
I am somewhat hesitant about us trying to whitelist *everything* that is
allowed.
I much prefer
/
---
(Updated July 2, 2015, 8:16 a.m.)
Review request for mesos, Anand Mazumdar, Benjamin Hindman, Ben Mahler, Marco
Massenzio, and Vinod Kone.
Bugs: MESOS-2860
https://issues.apache.org/jira/browse/MESOS-2860
Repository: mesos-incubating
` features?
I personally would prefer the use of alpha / beta as more standard in
industry parlance than experimental (which makes it sound more like a science
project :) )
- Marco Massenzio
On July 2, 2015, 11:47 p.m., Adam B wrote
with our coding style
(spacing, indentation, enclosing linkable to classes in back-ticks ` `, etc.)
but I'm not familiar enough with it to really comment.
And this is in any case more documentation than 90% of our codebase, so... yay!
:)
- Marco Massenzio
On July 2, 2015, 6:01 p.m., Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36036/#review89991
---
On June 30, 2015, 11:23 p.m., Marco Massenzio wrote
/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22
Diff: https://reviews.apache.org/r/36036/diff/
Testing
---
make check
Thanks,
Marco Massenzio
e-mail. To reply, visit:
https://reviews.apache.org/r/36036/#review90024
---
On June 30, 2015, 11:23 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail
- should
these be `userTime` or something?
(also, if they are time durations, please pre-pend the unit: `userTimeSec`)
- Marco Massenzio
On July 1, 2015, 9:38 p.m., Jojy Varghese wrote:
---
This is an automatically generated e-mail
the URL.
Looks to me like a better User Experience.
- Marco Massenzio
On July 1, 2015, 3:52 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35777
---
On July 1, 2015, 12:32 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/tests/cgroups_tests.cpp, line 1192
https://reviews.apache.org/r/36106/diff/1/?file=997648#file997648line1192
Add using to the top of the tests
Jojy Varghese wrote:
Since this is an alias (typedef) and scoped for the
On July 1, 2015, 9:54 p.m., Marco Massenzio wrote:
src/linux/cgroups.cpp, line 2002
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2002
and, in any event, the variables should have a meaningful name - should
these be `userTime` or something?
(also
://reviews.apache.org/r/36040/#comment143185
I have the impression your change introduced tabs?
(may be an RB artifact, though)
can you please add `is` (header *is* not...)
- Marco Massenzio
On June 30, 2015, 9:06 a.m., Isabel Jimenez wrote
, 2015, 7:30 p.m.)
Review request for mesos, Anand Mazumdar, Benjamin Hindman, Ben Mahler, Marco
Massenzio, and Vinod Kone.
Bugs: MESOS-2860
https://issues.apache.org/jira/browse/MESOS-2860
Repository: mesos-incubating
Description
---
Adding a call route with HTTP
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/linux/cgroups.cpp, line 2060
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2060
Why add trailing underscore?
Jojy Varghese wrote:
As a member variable(is accepted according to mesos coding style
:
https://reviews.apache.org/r/36036/#review89870
---
On June 30, 2015, 6:28 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
```
Diffs
-
3rdparty/libprocess/src/process.cpp d99947c1598c43c47c88ef3e8038081855f0d1dc
Diff: https://reviews.apache.org/r/36061/diff/
Testing
---
make check
and manual failing the DNS
Thanks,
Marco Massenzio
---
make check
and manual failing the DNS
Thanks,
Marco Massenzio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36036/#review89933
---
On June 30, 2015, 6:28 a.m., Marco Massenzio wrote
message)?
that would be a better check, so we won't fail tests just because we fix
typos in messages :)
- Marco Massenzio
On June 30, 2015, 9:07 a.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply
d99947c1598c43c47c88ef3e8038081855f0d1dc
Diff: https://reviews.apache.org/r/36061/diff/
Testing
---
make check
and manual failing the DNS
Thanks,
Marco Massenzio
962455cc368c6e5405599d6565660d4c3fd0fc22
Diff: https://reviews.apache.org/r/36036/diff/
Testing
---
make check
Thanks,
Marco Massenzio
., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/
---
(Updated June 30, 2015, 6:41 p.m.)
Review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35939/#review89543
---
Ship it!
Ship It!
- Marco Massenzio
On June 26, 2015, 6:58 p.m
---
On June 24, 2015, 6:01 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815
across other tests, maybe?
Finally, while it may all be very obvious to you :) I would suggest to add
some explanation output on some of the failures, so that in future people
less-experienced will be able to more easily analyze failures, should changes
induce breakages.
- Marco Massenzio
On June 25, 2015, 8:10 a.m., Marco Massenzio wrote:
Hey Paul, thanks for doing this!
In case you are interested, I have submitted a couple of Pull Requests to
the Google folks (without much success) but I've also
[forked](https://github.com/massenz/styleguide) `styleguide` and have
://reviews.apache.org/r/35856/#comment142061
Same comment as the other review :)
Great test, worth maybe factoring some of the common functionality in a
helper class?
- Marco Massenzio
On June 25, 2015, 12:29 a.m., Vinod Kone wrote
/master) branch contains
all the latest additions and it works - the only remaining thing for me is to
detect multi-line method declaration (so that cpplint does not complain about
the { on the newline).
Contributions welcome :)
- Marco Massenzio
On June 25, 2015, 4:29 a.m., Paul Brett wrote
://reviews.apache.org/r/35855/#comment141920
could this be more specific (exactly one)?
- Marco Massenzio
On June 25, 2015, 1:11 a.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
wonder whether the recursive behavior is the desired one here?
it risks making data/resources (in subdirs, created by different users)
unavailable for processes/tasks that are run.
We should probably also LOG(INFO) here as it may help when debugging
permission denied issues.
- Marco
---
make check
Thanks,
Marco Massenzio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/#review89122
---
On June 24, 2015, 1:15 a.m., Marco Massenzio wrote
., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/
---
(Updated June 24, 2015, 1:15 a.m.)
Review request
/network-monitoring.md (line 48)
https://reviews.apache.org/r/35763/#comment141543
please format as a markdown URL:
please see [MESOS-1856](https://issues.apache.org/jira/browse/MESOS-1856)
to be consistent with the rest of the document.
- Marco Massenzio
On June 23, 2015
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88925
---
Can you please add one of the committers as a reviewer?
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35565/#review88681
---
Ship it!
Ship It!
- Marco Massenzio
On June 20, 2015, 7:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35695/#review88680
---
Ship it!
Ship It!
- Marco Massenzio
On June 20, 2015, 7:14 p.m
57cf8fbeff203847b5b5442f6c78ca9c09bcc66d
src/master/constants.cpp 8c7174a9940bd332832bf85d81ab13cf11836dd0
src/master/detector.cpp 5700711771480f4e5da88e60657618c955f10048
Diff: https://reviews.apache.org/r/35571/diff/
Testing
---
make check
Thanks,
Marco Massenzio
57cf8fbeff203847b5b5442f6c78ca9c09bcc66d
src/master/constants.cpp 8c7174a9940bd332832bf85d81ab13cf11836dd0
src/master/detector.cpp 5700711771480f4e5da88e60657618c955f10048
Diff: https://reviews.apache.org/r/35571/diff/
Testing
---
make check
Thanks,
Marco Massenzio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88276
---
On June 17, 2015, 6:18 p.m., Marco Massenzio wrote
/constants.hpp 57cf8fbeff203847b5b5442f6c78ca9c09bcc66d
src/master/constants.cpp 8c7174a9940bd332832bf85d81ab13cf11836dd0
src/master/detector.cpp 5700711771480f4e5da88e60657618c955f10048
Diff: https://reviews.apache.org/r/35571/diff/
Testing
---
make check
Thanks,
Marco Massenzio
8c7174a9940bd332832bf85d81ab13cf11836dd0
src/master/detector.cpp 5700711771480f4e5da88e60657618c955f10048
Diff: https://reviews.apache.org/r/35571/diff/
Testing
---
make check
Thanks,
Marco Massenzio
---
On June 17, 2015, 11:40 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571
that I like the
new version better (that is: assuming that the new and improved version is
the bottom one?).
Can you please make the description clearer by stating: `will be` v. `is now`?
Thanks!
- Marco Massenzio
On June 16, 2015, 12:43 p.m., Alexander Rojas wrote
---
This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
Thanks,
Marco Massenzio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87539
---
On June 3, 2015, 6:44 a.m., Marco Massenzio wrote
.
Repository: mesos
Description
---
Added Uber to the Powered-by-Mesos page
Diffs
-
docs/powered-by-mesos.md 0ee763ffe32e6667e4ba708dd275d9f1b5116815
Diff: https://reviews.apache.org/r/35341/diff/
Testing
---
Thanks,
Marco Massenzio
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments
---
On June 4, 2015, 4:27 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35043
/34687/#review86819
---
On June 3, 2015, 9 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34687
suggest and we would like to move forward and make that change later. Is that
OK with you?
Marco Massenzio wrote:
Hey Vinod - as Niklas pointed out, we have invested a significant amount
of time on this one, including the manual testing I've done (as summarized on
MESOS-2304) and I'd
/tests/common/parse_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34687/diff/
Testing
---
make check
Thanks,
Marco Massenzio
On June 2, 2015, 3:38 p.m., Marco Massenzio wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 184
https://reviews.apache.org/r/34943/diff/1/?file=976658#file976658line184
too much choice, IMO - there are (if I counted them right) 8 different
`add
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review86667
---
On June 3, 2015, 6:44 a.m., Marco Massenzio wrote
generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review86360
---
On June 3, 2015, 6:44 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34195/#review86258
---
On May 29, 2015, 1:10 a.m., Marco Massenzio wrote
you're just calling a normal constructor (i.e., not a
constructor that takes an std::initializer_list or an implicit constructor
that just sets the fields of the object).
Finally, this can be simplified:
JSON::Object json(JSON::Protobuf(masterInfo));
Marco Massenzio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34687/#review86176
---
On May 31, 2015, 2:58 a.m., Marco Massenzio wrote
were addressed
in the new diff: is something missing?
Thanks!
- Marco Massenzio
On June 2, 2015, 2:03 p.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33824
,
Marco Massenzio
};
```
- Marco Massenzio
On June 2, 2015, 2:43 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34943
, 2015, 2:46 p.m.)
Review request for mesos and Marco Massenzio.
Repository: mesos
Description
---
This is one possible way of handling processing --help. Also, this is missing
a test.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
/TestPersistentVolumeFramework.java
https://reviews.apache.org/r/9/#comment138044
if (master.isEmpty()) ...
- Marco Massenzio
On May 18, 2015, 4:42 p.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments
/r/34193/#review85843
---
On May 29, 2015, 12:51 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34193
/http_tests.cpp f087b2313a13c3199b70b3d7feb728e1449a52e7
src/tests/common/parse_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34687/diff/
Testing
---
make check
Thanks,
Marco Massenzio
) underneath the DCOS UI behind a
reverse proxy, so that `http://dcos_host:port/mesos` shows the Mesos
UI, and `http://dcos_host:port/mesos/help/foo` should show the
appropriate help path.
How did you test this? Please fill out the Testing section
appropriately.
Marco Massenzio wrote
8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098
src/tests/common/http_tests.cpp f087b2313a13c3199b70b3d7feb728e1449a52e7
src/tests/common/parse_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34687/diff/
Testing
---
make check
Thanks,
Marco Massenzio
weeks since last update.
If you are planning to resubmit as a different patch, can you please close this
one?
thanks!
- Marco Massenzio
On May 4, 2015, 10:21 p.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail
---
On May 26, 2015, 8:47 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34193
: if you are happy with
this patch, could you please help him out to commit?
Thanks!
- Marco Massenzio
On May 21, 2015, 1:11 p.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
request for mesos, Adam B, Marco Massenzio, and Michael Lunøe.
Bugs: MESOS-2748
https://issues.apache.org/jira/browse/MESOS-2748
Repository: mesos
Description
---
Use relative url in /help generated links point
Diffs
-
3rdparty/libprocess/src/help.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34655/#review85592
---
Ship it!
Ship It!
- Marco Massenzio
On May 28, 2015, 7:54 a.m
e3fff5d60c0468c0d258f2bb301efc1309c071b0
src/usage/main.cpp 97f55e938dc7678f8331970d8953d09218f70902
Diff: https://reviews.apache.org/r/34195/diff/
Testing
---
make check
**NOTE** this fixes completely the chained changes from 34193 and makes all the
tests pass.
Thanks,
Marco Massenzio
/main.cpp 97f55e938dc7678f8331970d8953d09218f70902
Diff: https://reviews.apache.org/r/34195/diff/
Testing
---
make check
**NOTE** this fixes completely the chained changes from 34193 and makes all the
tests pass.
Thanks,
Marco Massenzio
---
On May 28, 2015, 10:06 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34195
On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote:
src/common/protobuf_utils.hpp, line 83
https://reviews.apache.org/r/34687/diff/1/?file=972329#file972329line83
Shouldn't parse() go in
https://github.com/apache/mesos/blob/master/src/common/parse.hpp?
Marco Massenzio wrote
,
Marco Massenzio
everywhere to `masterInfo` - awfully sorry about that.
On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote:
src/tests/common/protobuf_utils_tests.cpp, line 23
https://reviews.apache.org/r/34687/diff/1/?file=972331#file972331line23
This (and standard c includes) goes first
Marco Massenzio
for net::IP?
Marco Massenzio wrote:
haven't come across it, and, trust me, I've looked for better ways of
getting a string out of a net::IP object
would it be in the net::IP class, or tucked somewhere else safe?
sweet - found it!
- Marco
/#comment137038
Apache Mesos Docs, maybe?
- Marco Massenzio
On May 27, 2015, 6:38 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34724
.
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34687/#review85311
---
On May 26, 2015, 11:54 p.m., Marco Massenzio wrote
/protobuf_utils.hpp 9ecd2343689252af1b997392ec367d14d55ac7d1
src/common/protobuf_utils.cpp bd6996159e73bf63bb7c2fa3a28def6a2be92b1b
src/tests/common/protobuf_utils_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34687/diff/
Testing
---
make check
Thanks,
Marco Massenzio
.
Thanks,
Marco Massenzio
the
tests pass.
Thanks,
Marco Massenzio
201 - 300 of 320 matches
Mail list logo
