Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

2018-10-12 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/#review209509 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 12, 2018

Re: Review Request 68899: Updated the MesosCon 2018 location.

2018-10-02 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68899/#review209157 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 2, 2018

Re: Review Request 68826: Fixed bug in `verify-reviews` due to mismatched types.

2018-09-24 Thread Andrew Schwartzmeyer
/ Testing --- Thanks, Andrew Schwartzmeyer

Review Request 68826: Fixed bug in `verify-reviews` due to mismatched types.

2018-09-24 Thread Andrew Schwartzmeyer
that the logic afterwards only has one type to deal with. Diffs - support/verify-reviews.py 72b7eb5b9baaf8eaa352b55dad55e62881d87323 Diff: https://reviews.apache.org/r/68826/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.

2018-09-14 Thread Andrew Schwartzmeyer
) <https://reviews.apache.org/r/68723/#comment292751> Up to your use of it if you just want silence here instead. - Andrew Schwartzmeyer On Sept. 14, 2018, 12:39 p.m., Andrew Schwartzmeyer wrote: > > --- > This is a

Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.

2018-09-14 Thread Andrew Schwartzmeyer
ce9a35962e82e88648a19d0e8772ba0217ef229d Diff: https://reviews.apache.org/r/68723/diff/1/ Testing --- Tested with `--skip-verify` on the CLI; argument is no longer required. Thanks, Andrew Schwartzmeyer

Re: Review Request 68625: Added 'MesosCon 2018 CFP is now closed!' blog post.

2018-09-04 Thread Andrew Schwartzmeyer
is-now-closed.md PRE-CREATION Diff: https://reviews.apache.org/r/68625/diff/2/ Changes: https://reviews.apache.org/r/68625/diff/1-2/ Testing --- Thanks, Andrew Schwartzmeyer

Review Request 68625: Added 'MesosCon 2018 CFP is now closed!' blog post.

2018-09-04 Thread Andrew Schwartzmeyer
Description --- Added 'MesosCon 2018 CFP is now closed!' blog post. Diffs - site/source/blog/2018-09-05-mesoscon-2018-cfp-is-now-closed.md PRE-CREATION Diff: https://reviews.apache.org/r/68625/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 68420: Added /files API test for reserved query characters.

2018-09-04 Thread Andrew Schwartzmeyer
er for query parameters `%` to > > // ensure it is encoded and decoded correctly. > > const string filename = "foo%3Abar"; > > ``` > > > > And not do line 334 as it's irrelevant to this test > > Andrew Schwartzmeyer wr

Re: Review Request 68619: Defaulted support scripts to Python 3.

2018-09-04 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68619/#review208316 --- Ship it! Ship It! - Andrew Schwartzmeyer On Sept. 4, 2018

Re: Review Request 68420: Added /files API test for reserved query characters.

2018-08-28 Thread Andrew Schwartzmeyer
er for query parameters `%` to > > // ensure it is encoded and decoded correctly. > > const string filename = "foo%3Abar"; > > ``` > > > > And not do line 334 as it's irrelevant to this test > > Andrew Schwartzmeyer wr

Re: Review Request 68420: Added /files API test for reserved query characters.

2018-08-28 Thread Andrew Schwartzmeyer
) - src/tests/files_tests.cpp d09279077ec704167991933349ee943ab44d0aa9 Diff: https://reviews.apache.org/r/68420/diff/2/ Changes: https://reviews.apache.org/r/68420/diff/1-2/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.

2018-08-27 Thread Andrew Schwartzmeyer
` and `os::Exec` (which will not be implemented on Windows). Diffs (updated) - 3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c Diff: https://reviews.apache.org/r/68532/diff/3/ Changes: https://reviews.apache.org/r/68532/diff/2-3/ Testing --- Thanks, A

Re: Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.

2018-08-27 Thread Andrew Schwartzmeyer
d `os::Exec` (which will not be implemented on Windows). Diffs (updated) - 3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c Diff: https://reviews.apache.org/r/68532/diff/2/ Changes: https://reviews.apache.org/r/68532/diff/1-2/ Testing --- Thanks, A

Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.

2018-08-27 Thread Andrew Schwartzmeyer
Diffs - 3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c Diff: https://reviews.apache.org/r/68532/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Review Request 68531: Windows: Ported `OsTest.Environment`.

2018-08-27 Thread Andrew Schwartzmeyer
/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c Diff: https://reviews.apache.org/r/68531/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Review Request 68530: Windows: Enabled `RemoveWithContinueOnError` test.

2018-08-27 Thread Andrew Schwartzmeyer
rg/r/68530/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Review Request 68529: Windows: Added notes for permanently disabled tests.

2018-08-27 Thread Andrew Schwartzmeyer
, Andrew Schwartzmeyer

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

2018-08-24 Thread Andrew Schwartzmeyer
--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68454/ > --- > > (Updated Aug. 23, 2018, 3:44 p.m.) > > > Review request for mesos, Akash Gupta, Andrew S

Re: Review Request 68420: Added regression test for encoded queries over the `/files` API.

2018-08-23 Thread Andrew Schwartzmeyer
334 is relevant to this test: it's demonstrating that the query can be erroneously decoded too many times. - Andrew ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68420/#review207830 --

Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`.

2018-08-23 Thread Andrew Schwartzmeyer
"docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos" ``` Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest. Thanks, Andrew Schwartzmeyer

Re: Review Request 68422: Added regression test for `http::internal::encode(Request)`.

2018-08-23 Thread Andrew Schwartzmeyer
y parameter is going over the wire unencoded. Diffs (updated) - 3rdparty/libprocess/src/tests/http_tests.cpp 89d3bb2f91efe97591fe3f43e947413cf8b61f8c Diff: https://reviews.apache.org/r/68422/diff/2/ Changes: https://reviews.apache.org/r/68422/diff/1-2/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 68319: Put binaries into root folder in libprocess.

2018-08-20 Thread Andrew Schwartzmeyer
> On Aug. 20, 2018, 11:18 a.m., Andrew Schwartzmeyer wrote: > > I have to ask: why? I've personally thought it would be nicer to remove > > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add > > it to stout and libprocess? > > Benjamin

Re: Review Request 68329: Windows: Made `libwinio` the default option.

2018-08-20 Thread Andrew Schwartzmeyer
/libprocess/src/CMakeLists.txt 19fa9809c2298ea68649702b94a0c75d806caba3 3rdparty/libprocess/src/tests/CMakeLists.txt a03a77eb5e289b4daac0bbd414dc17c8acc848dc Diff: https://reviews.apache.org/r/68329/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 68398: Added `fs::used` helper API to stout.

2018-08-20 Thread Andrew Schwartzmeyer
) <https://reviews.apache.org/r/68398/#comment291076> `UNIMPLEMENTED()`. Should cause a compiler warning if used in a code-path on Windows. - Andrew Schwartzmeyer On Aug. 16, 2018, 4:51 p.m., James Peach wrote: > > ---

Re: Review Request 68396: Updated the ::pipe() system calls to pipe2 in posix subprocess.

2018-08-20 Thread Andrew Schwartzmeyer
hen (after I use `at`) it'll look just like windows/subprocess.cpp! Actually... it would end up identical save for the arguments sent to `os::pipe`. Time for some consolidation? - Andrew Schwartzmeyer On Aug. 17, 2018, 3:36 p.

Re: Review Request 68319: Put binaries into root folder in libprocess.

2018-08-20 Thread Andrew Schwartzmeyer
> On Aug. 20, 2018, 11:18 a.m., Andrew Schwartzmeyer wrote: > > I have to ask: why? I've personally thought it would be nicer to remove > > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add > > it to stout and libprocess? > > Benjamin

Re: Review Request 68429: Fixed paths to 3rdparty test executable under Windows.

2018-08-20 Thread Andrew Schwartzmeyer
68429/#review207612 --- On Aug. 20, 2018, 4:56 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.or

Re: Review Request 68319: Put binaries into root folder in libprocess.

2018-08-20 Thread Andrew Schwartzmeyer
er to remove this rather unexpected logic (from a CMake standpoint) from Mesos. Why add it to stout and libprocess? - Andrew Schwartzmeyer On Aug. 20, 2018, 2:53 a.m., Benjamin Bannier wrote: > > --- > This is an automatically ge

Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`.

2018-08-20 Thread Andrew Schwartzmeyer
:05.214131 4480 hierarchical.cpp:637] Removed agent > > 2ca394f1-f5a9-4188-add6-1beb8e603e46-S0 > > I0818 02:22:05.592200 5000 process.cpp:926] Stopped the socket accept loop > > ``` These are expected due to long path issues on the host. We could (a) change `

Review Request 68420: Added regression test for encoded queries over the `/files` API.

2018-08-17 Thread Andrew Schwartzmeyer
this breaks something such as the `files` server. Diffs - src/tests/files_tests.cpp d09279077ec704167991933349ee943ab44d0aa9 Diff: https://reviews.apache.org/r/68420/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 68375: Fixed encoding behavior of `http::internal::encode(Request)`.

2018-08-17 Thread Andrew Schwartzmeyer
, Andrew Schwartzmeyer

Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`.

2018-08-17 Thread Andrew Schwartzmeyer
ontainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos" ``` Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest. Thanks, Andrew Schwartzmeyer

Review Request 68422: Added regression test for `http::internal::encode(Request)`.

2018-08-17 Thread Andrew Schwartzmeyer
61f8c Diff: https://reviews.apache.org/r/68422/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 68374: Windows: Fixed a bug when `taskID` contains a `:`.

2018-08-17 Thread Andrew Schwartzmeyer
e7cf84993c74cf6da7fe22d5112e86e039780287 src/tests/paths_tests.cpp 4808402f789ebc783b308c03b8e412ba22bf9f5d Diff: https://reviews.apache.org/r/68374/diff/2/ Changes: https://reviews.apache.org/r/68374/diff/1-2/ Testing --- TODO Thanks, Andrew Schwartzmeyer

Re: Review Request 68297: Windows: Fixed a bug when `executorId` contains a `:`.

2018-08-17 Thread Andrew Schwartzmeyer
7;d rather not include it). Thanks, Andrew Schwartzmeyer

Review Request 68375: WIP: Added missing encode. Needs tests.

2018-08-15 Thread Andrew Schwartzmeyer
path set for `$TMP`). Needs more tests and testing. Thanks, Andrew Schwartzmeyer

Re: Review Request 68301: WIP: Tests with `default:id`. Not for merging.

2018-08-15 Thread Andrew Schwartzmeyer
ng-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest. Thanks, Andrew Schwartzmeyer

Review Request 68374: Windows: Fixed a bug when `taskID` contains a `:`.

2018-08-15 Thread Andrew Schwartzmeyer
. Repository: mesos Description --- Windows: Fixed a bug when `taskID` contains a `:`. Diffs - src/slave/paths.cpp ed0b1276908f4990ce7a24c96aea20e8c79d3126 Diff: https://reviews.apache.org/r/68374/diff/1/ Testing --- TODO Thanks, Andrew Schwartzmeyer

Re: Review Request 68297: Windows: Fixed a bug when `executorId` contains a `:`.

2018-08-15 Thread Andrew Schwartzmeyer
changing the machine's registry, so I'd rather not include it). Thanks, Andrew Schwartzmeyer

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

2018-08-14 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review207251 --- Ship it! Ship It! - Andrew Schwartzmeyer On Aug. 7, 2018

Re: Review Request 67504: Added support script to post build results.

2018-08-14 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/#review207243 --- Ship it! Ship It! - Andrew Schwartzmeyer On Aug. 7, 2018

Re: Review Request 67503: Added support helper for fetching review ids.

2018-08-14 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/#review207242 --- Ship it! Ship It! - Andrew Schwartzmeyer On Aug. 7, 2018

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

2018-08-14 Thread Andrew Schwartzmeyer
(patched) <https://reviews.apache.org/r/67502/#comment290552> I actually disagree with the TODO here: we often use an empty diff (but a new iteration of the review) to purposefully trigger the Review Bot. - Andrew Schwartzmeyer On Aug. 7, 2018, 10:36 a.m., Dragos Schebesch

Review Request 68331: Windows: Made `libwinio` the default option.

2018-08-13 Thread Andrew Schwartzmeyer
f0f12fc81ed664528cf7496cf75e1cb11eee6013 src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c Diff: https://reviews.apache.org/r/68331/diff/1/ Testing --- Built with and without `-DENABLE_LIBEVENT` on Windows. Thanks, Andrew Schwartzmeyer

Review Request 68329: Windows: Made `libwinio` the default option.

2018-08-13 Thread Andrew Schwartzmeyer
a03a77eb5e289b4daac0bbd414dc17c8acc848dc Diff: https://reviews.apache.org/r/68329/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 67932: Windows: Extracted file layers using `wclayer` from `hcsshim`.

2018-08-10 Thread Andrew Schwartzmeyer
t; > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67932/ > --- > > (Updated Aug. 6, 2018, 11:46 a.m.) > > > Review request for mesos,

Re: Review Request 68303: Fixed gRPC compilation for non-SSL build.

2018-08-10 Thread Andrew Schwartzmeyer
27;ed without, built with. Thanks! - Andrew Schwartzmeyer On Aug. 10, 2018, 3:17 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Review Request 68301: WIP: Tests with `default:id`. Not for merging.

2018-08-10 Thread Andrew Schwartzmeyer
kerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos" ``` Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest. Thanks, Andrew Schwartzmeyer

Review Request 68297: Windows: Fixed a bug when `executorId` contains a `:`.

2018-08-10 Thread Andrew Schwartzmeyer
`, which I also tested, but required changes of asserts (and caused long path issues only solvable by changing the machine's registry, so I'd rather not include it). Thanks, Andrew Schwartzmeyer

Re: Review Request 68265: Built gRPC support in mesos-tidy.

2018-08-08 Thread Andrew Schwartzmeyer
mesos-tidy violations found. ``` - Andrew Schwartzmeyer On Aug. 7, 2018, 4:56 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Review Request 68263: Fixed Windows build break due to missing lambda capture.

2018-08-07 Thread Andrew Schwartzmeyer
- 3rdparty/libprocess/src/tests/benchmarks.cpp 16b3bca44ca3e9a5fddd93fa02b9a3021c696fda Diff: https://reviews.apache.org/r/68263/diff/1/ Testing --- Windows build, cquery (clang) did not emit warning. Thanks, Andrew Schwartzmeyer

Review Request 68238: Fixed `mesos-style.py` for Windows.

2018-08-06 Thread Andrew Schwartzmeyer
12fd33061fcb2cb04349ec1138844ea712610259 Diff: https://reviews.apache.org/r/68238/diff/1/ Testing --- Can commit using normal hooks on Windows. Thanks, Andrew Schwartzmeyer

Re: Review Request 68176: Fixed gRPC release build on Windows.

2018-08-03 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68176/#review206846 --- Ship it! Ship It! - Andrew Schwartzmeyer On Aug. 2, 2018, 4

Re: Review Request 67933: Replaced `` with `` in stout.

2018-08-01 Thread Andrew Schwartzmeyer
Schwartzmeyer On July 16, 2018, 2:43 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

2018-07-31 Thread Andrew Schwartzmeyer
tting/commenting etc., and double-check the schema, but otherwise LGTM - Andrew Schwartzmeyer On July 31, 2018, 2:41 p.m., Liangyu Zhao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 67930: Get tests ready for Windows UCR development.

2018-07-31 Thread Andrew Schwartzmeyer
tting/commenting etc., but otherwise LGTM. - Andrew Schwartzmeyer On July 31, 2018, 2:42 p.m., Liangyu Zhao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.

2018-07-31 Thread Andrew Schwartzmeyer
ginal authorship (me); I thought RB would preserve it, but apparently not, I guess it takes it from the user submitting. Oh well. - Andrew Schwartzmeyer On July 31, 2018, 2:42 p.m., Liangyu Zhao wrote: > > --- > This is an automatical

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-31 Thread Andrew Schwartzmeyer
tting/commenting etc., but otherwise LGTM. - Andrew Schwartzmeyer On July 31, 2018, 2:41 p.m., Liangyu Zhao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

2018-07-31 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/#review206689 --- Ship it! Tested sponsor email, it works! - Andrew

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-31 Thread Andrew Schwartzmeyer
) <https://reviews.apache.org/r/67932/#comment289772> :) - Andrew Schwartzmeyer On July 31, 2018, 2:41 p.m., Liangyu Zhao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

2018-07-31 Thread Andrew Schwartzmeyer
> On July 30, 2018, 4:39 p.m., Andrew Schwartzmeyer wrote: > > include/mesos/uri/fetcher.hpp > > Lines 101 (patched) > > <https://reviews.apache.org/r/67931/diff/3/?file=2061467#file2061467line101> > > > > I am not convinced we need to be passing this a

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-31 Thread Andrew Schwartzmeyer
> On July 30, 2018, 5:30 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Line 381 (original), 388 (patched) > > <https://reviews.apache.org/r/67932/diff/3/?file=2061482#file2061482line388> > > &g

Re: Review Request 67916: Patched Google Test with upstream bugfix.

2018-07-31 Thread Andrew Schwartzmeyer
mpile interface definition, `ninja tests` successfully built on Windows with this patch applied, after not building before the patch. Thanks, Andrew Schwartzmeyer

Re: Review Request 67916: Patched Google Test with upstream bugfix.

2018-07-31 Thread Andrew Schwartzmeyer
ache.org/r/67916/#review206647 --- On July 30, 2018, 11:50 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 68016: Added libseccomp to the build.

2018-07-30 Thread Andrew Schwartzmeyer
tps://reviews.apache.org/r/68016/#comment289680> What targets need `ENABLE_SECCOMP_ISOLATOR` defined? Presumably this is new code, so we don't have to leave this as a to-do. (And I'm guessing just `libmesos PRIVATE`?) - Andrew Schwartzmeyer On July 23, 2018, 9:17 a.m., And

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-30 Thread Andrew Schwartzmeyer
clayer_remove` is supposed to remove the directory? src/slave/containerizer/mesos/provisioner/docker/store.cpp Lines 490 (patched) <https://reviews.apache.org/r/67932/#comment289679> Last I remember, `flags.docker_store_dir` was some Linux path; did we get that fixed (or am I misrememberin

Re: Review Request 67930: Get tests ready for Windows UCR development.

2018-07-30 Thread Andrew Schwartzmeyer
281-283 (patched) <https://reviews.apache.org/r/67930/#comment289667> nit: `static constexpr char DOCKER_IMAGE[]` (like above) - Andrew Schwartzmeyer On July 18, 2018, 2:27 a.m., Liangyu Zhao wrote: > > --- > This is a

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

2018-07-30 Thread Andrew Schwartzmeyer
67931/#comment289666> Are we just skipping a failed blob here and trying to process the rest? Does that make sense to do? - Andrew Schwartzmeyer On July 30, 2018, 3:40 p.m., Liangyu Zhao wrote: > > --- > This is an aut

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-30 Thread Andrew Schwartzmeyer
dparty\sasl2-2.1.27rc3.vcxproj] > > > > > > "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) -> > >"D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj" (default target) (7) -> > >(CustomBuild target) -> > >

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-30 Thread Andrew Schwartzmeyer
-- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67932/ > --- > > (Updated July 18, 2018, 2:27 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Sc

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

2018-07-30 Thread Andrew Schwartzmeyer
> On July 17, 2018, 11:16 a.m., Andrew Schwartzmeyer wrote: > > include/mesos/docker/spec.hpp > > Lines 124-126 (patched) > > <https://reviews.apache.org/r/67931/diff/1/?file=2059702#file2059702line124> > > > > I think this and the commit before need t

Re: Review Request 67916: Patched Google Test with upstream bugfix.

2018-07-30 Thread Andrew Schwartzmeyer
ition, `ninja tests` successfully built on Windows with this patch applied, after not building before the patch. Thanks, Andrew Schwartzmeyer

Re: Review Request 67916: Patched Google Test with upstream bugfix.

2018-07-30 Thread Andrew Schwartzmeyer
tions(-D_SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING) ``` Unfortunately, it still repro'ed with this patch applied too, so I need to figure out what we missed. Thanks, Andrew Schwartzmeyer

Re: Review Request 67916: Patched Google Test with upstream bugfix.

2018-07-27 Thread Andrew Schwartzmeyer
else do people generate patches? - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67916/#review206332 --- On July 13, 2018, 2

Re: Review Request 67751: Add missing files to CMake build.

2018-07-27 Thread Andrew Schwartzmeyer
: https://reviews.apache.org/r/67751/diff/2-3/ Testing --- Thanks, Andrew Schwartzmeyer

Review Request 68094: Add port mapping and network ports isolators sources to CMake.

2018-07-27 Thread Andrew Schwartzmeyer
mesos/CMakeLists.txt ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8 src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 Diff: https://reviews.apache.org/r/68094/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Review Request 68093: Add XFS disk isolator files to CMake.

2018-07-27 Thread Andrew Schwartzmeyer
/68093/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 67751: Add missing files to CMake build.

2018-07-27 Thread Andrew Schwartzmeyer
695b6f543847d4270f7004a1768919904975d7a4 Diff: https://reviews.apache.org/r/67751/diff/2/ Changes: https://reviews.apache.org/r/67751/diff/1-2/ Testing (updated) --- Thanks, Andrew Schwartzmeyer

Review Request 67983: Enabled `TimeTest.Now` on Windows.

2018-07-20 Thread Andrew Schwartzmeyer
08ddb56f1789f400b8cd072c53e885c759f13ddc Diff: https://reviews.apache.org/r/67983/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 67980: Windows: Enabled rest of `ProcessTest` suite.

2018-07-19 Thread Andrew Schwartzmeyer
Testing --- `ctest -V` on Windows Thanks, Andrew Schwartzmeyer

Review Request 67980: Windows: Enabled rest of `ProcessTest` suite.

2018-07-19 Thread Andrew Schwartzmeyer
`. Diffs - 3rdparty/libprocess/src/tests/process_tests.cpp 8baf60d8bbb675e26fea5e76c825ef73fedbc629 Diff: https://reviews.apache.org/r/67980/diff/1/ Testing --- `ctest -V` on Windows Thanks, Andrew Schwartzmeyer

Review Request 67979: Windows: Documented why the `RemoteLinkLeak` test is not enabled.

2018-07-19 Thread Andrew Schwartzmeyer
8baf60d8bbb675e26fea5e76c825ef73fedbc629 Diff: https://reviews.apache.org/r/67979/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Review Request 67978: Windows: Enabled `RemoteLink` tests.

2018-07-19 Thread Andrew Schwartzmeyer
8baf60d8bbb675e26fea5e76c825ef73fedbc629 Diff: https://reviews.apache.org/r/67978/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Review Request 67977: Fixed `test-linkee` logic in `ProcessRemoteLinkTest::SetUp()`.

2018-07-19 Thread Andrew Schwartzmeyer
3rdparty/libprocess/src/tests/process_tests.cpp 8baf60d8bbb675e26fea5e76c825ef73fedbc629 Diff: https://reviews.apache.org/r/67977/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer

Review Request 67976: Windows: Added `nullptr` checks when using `libwinio_loop` pointer.

2018-07-19 Thread Andrew Schwartzmeyer
/1/ Testing --- Thanks, Andrew Schwartzmeyer

Re: Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.

2018-07-19 Thread Andrew Schwartzmeyer
27438d31617b3b78bf3d4deffd25c93340610e8d Diff: https://reviews.apache.org/r/67951/diff/3/ Changes: https://reviews.apache.org/r/67951/diff/2-3/ Testing --- `stout-tests` and `libprocess-tests` passed on Windows and Ubuntu Thanks, Andrew Schwartzmeyer

Re: Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite.

2018-07-17 Thread Andrew Schwartzmeyer
--- 3rdparty/libprocess/src/process.cpp 7c0a0bc0c1e50354b6da219032ac830cbeec0a0d 3rdparty/libprocess/src/tests/http_tests.cpp acbd6973829411652fc5d57ef473c0d8ba9cd5b4 Diff: https://reviews.apache.org/r/67952/diff/1/ Testing --- `stout-tests` and `libprocess-tests` passed on Window

Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.

2018-07-17 Thread Andrew Schwartzmeyer
-tests` passed on Windows and Ubuntu Thanks, Andrew Schwartzmeyer

Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite.

2018-07-17 Thread Andrew Schwartzmeyer
/src/tests/http_tests.cpp acbd6973829411652fc5d57ef473c0d8ba9cd5b4 Diff: https://reviews.apache.org/r/67952/diff/1/ Testing --- `stout-tests` and `libprocess-tests` passed on Windows and Ubuntu Thanks, Andrew Schwartzmeyer

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-17 Thread Andrew Schwartzmeyer
os\3rdparty\curl-7.60.0.vcxproj] > > CUSTOMBUILD : error : downloading > > 'https://github.com/mesos/3rdparty/raw/master/curl-7.60.0.tar.gz' failed > > [D:\DCOS\mesos\3rdparty\curl-7.60.0.vcxproj] > > CUSTOMBUILD : The requested URL returned er

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

2018-07-17 Thread Andrew Schwartzmeyer
gt; We can delete this now! Also, add `MESOS-8570` to the "bug" field of this review, and let's get you a JIRA account so I can assign it to you. src/uri/fetcher.cpp Lines 88 (patched) <https://reviews.apache.org/r/67931/#comment289066> Why does this

Re: Review Request 67930: Get tests ready for Windows UCR development.

2018-07-17 Thread Andrew Schwartzmeyer
uri_fetcher_tests.cpp Lines 305-312 (patched) <https://reviews.apache.org/r/67930/#comment289055> What's the reason this has to _only_ be done on Windows? src/tests/uri_fetcher_tests.cpp Lines 307 (patched) <https://reviews.apache.org/r/67930/#comment289054> s/Verision/Version - An

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-17 Thread Andrew Schwartzmeyer
> On July 16, 2018, 1:32 p.m., Andrew Schwartzmeyer wrote: > > Did you have an automated way of finding where we should apply `override` > > in existing code? I'd like to see if there's any Windows-only code/tests we > > should fix too. > > Armand Gri

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

2018-07-16 Thread Andrew Schwartzmeyer
to the point where we're setting `URI_SRC` to begin with. src/uri/fetchers/docker.cpp Lines 102-105 (patched) <https://reviews.apache.org/r/67931/#comment289041> I think there's a `strings::replace` to do this.

Review Request 67933: Replaced `` with `` in stout.

2018-07-16 Thread Andrew Schwartzmeyer
computer that I figured I should post. `ninja tests ; ctest -V` on Windows. Thanks, Andrew Schwartzmeyer

Re: Review Request 67869: Add use of `override` to the Mesos C++ style guide.

2018-07-16 Thread Andrew Schwartzmeyer
change, as I believe that if we care about it, we need to call it out in addition to its presence in the Google Style Guide (that thing is enormous!). - Andrew Schwartzmeyer On July 11, 2018, 10:03 p.m., James Peach wrote: > > --- >

Re: Review Request 67868: Apply the `override` keyword to Mesos.

2018-07-16 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67868/#review206131 --- Ship it! Ship It! - Andrew Schwartzmeyer On July 11, 2018

Re: Review Request 67867: Apply the `override` keyword to libprocess.

2018-07-16 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67867/#review206129 --- Ship it! Ship It! - Andrew Schwartzmeyer On July 11, 2018

Re: Review Request 67869: Add use of `override` to the Mesos C++ style guide.

2018-07-16 Thread Andrew Schwartzmeyer
-- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67869/ > ------- > > (Updated July 11, 2018, 10:03 p.m.) > > > Review request for mesos, Andrew Schwartzmeye

  1   2   3   4   5   6   7   8   9   10   >