Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101085286
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -528,13 +582,41 @@ public SparkAppHandle
startApplication(SparkAppHa
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101095913
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -71,6 +100,9 @@ private[spark] abstract class LauncherBackend {
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101084346
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -528,13 +582,41 @@ public SparkAppHandle
startApplication(SparkAppHa
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101061331
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -685,9 +686,8 @@ object SparkSubmit extends CommandLineUtils {
ad
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101087592
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -49,6 +49,39 @@
*
*
*
+ * Currently, while lau
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101092206
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -71,6 +100,9 @@ private[spark] abstract class LauncherBackend {
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101085524
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitRunner.java ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Fou
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101062900
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +719,23 @@ object SparkSubmit extends CommandLineUtils {
p
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101083260
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +121,30 @@ public static void setConfig(String name, String
v
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101094707
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +121,30 @@ public static void setConfig(String name, String
valu
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100950587
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +719,23 @@ object SparkSubmit extends CommandLineUtils {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100949504
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +121,30 @@ public static void setConfig(String name, String
valu
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100939063
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -479,7 +538,7 @@ public Process launch() throws IOException {
*
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100939127
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -488,11 +547,22 @@ public Process launch() throws IOException {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100936686
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractSparkAppHandle.java ---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100937515
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildThreadAppHandle.java ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Fou
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100934503
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +719,23 @@ object SparkSubmit extends CommandLineUtils {
prin
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100936606
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -110,12 +142,14 @@ private[spark] abstract class LauncherBackend {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100935501
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -17,38 +17,67 @@
package org.apache.spark.launcher
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100934407
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100939738
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -25,8 +25,8 @@
*
*
* The {@link org.apache.spark.launc
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100938028
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -89,11 +89,31 @@
private static volatile LauncherServer serverIn
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100936833
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractSparkAppHandle.java ---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100937832
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -157,9 +176,15 @@ public void run() {
* Creates a new app handl
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100938862
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +121,30 @@ public static void setConfig(String name, String
valu
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100936310
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -71,6 +100,9 @@ private[spark] abstract class LauncherBackend {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100934574
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +719,23 @@ object SparkSubmit extends CommandLineUtils {
prin
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100935040
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -735,7 +751,11 @@ object SparkSubmit extends CommandLineUtils {
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100938919
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +121,30 @@ public static void setConfig(String name, String
valu
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100938212
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -73,6 +74,14 @@
/** Logger name to use when launching a child pro
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100934667
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +719,23 @@ object SparkSubmit extends CommandLineUtils {
prin
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100938252
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -73,6 +74,14 @@
/** Logger name to use when launching a child pro
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100937560
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java ---
@@ -106,5 +106,4 @@ public void close() throws IOException {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100937651
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -89,11 +89,31 @@
private static volatile LauncherServer serverIn
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100320712
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -1149,13 +1179,23 @@ private object Client extends Loggi
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100313659
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +719,20 @@ object SparkSubmit extends CommandLineUtils {
p
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100312242
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100318015
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -49,6 +49,38 @@
*
*
*
+ * Currently, for curre
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100318779
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -49,6 +49,38 @@
*
*
*
+ * Currently, for curre
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100312144
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100313512
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +719,20 @@ object SparkSubmit extends CommandLineUtils {
p
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100318547
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/package-info.java ---
@@ -49,6 +49,38 @@
*
*
*
+ * Currently, for curre
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100316402
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -94,6 +103,13 @@
static final Map launcherConfig = new H
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100316424
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -94,6 +103,13 @@
static final Map launcherConfig = new H
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100317631
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitRunner.java ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Fou
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100316057
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -89,11 +89,32 @@
private static volatile LauncherServer serve
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r99850931
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -17,38 +17,67 @@
package org.apache.spark.launcher
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r99849329
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -71,6 +100,9 @@ private[spark] abstract class LauncherBackend {
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r99841742
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractSparkAppHandle.java ---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Soft
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87464404
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +721,27 @@ object SparkSubmit {
printWarning("Subclasses of sc
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87463913
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +721,27 @@ object SparkSubmit {
printWarning("Subclasses of sc
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87466599
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -71,6 +100,9 @@ private[spark] abstract class LauncherBackend {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87467314
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -103,67 +46,27 @@ public synchronized void kill() {
try {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87463639
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +721,27 @@ object SparkSubmit {
printWarning("Subclasses of sc
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87463521
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87465891
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -17,38 +17,67 @@
package org.apache.spark.launcher
+
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87464167
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +721,27 @@ object SparkSubmit {
printWarning("Subclasses of sc
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87466834
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractSparkAppHandle.java ---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software F
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r87465101
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -735,7 +757,11 @@ object SparkSubmit {
}
try {
-
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r86870416
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildThreadAppHandle.java ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Softwar
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r85029363
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +123,27 @@ public static void setConfig(String name, String
value
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r85026996
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +123,27 @@ public static void setConfig(String name, String
value
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r85026908
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +123,27 @@ public static void setConfig(String name, String
value
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84791881
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -1186,9 +1209,13 @@ private[spark] class Client(
}
-private
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84788125
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -103,67 +46,22 @@ public synchronized void kill() {
try {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84789919
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -528,13 +581,41 @@ public SparkAppHandle
startApplication(SparkAppHandle
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84789427
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -73,6 +74,14 @@
/** Logger name to use when launching a child proc
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84788565
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherProtocol.java ---
@@ -32,6 +32,9 @@
/** Environment variable where the secret for co
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84782803
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84789538
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +123,27 @@ public static void setConfig(String name, String
value
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84785459
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -710,7 +723,11 @@ object SparkSubmit {
printWarning("Subclasses of sc
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84782648
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84788429
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildThreadAppHandle.java ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foun
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84789777
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +123,27 @@ public static void setConfig(String name, String
value
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84787477
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractSparkAppHandle.java ---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software F
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84787094
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -110,12 +146,14 @@ private[spark] abstract class LauncherBackend {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84786614
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -17,38 +17,71 @@
package org.apache.spark.launcher
+
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84783206
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -676,8 +678,19 @@ object SparkSubmit {
addJarToClasspath(jar, loader)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84791767
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -645,11 +664,13 @@ private[spark] class Client(
remoteFs, hadoopConf,
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84790527
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitRunner.java ---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84785044
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -710,7 +723,11 @@ object SparkSubmit {
printWarning("Subclasses of sc
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84785351
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -710,7 +723,11 @@ object SparkSubmit {
printWarning("Subclasses of sc
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84784981
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -676,8 +678,19 @@ object SparkSubmit {
addJarToClasspath(jar, loader)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84788283
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildThreadAppHandle.java ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foun
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84785866
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -17,38 +17,71 @@
package org.apache.spark.launcher
+
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84790049
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -528,13 +581,41 @@ public SparkAppHandle
startApplication(SparkAppHandle
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84786490
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -17,38 +17,71 @@
package org.apache.spark.launcher
+
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84791332
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -56,23 +56,38 @@ import org.apache.spark.internal.config._
import org.apach
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84791392
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -56,23 +56,38 @@ import org.apache.spark.internal.config._
import org.apach
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84782701
--- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala ---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84783078
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -676,8 +678,19 @@ object SparkSubmit {
addJarToClasspath(jar, loader)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84787253
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractSparkAppHandle.java ---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software F
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r84178923
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitRunner.java ---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software F
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r83744591
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -760,7 +787,7 @@ private[spark] class Client(
.foreach { case (
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r83277627
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -710,7 +724,12 @@ object SparkSubmit {
printWarning("Subclasses of sc
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r83280861
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -1189,6 +1217,10 @@ private[spark] class Client(
private object Client exte
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r83281329
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -1197,12 +1229,22 @@ private object Client extends Logging {
// Set an
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r82075274
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -488,11 +546,22 @@ public Process launch() throws IOException {
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r81985259
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -1322,7 +1373,9 @@ private object Client extends Logging {
conf: C
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r81988012
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -1189,6 +1217,10 @@ private[spark] class Client(
private object Client e
101 - 200 of 241 matches
Mail list logo
