Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16344
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97217994
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -106,11 +148,24 @@ private[regression] trait
Gene
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97227087
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -1052,6 +1217,120 @@ class GeneralizedLinearR
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97219484
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -57,30 +57,72 @@ private[regression] trait
Genera
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97219567
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -57,30 +57,72 @@ private[regression] trait
Genera
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97226910
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -620,25 +779,67 @@ object GeneralizedLinearRegress
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97226879
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -620,25 +779,67 @@ object GeneralizedLinearRegress
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97219089
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -578,6 +580,169 @@ class GeneralizedLinearReg
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97225945
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -308,7 +380,10 @@ object GeneralizedLinearRegressi
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97219666
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -106,11 +148,24 @@ private[regression] trait
Gene
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97218693
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -369,6 +446,23 @@ object GeneralizedLinearRegressi
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97226609
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -409,27 +503,108 @@ object GeneralizedLinearRegres
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97218286
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -409,27 +503,108 @@ object GeneralizedLinearRegres
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r97227237
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -1052,6 +1217,120 @@ class GeneralizedLinearR
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r96061883
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -242,9 +316,9 @@ class GeneralizedLinearRegressi
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r96061873
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -613,25 +758,67 @@ object GeneralizedLinearRegre
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r95994801
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -242,9 +316,9 @@ class GeneralizedLinearRegression
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r95995765
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -613,25 +758,67 @@ object GeneralizedLinearRegress
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r95989723
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -57,30 +57,72 @@ private[regression] trait
Genera
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r95991458
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -106,11 +148,20 @@ private[regression] trait
Gene
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r95992789
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -613,25 +758,67 @@ object GeneralizedLinearRegress
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r95991944
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -106,11 +148,20 @@ private[regression] trait
Gene
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r95993832
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -613,25 +758,67 @@ object GeneralizedLinearRegress
GitHub user actuaryzhang reopened a pull request:
https://github.com/apache/spark/pull/16344
[SPARK-18929][ML] Add Tweedie distribution in GLM
## What changes were proposed in this pull request?
I propose to add the full Tweedie family into the
GeneralizedLinearRegression model.
Github user actuaryzhang closed the pull request at:
https://github.com/apache/spark/pull/16344
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r94849556
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,32 +432,121 @@ object GeneralizedLinearRegr
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r94849540
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -365,7 +401,6 @@ object GeneralizedLinearRegress
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r94849501
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -158,6 +183,16 @@ class GeneralizedLinearRegress
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r94773809
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,32 +432,121 @@ object GeneralizedLinearRegres
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r94762690
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -365,7 +401,6 @@ object GeneralizedLinearRegressio
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r94772856
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,32 +432,121 @@ object GeneralizedLinearRegres
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r94771634
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -158,6 +183,16 @@ class GeneralizedLinearRegressio
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r94773283
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -128,13 +152,14 @@ private[regression] trait
Gene
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r94764683
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,32 +432,121 @@ object GeneralizedLinearRegres
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93971228
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,21 +435,102 @@ object GeneralizedLinearRegression
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93971681
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,20 +337,24 @@ object GeneralizedLinearRegression
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93776808
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,46 +434,118 @@ object GeneralizedLinearRegres
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93778762
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,14 +341,15 @@ object GeneralizedLinearRegress
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93773154
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -64,6 +64,28 @@ private[regression] trait
General
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93774215
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,46 +434,118 @@ object GeneralizedLinearRegres
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93779154
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -578,6 +578,100 @@ class GeneralizedLinearReg
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93778869
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,20 +337,24 @@ object GeneralizedLinearRegress
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93775431
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,46 +434,118 @@ object GeneralizedLinearRegres
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93777486
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,46 +434,118 @@ object GeneralizedLinearRegres
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93776723
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,46 +434,118 @@ object GeneralizedLinearRegres
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93773858
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -128,13 +151,14 @@ private[regression] trait
Gene
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93775763
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,46 +434,118 @@ object GeneralizedLinearRegres
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93672741
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,20 +337,24 @@ object GeneralizedLinearRegre
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93612915
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,49 +436,132 @@ object GeneralizedLinearRegression
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93612097
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,20 +337,24 @@ object GeneralizedLinearRegression
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93612965
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,49 +436,132 @@ object GeneralizedLinearRegression
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93613064
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,49 +436,132 @@ object GeneralizedLinearRegression
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93565567
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,14 +341,15 @@ object GeneralizedLinearRegre
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93565335
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -64,6 +64,27 @@ private[regression] trait
Gener
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93488131
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -242,7 +275,12 @@ class GeneralizedLinearRegression @S
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93486159
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,14 +341,15 @@ object GeneralizedLinearRegre
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93482978
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -242,7 +275,12 @@ class GeneralizedLinearRegress
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93420832
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,14 +436,19 @@ object GeneralizedLinearRegression
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93420812
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -242,7 +275,12 @@ class GeneralizedLinearRegression @S
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93420417
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -64,6 +64,27 @@ private[regression] trait
Generalized
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93420653
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -397,14 +436,19 @@ object GeneralizedLinearRegression
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93455400
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -592,6 +629,59 @@ object GeneralizedLinearRegression e
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93420479
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -64,6 +64,27 @@ private[regression] trait
Generalized
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93449402
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -64,6 +64,27 @@ private[regression] trait
General
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93453273
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -303,14 +341,15 @@ object GeneralizedLinearRegress
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93447628
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -64,6 +64,27 @@ private[regression] trait
General
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93290854
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -242,7 +275,7 @@ class GeneralizedLinearRegression @Si
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93291042
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -592,6 +629,59 @@ object GeneralizedLinearRegression e
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93290858
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -592,6 +629,59 @@ object GeneralizedLinearRegres
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93289668
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -592,6 +629,59 @@ object GeneralizedLinearRegres
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93215641
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -592,6 +629,59 @@ object GeneralizedLinearRegression e
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93215688
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -592,6 +629,59 @@ object GeneralizedLinearRegression e
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93216003
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -592,6 +629,59 @@ object GeneralizedLinearRegression e
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93215941
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -592,6 +629,59 @@ object GeneralizedLinearRegression e
GitHub user actuaryzhang opened a pull request:
https://github.com/apache/spark/pull/16344
[SPARK-18929][ML] Add Tweedie distribution in GLM
## What changes were proposed in this pull request?
I propose to add the full Tweedie family into the
GeneralizedLinearRegression model. T
75 matches
Mail list logo
