Mike Percy has posted comments on this change.
Change subject: disk failure: don't open tablets on failed disks
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7766/3/src/kudu/fs/log_block_manager.cc
File
Adar Dembo has posted comments on this change.
Change subject: consensus: use periodic timers for failure detection
..
Patch Set 5: Verified+1
Known flake in AdminCliTest.TestMoveTablet, overriding Jenkins.
--
To view, visit
Alexey Serbin has posted comments on this change.
Change subject: KUDU-2033 (part 2). Add test for Java client failover support.
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7722
To
Adar Dembo has submitted this change and it was merged.
Change subject: rpc: periodic timers
..
rpc: periodic timers
This patch introduces a generic periodic timer class. How does it work?
1. A timer is constructed with a
Adar Dembo has submitted this change and it was merged.
Change subject: consensus: use periodic timers for failure detection
..
consensus: use periodic timers for failure detection
This patch replaces the existing failure
Adar Dembo has posted comments on this change.
Change subject: rpc: periodic timers
..
Patch Set 5: Verified+1
Unrelated test failure, I filed KUDU-2109 for the issue.
--
To view, visit http://gerrit.cloudera.org:8080/7733
Todd Lipcon has posted comments on this change.
Change subject: [java] KUDU-2103 Canonicalize hostnames in client
..
Patch Set 3:
(5 comments)
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#23).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7749
to look at the new patch set (#5).
Change subject: KUDU-2095 - Add `keepAlive` method to Java API
..
KUDU-2095 -
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(10 comments)
> (1 comment)
>
> Looks good! I'm very pleased how this came together, net-net I
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7749
to look at the new patch set (#6).
Change subject: KUDU-2095 - Add scanner `keepAlive` RPC call to Java API
..
Todd Lipcon has submitted this change and it was merged.
Change subject: dense_node-itest: add extra log output
..
dense_node-itest: add extra log output
For yet-unexplained reasons, this itest still sometimes skips outputting
t...@phdata.io has posted comments on this change.
Change subject: KUDU-2095 - Add scanner `keepAlive` RPC call to Java API
..
Patch Set 6:
(4 comments)
Alexey Serbin has submitted this change and it was merged.
Change subject: [build-support] IWYU build configuration for Jenkins
..
[build-support] IWYU build configuration for Jenkins
Added provisions to run the
Mike Percy has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(13 comments)
Looks pretty good to me, I mainly have nits.
Mike Percy has posted comments on this change.
Change subject: KUDU-1407: reassign failed tablets
..
Patch Set 17:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7440/17//COMMIT_MSG
Commit Message:
PS17, Line 30: is added
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7773
to look at the new patch set (#2).
Change subject: [iwyu] a minor clean-up after recent merges
..
[iwyu] a minor
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7270
to look at the new patch set (#26).
Change subject: disk failure: add persistent disk states
..
disk failure: add
Andrew Wong has posted comments on this change.
Change subject: disk failure: add persistent disk states
..
Patch Set 25:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7270/25/src/kudu/fs/block_manager_util.cc
File
Todd Lipcon has posted comments on this change.
Change subject: [iwyu] a minor clean-up after recent merges
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7773
To unsubscribe, visit
Attila Bukor has posted comments on this change.
Change subject: [java] KUDU-2103 Canonicalize hostnames in client
..
Patch Set 1:
(1 comment)
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 23:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/7207/23/src/kudu/fs/log_block_manager.cc
File
Adar Dembo has posted comments on this change.
Change subject: disk failure: add persistent disk states
..
Patch Set 26:
(17 comments)
http://gerrit.cloudera.org:8080/#/c/7270/26/src/kudu/fs/block_manager_util.cc
File
Dan Burkert has posted comments on this change.
Change subject: consensus: use periodic timers for failure detection
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7735
To unsubscribe, visit
Alexey Serbin has posted comments on this change.
Change subject: [tools] Add summary-only mode to ksck
..
Patch Set 2:
> (1 comment)
>
> I realized there's quite a bit more work to do to get
> machine-readable output from
Adar Dembo has submitted this change and it was merged.
Change subject: util: remove old failure detector and resettable heartbeater
code
..
util: remove old failure detector and resettable heartbeater code
With the move to
Adar Dembo has submitted this change and it was merged.
Change subject: consensus_peers: replace bespoke Raft heartbeat logic with
periodic timers
..
consensus_peers: replace bespoke Raft heartbeat logic with periodic timers
Adar Dembo has abandoned this change.
Change subject: kserver: consolidate randomized failure monitors
..
Abandoned
I went in a different direction and reimplemented failure detection using
timer-based scheduling:
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7775
to review the following change.
Change subject: dense_node-itest: add extra log output
..
dense_node-itest: add extra
Dan Burkert has posted comments on this change.
Change subject: consensus_peers: replace bespoke Raft heartbeat logic with
periodic timers
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7734
Dan Burkert has posted comments on this change.
Change subject: rpc: periodic timers
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7733
To unsubscribe, visit
Dan Burkert has posted comments on this change.
Change subject: consensus_peers: replace bespoke Raft heartbeat logic with
periodic timers
..
Patch Set 5:
flake looked like KUDU-1736 so I retriggered it
--
To view, visit
Dan Burkert has posted comments on this change.
Change subject: rpc: periodic timers
..
Patch Set 5:
unrelated flake. retriggered
--
To view, visit http://gerrit.cloudera.org:8080/7733
To unsubscribe, visit
Mike Percy has posted comments on this change.
Change subject: disk failure: don't open tablets on failed disks
..
Patch Set 3:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/7766/3//COMMIT_MSG
Commit Message:
PS3, Line
Dan Burkert has posted comments on this change.
Change subject: util: remove old failure detector and resettable heartbeater
code
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7736
To
Hello David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7440
to look at the new patch set (#18).
Change subject: KUDU-1407: reassign failed tablets
..
Andrew Wong has posted comments on this change.
Change subject: KUDU-1407: reassign failed tablets
..
Patch Set 17:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7440/17//COMMIT_MSG
Commit Message:
PS17, Line 30: is added
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7749
to look at the new patch set (#4).
Change subject: KUDU-2095 - Add `keepAlive` method to Java API
..
KUDU-2095 -
Adar Dembo has posted comments on this change.
Change subject: dense_node-itest: add extra log output
..
Patch Set 1: Code-Review+2
Sure, why not.
--
To view, visit http://gerrit.cloudera.org:8080/7775
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: disk failure: don't open tablets on failed disks
..
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7766/3/src/kudu/fs/data_dirs.cc
File
Edward Fancher has posted comments on this change.
Change subject: KUDU-2033 (part 2). Add test for Java client failover support.
..
Patch Set 2:
(4 comments)
Sailesh Mukil has posted comments on this change.
Change subject: [security] avoid tickets with NULL 'renew_till'
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7770/2//COMMIT_MSG
Commit Message:
PS2, Line
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7770
to look at the new patch set (#3).
Change subject: [security] avoid tickets with NULL 'renew_till'
..
[security]
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7651
to look at the new patch set (#6).
Change subject: Run the gradle build as a part of the gerrit tests
..
Run the
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7773
Change subject: [iwyu] a minor clean-up after recent merges
..
[iwyu] a minor clean-up after recent merges
After recent updates, some
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital
letters
..
KUDU-1942. Kerberos fails to log in on hostnames with capital letters
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital
letters
..
Patch Set 1: Code-Review+2
--
To view, visit
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital
letters
..
Patch Set 1: Code-Review+2
--
To view, visit
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital
letters
..
KUDU-1942. Kerberos fails to log in on hostnames with capital letters
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7722
to look at the new patch set (#2).
Change subject: KUDU-2033 (part 2). Add test for Java client failover support.
Dan Burkert has posted comments on this change.
Change subject: rpc: periodic timers
..
Patch Set 4: Code-Review+1
(1 comment)
LGTM modulo the typo
http://gerrit.cloudera.org:8080/#/c/7733/4/src/kudu/rpc/periodic.h
File
Todd Lipcon has posted comments on this change.
Change subject: KUDU-871. Support tombstoned voting
..
Patch Set 10:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/6960/10/src/kudu/consensus/raft_consensus.cc
File
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7602
to look at the new patch set (#13).
Change subject: separate DataDirManager from BlockManagers
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7270
to look at the new patch set (#25).
Change subject: disk failure: add persistent disk states
..
disk failure: add
Dan Burkert has posted comments on this change.
Change subject: consensus_peers: replace bespoke Raft heartbeat logic with
periodic timers
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7734
Will Berkeley has posted comments on this change.
Change subject: Kudu Consistency Blog Post Pt1
..
Patch Set 10:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/7019/10/_posts/2017-08-21-kudu-consistency-pt1.md
File
Dan Burkert has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(1 comment)
Looks good! I'm very pleased how this came together, net-net I think the code
is
Dan Burkert has posted comments on this change.
Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy
..
Patch Set 1:
lgtm
--
To view, visit http://gerrit.cloudera.org:8080/7701
To unsubscribe, visit
Dan Burkert has posted comments on this change.
Change subject: consensus: use periodic timers for failure detection
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7735/2/src/kudu/consensus/raft_consensus.cc
Alexey Serbin has posted comments on this change.
Change subject: KUDU-871. Support tombstoned voting
..
Patch Set 10:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/6960/10/src/kudu/integration-tests/cluster_itest_util.h
Todd Lipcon has posted comments on this change.
Change subject: [java] KUDU-2103 Canonicalize hostnames in client
..
Patch Set 1:
(1 comment)
Attila Bukor has posted comments on this change.
Change subject: [java] KUDU-2103 Canonicalize hostnames in client
..
Patch Set 1:
(5 comments)
Will Berkeley has posted comments on this change.
Change subject: [tools] Add summary-only mode to ksck
..
Patch Set 2:
(1 comment)
I realized there's quite a bit more work to do to get machine-readable output
from ksck,
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] a minor clean-up after recent merges
..
Patch Set 2: Verified+1
unrelated flake in delete_table-itest.0
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7207
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Run the gradle build as a part of the gerrit tests
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7651/6/build-support/jenkins/build-and-test.sh
Alexey Serbin has submitted this change and it was merged.
Change subject: [iwyu] a minor clean-up after recent merges
..
[iwyu] a minor clean-up after recent merges
After recent updates, some file became not compliant with
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7757
to look at the new patch set (#2).
Change subject: [java] KUDU-2103 Canonicalize hostnames in client
..
[java]
Adar Dembo has posted comments on this change.
Change subject: util: remove old failure detector and resettable heartbeater
code
..
Patch Set 4: Verified+1
Overriding Jenkins, a TSAN test failed due to an isolate failure.
--
Andrew Wong has posted comments on this change.
Change subject: disk failure: add persistent disk states
..
Patch Set 25:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/7270/24/src/kudu/fs/block_manager_util.cc
File
Alexey Serbin has posted comments on this change.
Change subject: [security] avoid tickets with NULL 'renew_till'
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7770/2/src/kudu/security/init.cc
File
Todd Lipcon has posted comments on this change.
Change subject: raft_consensus-itest: robust fix for asynchronous kill
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7561/5//COMMIT_MSG
Commit Message:
Line
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7207
to look at the new patch set (#22).
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
KUDU-1943:
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/7207/21/src/kudu/fs/block_manager-test.cc
File
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/20/src/kudu/fs/log_block_manager.cc
File
Andrew Wong has posted comments on this change.
Change subject: Kudu Consistency Blog Post Pt1
..
Patch Set 10:
(22 comments)
http://gerrit.cloudera.org:8080/#/c/7019/10/_posts/2017-08-21-kudu-consistency-pt1.md
File
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/
Change subject: [cmake] introduce 'pb-gen' and 'krpc-gen' target
..
[cmake] introduce 'pb-gen' and 'krpc-gen' target
Introduced a new
Mike Percy has posted comments on this change.
Change subject: KUDU-1407: reassign failed tablets
..
Patch Set 19:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7440/19/src/kudu/consensus/consensus_queue.cc
File
Mike Percy has posted comments on this change.
Change subject: KUDU-1407: reassign failed tablets
..
Patch Set 19:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/7440/19/src/kudu/consensus/consensus_queue.cc
File
Hello David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7440
to look at the new patch set (#19).
Change subject: KUDU-1407: reassign failed tablets
..
Andrew Wong has posted comments on this change.
Change subject: KUDU-1407: reassign failed tablets
..
Patch Set 19:
The jenkins failure doesn't seem to be related to these changes. This patch is
still good for review.
--
To
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [cmake] introduce 'pb-gen' and 'krpc-gen' targets
..
[cmake] introduce 'pb-gen' and 'krpc-gen' targets
Introduced a new target to generate protobuf stubs and KRPC
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7757
to look at the new patch set (#3).
Change subject: [java] KUDU-2103 Canonicalize hostnames in client
..
[java]
Andrew Wong has posted comments on this change.
Change subject: KUDU-1407: reassign failed tablets
..
Patch Set 17:
This patch has been +2'd, but some of the logic around failing tablet replicas
overlaps with the tombstoned
Andrew Wong has posted comments on this change.
Change subject: disk failure: add persistent disk states
..
Patch Set 26:
Addressed the comments and a slip-up on my part that caused the build to fail.
This is ready for
Hao Hao has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7207/22/src/kudu/fs/log_block_manager.cc
File
David Ribeiro Alves has posted comments on this change.
Change subject: disk failure: don't open tablets on failed disks
..
Patch Set 3:
(9 comments)
Adar Dembo has posted comments on this change.
Change subject: raft_consensus-itest: robust fix for asynchronous kill
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7561/5//COMMIT_MSG
Commit Message:
Line
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7733
to look at the new patch set (#5).
Change subject: rpc: periodic timers
..
rpc: periodic
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1407: reassign failed tablets
..
Patch Set 17: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7440
To unsubscribe, visit
Adar Dembo has submitted this change and it was merged.
Change subject: separate DataDirManager from BlockManagers
..
separate DataDirManager from BlockManagers
Currently, the DataDirManager is owned by the BlockManagers.
Adar Dembo has posted comments on this change.
Change subject: separate DataDirManager from BlockManagers
..
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7602
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7207/22/src/kudu/fs/block_manager.cc
File
Adar Dembo has posted comments on this change.
Change subject: consensus: use periodic timers for failure detection
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7735/2/src/kudu/consensus/raft_consensus.cc
Andrew Wong has posted comments on this change.
Change subject: separate DataDirManager from BlockManagers
..
Patch Set 13:
This patch hasn't changed much; mainly been rebasing it. It's been +2'd though
without significant
Mike Percy has posted comments on this change.
Change subject: KUDU-1943: Add BlockTransaction to Block Manager
..
Patch Set 22:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7207/22/src/kudu/fs/block_manager.cc
File
Alexey Serbin has posted comments on this change.
Change subject: [build-support] IWYU build configuration for Jenkins
..
Patch Set 9:
> You removed it anyway? Okay.
Yep, I didn't notice your earlier +2. Also, the section
Adar Dembo has posted comments on this change.
Change subject: disk failure: add persistent disk states
..
Patch Set 24:
(13 comments)
I didn't finish reviewing data_dirs.cc. Looked at the rest, though.
Adar Dembo has posted comments on this change.
Change subject: [build-support] IWYU build configuration for Jenkins
..
Patch Set 8:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7750/8/CMakeLists.txt
File CMakeLists.txt:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7748
to look at the new patch set (#6).
Change subject: KUDU-1811: C++ client: use larger batches when fetching scan
tokens
1 - 100 of 116 matches
Mail list logo