[kudu-CR] KUDU2665: LBM deletes the valid live block

2019-01-30 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12308 Change subject: KUDU2665: LBM deletes the valid live block .. KUDU2665: LBM deletes the valid live block Due to the nature of WritableBlock fi

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12310 Change subject: [build] Fix mini cluster binary relocation on Mac OS .. [build] Fix mini cluster binary relocation on Mac OS On Mac OS th

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 1: Code-Review+1 Ship it. -- To view, visit http:

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 1: (1 comment) Looks good, just a question about t

[kudu-CR] [thirdparty] detection of broken std::regex in libstdc++

2019-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12302 ) Change subject: [thirdparty] detection of broken std::regex in libstdc++ .. Patch Set 1: > Build Failed > > http://jenkins.kudu.apac

[kudu-CR] [thirdparty] detection of broken std::regex in libstdc++

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12302 ) Change subject: [thirdparty] detection of broken std::regex in libstdc++ .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/123

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Grant Henke (Code Review)
Hello Mike Percy, Brian McDevitt, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12310 to look at the new patch set (#2). Change subject: [build] Fix mini cluster binary relocation on Mac OS

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/123

[kudu-CR] [build] Improve mini cluster artifact name

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12312 Change subject: [build] Improve mini cluster artifact name .. [build] Improve mini cluster artifact name Adjust the name of the artifact/

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12

[kudu-CR] [build] Improve mini cluster artifact name

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12312 ) Change subject: [build] Improve mini cluster artifact name .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/123

[kudu-CR] [build] Improve mini cluster artifact name

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12312 ) Change subject: [build] Improve mini cluster artifact name .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12312/1/buil

[kudu-CR] [build] Improve mini cluster artifact name

2019-01-30 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12312 to look at the new patch set (#2). Change subject: [build] Improve mini cluster artifact name .. [build

[kudu-CR] [build] Improve mini cluster artifact name

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12312 ) Change subject: [build] Improve mini cluster artifact name .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/123

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/123

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/123

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Grant Henke (Code Review)
Hello Mike Percy, Brian McDevitt, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12310 to look at the new patch set (#3). Change subject: [build] Fix mini cluster binary relocation on Mac OS

[kudu-CR] KUDU-2680: ignore tombstones when updating dirs

2019-01-30 Thread Andrew Wong (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12313 to review the following change. Change subject: KUDU-2680: ignore tombstones when updating dirs .. KUDU-2680: ignore t

[kudu-CR] KUDU-2680: ignore tombstones when updating dirs

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12313 ) Change subject: KUDU-2680: ignore tombstones when updating dirs .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/123

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Grant Henke (Code Review)
Hello Mike Percy, Brian McDevitt, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12310 to look at the new patch set (#4). Change subject: [build] Fix mini cluster binary relocation on Mac OS

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 4: Code-Review+2 Adar mentioned on Slack that he is ok

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. Patch Set 4: Verified+1 (1 comment) http://gerrit.cloudera.org:

[kudu-CR] [thirdparty] detection of broken std::regex in libstdc++

2019-01-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12302 to look at the new patch set (#2). Change subject: [thirdparty] detection of broken std::regex in libstdc++

[kudu-CR] [build] Improve mini cluster artifact name

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12312 ) Change subject: [build] Improve mini cluster artifact name .. [build] Improve mini cluster artifact name Adjust the name of the

[kudu-CR] [build] Fix mini cluster binary relocation on Mac OS

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12310 ) Change subject: [build] Fix mini cluster binary relocation on Mac OS .. [build] Fix mini cluster binary relocation on Mac OS On

[kudu-CR] KUDU-2680: ignore tombstones when updating dirs

2019-01-30 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12313 to look at the new patch set (#2). Change subject: KUDU-2680: ignore tombstones when updating dirs .. K

[kudu-CR] [gradle] Increase test JVMs heap size

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12134 ) Change subject: [gradle] Increase test JVMs heap size .. [gradle] Increase test JVMs heap size The flume test RegexpKuduOperatio

[kudu-CR] KUDU2665: LBM deletes the valid live block

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12308 ) Change subject: KUDU2665: LBM deletes the valid live block .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/12308/1//COM

[kudu-CR] KUDU-2680: ignore tombstones when updating dirs

2019-01-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12313 ) Change subject: KUDU-2680: ignore tombstones when updating dirs .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12313/1

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/12

[kudu-CR] KUDU-2680: ignore tombstones when updating dirs

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12313 ) Change subject: KUDU-2680: ignore tombstones when updating dirs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12314 Change subject: binary artifact: generate properties file .. binary artifact: generate properties file Generate a properties file so we ca

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 ) Change subject: binary artifact: generate properties file .. Patch Set 1: Code-Review+1 Looks good. -- To view, visit http://gerrit

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 ) Change subject: binary artifact: generate properties file .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12314/1/build

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 ) Change subject: binary artifact: generate properties file .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12314/1/build

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 ) Change subject: binary artifact: generate properties file .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12314/1/build

[kudu-CR] KUDU-2477: highlight primary key in master Web UI

2019-01-30 Thread Greg Solovyev (Code Review)
Greg Solovyev has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12316 Change subject: KUDU-2477: highlight primary key in master Web UI .. KUDU-2477: highlight primary key in master Web UI This change uses

[kudu-CR](branch-1.8.x) KUDU-2670: split more scanner and add concurrent

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12305 ) Change subject: KUDU-2670: split more scanner and add concurrent .. Patch Set 2: Thanks for uploading this. I will take a look soon. Gi

[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster

2019-01-30 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 ) Change subject: KUDU-2411: Example integration test using KuduMiniCluster .. Patch Set 1: (1 comment) A simple example of wiring it

[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster

2019-01-30 Thread Brian McDevitt (Code Review)
Brian McDevitt has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12318 Change subject: KUDU-2411: Example integration test using KuduMiniCluster .. KUDU-2411: Example integration test using KuduMiniCluster

[kudu-CR] [thirdparty] detection of broken std::regex in libstdc++

2019-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12302 ) Change subject: [thirdparty] detection of broken std::regex in libstdc++ .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-2411: Altered binary jar extractor API

2019-01-30 Thread Brian McDevitt (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12319 to look at the new patch set (#2). Change subject: KUDU-2411: Altered binary jar extractor API

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 ) Change subject: binary artifact: generate properties file .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12314/1/build

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Mike Percy (Code Review)
Hello Brian McDevitt, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12314 to look at the new patch set (#2). Change subject: binary artifact: generate properties file ..

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 ) Change subject: binary artifact: generate properties file .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12314/1/build

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 ) Change subject: binary artifact: generate properties file .. Patch Set 3: Verified+1 I ran on my Mac and the included properties file co

[kudu-CR] KUDU-2411: Altered binary jar extractor API

2019-01-30 Thread Brian McDevitt (Code Review)
Brian McDevitt has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12319 Change subject: KUDU-2411: Altered binary jar extractor API .. KUDU-2411: Altered binary jar extractor API The jar extractor API now h

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 ) Change subject: binary artifact: generate properties file .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-2411: Altered binary jar extractor API

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 ) Change subject: KUDU-2411: Altered binary jar extractor API .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12319/2/jav

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has removed a vote on this change. Change subject: binary artifact: generate properties file .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12314 To unsubscribe, visit ht

[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 ) Change subject: KUDU-2411: Example integration test using KuduMiniCluster .. Patch Set 1: Looks good as a minimal start. Perhaps we shou

[kudu-CR] KUDU-2684: deduplicate master addrs on tservers

2019-01-30 Thread Andrew Wong (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12320 to review the following change. Change subject: KUDU-2684: deduplicate master addrs on tservers .. KUDU-2684: dedup

[kudu-CR] KUDU-2680: ignore tombstones when updating dirs

2019-01-30 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12313 ) Change subject: KUDU-2680: ignore tombstones when updating dirs .. KUDU-2680: ignore tombstones when updating dirs Previously, w

[kudu-CR] [thirdparty] detection of broken std::regex in libstdc++

2019-01-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12302 to look at the new patch set (#3). Change subject: [thirdparty] detection of broken std::regex in libstdc++

[kudu-CR] binary artifact: generate properties file

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12314 ) Change subject: binary artifact: generate properties file .. binary artifact: generate properties file Generate a properties file

[kudu-CR] [thirdparty] detection of broken std::regex in libstdc++

2019-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12302 ) Change subject: [thirdparty] detection of broken std::regex in libstdc++ .. Patch Set 3: (2 comments) Thank you for fast review! htt

[kudu-CR] [thirdparty] detection of broken std::regex in libstdc++

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12302 ) Change subject: [thirdparty] detection of broken std::regex in libstdc++ .. Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloude

[kudu-CR] KUDU-2684: deduplicate master addrs on tservers

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12320 ) Change subject: KUDU-2684: deduplicate master addrs on tservers .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12320/1

[kudu-CR] KUDU-2411: Altered binary jar extractor API

2019-01-30 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 ) Change subject: KUDU-2411: Altered binary jar extractor API .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12319/2

[kudu-CR] KUDU-2411: Altered binary jar extractor API

2019-01-30 Thread Brian McDevitt (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12319 to look at the new patch set (#3). Change subject: KUDU-2411: Altered binary jar extractor API

[kudu-CR] KUDU-2411: Altered binary jar extractor API

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 ) Change subject: KUDU-2411: Altered binary jar extractor API .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/

[kudu-CR] KUDU-2684: deduplicate master addrs on tservers

2019-01-30 Thread Andrew Wong (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12320 to look at the new patch set (#2). Change subject: KUDU-2684: deduplicate master addrs on tservers ..

[kudu-CR] KUDU-2411: Altered binary jar extractor API

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 ) Change subject: KUDU-2411: Altered binary jar extractor API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12319/3//COM

[kudu-CR] [thirdparty] detection of broken std::regex in libstdc++

2019-01-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12302 ) Change subject: [thirdparty] detection of broken std::regex in libstdc++ .. [thirdparty] detection of broken std::regex in libs

[kudu-CR] KUDU-2684: deduplicate master addrs on tservers

2019-01-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12320 ) Change subject: KUDU-2684: deduplicate master addrs on tservers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12320/

[kudu-CR] KUDU-2684: deduplicate master addrs on tservers

2019-01-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12320 ) Change subject: KUDU-2684: deduplicate master addrs on tservers .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] KUDU-2477: highlight primary key in master Web UI

2019-01-30 Thread Greg Solovyev (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12316 to look at the new patch set (#2). Change subject: KUDU-2477: highlight primary key in master Web UI .. KUDU-2477:

[kudu-CR] [java] fix ITClient test retrying

2019-01-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12321 to review the following change. Change subject: [java] fix ITClient test retrying .. [java] fix ITClie

[kudu-CR] [java] better client and minicluster cleanup after tests finish

2019-01-30 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12322 to review the following change. Change subject: [java] better client and minicluster cleanup after tests finish ...

[kudu-CR] KUDU-2411: Example integration test using KuduMiniCluster

2019-01-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 ) Change subject: KUDU-2411: Example integration test using KuduMiniCluster .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] KUDU-2684: deduplicate master addrs on tservers

2019-01-30 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-2684: deduplicate master addrs on tservers .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12320 To unsubscribe, v

[kudu-CR] KUDU-2684: deduplicate master addrs on tservers

2019-01-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12320 ) Change subject: KUDU-2684: deduplicate master addrs on tservers .. Patch Set 2: Verified+1 I filed KUDU-2686 for the failure; doesn't se

[kudu-CR](branch-1.8.x) KUDU-2670: split more scanner and add concurrent

2019-01-30 Thread yangz (Code Review)
yangz has posted comments on this change. ( http://gerrit.cloudera.org:8080/12305 ) Change subject: KUDU-2670: split more scanner and add concurrent .. Patch Set 2: > Thanks for uploading this. I will take a look soon. > > G

[kudu-CR] [java] fix ITClient test retrying

2019-01-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12321 ) Change subject: [java] fix ITClient test retrying .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12321

[kudu-CR] KUDU2665: LBM deletes the valid live block

2019-01-30 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12308 ) Change subject: KUDU2665: LBM deletes the valid live block .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/12308/1/src/kudu

[kudu-CR] KUDU2665: LBM may delete containers with live blocks

2019-01-30 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12308 to look at the new patch set (#2). Change subject: KUDU2665: LBM may delete containers with live blocks

[kudu-CR] KUDU-2670: split more scanner and add concurrent

2019-01-30 Thread yangz (Code Review)
yangz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12323 Change subject: KUDU-2670: split more scanner and add concurrent .. KUDU-2670: split more scanner and add concurrent 1. Add a concurrent scanne

[kudu-CR] KUDU2665: LBM may delete containers with live blocks

2019-01-30 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12308 ) Change subject: KUDU2665: LBM may delete containers with live blocks .. Patch Set 2: if we comment 'blocks_being_written() == 0' in the log_b