Re: Review Request 46580: Added uriparser as a bundled dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46580/#review130179 --- Fix it, then Ship it!

Re: Review Request 44454: Enabled Sequence mount for prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/#review130192 ---

Re: Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/#review130197 ---

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46255/#review130180 --- src/slave/main.cpp (line 232)

Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46254/#review130201 --- Ship it! Ship It! - Kapil Arya On April 21, 2016, 4:21

Re: Review Request 46577: Fixed isolator cleaup issue when destroying a provisioning container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46577/#review130199 --- Patch looks great! Reviews applied: [46576, 46577] Passed

Re: Review Request 44454: Enabled Sequence mount for prepare().

> On 四月 22, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109 > > > > > > Please use a Sequence for each DockerVolume. umount A and mount B can > >

Re: Review Request 46391: Clarified several agent log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46391/#review130177 --- Patch looks great! Reviews applied: [46391] Passed command:

Review Request 46588: Added URI struct to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/ --- Review request for mesos, Gilbert Song, Artem Harutyunyan, Jie Yu, and Jojy

Review Request 46594: Added test for isolator cleanup before prepare.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46594/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy

Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46258/#review130204 --- Fix it, then Ship it! Ship It!

Re: Review Request 46577: Fixed isolator cleaup issue when destroying a provisioning container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46577/#review130207 --- Ship it! Ship It! - Jie Yu On April 22, 2016, 6:21 p.m.,

Review Request 46593: Added test for containerizer destroy while provisioning race.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46593/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy

Re: Review Request 45674: Implemented recover() for dvd isolator.

> On 四月 22, 2016, 10:20 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 181-185 > > > > > > Please do not copy the comments blindly. The comments here does not

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/#review130171 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 5:58

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130193 ---

Re: Review Request 45275: Enabled "--explicitcreate" when call "dvdcli mount".

> On 四月 22, 2016, 5:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp, lines > > 56-65 > > > > > > I think what we should do here is: > > > > 1) If 'options' is

Re: Review Request 46391: Clarified several agent log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46391/#review130170 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 3:28

Re: Review Request 46341: Stout:[2/2] Transitioned reap.cpp to `os::waitpid`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46341/#review130183 --- Ship it! Ship It! - Joris Van Remoortere On April 20, 2016,

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46344/#review130185 --- 3rdparty/libprocess/include/process/windows/winsock.hpp (line

Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46259/#review130206 --- 3rdparty/libprocess/include/process/metrics/metrics.hpp (lines

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 22, 2016, 6:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > > > > > Should that be a hashset given that we don't allow duplicate? The problem is

Re: Review Request 46469: Added support for credentials to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/#review130165 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 3:15

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review130172 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 5:28

Re: Review Request 46472: Reran `generate-endpoint-help.py` script for endpoints redirection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46472/#review130182 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 5:10

Re: Review Request 46550: Fixed slave to initialize libprocess before modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46550/#review130186 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 1:41

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/#review130196 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 46576: Fixed a mesos containerizer race destroy while preparing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46576/#review130205 --- Ship it! Ship It! - Jie Yu On April 22, 2016, 6:20 p.m.,

Re: Review Request 44454: Enabled Sequence mount for prepare().

> On April 22, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109 > > > > > > Please use a Sequence for each DockerVolume. umount A and mount B can > >

Re: Review Request 46588: Added URI struct to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/#review130232 --- Bad patch! Reviews applied: [46588, 46580] Failed command:

Re: Review Request 45671: Added version checking for dvdcli.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45671/ --- (Updated 四月 23, 2016, 2:16 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 42806: Added the fetcher plugin module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/#review130248 --- Patch looks great! Reviews applied: [42806] Passed command:

Re: Review Request 46588: Added URI struct to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/ --- (Updated April 22, 2016, 5:48 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45377: Ignored docker volume when updating container volume path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 23, 2016, 2:03 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.

> On April 22, 2016, 10:26 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/include/process/metrics/metrics.hpp, lines 55-58 > > > > > > trailing underscore? See my comment on https://reviews.apache.org/r/46258/ >

Re: Review Request 46580: Added uriparser as a bundled dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46580/ --- (Updated April 22, 2016, 5:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46220: Added documentation for Nvidia GPU support.

> On April 22, 2016, 5:55 p.m., Qian Zhang wrote: > > docs/gpu-support.md, line 440 > > > > > > Does this limitation mean that currently we do not support container > > with an image (e.g., Docker image, Appc

Re: Review Request 46588: Added URI struct to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/ --- (Updated April 22, 2016, 5:48 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 42806: Added the fetcher plugin module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/ --- (Updated April 23, 2016, 2:33 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45377: Ignored docker volume when updating container volume path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review130245 --- Patch looks great! Reviews applied: [45377] Passed command:

Re: Review Request 46580: Added uriparser as a bundled dependency.

> On April 22, 2016, 2:14 p.m., Jie Yu wrote: > > 3rdparty/libprocess/configure.ac, line 892 > > > > > > Is this some specicial autoconf thing? I don't see it being used... Oops, that's a leftover from a more

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On April 22, 2016, 6:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > > > > > Should that be a hashset given that we don't allow duplicate? > > Guangya

Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46255/ --- (Updated April 23, 2016, 4:41 a.m.) Review request for mesos, Adam B and

Re: Review Request 46168: Add subdirectory support to URI.filename field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46168/#review130235 --- Ship it! Looks great! I'll commit it with the following minor

Re: Review Request 44454: Enabled Sequence mount for prepare().

> On 四月 22, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109 > > > > > > Please use a Sequence for each DockerVolume. umount A and mount B can > >

Re: Review Request 44454: Enabled Sequence mount for prepare().

> On 四月 22, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109 > > > > > > Please use a Sequence for each DockerVolume. umount A and mount B can > >

Re: Review Request 44454: Enabled Sequence mount for prepare().

> On April 22, 2016, 9:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109 > > > > > > Please use a Sequence for each DockerVolume. umount A and mount B can > >

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 22, 2016, 6:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, line 242 > > > > > > YOu can iterate through `volumeInfos` here. > > Guangya Liu wrote: > You

Re: Review Request 46594: Added test for isolator cleanup before prepare.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46594/#review130242 --- Bad patch! Reviews applied: [46594, 46593, 46577, 46576] Failed

Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.

> On April 22, 2016, 10:24 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/include/process/logging.hpp, lines 28-31 > > > > > > Don't we prefere trailing underscores? For function parameters we use leading

Re: Review Request 46319: Added authorization to agents' `/statistics` endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review130057 --- Looks great! Just some minor points, and then we need to settle

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 21, 2016, 9:36 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > > > > > Should we use a hashset for `dockerVolumeInfos`? > > > > I am

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 22, 2016, 6:36 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/ --- (Updated 四月 22, 2016, 7:15 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46447: Windows: [2/4] Extracted `SocketError` definition in `error.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46447/#review130048 --- Ship it! Ship It! - Michael Park On April 20, 2016, 4:46

Re: Review Request 44454: Enabled Sequence mount for prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/#review130047 --- Ship it! Ship It! - haosdent huang On April 22, 2016, 6:49

Re: Review Request 44454: Enabled Sequence mount for prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/ --- (Updated 四月 22, 2016, 7:39 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- (Updated April 22, 2016, 7:18 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46472: Reran `generate-endpoint-help.py` script for endpoints redirection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46472/ --- (Updated April 22, 2016, 7:18 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 43985: Windows: [1/4] Implemented `sendfile`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43985/#review130044 --- Ship it! Committed with the following changes.

Re: Review Request 46293: Windows: [4/4] Updated `sendfile` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46293/#review130049 --- Ship it! Ship It! - Michael Park On April 20, 2016, 9:48

Re: Review Request 46285: Windows: [3/4] `sendfile` used with the typed error state of `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46285/#review130040 --- Ship it! Committed with the following change.

Re: Review Request 46318: Added helper to create test slave with injected `Authorizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46318/#review130053 --- Please add a bit more motivation to the description, especially

Re: Review Request 45265: Plugged in docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/#review130055 --- Ship it! Ship It! - haosdent huang On April 22, 2016, 7:24

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

> On April 20, 2016, 1:35 a.m., Adam B wrote: > > src/slave/http.cpp, line 354 > > > > > > Forgive my lambda-ignorance here, but are you creating this locally > > scoped pointer just so that you can expose it to

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

> On 四月 22, 2016, 1:04 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 378-380 > > > > > > Seems like we should capture the first `:` here. Otherwise, we

Re: Review Request 34646: Redirected to the leading master when current master is not the leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated April 22, 2016, 7:18 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46473/ --- (Updated April 22, 2016, 7:18 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46470: Change to explicit case statements (`UNKNOWN`) for authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46470/#review130050 --- Patch looks great! Reviews applied: [46364, 46470] Passed

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/ --- (Updated 四月 22, 2016, 7:08 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/#review130052 ---

Re: Review Request 44454: Enabled Sequence mount for prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/ --- (Updated 四月 22, 2016, 6:49 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45265: Plugged in docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/ --- (Updated 四月 22, 2016, 7:24 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45922: Added agent authorization flags.

> On April 20, 2016, 12:26 a.m., Adam B wrote: > > src/tests/cluster.hpp, line 151 > > > > > > Why do you even need the overload for the authorizer here? Seems like > > most tests will either provide --acls and use

Re: Review Request 45922: Added agent authorization flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/#review130041 --- Fix it, then Ship it! Looks great! Just one issue with

Re: Review Request 45674: Implemented recover() for dvd isolator.

> On 四月 22, 2016, 7:41 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, line 171 > > > > > > Should wait for cleanup before return like: > > ``` > >

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

> On April 20, 2016, 10:35 a.m., Adam B wrote: > > src/slave/http.cpp, line 354 > > > > > > Forgive my lambda-ignorance here, but are you creating this locally > > scoped pointer just so that you can expose it to

Re: Review Request 45671: Added version checking for dvdcli.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45671/ --- (Updated 四月 22, 2016, 9:09 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46428: Added agent flag to turn on/off docker volume reference counter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/ --- (Updated 四月 22, 2016, 9:16 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45922: Added agent authorization flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/ --- (Updated April 22, 2016, 12:11 p.m.) Review request for mesos, Adam B and

Review Request 46564: Fixed a typo in Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46564/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Review Request 46567: Passed argument by const-ref in command executor's escalated().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46567/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 45922: Added agent authorization flags.

> On April 22, 2016, 9:35 a.m., Adam B wrote: > > src/tests/cluster.cpp, line 392 > > > > > > Double underscores for variable names are discouraged (usually only > > acceptable for continuation function names). >

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

> On April 20, 2016, 10:35 a.m., Adam B wrote: > > src/tests/slave_authorization_tests.cpp, lines 110-114 > > > > > > This seems wrong. You don't even bother to reset the authenticator > > after you're done? > >

Re: Review Request 46567: Passed argument by const-ref in command executor's escalated().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46567/#review130078 --- Ship it! Ship It! - Benjamin Bannier On April 22, 2016,

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46314/#review130062 --- Patch looks great! Reviews applied: [46314] Passed command:

Re: Review Request 46220: Added documentation for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46220/#review130067 --- docs/gpu-support.md (line 440)

Re: Review Request 45922: Added agent authorization flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/ --- (Updated April 22, 2016, 12:05 p.m.) Review request for mesos, Adam B and

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ --- (Updated April 22, 2016, 12:12 p.m.) Review request for mesos, Adam B,

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

> On April 20, 2016, 10:35 a.m., Adam B wrote: > > include/mesos/authorizer/acls.proto, line 151 > > > > > > Let's consider calling this `GetEndpoint`, to match the HTTP verb? > > There may be some users that are

Re: Review Request 46501: Updated authorization.md to reflect current changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review130080 --- docs/authorization.md

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46473/#review130070 --- Patch looks great! Reviews applied: [34646, 46471, 46472, 46473]

Re: Review Request 46564: Fixed a typo in Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46564/#review130077 --- Patch looks great! Reviews applied: [46564] Passed command:

Re: Review Request 46318: Added helper to create test agent with injected `Authorizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46318/ --- (Updated April 22, 2016, 4:04 p.m.) Review request for mesos, Adam B,

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

> On April 21, 2016, 4:44 p.m., Benjamin Bannier wrote: > > src/launcher/executor.cpp, lines 90-93 > > > > > > Now that we add a fourth state documenting e.g., which states are > > initial or terminal might help

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

> On April 22, 2016, 10:22 a.m., Adam B wrote: > > src/slave/http.cpp, lines 620-622 > > > > > > Not sure why you reversed the boolean/order here, but ok. You are right, putting the expected case first makes this

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

> On April 19, 2016, 1:26 p.m., Jan Schlicht wrote: > > The test case may need to be moved into `slave_authorization_tests.cpp` > > that was added in https://reviews.apache.org/r/46318/, but that really > > depends on whether that change there gets accepted or not. I moved the test into

Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/ --- (Updated April 22, 2016, 4:04 p.m.) Review request for mesos, Adam B,

Re: Review Request 46318: Added helper to create test agent with injected `Authorizer`.

> On April 22, 2016, 9:42 a.m., Adam B wrote: > > src/tests/mesos.hpp, line 210 > > > > > > How do you know this is the set of parameters your helper will need? > > Why don't you need a containerizer, etc.? The

Re: Review Request 46469: Added support for credentials to mesos-execute.

> On April 22, 2016, 1:19 a.m., Vinod Kone wrote: > > src/cli/execute.cpp, line 754 > > > > > > I think it is ok to set principal and not secret. We should just set > > the framework info principal in that case. >

  1   2   >