On Sunday, September 9, 2018 at 4:50:38 AM UTC+2, Bekket McClane wrote:
>
> Hi,
>
> I'm currently studying some graph reduction passes.
> It seems that LoopPeeling is only used when certain flag is turn on. I'm
> curious about the status and usage of this pass
>
The pass is on by default.
>
On Monday, September 4, 2017 at 1:43:11 PM UTC+2, Caitlin Potter wrote:
>
>
> On Sep 4, 2017, at 4:08 AM, jarin via v8-dev <v8-...@googlegroups.com
> > wrote:
>
>
>
> On Friday, September 1, 2017 at 6:29:50 PM UTC+2, Jakob Kummerow wrote:
>>
>> As Yan
On Friday, September 1, 2017 at 6:29:50 PM UTC+2, Jakob Kummerow wrote:
>
> As Yang points out, microtasks are only run when the embedder asks us to,
> and per spec this is only when the execution stack is otherwise empty. (The
> exception to this is %RunMicroTasks() in mjsunit tests.)
> So we
lgtm
https://codereview.chromium.org/1287383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm with a nit.
https://codereview.chromium.org/1319703006/diff/20001/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/1319703006/diff/20001/src/compiler/typer.cc#newcode562
src/compiler/typer.cc:562: Type* myinteger = Type::Intersect(type,
integer,
lgtm
https://codereview.chromium.org/1328193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1325573004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1330033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
looks good so far.
https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):
https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc#newcode1732
src/x64/builtins-x64.cc:1732: // TODO(bmeurer): This doesn't match
lgtm
https://codereview.chromium.org/1311013008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1328783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1322703003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm with a nit.
https://codereview.chromium.org/1318713007/diff/20001/src/runtime/runtime-atomics.cc
File src/runtime/runtime-atomics.cc (right):
https://codereview.chromium.org/1318713007/diff/20001/src/runtime/runtime-atomics.cc#newcode490
src/runtime/runtime-atomics.cc:490: case
lgtm, thanks!
https://codereview.chromium.org/1312893010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/1302173007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1326643006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Benedikt Meurer,
Message:
Benedikt, could you take a look, please?
Description:
[turbofan] Do not force stack slot for eager deopt inputs.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/1307203005/
Base URL:
lgtm with a nit.
https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js
File src/array-iterator.js (right):
https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js#newcode82
src/array-iterator.js:82: !HAS_DEFINED_PRIVATE(iterator,
arrayIteratorNextIndexSymbol))
lgtm
https://codereview.chromium.org/1304163010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Benedikt Meurer,
Message:
Could you take a look, please?
Description:
Cleanup representation calculation for Phis in Crankshaft.
This replaces the counters for use representations with
simple tracking of most-general representation seen so far.
R=bmeu...@chromium.org
BUG=
Please
lgtm, although I do not fully understand why there is the call to
FindOptimalSplitPos after we find a valid split position.
https://codereview.chromium.org/1314423006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
On 2015/08/31 06:06:30, mvstanton wrote:
lgtm (rubber-stamp)
https://codereview.chromium.org/1326463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
lgtm with some non-blocking questions.
https://codereview.chromium.org/1317383002/diff/60001/src/full-codegen/arm/full-codegen-arm.cc
File src/full-codegen/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/1317383002/diff/60001/src/full-codegen/arm/full-codegen-arm.cc#newcode247
lgtm
https://codereview.chromium.org/1320363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
On 2015/08/31 22:09:51, binji wrote:
The latest spec no longer supports atomic floats.
It looks like there have been something strange going on with
CompareExchangeSeqCst on Windows.
https://codereview.chromium.org/1318713007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm.
https://codereview.chromium.org/1317383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1315113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
On 2015/08/20 23:16:13, binji wrote:
On 2015/08/20 at 05:19:58, jarin wrote:
On 2015/08/19 17:36:23, binji wrote:
https://codereview.chromium.org/1230303005/diff/120001/src/execution.cc
File src/execution.cc (right):
https://codereview.chromium.org/1230303005/diff/120001/src
lgtm
https://codereview.chromium.org/1303863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
be NumberConstant(0) if the closure is global code
+ // (rather than a function). We exclude that case here.
+ // TODO(jarin) Find a better way to check that the closure is a function.
+ if (FLAG_turbo_allocate input_type-Is(Type::Receiver())
+ closure-opcode() != IrOpcode::kNumberConstant
()) {
On 2015/08/19 at 05:26:05, Jarin wrote:
Could we perhaps pull the waiting() check into NotifyWake?
Then the waiting accessors could be private (and perhaps we could even
pull
the waiting_ flag into the critical section and make it non-atomic).
My thought here was to do a quick check
https://codereview.chromium.org/1292383007/diff/1/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/1292383007/diff/1/src/compiler/js-typed-lowering.cc#newcode1238
src/compiler/js-typed-lowering.cc:1238: Node* const closure =
lgtm
https://codereview.chromium.org/1302513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm with a question.
https://codereview.chromium.org/1230303005/diff/120001/src/execution.cc
File src/execution.cc (right):
https://codereview.chromium.org/1230303005/diff/120001/src/execution.cc#newcode418
src/execution.cc:418: if (isolate_-futex_wait_list_node()-waiting()) {
Could we
lgtm. Thanks!
https://codereview.chromium.org/1289313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/1296933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm.
I cannot shake the feeling that the hydrogen part could look much better if
we
had a better way to write else-if cascades.
https://codereview.chromium.org/1293533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
lgtm.
However, I am not a big fan of the 'if (Node* node = ...)' pattern,
especially
when there is a 'node' variable in the outer scope, so it can be easily
misread
as if (node == ...)'.
https://codereview.chromium.org/1291113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1294913005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Starzinger,
Message:
Could you take a look, please?
Description:
[turbofan] Remove the output_index field that was unused in Node::Use.
BUG=
Please review this at https://codereview.chromium.org/1294913003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
almost lgtm.
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h
File src/compiler/frame.h (right):
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode125
src/compiler/frame.h:125: ++spilled_callee_register_slot_count_ +=
count;
How about
Looking at the code closer, the OutputIndexField is never really used.
Perhaps we can remove this...
Thanks for reporting!
- Jaro.
On Sunday, August 16, 2015 at 3:26:12 AM UTC+2, Aaron Gray wrote:
Hi,
I am pretty sure I have found a bug in Node.have on line 232 in
OutputIndexField it
lgtm with a nit and a question.
https://codereview.chromium.org/1287203002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/1287203002/diff/1/src/hydrogen.cc#newcode10907
src/hydrogen.cc:10907: if (left_type-Is(Type::String())) {
Could not you say here
if
lgtm
https://codereview.chromium.org/1295433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1292033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1285723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1284853002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
One question below.
Still, could you explain why it deadlocked?
https://codereview.chromium.org/1230303005/diff/80001/src/futex-emulation.cc
File src/futex-emulation.cc (right):
https://codereview.chromium.org/1230303005/diff/80001/src/futex-emulation.cc#newcode138
src/futex-emulation.cc:138:
lgtm
https://codereview.chromium.org/1287543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1282763002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1275013004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1278873007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
I think I understand now how the spilling works, but it is very subtle.
Once you
add explanatory comments, it will be good to go.
What are the performance numbers?
https://codereview.chromium.org/1271703002/diff/80001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc
lgtm
https://codereview.chromium.org/1271703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1280483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1263033004/diff/60001/src/compiler/raw-machine-assembler.h
File src/compiler/raw-machine-assembler.h (right):
https://codereview.chromium.org/1263033004/diff/60001/src/compiler/raw-machine-assembler.h#newcode482
src/compiler/raw-machine-assembler.h:482:
(assigned,
spill_operand);
On 2015/08/04 20:34:46, Mircea Trofin wrote:
On 2015/08/04 19:39:43, Jarin wrote:
Still confused about this - where do we actually spill the deferred
block with
a
call? This move seems to be only inserted for ranges that are not
spilled.
Correct. It sets up the stage
lgtm
https://codereview.chromium.org/1269183002/diff/1/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/1269183002/diff/1/src/compiler/instruction-selector.cc#newcode1004
src/compiler/instruction-selector.cc:1004:
lgtm
https://codereview.chromium.org/1256313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1260813008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Unfortunately, I am quite confused about this change, so I have bunch of
questions.
https://codereview.chromium.org/1271703002/diff/60001/src/compiler/move-optimizer.cc
File src/compiler/move-optimizer.cc (right):
On 2015/07/31 16:09:00, Mircea Trofin wrote:
Quick update: Benedikt is on vacation; I have just returned from one.
Today, I
have been mostly catching up on email and fixing/triaging urgent issues. I
should be able to review your CLs tomorrow.
https://codereview.chromium.org/1256313003/
--
Reviewers: Yang,
Message:
Could take a look, please?
It turns out the arguments object screw-up was caused by my deoptimizer
refactoring.
Description:
[deoptimizer] Do not pass arguments markers to the debugger.
This fixes a bug introduced by r28826 (Unify decoding of deoptimization
Looking good so far.
https://codereview.chromium.org/1263033004/diff/1/src/compiler/x64/code-generator-x64.cc
File src/compiler/x64/code-generator-x64.cc (right):
https://codereview.chromium.org/1263033004/diff/1/src/compiler/x64/code-generator-x64.cc#newcode1224
Reviewers: Yang,
Message:
Could you take a look, please?
Description:
[deoptimizer] Fix the frame size calculation for debugger-inspectable frame
construction.
The calculation now takes into account the size of the arguments object
if it is present in the optimized frame.
(Yang, many thanks
https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc#newcode160
src/deoptimizer.cc:160:
data-ArgumentsStackHeight(deoptimization_index)-value() *
kPointerSize;
On 2015/08/03
lgtm
https://codereview.chromium.org/1264723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1254623002/diff/60001/test/cctest/compiler/test-run-properties.cc
File test/cctest/compiler/test-run-properties.cc (right):
https://codereview.chromium.org/1254623002/diff/60001/test/cctest/compiler/test-run-properties.cc#newcode25
lgtm. Love it!
https://codereview.chromium.org/1252623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm.
https://codereview.chromium.org/1255563002/diff/40001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1255563002/diff/40001/src/d8.cc#newcode780
src/d8.cc:780: }
How about factoring out the extraction of the worker from the args into
a helper function?
Also, could you
lgtm
https://codereview.chromium.org/1249723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
I thought it looked good to me, but the bots disagree. Could you take a
look?
(It would be great if you could describe what went wrong.)
https://codereview.chromium.org/1230303005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm with bunch of questions.
https://codereview.chromium.org/1252623003/diff/20001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1252623003/diff/20001/src/d8.cc#newcode338
src/d8.cc:338: options.set_script_executed(true);
It looks like the set_script_executed could be
lgtm
https://codereview.chromium.org/1252093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm.
I am wondering whether the extra complexity is going to pay for itself. The
special casing OperandGenerator::Use looks funky (but I do not know of a
better
way to do this).
https://codereview.chromium.org/1242303005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
One question. If this is answered, it looks good.
https://codereview.chromium.org/1255563002/diff/20001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1255563002/diff/20001/src/d8.cc#newcode1842
src/d8.cc:1842: state_ = TERMINATED;
What if we call quit() from one worker and
lgtm
https://codereview.chromium.org/1248263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Ouch, my eyes! lgtm.
https://codereview.chromium.org/1248483007/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1248483007/diff/20001/src/heap/heap.cc#newcode4012
src/heap/heap.cc:4012: kHeapObjectTag),
Can't you say
https://codereview.chromium.org/1242123006/diff/40001/src/compiler/greedy-allocator.cc
File src/compiler/greedy-allocator.cc (right):
https://codereview.chromium.org/1242123006/diff/40001/src/compiler/greedy-allocator.cc#newcode87
src/compiler/greedy-allocator.cc:87: auto instr =
lgtm. Oh boy, this is ugly.
At this point, can't we just use a standard lock + condition variable
mechanism
to protect and wait for the page's sweeping status? Would it be too slow?
E.g.,
in Heap::CanMoveObjectStart we would have to lock inside the
SweepingCompleted
check.
This funky
lgtm
https://codereview.chromium.org/1219063017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1219063017/diff/180001/src/compiler/coalesced-live-ranges.cc
File src/compiler/coalesced-live-ranges.cc (right):
https://codereview.chromium.org/1219063017/diff/180001/src/compiler/coalesced-live-ranges.cc#newcode66
src/compiler/coalesced-live-ranges.cc:66:
Scary stuff. It looks ok, but fairly brittle. Adding mstarzinger@ to have a
look.
https://codereview.chromium.org/1244693002/diff/20001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
lgtm.
Even though it would be even better if
- all the DCHECKs took into account the new flag.
- the flag was explicitly passed on the HAdd constructor (ideally as an
enum,
with the default value being the normal add) and then DCHECK that the
representations are in sync with the constructor
Looks even better, I still have two suggestions, but it is up to you.
https://codereview.chromium.org/1244693002/diff/80001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/1244693002/diff/80001/src/hydrogen-instructions.h#newcode4918
looks good with one final nit
https://codereview.chromium.org/1244693002/diff/120001/src/mips/lithium-mips.cc
File src/mips/lithium-mips.cc (right):
https://codereview.chromium.org/1244693002/diff/120001/src/mips/lithium-mips.cc#newcode1625
src/mips/lithium-mips.cc:1625:
lgtm. (but we should revisit the busy wait at some point.)
https://codereview.chromium.org/1208933006/diff/240001/src/futex-emulation.cc
File src/futex-emulation.cc (right):
https://codereview.chromium.org/1208933006/diff/240001/src/futex-emulation.cc#newcode63
src/futex-emulation.cc:63: //
lgtm.
https://codereview.chromium.org/1240553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/07/15 18:50:53, jochen wrote:
yeah, it's essentially the same as while (1) {} - nothing gets rendered,
and
after a while you'll get the tab unresponsive, kill? dialog.
With while(1) {} you still get stack checks, so you can interrupt (e.g.,
from
the debugger or some such). Here,
Adding jochen to discuss the blocking of main thread.
https://codereview.chromium.org/1208933006/diff/180001/src/futex-emulation.cc
File src/futex-emulation.cc (right):
https://codereview.chromium.org/1208933006/diff/180001/src/futex-emulation.cc#newcode80
src/futex-emulation.cc:80:
lgtm.
While I agree that volatile has no useful meaning for multi-threading, it
does
prevents some wilder compiler optimizations, and in the absence of any other
synchronization primitives it might be better than nothing. I think it is
fine
to leave out 'volatile' here because the
lgtm
https://codereview.chromium.org/1224173003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm.
Even though it might be better to put the 'once' variable on the Shell class
(the Chrome build likes to complain about static initialization).
https://codereview.chromium.org/1230403003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
lgtm
https://codereview.chromium.org/1226143003/diff/60001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1226143003/diff/60001/src/d8.cc#newcode1693
src/d8.cc:1693: if (base::NoBarrier_CompareAndSwap(join_called_, false,
true) == false) {
It looks like join_called_ is
lgtm
https://codereview.chromium.org/1232243002/diff/1/test/mjsunit/harmony/atomics.js
File test/mjsunit/harmony/atomics.js (right):
https://codereview.chromium.org/1232243002/diff/1/test/mjsunit/harmony/atomics.js#newcode166
test/mjsunit/harmony/atomics.js:166: [false, true,
lgtm
https://codereview.chromium.org/1232343002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1229233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1226143003/diff/1/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1226143003/diff/1/src/d8.cc#newcode1703
src/d8.cc:1703: case STOPPED:
Why do we want to retry when STOPPED?
Actually, I am even confused why we are trying to go through the
First batch of comments.
https://codereview.chromium.org/1208933006/diff/160001/src/futex-emulation.cc
File src/futex-emulation.cc (right):
https://codereview.chromium.org/1208933006/diff/160001/src/futex-emulation.cc#newcode18
src/futex-emulation.cc:18: FutexWaitList
lgtm
https://codereview.chromium.org/1220193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
1 - 100 of 1099 matches
Mail list logo
