FWIW, Niko is looking into simplifying the rewriting mechanism as part of
his
patch now.
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
On 2015/12/04 14:35:32, caitp wrote:
On 2015/12/04 14:34:43, caitp wrote:
> On 2015/12/04 14:32:33, rossberg wrote:
> > On 2015/12/04 14:26:09, caitp wrote:
> > > On 2015/12/04 14:24:21, rossberg wrote:
> > > > The main thing I'm confused about is why we nee
The main thing I'm confused about is why we need the rewriting queue. What
prevents you from invoking the rewriting right at the time where you
currently
just queue it up?
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/12/04 14:26:09, caitp wrote:
On 2015/12/04 14:24:21, rossberg wrote:
> The main thing I'm confused about is why we need the rewriting queue.
What
> prevents you from invoking the rewriting right at the time where you
currently
> just queue it up?
The main thing is the
On 2015/12/04 15:31:49, caitp wrote:
On 2015/12/04 15:16:33, rossberg wrote:
> On 2015/12/04 14:35:32, caitp wrote:
> > On 2015/12/04 14:34:43, caitp wrote:
> > > On 2015/12/04 14:32:33, rossberg wrote:
> > > > On 2015/12/04 14:26:09, caitp wrote:
> > > >
Some quick thoughts.
Option (4) is a non-starter. Section numbers are not stable across spec
releases.
Option (3) doesn't sound bad, although it's not quite clear what the
criteria for putting something into objects vs runtime vs the new dir would
be. If we introduced a third category, not only
https://codereview.chromium.org/1317033005/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1317033005/diff/20001/src/preparser.h#newcode3288
src/preparser.h:3288:
!IsArrowFunction(result->AsFunctionLiteral()->kind())) {
On 2015/09/19 21:34:36, caitp
Hm, I don't quite understand this CL. It seems to special-case for-loops,
but
there are many other constructs that could introduce conflicting bindings.
Shouldn't these conflicts be detected in a more central place?
Specifically, I
think you want to invoke something similar to the existing
https://codereview.chromium.org/1272673003/diff/230001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1272673003/diff/230001/src/parser.h#newcode1324
src/parser.h:1324: !is_rest && pattern->IsVariableProxy() && initializer
== nullptr;
On 2015/09/02 20:11:31, caitp
Igor, given that Toon is away, can you perhaps have a look at this CL?
https://codereview.chromium.org/1239803004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev"
On 2015/09/02 12:22:32, ruv wrote:
On 2015/08/19 16:10:23, rossberg wrote:
> - In the parser, if a function has a sloppy direct eval, introduce an
additional varblock scope around each non-simple (desugared) parameter, as
required by the spec to contain possible dynamic var bindings.
Co
Parser changes LGTM, haven't looked at the rest.
https://codereview.chromium.org/1272673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
LGTM modulo comment
https://codereview.chromium.org/1314203002/diff/40001/test/mjsunit/strong/function-arity.js
File test/mjsunit/strong/function-arity.js (left):
https://codereview.chromium.org/1314203002/diff/40001/test/mjsunit/strong/function-arity.js#oldcode220
Reviewers: adamk,
Message:
Hi Adam, this is as far as I got so far. Please feel free to grab. I just
got it
to compile, but currently breaks some existing stuff. I didn't yet get to
finding out why.
Description:
[es6] Implement destructuring for `catch`
WIP
BUG=v8:811
LOG=N
Please review
lgtm
https://codereview.chromium.org/1318693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1309523005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1312413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Looks mostly good to me, I just wonder how confident we can be that using
IS_CALLABLE everywhere doesn't allow tons of cases we don't actually handle.
https://codereview.chromium.org/1316933002/diff/1/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/1312613003/diff/60001/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1312613003/diff/60001/src/scopes.h#newcode232
src/scopes.h:232: void SetNonlinear() { scope_nonlinear_ = true; }
On 2015/08/26 11:30:30, Michael Starzinger wrote:
Isn't
On 2015/08/26 12:07:58, rossberg wrote:
https://codereview.chromium.org/1312613003/diff/60001/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1312613003/diff/60001/src/scopes.h#newcode232
src/scopes.h:232: void SetNonlinear() { scope_nonlinear_ = true; }
On 2015/08/26
lgtm
https://codereview.chromium.org/1314053003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1317843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1305383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Friendly ping.
https://codereview.chromium.org/1303013007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/1316633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1311163002/diff/1/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1311163002/diff/1/src/scopes.h#newcode133
src/scopes.h:133: bool is_optional, bool is_rest, bool* is_duplicate);
On 2015/08/24 17:51:00, adamk wrote:
Two bools in a row
https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc#newcode116
src/ast-expression-visitor.cc:116: VisitExpression(label);
Why is the label
https://codereview.chromium.org/1303013007/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1303013007/diff/1/src/parser.cc#newcode4390
src/parser.cc:4390: CheckConflictingVarDeclarations(param_scope,
CHECK_OK);
On 2015/08/25 20:18:12, Dan Ehrenberg wrote:
Not
lgtm
https://codereview.chromium.org/1314843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1314843002/diff/1/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1314843002/diff/1/src/ast-expression-visitor.cc#newcode235
src/ast-expression-visitor.cc:235: void
AstExpressionVisitor::VisitYield(Yield*
lgtm
https://codereview.chromium.org/1300103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1315823002/diff/20001/src/interpreter/bytecode-generator.cc
File src/interpreter/bytecode-generator.cc (right):
https://codereview.chromium.org/1315823002/diff/20001/src/interpreter/bytecode-generator.cc#newcode339
src/interpreter/bytecode-generator.cc:339:
13:18:18, wingo wrote:
On 2015/08/25 12:55:56, rossberg wrote:
I wonder, does rest actually need special treatment here? Can't it
simply be
parsed as spread in the else case below, and later be rewritten?
I think it does need special treatment. All the other places that
parse spread
(array
https://codereview.chromium.org/1300103005/diff/11/src/expression-classifier.h
File src/expression-classifier.h (right):
https://codereview.chromium.org/1300103005/diff/11/src/expression-classifier.h#newcode235
src/expression-classifier.h:235: // parameter
Nit: period
https://codereview.chromium.org/1287063004/diff/60001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1287063004/diff/60001/src/parser.cc#newcode3916
src/parser.cc:3916: parser_-Check(Token::ASSIGN)) {
On 2015/08/24 14:10:10, wingo wrote:
How on earth does this work?
https://codereview.chromium.org/1314543005
https://codereview.chromium.org/1287063004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
On 2015/08/24 16:01:48, wingo wrote:
lgtm with test nits
https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc#newcode3750
https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1314543005/diff/1/test/cctest/test-parsing.cc#newcode3750
test/cctest/test-parsing.cc:3750: // ({a} = {}) = {},
On 2015/08/24 16:01:47, wingo
lgtm
https://codereview.chromium.org/1310213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1286383005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
You might want to consider changing the CL title, because the actual revert
is
not even in it, IIUC.
https://codereview.chromium.org/1300103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
/cctest/expression-type-collector.h#newcode13
test/cctest/expression-type-collector.h:13: // Macros to define checking
of a tree walk.
On 2015/08/20 21:35:47, bradn wrote:
On 2015/08/20 16:34:27, rossberg wrote:
That's some fancy macro fu there! :)
Not sure whether that's a compliment
lgtm
https://codereview.chromium.org/1303843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/20 21:24:48, Dan Ehrenberg wrote:
Such a weird spec, but your implementation makes sense. I can't think of a
simpler way. Why don't the default parameter direct evals just run within
the
function's existing var scope? (Or, why 1JS?!)
Because the var scope is not in scope for
https://codereview.chromium.org/1292753007/diff/1/src/contexts.cc
File src/contexts.cc (right):
https://codereview.chromium.org/1292753007/diff/1/src/contexts.cc#newcode65
src/contexts.cc:65: return ext-IsSloppyBlockWithEvalContextExtension()
On 2015/08/20 10:30:00, Michael Starzinger wrote:
LGTM
It's sad that this makes the use of private symbols unmodular. But I guess
uniformity wins...
https://codereview.chromium.org/1293493004/diff/1/src/array-iterator.js
File src/array-iterator.js (right):
https://codereview.chromium.org/1293493004/diff/1/src/array-iterator.js#newcode16
lgtm
https://codereview.chromium.org/1302893002/diff/1/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/1302893002/diff/1/src/scanner.h#newcode367
src/scanner.h:367: if (my_bookmark_) scanner_-DropBookmark();
Hm, this _does_ change the semantics, doesn't it? It looks
https://codereview.chromium.org/1288773007/diff/40001/src/ast-expression-visitor.h
File src/ast-expression-visitor.h (right):
https://codereview.chromium.org/1288773007/diff/40001/src/ast-expression-visitor.h#newcode26
src/ast-expression-visitor.h:26: void* operator new(size_t size, Zone*
zone)
, rossberg wrote:
Hm, this _does_ change the semantics, doesn't it? It looks more correct,
though.
Yes, good observation. But I think the case where this makes a difference
shouldn't happen in practice, so it shouldn't change behaviour overall.
And if the case does happen, this should fix
https://codereview.chromium.org/1286383005/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1286383005/diff/20001/src/preparser.h#newcode2288
src/preparser.h:2288: result =
Nit: unnecessary line break?
lgtm
https://codereview.chromium.org/1306583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM (rubberstamp)
https://codereview.chromium.org/1301583005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
On 2015/08/11 21:20:19, adamk wrote:
What do you think?
LGTM. Never quite got the point of this test.
https://codereview.chromium.org/1275423006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/1288313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1290013002/diff/20001/test/mjsunit/harmony/new-target.js
File test/mjsunit/harmony/new-target.js (right):
https://codereview.chromium.org/1290013002/diff/20001/test/mjsunit/harmony/new-target.js#newcode390
test/mjsunit/harmony/new-target.js:390:
https://codereview.chromium.org/1287063004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1287063004/diff/1/src/parser.cc#newcode4328
src/parser.cc:4328: Expression* param =
On 2015/08/12 18:22:59, adamk wrote:
I think this should be called initializer
That
lgtm
https://codereview.chromium.org/1290743005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1290193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1287063004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1287063004/diff/1/src/parser.cc#newcode3908
src/parser.cc:3908: // TODO(rossberg): allow initializers
Need to come up with a test that actually triggers this.
https
lgtm
https://codereview.chromium.org/1290703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM, I'm fine with landing this as a temporary hack, but can we have a
couple
of comments (and perhaps TODOs) clarifying why it was introduced?
CC'ing Benedikt.
https://codereview.chromium.org/1281883002/diff/1/src/scopeinfo.cc
File src/scopeinfo.cc (right):
On 5 August 2015 at 22:18, Adam Klein ad...@chromium.org wrote:
On Wed, Aug 5, 2015 at 7:23 AM, rossb...@chromium.org wrote:
https://codereview.chromium.org/1274653002/diff/1/src/i18n.js
File src/i18n.js (right):
https://codereview.chromium.org/1274653002/diff/1/src/i18n.js#newcode2019
On 2015/08/06 17:12:43, adamk wrote:
Can you add some tests with arrow functions? Want to make sure that's
covered,
as some of the logic upstream is different (though should all flow
through the
same place).
That's funny: I actually had tests for arrow functions, and then spent an
hour
I also tried digging into it, but without much success. Something must be
pointing into the wild, but I couldn't find out what.
Some cases fail with an invalid access. I'd try to breakpoint on those in
the
debugger and try to figure out what there pointing at and where it is coming
from.
lgtm
https://codereview.chromium.org/1273543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1271073002/diff/1/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/1271073002/diff/1/src/scanner.cc#newcode1078
src/scanner.cc:1078: // Accept both \u and \u{xx}.
Nit: reformat.
LGTM, modulo build problem
https://codereview.chromium.org/1262913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
https://codereview.chromium.org/1274653002/diff/1/src/i18n.js
File src/i18n.js (right):
https://codereview.chromium.org/1274653002/diff/1/src/i18n.js#newcode2019
src/i18n.js:2019: %FunctionSetLength(StringNormalizeJS, 0);
I'd prefer avoiding the runtime call and instead define the function
with
lgtm
https://codereview.chromium.org/1270393002/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/1270393002/diff/1/src/runtime/runtime-classes.cc#newcode266
src/runtime/runtime-classes.cc:266:
lgtm
https://codereview.chromium.org/1274653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1270423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1257063003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1259183005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1260053004/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1260053004/diff/20001/src/parser.cc#newcode4436
src/parser.cc:4436: VariableMode fvar_mode = use_strict_const ? CONST :
CONST_LEGACY;
Wait, I thought the idea was that
LGTM, thanks!
https://codereview.chromium.org/1253103006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
https://codereview.chromium.org/1259013003/diff/1/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1259013003/diff/1/src/parser.h#newcode559
src/parser.h:559: DCHECK(arity == params.length());
On 2015/08/03 18:20:23, adamk wrote:
DCHECK_EQ.
Done.
Also, it will
https://codereview.chromium.org/1250733005/diff/310001/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/1250733005/diff/310001/src/macros.py#newcode101
src/macros.py:101: macro IS_SIMD_OBJECT(arg) =
(%_IsSimdObject(arg));
Please revert this renaming. SIMD values
LGTM, but Dan should have a look as well.
https://codereview.chromium.org/1230343003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
LGTM, I'm okay with this.
https://codereview.chromium.org/1267773009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2015/08/03 14:31:31, bbudge wrote:
On 2015/08/03 14:10:34, titzer wrote:
On 2015/08/03 13:54:42, Yang wrote:
On 2015/08/03 13:03:06, commit-bot: I haz the power wrote:
Patchset 11 (id:??) landed as
https://crrev.com/7b9670b63b486ba3b6f8a569552d307282dbccfd
Cr-Commit-Position:
On 2015/08/04 15:17:58, mtbrandyberry wrote:
On 2015/08/04 14:24:43, commit-bot: I haz the power wrote:
Patchset 1 (id:??) landed as
https://crrev.com/479e0c034736f7aab301daab190f5d8a58d20d7d
Cr-Commit-Position: refs/heads/master@{#30001}
Another instance of this same issue exists on line
Addressed the arity issue by separating out a FormalParametersBase class
that
does not have an arity field, so that it only exists in the preparser. It
is now
updated in PreParserTraits::AddFormalParameter.
https://codereview.chromium.org/1259283002/diff/1/src/parser.cc
File src/parser.cc
https://codereview.chromium.org/1259283002/diff/40001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1259283002/diff/40001/src/parser.h#newcode556
src/parser.h:556: const Parameter at(int i) const { return params[i]; }
On 2015/08/04 17:25:04, adamk wrote:
On 2015/08/04
IS_SIMD_VALUE(arg) = (IS_FLOAT32X4(arg)
|| IS_INT32X4(arg) || IS_BOOL32X4(arg) || IS_INT16X8(arg) ||
IS_BOOL16X8(arg) || IS_INT8X16(arg) || IS_BOOL8X16(arg));
On 2015/07/30 13:46:58, bbudge wrote:
On 2015/07/29 14:37:55, rossberg wrote:
Hm, this seems rather expensive. It is used on some
));
On 2015/07/30 15:12:24, rossberg wrote:
I'm surprised this actually works! See above, you should have written
%IsSimdValue here.
Drive-by explanation of why this works: since a recent refactor (by Sven I
think
it was), the %_ form works for all runtime calls, and the backends fall
back
On 2015/07/30 16:21:27, bbudge wrote:
On 2015/07/30 15:50:39, rossberg wrote:
On 2015/07/30 15:34:58, adamk wrote:
https://codereview.chromium.org/1250733005/diff/230001/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/1250733005/diff/230001/src/macros.py
lgtm
https://codereview.chromium.org/1264823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1266573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1256323004/diff/20001/src/runtime.js
File src/runtime.js (left):
https://codereview.chromium.org/1256323004/diff/20001/src/runtime.js#oldcode769
src/runtime.js:769: if (IS_SYMBOL_WRAPPER(x)) throw
MakeTypeError(kSymbolToPrimitive);
On 2015/07/28 19:07:30,
Mostly looking good, but I wonder about the cost of the IS_SIMD_VALUE
predicate.
https://codereview.chromium.org/1250733005/diff/210001/src/harmony-simd.js
File src/harmony-simd.js (right):
https://codereview.chromium.org/1250733005/diff/210001/src/harmony-simd.js#newcode35
lgtm
https://codereview.chromium.org/1260273002/diff/20001/src/runtime.js
File src/runtime.js (left):
https://codereview.chromium.org/1260273002/diff/20001/src/runtime.js#oldcode796
src/runtime.js:796: if (IS_FLOAT32X4(x)) throw
MakeTypeError(kSimdToNumber);
Perhaps add a comment explaining
lgtm
https://codereview.chromium.org/1258883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1247443004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1247443004/diff/1/src/parser.cc#newcode4306
src/parser.cc:4306: if (parameters.has_rest) return false;
On 2015/07/23 11:12:48, Michael Starzinger wrote:
This semantic
Also added a test for super calls.
https://codereview.chromium.org/1244423003/diff/1/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1244423003/diff/1/src/scopes.h#newcode486
src/scopes.h:486: // Find the first function, script, or eval scope.
This is the scope
On
lgtm
https://codereview.chromium.org/1240093005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1251933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Looks good, just a nit.
https://codereview.chromium.org/1240093005/diff/70001/src/dateparser.cc
File src/dateparser.cc (right):
https://codereview.chromium.org/1240093005/diff/70001/src/dateparser.cc#newcode84
src/dateparser.cc:84: if (hour == 24 minute == 0 second == 0
millisecond == 0) {
lgtm
https://codereview.chromium.org/1235153006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Btw, can't you remove rest_parameter_ and rest_index_ from Scope now?
https://codereview.chromium.org/1235153006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
, adamk wrote:
On 2015/07/21 10:25:37, rossberg wrote:
Some of the tests now become a bit circular (relying on the
correctness of
Promise.resolve/then to test the correctness of
Promise.resolve/then). But I
don't have a better idea either.
I could switch them all to use %EnqueueMicrotask
1 - 100 of 2298 matches
Mail list logo
