Re: [Openocd-development] [PATCH] Unused variables
On Thu, Oct 20, 2011 at 7:35 AM, Peter Stuge pe...@stuge.se wrote: Øyvind Harboe wrote: I'm thinking a bit about how I can draw up some graphs on this... Graphing number of commits is easy, but graphing the review is difficult. Before we got Gerrit going I decided that I could no longer spend time submitting patches to the official repository, much as I wanted to. Some graphing I've been thinking about: - plot a number that shows the redundancy in maintainers. I.e. are we relying on a single maintainer or are there multiple maintainers who commit/submit patches? Plot standard deviation of % of commits grouped into maintainers. Do this per week to show how the project develops. - plot # of lines of code / time committed. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
Øyvind Harboe wrote: Some graphing I've been thinking about: - plot a number that shows the redundancy in maintainers. I.e. are we relying on a single maintainer or are there multiple maintainers I've so far taken infinitely many more commits from Gerrit into openocd.git than before. Much more effort to deal with patch files. Committed LOC is a function of review, but not completely accurate, since review unfortunately sometimes also leads to nothing. //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
On Thu, Oct 20, 2011 at 8:38 AM, Peter Stuge pe...@stuge.se wrote: Øyvind Harboe wrote: Some graphing I've been thinking about: - plot a number that shows the redundancy in maintainers. I.e. are we relying on a single maintainer or are there multiple maintainers I've so far taken infinitely many more commits from Gerrit into openocd.git than before. Much more effort to deal with patch files. Ca. 2 weeks ago, I decided I could no longer commit patches and stopped doing so. Nobody else stepped up. This is why Gerrit forced itself forward as the only viable solution. Don't think that I didn't notice that you have pushed infinitely many more patches to the repository than before! :-) -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
openocd-development-boun...@lists.berlios.de wrote: Jon Povey wrote: this additional barrier to contributing does put me and others off contributing in future. Using Git is also a barrier for some, perhaps even for many. Gerrit is new, so sure there will be resistance. Maybe sometime it will be just as common as Git itself. I think the learning curve for Git is much steeper than for Gerrit. For sure. But I've had to learn git already for other reasons :) Please look at the updated HACKING file, or my previous email, for an overview of the quick and simple steps to use Gerrit: You need an OpenID from somewhere (let me know if you want one from me) You need to register on a web page and pick a username You need to set an HTTP password or upload a public SSH key The above takes not two minutes. A bit of a simplification, you also need to do the git-side setup, and have the general slowdown of fumbling around a bit until you get the idea of the new workflow. But not a huge amount of work, I agree. An interesting fact is that in the project where I've seen Gerrit introduced there were several new contributors sending commits, who had previously never been seen on the mailing list. I was surprised, but in a good way! There will be new contributors coming along to projects all the time, of course.. Though I suppose maybe the gerrit way of doing things could be preferable to some as it involves less human interaction and discussion on mailing lists, maybe for people who are wary of getting flamed for incorrect email setup (or signatures - sorry!) or who are not confident in their English. Great if gerrit works well for OpenOCD, I hope it does. I just wanted to make the point that it does involve some extra hassle to get started contributing, and that extra barrier and possible negative effects did not seem to have been mentioned. Most of the discussion seemed to be maintainers or energetic contributors enthusing about how jazzy gerrit was going to be. -- Jon Povey jon.po...@racelogic.co.uk Racelogic is a limited company registered in England. Registered number 2743719 . Registered Office Unit 10, Swan Business Centre, Osier Way, Buckingham, Bucks, MK18 1TB . The information contained in this electronic mail transmission is intended by Racelogic Ltd for the use of the named individual or entity to which it is directed and may contain information that is confidential or privileged. If you have received this electronic mail transmission in error, please delete it from your system without copying or forwarding it, and notify the sender of the error by reply email so that the sender's address records can be corrected. The views expressed by the sender of this communication do not necessarily represent those of Racelogic Ltd. Please note that Racelogic reserves the right to monitor e-mail communications passing through its network ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
Øyvind Harboe wrote: If you want to spend the time taking other people's patches and pushing them to Gerrit so they don't have to, go right ahead. Obviously not if I am not in a hurry to take the time to setup for gerrit even for myself. Don't think the sarcasm was helpful there. We're starting to gather data that we're getting *more* and *better* patches submitted to the Git repository. We also see that the less active maintainers are now reviewing and submitting to the repository. That's great if it ends up being a good thing for the project when hindsight becomes available. I hope it does. -- Jon Povey jon.po...@racelogic.co.uk Racelogic is a limited company registered in England. Registered number 2743719 . Registered Office Unit 10, Swan Business Centre, Osier Way, Buckingham, Bucks, MK18 1TB . The information contained in this electronic mail transmission is intended by Racelogic Ltd for the use of the named individual or entity to which it is directed and may contain information that is confidential or privileged. If you have received this electronic mail transmission in error, please delete it from your system without copying or forwarding it, and notify the sender of the error by reply email so that the sender's address records can be corrected. The views expressed by the sender of this communication do not necessarily represent those of Racelogic Ltd. Please note that Racelogic reserves the right to monitor e-mail communications passing through its network ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
Actually, in some ways nothing has changed when we switched to Gerrit. Before Gerrit, OpenOCD maintainers had stopped lifting patches into git and now we don't lift them into Gerrit. Same thing, except with Gerrit contributors (or anyone) have the option of lifting patches into Gerrit themselves. That's great if it ends up being a good thing for the project when hindsight becomes available. I hope it does. We decided to switch to Gerrit only after catastrophic failure of the existing process. I stopped submitting patches for two weeks and nobody else submitted. Clearly the process was broken. Things have improved infinitely after we introduced Gerrit. Patches are now being submitted again. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Gerrit background
First of all, I'd like everybody to stand up and give a big hand to Spencer who's through his efforts has saved OpenOCD from a slow torturous demise! Why was Gerrit introduced? In some ways nothing has changed when we switched to Gerrit. Before Gerrit, OpenOCD maintainers had stopped lifting patches into git. I've tried to recruit new maintainers, that too. The existing process had failed catastrophically. This is not a matter of policy or opinion, it's a fact. What's changed with Gerrit? OpenOCD maintainers still don't lift patches into Gerrit. Same thing, except with Gerrit contributors (or anyone) have the option of lifting patches into Gerrit themselves. Things have improved infinitely after we introduced Gerrit. Patches are now being submitted again. However, the maintainers won't stop there. We've introduced a build server(Jenkins) that builds all patches and checks for warnings, etc. automatically so contributors can weed out all those nits before anyone look at their patches. Who knows what percentage of fixes to OpenOCD that ever make it into the repository. 10%? 5%? 50%? With Gerrit we've raised it from 0% to n%. Again! I'd like everybody to give a big round of applause to Spencer who's spent the time fixing the OpenOCD process by reading up on and setting up the Gerrit+Jenkins server -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
On Thu, Oct 20, 2011 at 3:23 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: First of all, I'd like everybody to stand up and give a big hand to Spencer who's through his efforts has saved OpenOCD from a slow torturous demise! ... Who knows what percentage of fixes to OpenOCD that ever make it into the repository. 10%? 5%? 50%? With Gerrit we've raised it from 0% to n%. Again! I'd like everybody to give a big round of applause to Spencer who's spent the time fixing the OpenOCD process by reading up on and setting up the Gerrit+Jenkins server I agree, this is great work. I am not a programmer myself and I can only contribute by testing or provide some suggestions based on my experiences with testing of other projects (libusb, libusb-win32, libftdi, etc). So I am kind of an outsider of this git/gerrit stuff (I admit I know very little of git, even less about gerrit), but from what I see so far, I think this is a good move. -- Xiaofan ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
I agree, this is great work. I am not a programmer myself and I can only contribute by testing or provide some suggestions based on my experiences with testing of other projects (libusb, libusb-win32, libftdi, etc). So I am kind of an outsider of this git/gerrit stuff (I admit I know very little of git, even less about gerrit), but from what I see so far, I think this is a good move. Still you can get a Gerrit account to read over patches and give comments! All you need is a web browser, you can do it on the train using your cell phone if you're a commuter :-) If you give a patch your approval, then that input will be very much appreciated and result in real improvements to code and patches being committed more rapidly. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
On Thu, 20 Oct 2011 07:18:18 +0200 Peter Stuge pe...@stuge.se wrote: You need an OpenID from somewhere (let me know if you want one from me) You need to register on a web page and pick a username You need to set an HTTP password or upload a public SSH key The above takes not two minutes. If you have no idea what OpenID is, have only a basic understanding of git and want to first understand what you are doing to avoid stupid mistakes, then it takes maybe an hour or two to get up and working. But i have to say, comparing patch submission with gerrit and w/o, i think that gerrit is by far superior to anything i've seen until now. Yes, the first patch takes quite a bit of time. But then it's just like pushing patches to an upstream repo. And resubmitting patches is damn easy and patch managment even more so. That said, i like gerrit, but dont underestimate the first hurdle to get it working. Attila Kinali -- The trouble with you, Shev, is you don't say anything until you've saved up a whole truckload of damned heavy brick arguments and then you dump them all out and never look at the bleeding body mangled beneath the heap -- Tirin, The Dispossessed, U. Le Guin ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Only every second programming works
Akos Vandra wrote: 1. (in reply to freddie choppin) As far as I understand, reset halt is not supported on my target because srst pulls trst. Note that this was set incorrectly for the lpc17xx chip. Double check if the setting in openocd really actually matches your hardware. You need to check both chip and the board schematic. //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Only every second programming works
I know what TRST is, but not SRST. Would it be the normal chip reset? Ákos On 20 October 2011 11:12, Peter Stuge pe...@stuge.se wrote: Akos Vandra wrote: 1. (in reply to freddie choppin) As far as I understand, reset halt is not supported on my target because srst pulls trst. Note that this was set incorrectly for the lpc17xx chip. Double check if the setting in openocd really actually matches your hardware. You need to check both chip and the board schematic. //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Only every second programming works
Akos Vandra wrote: I know what TRST is, but not SRST. Would it be the normal chip reset? Right, system reset. //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] gitweb down?
Hi, seems like the gitweb for OpenOCD is down? E.g. the links such as http://openocd.zylin.com/gitweb/?p=openocd.git;a=commit;h=a756b1bcdffef34a6d60d7a2706da9574663f544 no longer work (they did yesterday). There are links from Gerrits pages to the gitweb install, for example (and that's a good thing; please don't drop gitweb, I for one find it very useful; the commitdiff view there is the best one for me to review patches as a whole). If possible, please also change Gerrit to point to a=commitdiff instead of a=commit as above, that's much more useful, IMHO. Thanks. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
What exactly is checked by jenkins currently? I suggest at least one build with the default ./configure (no options) and one with as many ./configure options enabled as is possible on the build host. It's very early days still and we're still sorting out problems. We have ambitions to do lots of testing automatically, including everything you mentioned. Definitely we want -Werror and we already do. We're also considering adding clang static analysis, but that's some ways off still. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] gitweb down?
On 20 October 2011 11:49, Uwe Hermann u...@hermann-uwe.de wrote: Hi, seems like the gitweb for OpenOCD is down? E.g. the links such as http://openocd.zylin.com/gitweb/?p=openocd.git;a=commit;h=a756b1bcdffef34a6d60d7a2706da9574663f544 no longer work (they did yesterday). There are links from Gerrits pages to the gitweb install, for example (and that's a good thing; please don't drop gitweb, I for one find it very useful; the commitdiff view there is the best one for me to review patches as a whole). If possible, please also change Gerrit to point to a=commitdiff instead of a=commit as above, that's much more useful, IMHO. my mistake, changed some permission - all fixed now. for info gitweb is now working on jenkins too. Spen ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] gitweb down?
On 20 October 2011 12:06, Spencer Oliver s...@spen-soft.co.uk wrote: On 20 October 2011 11:49, Uwe Hermann u...@hermann-uwe.de wrote: Hi, seems like the gitweb for OpenOCD is down? E.g. the links such as http://openocd.zylin.com/gitweb/?p=openocd.git;a=commit;h=a756b1bcdffef34a6d60d7a2706da9574663f544 no longer work (they did yesterday). There are links from Gerrits pages to the gitweb install, for example (and that's a good thing; please don't drop gitweb, I for one find it very useful; the commitdiff view there is the best one for me to review patches as a whole). If possible, please also change Gerrit to point to a=commitdiff instead of a=commit as above, that's much more useful, IMHO. makes sense - I have changed to use commitdiff Cheers Spen ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
On Thu, Oct 20, 2011 at 3:33 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: I agree, this is great work. I am not a programmer myself and I can only contribute by testing or provide some suggestions based on my experiences with testing of other projects (libusb, libusb-win32, libftdi, etc). So I am kind of an outsider of this git/gerrit stuff (I admit I know very little of git, even less about gerrit), but from what I see so far, I think this is a good move. Still you can get a Gerrit account to read over patches and give comments! All you need is a web browser, you can do it on the train using your cell phone if you're a commuter :-) If you give a patch your approval, then that input will be very much appreciated and result in real improvements to code and patches being committed more rapidly. Done. Just post my first comment. -- Xiaofan ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
On Thu, Oct 20, 2011 at 7:59 PM, Xiaofan Chen xiaof...@gmail.com wrote: On Thu, Oct 20, 2011 at 3:33 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: Still you can get a Gerrit account to read over patches and give comments! All you need is a web browser, you can do it on the train using your cell phone if you're a commuter :-) If you give a patch your approval, then that input will be very much appreciated and result in real improvements to code and patches being committed more rapidly. Done. Just post my first comment. I feel the following category is too coarse. +1 Looks good to me, but someone else must approve 0 No score -1 I would prefer that you didn't submit this I would like to have something like, Looks pretty good, but some enhancements are needed. -1 is too harsh in the case of the J-Link libusb-1.0 patch. 0 rather says nothing. And I do not want to give 1 in this case since I think some changes are necessary. -- Xiaofan ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] arm-jtag-ew + swd
On Thu, Oct 20, 2011 at 4:59 AM, Peter Stuge pe...@stuge.se wrote: 1. Continue what David Brownell worked on for FT2232-based adapters 2. Try Tomek's libswd, which I think works so far primarily with (only some?) FT2232-based adapters These are now joined into one :-) Transport and driver for ft2232 are now complete, just need to fix the target so not that much work left, damn im so multiplexed recently :-( 3. Use a Versaloon (e.g. Versaloon Mini, see http://www.versaloon.com/ ) and Simon's patches to OpenOCD Yup. it can upload firmware from what I saw in the logs :-) -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
Xiaofan Chen wrote: -1 is too harsh in the case of the J-Link libusb-1.0 patch. I think it fits, because: I think some changes are necessary. This is what you say with -1. You don't think this should be added exactly as-is. It can sometimes be nice to use the comment field in addition to inline comments, to expand a little in general on the chosen scoring and what needs further improvement, if that isn't clear from inline comments already. -1 isn't Never ever but rather Not yet. The what is missing has to be explained manually, which I think is a very important step. (Ie. writing concrete comments, as you did.) I mean, there is no point to try to create a multi-choice selection that will have one option for every case, because every change will most likely need different fixes. It's important for both contributors and reviewers to remember what +1 and -1 each means; +1 says that the change should be included exactly as it is, and -1 says that you want something to be improved first. Also remember that the score is only for the patch set, and not for the entire change. After the commit has been changed locally, and a new version of the commit has been pushed, it will be shown as a new patch set, and that patch set will receive a new score. //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
On Thu, Oct 20, 2011 at 9:14 PM, Peter Stuge pe...@stuge.se wrote: Xiaofan Chen wrote: -1 is too harsh in the case of the J-Link libusb-1.0 patch. I think it fits, because: I think some changes are necessary. This is what you say with -1. You don't think this should be added exactly as-is. It can sometimes be nice to use the comment field in addition to inline comments, to expand a little in general on the chosen scoring and what needs further improvement, if that isn't clear from inline comments already. -1 isn't Never ever but rather Not yet. The what is missing has to be explained manually, which I think is a very important step. (Ie. writing concrete comments, as you did.) Then please change the wording of -1 +1 Looks good to me, but someone else must approve 0 No score -1 I would prefer that you didn't submit this If the contributor see a -1 and refer to the above, I do not think it is that encouraging. :-). -- Xiaofan ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Command-line paths problem in Windows
Hi! The most recent OpenOCD behaves differently on Windows than 0.5.0 (and before) and in my opinion the direction of change is to worse. OpenOCD 0.5.0 could be run this way: openocd -f interface/jtagkey.cfg -f target/stm32.cfg And it worked fine. Current OpenOCD when trying this gives: Runtime Error: embedded:startup.tcl:58: couldn't read file D:openocd-devopenocd -0.6.0-dev-11102001452in../interface/jtagkey.cfg: No such file or directory in procedure 'script' at file embedded:startup.tcl, line 58 The only working version that I've found is: openocd -f ../interface/jtagkey.cfg -f ../target/stm32.cfg But that's not all. Other differences: 1. In 0.5.0 you could use slash or backslash (which is more correct in Windows) - no difference. Now only slash works, backslash is ommited and replaced with... nothing... 2. When running OpenOCD as External Tool from Eclipse I always left Working Dir empty and it worked fine, now I have to specify this directory for OpenOCD to work - probably because backslashes in Windows paths are replaced with nothing... I think that the root cause for the problem is because backslashes are now treated differently. Can that be fixed? Is that a problem of OpenOCD or JimTCL or maybe you don't consider this a problem at all? 4\/3!! ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Building OpenOCD for Windows
Hi! I've prepared a package but I've found an inconvenience in handling paths in new version (see other thread) so I'll see whether there's a will and possibility to fix/change that before publishing. If you need it now I can send you the package. 4\/3!! ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Building OpenOCD for Windows
On 2011-10-20 01:42, Peter Stuge wrote: Maybe you can also describe how you build them? No magic here - it's just much simpler to do crosscompilation on Linux than fighting natively in Windows. The cause of problems in Windows is that OpenOCD needs many tools to be compiled. libftdi needs even more (cmake). Setting them all under MinGW or Cygwin seems to me like too much work because in any Linux distro most of them are present by default or can be installed with a few clicks. 4\/3!! ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
Xiaofan Chen wrote: I think some changes are necessary. This is what you say with -1. .. Then please change the wording of -1 +1 Looks good to me, but someone else must approve 0 No score -1 I would prefer that you didn't submit this If the contributor see a -1 and refer to the above, I do not think it is that encouraging. :-). I think it is very important to always write some explanations for why a change should not be submitted (which is the Gerrit term for adding the change into the public repository), so that the contributor knows why the change is not yet acceptable. //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Command-line paths problem in Windows
On 21/10/2011 3:04 AM, Freddie Chopin wrote: 1. In 0.5.0 you could use slash or backslash (which is more correct in Windows) - no difference. Now only slash works, backslash is ommited and replaced with... nothing... 2. When running OpenOCD as External Tool from Eclipse I always left Working Dir empty and it worked fine, now I have to specify this directory for OpenOCD to work - probably because backslashes in Windows paths are replaced with nothing... Have you tried with double backslash \\ ? I've become very used to windows/cygwin/openocd/eclipse/make all behaving very differently when it comes to slashes, and trying to make various different tools work together through eclipse or makefiles can be quite frustrating when they use incompatible paths. The same can be said for ' and , both can be useful in some cases when building paths with spaces, but both can also break things in other apps. I don't know anything about who/what changed the handling in openocd, although if it's been done on purpose to make its handling more consistent or compatible with other parts of the toolchain I'd think it's worthwhile, although it doesn't sound like that is the case, it's certainly sounding worse in eclipse going by your description. Either way, I generally us the \\ as the most compatible path separator on windoze, although there's still some apps that don't like that either, and it isn't any good if you want to make cross platform config files Andrew ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
On Fri, Oct 21, 2011 at 12:32 AM, Peter Stuge pe...@stuge.se wrote: Xiaofan Chen wrote: Then please change the wording of -1 +1 Looks good to me, but someone else must approve 0 No score -1 I would prefer that you didn't submit this If the contributor see a -1 and refer to the above, I do not think it is that encouraging. :-). I think it is very important to always write some explanations for why a change should not be submitted (which is the Gerrit term for adding the change into the public repository), so that the contributor knows why the change is not yet acceptable. That is of course right. But that does not answer my question. I think it is good to change the wording of -1 to something like some changes are necessary before this patch can be accepted. -- Xiaofan ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
That is of course right. But that does not answer my question. I think it is good to change the wording of -1 to something like some changes are necessary before this patch can be accepted. I think most people will understand that this is a textstring within Gerrit. Perhaps you can talk to the developers upstream? OpenOCD just uses Gerrit. What you've find may be a beauty spot depending on who you ask. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
