Re: Help on post review tool
Please help on the below issue. On Fri, Jul 6, 2012 at 5:39 PM, Nilesh Jaiswal nileshj...@gmail.com wrote: Dear All, Please advise any changes or modification i need to do in RB server if my server is placed in secured network. To access my reviewboard server i need provide full path of the RB server with port number ( eg http://rbserver.server.com:5450/rbserver) , hence while posting review request my RBTools does not work as expected and i am getting below error message. *Unable to find a Review Board server for this source code tree.* What is missing.? Regards, Nilesh J -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Help on post review tool
Dear All, Please advise any changes or modification i need to do in RB server if my server is placed in secured network. To access my reviewboard server i need provide full path of the RB server with port number ( eg http://rbserver.server.com:5450/rbserver) , hence while posting review request my RBTools does not work as expected and i am getting below error message. *Unable to find a Review Board server for this source code tree.* What is missing.? Regards, Nilesh J -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Updates: Status: Fixed Comment #9 on issue 1113 by trowb...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 Fixed in master (f226c46). Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #7 on issue 1113 by jhuffa...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 I ran into this problem recently. I understand that you have an established workflow but this is a nasty bug that cost more than a few of us time. I don't know your code base, but was successfully (easily) able to port the files from above (0.2 to 0.3.4). I'm going to attach my diff from 0.3.4, if you really need me to apply it to reviews.reviewboard.org I can, but it seems like you should be able to do it more quickly. I really hope this gets incorporated into future versions as it is quite annoying. Attachments: postreview.py.diff 3.1 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool
Comment #3 on issue 2465 by sudhir.s...@gmail.com: For non owned review - fix error message in Review Board post-review tool http://code.google.com/p/reviewboard/issues/detail?id=2465 Hi David post-review -r ID (where ID is not owned). FYI, we use subversion and I don't feel this issue is related to SCM. Regards Sudhir -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool
Updates: Status: Fixed Comment #4 on issue 2465 by trowb...@gmail.com: For non owned review - fix error message in Review Board post-review tool http://code.google.com/p/reviewboard/issues/detail?id=2465 Thanks! Fixed in master (7570943). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool
Updates: Status: NeedInfo Comment #2 on issue 2465 by trowb...@gmail.com: For non owned review - fix error message in Review Board post-review tool http://code.google.com/p/reviewboard/issues/detail?id=2465 How are you invoking post-review? Is this with perforce? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool
Comment #1 on issue 2465 by sudhir.s...@gmail.com: For non owned review -
fix error message in Review Board post-review tool
http://code.google.com/p/reviewboard/issues/detail?id=2465
Better diagnostic for non owned review update is as below:
if not server.info.supports_changesets or not options.change_only:
try:
server.upload_diff(review_request, diff_content,
parent_diff_content)
except APIError, e:
sys.stderr.write('\n')
sys.stderr.write('Error uploading diff\n')
sys.stderr.write('\n')
if e.error_code == 101 and e.http_status == 403:
sys.stderr.write('Error: You are not the owner of this
ReviewBoard review.\n')
sys.stderr.write('\n')
die()
if e.error_code == 105:
sys.stderr.write('The generated diff file was empty. This '
'usually means no files were\n')
sys.stderr.write('modified in this change.\n')
sys.stderr.write('\n')
sys.stderr.write('Try running with --output-diff and
--debug '
'for more information.\n')
sys.stderr.write('\n')
die(Your review request still exists, but the diff is not +
attached.)
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2465 by sudhir.s...@gmail.com: For non owned review - fix error message in Review Board post-review tool http://code.google.com/p/reviewboard/issues/detail?id=2465 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? RBTools 0.3.4 What's the URL of the page containing the problem? NO URL - post-review tool What steps will reproduce the problem? 1. post-review to an existing NON owned review. 2. 3. What is the expected output? What do you see instead? you don't own the RB. I see below output instead Error uploading diff. Your review request still exists, but the diff is not attached. What operating system are you using? What browser? RHEL 5.0 Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Question about post-review tool / Further development idea, svn direct upload possibility ?
Hi, I found the next problem while we were piloting reviewboard in our organization. We have ~250 repositories, and the post-review tool get's really slow when it's trying to find out the right repository for the provided url. (and it's not in the top 50) I use the tool like this: post-review --repository-url=$URL $BR --branch=$BR --revision-range $REV --server=http://rb..net/ --user=$USR $EXT So than it starts to collect xml-s from the server to find the right repo. Are there any better way ? I mean I may provide the repository name which we most probably looking for here... And from one of my users: Is it possible to upload changes from svn by using the tool web interface ? (I guess no, but as I see it's a good further development idea.) In fact I would be happy to implement this by myself, but I know only python, no django knowledge :-( So the idea would be that user provide: - The repository (by selecting the name) - branch (by input field) - revision-range (by input field) Br, Peter. P.S.: Thanks for the great tool ! I hope you don't get this mail as complaining, I just wanted to give some feedback about your super tool ! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Can I do post-commite review on the website (without post-review tool)?
I think the post-review tool is a very nice tool for pre-commite reivew with reviewboard. But if I just want to do a post-commite review on my PC, where doesn't install svn client, what should I do? I ask so because I ever seen such a system, so I think I should not be a technical problem, right? Best regards. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Can I do post-commite review on the website (without post-review tool)?
Hi James, The options we provide today are to use either post-review with --revision-range, or just generate a diff with svn diff. Ideally there'd be a web UI for this built into Review Board. We had someone working on one at one point, but the project sort of didn't pan out. We'll likely work toward it again sometime in the future, but not right away. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Sep 28, 2011 at 2:17 AM, James Tang tzl...@gmail.com wrote: I think the post-review tool is a very nice tool for pre-commite reivew with reviewboard. But if I just want to do a post-commite review on my PC, where doesn't install svn client, what should I do? I ask so because I ever seen such a system, so I think I should not be a technical problem, right? Best regards. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #6 on issue 1113 by trowb...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 We need fixes submitted to reviews.reviewboard.org, not posted here (especially in the format that it was). The code in post-review has also diverged a lot since 0.2. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #5 on issue 1113 by underpl...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 This is an issue for us as well. Seeing as a fix has been sumbitted and it looks reasonably simple, could we please get a fix for this? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #4 on issue 1113 by rix0...@gmail.com: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 Still not fixed in 0.3.2. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Weird problem using post-review tool on windows
Running the post-review tool on my Windows Vista 64 bit machine gives me error HTTP 404 or HTTP 503. But, if I execute the same command with Fiddler running then it executes fine. I have tried disabling the firewall as well, but, doesn't help. Moreover, I can work with ReviewBoard via the browser with no issues at all. ReviewBoard 1.5 is installed and configured on Linux VM with static I/P assigned to it. Has anybody faced this problem? What is the resolution? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Weird problem using post-review tool on windows
Can you run with --debug and provide the results? It'll help to see what exactly is being accessed. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Nov 10, 2010 at 5:20 PM, asawhney adityasawh...@gmail.com wrote: Running the post-review tool on my Windows Vista 64 bit machine gives me error HTTP 404 or HTTP 503. But, if I execute the same command with Fiddler running then it executes fine. I have tried disabling the firewall as well, but, doesn't help. Moreover, I can work with ReviewBoard via the browser with no issues at all. ReviewBoard 1.5 is installed and configured on Linux VM with static I/P assigned to it. Has anybody faced this problem? What is the resolution? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard 1.5 under Apache: IOError when posting review from command line post-review tool
You're welcome. I hope that helps.
In the interest of accuracy, I need to modify my post earlier
regarding the problems with platform.py.
After more thorough testing, I do not believe that these exceptions
are directly caused by any of the functions defined in platform.py.
Rather, I think they are all instances of race conditions between
subprocess creation and attempts to use the resulting subprocesses.
Note that platform.py (at least the version I have), uses os.popen()
to create subprocesses to make the system calls, not
subprocess.Popen().
It seems that in certain circumstances, with certain processors, etc.,
these same race condition issues can affect os.popen() calls as well
as subprocess.Popen().
Stubbing out the _cleanup() function to be a no-op, as recommended in
the bug thread to which I sent the link, dramatically reduced the
number of exceptions during diff viewing. It didn't totally eliminate
them. So, as also suggested in that thread, I've added a
time.sleep(0.1) line in perforce.py, between the call to open the
perforce cmdline subprocess and the line to communicate with it. I'm
hoping 100ms will provide enough time for Popen to win the race every
time.
A similar small wait may need to be added between platform.py module's
calls to os.popen and calls to read().
Good luck,
Dennis
On Oct 31, 1:28 pm, Rob rrom...@gmail.com wrote:
Thank you very much for the reference and tips. I'll give that a
try.
On Oct 29, 11:54 am, Dennis dennisfraz...@charter.net wrote:
Rob, have you seen this?
http://bugs.python.org/issue1731717
Implementing the proposed workaround in the latest entry of that
thread fixed a lot of the [Errno 10] problems for me--all of the ones
from the diff viewer, in fact.
I may have fixed the remaining ones from that 'uname -p' function call
in platform.py that you're seeing, by inserting the return string from
'uname -o' on my system to the output value of syscmd_uname.
It looks to me like the intent was to use 'uname -o' in the first
place, since that returns the operating system name, while uname -p
returns the processor type. Somehow, this function ends up calling
uname -p.
I assigned 'GNU/Linux' to the output of syscmd_uname in platform.py,
and so far I've not seen the [Errno 10] in 3 consecutive post-review
submissions.
I'm not certain that it's fixed completely, but it looks good so far.
Dennis
On Oct 13, 12:30 pm, Rob rrom...@gmail.com wrote:
Starting in ReviewBoard 1.5 (Python 2.5.1 linux64 compiled
mod_python.so) the changes to use Paramiko result in this exception
when posting a review changelist (from Perforce) via the commandline
post-review tool.
HTTP POSTing tohttp://sw-web3.altera.com/review/api/json/accounts/login/:
{'username': 'rromano', 'password': '**'}
Traceback (most recent call last):
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1537, in HandlerDispatch
default=default_handler, arg=req, silent=hlist.silent)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1229, in _process_target
result = _execute_target(config, req, object, arg)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1128, in _execute_target
result = object(arg)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 228, in handler
return ModPythonHandler()(req)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 191, in __call__
self.load_middleware()
File /tools/django/trunk/1.2.3/django/core/handlers/base.py, line
40, in load_middleware
mod = import_module(mw_module)
File /tools/django/trunk/1.2.3/django/utils/importlib.py, line 35,
in import_module
__import__(name)
File /usr/local/altera/django/reviewboard/admin/middleware.py,
line 13, in lt;modulegt;
from reviewboard.webapi.json import service_not_configured
File /usr/local/altera/django/reviewboard/webapi/json.py, line 29,
in lt;modulegt;
from reviewboard.diffviewer.forms import EmptyDiffError
File /usr/local/altera/django/reviewboard/diffviewer/forms.py,
line 7, in lt;modulegt;
from reviewboard.diffviewer.diffutils import
DEFAULT_DIFF_COMPAT_VERSION
File /usr/local/altera/django/reviewboard/diffviewer/diffutils.py,
line 29, in lt;modulegt;
from reviewboard.scmtools.core import PRE_CREATION, HEAD
File /usr/local/altera/django/reviewboard/scmtools/core.py, line
5, in lt;modulegt;
from reviewboard.scmtools import sshutils
File /usr/local/altera/django/reviewboard/scmtools/sshutils.py,
line 5, in lt;modulegt;
import paramiko
File /usr/local/altera/django/reviewboard/paramiko/__init__.py,
line 69, in lt;modulegt;
from transport import randpool
Re: ReviewBoard 1.5 under Apache: IOError when posting review from command line post-review tool
Rob, have you seen this?
http://bugs.python.org/issue1731717
Implementing the proposed workaround in the latest entry of that
thread fixed a lot of the [Errno 10] problems for me--all of the ones
from the diff viewer, in fact.
I may have fixed the remaining ones from that 'uname -p' function call
in platform.py that you're seeing, by inserting the return string from
'uname -o' on my system to the output value of syscmd_uname.
It looks to me like the intent was to use 'uname -o' in the first
place, since that returns the operating system name, while uname -p
returns the processor type. Somehow, this function ends up calling
uname -p.
I assigned 'GNU/Linux' to the output of syscmd_uname in platform.py,
and so far I've not seen the [Errno 10] in 3 consecutive post-review
submissions.
I'm not certain that it's fixed completely, but it looks good so far.
Dennis
On Oct 13, 12:30 pm, Rob rrom...@gmail.com wrote:
Starting in ReviewBoard 1.5 (Python 2.5.1 linux64 compiled
mod_python.so) the changes to use Paramiko result in this exception
when posting a review changelist (from Perforce) via the commandline
post-review tool.
HTTP POSTing tohttp://sw-web3.altera.com/review/api/json/accounts/login/:
{'username': 'rromano', 'password': '**'}
Traceback (most recent call last):
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1537, in HandlerDispatch
default=default_handler, arg=req, silent=hlist.silent)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1229, in _process_target
result = _execute_target(config, req, object, arg)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1128, in _execute_target
result = object(arg)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 228, in handler
return ModPythonHandler()(req)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 191, in __call__
self.load_middleware()
File /tools/django/trunk/1.2.3/django/core/handlers/base.py, line
40, in load_middleware
mod = import_module(mw_module)
File /tools/django/trunk/1.2.3/django/utils/importlib.py, line 35,
in import_module
__import__(name)
File /usr/local/altera/django/reviewboard/admin/middleware.py,
line 13, in lt;modulegt;
from reviewboard.webapi.json import service_not_configured
File /usr/local/altera/django/reviewboard/webapi/json.py, line 29,
in lt;modulegt;
from reviewboard.diffviewer.forms import EmptyDiffError
File /usr/local/altera/django/reviewboard/diffviewer/forms.py,
line 7, in lt;modulegt;
from reviewboard.diffviewer.diffutils import
DEFAULT_DIFF_COMPAT_VERSION
File /usr/local/altera/django/reviewboard/diffviewer/diffutils.py,
line 29, in lt;modulegt;
from reviewboard.scmtools.core import PRE_CREATION, HEAD
File /usr/local/altera/django/reviewboard/scmtools/core.py, line
5, in lt;modulegt;
from reviewboard.scmtools import sshutils
File /usr/local/altera/django/reviewboard/scmtools/sshutils.py,
line 5, in lt;modulegt;
import paramiko
File /usr/local/altera/django/reviewboard/paramiko/__init__.py,
line 69, in lt;modulegt;
from transport import randpool, SecurityOptions, Transport
File /usr/local/altera/django/reviewboard/paramiko/transport.py,
line 32, in lt;modulegt;
from paramiko import util
File /usr/local/altera/django/reviewboard/paramiko/util.py, line
32, in lt;modulegt;
from paramiko.common import *
File /usr/local/altera/django/reviewboard/paramiko/common.py, line
98, in lt;modulegt;
from rng import StrongLockingRandomPool
File /usr/local/altera/django/reviewboard/paramiko/rng.py, line
44, in lt;modulegt;
if ((platform is not None and platform.system().lower() ==
'windows') or
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
1042, in system
return uname()[0]
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
1014, in uname
processor = _syscmd_uname('-p','')
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
801, in _syscmd_uname
rc = f.close()
IOError: [Errno 10] No child processes
This looks very fundamental. Python's platform.uname() fn does a
subprocess call to `uname` and it's not liked.
Incidentally, under ReviewBoard 1.0.x, I had similar issues in
ReviewBoard's own code using subprocess.POpen to extract diffs from
`p4`. I simply changed the code to use os.system() and it worked fine
thereafter.
Are there known issues with the subprocess.POpen module when running
under Apache?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr
ReviewBoard 1.5 under Apache: IOError when posting review from command line post-review tool
Starting in ReviewBoard 1.5 (Python 2.5.1 linux64 compiled
mod_python.so) the changes to use Paramiko result in this exception
when posting a review changelist (from Perforce) via the commandline
post-review tool.
HTTP POSTing to http://sw-web3.altera.com/review/api/json/accounts/login/:
{'username': 'rromano', 'password': '**'}
Traceback (most recent call last):
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1537, in HandlerDispatch
default=default_handler, arg=req, silent=hlist.silent)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1229, in _process_target
result = _execute_target(config, req, object, arg)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1128, in _execute_target
result = object(arg)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 228, in handler
return ModPythonHandler()(req)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 191, in __call__
self.load_middleware()
File /tools/django/trunk/1.2.3/django/core/handlers/base.py, line
40, in load_middleware
mod = import_module(mw_module)
File /tools/django/trunk/1.2.3/django/utils/importlib.py, line 35,
in import_module
__import__(name)
File /usr/local/altera/django/reviewboard/admin/middleware.py,
line 13, in lt;modulegt;
from reviewboard.webapi.json import service_not_configured
File /usr/local/altera/django/reviewboard/webapi/json.py, line 29,
in lt;modulegt;
from reviewboard.diffviewer.forms import EmptyDiffError
File /usr/local/altera/django/reviewboard/diffviewer/forms.py,
line 7, in lt;modulegt;
from reviewboard.diffviewer.diffutils import
DEFAULT_DIFF_COMPAT_VERSION
File /usr/local/altera/django/reviewboard/diffviewer/diffutils.py,
line 29, in lt;modulegt;
from reviewboard.scmtools.core import PRE_CREATION, HEAD
File /usr/local/altera/django/reviewboard/scmtools/core.py, line
5, in lt;modulegt;
from reviewboard.scmtools import sshutils
File /usr/local/altera/django/reviewboard/scmtools/sshutils.py,
line 5, in lt;modulegt;
import paramiko
File /usr/local/altera/django/reviewboard/paramiko/__init__.py,
line 69, in lt;modulegt;
from transport import randpool, SecurityOptions, Transport
File /usr/local/altera/django/reviewboard/paramiko/transport.py,
line 32, in lt;modulegt;
from paramiko import util
File /usr/local/altera/django/reviewboard/paramiko/util.py, line
32, in lt;modulegt;
from paramiko.common import *
File /usr/local/altera/django/reviewboard/paramiko/common.py, line
98, in lt;modulegt;
from rng import StrongLockingRandomPool
File /usr/local/altera/django/reviewboard/paramiko/rng.py, line
44, in lt;modulegt;
if ((platform is not None and platform.system().lower() ==
'windows') or
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
1042, in system
return uname()[0]
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
1014, in uname
processor = _syscmd_uname('-p','')
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
801, in _syscmd_uname
rc = f.close()
IOError: [Errno 10] No child processes
This looks very fundamental. Python's platform.uname() fn does a
subprocess call to `uname` and it's not liked.
Incidentally, under ReviewBoard 1.0.x, I had similar issues in
ReviewBoard's own code using subprocess.POpen to extract diffs from
`p4`. I simply changed the code to use os.system() and it worked fine
thereafter.
Are there known issues with the subprocess.POpen module when running
under Apache?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard 1.5 under Apache: IOError when posting review from command line post-review tool
I'm not really sure. This is the first I've heard of this issue. The
call actually comes from paramiko, a Python module we use for the SSH
support. Might be worth seeing if other people outside Review Board
have hit that issue.
Christian
On Wednesday, October 13, 2010, Rob rrom...@gmail.com wrote:
Starting in ReviewBoard 1.5 (Python 2.5.1 linux64 compiled
mod_python.so) the changes to use Paramiko result in this exception
when posting a review changelist (from Perforce) via the commandline
post-review tool.
HTTP POSTing to http://sw-web3.altera.com/review/api/json/accounts/login/:
{'username': 'rromano', 'password': '**'}
Traceback (most recent call last):
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1537, in HandlerDispatch
default=default_handler, arg=req, silent=hlist.silent)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1229, in _process_target
result = _execute_target(config, req, object, arg)
File /tools/python/2.5.1/linux64/lib/python2.5/site-packages/
mod_python/importer.py, line 1128, in _execute_target
result = object(arg)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 228, in handler
return ModPythonHandler()(req)
File /tools/django/trunk/1.2.3/django/core/handlers/modpython.py,
line 191, in __call__
self.load_middleware()
File /tools/django/trunk/1.2.3/django/core/handlers/base.py, line
40, in load_middleware
mod = import_module(mw_module)
File /tools/django/trunk/1.2.3/django/utils/importlib.py, line 35,
in import_module
__import__(name)
File /usr/local/altera/django/reviewboard/admin/middleware.py,
line 13, in lt;modulegt;
from reviewboard.webapi.json import service_not_configured
File /usr/local/altera/django/reviewboard/webapi/json.py, line 29,
in lt;modulegt;
from reviewboard.diffviewer.forms import EmptyDiffError
File /usr/local/altera/django/reviewboard/diffviewer/forms.py,
line 7, in lt;modulegt;
from reviewboard.diffviewer.diffutils import
DEFAULT_DIFF_COMPAT_VERSION
File /usr/local/altera/django/reviewboard/diffviewer/diffutils.py,
line 29, in lt;modulegt;
from reviewboard.scmtools.core import PRE_CREATION, HEAD
File /usr/local/altera/django/reviewboard/scmtools/core.py, line
5, in lt;modulegt;
from reviewboard.scmtools import sshutils
File /usr/local/altera/django/reviewboard/scmtools/sshutils.py,
line 5, in lt;modulegt;
import paramiko
File /usr/local/altera/django/reviewboard/paramiko/__init__.py,
line 69, in lt;modulegt;
from transport import randpool, SecurityOptions, Transport
File /usr/local/altera/django/reviewboard/paramiko/transport.py,
line 32, in lt;modulegt;
from paramiko import util
File /usr/local/altera/django/reviewboard/paramiko/util.py, line
32, in lt;modulegt;
from paramiko.common import *
File /usr/local/altera/django/reviewboard/paramiko/common.py, line
98, in lt;modulegt;
from rng import StrongLockingRandomPool
File /usr/local/altera/django/reviewboard/paramiko/rng.py, line
44, in lt;modulegt;
if ((platform is not None and platform.system().lower() ==
'windows') or
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
1042, in system
return uname()[0]
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
1014, in uname
processor = _syscmd_uname('-p','')
File /tools/python/2.5.1/linux64/lib/python2.5/platform.py, line
801, in _syscmd_uname
rc = f.close()
IOError: [Errno 10] No child processes
This looks very fundamental. Python's platform.uname() fn does a
subprocess call to `uname` and it's not liked.
Incidentally, under ReviewBoard 1.0.x, I had similar issues in
ReviewBoard's own code using subprocess.POpen to extract diffs from
`p4`. I simply changed the code to use os.system() and it worked fine
thereafter.
Are there known issues with the subprocess.POpen module when running
under Apache?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl
Re: post-review tool: How to post only *.c and *.h files
The repository path specified must be the *root* of the SVN repository,
which must match what's in Review Board.
The files being put up for review should be passed as additional parameters.
For example:
$ post-review src/*.c
Are you trying to post existing (committed) code, or new (uncommitted) code
to the repository? If the latter, there was a script for that in another
thread.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Aug 24, 2010 at 7:29 AM, sakthi listsak...@gmail.com wrote:
I tried to give a path that resides inside the repository..
I get Got API Error 207 (HTTP code 200): The file was not found in
the repository
post-review doesnt take path inside repository?
Do i have to touch the file which have to be reviewed and check in to
post into review board?
Kindly help me a way to post the files into review board.
Regards
Sakthi
-error-
start---
Review request created
Uploading diff, size: 2666171
HTTP POSTing to
http://10.20.1.98/revboard/api/json/reviewrequests/3/diff/new/:
{'basedir': '/'}
Got API Error 207 (HTTP code 200): The file was not found in the
repository
Error data: {u'stat': u'fail', u'file':
u'/projects/starship/branches/br-catIQ/dect/dc-nwk/src-pp/pnciss.c', u'err':
{u'msg': u'The file was not found in the repository', u'code': 207},
u'revision': u'21677'}
Error uploading diff
Your review request still exists, but the diff is not attached.
--error-end
On Aug 24, 6:30 pm, sakthi listsak...@gmail.com wrote:
Hello Christian,
Can you tell me how to mention the path?
I am stuck up.. i am getting this error as the repository contains doc
files..
Failed to execute command: ['svn', 'info', 'Design Specs/
s1020_design.doc']
May i know how to mention only the path that is required?
This is the sample command line i used.
$ sudo post-review -d --server=http://reviewboard.local.server/--
revision-range=21677:22627 --repository-url=http://svn.local.server/
svn/repos/projects/Project1/
Thanks
Sakthi
On Aug 24, 12:18 pm, Christian Hammond chip...@chipx86.com wrote:
If you can build the file list separately of *.c and *.h files, you can
just
pass those to post-review. It takes file paths and lists of files.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote:
Hi Chris, I accept what you said, I can see some logic there.
I dont want to load test scripts and docs for review.. I will have to
find a way..
thanks again.
sakthi
On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote:
sakthi wrote:
Could find i have to use post-review tool to post the code into
review
board.
Can some one help me out how to post ONLY *.c and *.h files
recursively from SVN directory.
Is there any automated script available.. where i shall modify
the
require information to post the code that is required?
Let me pose a question to you ;-)
How are you going to submit just *.c and *.h files to subversion
when
you come to commit? There is no reviewboard involved at that stage.
Postreview will accept the same filenames on command line that
subversion will take at submit time.
Chris
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
It should. When doing --revision-range with Subversion, we're essentially
passing that range to 'svn diff' when generating the diff.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Aug 24, 2010 at 9:10 AM, sakthi listsak...@gmail.com wrote:
does review board handle if the files are deleted and new file that is
added in the repository, while doing --revision-range?
On Aug 24, 7:29 pm, sakthi listsak...@gmail.com wrote:
I tried to give a path that resides inside the repository..
I get Got API Error 207 (HTTP code 200): The file was not found in
the repository
post-review doesnt take path inside repository?
Do i have to touch the file which have to be reviewed and check in to
post into review board?
Kindly help me a way to post the files into review board.
Regards
Sakthi
-error-
start---
Review request created
Uploading diff, size: 2666171
HTTP POSTing tohttp://
10.20.1.98/revboard/api/json/reviewrequests/3/diff/new/:{'basedirhttp://10.20.1.98/revboard/api/json/reviewrequests/3/diff/new/:%7B%27basedir':
'/'}
Got API Error 207 (HTTP code 200): The file was not found in the
repository
Error data: {u'stat': u'fail', u'file':
u'/projects/starship/branches/br-catIQ/dect/dc-nwk/src-pp/pnciss.c', u'err':
{u'msg': u'The file was not found in the repository', u'code': 207},
u'revision': u'21677'}
Error uploading diff
Your review request still exists, but the diff is not attached.
--error-end
On Aug 24, 6:30 pm, sakthi listsak...@gmail.com wrote:
Hello Christian,
Can you tell me how to mention the path?
I am stuck up.. i am getting this error as the repository contains doc
files..
Failed to execute command: ['svn', 'info', 'Design Specs/
s1020_design.doc']
May i know how to mention only the path that is required?
This is the sample command line i used.
$ sudo post-review -d --server=http://reviewboard.local.server/--
revision-range=21677:22627 --repository-url=http://svn.local.server/
svn/repos/projects/Project1/
Thanks
Sakthi
On Aug 24, 12:18 pm, Christian Hammond chip...@chipx86.com wrote:
If you can build the file list separately of *.c and *.h files, you
can just
pass those to post-review. It takes file paths and lists of files.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com
wrote:
Hi Chris, I accept what you said, I can see some logic there.
I dont want to load test scripts and docs for review.. I will have
to
find a way..
thanks again.
sakthi
On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote:
sakthi wrote:
Could find i have to use post-review tool to post the code into
review
board.
Can some one help me out how to post ONLY *.c and *.h files
recursively from SVN directory.
Is there any automated script available.. where i shall modify
the
require information to post the code that is required?
Let me pose a question to you ;-)
How are you going to submit just *.c and *.h files to subversion
when
you come to commit? There is no reviewboard involved at that
stage.
Postreview will accept the same filenames on command line that
subversion will take at submit time.
Chris
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more
Re: post-review tool: How to post only *.c and *.h files
Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
There could be -exclude or -include switch to post-review but I think better way is keep all in two separate checkouts which appropriate ignore rulez - one for docs second for source code. On Tue, Aug 24, 2010 at 8:11 AM, sakthi listsak...@gmail.com wrote: Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
If you can build the file list separately of *.c and *.h files, you can just pass those to post-review. It takes file paths and lists of files. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote: Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
Hello Christian, Can you tell me how to mention the path? I am stuck up.. i am getting this error as the repository contains doc files.. Failed to execute command: ['svn', 'info', 'Design Specs/ s1020_design.doc'] May i know how to mention only the path that is required? This is the sample command line i used. $ sudo post-review -d --server=http://reviewboard.local.server/ -- revision-range=21677:22627 --repository-url=http://svn.local.server/ svn/repos/projects/Project1/ Thanks Sakthi On Aug 24, 12:18 pm, Christian Hammond chip...@chipx86.com wrote: If you can build the file list separately of *.c and *.h files, you can just pass those to post-review. It takes file paths and lists of files. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote: Hi Chris, I accept what you said, I can see some logic there. I dont want to load test scripts and docs for review.. I will have to find a way.. thanks again. sakthi On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote: sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
I tried to give a path that resides inside the repository..
I get Got API Error 207 (HTTP code 200): The file was not found in
the repository
post-review doesnt take path inside repository?
Do i have to touch the file which have to be reviewed and check in to
post into review board?
Kindly help me a way to post the files into review board.
Regards
Sakthi
-error-
start---
Review request created
Uploading diff, size: 2666171
HTTP POSTing to
http://10.20.1.98/revboard/api/json/reviewrequests/3/diff/new/: {'basedir':
'/'}
Got API Error 207 (HTTP code 200): The file was not found in the repository
Error data: {u'stat': u'fail', u'file':
u'/projects/starship/branches/br-catIQ/dect/dc-nwk/src-pp/pnciss.c',
u'err': {u'msg': u'The file was not found in the repository', u'code':
207}, u'revision': u'21677'}
Error uploading diff
Your review request still exists, but the diff is not attached.
--error-end
On Aug 24, 6:30 pm, sakthi listsak...@gmail.com wrote:
Hello Christian,
Can you tell me how to mention the path?
I am stuck up.. i am getting this error as the repository contains doc
files..
Failed to execute command: ['svn', 'info', 'Design Specs/
s1020_design.doc']
May i know how to mention only the path that is required?
This is the sample command line i used.
$ sudo post-review -d --server=http://reviewboard.local.server/--
revision-range=21677:22627 --repository-url=http://svn.local.server/
svn/repos/projects/Project1/
Thanks
Sakthi
On Aug 24, 12:18 pm, Christian Hammond chip...@chipx86.com wrote:
If you can build the file list separately of *.c and *.h files, you can just
pass those to post-review. It takes file paths and lists of files.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote:
Hi Chris, I accept what you said, I can see some logic there.
I dont want to load test scripts and docs for review.. I will have to
find a way..
thanks again.
sakthi
On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote:
sakthi wrote:
Could find i have to use post-review tool to post the code into review
board.
Can some one help me out how to post ONLY *.c and *.h files
recursively from SVN directory.
Is there any automated script available.. where i shall modify the
require information to post the code that is required?
Let me pose a question to you ;-)
How are you going to submit just *.c and *.h files to subversion when
you come to commit? There is no reviewboard involved at that stage.
Postreview will accept the same filenames on command line that
subversion will take at submit time.
Chris
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
does review board handle if the files are deleted and new file that is
added in the repository, while doing --revision-range?
On Aug 24, 7:29 pm, sakthi listsak...@gmail.com wrote:
I tried to give a path that resides inside the repository..
I get Got API Error 207 (HTTP code 200): The file was not found in
the repository
post-review doesnt take path inside repository?
Do i have to touch the file which have to be reviewed and check in to
post into review board?
Kindly help me a way to post the files into review board.
Regards
Sakthi
-error-
start---
Review request created
Uploading diff, size: 2666171
HTTP POSTing
tohttp://10.20.1.98/revboard/api/json/reviewrequests/3/diff/new/:{'basedir':
'/'}
Got API Error 207 (HTTP code 200): The file was not found in the
repository
Error data: {u'stat': u'fail', u'file':
u'/projects/starship/branches/br-catIQ/dect/dc-nwk/src-pp/pnciss.c',
u'err': {u'msg': u'The file was not found in the repository', u'code':
207}, u'revision': u'21677'}
Error uploading diff
Your review request still exists, but the diff is not attached.
--error-end
On Aug 24, 6:30 pm, sakthi listsak...@gmail.com wrote:
Hello Christian,
Can you tell me how to mention the path?
I am stuck up.. i am getting this error as the repository contains doc
files..
Failed to execute command: ['svn', 'info', 'Design Specs/
s1020_design.doc']
May i know how to mention only the path that is required?
This is the sample command line i used.
$ sudo post-review -d --server=http://reviewboard.local.server/--
revision-range=21677:22627 --repository-url=http://svn.local.server/
svn/repos/projects/Project1/
Thanks
Sakthi
On Aug 24, 12:18 pm, Christian Hammond chip...@chipx86.com wrote:
If you can build the file list separately of *.c and *.h files, you can
just
pass those to post-review. It takes file paths and lists of files.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Aug 23, 2010 at 11:11 PM, sakthi listsak...@gmail.com wrote:
Hi Chris, I accept what you said, I can see some logic there.
I dont want to load test scripts and docs for review.. I will have to
find a way..
thanks again.
sakthi
On Aug 24, 2:03 am, Chris Clark chris.cl...@ingres.com wrote:
sakthi wrote:
Could find i have to use post-review tool to post the code into
review
board.
Can some one help me out how to post ONLY *.c and *.h files
recursively from SVN directory.
Is there any automated script available.. where i shall modify the
require information to post the code that is required?
Let me pose a question to you ;-)
How are you going to submit just *.c and *.h files to subversion when
you come to commit? There is no reviewboard involved at that stage.
Postreview will accept the same filenames on command line that
subversion will take at submit time.
Chris
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
post-review tool: How to post only *.c and *.h files
I am first timer for Review Board.. trying to figure out how to post code into review board for review.. and how to initiate review etc... Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Cheers Sakthi -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #3 on issue 1113 by bobafeth2000: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 I added a workaround for that issue on my local installation. I hope it can help anybody having the same problem until an official fix come out. Attached are two files: - postreview.org is the original one upon which the fix is based (RBTools-0.2) - postreview.py is the modified one that handles the case of deleted files. Attachments: postreview.py 104 KB postreview.org 104 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Comment #2 on issue 1113 by trowbrds: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 Issue 1738 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1499 in reviewboard: post-review tool can't use some forms of CVS/Root entries
Updates: Status: PendingReview Comment #3 on issue 1499 by trowbrds: post-review tool can't use some forms of CVS/Root entries http://code.google.com/p/reviewboard/issues/detail?id=1499 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1499 in reviewboard: post-review tool can't use some forms of CVS/Root entries
Updates: Status: NeedInfo Labels: Component-RBTools Comment #2 on issue 1499 by chipx86: post-review tool can't use some forms of CVS/Root entries http://code.google.com/p/reviewboard/issues/detail?id=1499 Can you submit a patch to http://reviews.reviewboard.org/ ? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1497 in reviewboard: post-review tool doesn't support certain CVS formats
Updates: Status: Invalid Comment #1 on issue 1497 by chipx86: post-review tool doesn't support certain CVS formats http://code.google.com/p/reviewboard/issues/detail?id=1497 There's no info in here about what's wrong or why. Assuming this is replaced by bug 1499. Otherwise, please file a new bug. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
About post-commit review with post-review tool
Hi, All. I had tried to use post-review to product a ReviewRequest after the code has been commited to CVS Repository. The original version of source file is 1.1, I chengd the file and commited again, The version on CVS repository then is 1.2; So I use the command: #post-review revision-range=1.1:1.2 --username=A1 --password=A1Pass --target-people=B1 --summary=NoSummary -p test.c But the execution of this command reports: -- Error Uploading diff: One or more fields has errors: (105) Your review requests is still exists, But the diff is not attached --- Then I tried to use --revision-range=0:1 , This time the commit is well, But When I open the review board WebUI, It shows the list: Diff revision 1 (Latest) Files Changed: /tmp/cvs0u9OUY: 1 change [ new content ] /tmp/cvs2PY2EF: 1 change [ new content ] /tmp/cvs4c1jWh: 1 change [ new content ] /tmp/cvs4s3h8n: 1 change [ new content ] /tmp/cvs4yGoXf: 1 change [ new content ] /tmp/cvs6BEFdG: 1 change [ new content ] /tmp/cvs6JH9h6: 1 change [ new content ] . - But not the diff of file test.c Which is my designed to show. My questions are : (1) What is the --Revision-range mean? (Is the Revision means the source code version on Repostitory?) (2) How to make post-commit review request for one or more specific files? (3) If there are more then one files needing to be reviewed, But they are in different version in the Repository, Can I create a post-commit ReviewRequest for those files? (All those file diffs are in one diff file ) and How? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool reports 'Error uploading diff: The file was not found in the repository (207)'
Thanks Christian, I've now set the URL to the repository base, and when I run 'post- review' I now get a more promising response: Review request #12 posted. http://localhost:/r/12 However when I click 'View Diff' for the generated review request, I get the following in the content pane (below). Any ideas? Paul Traceback (most recent call last): File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 623, in get_diff_files large_data=True) File c:\program files\python_2.5.4\lib\site-packages\Djblets-0.5- py2.5.egg\djblets\util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 622, in lambda enable_syntax_highlighting), File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 109, in patch stderr=subprocess.STDOUT) File C:\Program Files\Python_2.5.4\lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\Program Files\Python_2.5.4\lib\subprocess.py, line 822, in _execute_child startupinfo) WindowsError: [Error 2] The system cannot find the file specified --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool reports 'Error uploading diff: The file was not found in the repository (207)'
Yep, common problem. patch.exe isn't in the path that Apache sees. I believe some people have solved this by making sure it's part of the global system path, or by setting the path using the SetEnv command in the Apache config file. Do let me know if the former works, and I'll add it to the docs. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Jul 16, 2009 at 1:36 AM, paul paul.grib...@gmail.com wrote: Thanks Christian, I've now set the URL to the repository base, and when I run 'post- review' I now get a more promising response: Review request #12 posted. http://localhost:/r/12 However when I click 'View Diff' for the generated review request, I get the following in the content pane (below). Any ideas? Paul Traceback (most recent call last): File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 623, in get_diff_files large_data=True) File c:\program files\python_2.5.4\lib\site-packages\Djblets-0.5- py2.5.egg\djblets\util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 622, in lambda enable_syntax_highlighting), File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 109, in patch stderr=subprocess.STDOUT) File C:\Program Files\Python_2.5.4\lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\Program Files\Python_2.5.4\lib\subprocess.py, line 822, in _execute_child startupinfo) WindowsError: [Error 2] The system cannot find the file specified --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool reports 'Error uploading diff: The file was not found in the repository (207)'
Thanks again Christian, That's done the trick. I tried each solution separately and either one works fine. On Jul 16, 10:15 am, Christian Hammond chip...@chipx86.com wrote: Yep, common problem. patch.exe isn't in the path that Apache sees. I believe some people have solved this by making sure it's part of the global system path, or by setting the path using the SetEnv command in the Apache config file. Do let me know if the former works, and I'll add it to the docs. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Thu, Jul 16, 2009 at 1:36 AM, paul paul.grib...@gmail.com wrote: Thanks Christian, I've now set the URL to the repository base, and when I run 'post- review' I now get a more promising response: Review request #12 posted. http://localhost:/r/12 However when I click 'View Diff' for the generated review request, I get the following in the content pane (below). Any ideas? Paul Traceback (most recent call last): File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 623, in get_diff_files large_data=True) File c:\program files\python_2.5.4\lib\site-packages\Djblets-0.5- py2.5.egg\djblets\util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 622, in lambda enable_syntax_highlighting), File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 109, in patch stderr=subprocess.STDOUT) File C:\Program Files\Python_2.5.4\lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\Program Files\Python_2.5.4\lib\subprocess.py, line 822, in _execute_child startupinfo) WindowsError: [Error 2] The system cannot find the file specified --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool reports 'Error uploading diff: The file was not found in the repository (207)'
Good to hear. I have a patch that will be going in to 1.0.1 that will check for this before trying to serve any URLs, and inform the user as to how to fix it, so this won't be as big a problem for future users. Thanks! Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Thu, Jul 16, 2009 at 6:16 AM, paul paul.grib...@gmail.com wrote: Thanks again Christian, That's done the trick. I tried each solution separately and either one works fine. On Jul 16, 10:15 am, Christian Hammond chip...@chipx86.com wrote: Yep, common problem. patch.exe isn't in the path that Apache sees. I believe some people have solved this by making sure it's part of the global system path, or by setting the path using the SetEnv command in the Apache config file. Do let me know if the former works, and I'll add it to the docs. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Thu, Jul 16, 2009 at 1:36 AM, paul paul.grib...@gmail.com wrote: Thanks Christian, I've now set the URL to the repository base, and when I run 'post- review' I now get a more promising response: Review request #12 posted. http://localhost:/r/12 However when I click 'View Diff' for the generated review request, I get the following in the content pane (below). Any ideas? Paul Traceback (most recent call last): File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 623, in get_diff_files large_data=True) File c:\program files\python_2.5.4\lib\site-packages\Djblets-0.5- py2.5.egg\djblets\util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 622, in lambda enable_syntax_highlighting), File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\program files\python_2.5.4\lib\site-packages \ReviewBoard-1.0rc3-py2.5.egg\reviewboard\diffviewer\diffutils.py, line 109, in patch stderr=subprocess.STDOUT) File C:\Program Files\Python_2.5.4\lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\Program Files\Python_2.5.4\lib\subprocess.py, line 822, in _execute_child startupinfo) WindowsError: [Error 2] The system cannot find the file specified --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
post-review tool reports 'Error uploading diff: The file was not found in the repository (207)'
Hi, I'm trying to evaluate ReviewBoard. It would eventually run on a linux environment but for now am trying to deploy on a PC running Windows XP. I've raise an issue for my problem (http://code.google.com/p/ reviewboard/issues/detail?id=1220), apologies if I should have used the discussion group first. Everything seems to be tantalizingly close, but I'm unable to upload code diffs to the server using the 'post-review' tool and I'm not getting very useful messages back from it, just the message: Error uploading diff: The file was not found in the repository (207) Any help would be greatly appreciated Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool reports 'Error uploading diff: The file was not found in the repository (207)'
That means that one of the files referenced in the diff couldn't be found in the repository. A common cause is that the repository path is set incorrectly. What type of repository is this? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Jul 15, 2009 at 6:24 AM, paul paul.grib...@gmail.com wrote: Hi, I'm trying to evaluate ReviewBoard. It would eventually run on a linux environment but for now am trying to deploy on a PC running Windows XP. I've raise an issue for my problem (http://code.google.com/p/ reviewboard/issues/detail?id=1220http://code.google.com/p/%0Areviewboard/issues/detail?id=1220), apologies if I should have used the discussion group first. Everything seems to be tantalizingly close, but I'm unable to upload code diffs to the server using the 'post-review' tool and I'm not getting very useful messages back from it, just the message: Error uploading diff: The file was not found in the repository (207) Any help would be greatly appreciated Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool reports 'Error uploading diff: The file was not found in the repository (207)'
Christian, Thanks for the reply. It's a subversion repository. lets say the URL for the top of my project is 'http://subversionserver: /projects/trunk/top/myproject' - this is how I've define the repository to reviewboard webapp. I've checked out everything under 'http://subversionserver:/ projects/trunk/top' and set the subversion property 'reviewboard:url' to the reviewboard webapp URL for folder 'myproject'. I've then done: cd myproject (local checked out SVN copy). post-review.py Paul On Jul 15, 9:34 pm, Christian Hammond chip...@chipx86.com wrote: That means that one of the files referenced in the diff couldn't be found in the repository. A common cause is that the repository path is set incorrectly. What type of repository is this? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Wed, Jul 15, 2009 at 6:24 AM, paul paul.grib...@gmail.com wrote: Hi, I'm trying to evaluate ReviewBoard. It would eventually run on a linux environment but for now am trying to deploy on a PC running Windows XP. I've raise an issue for my problem (http://code.google.com/p/ reviewboard/issues/detail?id=1220http://code.google.com/p/%0Areviewboard/issues/detail?id=1220), apologies if I should have used the discussion group first. Everything seems to be tantalizingly close, but I'm unable to upload code diffs to the server using the 'post-review' tool and I'm not getting very useful messages back from it, just the message: Error uploading diff: The file was not found in the repository (207) Any help would be greatly appreciated Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool reports 'Error uploading diff: The file was not found in the repository (207)'
The repository URL should be the base of the repository. Specifically, http://subversionserver:/projects/ (assuming projects/ is the root, and not a directory in the SVN server). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Jul 15, 2009 at 2:35 PM, paul paul.grib...@gmail.com wrote: Christian, Thanks for the reply. It's a subversion repository. lets say the URL for the top of my project is 'http://subversionserver: /projects/trunk/top/myproject' - this is how I've define the repository to reviewboard webapp. I've checked out everything under 'http://subversionserver:/ projects/trunk/top http://subversionserver:/%0Aprojects/trunk/top' and set the subversion property 'reviewboard:url' to the reviewboard webapp URL for folder 'myproject'. I've then done: cd myproject (local checked out SVN copy). post-review.py Paul On Jul 15, 9:34 pm, Christian Hammond chip...@chipx86.com wrote: That means that one of the files referenced in the diff couldn't be found in the repository. A common cause is that the repository path is set incorrectly. What type of repository is this? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Wed, Jul 15, 2009 at 6:24 AM, paul paul.grib...@gmail.com wrote: Hi, I'm trying to evaluate ReviewBoard. It would eventually run on a linux environment but for now am trying to deploy on a PC running Windows XP. I've raise an issue for my problem (http://code.google.com/p/ reviewboard/issues/detail?id=1220 http://code.google.com/p/%0Areviewboard/issues/detail?id=1220), apologies if I should have used the discussion group first. Everything seems to be tantalizingly close, but I'm unable to upload code diffs to the server using the 'post-review' tool and I'm not getting very useful messages back from it, just the message: Error uploading diff: The file was not found in the repository (207) Any help would be greatly appreciated Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1220 in reviewboard: post-review tool fails to upload diffs
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1220 by paul.gribben: post-review tool fails to upload diffs http://code.google.com/p/reviewboard/issues/detail?id=1220 What version are you running? Software: ReviewBoard-1.0rc3-py2.5, RBTools-0.2beta1-py2.5 What's the URL of the page containing the problem? N/A. Problem is with post-review tool What steps will reproduce the problem? 1. cd [my local svn view top-level folder] 2. run 'post-review.py' What is the expected output? What do you see instead? After accepting login credentials, replies with: Error uploading diff: The file was not found in the repository (207) A review entry is created and is visible in the webapp, but it has no content (the diffs have not been uploaded). I've then added some printouts to the post-review.py script that was provided by the RBTools-0.2beta1-py2.5 module to verify that a valid diff has been submitted on line 2022 by command server.upload_diff command (and it is fine). What operating system are you using? What browser? Platform: Windows XP, MySQL, Apache 2.2 with mod python, Firefox 3.0.11 Please provide any additional information below. I have set the svn property 'reviewboard:url' to 'http://localhost:'. When I browse to this URL I get the ReviewBoard web app. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1113 in reviewboard: post-review tool cannot handle revisions with deleted files in Subversion
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1113 by mdelagra: post-review tool cannot handle revisions with deleted files in Subversion http://code.google.com/p/reviewboard/issues/detail?id=1113 *NOTE: Do not post confidential information in this bug report.* What version are you running? RBTools 0.2beta1 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. svn delete some_file 2. svn commit -m 'deleting a file' 3. post-review --revision-range=revision-1:revision What is the expected output? What do you see instead? Expected: login prompt Actual: Failed to execute command: ['svn', 'info', 'path/deleted_file'] [svn: 'path/deleted_file' is not under version control\n] What operating system are you using? What browser? OS X Please provide any additional information below. Manually posting a diff to a ReviewBoard website that includes a deleted file works fine in the latest version, but the post-review tool does not work. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: post-review tool
Transfer/StdAfx.h
diff -urNp c:\docume~1\rpius\locals~1\temp\tmptkche3
Transfer/StdAfx.h
Looking for 'xxx.xxx.xxx.xxx /' cookie in C:\Documents and
Settings\username\Local Settings\Application
Data\.post-review-cookies.txt Loaded valid cookie -- no login required
Attempting to create review request for 10020
HTTP POSTing to
http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/new/:
{'repository_path': ':1666', 'changenum': '10020'}
Review request already exists. Updating it...
HTTP POSTing to
http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/186/update_from_cha...
:
{}
Review request created
Uploading diff, size: 37349
HTTP POSTing to
http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/186/diff/new/:{}
Review request #186 posted.
http://xxx.xxx.xxx.xxx:80/r/186
Thanks,
Roshan Pius
On Tue, Apr 14, 2009 at 6:15 PM, Raghu raghu...@gmail.com wrote:
Can you provide the complete output of post-review -d? My first guess
would be that it is due to a space in the file path.
-Raghu
On Apr 13, 10:25 am, roshanpius roshanpiustho...@gmail.com wrote:
Hi ,
I've been using post-review tool for posting reviews for Review Board
for a Perforce Repository. I've integrated the post-review tool into
P4V which is the GUI P4 Client For Windows. This worked fine till now.
But now i've created a new workspace and tried using post-review, but
the diff didn't fetch the file from my hard disk. It was fetching the
correct file from Repository, but not finding the correct edited file
on my Workspace.
I ran post-review with -d flag to get the debug logs and i noticed
that the path on the Workspace that the diff was trying to fetch was
completely wrong:
diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf Transfer/
ConfigReader.cpp
It should have been:
diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf
C:\Unicode\jordan-
unicode\host\src\Assisted File Transfer/ConfigReader.cpp
I'm using post-review with the following arguments in the P4V Client:
python C:\Python26\post-review.py %c --p4-client $c --p4-port $p
Do i need to change something in the post-review Configuration for the
new workspace ?
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: post-review tool
Can you provide the complete output of post-review -d? My first guess would be that it is due to a space in the file path. -Raghu On Apr 13, 10:25 am, roshanpius roshanpiustho...@gmail.com wrote: Hi , I've been using post-review tool for posting reviews for Review Board for a Perforce Repository. I've integrated the post-review tool into P4V which is the GUI P4 Client For Windows. This worked fine till now. But now i've created a new workspace and tried using post-review, but the diff didn't fetch the file from my hard disk. It was fetching the correct file from Repository, but not finding the correct edited file on my Workspace. I ran post-review with -d flag to get the debug logs and i noticed that the path on the Workspace that the diff was trying to fetch was completely wrong: diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf Transfer/ ConfigReader.cpp It should have been: diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf C:\Unicode\jordan- unicode\host\src\Assisted File Transfer/ConfigReader.cpp I'm using post-review with the following arguments in the P4V Client: python C:\Python26\post-review.py %c --p4-client $c --p4-port $p Do i need to change something in the post-review Configuration for the new workspace ? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool
The complete output of post-review -d :
p4 info
repository info: Path: :1666, Base path: None, Supports changesets:
True
Generating diff for changenum 10020
p4 describe -s 10020
Processing edit of //branch/host/src/Assisted File Transfer/AftMain.cpp
Writing //branch/host/src/Assisted File Transfer/AftMain.cpp#1 to
c:\docume~1\rpius\locals~1\temp\tmptkche3
p4 print -q //branch/host/src/Assisted File Transfer/AftMain.cpp#1
p4 where //branch/host/src/Assisted File Transfer/AftMain.cpp
diff -urNp c:\docume~1\rpius\locals~1\temp\tmptkche3 Transfer/AftMain.cpp
Processing edit of //branch/host/src/Assisted File
Transfer/ConfigReader.cpp
Writing //branch/host/src/Assisted File Transfer/ConfigReader.cpp#1 to
c:\docume~1\rpius\locals~1\temp\tmptkche3
p4 print -q //branch/host/src/Assisted File Transfer/ConfigReader.cpp#1
p4 where //branch/host/src/Assisted File Transfer/ConfigReader.cpp
diff -urNp c:\docume~1\rpius\locals~1\temp\tmptkche3
Transfer/ConfigReader.cpp
Processing edit of //branch/host/src/Assisted File Transfer/StdAfx.h
Writing //branch/host/src/Assisted File Transfer/StdAfx.h#1 to
c:\docume~1\rpius\locals~1\temp\tmptkche3
p4 print -q //branch/host/src/Assisted File Transfer/StdAfx.h#1
p4 where //branch/host/src/Assisted File Transfer/StdAfx.h
diff -urNp c:\docume~1\rpius\locals~1\temp\tmptkche3 Transfer/StdAfx.h
Looking for 'xxx.xxx.xxx.xxx /' cookie in C:\Documents and
Settings\username\Local Settings\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for 10020
HTTP POSTing to http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/new/:
{'repository_path': ':1666', 'changenum': '10020'}
Review request already exists. Updating it...
HTTP POSTing to
http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/186/update_from_changenum/:
{}
Review request created
Uploading diff, size: 37349
HTTP POSTing to
http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/186/diff/new/: {}
Review request #186 posted.
http://xxx.xxx.xxx.xxx:80/r/186
Thanks,
Roshan Pius
On Tue, Apr 14, 2009 at 6:15 PM, Raghu raghu...@gmail.com wrote:
Can you provide the complete output of post-review -d? My first guess
would be that it is due to a space in the file path.
-Raghu
On Apr 13, 10:25 am, roshanpius roshanpiustho...@gmail.com wrote:
Hi ,
I've been using post-review tool for posting reviews for Review Board
for a Perforce Repository. I've integrated the post-review tool into
P4V which is the GUI P4 Client For Windows. This worked fine till now.
But now i've created a new workspace and tried using post-review, but
the diff didn't fetch the file from my hard disk. It was fetching the
correct file from Repository, but not finding the correct edited file
on my Workspace.
I ran post-review with -d flag to get the debug logs and i noticed
that the path on the Workspace that the diff was trying to fetch was
completely wrong:
diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf Transfer/
ConfigReader.cpp
It should have been:
diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf C:\Unicode\jordan-
unicode\host\src\Assisted File Transfer/ConfigReader.cpp
I'm using post-review with the following arguments in the P4V Client:
python C:\Python26\post-review.py %c --p4-client $c --p4-port $p
Do i need to change something in the post-review Configuration for the
new workspace ?
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: post-review tool
Yeah, it's definitely due to spaces in the filenames. Eris Huss did some
work that should lead to a fix for this, I believe, but someone encountering
this problem needs to find where it's breaking and update the code to make
this work.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Tue, Apr 14, 2009 at 6:37 AM, roshan pius roshanpiustho...@gmail.comwrote:
The complete output of post-review -d :
p4 info
repository info: Path: :1666, Base path: None, Supports
changesets: True
Generating diff for changenum 10020
p4 describe -s 10020
Processing edit of //branch/host/src/Assisted File
Transfer/AftMain.cpp
Writing //branch/host/src/Assisted File Transfer/AftMain.cpp#1 to
c:\docume~1\rpius\locals~1\temp\tmptkche3
p4 print -q //branch/host/src/Assisted File Transfer/AftMain.cpp#1
p4 where //branch/host/src/Assisted File Transfer/AftMain.cpp
diff -urNp c:\docume~1\rpius\locals~1\temp\tmptkche3
Transfer/AftMain.cpp
Processing edit of //branch/host/src/Assisted File
Transfer/ConfigReader.cpp
Writing //branch/host/src/Assisted File Transfer/ConfigReader.cpp#1
to c:\docume~1\rpius\locals~1\temp\tmptkche3
p4 print -q //branch/host/src/Assisted File
Transfer/ConfigReader.cpp#1
p4 where //branch/host/src/Assisted File Transfer/ConfigReader.cpp
diff -urNp c:\docume~1\rpius\locals~1\temp\tmptkche3
Transfer/ConfigReader.cpp
Processing edit of //branch/host/src/Assisted File Transfer/StdAfx.h
Writing //branch/host/src/Assisted File Transfer/StdAfx.h#1 to
c:\docume~1\rpius\locals~1\temp\tmptkche3
p4 print -q //branch/host/src/Assisted File Transfer/StdAfx.h#1
p4 where //branch/host/src/Assisted File Transfer/StdAfx.h
diff -urNp c:\docume~1\rpius\locals~1\temp\tmptkche3 Transfer/StdAfx.h
Looking for 'xxx.xxx.xxx.xxx /' cookie in C:\Documents and
Settings\username\Local Settings\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for 10020
HTTP POSTing to http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/new/:
{'repository_path': ':1666', 'changenum': '10020'}
Review request already exists. Updating it...
HTTP POSTing to
http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/186/update_from_changenum/:
{}
Review request created
Uploading diff, size: 37349
HTTP POSTing to
http://xxx.xxx.xxx.xxx:80/api/json/reviewrequests/186/diff/new/: {}
Review request #186 posted.
http://xxx.xxx.xxx.xxx:80/r/186
Thanks,
Roshan Pius
On Tue, Apr 14, 2009 at 6:15 PM, Raghu raghu...@gmail.com wrote:
Can you provide the complete output of post-review -d? My first guess
would be that it is due to a space in the file path.
-Raghu
On Apr 13, 10:25 am, roshanpius roshanpiustho...@gmail.com wrote:
Hi ,
I've been using post-review tool for posting reviews for Review Board
for a Perforce Repository. I've integrated the post-review tool into
P4V which is the GUI P4 Client For Windows. This worked fine till now.
But now i've created a new workspace and tried using post-review, but
the diff didn't fetch the file from my hard disk. It was fetching the
correct file from Repository, but not finding the correct edited file
on my Workspace.
I ran post-review with -d flag to get the debug logs and i noticed
that the path on the Workspace that the diff was trying to fetch was
completely wrong:
diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf Transfer/
ConfigReader.cpp
It should have been:
diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf C:\Unicode\jordan-
unicode\host\src\Assisted File Transfer/ConfigReader.cpp
I'm using post-review with the following arguments in the P4V Client:
python C:\Python26\post-review.py %c --p4-client $c --p4-port $p
Do i need to change something in the post-review Configuration for the
new workspace ?
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
post-review tool
Hi , I've been using post-review tool for posting reviews for Review Board for a Perforce Repository. I've integrated the post-review tool into P4V which is the GUI P4 Client For Windows. This worked fine till now. But now i've created a new workspace and tried using post-review, but the diff didn't fetch the file from my hard disk. It was fetching the correct file from Repository, but not finding the correct edited file on my Workspace. I ran post-review with -d flag to get the debug logs and i noticed that the path on the Workspace that the diff was trying to fetch was completely wrong: diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf Transfer/ ConfigReader.cpp It should have been: diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf C:\Unicode\jordan- unicode\host\src\Assisted File Transfer/ConfigReader.cpp I'm using post-review with the following arguments in the P4V Client: python C:\Python26\post-review.py %c --p4-client $c --p4-port $p Do i need to change something in the post-review Configuration for the new workspace ? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 796 in reviewboard: post-review tool doesn't create a review if reviewboard was installed on a url that is not root at '/', e.g. '/reviews'
Comment #1 on issue 796 by minorgal: post-review tool doesn't create a review if reviewboard was installed on a url that is not root at '/', e.g. '/reviews' http://code.google.com/p/reviewboard/issues/detail?id=796 I am having this issue too, if you have a fix please let me know. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 796 in reviewboard: post-review tool doesn't create a review if reviewboard was installed on a url that is not root at '/', e.g. '/reviews'
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 796 by butchland: post-review tool doesn't create a review if reviewboard was installed on a url that is not root at '/', e.g. '/reviews' http://code.google.com/p/reviewboard/issues/detail?id=796 The post-review tool assumes that the reviewboard url is always at '/' e.g. 'http://reviews.example.com/'. If reviewboard was installed with a url like 'http://www.example.com/reviews/', the post-review tool cannot submit a new review. What steps will reproduce the problem? 1. Install reviewboard on a url that is not at the root of the site: In my case I installed it using the following modpython configuration: # Error handlers ErrorDocument 500 /errordocs/500.html # Serve django pages Location /reviewboard PythonPath ['/srv/reviewboard/conf'] + sys.path SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off # Used to run multiple mod_python sites in the same apache PythonInterpreter reviewboard_reviewboard /Location # Serve static media without running it through mod_python # (overrides the above) Location /media SetHandler None /Location Location /errordocs SetHandler None /Location # Alias static media requests to filesystem Alias /media /srv/reviewboard/htdocs/media Alias /errordocs /srv/reviewboard/htdocs/errordocs 2. Complete the reviewboard installation and configuration (including simplejson on the client) 3. Try to submit a review using post-review with option '--server=http://www.example.com/reviewboard' where http://www.example.com/reviewboard is the url of your reviewboard site. What is the expected output? What do you see instead? It should have created a new draft review request. Instead it returns a 404 error message like the following: 'Unable to access http://www.example.com/api/json/repositories/ (404). The host path may be invalid' What operating system are you using? What browser? This is on both Linux and windows. Browser is not relevant as I am using a commandline tool. Please provide any additional information below. The error is due to the fact that its trying to look up 'http://www.example.com/api/json/repositories' when it should be looking up 'http://www.example.com/reviewboard/api/json/repositories' I created a fix for it and have submitted for review. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Re: post-review tool issues
Sorry, Small typo.. C:\python2.6 %C --p4-client $c --p4-port $p I can see in the P4V command window the arguments getting populated properly : C:\python post-review.py 8624 --p4-client New_DepotView --p4-port xxx.xxx.xxx.xxx:1999 C:\python2.6\post-review.py %C --p4-client $c --p4-port $p I can see in the P4V command window the arguments getting populated properly : C:\python\post-review.py 8624 --p4-client New_DepotView --p4-port xxx.xxx.xxx.xxx:1999 On Dec 9, 9:21 am, roshanpius [EMAIL PROTECTED] wrote: Hi, I am having a small issue integrating post-review with P4V in the Windows systems. I've installed python2.6, setuptools, simplejson and GNU diffutils. Here is the problem I've renamed post-review to post-review.py(so that it gets associated automatically) and when i run it in command line with the appropriate arguments, it works perfectly well. But when I import it into P4V and run the same command, it says not able to execute the command: C:\python2.6 %C --p4-client $c --p4-port $p I can see in the P4V command window the arguments getting populated properly : C:\python post-review.py 8624 --p4-client New_DepotView --p4-port xxx.xxx.xxx.xxx:1999 What am I missing here.. ? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool issues
With that error, I'd definitely try setting Application to be the Python binary, and then use the script as the first parameter. P4V probably requires that the application itself be an actual binary, rather than assuming it will be opened with something else by file association. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Dec 8, 2008 at 9:55 PM, roshan pius [EMAIL PROTECTED]wrote: Hi Christian, It show the code being executed in their P4V command Window and then it pops up a message saying Unable to execute the command Error: Unable to run C:\Python26\post-review.py But the same command works on the command line... There is some issue here I'm attaching a screenshot of the configuration... Maybe someone with a knowledge of how P4V works can help... Thanks, Roshan Pius On Tue, Dec 9, 2008 at 11:01 AM, Christian Hammond [EMAIL PROTECTED] wrote: There's no error messages or any output? It's just doing nothing? I don't know a thing about how P4V works. What happens if you specify the python binary before the script name? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Dec 8, 2008 at 8:33 PM, roshanpius [EMAIL PROTECTED] wrote: Sorry, Small typo.. C:\python2.6 %C --p4-client $c --p4-port $p I can see in the P4V command window the arguments getting populated properly : C:\python post-review.py 8624 --p4-client New_DepotView --p4-port xxx.xxx.xxx.xxx:1999 C:\python2.6\post-review.py %C --p4-client $c --p4-port $p I can see in the P4V command window the arguments getting populated properly : C:\python\post-review.py 8624 --p4-client New_DepotView --p4-port xxx.xxx.xxx.xxx:1999 On Dec 9, 9:21 am, roshanpius [EMAIL PROTECTED] wrote: Hi, I am having a small issue integrating post-review with P4V in the Windows systems. I've installed python2.6, setuptools, simplejson and GNU diffutils. Here is the problem I've renamed post-review to post-review.py(so that it gets associated automatically) and when i run it in command line with the appropriate arguments, it works perfectly well. But when I import it into P4V and run the same command, it says not able to execute the command: C:\python2.6 %C --p4-client $c --p4-port $p I can see in the P4V command window the arguments getting populated properly : C:\python post-review.py 8624 --p4-client New_DepotView --p4-port xxx.xxx.xxx.xxx:1999 What am I missing here.. ? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool issues
You have a space before the script name. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Dec 8, 2008 at 10:17 PM, roshan pius [EMAIL PROTECTED]wrote: Hi Now I've made the changes i'm getting a new error now.. I've posted the config and the error screenshots. Thanks, Roshan Pius On Tue, Dec 9, 2008 at 11:35 AM, Christian Hammond [EMAIL PROTECTED] wrote: With that error, I'd definitely try setting Application to be the Python binary, and then use the script as the first parameter. P4V probably requires that the application itself be an actual binary, rather than assuming it will be opened with something else by file association. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Dec 8, 2008 at 9:55 PM, roshan pius [EMAIL PROTECTED] wrote: Hi Christian, It show the code being executed in their P4V command Window and then it pops up a message saying Unable to execute the command Error: Unable to run C:\Python26\post-review.py But the same command works on the command line... There is some issue here I'm attaching a screenshot of the configuration... Maybe someone with a knowledge of how P4V works can help... Thanks, Roshan Pius On Tue, Dec 9, 2008 at 11:01 AM, Christian Hammond [EMAIL PROTECTED] wrote: There's no error messages or any output? It's just doing nothing? I don't know a thing about how P4V works. What happens if you specify the python binary before the script name? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Dec 8, 2008 at 8:33 PM, roshanpius [EMAIL PROTECTED] wrote: Sorry, Small typo.. C:\python2.6 %C --p4-client $c --p4-port $p I can see in the P4V command window the arguments getting populated properly : C:\python post-review.py 8624 --p4-client New_DepotView --p4-port xxx.xxx.xxx.xxx:1999 C:\python2.6\post-review.py %C --p4-client $c --p4-port $p I can see in the P4V command window the arguments getting populated properly : C:\python\post-review.py 8624 --p4-client New_DepotView --p4-port xxx.xxx.xxx.xxx:1999 On Dec 9, 9:21 am, roshanpius [EMAIL PROTECTED] wrote: Hi, I am having a small issue integrating post-review with P4V in the Windows systems. I've installed python2.6, setuptools, simplejson and GNU diffutils. Here is the problem I've renamed post-review to post-review.py(so that it gets associated automatically) and when i run it in command line with the appropriate arguments, it works perfectly well. But when I import it into P4V and run the same command, it says not able to execute the command: C:\python2.6 %C --p4-client $c --p4-port $p I can see in the P4V command window the arguments getting populated properly : C:\python post-review.py 8624 --p4-client New_DepotView --p4-port xxx.xxx.xxx.xxx:1999 What am I missing here.. ? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool issues
Hi. I just ran some of the code through for that diff header and it appears to be working okay here. Perhaps there's something subtle we're not accounting for. Can you e-mail me (privately if you like) the actual debug output from post-review? You can strip anything you need to strip, but the diff header parts are pretty important. Output to a file instead of copying and pasting, because I'll need to check tabs vs. spaces and such. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Sun, Dec 7, 2008 at 2:26 AM, roshanpius [EMAIL PROTECTED]wrote: Hi guys, I have recently installed ReviewBoard for Code Reviews on a Linux server in my Company. We're running a Perforce SCM. Even though i had initially run into some issues regarding installation, it is finally up and running. But now i've hit another roadblock with the post-review tool. We've a development machine on which all of us have our P4 Workspaces. So I've to generate the diff from this development server to the other server on which reviewboard is running. But when I try to run the post-review tool on a changelist, I get an error with debug flag on: Unable to parse diff header: --- /tmp/tmpHMpfDv 2008-12-07 15:43:46.0 +0530 +++ /home/rpius/perforce/evros-dev1.6patch-rpius/nlg_rel1.6_patch/ common/evlog/evl_log.c 1970-01-01 05:30:00.0 +0530 @@ -1,731 +0,0 @@ The second file on my workspace has the time stamp wrong as well (01-01-1970). When I manually do a diff the time-stamp is correct (21-11-2008) diff -urNp /tmp/tmpHMpfDv /home/rpius/perforce/evros-dev1.6patch-rpius/ nlg_rel1.6_patch/common/evlog/evl_log.c --- /tmp/tmpH6xa0M 2008-12-07 15:31:23.0 +0530 +++ /home/rpius/perforce/evros-dev1.6patch-rpius/nlg_rel1.6_patch/ common/evlog/evl_log.c2008-11-21 22:00:53.0 +0530 What is happening here ?? I tried going through the post-review code(with no knowledge of python). What I found was that the post-review tool expects the time stamp to be the first thing on the diff(That is not the case as seen above) . Also the post-review tool appends --- and +++ after the diff is generated, but in my case this is already present in the diff command itself (as seen above). So the post-review tool doesn't seem to be getting the pattern it expects. So what do i do? Even when I deleted the portion of the code checking for the time stamps initially(line number 990-1023)...It still gives me another error when it tries to post the review - something about the arguments being messed up(obviously!!!) in the diff and thus unable to post it... I also read somewhere that this could be some problem with the older diffutils-2.8.1 But I've diffutils-2.8.7-80 On OpenSuse11.. Any Help would be greatly appreciated. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
where did the post-review tool go?
I blew everything away because I found the nifty-neato new installer... but as far as I can tell the post-review tool didn't come down. Where can I go to get the latest version? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Where is the post-review tool
I installed the latest stuff (blew everything away first) and can't find the latest version of the post-review tool. Where do I go to get it? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Where is the post-review tool
AndyP wrote: I installed the latest stuff (blew everything away first) and can't find the latest version of the post-review tool. Where do I go to get it? You can pull it down from svn (and you can even use wget if you don't have svn to hand): http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/contrib/tools/post-review Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Where is the post-review tool
Yeah, this is the way to do it. Before long (pre-1.0) I expect to make post-review its own easy_installable thing. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Dec 4, 2008 at 3:49 PM, Chris Clark [EMAIL PROTECTED] wrote: AndyP wrote: I installed the latest stuff (blew everything away first) and can't find the latest version of the post-review tool. Where do I go to get it? You can pull it down from svn (and you can even use wget if you don't have svn to hand): http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/contrib/tools/post-review Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Where is the post-review tool
I actually found it... in /usr/lib/python2.5/site-packages/ ReviewBoard.(egg stuff)../reviewboard/contrib/tools Is this the latest and greatest? I guess I have to ask: Does reviewboard support cygwin+perforce on a windows environment? I have had nothing but trouble getting the post- review tool to work. I took a break for a couple of months hoping that things would settle down... our production environment is running something that is old - probably around March or April timeframe. I had to hand-tweak the post-review tool back then to make it work (from suggestions on this forum)... but I was hoping that all that had gone away. I really like the new installer - that makes the server side a snap. The client side though... The latest trouble I am having is that for some reason the tool is Unable to parse diff header. It's pretty obvious why when I run the -d flag to debug - it is trying to use the diff tool against a windows- formatted-pathname. i.e. diff -urNp /cygdrive/c/path_to_file/myfile.cpp c:\path_to_file \myfile.cpp and of course the diff will fail - it can't do that under cygwin. On Dec 4, 3:49 pm, Chris Clark [EMAIL PROTECTED] wrote: AndyP wrote: I installed the latest stuff (blew everything away first) and can't find the latest version of the post-review tool. Where do I go to get it? You can pull it down from svn (and you can even use wget if you don't have svn to hand): http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/... Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Where is the post-review tool
It is probably the p4 where command that is throwing it off: $ p4 where //depot/dev/removed/gx/core/src/win32/desktop/myfile.cpp //depot/dev/removed/gx/core/src/win32/desktop/DesktopDeviceLite.cpp // apeterson-removed/removed/gx/core/src/win32/desktop/myfile.cpp c: \removed\gx\core\src\win32\desktop\myfile.cpp -- note that the 3rd output is in dos format. On Dec 4, 5:53 pm, AndyP [EMAIL PROTECTED] wrote: cygwin bash shell. That's the only access I have to python on the machine. we are using cygwin for the make system anyway - and reviewboard tools fall nicely in there - if I can get them to work! Thanks! On Dec 4, 5:41 pm, Christian Hammond [EMAIL PROTECTED] wrote: It has to do with people not using the right version of GNU diff, or weird stuff happening with file path delimiters with Cygwin. There's a change pending that will hopefully fix a lot of this up. Instead of calling out to diff, we'd be generating it inline. Are you running from cmd.exe or from the cygwin bash shell? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Dec 4, 2008 at 5:36 PM, AndyP [EMAIL PROTECTED] wrote: I actually found it... in /usr/lib/python2.5/site-packages/ ReviewBoard.(egg stuff)../reviewboard/contrib/tools Is this the latest and greatest? I guess I have to ask: Does reviewboard support cygwin+perforce on a windows environment? I have had nothing but trouble getting the post- review tool to work. I took a break for a couple of months hoping that things would settle down... our production environment is running something that is old - probably around March or April timeframe. I had to hand-tweak the post-review tool back then to make it work (from suggestions on this forum)... but I was hoping that all that had gone away. I really like the new installer - that makes the server side a snap. The client side though... The latest trouble I am having is that for some reason the tool is Unable to parse diff header. It's pretty obvious why when I run the -d flag to debug - it is trying to use the diff tool against a windows- formatted-pathname. i.e. diff -urNp /cygdrive/c/path_to_file/myfile.cpp c:\path_to_file \myfile.cpp and of course the diff will fail - it can't do that under cygwin. On Dec 4, 3:49 pm, Chris Clark [EMAIL PROTECTED] wrote: AndyP wrote: I installed the latest stuff (blew everything away first) and can't find the latest version of the post-review tool. Where do I go to get it? You can pull it down from svn (and you can even use wget if you don't have svn to hand): http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/... Chris- Hide quoted text - - Show quoted text -- Hide quoted text - - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Where is the post-review tool
Yeah, that would do it. You sohuld be able to run Cygwin stuff from a dos box if you specify the full path to python. Could do a post-review wrapper script that does: c:\cygwin\bin\python \path\to\post-review blah blah See if it works at all. Ideally we'd make this work with cygwin, certainly, but I don't have anything set up to work on this right now so I'm not in a good position to investigate and fix it. Any takers? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Dec 4, 2008 at 5:59 PM, AndyP [EMAIL PROTECTED] wrote: It is probably the p4 where command that is throwing it off: $ p4 where //depot/dev/removed/gx/core/src/win32/desktop/myfile.cpp //depot/dev/removed/gx/core/src/win32/desktop/DesktopDeviceLite.cpp // apeterson-removed/removed/gx/core/src/win32/desktop/myfile.cpp c: \removed\gx\core\src\win32\desktop\myfile.cpp -- note that the 3rd output is in dos format. On Dec 4, 5:53 pm, AndyP [EMAIL PROTECTED] wrote: cygwin bash shell. That's the only access I have to python on the machine. we are using cygwin for the make system anyway - and reviewboard tools fall nicely in there - if I can get them to work! Thanks! On Dec 4, 5:41 pm, Christian Hammond [EMAIL PROTECTED] wrote: It has to do with people not using the right version of GNU diff, or weird stuff happening with file path delimiters with Cygwin. There's a change pending that will hopefully fix a lot of this up. Instead of calling out to diff, we'd be generating it inline. Are you running from cmd.exe or from the cygwin bash shell? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Dec 4, 2008 at 5:36 PM, AndyP [EMAIL PROTECTED] wrote: I actually found it... in /usr/lib/python2.5/site-packages/ ReviewBoard.(egg stuff)../reviewboard/contrib/tools Is this the latest and greatest? I guess I have to ask: Does reviewboard support cygwin+perforce on a windows environment? I have had nothing but trouble getting the post- review tool to work. I took a break for a couple of months hoping that things would settle down... our production environment is running something that is old - probably around March or April timeframe. I had to hand-tweak the post-review tool back then to make it work (from suggestions on this forum)... but I was hoping that all that had gone away. I really like the new installer - that makes the server side a snap. The client side though... The latest trouble I am having is that for some reason the tool is Unable to parse diff header. It's pretty obvious why when I run the -d flag to debug - it is trying to use the diff tool against a windows- formatted-pathname. i.e. diff -urNp /cygdrive/c/path_to_file/myfile.cpp c:\path_to_file \myfile.cpp and of course the diff will fail - it can't do that under cygwin. On Dec 4, 3:49 pm, Chris Clark [EMAIL PROTECTED] wrote: AndyP wrote: I installed the latest stuff (blew everything away first) and can't find the latest version of the post-review tool. Where do I go to get it? You can pull it down from svn (and you can even use wget if you don't have svn to hand): http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/... Chris- Hide quoted text - - Show quoted text -- Hide quoted text - - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
