Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

[Jayush Luniya]

> On Jan. 23, 2018, 5:13 p.m., Jayush Luniya wrote:
> > Ship It!

Bharat,
Can you commit this patch to trunk and branch-2.6 so that it gets picked up in 
the next Ambari release?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/#review196035
---


On May 2, 2017, 5:28 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58927/
> ---
> 
> (Updated May 2, 2017, 5:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20908
> https://issues.apache.org/jira/browse/AMBARI-20908
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  680dd32 
> 
> 
> Diff: https://reviews.apache.org/r/58927/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with default installation and added advertised.listeners
> and enabled kerberos and then checked advertised.listeners to see if it is 
> same as user provided.
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58927/#review196035
---


Ship it!




Ship It!

- Jayush Luniya


On May 2, 2017, 5:28 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58927/
> ---
> 
> (Updated May 2, 2017, 5:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-20908
> https://issues.apache.org/jira/browse/AMBARI-20908
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  680dd32 
> 
> 
> Diff: https://reviews.apache.org/r/58927/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with default installation and added advertised.listeners
> and enabled kerberos and then checked advertised.listeners to see if it is 
> same as user provided.
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 64693: Add service group dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64693/#review194150
---



Unit tests?

- Jayush Luniya


On Dec. 18, 2017, 11:53 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64693/
> ---
> 
> (Updated Dec. 18, 2017, 11:53 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and 
> Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Chnaged adding service group dependency by name, not by id. Fixed 
> add/get/delete requests.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java
>  9389f0c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java
>  9f4eea3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java
>  1a4b4ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
>  aac7102 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupDependencyEntity.java
>  ee0beeb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  914b65a 
> 
> 
> Diff: https://reviews.apache.org/r/64693/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 64637: Livy/Livy2 Unable To Start Due to Address Already In Use

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64637/#review193872
---


Ship it!




Ship It!

- Jayush Luniya


On Dec. 15, 2017, 3:03 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64637/
> ---
> 
> (Updated Dec. 15, 2017, 3:03 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22655
> https://issues.apache.org/jira/browse/AMBARI-22655
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While restarting Livy and Livy2 on a non-root cluster, the following is seen:
> 
> ```
> 17/12/14 14:36:23 WARN LivyConf: The configuration key 
> livy.repl.enableHiveContext has been deprecated as of Livy 0.4 and may be 
> removed in the future. Please use the new key livy.repl.enable-hive-context 
> instead.
> 17/12/14 14:36:23 WARN LivyConf: The configuration key 
> livy.server.csrf_protection.enabled has been deprecated as of Livy 0.4 and 
> may be removed in the future. Please use the new key 
> livy.server.csrf-protection.enabled instead.
> 17/12/14 14:36:23 INFO AccessManager: AccessControlManager acls 
> disabled;users with view permission: ;users with modify permission: ;users 
> with super permission: cstm-zeppelin;other allowed users: *
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Welcome to
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:     __
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:  / __/__  ___ _/ 
> /__
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: _\ \/ _ \/ _ `/ __/  
> '_/
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:/___/ .__/_,_/_/ /_/_\  
>  version 2.2.0.2.6.4.0-73
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:   /_/
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout:
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Using Scala version 
> 2.11.8, OpenJDK 64-Bit Server VM, 1.8.0_131
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Branch HEAD
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Compiled by user jenkins 
> on 2017-12-13T19:08:32Z
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Revision 
> a24017869f5450397136ee8b11be818e7cd3facb
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Url 
> g...@github.com:hortonworks/spark2.git
> 17/12/14 14:36:28 INFO LineBufferedStream: stdout: Type --help for more 
> information.
> 17/12/14 14:36:29 WARN NativeCodeLoader: Unable to load native-hadoop library 
> for your platform... using builtin-java classes where applicable
> 17/12/14 14:36:31 INFO AHSProxy: Connecting to Application History server at 
> nat-yc-r7-ovvs-ambari-autostart-4-re-2.openstacklocal/172.22.121.144:10200
> 17/12/14 14:36:32 WARN DomainSocketFactory: The short-circuit local reads 
> feature cannot be used because libhadoop cannot be loaded.
> 17/12/14 14:36:33 INFO StateStore$: Using FileSystemStateStore for recovery.
> 17/12/14 14:36:33 INFO BatchSessionManager: Recovered 0 batch sessions. Next 
> session id: 0
> 17/12/14 14:36:33 INFO InteractiveSessionManager: Recovered 0 interactive 
> sessions. Next session id: 0
> 17/12/14 14:36:33 INFO InteractiveSessionManager: Heartbeat watchdog thread 
> started.
> 17/12/14 14:36:33 INFO LivyServer: SPNEGO auth enabled (principal = 
> HTTP/nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklo...@example.com)
> 17/12/14 14:36:33 INFO LivyServer: CSRF protection is enabled.
> 17/12/14 14:36:34 INFO KerberosAuthenticationHandler: Login using keytab 
> /etc/security/keytabs/spnego.service.keytab, for principal 
> HTTP/nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklo...@example.com
> 17/12/14 14:36:34 INFO KerberosAuthenticationHandler: Map server: 
> nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklocal to principal: 
> [HTTP/nat-yc-r7-ovvs-ambari-autostart-4-re-3.openstacklo...@example.com], 
> added = true
> 17/12/14 14:36:34 WARN AbstractLifeCycle: FAILED 
> ServerConnector@df1cff6{SSL-http/1.1}{0.0.0.0:8999}: java.net.BindException: 
> Address already in use
> java.net.BindException: Address already in use
> at sun.nio.ch.Net.bind0(Native Method)
> ```
> 
> This occurs because the PID file cannot be accessed by the non-root agent and 
> returns an exit code of 1:
> {code}
> call returned (1, 'cat: /var/run/livy/livy-cstm-livy-server.pid: Permission 
> denied')
> {code}
> 
> This tricks out PID detection into thinking that

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64594/#review193820
---




ambari-common/src/main/python/resource_management/libraries/functions/stack_settings.py
Lines 24 (patched)
<https://reviews.apache.org/r/64594/#comment272454>

STACK_NAME_SETTING_KEY or STACK_NAME_PROPERTY

Lets try not to use CONFIG to avoid confusion.


- Jayush Luniya


On Dec. 14, 2017, 9:02 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64594/
> ---
> 
> (Updated Dec. 14, 2017, 9:02 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22649
> https://issues.apache.org/jira/browse/AMBARI-22649
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Background : AMBARI-22198 added "stack settings", and AMBARI-22196 introduced 
> "cluster settings" in Ambari.
> 
> **==**
> **Library for querying _clusterSettings_ and _stackSettings_ for its contents 
> in command*.json.**
> **==**
> 
> One should be able to query for a given **clusterSettings** or 
> **stackSettings**:
>  -  by passing in the setting name(one or more) in order to get it back as 
> key-value map, or
>  -  just get the value back for a passed-in setting.
> 
> 
> **Functions for clusterSettings:**
> **--**
>   - **get_cluster_setting_entries(setting_names)** : 
> -- Retrieves the passed-in cluster setting entr(y/ies) and their values 
> as a map.
>If 'setting_names' is passed-in as None : all the settings names and 
> their corresponding values will be returned as map.
>If 'setting_names' is passed-in as empty set : None will be returned.
> 
>   - **get_cluster_setting_value(setting_name)** :
> -- Retrieves the passed-in cluster setting entry's value.
> 
>   - **is_security_enabled()** : 
> -- Retrieves the cluster's security status.
> 
> 
> **Functions for stackSettings:** 
> ****
> 
> Stack settings as of now has 5 settings : stack_name, stack_root, 
> stack_features, stack_tools, stack_packages. stack_name, stack_root have 
> string as values, whereas stack_features, stack_tools, stack_packages have 
> values as JSON. Further there already exists python functions in files : 
> **stack_features.py**, **stack_tools.py** and **stack_select.py**.
> 
>- **get_stack_setting_entries(setting_names)** : 
>   --   Retrieves the passed-in stack setting entr(y/ies) and their values 
> as a map.
> If 'setting_names' is passed-in as None, all the settings names 
> and their corresponding values will be returned as map.
> If 'setting_names' is passed-in as empty set : None will be 
> returned.
> 
>- **get_stack_setting_value(setting_name)**:
> -- Retrieves the passed-in stack setting entry's value.
> 
> - **get_stack_name()**:
> -- Retrieves the stack name.
> 
> - **get_stack_root()**:
>-- Retrieves the stack root.
> 
>  
> 
> **Modifications in  _stack_features.py, stack_tools.py and stack_select.py_ 
> files:**
> **-**
> 
> - Given that these already exist and as of now they read the relevant stack 
> setting from *configurations/cluster_env*. 
> - Thus, code has been added to try reading from /stackSettings first by 
> calling the new fn.() get_stack_setting_value(). if setting not found, go for 
> the fall back  *configurations/cluster_env* (which would be removed soon, 
> when we remove cluster_env).
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/cluster_settings.py
>  PRE-CREATION 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  92823b0 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  b741a33 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_settings.py
>  PRE-CREATION 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  d9233a3 
> 
> 
> Diff: https://reviews.apache.org/r/64594

Re: Review Request 64528: Zeppelin Interpreter settings are getting updated after zeppelin restart

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64528/#review193570
---


Ship it!




Ship It!

- Jayush Luniya


On Dec. 12, 2017, 4:21 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64528/
> ---
> 
> (Updated Dec. 12, 2017, 4:21 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22626
> https://issues.apache.org/jira/browse/AMBARI-22626
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin Interpreter settings are getting updated after zeppelin restart.
> 
> Steps to reproduce :
> 1) Update the zeppelin.pyspark.python to /base/tools/python-2.7.14/bin/python 
> for spark2 interpreter
> 2) Restart zeppelin
> 3) After restart zeppelin.pyspark.python is getting overridden with value 
> 'python'.
> Same is observed with livy2 interpreter.
> 
> But same steps for spark interpreter is working fine even after zeppelin 
> restart.
> 
> So looks like issue is happening only for spark2 and livy2 interpreter.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
>  713db232b1 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
>  c9030bd33e 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  bb4c5b227b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/spark2_config_template.py
>  28a63c6f1b 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  4b4dc1fe48 
> 
> 
> Diff: https://reviews.apache.org/r/64528/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> File Attachments
> 
> 
> AMBARI-22626_branch-2.6_v1.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/12/12/6c85f9cf-ad03-466d-9dee-6813260b1275__AMBARI-22626_branch-2.6_v1.patch
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 64397: AMBARI-22602. Add 'clusterSettings' and 'stackSettings' parameters in Execution Command.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64397/#review193406
---




ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
Lines 291 (patched)
<https://reviews.apache.org/r/64397/#comment271960>

settings or clusterSettings instead of params?



ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
Lines 300 (patched)
<https://reviews.apache.org/r/64397/#comment271961>

settings or stackSettings instead of params?


- Jayush Luniya


On Dec. 7, 2017, 8:11 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64397/
> ---
> 
> (Updated Dec. 7, 2017, 8:11 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22602
> https://issues.apache.org/jira/browse/AMBARI-22602
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-22198 added "stack settings", and AMBARI-22196 introduced "cluster 
> settings" in Ambari.
> 
> This review adds 2 new parameters to Execution Command : **(1).** 
> clusterSettings and **(2).** stackSettings, and adds their respective set of 
> key-values pairs.
> 
> - This enables these parameters to be passed in to the ambari-agent's 
> **command*.json**.
> 
> 
> Test cases are tracked in : AMBARI-22603
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  5ee4bf6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  e7dea06 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  59e6622 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  9043297 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  8bd24f2 
> 
> 
> Diff: https://reviews.apache.org/r/64397/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on Live cluster doing following : 
> (1). Start Service 
> (2). Restart Service 
> (3). Stop Service 
> (4). Refreshing client configs
> (5). Adding Client.
> 
> 
> **Snippet from command*.json as part of testing:**
> {
> ...
> ...
> "clusterSettings": {
> "security_enabled": "false",
> "hide_yarn_memory_widget": "false",
> "enable_external_ranger": "false",
> "override_uid": "true",
> "kerberos_domain": "EXAMPLE.COM",
> "one_dir_per_partition": "false",
> "repo_ubuntu_template": "{{package_type}} {{base_url}} 
> {{components}}",
> "ignore_groupsusers_create": "false",
> "alerts_repeat_tolerance": "1",
> "namenode_rolling_restart_timeout": "4200",
> "fetch_nonlocal_groups": "true",
> "manage_dirs_on_root": "true",
> "recovery_lifetime_max_count": "1024",
> "agent_mounts_ignore_list": "",
> "ignore_bad_mounts": "false",
> "recovery_window_in_minutes": "60",
> "sysprep_skip_copy_tarballs_hdfs": "false",
> "recovery_type": "AUTO_START",
> "user_group": "hadoop",
> "namenode_rolling_restart_safemode_exit_timeout": "3600",
> "recovery_retry_interval": "5",
> "sysprep_skip_copy_oozie_share_lib_to_hdfs": "false",
> "sysprep_skip_setup_jce": "false",
> "manage_hive_fsroot": "true",
> "service_check_type": "full",
> "recovery_enabled": "true",
> "recovery_max_count": "6",
> "sysprep_skip_create_users_and_groups": "false",
> "smokeuser_keytab": "/etc/security/keytabs/smokeuser.headless.keytab",
> "managed_hdfs_resource_property_names": "false&qu

Re: Review Request 63923: Unable to enable hdfs, hive plugin in ranger

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63923/#review191389
---


Ship it!




Ship It!

- Jayush Luniya


On Nov. 17, 2017, 6:01 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63923/
> ---
> 
> (Updated Nov. 17, 2017, 6:01 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Swapan Shridhar, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-22468
> https://issues.apache.org/jira/browse/AMBARI-22468
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exception in stack recommendation call due to null pointer for streamline-env 
> configuration
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> a16fdb737a 
> 
> 
> Diff: https://reviews.apache.org/r/63923/diff/1/
> 
> 
> Testing
> ---
> 
> Enabled Hive and HDFS plugin successfully.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 63742: Add service dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63742/#review190786
---


Ship it!




Ship It!

- Jayush Luniya


On Nov. 10, 2017, 11:11 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63742/
> ---
> 
> (Updated Nov. 10, 2017, 11:11 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and 
> Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22345
> https://issues.apache.org/jira/browse/AMBARI-22345
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Second part of patch. Did some code cleanup. Also reimplemented API and BE to 
> use sevice dependency id.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  afdfcc4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java
>  97fe502 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java
>  d8d89da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterServiceDAO.java
>  0eeb19b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java
>  976bb67 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDependencyEntity.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 27d37e3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> c4c2d84 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> bfb04be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  755a80f 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e1e7c9e 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b438e69 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql aab7f95 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8832818 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 135707b 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 7d93aad 
>   ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5 
> 
> 
> Diff: https://reviews.apache.org/r/63742/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63653: Add service group dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63653/#review190612
---


Ship it!




Ship It!

- Jayush Luniya


On Nov. 9, 2017, 12:16 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63653/
> ---
> 
> (Updated Nov. 9, 2017, 12:16 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, Madhuvanthi 
> Radhakrishnan, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added id column for service group dependency.
> Tested and fixed cross cluster mapping
> Did some code cleanup
> 
> P.S. I've added changes only for postgres .sql file. After First review, if 
> main part is ok, i will add changes and test other dbs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  0638a06 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java
>  e9cf937 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
>  78610d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java
>  63e78d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupDependencyEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  1bcdd80 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 2193c3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 3d59c96 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  7737c0d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  881f172 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 36ff3b7 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 70a6543 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7c5f0fd 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql dfef1ce 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 870555d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 641b959 
>   ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5 
> 
> 
> Diff: https://reviews.apache.org/r/63653/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63205/#review189819
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 25, 2017, 6:44 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63205/
> ---
> 
> (Updated Oct. 25, 2017, 6:44 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22198
> https://issues.apache.org/jira/browse/AMBARI-22198
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This JIRA work assumes the following things to be present in the stack (3.0 
> onwards) coming from the mpack (as there is no inheritance in stacks, given 
> the flat stack structure coming from mpacks):
> 
> - **settings.xml** file in 
> **/var/lib/ambari-server/resources/stacks///configuration**
> 
> - **stack_features.json**, **stack_packages.json** and **stack_tools.json** 
> present in 
> **/var/lib/ambari-server/resources/stacks///properties/**
>  directory.
> 
> 
> Above work is done as part of JIRA : AMBARI-22285
> 
> 
> --
> 
> 
> **Work done in this Review Request:**
> 
> - Implement the new read only 
> http://:/api/v1/stacks//versions//settings 
> API.
> It serves the following settings : **stack_features**, **stack_name**, 
> **stack_packages**, **stack_root** and **stack_tools**.
> 
> - Renaming of files for Cluster Settings related code (work done in  
> AMBARI-22196).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootStackSettingsResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  1c0a555 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
>  d77b347 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  aef7fc1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  ce61497 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8a038cc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootStackSettingsResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
>  4cb6cd9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
>  fcda654 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManagerFactory.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 878415b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 07d28ce 
>   ambari-server/src/main/resources/stacks/HDP/3.0/configuration/settings.xml 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63205/diff/4/
> 
> 
> Testing
> ---
> 
> **Testing on 2.6 stack** (stack version in general has no effect on what we 
> are testing here)
> 
> 
> - **GET http://:/api/v1/stacks/HDP/versions/2.6/settings**
> 
> 
> {
>   "href" : "http://:/api/v1/stacks/HDP/versions/2.6/settings",
>   "items" : [
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_features",
>   "StackSettingsInfo" : {
> "property_name" : "stack_features",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
>   

Re: Review Request 63441: Remove Slider from Ambari stack definition of HDP 3.0

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63441/#review189818
---



This will break HIVE LLAP as it uses slider. Please don't make any changes to 
HDP-3.0 stack for now.

- Jayush Luniya


On Oct. 31, 2017, 1:35 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63441/
> ---
> 
> (Updated Oct. 31, 2017, 1:35 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22340
> https://issues.apache.org/jira/browse/AMBARI-22340
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Slider is no longer a service on it's own in HDP 3.0, it is a part of YARN. 
> So it should be removed from the stack definition.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 
> db490c9 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-client.xml
>  adeba58 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-env.xml
>  ce06a18 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-log4j.xml
>  cd9b2a4 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/kerberos.json
>  8f07b42 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/metainfo.xml
>  168a2df 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/files/hbaseSmokeVerify.sh
>  5c320c0 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/__init__.py
>  5561e10 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params.py
>  c03329c 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_linux.py
>  350be45 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_windows.py
>  fd2f358 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/service_check.py
>  8582b5e 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider.py
>  83c5629 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider_client.py
>  45c7785 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/templates/storm-slider-env.sh.j2
>  8022a4b 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/service_advisor.py
>  5614868 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 
> 061587d 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 
> 23f558d 
> 
> 
> Diff: https://reviews.apache.org/r/63441/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local vagrant cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 63457: Add service dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63457/#review189815
---


Ship it!




Ship It!

- Jayush Luniya


On Nov. 1, 2017, 12:20 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63457/
> ---
> 
> (Updated Nov. 1, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22345
> https://issues.apache.org/jira/browse/AMBARI-22345
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> API:
> {code}
> POST 
> http://SERVER:8080/api/v2/clusters/{cluster-id}/servicegroups/{sgId}/services
> 
> Request
> 
> {
>   "ServiceInfo" : {
> "service_name" : "{service-name}",
> "service_display_name" : "{service-display-name}",
> "service_version" : "{service-version}",
> "stack_id" : "{stack-id}",
> "hosting_platform" : "Ambari|Yarn"
>   }
>   "dependencies" : [
>   {
> "ServiceInfo" : {
>   "service_id" : "{dependent-service-id}",
>   "cluster_id" : "{dependent-cluster-id}",
>   "service_group_id" : "{dependent-service-group-id}",
>}
>   }
> ]
> }
> {code}
> 
> DB:
> Add table {{servicedependencies}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceDependencyResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java
>  8255674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  cb0ad20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  f75a7d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  cfab185 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java
>  9fca099 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> b9ab79f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java
>  b48d825 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 167e4ca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  1e4d81f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63457/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63457: Add service dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63457/#review189814
---




ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
Lines 172 (patched)
<https://reviews.apache.org/r/63457/#comment267023>

Similar feedback for using id as primary key as in the case of 
servicegroupdependencies. Please address those in a follow up commit.


- Jayush Luniya


On Nov. 1, 2017, 12:20 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63457/
> ---
> 
> (Updated Nov. 1, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22345
> https://issues.apache.org/jira/browse/AMBARI-22345
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> API:
> {code}
> POST 
> http://SERVER:8080/api/v2/clusters/{cluster-id}/servicegroups/{sgId}/services
> 
> Request
> 
> {
>   "ServiceInfo" : {
> "service_name" : "{service-name}",
> "service_display_name" : "{service-display-name}",
> "service_version" : "{service-version}",
> "stack_id" : "{stack-id}",
> "hosting_platform" : "Ambari|Yarn"
>   }
>   "dependencies" : [
>   {
> "ServiceInfo" : {
>   "service_id" : "{dependent-service-id}",
>   "cluster_id" : "{dependent-cluster-id}",
>   "service_group_id" : "{dependent-service-group-id}",
>}
>   }
> ]
> }
> {code}
> 
> DB:
> Add table {{servicedependencies}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceDependencyResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java
>  8255674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  cb0ad20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  f75a7d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  cfab185 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java
>  9fca099 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> b9ab79f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java
>  b48d825 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 167e4ca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  1e4d81f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63457/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63051: Add service group dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/#review189813
---


Ship it!




Go ahead and commit this patch and make the suggested changes in a separate 
patch.

- Jayush Luniya


On Oct. 25, 2017, 11:18 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63051/
> ---
> 
> (Updated Oct. 25, 2017, 11:18 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add table servicegroupdependencies
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupDependencyResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
>  13bdd7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  1e2eaf4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  f75a7d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  cfab185 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  7f8facb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 9850462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
>  7146bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  735a946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  1e4d81f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63051/diff/8/
> 
> 
> Testing
> ---
> 
> Will fix tests after patch approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63051: Add service group dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/#review189812
---




ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
Lines 162 (patched)
<https://reviews.apache.org/r/63051/#comment267021>

Add an id column to the table as primary key (i.e. dependency_id)



ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
Lines 167 (patched)
<https://reviews.apache.org/r/63051/#comment267022>

Make this as unique constraint rather than primary key and add "id" as 
primary key. See alerts tables for example

CREATE TABLE alert_group (
  group_id BIGINT NOT NULL,
  cluster_id BIGINT NOT NULL,
  group_name VARCHAR(255) NOT NULL,
  is_default SMALLINT NOT NULL DEFAULT 0,
  service_name VARCHAR(255),
  CONSTRAINT PK_alert_group PRIMARY KEY (group_id),
  CONSTRAINT uni_alert_group_name UNIQUE(cluster_id,group_name)
    );


- Jayush Luniya


On Oct. 25, 2017, 11:18 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63051/
> ---
> 
> (Updated Oct. 25, 2017, 11:18 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add table servicegroupdependencies
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupDependencyResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
>  13bdd7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  1e2eaf4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  f75a7d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  cfab185 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  7f8facb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 9850462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
>  7146bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  735a946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  1e4d81f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63051/diff/8/
> 
> 
> Testing
> ---
> 
> Will fix tests after patch approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63051: Add service group dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/#review189810
---



[~vbrodetskyi]
Generally this API looks good. If we make the API to use dependency_id instead 
of dependency_service_group_name as key we can potentially support 
cross-cluster mappings. You can either make this change in this iteration or 
make the change in a separate patch.

{code}
GET /api/v1/clusters/fff/servicegroups/core/dependencies/1
{
  "ServiceGroupDependencyInfo" : {
"cluster_id" : 2,
"cluster_name" : "fff",
"service_group_id" : 2,
"service_group_name" : "core",
"dependency_id" : 1,
"dependency_cluster_id" : 2,
"dependency_cluster_name" : "fff",
    "dependency_service_group_id" : 5,
"dependency_service_group_name" : "test2"
  }
}
{code}

- Jayush Luniya


On Oct. 25, 2017, 11:18 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63051/
> ---
> 
> (Updated Oct. 25, 2017, 11:18 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add table servicegroupdependencies
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupDependencyResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
>  13bdd7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  1e2eaf4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  f75a7d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  cfab185 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  7f8facb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 9850462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
>  7146bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  735a946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  1e4d81f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63051/diff/8/
> 
> 
> Testing
> ---
> 
> Will fix tests after patch approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63205/#review188978
---




ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
Lines 1065 (patched)
<https://reviews.apache.org/r/63205/#comment265915>

Rename to {stackName}/versions/{stackVersion}/settings instead?


- Jayush Luniya


On Oct. 22, 2017, 11:46 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63205/
> ---
> 
> (Updated Oct. 22, 2017, 11:46 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22198
> https://issues.apache.org/jira/browse/AMBARI-22198
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This JIRA work assumes the following things to be present in the stack (3.0 
> onwards) coming from the mpack (as there is no inheritance in stacks, given 
> the flat stack structure coming from mpacks):
> 
> - **settings.xml** file in 
> **/var/lib/ambari-server/resources/stacks///configuration**
> 
> - **stack_features.json**, **stack_packages.json** and **stack_tools.json** 
> present in 
> **/var/lib/ambari-server/resources/stacks///properties/**
>  directory.
> 
> 
> Above work is done as part of JIRA : AMBARI-22285
> 
> 
> --
> 
> 
> **Work done in this Rveiew Request:**
> 
> - Implement the new read only 
> http://:/api/v1/stacks//versions//stack_settings
>  API.
> It serves the following settings : **stack_features**, **stack_name**, 
> **stack_packages**, **stack_root** and **stack_tools**.
> 
> - Renaming of files for Cluster Settings related code (work done in  
> AMBARI-22196).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootStackSettingsResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  2bb450b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
>  d77b347 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  aef7fc1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  ce61497 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  28b5c28 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootStackSettingsResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
>  4cb6cd9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
>  fcda654 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManagerFactory.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 878415b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 07d28ce 
> 
> 
> Diff: https://reviews.apache.org/r/63205/diff/1/
> 
> 
> Testing
> ---
> 
> **Testing on 2.6 stack** (stack version in general has no effect on what we 
> are testing here)
> 
> 
> - **GET http://:/api/v1/stacks/HDP/versions/2.6/stack_settings**
> 
> 
> {
>   "href" : "http://:/api/v1/stacks/HDP/versions/2.6/stack_settings",
>   "items" : [
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/stack_settings/stack_features",
>   "StackSettingsInfo" : {
> "property_name" : "stack_features"

Re: Review Request 63051: Add service group dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/#review188693
---



Can you add some sample POST, GET APIs?

- Jayush Luniya


On Oct. 19, 2017, 2:58 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63051/
> ---
> 
> (Updated Oct. 19, 2017, 2:58 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add table servicegroupdependencies
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
>  53c3d1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  7f8facb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 9850462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
>  7146bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  735a946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fcc07b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63051/diff/5/
> 
> 
> Testing
> ---
> 
> Will fix tests after patch approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62989: AMBARI-22238 : Maven cleanup of ambari utility, logsearch and ambari metrics modules

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62989/#review188059
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 13, 2017, 8:50 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62989/
> ---
> 
> (Updated Oct. 13, 2017, 8:50 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Miklos Gergely, Oliver Szabo, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-22238
> https://issues.apache.org/jira/browse/AMBARI-22238
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove
> annotations-1.3.2.jar
> tools-#.jar
> jdk.tools-#.jar
> checkstyle-#.jar
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 283179c 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml a439266 
>   ambari-metrics/ambari-metrics-assembly/pom.xml b6b9ad7 
>   ambari-metrics/ambari-metrics-common/pom.xml b52b1d9 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 25373e7 
>   utility/pom.xml a708384 
> 
> 
> Diff: https://reviews.apache.org/r/62989/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review188038
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 12, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 12, 2017, 11:47 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  98b1edf6a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  3bde889b4b 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/3/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/#review187736
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 11, 2017, 8:26 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62802/
> ---
> 
> (Updated Oct. 11, 2017, 8:26 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Following done as part of this JIRA:**
> 
> - Move all non-stack specific configs in **cluster-env.xml** to 
> **cluster-settings.xml**.
> - For example **cluster-env/security_enabled** is a cluster setting and 
> shouldn't be associated with any **stack/mpack**. 
> {code}
>   
> security_enabled
> false
> Hadoop Security
> 
>   
> {code}
> 
> - Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml** 
> which includes all the read only cluster specific settings.
> 
> 
> - **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings
> 
> 
> **Followup work :**
> 
> - **AMBARI-22197** takes care of removing **cluster-env.xml** and associated 
> code and API once we have **AMBARI-22198** completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/PropertyNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  7431f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootClusterSettingsResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  fd15105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  67d3a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  f2c4c52 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  c56483d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
>  fb31c19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
>  ea67207 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
>  d33b5cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  0c5a579 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootClusterSettingsResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  f8feef2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
>  6f5b0f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
>  819507b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  a364c4c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 63c850e 
>   ambari-server/src/main/resources/cluster-settings.xml PRE-

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62895/#review187702
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 11, 2017, 4:17 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62895/
> ---
> 
> (Updated Oct. 11, 2017, 4:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi 
> Radhakrishnan.
> 
> 
> Bugs: AMBARI-22209
> https://issues.apache.org/jira/browse/AMBARI-22209
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix quick links in mpacks.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 1cad4df 
> 
> 
> Diff: https://reviews.apache.org/r/62895/diff/1/
> 
> 
> Testing
> ---
> 
> will check tests after approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

[Jayush Luniya]

> On Oct. 11, 2017, 6:45 p.m., Madhuvanthi Radhakrishnan wrote:
> > We might want to add it to trunk itself. Thanks

The serviceInfo.clone() is something I added for the mpack generator. So the 
patch won't be applicable there. Lets just fix this in the feature branch. 
Eventually we will be merging to trunk.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62895/#review187681
---


On Oct. 11, 2017, 4:17 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62895/
> ---
> 
> (Updated Oct. 11, 2017, 4:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi 
> Radhakrishnan.
> 
> 
> Bugs: AMBARI-22209
> https://issues.apache.org/jira/browse/AMBARI-22209
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix quick links in mpacks.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 1cad4df 
> 
> 
> Diff: https://reviews.apache.org/r/62895/diff/1/
> 
> 
> Testing
> ---
> 
> will check tests after approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62895/#review187697
---




ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java
Lines 1037 (patched)
<https://reviews.apache.org/r/62895/#comment264743>

Why not set themes itself instead of themeList?



ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java
Lines 1075 (patched)
<https://reviews.apache.org/r/62895/#comment264744>

Why not set quickLinksConfigurations itself?


- Jayush Luniya


On Oct. 11, 2017, 4:17 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62895/
> ---
> 
> (Updated Oct. 11, 2017, 4:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi 
> Radhakrishnan.
> 
> 
> Bugs: AMBARI-22209
> https://issues.apache.org/jira/browse/AMBARI-22209
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix quick links in mpacks.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 1cad4df 
> 
> 
> Diff: https://reviews.apache.org/r/62895/diff/1/
> 
> 
> Testing
> ---
> 
> will check tests after approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/#review187686
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 11, 2017, 8:13 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62802/
> ---
> 
> (Updated Oct. 11, 2017, 8:13 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Following done as part of this JIRA:**
> 
> - Move all non-stack specific configs in **cluster-env.xml** to 
> **cluster-settings.xml**.
> - For example **cluster-env/security_enabled** is a cluster setting and 
> shouldn't be associated with any **stack/mpack**. 
> {code}
>   
> security_enabled
> false
> Hadoop Security
> 
>   
> {code}
> 
> - Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml** 
> which includes all the read only cluster specific settings.
> 
> 
> - **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings
> 
> 
> **Followup work :**
> 
> - **AMBARI-22197** takes care of removing **cluster-env.xml** and associated 
> code and API once we have **AMBARI-22198** completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/PropertyNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  7431f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootClusterSettingsResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  fd15105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  67d3a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  f2c4c52 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  c56483d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
>  fb31c19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
>  ea67207 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
>  d33b5cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  0c5a579 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootClusterSettingsResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  f8feef2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
>  6f5b0f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
>  819507b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  a364c4c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 63c850e 
>   ambari-server/src/main/resources/cluster-settings.xml PRE-

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

[Jayush Luniya]

> On Oct. 11, 2017, 4:42 p.m., Madhuvanthi Radhakrishnan wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootClusterSettingsResourceProvider.java
> > Lines 95 (patched)
> > <https://reviews.apache.org/r/62802/diff/3/?file=1852339#file1852339line95>
> >
> > Hi @Jayush,
> > Should it be getResourcesAuthorized?

No getResources is fine since this is a read-only API. The 
clusters//settings should be authorized.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/#review187664
---


On Oct. 11, 2017, 8:13 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62802/
> ---
> 
> (Updated Oct. 11, 2017, 8:13 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Following done as part of this JIRA:**
> 
> - Move all non-stack specific configs in **cluster-env.xml** to 
> **cluster-settings.xml**.
> - For example **cluster-env/security_enabled** is a cluster setting and 
> shouldn't be associated with any **stack/mpack**. 
> {code}
>   
> security_enabled
> false
> Hadoop Security
> 
>   
> {code}
> 
> - Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml** 
> which includes all the read only cluster specific settings.
> 
> 
> - **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings
> 
> 
> **Followup work :**
> 
> - **AMBARI-22197** takes care of removing **cluster-env.xml** and associated 
> code and API once we have **AMBARI-22198** completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/PropertyNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  7431f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootClusterSettingsResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  fd15105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  67d3a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  f2c4c52 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  c56483d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
>  fb31c19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
>  ea67207 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
>  d33b5cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  0c5a579 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootClusterSettingsResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  f8feef2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
>  6f5b0f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
>  819507b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  a364c4c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLe

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/#review187631
---




ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
Lines 25 (patched)
<https://reviews.apache.org/r/62802/#comment264674>

RootClusterSettingsResourceDefinition



ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceLevelClusterSettingRequest.java
Lines 22 (patched)
<https://reviews.apache.org/r/62802/#comment264675>

RootClusterSettingRequest?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
Line 31 (original)
<https://reviews.apache.org/r/62802/#comment264676>

Why do we need to remove StackConfigurationResponse()?



ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
Lines 78 (patched)
<https://reviews.apache.org/r/62802/#comment264677>

    RootClusterSetting


- Jayush Luniya


On Oct. 11, 2017, 5:27 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62802/
> ---
> 
> (Updated Oct. 11, 2017, 5:27 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Following done as part of this JIRA:**
> 
> - Move all non-stack specific configs in **cluster-env.xml** to 
> **cluster-settings.xml**.
> - For example **cluster-env/security_enabled** is a cluster setting and 
> shouldn't be associated with any **stack/mpack**. 
> {code}
>   
> security_enabled
> false
> Hadoop Security
> 
>   
> {code}
> 
> - Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml** 
> which includes all the read only cluster specific settings.
> 
> 
> - **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings
> 
> 
> **Followup work :**
> 
> - **AMBARI-22197** takes care of removing **cluster-env.xml** and associated 
> code and API once we have **AMBARI-22198** completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ConfigurationNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  7431f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  fd15105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  67d3a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  f2c4c52 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  c56483d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceLevelClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
>  fb31c19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
>  ea67207 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
>  d33b5cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  0c5a579 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  f8feef2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackCon

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/#review187629
---




ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
Lines 777 (patched)
<https://reviews.apache.org/r/62802/#comment264669>

PropertyNotFoundException instead?



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
Lines 778 (patched)
<https://reviews.apache.org/r/62802/#comment264671>

Remove cluster-settings.xml hardcodings. Use constant instead.



ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
Lines 53 (patched)
<https://reviews.apache.org/r/62802/#comment264672>

Rename to RootClusterSettingService()? 

Lets reserve ClusterSettingService for 
api/v1/clusters//settings



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
Lines 1 (patched)
<https://reviews.apache.org/r/62802/#comment264673>

Rename to RootClusterSettingsResourceProvider?


- Jayush Luniya


On Oct. 11, 2017, 5:27 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62802/
> ---
> 
> (Updated Oct. 11, 2017, 5:27 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Following done as part of this JIRA:**
> 
> - Move all non-stack specific configs in **cluster-env.xml** to 
> **cluster-settings.xml**.
> - For example **cluster-env/security_enabled** is a cluster setting and 
> shouldn't be associated with any **stack/mpack**. 
> {code}
>   
> security_enabled
> false
> Hadoop Security
> 
>   
> {code}
> 
> - Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml** 
> which includes all the read only cluster specific settings.
> 
> 
> - **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings
> 
> 
> **Followup work :**
> 
> - **AMBARI-22197** takes care of removing **cluster-env.xml** and associated 
> code and API once we have **AMBARI-22198** completed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ConfigurationNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  7431f9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  fd15105 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  67d3a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  f2c4c52 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  c56483d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceLevelClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
>  fb31c19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
>  ea67207 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
>  d33b5cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  0c5a579 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  f8feef2

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

[Jayush Luniya]

> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
> > Line 248 (original), 246 (patched)
> > <https://reviews.apache.org/r/62856/diff/1/?file=1850073#file1850073line248>
> >
> > Should now be getName() instead of getServiceDisplayName() since we 
> > updated the semantics to (service_name, service_type)
> 
> Nate Cole wrote:
> What is this (service_name, service_type) you speak of?  I would hope 
> we're keeping display (ZooKeeper) vs name (ZOOKEEPER).  Are you saying 
> there's yet a 3rd service identifier?  metainfo.xml already has a  
> element, and that's for things like HCFS (Hadoop Compliant File System) - 
> what is that going to be called in this new world?
> 
> Jayush Luniya wrote:
> @Nate
> service_name = ZK1, service_type = ZOOKEEPER for creating multiple 
> instances. The service display name remains ZooKeeper in the stack 
> definition. From UI perspective we have to see how we display this. Jaimin 
> suggested displaying this as "ZooKeeper" for the default instance and 
> "ZooKeeper (ZK1)" for 2nd instance and above.
> 
> The service type in service definition will be termed service category.
> 
> Nate Cole wrote:
> @Jayush,
> 
> That seems overly complicated.  Why not use the service group name, as 
> in:  ():  eg "ZooKeeper (Core)".  You still end 
> up with a trifecta of display, name, service_group_name.  Changing name to 
> NOT be the service name will be extremely confusing to those used to the v1 
> API.

Oh the default is service_name = service_type = ZOOKEEPER so old semantics will 
remain the same.

One of the requirement was to not add limitation that a service group can have 
only a single service instance.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
---


On Oct. 10, 2017, 8:09 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 10, 2017, 8:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 44d76afcd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  6b32d4c75e 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

[Jayush Luniya]

> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
> > Line 248 (original), 246 (patched)
> > <https://reviews.apache.org/r/62856/diff/1/?file=1850073#file1850073line248>
> >
> > Should now be getName() instead of getServiceDisplayName() since we 
> > updated the semantics to (service_name, service_type)
> 
> Nate Cole wrote:
> What is this (service_name, service_type) you speak of?  I would hope 
> we're keeping display (ZooKeeper) vs name (ZOOKEEPER).  Are you saying 
> there's yet a 3rd service identifier?  metainfo.xml already has a  
> element, and that's for things like HCFS (Hadoop Compliant File System) - 
> what is that going to be called in this new world?

@Nate
service_name = ZK1, service_type = ZOOKEEPER for creating multiple instances. 
The service display name remains ZooKeeper in the stack definition. From UI 
perspective we have to see how we display this. Jaimin suggested displaying 
this as "ZooKeeper" for the default instance and "ZooKeeper (ZK1)" for 2nd 
instance and above.

The service type in service definition will be termed service category.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
---


On Oct. 10, 2017, 4:58 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> -------
> 
> (Updated Oct. 10, 2017, 4:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e9fa8db0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  ec4d383dee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 44d76afcd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  6b32d4c75e 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187229
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 5, 2017, 2:22 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Oct. 5, 2017, 2:22 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 5307176 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 2dc1738 
>   
> ambari-server/src/test/python/common-services/AMBARI_METRICS/test_service_advisor.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 65b23b0 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> d6b572e 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/4/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187159
---




ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py
Line 2318 (original)
<https://reviews.apache.org/r/62756/#comment264066>

Can't we move the test code to 
ambari-server/src/test/python/common-services/AMBARI_METRICS/test_service_advisor.py?

See 
https://github.com/apache/ambari/blob/trunk/ambari-server/src/test/python/common-services/LOGSEARCH/test_service_advisor.py


- Jayush Luniya


On Oct. 4, 2017, 9:03 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Oct. 4, 2017, 9:03 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 5307176 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 2dc1738 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 65b23b0 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> d6b572e 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Jayush Luniya]

> On Oct. 4, 2017, 12:54 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
> > Lines 21 (patched)
> > <https://reviews.apache.org/r/62756/diff/1/?file=1845302#file1845302line21>
> >
> > Can we also remove the duplicate code in HDP stack advisors?
> 
> Vitalyi Brodetskyi wrote:
> Which code i should remove? If you are talking about all AMS methods 
> (recommendations and validations), i don't think we can remove them. As of 
> now, only HDP 3.0 work with service advisors, all other stacks work with 
> stack advisor.

No support for service advisor was add a while back. We already have LOGSEARCH, 
AMBARI_INFRA, NIFI that define service advisors. 

See 
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/service_advisor.py

The default stack advisor has installation hooks to call individual service 
advisors
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/stack_advisor.py#L765

Can you try and see?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187037
---


On Oct. 4, 2017, 8:26 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Oct. 4, 2017, 8:26 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187037
---




ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
Lines 21 (patched)
<https://reviews.apache.org/r/62756/#comment263992>

Can we also remove the duplicate code in HDP stack advisors?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
Lines 466 (patched)
<https://reviews.apache.org/r/62756/#comment263991>

Fix Typo "AMS Validator" instead of "Storm Validator"


- Jayush Luniya


On Oct. 3, 2017, 7:48 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Oct. 3, 2017, 7:48 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review187036
---




ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
Line 77 (original), 77 (patched)
<https://reviews.apache.org/r/62756/#comment263990>

Is this change to ATLAS service advisor supposed to be part of the patch?


- Jayush Luniya


On Oct. 3, 2017, 7:48 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62756/
> ---
> 
> (Updated Oct. 3, 2017, 7:48 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi 
> Radhakrishnan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22124
> https://issues.apache.org/jira/browse/AMBARI-22124
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need to move AMS specific logic in the stack advisors to service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py
>  a2e31cc 
> 
> 
> Diff: https://reviews.apache.org/r/62756/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62712: AMBARI-22102 Ranger KMS should add proxy user for Spark2 user

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62712/#review186880
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 30, 2017, 9:58 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62712/
> ---
> 
> (Updated Sept. 30, 2017, 9:58 a.m.)
> 
> 
> Review request for Ambari, Bikas Saha, Gautam Borad, Jayush Luniya, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-22102
> https://issues.apache.org/jira/browse/AMBARI-22102
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2 user needs to be added to Ranger KMS proxy users in cluster.
> 
> Updating required_services list with SPARK2 config livy2_user/livy2-env to 
> recommendKMSProxyUsers()
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> be615db 
> 
> 
> Diff: https://reviews.apache.org/r/62712/diff/1/
> 
> 
> Testing
> ---
> 
> Unit Test passed.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/#review186854
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 30, 2017, 5:31 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62699/
> ---
> 
> (Updated Sept. 30, 2017, 5:31 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22100
> https://issues.apache.org/jira/browse/AMBARI-22100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change temp directory for jceks file from service level to component level.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8a433c83f4 
> 
> 
> Diff: https://reviews.apache.org/r/62699/diff/3/
> 
> 
> Testing
> ---
> 
> Ambari-2.6
> HDP-2.6.0.0
> Deploy Hive
> Deploy Oozie
> 
> [root@storm-simple-patch-madhu-2 conf]# pwd
> /var/lib/ambari-agent/cred/conf
> [root@storm-simple-patch-madhu-2 conf]# ls
> hive_metastore  hive_server  mysql_server  oozie_client  oozie_server
> 
> Run service checks
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/#review186778
---




ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py
Lines 284 (patched)
<https://reviews.apache.org/r/62699/#comment263612>

Need to check if 'role' is in commandJson first.

if 'role' in commandJson:
  roleName = commandJson['role']
  file_path = os.path.join(self.getProviderDirectory(roleName), 
"{0}.jceks".format(config_type))


- Jayush Luniya


On Sept. 30, 2017, 5:03 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62699/
> ---
> 
> (Updated Sept. 30, 2017, 5:03 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22100
> https://issues.apache.org/jira/browse/AMBARI-22100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change temp directory for jceks file from service level to component level.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8a433c83f4 
> 
> 
> Diff: https://reviews.apache.org/r/62699/diff/2/
> 
> 
> Testing
> ---
> 
> Ambari-2.6
> HDP-2.6.0.0
> Deploy Hive
> Deploy Oozie
> 
> [root@storm-simple-patch-madhu-2 conf]# pwd
> /var/lib/ambari-agent/cred/conf
> [root@storm-simple-patch-madhu-2 conf]# ls
> hive_metastore  hive_server  mysql_server  oozie_client  oozie_server
> 
> Run service checks
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/#review186753
---




ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py
Line 284 (original), 284 (patched)
<https://reviews.apache.org/r/62699/#comment263554>

Will role ever be null? I am thinking about service checks etc. Might want 
to add service_name as fall back just in case.


- Jayush Luniya


On Sept. 29, 2017, 10:14 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62699/
> ---
> 
> (Updated Sept. 29, 2017, 10:14 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22100
> https://issues.apache.org/jira/browse/AMBARI-22100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change temp directory for jceks file from service level to component level.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8a433c83f4 
> 
> 
> Diff: https://reviews.apache.org/r/62699/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62599: Remove user to group hardcoded logic in hooks

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62599/#review186529
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 27, 2017, 9:52 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62599/
> ---
> 
> (Updated Sept. 27, 2017, 9:52 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22068
> https://issues.apache.org/jira/browse/AMBARI-22068
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We added feature to tag a user property with corresponding user-group 
> properties to which a user should be added. We no longer should need the 
> hardcoded logic in the hooks adding users to groups. This can be entirely 
> stack driven after we update the user config properties for all services.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
>  e4aa21e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  52a5e6a 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4d33661 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
>  74d8600 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml
>  f97ca98 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  23b82e3 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  f45199f 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml
>  ccbda1e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
>  6393659 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
>  733ca8b 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  bb671cc 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  e292e6e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  b2c364c 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  54a62e2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml
>  90ba1c8 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  ad81d66 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
>  680e81f 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml
>  e1ca45a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  e861b6e 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml
>  b2d60c6 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
>  7748176 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-env.xml
>  0f67356 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
>  cc62c8b 
>   
> ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/configuration/ranger-env.xml
>  ff44901 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml
>  e5c0673 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/configuration/kms-env.xml
>  acecdfe 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  55d67cc 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/livy-env.xml
>  cec8054 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/spark-env.xml
>  f980f9a 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  35d364f 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml
>  d9d548d 

Re: Review Request 62599: Remove user to group hardcoded logic in hooks

[Jayush Luniya]

> On Sept. 27, 2017, 12:20 a.m., Madhuvanthi Radhakrishnan wrote:
> > Hi Vitaly,
> > Kindly refer https://reviews.apache.org/r/56727/ to check the value of 
> > user_groups attribute. 
> > For eg:
> > /resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
> > 
> > zeppelin_user
> > zeppelin
> > USER
> > User zeppelin daemon runs as
> > 
> > user
> > false
> > 
> > 
> > zeppelin-env
> > zeppelin_group
> > 
> > 
> > hadoop-env
> > proxyuser_group
> > 
> > 
> > 
> > 
> > 
> > 
> > Here, the user-group tag is able to tell the mapping between 
> > (zeppelin_group property in zeppellin-env file and proxyuser_group property 
> > in hadoop-env file) with the zeppelin_user. 
> > You can follow a similar pattern for the other services.
> > Thanks for doing this.

@Madhu
I think we renamed  to  in the final patch. Can you 
confirm?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62599/#review186348
---


On Sept. 26, 2017, 11:23 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62599/
> ---
> 
> (Updated Sept. 26, 2017, 11:23 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22068
> https://issues.apache.org/jira/browse/AMBARI-22068
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We added feature to tag a user property with corresponding user-group 
> properties to which a user should be added. We no longer should need the 
> hardcoded logic in the hooks adding users to groups. This can be entirely 
> stack driven after we update the user config properties for all services.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
>  e4aa21e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  52a5e6a 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4d33661 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
>  74d8600 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml
>  f97ca98 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  23b82e3 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  f45199f 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml
>  ccbda1e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
>  6393659 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
>  733ca8b 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  bb671cc 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  e292e6e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  b2c364c 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  54a62e2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml
>  90ba1c8 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  ad81d66 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
>  680e81f 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml
>  e1ca45a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  e861b6e 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml
>  b2d60c6 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
>  7748176 
>

Re: Review Request 62599: Remove user to group hardcoded logic in hooks

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62599/#review186408
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
Line 246 (original)
<https://reviews.apache.org/r/62599/#comment262973>

Lets also fix the Ganglia configs.


- Jayush Luniya


On Sept. 26, 2017, 11:23 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62599/
> ---
> 
> (Updated Sept. 26, 2017, 11:23 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22068
> https://issues.apache.org/jira/browse/AMBARI-22068
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We added feature to tag a user property with corresponding user-group 
> properties to which a user should be added. We no longer should need the 
> hardcoded logic in the hooks adding users to groups. This can be entirely 
> stack driven after we update the user config properties for all services.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
>  e4aa21e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  52a5e6a 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4d33661 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
>  74d8600 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml
>  f97ca98 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  23b82e3 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  f45199f 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml
>  ccbda1e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
>  6393659 
>   
> ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml
>  733ca8b 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  bb671cc 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  e292e6e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  b2c364c 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  54a62e2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml
>  90ba1c8 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  ad81d66 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
>  680e81f 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml
>  e1ca45a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  e861b6e 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml
>  b2d60c6 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
>  7748176 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-env.xml
>  0f67356 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
>  cc62c8b 
>   
> ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/configuration/ranger-env.xml
>  ff44901 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml
>  e5c0673 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/configuration/kms-env.xml
>  acecdfe 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  55d67cc 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/livy-env.xml
>  cec8054 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/spark-env.xml
>  f980f9a 
>   
> ambari-server/src/main/resour

Re: Review Request 62364: Set tez.runtime.shuffle.ssl.enable=false in Ambari for HSI

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62364/#review185522
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 16, 2017, 12:45 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62364/
> ---
> 
> (Updated Sept. 16, 2017, 12:45 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jayush Luniya, Swapan Shridhar, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-21973
> https://issues.apache.org/jira/browse/AMBARI-21973
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add tez.runtime.shuffle.ssl.enable=false to tez-interactive-site.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
>  c1a42b0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 75a8782 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  07bc8a4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  850f725 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 9a42098 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> ea58559 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> c67e4cf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  b49fdbf 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> af885e1 
> 
> 
> Diff: https://reviews.apache.org/r/62364/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review185458
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 14, 2017, 10:47 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61994/
> ---
> 
> (Updated Sept. 14, 2017, 10:47 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21856
> https://issues.apache.org/jira/browse/AMBARI-21856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that Ambari is using the reponame name field as the 
> distribution when it creates the repo definition file. Since both of these 
> repos use same distribution (which is a common Debian pattern), they collide.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  32b8038 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  858a55f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  c78d88d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  0735e27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  88ece8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  e81d1af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  bad8195 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> d43bdfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  854f03f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
>  5e1d5d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  17ded10 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  8427a1d 
>   ambari-server/src/main/resources/custom_actions/scripts/update_repo.py 
> 9f2107d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  058c45b 
>   ambari-server/src/main/resources/version_definition.xsd 832d7f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
>  18e2d3f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
> 
> 
> Diff: https://reviews.apache.org/r/61994/diff/4/
> 
> 
> Testing
> ---
> 
> test will be fixed after solution will be approved
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review185437
---




ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
Lines 126 (patched)
<https://reviews.apache.org/r/61994/#comment261744>

Can we make this as components instead of single component. We can consider 
components to be a comma separated list. Some debian repos also have multiple 
components although I don't think its commonly used. But just incase someone 
has a special case we don't have to revisit this.

https://wiki.debian.org/SourcesList

deb  http://deb.debian.org/debian stretch main contrib non-free
deb-src  http://deb.debian.org/debian stretch main contrib non-free

deb  http://deb.debian.org/debian stretch-updates main contrib non-free
deb-src  http://deb.debian.org/debian stretch-updates main contrib non-free

deb http://security.debian.org/ stretch/updates main contrib non-free
deb-src http://security.debian.org/ stretch/updates main contrib non-free


- Jayush Luniya


On Sept. 13, 2017, 5:37 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61994/
> ---
> 
> (Updated Sept. 13, 2017, 5:37 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21856
> https://issues.apache.org/jira/browse/AMBARI-21856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that Ambari is using the reponame name field as the 
> distribution when it creates the repo definition file. Since both of these 
> repos use same distribution (which is a common Debian pattern), they collide.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  32b8038 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  858a55f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  c78d88d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  0735e27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  88ece8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  bad8195 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> d43bdfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  854f03f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
>  5e1d5d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  17ded10 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  8427a1d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  058c45b 
>   ambari-server/src/main/resources/version_definition.xsd 832d7f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
>  18e2d3f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
> 
> 
> Diff: https://reviews.apache.org/r/61994/diff/3/
> 
> 
> Testing
> ---
> 
> test will be fixed after solution will be approved
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62250: AMBARI-21939 : Ambari HDFS Heatmaps are not showing data (Not Applicable) for bytes read, bytes written & DataNode Process Network I/O Utilization

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62250/#review185250
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 12, 2017, 4:58 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62250/
> ---
> 
> (Updated Sept. 12, 2017, 4:58 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21939
> https://issues.apache.org/jira/browse/AMBARI-21939
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM: HDFS Heatmaps are not showing data (Not Applicable) for bytes read, 
> bytes written & DataNode Process Network I/O Utilization
> 
> EXPECTED BEHAVIOUR: Heatmaps should show data
> 
> ACTUAL BEHAVIOUR: Data is being shown as Not Applicable (Grey Box)
> 
> ANALYSIS
> This is reproducible in Ambari 2.2.2 and Ambari 2.5.1.0. If you go to HDFS, 
> then click on Heatmaps, you can see the API call go to
> fields=host_components/metrics/dfs/datanode/bytes_written._rate 
> however this returns no values. If you remove ._rate then you can see the 
> values which you would expect.
> Attach one or more files to this issue
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  9e145c0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> bcfb2cc 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> eeb9ff8 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEHDFS/widgets.json
>  7a793f8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  db6ebc1 
> 
> 
> Diff: https://reviews.apache.org/r/62250/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> UpgradeCatalog260 test added.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 62249: Do not export YARN_CONF_DIR in 'yarn-env.sh' file

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62249/#review185211
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 12, 2017, 4:47 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62249/
> ---
> 
> (Updated Sept. 12, 2017, 4:47 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-21936
> https://issues.apache.org/jira/browse/AMBARI-21936
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> yarn-env.sh exports YARN_CONF_DIR 
> {code:title=yarn-env.sh}
># resolve links - $0 may be a softlink
>   export YARN_CONF_DIR="${YARN_CONF_DIR:-$HADOOP_YARN_HOME/conf}"
> {code}
> 
> This causes in not respecting --config option for yarn daemon.
> Hence please remove the export
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml
>  aaa72d1 
> 
> 
> Diff: https://reviews.apache.org/r/62249/diff/2/
> 
> 
> Testing
> ---
> 
> TODO
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62224: NullPointerException during blueprint generation

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62224/#review185126
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 11, 2017, 10:16 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62224/
> ---
> 
> (Updated Sept. 11, 2017, 10:16 p.m.)
> 
> 
> Review request for Ambari, Amarnath reddy pappu, Jayush Luniya, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-21865
> https://issues.apache.org/jira/browse/AMBARI-21865
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In an Namenode HA environment, export Blueprint throws NPE/Server Error for 
> some missing configurations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  b4e102737f 
> 
> 
> Diff: https://reviews.apache.org/r/62224/diff/2/
> 
> 
> Testing
> ---
> 
> Installed Ambari-2.4.3 HDP-2.5.3.0.
> 
> Added the properties to "Custom hdfs-site"
> dfs.nameservices=nonha,hacluster
> dfs.namenode.rpc-address.nonha=host-1.openstacklocal:8020
> dfs.ha.namenodes.hacluster=nn1,nn2
> dfs.namenode.rpc-address.hacluster.nn2=host-2.openstacklocal:8020
> dfs.namenode.rpc-address.hacluster.nn1=host-tt-3.openstacklocal:8020
> dfs.namenode.http-address.nonha=host-tt-1.openstacklocal:50070
> dfs.client.failover.proxy.provider.hacluster=org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider
> dfs.nameservices.internal=nonha
> 
> Added the fix/null-check and then exported the blueprint which was successful.
> Some properties will not be exported.
> Here is a snippet of the blueprint hdfs-site section
> "dfs.namenode.rpc-address.hacluster.nn2": "%HOSTGROUP::host_group_2%:8020",
> "dfs.namenode.rpc-address.hacluster.nn1": "%HOSTGROUP::host_group_3%:8020",
> "dfs.nameservices": "nonha,hacluster",
> "dfs.namenode.http-address.nonha": "host-1.openstacklocal:50070",
> "dfs.nameservices.internal": "nonha",
> "dfs.namenode.rpc-address": "%HOSTGROUP::host_group_1%:8020",
> "dfs.namenode.https-address": "%HOSTGROUP::host_group_1%:50470",
> "dfs.namenode.rpc-address.nonha": "host-1.openstacklocal:8020",
> "dfs.http.policy": "HTTP_ONLY",
> "dfs.client.failover.proxy.provider.hacluster": 
> "org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider",
> "dfs.namenode.http-address": "%HOSTGROUP::host_group_1%:50070",
> "dfs.datanode.https.address": "0.0.0.0:50475",
> "dfs.ha.namenodes.hacluster": "nn1,nn2",
> "dfs.namenode.secondary.http-address": "%HOSTGROUP::host_group_2%:50090",
> "dfs.datanode.http.address": "0.0.0.0:50075"
> 
> As you see because dfs.ha.namenodes.nonha does not exist, there will not be 
> any properties like dfs.namenode.rpc-address.nonha.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62224: NullPointerException during blueprint generation

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62224/#review185119
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Line 1044 (original), 1045 (patched)
<https://reviews.apache.org/r/62224/#comment261347>

Why not add the null check in splitAndTrimStrings? splitAndTrimStrings() is 
used in other places too that dont have null checks.


- Jayush Luniya


On Sept. 11, 2017, 5:51 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62224/
> ---
> 
> (Updated Sept. 11, 2017, 5:51 p.m.)
> 
> 
> Review request for Ambari, Amarnath reddy pappu, Jayush Luniya, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-21865
> https://issues.apache.org/jira/browse/AMBARI-21865
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In an Namenode HA environment, export Blueprint throws NPE/Server Error for 
> some missing configurations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  b4e102737f 
> 
> 
> Diff: https://reviews.apache.org/r/62224/diff/1/
> 
> 
> Testing
> ---
> 
> Installed Ambari-2.4.3 HDP-2.5.3.0.
> 
> Added the properties to "Custom hdfs-site"
> dfs.nameservices=nonha,hacluster
> dfs.namenode.rpc-address.nonha=host-1.openstacklocal:8020
> dfs.ha.namenodes.hacluster=nn1,nn2
> dfs.namenode.rpc-address.hacluster.nn2=host-2.openstacklocal:8020
> dfs.namenode.rpc-address.hacluster.nn1=host-tt-3.openstacklocal:8020
> dfs.namenode.http-address.nonha=host-tt-1.openstacklocal:50070
> dfs.client.failover.proxy.provider.hacluster=org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider
> dfs.nameservices.internal=nonha
> 
> Added the fix/null-check and then exported the blueprint which was successful.
> Some properties will not be exported.
> Here is a snippet of the blueprint hdfs-site section
> "dfs.namenode.rpc-address.hacluster.nn2": "%HOSTGROUP::host_group_2%:8020",
> "dfs.namenode.rpc-address.hacluster.nn1": "%HOSTGROUP::host_group_3%:8020",
> "dfs.nameservices": "nonha,hacluster",
> "dfs.namenode.http-address.nonha": "host-1.openstacklocal:50070",
> "dfs.nameservices.internal": "nonha",
> "dfs.namenode.rpc-address": "%HOSTGROUP::host_group_1%:8020",
> "dfs.namenode.https-address": "%HOSTGROUP::host_group_1%:50470",
> "dfs.namenode.rpc-address.nonha": "host-1.openstacklocal:8020",
> "dfs.http.policy": "HTTP_ONLY",
> "dfs.client.failover.proxy.provider.hacluster": 
> "org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider",
> "dfs.namenode.http-address": "%HOSTGROUP::host_group_1%:50070",
> "dfs.datanode.https.address": "0.0.0.0:50475",
> "dfs.ha.namenodes.hacluster": "nn1,nn2",
> "dfs.namenode.secondary.http-address": "%HOSTGROUP::host_group_2%:50090",
> "dfs.datanode.http.address": "0.0.0.0:50075"
> 
> As you see because dfs.ha.namenodes.nonha does not exist, there will not be 
> any properties like dfs.namenode.rpc-address.nonha.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

[Jayush Luniya]

> On Sept. 7, 2017, 8:55 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml
> > Lines 95 (patched)
> > <https://reviews.apache.org/r/61994/diff/2/?file=1817744#file1817744line95>
> >
> > We dont need to change it for HDP. For HDP the distribution should 
> > remain HDP. 
> > i.e. 
> > deb http://public-repo-1/ HDP main
> > 
> > KIBANA service in Metron mpack requires setting distribution=stable.
> > 
> > "distribution" should be an optional parameter.
> 
> Vitalyi Brodetskyi wrote:
> sure, i understand this. This patch is draft, to show for reviewers and 
> get some notes.

Got it, thanks for the clarification.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review184878
---


On Sept. 7, 2017, 8:40 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61994/
> -------
> 
> (Updated Sept. 7, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21856
> https://issues.apache.org/jira/browse/AMBARI-21856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that Ambari is using the reponame name field as the 
> distribution when it creates the repo definition file. Since both of these 
> repos use same distribution (which is a common Debian pattern), they collide.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  3d96122 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1a022af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  0735e27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  bad8195 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  854f03f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
>  5e1d5d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  17ded10 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  058c45b 
>   ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
> 
> 
> Diff: https://reviews.apache.org/r/61994/diff/2/
> 
> 
> Testing
> ---
> 
> test will be fixed after solution will be approved
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review184878
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
Line 22 (original), 22 (patched)
<https://reviews.apache.org/r/61994/#comment261080>

_UBUNTU_REPO_COMPONENTS_POSTFIX is hardcoded to "main" but it is possible 
that some debian repo for a custom service uses a different component name

For example:
deb http://url mydistro mycomponent

We should see if we can parameterize component names as well (default being 
"main" if it is not defined).



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
Line 48 (original), 48 (patched)
<https://reviews.apache.org/r/61994/#comment261078>

If repo['distribution'] is not defined then we should use repo['repoName'] 
as the distrbution. This will maintain compatibility for HDP deployments



ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml
Lines 95 (patched)
<https://reviews.apache.org/r/61994/#comment261076>

We dont need to change it for HDP. For HDP the distribution should remain 
HDP. 
i.e. 
deb http://public-repo-1/ HDP main

KIBANA service in Metron mpack requires setting distribution=stable.

"distribution" should be an optional parameter.


- Jayush Luniya


On Sept. 7, 2017, 8:40 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61994/
> ---
> 
> (Updated Sept. 7, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21856
> https://issues.apache.org/jira/browse/AMBARI-21856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The problem is that Ambari is using the reponame name field as the 
> distribution when it creates the repo definition file. Since both of these 
> repos use same distribution (which is a common Debian pattern), they collide.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  3d96122 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1a022af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  0735e27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  bad8195 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  854f03f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java
>  5e1d5d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  17ded10 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  058c45b 
>   ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  3a7b19b 
> 
> 
> Diff: https://reviews.apache.org/r/61994/diff/2/
> 
> 
> Testing
> ---
> 
> test will be fixed after solution will be approved
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61917/#review184091
---


Ship it!




Ship It!

- Jayush Luniya


On Aug. 29, 2017, 7:37 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61917/
> ---
> 
> (Updated Aug. 29, 2017, 7:37 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21824
> https://issues.apache.org/jira/browse/AMBARI-21824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ServiceGroup was a new sub-resource added for cluster in AMBARI-21594.
> 
> This Task involves :
> - moving *Services* which was earlier a sub-resource of *Cluster* under 
> *ServiceGroup* now, and
> -  using *Servicegroup* while doing Creation, Update and retrieval of 
> *HostComponents* and *ServiceComponents*.
> -  UI changes which includes creating a *default ServiceGroup named 'core'*, 
> and all services created goes under it. Further, making UI calls SG aware, 
> while making a call.
> 
> The new API calls will be the following:
> 
> 
> ---
> **==**
> **Service:**
> **==**
> 
> New API calls: 
> 
> http://:/api/v1/clusters//*servicegroups/*/services
> http://:/api/v1/clusters//*servicegroups/*/services/
> 
> **POST**
> 
> Eg: 
> http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services
> 
> Request
> 
> {code}
> {
>   "ServiceInfo" : {
> "cluster_name": "c1",
> "service_group_name": "core",
> "service_name": "RANGER",
> "service_display_name": "RANGER"
>   }
> }
> {code}
> 
> Response
> 
> {code}
> {
>   "resources" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER;,
>   "ServiceInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "credential_store_enabled" : false,
> "credential_store_supported" : false,
> "desired_repository_version_id" : "2.6.1.0-129",
> "desired_stack" : "HDP-2.6",
> "maintenance_state" : "OFF",
> "repository_state" : "NOT_REQUIRED",
> "service_display_name" : "RANGER",
> "service_group_id" : 2,
> "service_group_name" : "core",
> "service_id" : 4,
> "service_name" : "RANGER",
> "state" : "INIT"
>   }
> }
>   ]
> }
> {code}
> 
> 
> **GET**
> 
> Eg: 
> http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services
> 
> Request
> 
> {code}
> {code}
> 
> Response
> 
> {code}
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services;,
>   "items" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER;,
>   "ServiceInfo" : {
> "cluster_name" : "c1",
> "service_display_name" : "RANGER",
> "service_group_name" : "core"
>   }
> }
>   ]
> }
> {code}
> 
> Eg: 
> http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER
> 
> Request
> 
> {code}
> {code}
> 
> Response
> 
> {code}
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/core/services/RANGER;,
>   "ServiceInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "credential_store_enabled" : "false",
> "credential_store_supported" : "false",
> "desired_repository_version_id" : 1,
> "desired_stack" : {
>   "stackName" : "HDP",
>   "s

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61917/#review184047
---


Ship it!




Ship It!

- Jayush Luniya


On Aug. 28, 2017, 9:08 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61917/
> ---
> 
> (Updated Aug. 28, 2017, 9:08 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21824
> https://issues.apache.org/jira/browse/AMBARI-21824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ServiceGroup was a new sub-resource added for cluster in AMBARI-21594.
> 
> This change involves :
> - moving **Services** which was earlier a sub-resource of **Cluster** under 
> **ServiceGroup** now, and
> - using **Servicegroup** while doing Creation, Update and retrieval of 
> **HostComponents** and **ServiceComponents**.
> 
> The new API calls will be the following:
> 
> 
> -
> **Service:**
> 
> http://:/api/v1/clusters//**servicegroups/**/services
> http://:/api/v1/clusters//**servicegroups/**/services/
> 
> **ServiceComponent:**
> 
> http://:/api/v1/clusters//**servicegroups/**/services//components/
> http://:/api/v1/clusters//**servicegroups/**/services//components/ZOOKEEPER_SERVER
> 
> -
> 
> **HostComponent:** (API remains same, but has notion of servicegroup in 
> Ambari backend)
> 
> http://:/api/v1/clusters/c1/hosts//host_components/
> http://:/api/v1/clusters/c1/hosts//host_components/
> 
> 
> - The change also includes UI changes as well, which create a **default 
> ServiceGroup named 'core'**, and all services created goes under it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ServiceComponentNotFoundException.java
>  8f25cb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ServiceNotFoundException.java
>  6b18c09 
>   
> ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
>  03990a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  d83a5d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> e8c0b05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  24c2810 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentResourceDefinition.java
>  2a98a9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
>  f686851 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  80bd58d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  c38489d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  b489a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  aa1270a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  6ab2704 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  988fc78 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  b440c93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  543df26 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  6b03249 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  663d857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  ca84826 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java
>  3f75971 
>   
> a

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61917/#review184003
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Line 3555 (original), 3559 (patched)
<https://reviews.apache.org/r/61917/#comment260026>

Rename to findService?


- Jayush Luniya


On Aug. 28, 2017, 9:08 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61917/
> ---
> 
> (Updated Aug. 28, 2017, 9:08 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21824
> https://issues.apache.org/jira/browse/AMBARI-21824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ServiceGroup was a new sub-resource added for cluster in AMBARI-21594.
> 
> This change involves :
> - moving **Services** which was earlier a sub-resource of **Cluster** under 
> **ServiceGroup** now, and
> - using **Servicegroup** while doing Creation, Update and retrieval of 
> **HostComponents** and **ServiceComponents**.
> 
> The new API calls will be the following:
> 
> 
> -
> **Service:**
> 
> http://:/api/v1/clusters//**servicegroups/**/services
> http://:/api/v1/clusters//**servicegroups/**/services/
> 
> **ServiceComponent:**
> 
> http://:/api/v1/clusters//**servicegroups/**/services//components/
> http://:/api/v1/clusters//**servicegroups/**/services//components/ZOOKEEPER_SERVER
> 
> -
> 
> **HostComponent:** (API remains same, but has notion of servicegroup in 
> Ambari backend)
> 
> http://:/api/v1/clusters/c1/hosts//host_components/
> http://:/api/v1/clusters/c1/hosts//host_components/
> 
> 
> - The change also includes UI changes as well, which create a **default 
> ServiceGroup named 'core'**, and all services created goes under it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ServiceComponentNotFoundException.java
>  8f25cb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ServiceNotFoundException.java
>  6b18c09 
>   
> ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
>  03990a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  d83a5d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  2690008 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java 
> e8c0b05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  24c2810 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentResourceDefinition.java
>  2a98a9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
>  f686851 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  80bd58d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  c38489d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  b489a15 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  aa1270a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  6ab2704 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  988fc78 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  b440c93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  543df26 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  6b03249 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  663d857 
>   
> ambari-server/src/main/java/

Re: Review Request 61813: Storm Service should not have ranger 'ranger-admin-site' and 'ranger-ugsync-site' dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61813/#review183622
---



This dependency was added in 
https://issues.apache.org/jira/browse/AMBARI-14202. Removing this dependency 
will cause issues when WE is enabled. We need to improve our overall restart 
required logic but that is a larger improvement to be done. Unfortunatel, for 
now though we will need to keep these dependencies.

- Jayush Luniya


On Aug. 22, 2017, 1:42 p.m., Jay SenSharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61813/
> ---
> 
> (Updated Aug. 22, 2017, 1:42 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Juanjo  Marron, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21779
> https://issues.apache.org/jira/browse/AMBARI-21779
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Storm Service should not include the following ""
> 
> ranger-ugsync-site
> ranger-admin-site
> 
> Else making any configuration change in Ranger service (for example: "Ranger 
> User Info") will ask Storm service to be restarted.
> 
> Looks like as part of JIRA "AMBARI-16250"  this dependency was added in bulk 
> by mistake.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/metainfo.xml 
> 0c62c1a 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/metainfo.xml 
> 1bc23e4 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/metainfo.xml 
> 084eac2 
>   ambari-server/src/main/resources/common-services/STORM/1.1.0/metainfo.xml 
> 94f5ca3 
> 
> 
> Diff: https://reviews.apache.org/r/61813/diff/1/
> 
> 
> Testing
> ---
> 
> .
> 
> 
> Thanks,
> 
> Jay SenSharma
> 
>

Re: Review Request 61709: Ambari should expose whether a service is able to rolling-restart instead of hard coding service name

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61709/#review183449
---


Ship it!




Ship It!

- Jayush Luniya


On Aug. 17, 2017, 7:22 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61709/
> ---
> 
> (Updated Aug. 17, 2017, 7:22 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jayush Luniya, Koji Sekiguchi, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21737
> https://issues.apache.org/jira/browse/AMBARI-21737
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a new property called rollingRestartAllowed to metainfo.xml Existing 
> logic of client components are not removed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
>  0b0a5da2b0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
>  764e394540 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> a8a9a0faef 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/metainfo.xml
>  f408ba38ac 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
> d322adc47b 
>   ambari-server/src/main/resources/properties.json 11ca7f678a 
>   ambari-web/app/mappers/stack_service_mapper.js 8931066f76 
>   ambari-web/app/models/stack_service_component.js eb6f2dbff7 
> 
> 
> Diff: https://reviews.apache.org/r/61709/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:12 min
> [INFO] Finished at: 2017-08-17T00:01:59-07:00
> [INFO] Final Memory: 85M/962M
> [INFO] 
> 
> 
> Install ambari
> Deploy HDP
> Ensure no regression
> Kafka brokers allow rolling restart
> 
> This property can be used for any other services which have components that 
> are not clients but support rolling restart.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

[Jayush Luniya]

> On Aug. 1, 2017, 5:51 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
> > Lines 234 (patched)
> > <https://reviews.apache.org/r/61201/diff/4/?file=1786100#file1786100line234>
> >
> > Shouldn't this be
> > for(ServiceGroupRequest request : requests) {
> >   deleteStatusMetaData.addDeletedKey(request.getClusterName() + "/" + 
> > request.getServiceGroupName());
> > }
> 
> Swapan Shridhar wrote:
> request already has these 2 values only. 
> This is the result with : 'requests.toString()'
> 
> 
> {
>   "deleteResult" : [
> {
>   "deleted" : {
> "key" : "[clusterName=c1, serviceGroupName=CORE]"
>   }
> }
>   ]
> }

what I meant was for bulk delete should it be adding a deleted key for each?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61201/#review181877
---


On July 31, 2017, 9:06 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61201/
> ---
> 
> (Updated July 31, 2017, 9:06 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21594
> https://issues.apache.org/jira/browse/AMBARI-21594
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **ServiceGroup (SG)** : is defined as sub-resource of cluster. It would later 
> be used to logically group a set of services (coming out of Management Pack 
> selected).
>  
> **Example of a Service groups can be a:** 
> - “Core” Service Group  containing HDFS and Zookeeper. This will be formed by 
> default.
> - “Streaming” Service Group containing Kafka, Storm, Nifi.
> - “Data Science” Service Group containing Hive, Spark, Zeppelin.
> - “EDW” Service Group containing Hive, Spark.
> 
> As part of this review, following has been implemented:
> - SG added as sub-resource of cluster.
> - GET, POST and DELETE API for SG.
> 
> 
> 
> *API calls and response:*
> 
> *1.* 
> 
> POST:
> 
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups
> *Body :*
> 
> 
> [
> {
>   "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "CORE"
>   }
> },
> {
>   "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "EDW"
>   }
> }
> ]
> 
> 
> *Response:* 201 CREATED
> 
> 
> {
>   "resources" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
>   }
> },
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 803,
> "service_group_name" : "EDW"
>   }
> }
>   ]
> }
> 
> 
> *2.*
> ===
> GET :
> ===
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/
> 
> *Body:*
> 
> []
> 
> 
> *Response:* 200 OK
> 
> 
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/;,
>   "items" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "CORE"
>   }
> },
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW;,
> 

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61201/#review181877
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
Lines 234 (patched)
<https://reviews.apache.org/r/61201/#comment257665>

Shouldn't this be
for(ServiceGroupRequest request : requests) {
  deleteStatusMetaData.addDeletedKey(request.getClusterName() + "/" + 
request.getServiceGroupName());
    }


- Jayush Luniya


On July 31, 2017, 9:06 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61201/
> ---
> 
> (Updated July 31, 2017, 9:06 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21594
> https://issues.apache.org/jira/browse/AMBARI-21594
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **ServiceGroup (SG)** : is defined as sub-resource of cluster. It would later 
> be used to logically group a set of services (coming out of Management Pack 
> selected).
>  
> **Example of a Service groups can be a:** 
> - “Core” Service Group  containing HDFS and Zookeeper. This will be formed by 
> default.
> - “Streaming” Service Group containing Kafka, Storm, Nifi.
> - “Data Science” Service Group containing Hive, Spark, Zeppelin.
> - “EDW” Service Group containing Hive, Spark.
> 
> As part of this review, following has been implemented:
> - SG added as sub-resource of cluster.
> - GET, POST and DELETE API for SG.
> 
> 
> 
> *API calls and response:*
> 
> *1.* 
> 
> POST:
> 
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups
> *Body :*
> 
> 
> [
> {
>   "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "CORE"
>   }
> },
> {
>   "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "EDW"
>   }
> }
> ]
> 
> 
> *Response:* 201 CREATED
> 
> 
> {
>   "resources" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
>   }
> },
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 803,
> "service_group_name" : "EDW"
>   }
> }
>   ]
> }
> 
> 
> *2.*
> ===
> GET :
> ===
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/
> 
> *Body:*
> 
> []
> 
> 
> *Response:* 200 OK
> 
> 
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/;,
>   "items" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "CORE"
>   }
> },
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW;,
>   "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "EDW"
>   }
> }
>   ]
> }
> 
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
> 
> *Body:*
> 
> []
> 
> 
> *Response:* 200 OK
> 
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61201/#review181709
---




ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntityPK.java
Lines 43 (patched)
<https://reviews.apache.org/r/61201/#comment257342>

service group id instead



ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
Lines 159 (patched)
<https://reviews.apache.org/r/61201/#comment257343>

primary key should be service group id.


- Jayush Luniya


On July 28, 2017, 3:48 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61201/
> ---
> 
> (Updated July 28, 2017, 3:48 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21594
> https://issues.apache.org/jira/browse/AMBARI-21594
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **ServiceGroup (SG)** : is defined as sub-resource of cluster. It would later 
> be used to logically group a set of services (coming out of Management Pack 
> selected).
>  
> **Example of a Service groups can be a:** 
> - “Core” Service Group  containing HDFS and Zookeeper. This will be formed by 
> default.
> - “Streaming” Service Group containing Kafka, Storm, Nifi.
> - “Data Science” Service Group containing Hive, Spark, Zeppelin.
> - “EDW” Service Group containing Hive, Spark.
> 
> As part of this review, following has been implemented:
> - SG added as sub-resource of cluster.
> - GET, POST and DELETE API for SG.
> 
> 
> 
> *API calls and response:*
> 
> *1.* 
> 
> POST:
> 
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups
> *Body :*
> 
> 
> [
> {
>   "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "CORE"
>   }
> },
> {
>   "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "EDW"
>   }
> }
> ]
> 
> 
> *Response:* 201 CREATED
> 
> 
> {
>   "resources" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
>   }
> },
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 803,
> "service_group_name" : "EDW"
>   }
> }
>   ]
> }
> 
> 
> *2.*
> ===
> GET :
> ===
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/
> 
> *Body:*
> 
> []
> 
> 
> *Response:* 200 OK
> 
> 
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/;,
>   "items" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "CORE"
>   }
> },
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW;,
>   "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "EDW"
>   }
> }
>   ]
> }
> 
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
> 
> *Body:*
> 
> []
> 
> 
> *Response:* 200 OK
> 
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_gr

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61201/#review181708
---




ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
Lines 57 (patched)
<https://reviews.apache.org/r/61201/#comment257341>

Primary key in DB should be service group id and not service group name


- Jayush Luniya


On July 28, 2017, 3:48 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61201/
> ---
> 
> (Updated July 28, 2017, 3:48 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21594
> https://issues.apache.org/jira/browse/AMBARI-21594
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **ServiceGroup (SG)** : is defined as sub-resource of cluster. It would later 
> be used to logically group a set of services (coming out of Management Pack 
> selected).
>  
> **Example of a Service groups can be a:** 
> - “Core” Service Group  containing HDFS and Zookeeper. This will be formed by 
> default.
> - “Streaming” Service Group containing Kafka, Storm, Nifi.
> - “Data Science” Service Group containing Hive, Spark, Zeppelin.
> - “EDW” Service Group containing Hive, Spark.
> 
> As part of this review, following has been implemented:
> - SG added as sub-resource of cluster.
> - GET, POST and DELETE API for SG.
> 
> 
> 
> *API calls and response:*
> 
> *1.* 
> 
> POST:
> 
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups
> *Body :*
> 
> 
> [
> {
>   "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "CORE"
>   }
> },
> {
>   "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "EDW"
>   }
> }
> ]
> 
> 
> *Response:* 201 CREATED
> 
> 
> {
>   "resources" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
>   }
> },
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 803,
> "service_group_name" : "EDW"
>   }
> }
>   ]
> }
> 
> 
> *2.*
> ===
> GET :
> ===
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/
> 
> *Body:*
> 
> []
> 
> 
> *Response:* 200 OK
> 
> 
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/;,
>   "items" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "CORE"
>   }
> },
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW;,
>   "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "EDW"
>   }
> }
>   ]
> }
> 
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
> 
> *Body:*
> 
> []
> 
> 
> *Response:* 200 OK
> 
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
>   }
> }
> 
> 
> *3.*
> ===
> DELETE:
&g

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61201/#review181707
---




ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
Lines 201 (patched)
<https://reviews.apache.org/r/61201/#comment257339>

Bulk update for multiple service groups shouldnt take "serviceGroupName" 
path param.


- Jayush Luniya


On July 28, 2017, 3:48 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61201/
> ---
> 
> (Updated July 28, 2017, 3:48 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-21594
> https://issues.apache.org/jira/browse/AMBARI-21594
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **ServiceGroup (SG)** : is defined as sub-resource of cluster. It would later 
> be used to logically group a set of services (coming out of Management Pack 
> selected).
>  
> **Example of a Service groups can be a:** 
> - “Core” Service Group  containing HDFS and Zookeeper. This will be formed by 
> default.
> - “Streaming” Service Group containing Kafka, Storm, Nifi.
> - “Data Science” Service Group containing Hive, Spark, Zeppelin.
> - “EDW” Service Group containing Hive, Spark.
> 
> As part of this review, following has been implemented:
> - SG added as sub-resource of cluster.
> - GET, POST and DELETE API for SG.
> 
> 
> 
> *API calls and response:*
> 
> *1.* 
> 
> POST:
> 
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups
> *Body :*
> 
> 
> [
> {
>   "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "CORE"
>   }
> },
> {
>   "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "EDW"
>   }
> }
> ]
> 
> 
> *Response:* 201 CREATED
> 
> 
> {
>   "resources" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
>   }
> },
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 803,
> "service_group_name" : "EDW"
>   }
> }
>   ]
> }
> 
> 
> *2.*
> ===
> GET :
> ===
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/
> 
> *Body:*
> 
> []
> 
> 
> *Response:* 200 OK
> 
> 
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/;,
>   "items" : [
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "CORE"
>   }
> },
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW;,
>   "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "EDW"
>   }
> }
>   ]
> }
> 
> 
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
> 
> *Body:*
> 
> []
> 
> 
> *Response:* 200 OK
> 
> {
>   "href" : 
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE;,
>   "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
>   }
> }
> 
> 
> *3.*
>

Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61083/#review181221
---




ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
Lines 210 (patched)
<https://reviews.apache.org/r/61083/#comment256715>

Why do we need to delete?


- Jayush Luniya


On July 24, 2017, 2:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61083/
> ---
> 
> (Updated July 24, 2017, 2:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Madhan Neethiraj, Mugdha Varadkar, Nixon Rodrigues, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21563
> https://issues.apache.org/jira/browse/AMBARI-21563
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas use user groups synced in hadoopUGI for authentication and 
> authorization process for LDAP/Kerberos type.
> As core-site.xml was available in HBase conf which is in Atlas classpath and 
> so core.site.xml configs were available. But now as core-site.xml is not 
> available in Hbase conf, to fix this issue hadoop core-site.xml need to be 
> copied to Atlas conf directory by Ambari.
> 
> PS: Attached patch is applicable for trunk branch, patch for branch-2.5 is 
> attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  d424f5b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  3ed469a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  31cf0c8 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> 6e1a52e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> d1d8b7f 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 539bef5 
> 
> 
> Diff: https://reviews.apache.org/r/61083/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with installation on CentOS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178395
---


Ship it!




Ship It!

- Jayush Luniya


On June 20, 2017, 3:48 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated June 20, 2017, 3:48 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 160c91d 
>   ambari-server/src/test/python/TestAmbariServer.py 6bf5e43 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178323
---


Ship it!




Ship It!

- Jayush Luniya


On June 19, 2017, 10:38 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated June 19, 2017, 10:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 160c91d 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178253
---




ambari-server/src/main/python/ambari_server/serverUpgrade.py
Line 428 (original), 428 (patched)
<https://reviews.apache.org/r/60126/#comment252128>

Any unit tests to cover this?


- Jayush Luniya


On June 15, 2017, 5:11 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated June 15, 2017, 5:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py b488ca6 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178251
---




ambari-server/src/main/python/ambari_server/serverUpgrade.py
Lines 430 (patched)
<https://reviews.apache.org/r/60126/#comment252127>

We should not just check one version directory. It is possible that 
common-services/HDFS/2.1.0 is included in Ambari codebase and hence not a 
symlink but common-services/HDFS/3.0.0 is brought in via mpack and hence is a 
symlink.


- Jayush Luniya


On June 15, 2017, 5:11 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> ---
> 
> (Updated June 15, 2017, 5:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
> https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
> replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
> install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
> process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
> create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
> create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
> sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
> os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py b488ca6 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59718: mpack install fails when using https links

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59718/#review176624
---


Ship it!




Address review comment and commit

- Jayush Luniya


On June 1, 2017, 3:03 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59718/
> ---
> 
> (Updated June 1, 2017, 3:03 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-21167
> https://issues.apache.org/jira/browse/AMBARI-21167
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have https enabled on our public repo's. For customers that want to use 
> https links mpack install fails
> 
> {code}
> [root@arpit-1 ~]# ambari-server install-mpack \
> > --mpack=https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> >  \
> > --purge \
> > --verbose
> Using python  /usr/bin/python
> Installing management pack
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Installing management pack 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Download management pack to temp location 
> /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Downloading 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
>  to /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 691, in _install_mpack
> tmp_archive_path = download_mpack(mpack_path)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 140, in download_mpack
> download_file(mpack_path, tmp_archive_path)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 58, in download_file
> force_download_file(link, destination, chunk_size, progress_func = 
> progress_func)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 126, in force_download_file
> response = urllib2.urlopen(request)
>   File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
> return _opener.open(url, data, timeout)
>   File "/usr/lib64/python2.6/urllib2.py", line 391, in open
> response = self._open(req, data)
>   File "/usr/lib64/python2.6/urllib2.py", line 409, in _open
> '_open', req)
>   File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
> result = func(*args)
>   File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open
> return self.do_open(httplib.HTTPSConnection, req)
>   File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open
> raise URLError(err)
> urllib2.URLError:  routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure>
> [root@arpit-1 ~]#
> {code}
> 
> 
> {code}
> [root@arpit-1 ~]# rpm -qa | grep ambari
> ambari-server-2.5.1.0-146.x86_64
> [root@arpit-1 ~]#
> {code}
> 
> Marked it for 2.5.1 will let ambari team make call on if this can make it in 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py 66f6544 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 917dd9c 
> 
> 
> Diff: https://reviews.apache.org/r/59718/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59718: mpack install fails when using https links

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59718/#review176623
---




ambari-common/src/main/python/ambari_commons/inet_utils.py
Lines 81 (patched)
<https://reviews.apache.org/r/59718/#comment249987>

Looks like this is accidentally commented out


- Jayush Luniya


On June 1, 2017, 3:03 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59718/
> ---
> 
> (Updated June 1, 2017, 3:03 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-21167
> https://issues.apache.org/jira/browse/AMBARI-21167
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have https enabled on our public repo's. For customers that want to use 
> https links mpack install fails
> 
> {code}
> [root@arpit-1 ~]# ambari-server install-mpack \
> > --mpack=https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> >  \
> > --purge \
> > --verbose
> Using python  /usr/bin/python
> Installing management pack
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Installing management pack 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Download management pack to temp location 
> /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Downloading 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
>  to /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 691, in _install_mpack
> tmp_archive_path = download_mpack(mpack_path)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 140, in download_mpack
> download_file(mpack_path, tmp_archive_path)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 58, in download_file
> force_download_file(link, destination, chunk_size, progress_func = 
> progress_func)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 126, in force_download_file
> response = urllib2.urlopen(request)
>   File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
> return _opener.open(url, data, timeout)
>   File "/usr/lib64/python2.6/urllib2.py", line 391, in open
> response = self._open(req, data)
>   File "/usr/lib64/python2.6/urllib2.py", line 409, in _open
> '_open', req)
>   File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
> result = func(*args)
>   File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open
> return self.do_open(httplib.HTTPSConnection, req)
>   File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open
> raise URLError(err)
> urllib2.URLError:  routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure>
> [root@arpit-1 ~]#
> {code}
> 
> 
> {code}
> [root@arpit-1 ~]# rpm -qa | grep ambari
> ambari-server-2.5.1.0-146.x86_64
> [root@arpit-1 ~]#
> {code}
> 
> Marked it for 2.5.1 will let ambari team make call on if this can make it in 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py 66f6544 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 917dd9c 
> 
> 
> Diff: https://reviews.apache.org/r/59718/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59718: mpack install fails when using https links

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59718/#review176613
---


Ship it!




Ship It!

- Jayush Luniya


On June 1, 2017, 1:46 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59718/
> ---
> 
> (Updated June 1, 2017, 1:46 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-21167
> https://issues.apache.org/jira/browse/AMBARI-21167
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have https enabled on our public repo's. For customers that want to use 
> https links mpack install fails
> 
> {code}
> [root@arpit-1 ~]# ambari-server install-mpack \
> > --mpack=https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> >  \
> > --purge \
> > --verbose
> Using python  /usr/bin/python
> Installing management pack
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Installing management pack 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> INFO: Download management pack to temp location 
> /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> INFO: Downloading 
> https://public-repo-1.hortonworks.com/HDF/centos6/2.x/updates/2.1.3.0/tars/hdf_ambari_mp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
>  to /var/lib/ambari-server/data/tmp/hdf-ambari-mpack-2.1.3.0-6.tar.gz
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 691, in _install_mpack
> tmp_archive_path = download_mpack(mpack_path)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 140, in download_mpack
> download_file(mpack_path, tmp_archive_path)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 58, in download_file
> force_download_file(link, destination, chunk_size, progress_func = 
> progress_func)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/inet_utils.py", line 
> 126, in force_download_file
> response = urllib2.urlopen(request)
>   File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
> return _opener.open(url, data, timeout)
>   File "/usr/lib64/python2.6/urllib2.py", line 391, in open
> response = self._open(req, data)
>   File "/usr/lib64/python2.6/urllib2.py", line 409, in _open
> '_open', req)
>   File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
> result = func(*args)
>   File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open
> return self.do_open(httplib.HTTPSConnection, req)
>   File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open
> raise URLError(err)
> urllib2.URLError:  routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure>
> [root@arpit-1 ~]#
> {code}
> 
> 
> {code}
> [root@arpit-1 ~]# rpm -qa | grep ambari
> ambari-server-2.5.1.0-146.x86_64
> [root@arpit-1 ~]#
> {code}
> 
> Marked it for 2.5.1 will let ambari team make call on if this can make it in 
> or not.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py 66f6544 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 917dd9c 
> 
> 
> Diff: https://reviews.apache.org/r/59718/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59364: AMBARI-21053 Reverting Beacon stack advisor recommendation

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59364/#review175516
---


Ship it!




Ship It!

- Jayush Luniya


On May 18, 2017, 3:03 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59364/
> ---
> 
> (Updated May 18, 2017, 3:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, 
> Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21053
> https://issues.apache.org/jira/browse/AMBARI-21053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Beacon is an add-on-service installed via management pack. For services 
> installed via mpack need to use service advisor recommendation, which should 
> be provided in mpack.
> 
> Because of the stack_advisor code available, service_advisor.py code logic 
> from mpack is not getting executed.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 488562b 
> 
> 
> Diff: https://reviews.apache.org/r/59364/diff/1/
> 
> 
> Testing
> ---
> 
> Ran 273 tests in 7.202s
> 
> OK
> --
> Total run:1171
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59113/#review174420
---


Ship it!




- Jayush Luniya


On May 10, 2017, 12:21 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59113/
> ---
> 
> (Updated May 10, 2017, 12:21 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20974
> https://issues.apache.org/jira/browse/AMBARI-20974
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fix to update permissions after installing an mpack
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 167f264b8f 
>   ambari-server/src/test/python/TestMpacks.py ef8194502e 
> 
> 
> Diff: https://reviews.apache.org/r/59113/diff/2/
> 
> 
> Testing
> ---
> 
> Unit Testing:
> Total run:1170
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 02:15 min
> [INFO] Finished at: 2017-05-09T14:30:43-07:00
> [INFO] Final Memory: 94M/1439M
> 
> Functional Testing:
> Install Ambari-2.5.1 using non-root ambari admin user
> Install HDP-2.6 (HDFS, Yarn, ZKFS, Storm, Kafka)
> Install HDF-3.0
> ambari-server restart
> Add Nifi and start service.
> Verify that the permissions are set correctly in 
> /var/lib/ambari-server/resources/mpacks, 
> /var/lib/ambari-server/resources/extensions, 
> /var/lib/ambari-server/common-services/NIFI, 
> /var/lib/ambari-server/stacks/HDP/2.6/services/NIFI.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should handle Nifi service

[Jayush Luniya]

> On May 4, 2017, 7:48 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 221 (patched)
> > <https://reviews.apache.org/r/58995/diff/1/?file=1708375#file1708375line221>
> >
> > We should use stack_root and avoid harcoding HDP or HDF.
> 
> Vishal Suvagia wrote:
> Hi Alejandro,
> As Nifi will be an HDP add-on service, and bits for Nifi will 
> be installed under path /usr/hdf/{stack-version} from HDF repos even in an 
> HDP stack cluster. So to differentiate between HDF(for Nifi) and HDP, we will 
> need to keep the stack-checks.

Can you pass cred_lib_path_override and cred_setup_prefix_override parameters 
to this function and in NIFI pass these parameters explicit;y. That way we can 
get rid of both the hardcodings.
if service_name == 'nifi': 
 AND
if stack_name == 'HDP':  

Let NIFI explicitly handle this in their service definition and pass in the 
override parameters, instead of the utility function in resource_management 
library having these hardcodings.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review173950
---


On May 4, 2017, 3:16 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> ---
> 
> (Updated May 4, 2017, 3:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add support to enable Ranger Nifi plugin.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  c510dac 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
>  661089a 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
>  87fccbe 
> 
> 
> Diff: https://reviews.apache.org/r/58995/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58492: Add NIFI StackFeatures to HDP StackFeatures

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58492/#review172397
---


Ship it!




Ship It!

- Jayush Luniya


On April 19, 2017, 7:28 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58492/
> ---
> 
> (Updated April 19, 2017, 7:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20778
> https://issues.apache.org/jira/browse/AMBARI-20778
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add following properties to stack_Features.json
> {
>   "name": "nifi_encrypt_config",
>   "description": "Encrypt sensitive properties written to nifi property 
> file",
>   "min_version": "2.1.0.0"
> },
>  {
>   "name": "toolkit_config_update",
>   "description": "Support separate input and output for toolkit 
> configuration",
>   "min_version": "2.1.0.0"
> },
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  34f3c0769c 
> 
> 
> Diff: https://reviews.apache.org/r/58492/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58492: Add NIFI StackFeatures to HDP StackFeatures

[Jayush Luniya]

> On April 19, 2017, 5:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
> > Lines 402 (patched)
> > <https://reviews.apache.org/r/58492/diff/1/?file=1693587#file1693587line402>
> >
> > We need to be really careful here since technically those are versions 
> > of the NiFi stack when those services are added on top of the HDP stack, 
> > which is confusing.
> > 
> > I don't think these should be added to this file.

Madhu, the min_version should be HDP-specific. Since NIFI will be added to only 
HDP-2.6, you should set the min_version to 2.6.0.0. 

Alejandro, ideally we should have service features triggered based on service 
versions, but we dont have that functionality yet and hence the current 
approach. 

In Ambari 3.0 this would change.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58492/#review172373
---


On April 19, 2017, 5:25 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58492/
> ---
> 
> (Updated April 19, 2017, 5:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20778
> https://issues.apache.org/jira/browse/AMBARI-20778
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add following properties to stack_Features.json
> {
>   "name": "nifi_encrypt_config",
>   "description": "Encrypt sensitive properties written to nifi property 
> file",
>   "min_version": "2.1.0.0"
> },
>  {
>   "name": "toolkit_config_update",
>   "description": "Support separate input and output for toolkit 
> configuration",
>   "min_version": "2.1.0.0"
> },
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  34f3c0769c 
> 
> 
> Diff: https://reviews.apache.org/r/58492/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

[Jayush Luniya]

> On April 18, 2017, 12:36 a.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Line 52 (original), 52 (patched)
> > <https://reviews.apache.org/r/58489/diff/1/?file=1693394#file1693394line52>
> >
> > Why would service_name be the string "null"?
> 
> Madhuvanthi Radhakrishnan wrote:
> During install_packages roleCommand, the service name is set to "null"
> /var/lib/ambari-agent/data/command-5.json:"serviceName": "null",
> 
> Nate Cole wrote:
> If serviceName is the string "null" then that's pretty lame. :)  That 
> should be fixed.

I agree we should not have serviceName = "null" :) However we ensure there are 
no other side effects to it.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58489/#review172160
---


On April 18, 2017, 12:31 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58489/
> -------
> 
> (Updated April 18, 2017, 12:31 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20775
> https://issues.apache.org/jira/browse/AMBARI-20775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All the commands.json files should always contain the versionAdvertised 
> field. If versionAdvertised is not set in command.json then we should assume 
> that versionAdvertised=False when calling stack_tools.py
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  93ec0b74f5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  03f53d490b 
> 
> 
> Diff: https://reviews.apache.org/r/58489/diff/1/
> 
> 
> Testing
> ---
> 
> Tested for service actions:
> Start
> Stop
> Restart
> Reconfigure
> Service Check
> Enable HA
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58489/#review17
---




ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
Line 72 (original)
<https://reviews.apache.org/r/58489/#comment245323>

Also fix the get_stack_version.py to add null check for stack_selector_path

diff --git 
a/ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
 
b/ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
index 7274a598ed..6926be3c39 100644
--- 
a/ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
+++ 
b/ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
@@ -67,7 +67,7 @@ def get_stack_version(package_name):

   stack_selector_path = 
stack_tools.get_stack_tool_path(stack_tools.STACK_SELECTOR_NAME)

-  if not os.path.exists(stack_selector_path):
+  if not stack_selector_path or not os.path.exists(stack_selector_path):
 Logger.info('Skipping get_stack_version since " + stack_selector_tool 
+ " is not yet available')
 return None # lazy fail


- Jayush Luniya


On April 18, 2017, 12:31 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58489/
> ---
> 
> (Updated April 18, 2017, 12:31 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20775
> https://issues.apache.org/jira/browse/AMBARI-20775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All the commands.json files should always contain the versionAdvertised 
> field. If versionAdvertised is not set in command.json then we should assume 
> that versionAdvertised=False when calling stack_tools.py
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  93ec0b74f5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  03f53d490b 
> 
> 
> Diff: https://reviews.apache.org/r/58489/diff/1/
> 
> 
> Testing
> ---
> 
> Tested for service actions:
> Start
> Stop
> Restart
> Reconfigure
> Service Check
> Enable HA
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58489/#review172219
---




ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
Line 49 (original), 49 (patched)
<https://reviews.apache.org/r/58489/#comment245319>

I believe you will need to fix the unit test command.json files to set the 
versionAdvertised correctly otherwise it will cause the unit tests to fail.


- Jayush Luniya


On April 18, 2017, 12:31 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58489/
> ---
> 
> (Updated April 18, 2017, 12:31 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20775
> https://issues.apache.org/jira/browse/AMBARI-20775
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All the commands.json files should always contain the versionAdvertised 
> field. If versionAdvertised is not set in command.json then we should assume 
> that versionAdvertised=False when calling stack_tools.py
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  93ec0b74f5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  03f53d490b 
> 
> 
> Diff: https://reviews.apache.org/r/58489/diff/1/
> 
> 
> Testing
> ---
> 
> Tested for service actions:
> Start
> Stop
> Restart
> Reconfigure
> Service Check
> Enable HA
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58356/#review171939
---


Ship it!




Ship It!

- Jayush Luniya


On April 13, 2017, 3:44 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58356/
> ---
> 
> (Updated April 13, 2017, 3:44 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, 
> Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20735
> https://issues.apache.org/jira/browse/AMBARI-20735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created checkstyle check to ensure either @ApiOperation or @ApiIgnore is 
> present on all REST API methods
> 
> 
> Diffs
> -
> 
>   ambari-server/checkstyle.xml bf7698760ac8ddba1d692bcd448c19d939dc 
>   ambari-server/pom.xml fbc2b9fd129dca0828624fe76e33616b6919f429 
>   ambari-server/src/main/assemblies/server.xml 
> 27835265f78a3a7aed37eaa544e25679eee8b400 
>   utility/checkstyle.xml PRE-CREATION 
>   utility/pom.xml 6f602068ca863fd99d537b88462487d9f28e9c6d 
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java 
> PRE-CREATION 
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>  PRE-CREATION 
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>  14d74867b81d58a35e732940ccb16f02d4e9b317 
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>  PRE-CREATION 
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58356/diff/2/
> 
> 
> Testing
> ---
> 
> Includes unit test for the new check.
> Also ran the check on ambari-server: produces 315 errors.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171808
---


Ship it!




Ship It!

- Jayush Luniya


On April 12, 2017, 9:55 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 9:55 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/6/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> [INFO]
> [INFO] Ambari Main  SUCCESS [ 12.457 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.034 
> s]
> [INFO] Ambari Web . SUCCESS [03:22 
> min]
> [INFO] Ambari Views ... SUCCESS [  2.167 
> s]
> [INFO] Ambari Admin View .. SUCCESS [  8.811 
> s]
> [INFO] utility  SUCCESS [  1.172 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.557 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  3.959 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.448 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  3.951 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.229 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.459 
> s]
> [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  1.430 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [05:27 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  4.367 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  9.257 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [01:21 
> min]
> [INFO] Ambari Server .. SUCCESS [29:32 
> min]
> [INFO] Ambari Functional Tests  SUCCESS [  2.179 
> s]
> [INFO] Ambari Agent ... SUCCESS [ 33.694 
> s]
> [INFO] Ambari Client .. SUCCESS [  0.031 
> s]
> [INFO] Ambari Python Client ... SUCCESS [  0.379 
> s]
> [INFO] Ambari Groovy Client ... SUCCESS [  6.721 
> s]
> [INFO] Ambari Shell ... SUCCESS [  0.020 
> s]
> [INFO] Ambari Python Shell  SUCCESS [  0.033 
> s]
> [INFO] Ambari Groovy Shell  SUCCES

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171800
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
Line 120 (original), 120 (patched)
<https://reviews.apache.org/r/58277/#comment244802>

This change has been reverted  and hence we no longer need to include it in 
the patch



ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
Line 89 (original), 89 (patched)
<https://reviews.apache.org/r/58277/#comment244803>

This change has been reverted  and hence we no longer need to include it in 
the patch


- Jayush Luniya


On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171794
---




ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
Lines 52 (patched)
<https://reviews.apache.org/r/58277/#comment244795>

We should not look at versionAdvertised flag if service name or role is 
null. For instance for custom actions like install_packages the command is not 
specific to a service component and hence we should not skip calling stack/conf 
selector.


- Jayush Luniya


On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 12, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

> On April 12, 2017, 7:20 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/58277/diff/5/?file=1691001#file1691001line82>
> >
> > I don't see this being used anywhere.
> 
> Madhuvanthi Radhakrishnan wrote:
> It is used in 
> ~/hdf-ambari-mpack/src/main/resources/common-services/NIFI/1.0.0/package/scripts/params.py
> stack_version_buildnum = 
> get_component_version_with_stack_selector("/usr/bin/hdf-select", "nifi")
> 
> Jonathan Hurley wrote:
> If that's the only spot using it, then it should be moved into that 
> mpack, no? Otherwsie you risk it being removed in the future and breaking the 
> mpack.

More than one services can use this function (NIFI, STREAMLINE, REGISTRY) and 
dont have a way to have a shared library within mpack. We can just document the 
function that this function can be called by custom services and hence not to 
remove.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
---


On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> -------
> 
> (Updated April 12, 2017, 6:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  ad668a2051 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  872120cc55 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/5/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171651
---




ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
Lines 421 (patched)
<https://reviews.apache.org/r/58277/#comment244637>

Are we using this constant anywhere?


- Jayush Luniya


On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 11, 2017, 9:50 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/2/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171649
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
Lines 438 (patched)
<https://reviews.apache.org/r/58277/#comment244634>

You need to ensure that all code paths pass down the versionAdvertised flag.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
Lines 446 (patched)
<https://reviews.apache.org/r/58277/#comment244633>

add space after ","



ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
Lines 1314 (patched)
<https://reviews.apache.org/r/58277/#comment244635>

    Space after ","


- Jayush Luniya


On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 11, 2017, 9:50 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/2/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171648
---




ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
Lines 127 (patched)
<https://reviews.apache.org/r/58277/#comment244632>

The assumption here is that get_stack_tool does not return a 
stack_selector_path only if versionAdvertised=False which is not true. This 
warning message should be generic and instead in get_stack_tool you should log 
the message that cannot return the stack selector tool since 
versionAdvertised=False.


- Jayush Luniya


On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 11, 2017, 9:50 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/2/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

> On April 11, 2017, 10:14 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Lines 45 (patched)
> > <https://reviews.apache.org/r/58277/diff/2/?file=1689362#file1689362line45>
> >
> > Can this be None as opposed to the String "None"

+1 yes this needs to be None :)


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171643
---


On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 11, 2017, 9:50 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d5018f55b2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/2/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Lines 49 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686585#file1686585line49>
> >
> > This should actually be False by default.
> 
> Jayush Luniya wrote:
> Technically yes default should be False. However we have to ensure that 
> there are no regressions if versionAdvertised is not passed in some code path 
> in the command.json. Using versionAdvertised=True ensures that we are not 
> regressing the past behavior.
> 
> Alejandro Fernandez wrote:
> Default in metainfo.xml is False. We should maintain that consistency in 
> EU/RU, at least for now, especially since this may impact custom services.

@Alejandro,
Madhu will file a follow up JIRA for setting the versionAdvertised=False by 
default, there are few code paths and tests required to be updated for it to 
work correctly. However this patch is critical for unblocking work for HDP + 
Nifi custom service installation.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171447
---


On April 7, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 7, 2017, 11:47 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  c510dac060 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  77d5bf89db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/1/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 219 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686583#file1686583line219>
> >
> > We should not hardcode any stack name or path.
> > If HDP stack needs to use "/usr/hdf", then consider passing a variable 
> > to this function to overwrite the default stack_root.
> > 
> > Even in traditional HDP stacks, /usr/hdf will not exist.

Madhu, we can handle the RANGER changes in a separate JIRA and let RANGER team 
drive that change. I also see some deadcode that needs to be removed.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171447
---


On April 7, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 7, 2017, 11:47 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  c510dac060 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  77d5bf89db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/1/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

[Jayush Luniya]

> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Lines 49 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686585#file1686585line49>
> >
> > This should actually be False by default.

Technically yes default should be False. However we have to ensure that there 
are no regressions if versionAdvertised is not passed in some code path in the 
command.json. Using versionAdvertised=True ensures that we are not regressing 
the past behavior.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171447
---


On April 7, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
> 
> (Updated April 7, 2017, 11:47 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The custom services do not advertise any version and hence will not 
> participate in the HDP upgrade process. So selectors need not be called.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  c510dac060 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  79393b985f 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  02ae62daf3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  ff00a1f38e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  0d1ef13c21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  77d5bf89db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  751ce085d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  e42bd45cc1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
>  1609050409 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  71a02f5e5a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  554e089102 
> 
> 
> Diff: https://reviews.apache.org/r/58277/diff/1/
> 
> 
> Testing
> ---
> 
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine, 
> Registry
> Python unit tests
> Java unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

[Jayush Luniya]

> On March 30, 2017, 4:46 p.m., Jayush Luniya wrote:
> > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
> > Lines 203 (patched)
> > <https://reviews.apache.org/r/58031/diff/3/?file=1680492#file1680492line203>
> >
> > Why is this commented out?
> 
> Madhuvanthi Radhakrishnan wrote:
> The fix,
>   if name != 'metastore':
> XmlConfig("mapred-site.xml",
> skips the mapred-site.xml resource for hive-metastore so this test was 
> failing that resource not found. But that is expected so I thought we would 
> not need this test anymore.

But we should remove the deadcode and not comment it out right?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170595
---


On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> -------
> 
> (Updated March 29, 2017, 11:57 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HMS does not require mapred configs so we need to add a condition so that HMS 
> can be deployed without yarn
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  5f566174b8 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  b7b04a2095 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  2ed3e3a26a 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py
>  b7b04a2095 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py
>  2ed3e3a26a 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 9486e11e46 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> a159cd0370 
> 
> 
> Diff: https://reviews.apache.org/r/58031/diff/3/
> 
> 
> Testing
> ---
> 
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Deployed a regular cluster and added hive service wih existing mysql. 
> Verified that no regression occurs.
> Run python unit tests.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58051: Misc fixes for ambari-server swagger integration prototype

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58051/#review170616
---


Ship it!




Ship It!

- Jayush Luniya


On March 29, 2017, 10:51 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58051/
> ---
> 
> (Updated March 29, 2017, 10:51 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20624
> https://issues.apache.org/jira/browse/AMBARI-20624
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of this ticket following changes are done:
> # swagger spec file will be committed to ambari project at path: 
> ambari-server/docs/api/generated/swagger.json
> # swagger doc file in html format will be auto-generated and committed at 
> path: ambari-server/docs/api/generated/index.html
> # ascidoc directory with md files will not be maintained
> # currently swagger spec file had some validation errors. these errors has 
> been addressed.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/asciidoc/definitions.adoc 76beb8c 
>   ambari-server/docs/api/asciidoc/overview.adoc e9e5649 
>   ambari-server/docs/api/asciidoc/paths.adoc d756051 
>   ambari-server/docs/api/generated/index.html PRE-CREATION 
>   ambari-server/docs/api/generated/swagger.json PRE-CREATION 
>   ambari-server/pom.xml 618d21f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/GroupPrivilegeService.java
>  8a23885 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/GroupService.java
>  ad9db28 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/MemberService.java
>  ec02511 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/ActiveWidgetLayoutService.java
>  30714d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthorizationService.java
>  e6fda46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserPrivilegeService.java
>  d6b4b29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java
>  ad9c485 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewDataMigrationService.java
>  388f454 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java
>  9657c0e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewPermissionService.java
>  cbc037b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewPrivilegeService.java
>  e6d817f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewService.java
>  1936d5b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewVersionService.java
>  ed6ddb1 
> 
> 
> Diff: https://reviews.apache.org/r/58051/diff/1/
> 
> 
> Testing
> ---
> 
> verified that the swagger spec file has no validation error.
> verified that html doc file is generated as expected.
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170595
---




ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
Lines 203 (patched)
<https://reviews.apache.org/r/58031/#comment243457>

Why is this commented out?


- Jayush Luniya


On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> ---
> 
> (Updated March 29, 2017, 11:57 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HMS does not require mapred configs so we need to add a condition so that HMS 
> can be deployed without yarn
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  5f566174b8 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  b7b04a2095 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  2ed3e3a26a 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py
>  b7b04a2095 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py
>  2ed3e3a26a 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 9486e11e46 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> a159cd0370 
> 
> 
> Diff: https://reviews.apache.org/r/58031/diff/3/
> 
> 
> Testing
> ---
> 
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Deployed a regular cluster and added hive service wih existing mysql. 
> Verified that no regression occurs.
> Run python unit tests.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58009: Fetching running application logs results in 'java.io.IOException'

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58009/#review170356
---


Ship it!




Ship It!

- Jayush Luniya


On March 29, 2017, 12:20 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58009/
> ---
> 
> (Updated March 29, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20612
> https://issues.apache.org/jira/browse/AMBARI-20612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A new property called yarn.log.server.web-service.url was added in HDP 2.6
> It takes value from yarn.timeline-service.webapp.address if the 
> yarn.http.policy is HTTP_ONLY and takes value from 
> yarn.timeline-service.webapp.https.address if the yarn.http.policy is 
> HTTPS_ONLY.
> The logic works on fresh installs but is not present during upgrades from 
> HDP2.x to HDP2.6
> Fix is to provide the upgrade packs for it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  c8f93e436f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 3c0769a720 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  53caa52c6b 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 66f1a64d9d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  0d6f51b2e1 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 44d0a2a1d9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58009/diff/3/
> 
> 
> Testing
> ---
> 
> HDP upgrade from 2.5->2.6
> Unit tests
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57863/#review170203
---


Ship it!




Ship It!

- Jayush Luniya


On March 22, 2017, 11:58 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57863/
> ---
> 
> (Updated March 22, 2017, 11:58 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20536
> https://issues.apache.org/jira/browse/AMBARI-20536
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> get_port_from_url function parses an port only address incorrectly.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 
> 48e0aa0 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py
>  7ff2a14 
> 
> 
> Diff: https://reviews.apache.org/r/57863/diff/2/
> 
> 
> Testing
> ---
> 
> Reproduced with the alert being shown as "Connection refused for 
> http://:80/node/info
> With the fix, the alert did not appear.
> 
> Ran python tests.
> Also checked for an empty hive.metastore.uri property and it allowed the 
> value as per the fix for AMBARI-20427
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57795: While generating hash for ambari-server to fill agent cache, all the symlinks should be traversed too.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57795/#review169578
---


Ship it!




Ship It!

- Jayush Luniya


On March 21, 2017, 12:27 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57795/
> ---
> 
> (Updated March 21, 2017, 12:27 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20512
> https://issues.apache.org/jira/browse/AMBARI-20512
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> the archive.zip and .hash is not getting generated on the server side when 
> the package folder is under
> stacks///services//package
> instead of common-services///package
> On closer look, the issue was that when the directories are being traversed 
> to look for hooks and package folders that need to be hashed/archived for 
> having it in the agent cache, those directories that were symlinks were being 
> skipped.
> Fix is to include them.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py baf8179 
> 
> 
> Diff: https://reviews.apache.org/r/57795/diff/2/
> 
> 
> Testing
> ---
> 
> Tested using a management pack
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57253: Credential Store should be enabled by default on fresh installs

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57253/#review167849
---



Maybe I am missing something, but what logic ensures that upgrading an existing 
cluster does not enable the credential store for already deployed services?

- Jayush Luniya


On March 2, 2017, 7:48 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57253/
> ---
> 
> (Updated March 2, 2017, 7:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20275
> https://issues.apache.org/jira/browse/AMBARI-20275
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Credential Store should be enabled by default on fresh installs (Hive, Oozie, 
> Logsearch)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 245a94d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
> 4230dd4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml 
> 75aa9d9 
> 
> 
> Diff: https://reviews.apache.org/r/57253/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing
> ===
> *Scenario - 1 FRESH INSTALL*
> 
> Deploy Ambari 2.5 - HDP 2.6
> 0. Add services Hive, Oozie, Logsearch
> 1. GET http://:8080/api/v1/clusters/cl1/services/HIVE  - Hive 
> Credential Store enabled on fresh install
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "true",
> "credential_store_supported": "true",
> ….
> }
> 2. GET http://:8080/api/v1/clusters/cl1/services/OOZIE - Oozie 
> Credential Store enabled on fresh install
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "true",
> "credential_store_supported": "true",
> …
> }
> 3. GET http://:8080/api/v1/clusters/cl1/services/LOGSEARCH - Logsearch 
> Credential Store enabled on fresh install
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/LOGSEARCH",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "true",
> "credential_store_supported": "true",
> …
> }
> 4. User is able to disable Hive and Oozie CS
> PUT 
> http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(HIVE)
> {"ServiceInfo": {"credential_store_enabled": "false"}}
> 
> GET http://:8080/api/v1/clusters/cl1/services/HIVE
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "false",
> "credential_store_supported": "true",
> …
> }
> 
> PUT 
> http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(OOZIE)
> {"ServiceInfo": {"credential_store_enabled": "false"}}
> 
> GET http://:8080/api/v1/clusters/cl1/services/OOZIE
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "false",
> "credential_store_supported": "true",
> ….
> }
> 
> 5. User is not able to disable Logsearch
> PUT 
> http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(LOGSEARCH)
> {"ServiceInfo": {"credential_store_enabled": "false"}}
> Response:
> {
>   "status" : 400,
>   "message" : "java.lang.IllegalArgumentException: Invalid arguments, cannot 
> disable credential store as it is required by the service. Service=LOGSEARCH"
> }
> 
> *Scenario - 1 AMBARI UPGRADE*
> 1. Ambari upgrade 2.4->2.5 (HDP 2.5.0)
>Hive, Oozie, Logsearch - disabled
> 2. User is able to enable Credential Store for Hive, Oozie, Logsearch post 
> upgrade
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57115: AMBARI-20219 : Grafana Start Failed on HDF cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57115/#review166978
---


Ship it!




Ship It!

- Jayush Luniya


On Feb. 28, 2017, 12:46 a.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57115/
> ---
> 
> (Updated Feb. 28, 2017, 12:46 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20219
> https://issues.apache.org/jira/browse/AMBARI-20219
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Start All failed with Grafana start command failure, even though Grafana 
> Server started up fine.
> 
> Current wait time for Grafana pid creation is 5 seconds, which may not be 
> sufficient on slower systems. Increaed wait time to 20 sec, with periodic 
> checks every 2 seconds.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 
> 8a8ac8f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  cc751c0 
> 
> Diff: https://reviews.apache.org/r/57115/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 57089: HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, quicklinks, and themes

[Jayush Luniya]

> On Feb. 27, 2017, 6:43 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml,
> >  line 24
> > 
> >
> > This should be a brand new version of Slider.
> > It needs to contain a flattening of the configs from all of the older 
> > stacks, kerberos.json, widgets.json, etc.

It would be nice if we can build a tool to do the flattening so that we can use 
it for other services. We already have code that does the configs merge etc, we 
just want to export this out to create the merged service definition.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57089/#review166906
---


On Feb. 27, 2017, 1:24 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57089/
> ---
> 
> (Updated Feb. 27, 2017, 1:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19835
> https://issues.apache.org/jira/browse/AMBARI-19835
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, 
> quicklinks, and themes
> Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0
> In HDP 3.0, we have created a new stack definition that does not inherit from 
> other stacks, in order to reduce the complexity of having to analyze older 
> stacks.
> This means that we need to create a service definition (metainfo.xml, 
> configs, kerberos, widgets, metrics, quicklinks, and themes) that is 
> equivalent to what is inherit and deleted from all of the previous stacks.
> A merge needs to account for additions, overrides, and deletions.
> metainfo.xml and configs perform a merge of older versions
> kerberos.json always seems to override the previous file
> Because the bits for this service may not yet be available in the HDP 3.0 
> repo, 
> the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/SLIDER 
> (which uses inheritance) is equivalent to the flattening of 
> /api/v1/stacks/HDP/versions/3.0/services/SLIDER .
> Please take a look at how this was done for ZK, HDFS, and YARN/MR.
> This means that you will not be able to actually install the service for now, 
> but can still perform validation during the Install Wizard that the correct 
> components and configs show up.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57089/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166926
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 (line 25)
<https://reviews.apache.org/r/57096/#comment239011>

Can you add this to 
ambari/ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.jsonas
 well?


- Jayush Luniya


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>