On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote:
> - No changes to code provided by original fix.
> - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute
> unsigned code and code should be at least ad hoc signed.
> - Signing of app bundle produced by
On Thu, 12 May 2022 00:10:28 GMT, Joe Darcy wrote:
> Noticed by inspection during a CSR review, small refactoring to use a
> message-cause exception constructor when one is available.
>
> Will update the copyright before a push.
Marked as reviewed by bpb (Reviewer).
-
PR:
On Wed, 11 May 2022 16:38:54 GMT, Jorn Vernee wrote:
>> If you want to avoid processing asynchronous exceptions during this upcall
>> you could block them (check NoAsyncExceptionDeliveryMark in
>> JavaThread::exit()). Seems you could set the flag in
>> ProgrammableUpcallhandler::on_entry()
On Wed, 11 May 2022 13:35:00 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 462:
>
>> 460:
On Wed, 11 May 2022 17:55:16 GMT, Jorn Vernee wrote:
>> Oh nice! I was just thinking that the only possible way out of this
>> conundrum would be to somehow block the delivery of async exceptions (at
>> least outside of the user's exception handler). So, that seems to be exactly
>> what we
On Wed, 11 May 2022 13:35:43 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/hotspot/share/utilities/compilerWarnings_gcc.hpp line 51:
>
>> 49:
>>
On Thu, 12 May 2022 00:10:28 GMT, Joe Darcy wrote:
> Noticed by inspection during a CSR review, small refactoring to use a
> message-cause exception constructor when one is available.
>
> Will update the copyright before a push.
Marked as reviewed by iris (Reviewer).
-
PR:
On Thu, 12 May 2022 03:36:31 GMT, Paul Sandoz wrote:
>> Thanks for the review @PaulSandoz ! For the
>> `VectorIntrinsics.checkFromIndexSize`, I'm afraid it's not suitable to be
>> used here because the `outOfBounds` exception will be thrown if the offset
>> is not inside of the valid array
On Wed, 11 May 2022 19:45:55 GMT, Paul Sandoz wrote:
> I tried your test code with the patch and logged compilation
> (`-XX:-TieredCompilation -XX:+PrintCompilation -XX:+PrintInlining
> -XX:+PrintIntrinsics -Xbatch`)
>
> For `func` the first call to `VectorSupport::loadMasked` is intrinsic
On Wed, 11 May 2022 19:11:16 GMT, Phil Race wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 462:
>>
>>> 460:HARFBUZZ_DISABLED_WARNINGS_gcc := type-limits
>>> missing-field-initializers strict-aliasing
>>> 461:HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := reorder
>>>
On Wed, 11 May 2022 14:27:27 GMT, Kim Barrett wrote:
>> src/java.base/share/native/libjli/java.c line 1629:
>>
>>> 1627: const char *arg = jargv[i];
>>> 1628: if (arg[0] == '-' && arg[1] == 'J') {
>>> 1629: *nargv++ = (arg[2] == '\0') ? NULL : JLI_StringDup(arg +
On Wed, 11 May 2022 13:43:55 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/java.base/unix/native/libjli/java_md_common.c line 135:
>
>> 133:
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
>
On Wed, 11 May 2022 17:51:31 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR updates the VM implementation of the foreign linker, by bringing
>> over commits from the panama-foreign repo.
>>
>> This is split off from the main JEP integration for 19, since we have
>> limited resources to handle
On Wed, 11 May 2022 20:27:42 GMT, Patricio Chilano Mateo
wrote:
>> I went ahead and implemented this suggestion. Now we block async exceptions
>> in on_entry, and unblock in on_exit.
>
> Is it possible for these upcalls to be nested? If yes, we could add a boolean
> to context to avoid
On Wed, 11 May 2022 16:00:32 GMT, Maxim Kartashev
wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust API level to Windows 8 for security.cpp and do some cleanup
>
> This change seem to have made this
On Thu, 12 May 2022 01:27:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>>
On Wed, 11 May 2022 15:10:55 GMT, Paul Sandoz wrote:
>> Checking whether the indexes of masked lanes are inside of the valid memory
>> boundary is necessary for masked vector memory access. However, this could
>> be saved if the given offset is inside of the vector range that could make
>>
On Wed, 11 May 2022 23:08:32 GMT, Ioi Lam wrote:
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
> used. It should be removed, and all the handling of a specified user name
> should be removed.
Nice cleanup! I checked back in JDK 7 and couldn't find any use of
Hi Michael,
> On May 11, 2022, at 3:17 PM, Michael Hall wrote:
>
> Is this restricted somehow to Mac App Store applications?
Yes, helper tools (in our case JDK native commands) in Mac App Store
applications cannot use same bundle ID as another application. Since we have
bundle ID embedded in
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2
On Thu, 12 May 2022 01:56:25 GMT, Xiaohong Gong wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>> line 4086:
>>
>>> 4084: } else {
>>> 4085: $Type$Species vsp = vspecies();
>>> 4086: if (offset < 0 || offset >
Alexander
> On May 11, 2022, at 11:38 PM, Alexander Matveev
> wrote:
>
> Hi Michael,
>
>> On May 11, 2022, at 3:17 PM, Michael Hall wrote:
>>
>> Is this restricted somehow to Mac App Store applications?
> Yes, helper tools (in our case JDK native commands) in Mac App Store
> applications
Noticed by inspection during a CSR review, small refactoring to use a
message-cause exception constructor when one is available.
Will update the copyright before a push.
-
Commit messages:
- JDK-8286615: Small refactor to SerializedLambda
Changes:
The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
used. It should be removed, and all the handling of a specified user name
should be removed.
-
Commit messages:
- more cleanup
- 8286560: Remove user parameter from jdk.internal.perf.Perf.attach()
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote:
> - No changes to code provided by original fix.
> - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute
> unsigned code and code should be at least ad hoc signed.
> - Signing of app bundle produced by
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
>
On Wed, 11 May 2022 13:47:43 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/jdk.jpackage/linux/native/applauncher/LinuxPackage.c line 193:
>
>>
On Wed, 11 May 2022 21:58:46 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8286122: [macos]: App bundle cannot upload to Mac App Store due to
>> info.plist embedded in java exe [v2]
>
> - It is not possible to support native JDK commands such as "java" inside Mac
> App Store bundles due to embedded info.plist. Workarounds suggested in
> JDK-8286122 does not seems to be visible.
> - With proposed fix we will enforce "--strip-native-commands" option for
> jlink, so native JDK
I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
Fedora 36.
As you can see, the warnings spreads several areas. Let me know if I should
separate them by area.
* -Wstringop-overflow
* src/hotspot/share/oops/array.hpp
*
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment
On Tue, 10 May 2022 09:07:44 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown if the type of the right-hand
On Tue, 10 May 2022 14:46:56 GMT, Ludovic Henry wrote:
>> Despite the hash value being cached for Strings, computing the hash still
>> represents a significant CPU usage for applications handling lots of text.
>>
>> Even though it would be generally better to do it through an enhancement to
On Tue, 10 May 2022 14:46:56 GMT, Ludovic Henry wrote:
>> Despite the hash value being cached for Strings, computing the hash still
>> represents a significant CPU usage for applications handling lots of text.
>>
>> Even though it would be generally better to do it through an enhancement to
On Tue, 10 May 2022 17:43:24 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/TimeZone.java line 543:
>>
>>> 541: return new ZoneInfo(totalSecs == 0 ? "UTC" : GMT_ID +
>>> tzid, totalSecs);
>>> 542: } else {
>>> 543: return getTimeZone(tzid,
On Tue, 10 May 2022 12:03:09 GMT, Aleksey Shipilev wrote:
> There are plenty of tests failing on many architectures due to
> `--enable-preview` VM code introduced by Loom. This improvements eliminates
> some of the redundant `--enable-preview` clauses from the Record tests, since
> Records
On Tue, 10 May 2022 14:54:39 GMT, Aleksey Shipilev wrote:
>> There are plenty of tests failing on many architectures due to
>> `--enable-preview` VM code introduced by Loom. This improvements eliminates
>> some of the redundant `--enable-preview` clauses from the Record tests,
>> since
On Wed, 11 May 2022 09:00:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change that addresses
> https://bugs.openjdk.java.net/browse/JDK-8286559?
>
> The commit here removes the `synchronized` on `mark` and `reset` methods of
> `InflaterInputStream`. The `mark` method is a
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
>
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Tue, 10 May 2022 23:01:33 GMT, Roger Riggs wrote:
>> PR#8599 8244681: proposes to add compiler warnings for possible lossy
>> conversions
>> From the CSR:
>>
>> "If the type of the right-hand operand of a compound assignment is not
>> assignment compatible with the type of the variable, a
On Wed, 11 May 2022 08:10:56 GMT, Stephen Colebourne
wrote:
>> Added them except "UTC+...", as it is not recognizable as a Custom ID.
>
> Can the test cover `UT` prefix as well? (This is another valid prefix in
> `ZoneId`)
>
> If this PR isn't meant to work with UTC prefix, can a test be
On Wed, 11 May 2022 08:32:48 GMT, Uwe Schindler wrote:
>> Can the test cover `UT` prefix as well? (This is another valid prefix in
>> `ZoneId`)
>>
>> If this PR isn't meant to work with UTC prefix, can a test be added that
>> proves it does *not* work.
>>
>> ie. all these are valid in
On Tue, 10 May 2022 03:22:01 GMT, Joe Darcy wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 4511638: Double.toString(double) sometimes produces incorrect results
>
>
Can I please get a review of this change that addresses
https://bugs.openjdk.java.net/browse/JDK-8286559?
The commit here removes the `synchronized` on `mark` and `reset` methods of
`InflaterInputStream`. The `mark` method is a no-op method and the `reset`
method only always throws a
On Tue, 10 May 2022 18:44:01 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Tue, 10 May 2022 18:55:03 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Tue, 10 May 2022 17:43:07 GMT, Naoto Sato wrote:
>> test/jdk/java/util/TimeZone/ZoneOffsetRoundTripTest.java line 43:
>>
>>> 41: private Object[][] testZoneOffsets() {
>>> 42: return new Object[][] {
>>> 43: {ZoneId.of("Z"), 0},
>>
>> I know, `ZoneId.of()` should
On Wed, 11 May 2022 09:00:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change that addresses
> https://bugs.openjdk.java.net/browse/JDK-8286559?
>
> The commit here removes the `synchronized` on `mark` and `reset` methods of
> `InflaterInputStream`. The `mark` method is a
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi-line (block) comments. Nothing in the code proper has
On Tue, 10 May 2022 18:48:08 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Tue, 10 May 2022 19:16:35 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Tue, 10 May 2022 19:21:58 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Tue, 10 May 2022 20:22:39 GMT, Naoto Sato wrote:
> `String.decodeWithDecoder()` method requires the `CharsetDecoder` parameter
> replaces on malformed/unmappable characters with replacements. However, there
> was a code path that lacked to set the `CodingErrorAction.REPLACE` on the
>
Can I please get a review of this change which fixes build failures on macos
when using `--with-zlib=bundled`?
With this change the build now passes (tested both with bundled and system zlib
variants).
tier1, tier2 and tier3 testing has been done and no related failures have been
noticed.
On Wed, 11 May 2022 08:40:21 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>>
On Wed, 11 May 2022 11:38:31 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes build failures on macos
> when using `--with-zlib=bundled`?
>
> With this change the build now passes (tested both with bundled and system
> zlib variants).
>
> tier1, tier2 and tier3
On Wed, 11 May 2022 10:51:10 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/x86/foreign_globals_x86.hpp line 30:
>>
>>> 28: #include "utilities/growableArray.hpp"
>>> 29:
>>> 30: class outputStream;
>>
>> Redundant declaration?
>
> Yeah, this whole file is redundant :) (replaced by
On Tue, 10 May 2022 20:53:37 GMT, Vladimir Ivanov wrote:
>> src/hotspot/share/utilities/growableArray.hpp line 151:
>>
>>> 149: return _data;
>>> 150: }
>>> 151:
>>
>> This accessor is added to be able to temporarily view a stable GrowableArray
>> instance as a C-style array. It is
On Tue, 10 May 2022 20:30:09 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Tue, 10 May 2022 20:48:47 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Tue, 10 May 2022 21:01:48 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Tue, 10 May 2022 20:45:02 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Wed, 11 May 2022 11:48:00 GMT, Magnus Ihse Bursie wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> The harfbuzz disabled warning looks good, so build changes are
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On Wed, 11 May 2022 12:59:49 GMT, Magnus Ihse Bursie wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8244681: Add a warning for possibly lossy conversion in compound
>> assignments
>> recommended correction of
On Wed, 11 May 2022 13:05:45 GMT, Erik Gahlin wrote:
>> make/modules/jdk.jfr/Java.gmk line 26:
>>
>>> 24: #
>>> 25:
>>> 26: DISABLED_WARNINGS_java += exports lossy-conversions
>>
>> Note that with the fix of JDK-8286392 (and JDK-8286396) the
>> `lossy-conversions` warning should not be
On Wed, 11 May 2022 08:40:21 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>>
On Wed, 11 May 2022 08:40:21 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>>
On Wed, 11 May 2022 12:47:08 GMT, Jaikiran Pai wrote:
>> src/java.base/share/native/libzip/zlib/gzwrite.c line 452:
>>
>>> 450: len = strlen(next);
>>> 451: # else
>>> 452: # ifdef __APPLE__ // ignore format-nonliteral warning on macOS
>>
>> Instead of patching 3rd party code to fix a
On Wed, 11 May 2022 11:56:30 GMT, Magnus Ihse Bursie wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1,
On Wed, 11 May 2022 07:45:39 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown if the type of the right-hand
On Wed, 11 May 2022 07:45:39 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown if the type of the right-hand
On Wed, 11 May 2022 12:48:38 GMT, Alan Bateman wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/java.base/unix/native/libjli/java_md_common.c line 135:
>
>> 133:
On Wed, 11 May 2022 13:10:10 GMT, Magnus Ihse Bursie wrote:
>> I agree, but if it doesn't happen, I can follow up with a separate PR where
>> I remove the disablement.
>
> That's good to know. I think the tricky part is mostly about keeping track of
> all these disabled warnings, so they are
On Wed, 11 May 2022 08:40:21 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>>
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20.
>
> I've
On Tue, 10 May 2022 21:02:39 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Wed, 11 May 2022 12:50:39 GMT, Alan Bateman wrote:
>> Thank you for these useful inputs Magnus. I did these changes locally but
>> for some reason this format-nonliteral is not getting picked up while
>> building that library. I will investigate and see what's going on. Will
>> update the
On Wed, 11 May 2022 11:52:55 GMT, Magnus Ihse Bursie wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - copyright years
>> - disable format-nonliteral warning when building LIBSPLASHSCREEN with
>> bundled zlib
On Wed, 11 May 2022 11:06:51 GMT, Jorn Vernee wrote:
>> src/hotspot/share/opto/callGenerator.cpp line 1131:
>>
>>> 1129:
>>> 1130: case vmIntrinsics::_linkToNative:
>>> 1131: print_inlining_failure(C, callee, jvms->depth() - 1, jvms->bci(),
>>
>> Why is it unconditionally reported as
On Wed, 11 May 2022 14:25:39 GMT, Jaikiran Pai wrote:
>> I agree with Magnus and try to avoid changing the imported zlib code.
>
>> I did these changes locally but for some reason this format-nonliteral is
>> not getting picked up while building that library.
>
> Turns out that was slightly
On Wed, 11 May 2022 03:23:13 GMT, Xiaohong Gong wrote:
>> I modified the code of this PR to avoid the conversion of `boolean` to
>> `int`, so a constant integer value is passed all the way through, and the
>> masked load is made intrinsic from the method at which the constants are
>> passed
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2
On Tue, 10 May 2022 01:23:55 GMT, Xiaohong Gong wrote:
> Checking whether the indexes of masked lanes are inside of the valid memory
> boundary is necessary for masked vector memory access. However, this could be
> saved if the given offset is inside of the vector range that could make sure
>
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20.
>
> I've
On Tue, 10 May 2022 20:22:39 GMT, Naoto Sato wrote:
> `String.decodeWithDecoder()` method requires the `CharsetDecoder` parameter
> replaces on malformed/unmappable characters with replacements. However, there
> was a code path that lacked to set the `CodingErrorAction.REPLACE` on the
>
On Tue, 10 May 2022 01:23:55 GMT, Xiaohong Gong wrote:
> Checking whether the indexes of masked lanes are inside of the valid memory
> boundary is necessary for masked vector memory access. However, this could be
> saved if the given offset is inside of the vector range that could make sure
>
On Wed, 11 May 2022 13:27:38 GMT, Adam Sotona wrote:
>> That's good to know. I think the tricky part is mostly about keeping track
>> of all these disabled warnings, so they are not kept around longer than
>> necessary. And that needs coordination with all the subtasks of the umbrella
>>
On Wed, 11 May 2022 05:39:42 GMT, Alan Bateman wrote:
> > > It's probably ok, but the bug report is either incomplete or I am missing
> > > something. It says "This can be improved to something like: ..." but the
> > > same text as is emitted now is used. Can you fix this so I have a better
>
> Can I please get a review of this change which fixes build failures on macos
> when using `--with-zlib=bundled`?
>
> With this change the build now passes (tested both with bundled and system
> zlib variants).
>
> tier1, tier2 and tier3 testing has been done and no related failures have
>
On Wed, 11 May 2022 13:56:44 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/java.base/share/native/libjli/java.c line 1629:
>
>> 1627:
On Tue, 10 May 2022 20:38:05 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 21 commits:
>>
>> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>> - Remove unneeded
On Wed, 11 May 2022 13:31:16 GMT, Roger Riggs wrote:
>> Thanks for quick reaction.
>> I'll keep my eyes on this race of patches and update this pull request
>> accordingly or create a new PR.
>
> I put out a PR for java.base, but thought I'd wait until the javac fixe were
> pushed before
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment
Redirect discussion to nio-dev.
Brian
> On May 11, 2022, at 7:29 AM, Maxim Kartashev
> wrote:
>
> Win32 documentation [1] kind of discourages the use of space at the very
> end of a file name. Based on that, JDK-8190546 (File.toPath() reject
> directory names with trailing space) had been
This augments the ZipException upon rejecting a Zip File containing entry names
with "." or ".." elements.
It furthermore tries to clean up & compact the logic for detecting "." and ".."
and it adds a method IndexNode:nameAsString() to return the node name as a
String.
-
Commit
On Wed, 11 May 2022 12:05:29 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 306:
>>
>>> 304: intptr_t exception_handler_offset = __ pc() - start;
>>> 305:
>>> 306: // Native caller has no idea how to handle exceptions,
>>
>> Can you elaborate,
1 - 100 of 146 matches
Mail list logo