contrib/native/client/src/protobuf/BitControl.pb.cc 64ab783
contrib/native/client/src/protobuf/UserBitShared.pb.h cfe6938
contrib/native/client/src/protobuf/UserBitShared.pb.cc 17b3463
Diff: https://reviews.apache.org/r/29064/diff/
Testing
---
Thanks,
Parth Chandra
://reviews.apache.org/r/28419/#comment110138
Does this have to be static?
- Parth Chandra
On Nov. 24, 2014, 10:45 p.m., Xiao Meng wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28419
.
- Parth Chandra
On Feb. 11, 2015, 8:10 a.m., Xiao Meng wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30868/
---
(Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24470/#review72904
---
Ship it!
Ship It!
- Parth Chandra
On Feb. 16, 2015, 11:49 p.m
/
Testing
---
Ran thru test queries on all platforms. Valgrind on Linux.
Thanks,
Parth Chandra
Hangout starting now
https://plus.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc
On Mon, Jan 26, 2015 at 2:35 PM, Jason Altekruse altekruseja...@gmail.com
wrote:
Hello Drillers,
Please join us tomorrow at 10am Pacific for our community meeting. If you
are new to Drill, have
:30 p.m.)
Review request for drill and Parth Chandra.
Repository: drill-git
Description
---
Occasionally the client will receive handshake messages from the server.
Requests should be reponded to and responses should be ignored. Spurious
Query_Handle and Query_Result
out?
- Parth Chandra
On Jan. 6, 2015, 8:20 p.m., Norris Lee wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26371
/native/client/src/clientlib/drillClientImpl.cpp c832a79
Diff: https://reviews.apache.org/r/30905/diff/
Testing
---
Ran 30 concurrent queries on tpc-h data and had 6 queries with errors.
Everything ran successfully where previously the queries would give a crash.
Thanks,
Parth Chandra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28686/#review72477
---
Ship it!
Ship It!
- Parth Chandra
On Feb. 5, 2015, 7:28 p.m
- Parth Chandra
On Jan. 6, 2015, 1:06 a.m., Norris Lee wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26371/
---
(Updated Jan
/client/src/include/drill/common.hpp e149ed1
contrib/native/client/src/include/drill/drillClient.hpp 19fec69
Diff: https://reviews.apache.org/r/32214/diff/
Testing
---
Usual test queries on MAc/Linux/Win64
Thanks,
Parth Chandra
for this?
- Parth Chandra
On March 15, 2015, 9:11 p.m., Daniel Barclay wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32082/
---
(Updated
that the connection object adds and
removes statements from the registry (instead of the statements doing so
themselves). Makes the code cleaner. Not a showstopper for this patch.
- Parth Chandra
On March 20, 2015, 12:30 a.m., Daniel Barclay wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31876/#review77061
---
Ship it!
Ship It!
- Parth Chandra
On March 19, 2015, 3:16 a.m
I think the C++ client will be fine since we don't generate the code every
time. There may be some protobuf changes coming soon that will require
updating the code. I'll update the cmake required version at that time.
Parth
On Thu, Mar 19, 2015 at 2:43 PM, Xiao Meng xi...@simba.com wrote:
Hi,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32214/#review77272
---
On March 18, 2015, 8:35 p.m., Parth Chandra wrote
://reviews.apache.org/r/31995/#comment123976
Should we fix this and make it DECIMAL_DIGITS then?
- Parth Chandra
On March 12, 2015, 8:58 p.m., Daniel Barclay wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31995/#review76436
---
Ship it!
Ship It!
- Parth Chandra
On March 12, 2015, 8:58 p.m
On March 11, 2015, 12:29 a.m., Parth Chandra wrote:
contrib/native/client/src/include/drill/drillClient.hpp, line 311
https://reviews.apache.org/r/31876/diff/1/?file=889994#file889994line311
This is required on Windows but not on Linux. Can you add a link to the
explanation
;
}
contrib/native/client/src/include/drill/drillClient.hpp
https://reviews.apache.org/r/31876/#comment123406
This is required on Windows but not on Linux. Can you add a link to the
explanation?
- Parth Chandra
On March 10, 2015, 8:44 p.m., Alexander zarei wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31953/#review76204
---
Ship it!
Ship It!
- Parth Chandra
On March 11, 2015, 10:09 p.m
You will probably need to add the getString method for all varlen types.
- Parth Chandra
On March 23, 2015, 8:21 p.m., Daniel Barclay wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
Hi Matthew,
The drillbit sends back two messages to the client:
1) A message with the isLastChunk flag set to true and query state is
PENDING and
2) A terminal messge which has the query state changed to COMPLETED
(isLastChunk may be false).
I believe the JDBC driver batches these two
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32412/#review77808
---
Ship it!
Ship It!
- Parth Chandra
On March 23, 2015, 8:11 p.m
and cancellations.
Thanks,
Parth Chandra
,
Parth Chandra
for
DRILL-2245)
Thanks,
Parth Chandra
---
On Feb. 25, 2015, 6:38 p.m., Parth Chandra wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31419
-exec/src/main/java/org/apache/drill/exec/work/ErrorHelper.java
https://reviews.apache.org/r/31748/#comment126358
Since we're cleaning this up, I really thing a UUID for the client side
error message only serves to confuse the message and we should ideally remove
it.
- Parth Chandra
On March
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31313/#review77601
---
Ship it!
Ship It!
- Parth Chandra
On March 3, 2015, 1:31 a.m
+1 binding.
Built on Linux from src. Started drillbit and ran a few test queries from
sqlline. Looks good.
On Wed, Mar 25, 2015 at 11:49 PM, Jacques Nadeau jacq...@apache.org wrote:
Good evening,
I would like to propose the release of Apache Drill, version 0.8.0. This
is the second
even though this is a normal case.
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java
https://reviews.apache.org/r/32494/#comment127676
I think the parent throws an UnsupportedOperationException for the update
methods. Don't see why we need to override this.
- Parth Chandra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32598/#review78728
---
Ship it!
Ship It!
- Parth Chandra
On March 31, 2015, 9:33 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32593/#review78727
---
Ship it!
Ship It!
- Parth Chandra
On March 31, 2015, 9:32 p.m
in parallel and multiple queries in
parallel with errors and cancellations.
Thanks,
Parth Chandra
/drill/exec/store/json/TestJsonRecordReader.java
8b09e80
exec/java-exec/src/test/resources/jsoninput/DRILL-2350.json PRE-CREATION
Diff: https://reviews.apache.org/r/33289/diff/
Testing
---
All unit tests.
Thanks,
Parth Chandra
8b09e80
exec/java-exec/src/test/resources/jsoninput/DRILL-2350.json PRE-CREATION
Diff: https://reviews.apache.org/r/33289/diff/
Testing
---
All unit tests.
Thanks,
Parth Chandra
/33289/diff/
Testing
---
All unit tests.
Thanks,
Parth Chandra
Per the spec, one cannot call setTransactionLevel with TRANSACTION_NONE.
Doesn't the parent method throw an exception?
- Parth Chandra
On April 20, 2015, 3:03 a.m., Daniel Barclay wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33290/#review80901
---
Ship it!
Ship It!
- Parth Chandra
On April 20, 2015, 3:03 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/#review80909
---
Ship it!
Ship It!
- Parth Chandra
On April 20, 2015, 3:05 a.m
/TestJsonRecordReader.java
8b09e80
exec/java-exec/src/test/resources/jsoninput/DRILL-2350.json PRE-CREATION
Diff: https://reviews.apache.org/r/33289/diff/
Testing
---
All unit tests.
Thanks,
Parth Chandra
://reviews.apache.org/r/33442/diff/
Testing
---
Tested using sqlline
As the connection string use :
sqlline -u jdbc:drill:local=localhost:31010 -n admin -p admin
Thanks,
Parth Chandra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33291/#review81411
---
Ship it!
LGTM
- Parth Chandra
On April 23, 2015, 9:16 p.m
A common use case (as Daniel's example pointed out) is to arrange data in
directories by date and look for the newest date.
Something like this:
Directory structure -
2015-04-01/subdir/data.json
2015-04-02/subdir/data.json
2015-04-03/subdir/data.json
.
.
Then query for the latest
:
sqlline -u jdbc:drill:local=localhost:31010 -n admin -p admin
Thanks,
Parth Chandra
On April 21, 2015, 4:36 a.m., Parth Chandra wrote:
What should our option be to handle clients that do not handle the
exceptions thrown by these methods? We could check an environment variable
and if it is set, then silently return from any of these calls instead of
throwing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33345/#review81189
---
Ship it!
Ship It!
- Parth Chandra
On April 20, 2015, 4:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33322/#review81179
---
Ship it!
Ship It!
- Parth Chandra
On April 20, 2015, 3:03 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32795/#review80790
---
Ship it!
Ship It!
- Parth Chandra
On April 18, 2015, 12:50 a.m
=10.10.10.121:31010
Different drillbit
!connect jdbc:drill:schema=test;drillbit=10.10.10.123:31010
No schem specified
!connect jdbc:drill:drillbit=10.10.10.123:31010
Thanks,
Parth Chandra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33651/#review82304
---
Ship it!
Ship It!
- Parth Chandra
On April 29, 2015, 4:26 p.m
/DrillResultSetImpl.java
https://reviews.apache.org/r/33651/#comment133031
I don't get why you removed the call to checkNotClosed here.
- Parth Chandra
On April 29, 2015, 4:26 p.m., Daniel Barclay wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33599/#review82296
---
Ship it!
Ship It!
- Parth Chandra
On May 1, 2015, 11:21 p.m
odd since RecordBatchLoader.load() does not seem to be throwing
an exception.
Even if it does, you catch the exception and throw a SqlException with an
unknown exception message later.
- Parth Chandra
On May 2, 2015, 6:12 a.m., Daniel Barclay wrote
https://reviews.apache.org/r/33779/#comment133147
This is never released if an exception is throw.
- Parth Chandra
On May 2, 2015, 6:12 a.m., Daniel Barclay wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
+1 on reducing the fork count.
Don't see this as a reason to hold up the 0.9.0 release. The build
instructions can (probably should) be updated to tell people what to do to
reduce the forkCount.
On Wed, Apr 29, 2015 at 3:27 PM, Sudheesh Katkam skat...@maprtech.com
wrote:
I ran unit tests 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33779/#review82608
---
Ship it!
Ship It!
- Parth Chandra
On May 5, 2015, 3:08 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33685/#review82611
---
Ship it!
Ship It!
- Parth Chandra
On April 29, 2015, 8:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33684/#review82613
---
Ship it!
Ship It!
- Parth Chandra
On May 2, 2015, 5:31 a.m
/java/org/apache/drill/jdbc/test/Drill2128GetColumnsDataTypeNotTypeCodeIntBugsTest.java
https://reviews.apache.org/r/33683/#comment133377
(minor) Why not use the same pattern as the other tests that use
Driver.connect(...).
- Parth Chandra
On April 29, 2015, 8:50 p.m., Daniel Barclay wrote
with
RepeatedFixedWidthVectorLike. The former is a Vector (extends ValueVector)
while the latter is not a Vector (hence VectorLike).
- Parth Chandra
On May 7, 2015, 3:40 a.m., Hanifi Gunes wrote:
---
This is an automatically generated e-mail. To reply, visit
+1 on asking who is likely to fix your TODO !
In general you tend to ignore a TODO that you did not put in. Even with
TODO's that you yourself put in, action never gets taken unless there is a
_concrete_ action item to follow up. As far as I can see, a JIRA is the
closest we will get to having a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33910/#review83198
---
Ship it!
LGTM
- Parth Chandra
On May 7, 2015, 5:42 a.m., Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33911/#review83199
---
Ship it!
LGTM
- Parth Chandra
On May 7, 2015, 5:42 a.m., Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33925/#review83208
---
Ship it!
Ship It!
- Parth Chandra
On May 11, 2015, 6:49 a.m
/diff/
Testing
---
Connected to a specific drillbit and a specific schema defined. The ran show
tables and queries against the tables.
Note that if no schema is specified, the user has to choose a schema before
issuing queries.
Thanks,
Parth Chandra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33995/#review83349
---
Ship it!
Ship It!
- Parth Chandra
On May 8, 2015, 11:54 p.m
/UserBitShared.pb.h
e2f5fd0faeddc5968f0cdafd2200f46246210d31
contrib/native/client/src/protobuf/UserBitShared.pb.cc
b07ecda41b5159458c1d3f7d215afc6835ccf809
Diff: https://reviews.apache.org/r/34072/diff/
Testing
---
Tested with broken connections on Mac. Linix and Win64
Thanks,
Parth Chandra
/#review83453
---
On May 12, 2015, 4:54 a.m., Parth Chandra wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34072
/UserBitShared.pb.cc
b07ecda41b5159458c1d3f7d215afc6835ccf809
Diff: https://reviews.apache.org/r/34072/diff/
Testing
---
Tested with broken connections on Mac. Linix and Win64
Thanks,
Parth Chandra
It seems to me that we have been using Fix Version when we probably mean
Target Version.
The JIRA create issue dialog has this:
Target Version: The versions where this patch is intended to be committed.
Use Fix Version to note where it actually has been committed.
Perhaps we should start using
Version for when it actually got fixed.
On Wed, Apr 15, 2015 at 1:37 PM, Parth Chandra pchan...@maprtech.com
wrote:
It seems to me that we have been using Fix Version when we probably
mean
Target Version.
The JIRA create issue dialog has this:
Target Version
/store/easy/json/reader/BaseJsonProcessor.java
718bb09
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
c196fd2
Diff: https://reviews.apache.org/r/33289/diff/
Testing
---
All unit tests.
Thanks,
Parth Chandra
I've always been able to run unit tests on my Linux VM. But I see no reason
why we can't bump heap mem up to 3G.
On Fri, Apr 17, 2015 at 11:10 AM, Jacques Nadeau jacq...@apache.org wrote:
Hey Guys,
On my linux build machine with four heavy duty physical server cores, I
always get a HEAP OOM
/UserResultsListener.java
https://reviews.apache.org/r/32795/#comment130416
Are you using the queryState parameter anywhere? I didn't see this param
being used in any of the implementations.
- Parth Chandra
On April 17, 2015, 5:28 p.m., Sudheesh Katkam wrote
I'm seeing the following in the Unit tests (the test seem to be passing
though). Anyone else see these or is it just my branch?
*Running org.apache.drill.TestUnionAll#testUnionAllImplicitCastingFailure*
key
52459253098448904
1116675951
Exception (no rows returned):
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32494/#review79105
---
Ship it!
Sqlline does not seem to be an issue.
- Parth Chandra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32800/#review79116
---
Ship it!
Ship It!
- Parth Chandra
On April 6, 2015, 6:30 p.m
/java/org/apache/drill/exec/rpc/user/UserClient.java
https://reviews.apache.org/r/32819/#comment127945
Is this block redundant now? Status will not be success if the RPC version
does not match.
- Parth Chandra
On April 3, 2015, 8:29 p.m., Venki Korukanti wrote
/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java
https://reviews.apache.org/r/32831/#comment127948
Initialize this to empty string? If the client does not pass a password you
wont pass a NULL to the authenticator.
- Parth Chandra
On April 3, 2015, 9:10 p.m., Venki Korukanti
360becb
Diff: https://reviews.apache.org/r/32849/diff/
Testing
---
Ran Manual tests to check authentication works with valid/invalid username and
password combinations
Thanks,
Parth Chandra
contrib/native/client/src/protobuf/User.pb.h 69daf50
contrib/native/client/src/protobuf/User.pb.cc 360becb
Diff: https://reviews.apache.org/r/32849/diff/
Testing
---
Ran Manual tests to check authentication works with valid/invalid username and
password combinations
Thanks,
Parth Chandra
-user-transactions.json
PRE-CREATION
Diff: https://reviews.apache.org/r/32727/diff/
Testing
---
All unit tests on Linux
Thanks,
Parth Chandra
these commented out methods?
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java
https://reviews.apache.org/r/33044/#comment129282
call getIntValueorThrow instead?
- Parth Chandra
On April 10, 2015, 1:32 a.m., Daniel Barclay wrote
and there will be no impact on the clients.
- Parth Chandra
On April 8, 2015, 8:04 p.m., abdelhakim deneche wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32987
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35047/#review87266
---
Ship it!
Ship It!
- Parth Chandra
On June 4, 2015, 6:43 a.m
/jdbc/MetaImpl.java
https://reviews.apache.org/r/35046/#comment139571
Can you put the corresponding JIRA here?
- Parth Chandra
On June 4, 2015, 6:43 a.m., Daniel Barclay wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35049/#review87289
---
Ship it!
Ship It!
- Parth Chandra
On June 4, 2015, 6:43 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35048/#review87288
---
Ship it!
Ship It!
- Parth Chandra
On June 4, 2015, 6:43 a.m
files.
- Parth Chandra
On June 4, 2015, 6:43 a.m., Daniel Barclay wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35051
?
- Parth Chandra
On June 4, 2015, 6:44 a.m., Daniel Barclay wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35052/
---
(Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35143/#review87358
---
Ship it!
Ship It!
- Parth Chandra
On June 7, 2015, 12:43 a.m
Come join the Drill community as we discuss what has been happening lately
and what is in the pipeline. All are welcome, if you know about Drill, want
to know more or just want to listen in.
Link: https://plus.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc
Thanks
+1 on trying this. RB has been pretty painful to us.
On Mon, Jun 22, 2015 at 9:45 PM, Matthew Burgess mattyb...@gmail.com
wrote:
Is Travis https://travis-ci.org/ a viable option for the GitHub route?
I
use it for my own projects to build pull requests (with additional code
quality targets
I'd be in favor of doing this in the 1.2 release cycle.
On Thu, Jun 18, 2015 at 6:30 PM, Aditya a...@apache.org wrote:
Few of the storage plugins like HBase and Hive have matured enough to be
moved out of contrib and into the mainline, probably under exec/storage.
If people think that it is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35634/#review88611
---
Ship it!
Ship It!
- Parth Chandra
On June 19, 2015, 11:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34690/#review89266
---
Ship it!
Ship It!
- Parth Chandra
On May 29, 2015, 11:52 p.m
regression tests
Thanks,
Parth Chandra
1 - 100 of 506 matches
Mail list logo
