[Impala-CR](cdh5-trunk) IMPALA-3745: parquet invalid data handling

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3745: parquet invalid data handling .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3387/3/be/src/exec/data-source-scan-node.cc File

[Impala-CR](cdh5-trunk) IMPALA-3745: parquet invalid data handling

Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3745: parquet invalid data handling .. IMPALA-3745: parquet invalid data handling Added checks/error handling: * Negative string lengths while decoding

Re: Investigation of IMPALA-3678

Dimitris and Alex are the local experts on that code, so maybe they will have a better idea of what the correct solution is. On Wed, Jun 15, 2016 at 2:33 AM, Feng, Guangyuan wrote: > Hi, > > I'm investigating the issue of IMPALA-3678, and wanted to work on it. Some >

[Impala-CR](cdh5-trunk) IMPALA-3677: Write minidump on SIGUSR1

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3677: Write minidump on SIGUSR1 .. Patch Set 2: (1 comment) It looks like there's some possible interaction with the JVM, which uses the signal

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: Code-Review+1 (8 comments) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util

[Impala-CR](cdh5-trunk) IMPALA-3732: handle string length overflow in avro files

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3732: handle string length overflow in avro files .. Patch Set 4: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/3383

[Impala-CR](cdh5-trunk) IMPALA-3732: handle string length overflow in avro files

: If6541e7c68255bf599b26386a55057c93e62af51 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3732: handle string length overflow in avro files

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3732: handle string length overflow in avro files .. Patch Set 5: Code-Review+2 Noticed an off-by-one bug in the test code for inlined char fields

[Impala-CR](cdh5-trunk) IMPALA-3732: handle string length overflow in avro files

: If6541e7c68255bf599b26386a55057c93e62af51 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3732: handle string length overflow in avro files

: If6541e7c68255bf599b26386a55057c93e62af51 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3732: handle string length overflow in avro files

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3732: handle string length overflow in avro files .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3383/1//COMMIT_MSG Commit Message

[Impala-CR](cdh5-trunk) IMPALA-3732: handle string length overflow in avro files

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3383 Change subject: IMPALA-3732: handle string length overflow in avro files .. IMPALA-3732: handle string length overflow in avro files

Re: Fw: LLVM codegen functionality

Yeah, codegen typically gives very large speedups. Another option may be to avoid using the altivec extensions. We get a lot more benefit from codegen than SIMD instructions. On Intel we don't require any extensions beyond the base x86-64 instruction set (SSE4.2 is only used on systems that

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. Patch Set 21: Oops, will fix the comment in a follow up patch (also needed to add the test coverage

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/3072/18/be/src/exec/hdfs-avro-scanner

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

rit-Reviewer: Skye Wanderman-Milne <s...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) Use toolchain assembler.

Tim Armstrong has posted comments on this change. Change subject: Use toolchain assembler. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3352/1//COMMIT_MSG Commit Message: Line 7: Use toolchain assembler

[Impala-CR](cdh5-trunk) IMPALA-2033: Netezza compatibility functions quote ident

Tim Armstrong has posted comments on this change. Change subject: IMPALA-2033: Netezza compatibility functions quote_ident .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3263/2/be/src/exprs/expr-test.cc File

[Impala-CR](cdh5-trunk) Use toolchain assembler.

Tim Armstrong has posted comments on this change. Change subject: Use toolchain assembler. .. Patch Set 1: Code-Review+2 Looks good, should just make sure to do a test packaging build (if you didn't already). -- To view

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 5: It just occurred to me that this could give incorrect results running on a mixed

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory .. Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/3246/6/be/src/runtime/disk-io-mgr-scan

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3611: track unused Disk IO buffer memory .. IMPALA-3611: track unused Disk IO buffer memory Track I/O buffers against separate MemTrackers. This gives us

[Impala-CR](cdh5-trunk) IMPALA-3507: update binutils version to fix slow linking

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3507: update binutils version to fix slow linking .. Patch Set 2: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/3353

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/3338/5/be/src/util/bloom-filter.h

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. Patch Set 17: I removed the batch_size=1 tests and the corresponding changes to test_result_verifier

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has uploaded a new patch set (#18). Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. IMPALA-3441, IMPALA-3659: check for malformed Avro data This patch adds error checking to the Avro

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv .. Patch Set 6: I also realised that the impyla*dev workaround is no longer needed, so cleaned

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Casey Ching <ca...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

-MessageType: newpatchset Gerrit-Change-Id: Ie9216596db0f37d706ea7f77c129cecd5b070429 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Casey Ching <ca...@cloudera.com> Gerrit-Reviewer: Micha

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv .. Patch Set 4: Added a python script to download the archive given package name and version

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

-MessageType: newpatchset Gerrit-Change-Id: Ie9216596db0f37d706ea7f77c129cecd5b070429 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Casey Ching <ca...@cloudera.com> Gerrit-Reviewer: Micha

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has uploaded a new patch set (#17). Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. IMPALA-3441, IMPALA-3659: check for malformed Avro data This patch adds error checking to the Avro

[Impala-CR](cdh5-trunk) IMPALA-3223: Supports download of CDH components from S3.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c//2/bin/bootstrap_toolchain.py

[Impala-CR](cdh5-trunk) IMPALA-3223: Supports download of CDH components from S3.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/ To unsubscribe

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has uploaded a new patch set (#16). Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. IMPALA-3441, IMPALA-3659: check for malformed Avro data This patch adds error checking to the Avro

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/3072/13/be/src/exec/hdfs-avro

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has uploaded a new patch set (#15). Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. IMPALA-3441, IMPALA-3659: check for malformed Avro data This patch adds error checking to the Avro

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Patch Set 4: Code-Review+1 Looks good once we confirm we can build it ok. -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3507: update binutils version to fix slow linking

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3507: update binutils version to fix slow linking .. Patch Set 1: Private build and packaging build both succeeded. http://golden.jenkins.cloudera.com

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. Patch Set 13: I folded in another patch I had been working on that integrate

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

Tim Armstrong has uploaded a new patch set (#13). Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. IMPALA-3201: headers and reservation logic for new buffer pool This patch implements the core

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. Patch Set 12: rebased and updated the commit message slightly. -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3246/4/be/src/runtime/disk-io-mgr.cc File

[Impala-CR](cdh5-trunk) IMPALA-3507: update binutils version to fix slow linking

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3507: update binutils version to fix slow linking .. Patch Set 1: I should also run a packaging build to make sure that it compiles ok on a range

[Impala-CR](cdh5-trunk) IMPALA-1240: add back spilling sort now that sorter is not flaky

Tim Armstrong has posted comments on this change. Change subject: IMPALA-1240: add back spilling sort now that sorter is not flaky .. Patch Set 1: For context, this was originally removed in this commit: commit

[Impala-CR](cdh5-trunk) IMPALA-1240: add back spilling sort now that sorter is not flaky

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3356 Change subject: IMPALA-1240: add back spilling sort now that sorter is not flaky .. IMPALA-1240: add back spilling sort now that sorter

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3246/4/be/src/runtime/disk-io-mgr.cc File

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-3611: track unused Disk IO buffer memory .. IMPALA-3611: track unused Disk IO buffer memory Track I/O buffers against separate MemTrackers. This gives us

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/3072/13/be/src/exec/hdfs-avro

[Impala-CR](cdh5-trunk) IMPALA-3507: update binutils version to fix slow linking

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3507: update binutils version to fix slow linking .. Patch Set 1: Yeah I'll wait for that before running the tests and merging. I've tested locally

[Impala-CR](cdh5-trunk) IMPALA-3507: update binutils version to fix slow linking

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3353 Change subject: IMPALA-3507: update binutils version to fix slow linking .. IMPALA-3507: update binutils version to fix slow linking

[Toolchain-CR] IMPALA-3507: binutils fix for slow linking

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3507: binutils fix for slow linking .. Patch Set 1: http://unittest.jenkins.cloudera.com/job/verify-impala-toolchain-package-build/210/ -- To view

[Toolchain-CR] IMPALA-3507: binutils fix for slow linking

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3507: binutils fix for slow linking .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3341 To unsubscribe, visit http

[Toolchain-CR] IMPALA-3507: binutils fix for slow linking

Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3507: binutils fix for slow linking .. IMPALA-3507: binutils fix for slow linking Linking with ld from binutils-2.26 could be extremely slow

[Impala-CR](cdh5-trunk) IMPALA-3223: Supports download of CDH components from S3.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c//2/bin/bootstrap_toolchain.py

[Toolchain-CR] IMPALA-3507: binutils fix for slow linking

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3341 Change subject: IMPALA-3507: binutils fix for slow linking .. IMPALA-3507: binutils fix for slow linking Linking with ld from binutils

[Impala-CR](cdh5-trunk) IMPALA-2033: Netezza compatibility functions quote ident

Tim Armstrong has posted comments on this change. Change subject: IMPALA-2033: Netezza compatibility functions quote_ident .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3263/2/be/src/exprs/expr-test.cc File

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Patch Set 4: It looks like if we set the -B option to gcc (like we do for USE_GOLD_LINKER

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3246/4/be/src/runtime/disk-io-mgr.cc File

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-3611: track unused Disk IO buffer memory .. IMPALA-3611: track unused Disk IO buffer memory Track I/O buffers against separate MemTrackers. This gives us

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3246/3/be/src/runtime/disk-io-mgr.cc File

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Patch Set 4: It looks like it hit this on one of the builds: 11:45:59 /tmp/cc4RuPOa.s

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/3072/10/be/src/exec/hdfs-avro-scanner

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/2/be/src/util/bloom-filter.h

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/2/be/src/util/bloom-filter

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.

Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. .. Patch Set 2: (3 comments) Nice! Did you see any difference in end-to-end query time? I suspect

[Impala-CR](cdh5-trunk) IMPALA-3441, IMPALA-3659: check for malformed Avro data

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/3072/10/be/src/exec/hdfs-avro

[Impala-CR](cdh5-trunk) IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/3282/5/be/src/exec

[Impala-CR](cdh5-trunk) IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks

Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks .. IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks Refactor DataSink

[Impala-CR](cdh5-trunk) IMPALA-3223: Supports download of CDH components from S3.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c//2/bin/bootstrap_toolchain.py

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv .. Patch Set 3: My pip is tarmstrong@tarmstrong-box:~/Impala/Impala$ pip --version pip 1.5.6

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

-Change-Id: Ie9216596db0f37d706ea7f77c129cecd5b070429 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Casey Ching <ca...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Re

Re: Branch model discussion

Ah, I didn't realise you were thinking about Impala 3.0. My feeling is that we should try to minimise disruption to the regular development process on trunk. We could draw a line at some release as the last 2.x release, and once that's branched from trunk, breaking changes for 3.0 can go in.

Re: Branch model discussion

What would happen if we discover that a tagged release has a critical bug that was missed by the test cases? Would we have a release branch to stabilise the release with any critical fixes? Initially we probably don't need to do this, but I just want to make sure that we pick a release model that

[Impala-CR](cdh5-trunk) IMPALA-3632: Add script for runnig cppclean over the BE code.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3632: Add script for runnig cppclean over the BE code. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3237

[Impala-CR](cdh5-trunk) IMPALA-3632: Add script for runnig cppclean over the BE code.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3632: Add script for runnig cppclean over the BE code. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3237/1/CMakeLists.txt File

[Impala-CR](cdh5-trunk) IMPALA-3670: fix sorter buffer mgmt bugs

Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3670: fix sorter buffer mgmt bugs .. IMPALA-3670: fix sorter buffer mgmt bugs Also make test_scratch_disk.py more deterministic, by using

[Impala-CR](cdh5-trunk) IMPALA-3670: fix sorter buffer mgmt bugs

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3670: fix sorter buffer mgmt bugs .. Patch Set 6: Verified+1 http://sandbox.jenkins.cloudera.com/job/impala-private-build-and-test/3321/ -- To view

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3669: test scratch disk fails on S3

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3669: test_scratch_disk fails on S3 .. Patch Set 2: http://sandbox.jenkins.cloudera.com/job/impala-private-build-and-test/3315/ -- To view, visit http

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3669: test scratch disk fails on S3

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3669: test_scratch_disk fails on S3 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3318 To unsubscribe, visit http

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3669: test scratch disk fails on S3

Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3669: test_scratch_disk fails on S3 .. IMPALA-3669: test_scratch_disk fails on S3 Make the test deterministic by using max_block_mgr_memory

[Impala-CR](cdh5-trunk) IMPALA-2033: Netezza compatibility functions quote ident

Tim Armstrong has posted comments on this change. Change subject: IMPALA-2033: Netezza compatibility functions quote_ident .. Patch Set 2: (3 comments) Thanks for the quick turnaround, I think there are a few corner cases

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3217/1/infra/python/deps

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3217/1/infra/python/deps

[Impala-CR](cdh5-trunk) IMPALA-3670: fix sorter buffer mgmt bugs

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3670: fix sorter buffer mgmt bugs .. Patch Set 6: Code-Review+2 Rebase and address comment. Carry +2 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-CR](cdh5-trunk) IMPALA-3670: fix sorter buffer mgmt bugs

: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3670: fix sorter buffer mgmt bugs

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3670: fix sorter buffer mgmt bugs .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3315/3/be/src/runtime/sorter.cc File be/src/runtime

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3669: test scratch disk fails on S3

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3669: test_scratch_disk fails on S3 .. Patch Set 2: Added Michael in case you want to use this with your exhaustive test fixes. -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-1619: Support 64-bit allocations.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-1619: Support 64-bit allocations. .. Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/2781/5/be/src/runtime/buffered-block

[Impala-CR](cdh5-trunk) IMPALA-1619: Support 64-bit allocations.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-1619: Support 64-bit allocations. .. Patch Set 7: Sorry I missed the email notification for the last update of this, I need to do another pass

[Impala-CR](cdh5-trunk) IMPALA-3670: fix sorter buffer mgmt bugs

Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3670: fix sorter buffer mgmt bugs .. IMPALA-3670: fix sorter buffer mgmt bugs Also make test_scratch_disk.py more deterministic, by using

[Impala-CR](cdh5-trunk) IMPALA-3670: fix sorter buffer mgmt bugs

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3670: fix sorter buffer mgmt bugs .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3315/1/be/src/runtime/sorter.cc File be/src/runtime

[Impala-CR](cdh5-trunk) IMPALA-3670: fix sorter buffer mgmt bugs

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3670: fix sorter buffer mgmt bugs .. Patch Set 2: Separated out the IMPALA-3699 test fix, since that will need to go onto the release branch

[Impala-CR](cdh5-trunk) IMPALA-3670: fix sorter buffer mgmt bugs

Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3670: fix sorter buffer mgmt bugs .. IMPALA-3670: fix sorter buffer mgmt bugs Also make test_scratch_disk.py more deterministic, by using

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3669: test scratch disk fails on S3

Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3669: test_scratch_disk fails on S3 .. IMPALA-3669: test_scratch_disk fails on S3 Make the test deterministic by using max_block_mgr_memory instead

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3669: test scratch disk fails on S3

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3318 Change subject: IMPALA-3669: test_scratch_disk fails on S3 .. IMPALA-3669: test_scratch_disk fails on S3 Make the test deterministic

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3611: track unused Disk IO buffer memory .. IMPALA-3611: track unused Disk IO buffer memory Track I/O buffers against a separate MemTracker. This gives us

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/3246/1/be/src/runtime/disk-io-mgr-test.cc File

[Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv

Tim Armstrong has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv .. Patch Set 2: This is one of the fixes blocking IMPALA-3223: Make git.apache.org code

[Impala-CR](cdh5-trunk) IMPALA-3670,IMPALA-3669: fix sorter buffer mgmt bugs and tests

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3670,IMPALA-3669: fix sorter buffer mgmt bugs and tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3315/1/be/src/runtime/sorter.cc

<    4   5   6   7   8   9   10   11   12   13   >