[Impala-CR](cdh5-trunk) IMPALA-2956: Filters should be able to target multiple scan nodes

2016-05-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes .. Patch Set 9: Code-Review+2 Minor fix in kudu planner tests due to wrong stats.

Re: Greetings everyone. Does there exist some temporary fix for IMPALA-3432?

2016-05-17 Thread Tim Armstrong
If you delete the llvm-3.8 directories from your toolchain directory then rerun ./bin/bootstrap-toolchain.py, that will fix the issue. On Tue, May 17, 2016 at 7:44 PM, Wang, Youwei A wrote: > Greetings everyone. > I have synchronized my codebase with Impala CDH5-Trunk.

[Impala-CR](cdh5-trunk) IMPALA-2956: Filters should be able to target multiple scan nodes

2016-05-17 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2932 to look at the new patch set (#9). Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes

Greetings everyone. Does there exist some temporary fix for IMPALA-3432?

2016-05-17 Thread Wang, Youwei A
Greetings everyone. I have synchronized my codebase with Impala CDH5-Trunk. At the end phase of make_release.sh (I am building the latest CDH5-Trunk), I got following errors: ../../../toolchain/openldap-2.4.25/lib/libldap.a(os-ip.o): In function `ldap_int_poll': os-ip.c:(.text+0x2a6): warning:

[Impala-CR](cdh5-trunk) IMPALA-2809: improve ByteSwap with builtin function or SSE or AVX2

2016-05-17 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#2). Change subject: IMPALA-2809: improve ByteSwap with builtin function or SSE or AVX2 .. IMPALA-2809: improve ByteSwap with builtin function or SSE or AVX2 Using SSE4.2/AVX2

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. .. Patch Set 4: The perf difference seems to be within the noise:

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-3332: Free local allocations in sorter. .. IMPALA-3332: Free local allocations in sorter. Sorter can have runaway memory consumption as it never frees local

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. .. Patch Set 3: Change looks good, just waiting for some quick perf numbers and the updated test -- To view,

[Impala-CR](cdh5-trunk) IMPALA-2809: improve ByteSwap with builtin function or SSE or AVX2

2016-05-17 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-2809: improve ByteSwap with builtin function or SSE or AVX2 .. Patch Set 1: This patch is the formal patch for [IMPALA-2809: improve ByteSwap with builtin

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/2791/7//COMMIT_MSG Commit Message: Line 12:

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix Decimal to Timestamp casting Before this patch, we would first convert the Decimal to

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3109/1/be/src/runtime/sorter.cc File

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3109/1/be/src/runtime/sorter.cc File

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-3332: Free local allocations in sorter. .. IMPALA-3332: Free local allocations in sorter. Sorter can have runaway memory consumption as it never frees local

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/3109/1/be/src/runtime/sorter.cc File

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-3332: Free local allocations in sorter. .. IMPALA-3332: Free local allocations in sorter. Sorter can have runaway memory consumption as it never frees local

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3109/1/be/src/runtime/sorter.cc File

[Impala-CR](cdh5-trunk) IMPALA-3546: don't die if sysconf() reports bogus cache info

2016-05-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3546: don't die if sysconf() reports bogus cache info .. Patch Set 1: (1 comment) > (1 comment) Yeah, I agree we're better off just removing the methods

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3109/1/be/src/runtime/sorter.cc File

[Impala-CR](cdh5-trunk) IMPALA-3546: don't die if sysconf() reports bogus cache info

2016-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3546: don't die if sysconf() reports bogus cache info .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/2791/7//COMMIT_MSG Commit Message: Line 12: I ran a

[Impala-CR](cdh5-trunk) IMPALA-3546: don't die if sysconf() reports bogus cache info

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3110 Change subject: IMPALA-3546: don't die if sysconf() reports bogus cache info .. IMPALA-3546: don't die if sysconf() reports bogus cache

[Impala-CR](cdh5-trunk) IMPALA-3332: Free local allocations in sorter.

2016-05-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/3109 Change subject: IMPALA-3332: Free local allocations in sorter. .. IMPALA-3332: Free local allocations in sorter. Sorter can have runaway

[Impala-CR](cdh5-trunk) PREVIEW IMPALA-3441: check for malformed Avro data

2016-05-17 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: PREVIEW IMPALA-3441: check for malformed Avro data .. Patch Set 3: I think we should be able to have the ScannerContext function call the new

[Impala-CR](cdh5-trunk) PREVIEW IMPALA-3441: check for malformed Avro data

2016-05-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: PREVIEW IMPALA-3441: check for malformed Avro data .. Patch Set 3: Haven't looked at detail yet, but any way to combine or reuse the ScannerContext::ReadZLong()

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/2791/5/be/src/exprs/decimal-operators-ir.cc

[Impala-CR](cdh5-trunk) IMPALA-3163: Fix Decimal to Timestamp casting

2016-05-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-3163: Fix Decimal to Timestamp casting .. IMPALA-3163: Fix Decimal to Timestamp casting Before this patch, we would first convert the Decimal to

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-1633: Impala server GetOperationStatus() should return detail sql error code and message when query fails

2016-05-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1633: Impala server GetOperationStatus() should return detail sql error code and message when query fails .. Patch Set 2: (3 comments)

[Impala-CR](cdh5-trunk) IMPALA-2607: Increase default fs.s3a.connection.maximum

2016-05-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2607: Increase default fs.s3a.connection.maximum .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2965/2//COMMIT_MSG Commit Message: Line 7:

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: We need to think this through carefully because breaking the metadata

[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique_database fixture in test_data_errors.py.

2016-05-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_data_errors.py. .. Patch Set 1: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique_database fixture in test_data_errors.py.

2016-05-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_data_errors.py. .. Patch Set 1: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-2956: Filters should be able to target multiple scan nodes

2016-05-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes .. Patch Set 7: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-2956: Filters should be able to target multiple scan nodes

2016-05-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes .. Patch Set 8: Code-Review+2 Carrying Marcel's +2 -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-2956: Filters should be able to target multiple scan nodes

2016-05-17 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes .. Patch Set 7: Code-Review+2 (1 comment)

[hs2client-CR] Fix hs2client EXPECT_OK macro.

2016-05-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Fix hs2client EXPECT_OK macro. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3068/2/src/hs2client/test-util.h File

[hs2client-CR] Fix hs2client EXPECT_OK macro.

2016-05-17 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3068 to look at the new patch set (#3). Change subject: Fix hs2client EXPECT_OK macro. .. Fix hs2client EXPECT_OK

[Impala-CR](cdh5-trunk) IMPALA-2956: Filters should be able to target multiple scan nodes

2016-05-17 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2932 to look at the new patch set (#7). Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes

[Impala-CR](cdh5-trunk) IMPALA-1633: Impala server GetOperationStatus() should return detail sql error code and message when query fails

2016-05-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-1633: Impala server GetOperationStatus() should return detail sql error code and message when query fails .. IMPALA-1633: Impala server

[Impala-CR](cdh5-trunk) Add Kudu test helpers

2016-05-17 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Add Kudu test helpers .. Patch Set 13: Code-Review+2 The unittest2 module was needed for Kudu. I filed an issue about that. For now we'll have to install the

[Impala-CR](cdh5-trunk) Add Kudu test helpers

2016-05-17 Thread Casey Ching (Code Review)
Hello Michael Brown, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2855 to look at the new patch set (#13). Change subject: Add Kudu test helpers .. Add Kudu test

[Impala-CR](cdh5-trunk) Add Kudu test helpers

2016-05-17 Thread Casey Ching (Code Review)
Hello Michael Brown, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2855 to look at the new patch set (#12). Change subject: Add Kudu test helpers .. Add Kudu test

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: Tim, there is nothing that controls this. I hard coded this... I feel

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: I checked that there is no way to do per catalog topic update. once

[hs2client-CR] Fix hs2client EXPECT_OK macro.

2016-05-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Fix hs2client EXPECT_OK macro. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3068/2/src/hs2client/test-util.h File src/hs2client/test-util.h:

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: Where is the parameter that controls this? Sorry I'm not that

[Impala-CR](cdh5-trunk) IMPALA-2809: improve ByteSwap with builtin function or SSE or AVX2

2016-05-17 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has abandoned this change. Change subject: IMPALA-2809: improve ByteSwap with builtin function or SSE or AVX2 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/1813 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-2956: Filters should be able to target multiple scan nodes

2016-05-17 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2932 to look at the new patch set (#6). Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes

[Impala-CR](cdh5-trunk) IMPALA-2956: Filters should be able to target multiple scan nodes

2016-05-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes .. Patch Set 4: (2 comments)

[hs2client-CR] Fix hs2client EXPECT_OK macro.

2016-05-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Fix hs2client EXPECT_OK macro. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3068/2/src/hs2client/test-util.h File

[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique_database fixture in test_data_errors.py.

2016-05-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_data_errors.py. .. Patch Set 1: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3491: Merge test_hbase_metadata.py into compute_stats.py. Use unique db fixture.

2016-05-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Merge test_hbase_metadata.py into compute_stats.py. Use unique db fixture. .. Patch Set 2: Code-Review+2 -- To view, visit

[hs2client-CR] Fix hs2client EXPECT_OK macro.

2016-05-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Fix hs2client EXPECT_OK macro. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3068/2/src/hs2client/test-util.h File src/hs2client/test-util.h:

[hs2client-CR] Fix hs2client EXPECT_OK macro.

2016-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Fix hs2client EXPECT_OK macro. .. Patch Set 2: (1 comment) Thanks for the tip, Jim. We should fix this in Impala as well then.

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: I will try to do this per catalog update object. in order to simulate

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: Tim, that is not a start up option.. I hard coded that to be 20kb in

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: Tim.. yes.. I was trying to run test with that setting to be 20kb.. I

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: btw, the core test had 20kb setting as well with exhaustive data

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. Patch Set 4: sorry just saw this.. Yes, Dan. I saw exhaustive data loading hanging

[Impala-CR](cdh5-trunk) IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB.

2016-05-17 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#4). Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. .. IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. Java

[Impala-CR](cdh5-trunk) IMPALA-3491: Use unique_database fixture in test_last_ddl_time_update.py.

2016-05-17 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/3104 Change subject: IMPALA-3491: Use unique_database fixture in test_last_ddl_time_update.py. .. IMPALA-3491: Use unique_database fixture in

[Impala-CR](cdh5-trunk) IMPALA-3168: replace HashTable parameters with constants

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3168: replace HashTable parameters with constants .. IMPALA-3168: replace HashTable parameters with constants This addresses the regression for

[Impala-CR](cdh5-trunk) IMPALA-3168: replace HashTable parameters with constants

2016-05-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3168: replace HashTable parameters with constants .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3088 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode .. IMPALA-3286: prefetching for PartitionedAggregationNode This patch builds on top of the

[Impala-CR](cdh5-trunk) IMPALA-1928: Fix Thrift client transport wrapping order

2016-05-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-1928: Fix Thrift client transport wrapping order .. IMPALA-1928: Fix Thrift client transport wrapping order The thrift client incorrectly

[Impala-CR](cdh5-trunk) IMPALA-2956: Filters should be able to target multiple scan nodes

2016-05-17 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes .. Patch Set 5: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3535: Ignore invalid per-pool default query options

2016-05-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3535: Ignore invalid per-pool default query options .. IMPALA-3535: Ignore invalid per-pool default query options In 2.5 we added the ability

[Impala-CR](cdh5-trunk) IMPALA-3168: replace HashTable parameters with constants

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3168: replace HashTable parameters with constants .. IMPALA-3168: replace HashTable parameters with constants This addresses the regression for small-ndv

[Impala-CR](cdh5-trunk) IMPALA-3168: replace HashTable parameters with constants

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-3168: replace HashTable parameters with constants .. IMPALA-3168: replace HashTable parameters with constants This addresses the regression for small-ndv

[Impala-CR](cdh5-trunk) IMPALA-3168: replace HashTable parameters with constants

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3168: replace HashTable parameters with constants .. Patch Set 5: (15 comments) http://gerrit.cloudera.org:8080/#/c/3088/5/be/src/codegen/llvm-codegen.h

[Impala-CR](cdh5-trunk) IMPALA-3168: replace HashTable parameters with constants

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3168: replace HashTable parameters with constants .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3088/3/be/src/exec/hash-table.inline.h

[Impala-CR](cdh5-trunk) IMPALA-3168: replace HashTable parameters with constants

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-3168: replace HashTable parameters with constants .. IMPALA-3168: replace HashTable parameters with constants This addresses the regression for small-ndv

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode .. Patch Set 15: Code-Review+2 The build failures were manual cancellations... Carry Dan's +2 -- To

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode .. Patch Set 15: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3070 To unsubscribe,

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode .. Patch Set 14: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3070 to look at the new patch set (#15). Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode .. Patch Set 14: Code-Review+1 (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode .. Patch Set 13: (2 comments)

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Tim Armstrong (Code Review)
Hello Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3070 to look at the new patch set (#14). Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode .. Patch Set 13: (2 comments)

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode .. Patch Set 11: (14 comments)

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode .. Patch Set 13: I'm going to start a GVM, but will wait for Michael's +1 before merging. -- To view,

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3070 to look at the new patch set (#13). Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode ..

[Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode

2016-05-17 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3070 to look at the new patch set (#12). Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode ..

[Impala-CR](cdh5-trunk) IMPALA-2956: Filters should be able to target multiple scan nodes

2016-05-17 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes .. Patch Set 5: (1 comment)