Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

=city.id destTable: city customer_city: name: customer_city displayString: description: paths: - sales.customer_city_id=city.id - sales.customer_id=customer.id customer.city_id=city.id destTable: city ``` Thoughts? Thanks, Rajat

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

=city.id destTable: city ``` Thoughts? Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

ity: paths: - sales.customer_city_id=city.id - sales.customer_id=customer.id customer.city_id=city.id destTable: city ``` Thoughts? Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

ths: - sales.customer_city_id=city.id - sales.customer_id=customer.id customer.city_id=city.id destTable: city ``` Thoughts? Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

> > > >rating: displayString: Rating type: FLOAT defaultAggr: AVG Will try to shorten size for fields where only few fields are set and rest are null. - Rajat --- This is an automatically generated

Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41033/#review111586 ------- On Dec. 21, 2015, 4:54 p.m., Rajat Khandelwal wrote: > > --

Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

] [INFO] Total time: 26:39.990s [INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015 [INFO] Final Memory: 178M/1024M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

] [INFO] Total time: 26:39.990s [INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015 [INFO] Final Memory: 178M/1024M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

/cli.apt 3db53c44900176dc7f062267a200ec5c8ced5f6a Diff: https://reviews.apache.org/r/41033/diff/ Testing --- http://showterm.io/2bbd961fd3bcc859adbc8 Thanks, Rajat Khandelwal

Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

ms doc need change. By default async is false - unspecified default > > value is true. > > Rajat Khandelwal wrote: > if unspecified value is true then the default is true. unspecified value > is the value assumed when value is not provided for this argument. > > Amare

Re: Review Request 41506: LENS-899: Create Attempt framework

t's server's bound, the drivers have full freedom apart from that. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41506/#review111459 ------

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

g()` inside `describe`. That again can happen in different jira(s). - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41035/#review111587 ---------

Re: Review Request 41506: LENS-899: Create Attempt framework

hich it will still be even after addition of the `num_attempts` field. - Rajat ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41506/#review111459 --

Re: Review Request 41538: implementing java.sql.Connection#getMetaData in lens client jdbc

e/lens/client/jdbc/LensJdbcDatabaseMetaData.java (lines 375 - 387) <https://reviews.apache.org/r/41538/#comment172034> Same for these functions, I think jdbc client users can call this function to know what is or is not supported. - Rajat Khandelwal On Dec. 18, 2015, 11:56 a

Re: Review Request 41679: LENS-908 : Add error codes for jdbc query execution exception

tps://reviews.apache.org/r/41679/#comment172035> Add driver name also in the format string. - Rajat Khandelwal On Dec. 23, 2015, 2:44 p.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 41679: LENS-908 : Add error codes for jdbc query execution exception

tructor can take driver instance and exception instance and the driver name can be picked up inside the constructor. A lot of code change here is calling `this.getClass().getName()`. - Rajat Khandelwal On Dec. 23, 2015, 9:16 p.m., Sushil Mo

Re: Review Request 41630: support for prepared query on lens client jdbc

/LensJdbcPreparedStatementTest.java (line 33) <https://reviews.apache.org/r/41630/#comment172094> `List`? - Rajat Khandelwal On Dec. 23, 2015, 4:33 p.m., piyush mukati wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 41538: implementing java.sql.Connection#getMetaData in lens client jdbc

172102> http://stackoverflow.com/questions/4658867/why-does-arrays-aslist-return-its-own-arraylist-implementation `Arrays.asList(new Object[n])` and `new ArrayList(n)` have the same data usages, but the former is an fixed size array list without the `remove` and `add` functio

Re: Review Request 41506: LENS-899: Create Attempt framework

can be skipped from ordering construct. > > Rajat Khandelwal wrote: > Added it for a currently impossible (but plausible) bug, when driver > start time somehow gets missed while updating in the table, but driver end > time is updated correctly. Keeping both in order by will allow t

Re: Review Request 41687: LENS-907 : Subsequent calls to metastore API to fetch native tables throws error after the first call

/CubeMetastoreServiceImpl.java <https://reviews.apache.org/r/41687/#comment172103> Can you describe what is the exception thrown? - Rajat Khandelwal On Dec. 23, 2015, 5:40 p.m., Deepak Barr wrote: > > --- > This is a

Re: Review Request 41679: LENS-908 : Add error codes for jdbc query execution exception

> On Dec. 24, 2015, 12:42 p.m., Rajat Khandelwal wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 580 > > <https://reviews.apache.org/r/41679/diff/2/?file=1175374#file1175374line580> > > > > 1. Here everyw

Re: Review Request 41687: LENS-907 : Subsequent calls to metastore API to fetch native tables throws error after the first call

> On Dec. 24, 2015, 2:17 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, > > line 1217 > > <https://reviews.apache.org/r/41687/diff/1/?file=1175339#file1175339line1217> > > > >

Re: Review Request 41671: LENS-735 : Remove accepting TableReferences for ReferenceDimAttribute

nt a one-to one `toString` and `fromString` pair for priting and parsing join chains. Hopefully I'll be able to do that in LENS-791 It seems that from a lot of places, `throws LensException` can be removed. Have pointed out a few but I think mostly they are propagation of 1 or

Re: Review Request 41506: LENS-899: Create Attempt framework

e let the driver decide on number of re-tries ? It can be diff > > for Hive and JDBC. Eventually (in future) it can even differ based on error > > type. > > Rajat Khandelwal wrote: > Sure, but I believe the server should impose some upper bound on retries. > That&#

Re: Review Request 41687: LENS-907 : Subsequent calls to metastore API to fetch native tables throws error after the first call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41687/#review111844 --- Ship it! Ship It! - Rajat Khandelwal On Dec. 23, 2015, 5:40

Re: Review Request 41506: LENS-899: Create Attempt framework

d8e654d72989d7a8f9334adc81b82a9e0810ee39 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9afeb384738fa21ef7381cb5a54e3c02165a Diff: https://reviews.apache.org/r/41506/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

.id destTable: city ``` Thoughts? Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

.id destTable: city ``` Thoughts? Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

.id destTable: city ``` Thoughts? Thanks, Rajat Khandelwal

Re: Review Request 41538: implementing java.sql.Connection#getMetaData in lens client jdbc

> On Dec. 24, 2015, 1:02 p.m., Rajat Khandelwal wrote: > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java, > > lines 63-64 > > <https://reviews.apache.org/r/41538/diff/1/?file=1170547#file1170547line63> > > > &g

Re: Review Request 41630: support for prepared query on lens client jdbc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41630/#review112288 --- Ship it! Ship It! - Rajat Khandelwal On Dec. 30, 2015, 7:06

Re: Review Request 41679: LENS-908 : Add error codes for jdbc query execution exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41679/#review112291 --- Ship it! Ship It! - Rajat Khandelwal On Dec. 23, 2015, 9:16

Review Request 41794: LENS-518: Move Hive dependency to Apache Hive

-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 6c3d4c3b0235f88c16aad148cbbbc30eca89eb7f pom.xml 746204e87d046454fbd0e3f4690e3b220487418c Diff: https://reviews.apache.org/r/41794/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 41798: LENS - 910 : Add session config to skip filtering cube related tables from all the tables in a database

> On Dec. 31, 2015, 8:40 a.m., Puneet Gupta wrote: > > lens-server/src/main/resources/lenssession-default.xml, lines 234-238 > > > > > > Shall we not make this entry ? This feature is enabled in code by > > default

Re: Review Request 41794: LENS-518: Move Hive dependency to Apache Hive

5feab715b9a283e0951570a407b464b3bd7007a6 lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484 pom.xml 746204e87d046454fbd0e3f4690e3b220487418c Diff: https://reviews.apache.org/r/41794/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 41798: LENS - 910 : Add session config to skip filtering cube related tables from all the tables in a database

Not sure if design wise this is the best way to handle this . Should > > there be a cache instead? But keeping cache in sync with metastore may not > > be trivial? > > > > Others can comment too from design perspective.. > > Rajat Khandelwal wrote: >

Re: Review Request 41798: LENS - 910 : Add session config to skip filtering cube related tables from all the tables in a database

/CubeQueryConfUtil.java (line 113) <https://reviews.apache.org/r/41798/#comment173295> On second thought, `exclude.nativetables` is not descriptive enough. Can you change it to something more descriptive? - Rajat Khandelwal On Jan. 5, 2016, 2:11 p.m., Deepak Barr

Re: Review Request 41506: LENS-899: Create Attempt framework

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/41506/#review112292 ------- On Dec. 24, 2015, 4:06 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically genera

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

sult Available driverOpHandle: OperationHandle [opType=EXECUTE_STATEMENT, getHandleIdentifier()=1da0e13e-eb67-484b-931f-1ca5584ac030] submissionTime: 1452083135606 launchTime: 1452083141739 driverStartTime: 1452083139777 driverFinishTime: 1452083149324 finishTime: 1452083149336 closedTime: 0 lens-shell> ``` Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

149336 closedTime: 0 lens-shell> ``` Thanks, Rajat Khandelwal

Review Request 42023: LENS-719: Allow fact start time to be specified for a storage and a update period

/parse/StorageTableResolver.java 14def15ec842d1d2cf8d3079ecc457a147cd41af Diff: https://reviews.apache.org/r/42023/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 41671: LENS-735 : Remove accepting TableReferences for ReferenceDimAttribute

/AbstractCubeTable.java (lines 115 - 144) <https://reviews.apache.org/r/41671/#comment173726> Should we add nonnull annotation here? - Rajat Khandelwal On Jan. 7, 2016, 3:25 p.m., Amareshwari Sriramadasu wrote: > > --- > This is a

Review Request 42024: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

e531e6b0bcfb6c0d565cd0cfeb4e9b4b45b4534e lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java f02cdb05cb9e3707b59eb62fd068c31be9e4c69f Diff: https://reviews.apache.org/r/42024/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42023: LENS-719: Allow fact start time to be specified for a storage and a update period

/TestCubeMetastoreClient.java 0fef13f30662755c7f3da953c411e6715539ac7e Diff: https://reviews.apache.org/r/42023/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 42062: LENS-913: Seeing DateUtil exception in all cube tests

--- Thanks, Rajat Khandelwal

Re: Review Request 42062: LENS-913: Seeing DateUtil exception in all cube tests

://reviews.apache.org/r/42062/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42067: Review for streaming support in lens

144> name change necessary? Doc change should suffice. - Rajat Khandelwal On Jan. 8, 2016, 3:25 p.m., Puneet Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 5b44f9581ab1d57239b86738963ff519c0e94a9a Diff: https://reviews.apache.org/r/42070/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

`correct` solution first, will take pushdown as an improvement. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42070/#review113673 -

Re: Review Request 41671: LENS-735 : Remove accepting TableReferences for ReferenceDimAttribute

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41671/#review113685 --- Ship it! Ship It! - Rajat Khandelwal On Jan. 8, 2016, 3:07 p.m

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

le the test cases so want to keep them somewhere. Haven't found an elegant solution so far. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41035/#review113588 ----

Review Request 42136: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

4810559994f8e7b47d34246365912cc5fe09d97b Diff: https://reviews.apache.org/r/42136/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

> On Jan. 9, 2016, 7:09 a.m., Amareshwari Sriramadasu wrote: > > lens-examples/src/main/resources/city.yaml, line 1 > > <https://reviews.apache.org/r/41035/diff/10/?file=1184335#file1184335line1> > > > > No more xml ? > > Rajat Khandelwal wrote: >

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

lly generated e-mail. To reply, visit: https://reviews.apache.org/r/41035/#review113588 ------- On Jan. 6, 2016, 6:20 p.m., Rajat Khandelwal wrote: > > --- > This is an aut

Re: Review Request 42131: LENS-917 : Fix table pruning for multiple chains for same destination table

ts inside the loop as and when required. lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java (line 451) <https://reviews.apache.org/r/42131/#comment174559> should we change to debug log? - Rajat Khandelwal On Jan. 11, 2016, 5:37 p.m., Amareshwa

Re: Review Request 40579: Lens-spark-context package. It is an interface for using lens's query and ml abilities throught Spark.

n't drop the generic parameter here. - Rajat Khandelwal On Jan. 11, 2016, 5:02 p.m., vikas singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42022/#review114156 --- On Jan. 7, 2016, 4:36 p.m., Rajat Khandelwal wrote: > > --

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

e we creating static client? Please add comments. > > Rajat Khandelwal wrote: > The util needs to know whether a table is a cube table or not. For that > `CubeMetastoreClient` instance is required. Hence created a static client for > the entire utility to use. getting hiveconf

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

check this with Hive 2.1 and see if we have to remove > > isCubeNode fully ? > > Rajat Khandelwal wrote: > Yes. As in we don't *need* to remove it, but the function will never > return true with Hive >= 2.1 > > Amareshwari Sriramadasu wrote: > It may n

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

/CubeKeywordRemoverTest.java PRE-CREATION lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c Diff: https://reviews.apache.org/r/42022/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 42291: LENS-923: CLI should allow query execution without the prefix "query execute"

59b7355e832eac66b7054bcb33a3ec7e6dfb78ba lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java a29600d25d89e73f26102ba609e04b73f4cb7c58 src/site/apt/user/cli.apt 65380e680f1370820cf361457ad5286e6e95fd39 Diff: https://reviews.apache.org/r/42291/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42291: LENS-923: CLI should allow query execution without the prefix "query execute"

t; order by sample_dim_chain.name desc limit 2 --async 918534fb-3eff-42da-a1dd-25f43a78d377 lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name != "first" order by sample_dim_chain.name desc limit 2 --async -0n optional --async: ; default if option present: 'true'; default if option not present: 'false' lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name != "first" order by sample_dim_chain.name desc limit 2 --async --name optional --name: ; no default value lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name != "first" order by sample_dim_chain.name desc limit 2 --async --name myquery 7009e162-f448-40a6-b297-004499eb8b83 lens-shell> ``` Thanks, Rajat Khandelwal

Re: Review Request 41538: implementing java.sql.Connection#getMetaData in lens client jdbc

please check. - Rajat Khandelwal On Jan. 14, 2016, 7:19 p.m., piyush mukati wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 42291: LENS-923: CLI should allow query execution without the prefix "query execute"

by sample_dim_chain.name desc limit 2 --async 918534fb-3eff-42da-a1dd-25f43a78d377 lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name != "first" order by sample_dim_chain.name desc limit 2 --async -0n optional --async: ; default if option present: 'true'; default if option not present: 'false' lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name != "first" order by sample_dim_chain.name desc limit 2 --async --name optional --name: ; no default value lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name != "first" order by sample_dim_chain.name desc limit 2 --async --name myquery 7009e162-f448-40a6-b297-004499eb8b83 lens-shell> ``` Thanks, Rajat Khandelwal

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

/CubeKeywordRemoverTest.java PRE-CREATION lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 202db822f41fc53e6dad8789d6cac62a8c9be68c Diff: https://reviews.apache.org/r/42022/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

1452083139777 driverFinishTime: 1452083149324 finishTime: 1452083149336 closedTime: 0 lens-shell> ``` Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

3e-eb67-484b-931f-1ca5584ac030] submissionTime: 1452083135606 launchTime: 1452083141739 driverStartTime: 1452083139777 driverFinishTime: 1452083149324 finishTime: 1452083149336 closedTime: 0 lens-shell> ``` Thanks, Rajat Khandelwal

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41035/#review114948 --- On Jan. 18, 2016, 6:13 p.m., Rajat Khandelwal wrote: > > ---

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

xtend ToXMLString? > > If so, Can we enrfoce that at compilation somehow? > > Rajat Khandelwal wrote: > What do you mean by client facing classes? I was thinking mostly their > `toString` can be `yaml` because of better readability. > > Only plac

Re: Review Request 41035: LENS-791: CLI format json strips away all commas, including useful ones

3e-eb67-484b-931f-1ca5584ac030] submissionTime: 1452083135606 launchTime: 1452083141739 driverStartTime: 1452083139777 driverFinishTime: 1452083149324 finishTime: 1452083149336 closedTime: 0 lens-shell> ``` Thanks, Rajat Khandelwal

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

examples. :) - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42022/#review115115 --- On Jan. 18, 2016, 11:44 a.m., Rajat Khandel

Re: Review Request 42454: LENS-926 : Fixes Chain ref column from bridge table to be resolved correctly

/TestBridgeTableQueries.java (line 33) <https://reviews.apache.org/r/42454/#comment176331> Other than moving from the other class, any changes here? - Rajat Khandelwal On Jan. 18, 2016, 4 p.m., Amareshwari Sriramadasu wrote: > > ---

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

, Rajat Khandelwal

Re: Review Request 42291: LENS-923: CLI should allow query execution without the prefix "query execute"

rest of enhanced user experience, I propose let's have default values for the `show logs` command too. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42291/#review115

Review Request 42599: LENS-929: Fact skipping should be logged

.java 3e930ded95b5b975373d1035be61bf8360a45807 lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 8fdde1d60094815b96766a71003b7d0f44ffcd04 Diff: https://reviews.apache.org/r/42599/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

Diff: https://reviews.apache.org/r/42022/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

Diff: https://reviews.apache.org/r/42022/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

Diff: https://reviews.apache.org/r/42022/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42653: LENS-928 : DELETE request on /resultset API gives 500 in case of InMemory Result

/QueryExecutionServiceImpl.java (lines 2085 - 2087) <https://reviews.apache.org/r/42653/#comment176907> Are you able to reproduce the issue? Can you add test cases? - Rajat Khandelwal On Jan. 22, 2016, 7:28 p.m., Deepak Barr

Re: Review Request 42707: LENS-927 : Fix intermittent test failure due to alias look up in JoinTree

/JoinClause.java <https://reviews.apache.org/r/42707/#comment177058> The comment is not valid now? - Rajat Khandelwal On Jan. 25, 2016, 11:34 a.m., Amareshwari Sriramadasu wrote: > > --- > This is an automatically generated e

Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42703/#review116066 --- Ship it! Ship It! - Rajat Khandelwal On Jan. 25, 2016, 10

Re: Review Request 42703: Clean unaccessed InMemoryResultSet intances form server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42703/#review116068 --- Ship it! Ship It! - Rajat Khandelwal On Jan. 25, 2016, 10

Re: Review Request 42707: LENS-927 : Fix intermittent test failure due to alias look up in JoinTree

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42707/#review116067 --- Ship it! Ship It! - Rajat Khandelwal On Jan. 25, 2016, 12

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

/parse/TestBaseCubeQueries.java 57a15e23a39cf09e1f167740083b43bb154334eb Diff: https://reviews.apache.org/r/42070/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 42715: LENS-933: Allow presubmit hook to throw LensException

/browse/LENS-933 Repository: lens Description --- Diffs - lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java 70d999a00c0336887a8256435f2a2b9c764295f8 Diff: https://reviews.apache.org/r/42715/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

Diff: https://reviews.apache.org/r/42022/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

f this number needs to changed Updated to fail late - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42022/#review116083 --- On Jan

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

Having clauses should be pushed down to corresponding fact queries. > > Should not be converted to where clause. > > Rajat Khandelwal wrote: > Right now we have correctness issue. Push down of having clause has > certain requirements: > > 1. The entire boolean

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

/parse/TestBaseCubeQueries.java 57a15e23a39cf09e1f167740083b43bb154334eb Diff: https://reviews.apache.org/r/42070/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42022: LENS-912: Make `cube` keyword optional in queries

Diff: https://reviews.apache.org/r/42022/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

221272line186> > > > > Why is it catching LensException ? Removed. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42070/#review116536 ------

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

/parse/TestBaseCubeQueries.java 57a15e23a39cf09e1f167740083b43bb154334eb Diff: https://reviews.apache.org/r/42070/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

7e3a0bfa703d27f38c5b2a5935d7d2da07125b7c lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 57a15e23a39cf09e1f167740083b43bb154334eb Diff: https://reviews.apache.org/r/42070/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42909: LENS-920 : Fix reading and writing for json input and output in all API

+1 pom.xml (lines 966 - 968) <https://reviews.apache.org/r/42909/#comment177846> could probably look for other possible exclusins - Rajat Khandelwal On Jan. 28, 2016, 6:10 p.m., Amareshwari Sriramadasu wrote: > > ---

Re: Review Request 42909: LENS-920 : Fix reading and writing for json input and output in all API

> On Jan. 28, 2016, 6:50 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/cube-0.1.xsd, line 692 > > <https://reviews.apache.org/r/42909/diff/1/?file=1224917#file1224917line692> > > > > Seems there are multiple typos. > > Amareshwari Sri

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

/TestBaseCubeQueries.java 57a15e23a39cf09e1f167740083b43bb154334eb Diff: https://reviews.apache.org/r/42070/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42070/#review117195 ------- On Feb. 1, 2016, 6:12 p.m., Rajat Khandelwal wrote: > > --

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/42070/#review113673 ------- On Feb. 1, 2016, 6:12 p.m., Rajat Khandelwal wrote: > > --- > This is

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

Can you explain whats happening here? > > > > HQLParser.getString() is a costly operation on AST, should be called > > sparingly. > > Rajat Khandelwal wrote: > Trying to figure out whether the ast is in the select tree or not. So two > trees have to be traversed

Re: Review Request 42070: LENS-813: For multifact queries, having clauses are getting added to both sub queries.

------- On Feb. 1, 2016, 6:12 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42070/ > --

<    1   2   3   4   5   6   7   8   9   10   >