Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Yes, you have to give to get. In this case give up the viewpoint and get the compromise. Unfortunately, that goes for *everybody*, not just the one, as a compromise is something everybody can live with. If only viewpoints are brought forward, the only thing we can say is: 'we agree to disagree'.

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Hi All The initiative to setup a unified commit message was to help reduce the workload Michael has to do each month to compile the blog. We are a community and we want to work together and help each other. All the time we try very hard to reach consensus but sometimes that isn't possible, so

Re: Put "Reverts" in the commit template?

I think I identified another token and I want to call it "Update" At https://cwiki.apache.org/confluence/display/OFBIZ/From+Ant+to+Gradle we show the content of the main README.md file in HTML format (Confluence does not render directly the Markdown format) For that at the moment we (I

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Le 22/09/2016 à 18:06, Michael Brohl a écrit : Hi Rupert, Jacques, all, if I search Google for it, I find many different opinions. For example, here is a viarant from the Git documentation

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

are a worldwide community, please keep communication as simple as possible. Good morning comrade everybody, Shi Jinghai -邮件原件- 发件人: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com] 发送时间: 2016年9月22日 23:07 收件人: dev@ofbiz.apache.org 主题: Re: Commit template, more flexibility [was Re: Put "Re

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com] 发送时间: 2016年9月22日 23:07 收件人: dev@ofbiz.apache.org 主题: Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?] Scott, Reading your message I guess you did not read my previous explanation on why I pre

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

On Thu, Sep 22, 2016 at 5:21 PM, Rupert Howell wrote: > Hi yes, reading with interest, I agree with Jacques. > Commit messages should be Present Tense Imperative, Imperative Style. > well, now I am a bit confused because Jacques is using Present Tense in Third Person

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Michael, Thanks for calling the conversation stupid, you could have refrained on this :/ For the rest I'm done, I tried to put a bit more of flexibility in this template, but since nobody cares (apart Rupert, thanks!), let it be. Now you ALL must comply... -0 (minus zero) Jacques Le

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Hi Rupert, Jacques, all, if I search Google for it, I find many different opinions. For example, here is a viarant from the Git documentation http://git.kernel.org/?p=git/git.git;a=blob;f=Documentation/SubmittingPatches;h=ece3c77482b3ff006b973f1ed90b708e26556862;hb=HEAD "the body should

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Hi yes, reading with interest, I agree with Jacques. Commit messages should be Present Tense Imperative, Imperative Style. There's plenty of links on Google as to why this is the widely adopted industry standard. On 22 September 2016 at 16:06, Jacques Le Roux

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Scott, Reading your message I guess you did not read my previous explanation on why I prefer to use present instead of past. You may find more details in digging in previous emails. But long story short, I'm French so I can't compete in English with someone like you for who English is the

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

I can't believe you're being so stubborn about something so minor Jacques, it seems like very strange behavior to me. For what it's worth as a native English speaker, reading a commit message written in present-tense feels very strange to me. I'm looking at a history and reading something as

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

On Thu, Sep 22, 2016 at 9:36 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Jacopo, > > I saw you answered on Confluence where I 1st asked > https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+ > commit+message+template?focusedCommentId=65871637#comment-65871637 > > Now, I

Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

Jacopo, I saw you answered on Confluence where I 1st asked https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+commit+message+template?focusedCommentId=65871637#comment-65871637 Now, I understand that we need to pick a word, but why not being more flexible, similarly at what does

Re: Put "Reverts" in the commit template?

I have answered you in the Wiki but quoting here for everyone's convenience: "Jacques, for me it is a done deal! As you suggests we could change: - Documentation --> Documented - Fix for --> Fixed And the final list of verbs will be:

Re: Put "Reverts" in the commit template?

Hi Jacopo, What is the logical behind this? It's not the first time I ask and I'd really like to have a clarification. We have "Fix for" and "Documentation". Why not "Fixed" and "Documented"? Thanks Jacques Le 21/09/2016 à 19:09, Jacopo Cappellato a écrit : I have changed it to "Reverted"

Re: Put "Reverts" in the commit template?

I have changed it to "Reverted" for consistency reasons. Jacopo On Wed, Sep 21, 2016 at 7:01 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Done > > Jacques > > > Le 18/09/2016 à 11:19, Jacques Le Roux a écrit : > >> Hi, >> >> In some cases we need to revert a commit done for a

Re: Put "Reverts" in the commit template?

Done Jacques Le 18/09/2016 à 11:19, Jacques Le Roux a écrit : Hi, In some cases we need to revert a commit done for a Jira after we discover it causes an issue. We have not yet other means that using the fix word. I suggest we put in the "Reverts" (or "Revert for" or "Reverted" as it please

Re: Put "Reverts" in the commit template?

Hi Jacques, I don't know what to say. What I understand is that you don't want to use the template that committers are now abiding by and which you agreed on yourself before saying "I changed my mind"! I don't remember having any discussion beyond a few complaints inside your own commit messages.

Re: Put "Reverts" in the commit template?

Le 18/09/2016 à 17:48, Taher Alkhateeb a écrit : Sure let's add reverts, but can we also agree on a unified format? I still see Jacques using present and others using past which makes the original purpose of the unification unattainable (to automate reports). "(to automate reports)" :-o Are

Re: Put "Reverts" in the commit template?

Sure let's add reverts, but can we also agree on a unified format? I still see Jacques using present and others using past which makes the original purpose of the unification unattainable (to automate reports). I also see different levels of support for text width from different committers On

Re: Put "Reverts" in the commit template?

+1 Michael Am 18.09.16 um 11:19 schrieb Jacques Le Roux: Hi, In some cases we need to revert a commit done for a Jira after we discover it causes an issue. We have not yet other means that using the fix word. I suggest we put in the "Reverts" (or "Revert for" or "Reverted" as it please

Re: Put "Reverts" in the commit template?

Also what do we do when we fix an issue introduced by a still open improvement Jira? I use "Improves" because even if it's a bug it the continuity of an improvement, and anyway we can't add unlimited cases in the commit template (I'm sure we will find other edge cases) Jacques Le

Put "Reverts" in the commit template?

Hi, In some cases we need to revert a commit done for a Jira after we discover it causes an issue. We have not yet other means that using the fix word. I suggest we put in the "Reverts" (or "Revert for" or "Reverted" as it please you) word in the commit template for this reason. Because it's a