Re: [foreman-dev] 1.12 branched
On 06/06/16 07:59, Tomas Strachota wrote: > On 06/01/2016 09:04 AM, Tomas Strachota wrote: >> On 05/31/2016 05:02 PM, Dominic Cleal wrote: >>> On 31/05/16 15:03, Dominic Cleal wrote: >>>> In preparation for the first 1.12 release candidate, I've branched the >>>> develop branch on these repos to 1.12-stable: foreman, smart-proxy, >>>> foreman-installer, foreman-selinux, community-templates, >>>> foreman-packaging. >>>> >>>> I'd like to be able to release RC1 in the next week or so, and would >>>> love some help to get the following items complete: >>>> >>>> 1) Fixing regressions in 1.12: >>>> http://projects.theforeman.org/projects/foreman/issues?query_id=99 >>>> https://github.com/theforeman/foreman/labels/1.12.0 >>>> >>>> 2) Documenting 1.12 changes - we've got lots of Puppet and smart proxy >>>> changes to document in this release. The full task list is at: >>>> https://github.com/theforeman/theforeman.org/issues/555 >>>> >>>> 3) Installer releases - we need to start releasing new major/minor >>>> versions of our installer modules to the Forge. I think they're mostly >>>> ready. >>> >>> 4) Hammer CLI releases - currently we'll be shipping Hammer CLI 0.6.1 >>> with 0.6.2 of hammer_cli_foreman, but if a new version could be cut from >>> master if there's something to release, these can be updated. >> >> There are some changes worth releasing. I'll do 0.7 this week. >> > > The hammer 0.7 had to be postponed a bit due to this regression: > http://projects.theforeman.org/issues/15257 > > I hope this will get fixed this week. I'd still like to release 0.7 for > the Foreman 1.12. No worries, thanks for the update. RC1 should be out today or tomorrow, so RC2 would be in a further 1.5 to 2 weeks, giving you some time. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Drop support for Ruby 1.9.2 in smart proxy
I'd like to drop support for testing Ruby 1.9.2 in the smart proxy, primarily because we're getting intermittent segfaults on it during tests. We used to have some platforms (such as Debian Squeeze, IIRC) that shipped 1.9.2 but we no longer support them. Puppet also didn't support it officially as 1.9.3 contained lots of fixes. 1.8.7 support would remain, so we'd have 1.8.7, 1.9.3, 2.0.0 and up. Any objections? -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Drop support for Ruby 1.9.2 in smart proxy
On 07/06/16 13:20, Dominic Cleal wrote: > I'd like to drop support for testing Ruby 1.9.2 in the smart proxy, > primarily because we're getting intermittent segfaults on it during tests. > > We used to have some platforms (such as Debian Squeeze, IIRC) that > shipped 1.9.2 but we no longer support them. Puppet also didn't support > it officially as 1.9.3 contained lots of fixes. > > 1.8.7 support would remain, so we'd have 1.8.7, 1.9.3, 2.0.0 and up. I've removed 1.9.2 from the matrix. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Merge foreman-bats into Forklift
On 23/05/16 21:48, Ewoud Kohl van Wijngaarden wrote: > Hello all, > > With katello-deploy being renamed to Forklift[1], I was wondering if we > should merge foreman-bats into it. The benefit would be that it already > contains some bats tests for Katello and if it's going to be the tool to > deploy a development env or test env, it's a logical fit for all our > system tests. > > Thoughts? I'd prefer to keep foreman-bats where it is, I don't want to mix it with development tools or plugins. foreman-bats serves a limited purpose well right now. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Nominating Timo Goebel for theforeman/foreman commit access
On 02/06/16 15:47, Daniel Lobato Garcia wrote: > Hi devs, > > I'd like to nominate Timo Goebel (timogoebel on Github & IRC) for commit > access to theforeman/foreman repo. > > He's been contributing to the puppet modules, community-templates, bootdisk > and Foreman for some time, particularly on the VMWare/vsphere side of things. > He's been running Foreman on production for years already and gave > local talks about it.(www.meetup.com/AWS-Meetup-Karlsruhe/events/229036956/) > > Most importantly and the reason why I thought of him as a person that > could become a committer is his involvement on ipv6 support lately, > where he's been submitting consistently good code. > > I think he understands very well the problem domain, and he will be > committed to maintain and improve the code quality of the project, as > well as providing good feedback from a production installations. > > Some examples of his contributions: > > https://github.com/theforeman/foreman/pull/3420 > https://github.com/theforeman/foreman/pull/3424 > https://github.com/theforeman/foreman/pull/3498 > https://github.com/theforeman/foreman/pull/3499 > https://github.com/theforeman/foreman/commit/5131edbfab258c0862c987f238049ee81a1cd13f > https://github.com/theforeman/foreman/commit/8ca6c6bbc5242c29a8039d1e6a1d09d1a454164c > https://github.com/theforeman/foreman/commit/2328beb569d3f0e51043202d3a00a3b30879d244 > https://github.com/theforeman/puppet-puppet/pull/389 > https://github.com/theforeman/foreman_bootdisk/pull/19 > > Lastly I'd encourage him to start reviewing already! > > Objections or comments in private are welcome, but public replies to this > thread are preferred :) Yep, I definitely agree. Please let me know in a week what the outcome is. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: OpenPGP digital signature
[foreman-dev] Security fix help requested - orgs/locations issue #15268
A security issue in access to orgs/locations has been filed, which doesn't take the user's associated taxonomies into account in both UI and API actions. Could somebody help write a patch to fix it? http://projects.theforeman.org/issues/15268 is the ticket. It probably needs resource scopes for indexes and regular actions overriding in both controllers, or similar. Thanks! -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Jenkins Email Notifications
On 25/05/16 16:35, Eric D Helms wrote: > There was a period of time where Jenkins was sending email notifications > when the email notifier was configured for a job. A few of us have > noticed that this seems to have stopped at some point and does not > appear to be being eaten by spam filters. > > Does anyone that works with the infrastructure have insight into why > this might have stopped and how we fix it? The server's maillog was showing refusals as the source address was an unknown domain. I've tried to change this in Jenkins settings to nob...@ci.theforeman.org so it resolves, and I'm receiving the test notifications with that address. Could you try that? -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Merge foreman-bats into Forklift
On 25/05/16 17:25, Ewoud Kohl van Wijngaarden wrote: > On Wed, May 25, 2016 at 10:38:04AM -0400, Stephen Benjamin wrote: >> I can understand separating it from development tools, so what about moving >> Katello's bats to foreman-bats? > > What would then be the primary way of getting the latest bats tests? A > script to clone the foreman-bats repository? Assuming you just want to get foreman-bats to use its helpers then yes, just clone the repo and they should be usable. Freight does something similar to use another library of BATS helpers (https://github.com/freight-team/freight/blob/master/Makefile#L88). Else you could use a submodule/tree to stay with a particular version. The helpers could always be moved into their own repo if necessary. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] 1.12 branched
In preparation for the first 1.12 release candidate, I've branched the develop branch on these repos to 1.12-stable: foreman, smart-proxy, foreman-installer, foreman-selinux, community-templates, foreman-packaging. I'd like to be able to release RC1 in the next week or so, and would love some help to get the following items complete: 1) Fixing regressions in 1.12: http://projects.theforeman.org/projects/foreman/issues?query_id=99 https://github.com/theforeman/foreman/labels/1.12.0 2) Documenting 1.12 changes - we've got lots of Puppet and smart proxy changes to document in this release. The full task list is at: https://github.com/theforeman/theforeman.org/issues/555 3) Installer releases - we need to start releasing new major/minor versions of our installer modules to the Forge. I think they're mostly ready. Packaging repos are also now copied from nightly to 1.12, though we can't build new plugins for 1.12 until RC1 builds are available. I've frozen the 1.9 plugin repo so we maintain only nightly plus the three stable repos from 1.10 onwards. Cheers, -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Jenkins restarted
I've restarted Jenkins, which may have lost track of any builds that were in progress at the time - sorry! Please re-test any PRs affected. The JVM heap usage was getting quite critical and as it's sized a little over the amount of physical RAM on the VM, the GC was causing heavy swapping, causing the UI to become unresponsive. I've added a regular scheduled safe restart now at around 3am UTC to help keep it in check and will look at moving it to a bigger VM soon with more heap if that doesn't help. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Plugins to be removed from RPM repos for 1.12
On 21/04/16 13:37, Lukas Zapletal wrote: >> Thanks, I've added you to the ABRT team so you've now got commit rights. >> At a glance it looks like master might be compatible, but it probably >> needs testing at least, and a release cut. >> >> If you can let me know which e-mail address you use for rubygems.org >> then I can add you to the two gems. > > I've fixed the plugin for Rails 4.2: > > https://github.com/theforeman/foreman_abrt/pull/9 > > and also fixed another incompatibility with recent changes in Smart > Proxy core: > > https://github.com/theforeman/smart_proxy_abrt/pull/7 > > Tested with develop branches. It looks like the changes may be released, so please also update the packages if you wish to keep them maintained. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Foreman (core) support for Ruby 1.9.3 has ended
Please note that support for Ruby 1.9.3 has been dropped in Foreman core's develop branch. Versions 2.0, 2.1, 2.2 and 2.3 are supported and make up the new test matrix. Other sub-projects such as the smart proxy are unaffected. You'll likely see an error installing google-api-client if you're still using 1.9.3, so you should change Ruby versions. Gem::InstallError: google-api-client requires Ruby version ~> 2.0. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Removing Fedora 19 from Koji
I'd like to remove the Fedora 19 external repos from Koji to make room for 24. I see that Katello and Pulp both have nightly fedora19 build targets - are they still used, or can I delete it? -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Deprecate EL6?
On 28/07/16 13:08, Ewoud Kohl van Wijngaarden wrote: > On Thu, Jul 28, 2016 at 06:48:07AM -0400, Stephen Benjamin wrote: >> 2 users yesterday at the meet-up in DC specifically asked about this, and >> were rather surprised by the decision. They have some long-running instances >> of Foreman and they want to have more time to get them off EL6, and >> continuing >> to get updates (esp. security issues) was important for them. Considering >> 75%+ of Foreman users run on EL, it's no surprise EL6 still makes up a big >> part of the user base. > > I believe that at the Nuremburg meetup there were a few users on EL6 as > well, but they mostly cared about supporting EL6 clients (through > provisioning) which will be supported for a long time. > > That said, I believe security updates are the most important to them so > you could consider supporting the last release on EL6 a bit longer. I > don't know how much of a time/effort difference that makes compared to > supporting it longer on the newest release. Yeah, I can certainly try for a bit longer if it's useful to people, though help doing the backports may be appreciated when we get there. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: OpenPGP digital signature
Re: [foreman-dev] Deprecate EL6?
On 10/05/16 10:26, Dominic Cleal wrote: > I'd like to propose a deprecation of EL6 for Foreman 1.12, so we have > the option of leaving it out of the 1.13 release. I've stopped nightly EL6 builds now and will remove the yum repos shortly too. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Deprecate EL6?
On 26/07/16 14:13, Eric D Helms wrote: > > > On Tue, Jul 26, 2016 at 4:46 AM, Dominic Cleal <domi...@cleal.org > <mailto:domi...@cleal.org>> wrote: > > On 10/05/16 10:26, Dominic Cleal wrote: > > I'd like to propose a deprecation of EL6 for Foreman 1.12, so we have > > the option of leaving it out of the 1.13 release. > > I've stopped nightly EL6 builds now and will remove the yum repos > > shortly too. > > > I would like to ask that we put a hold on this change without some > further discussion. This comes as a bit of a surprise (at a minimum a > warning similar to branch warnings would have been nice) given the > conversation herein where there was equal sides for and against this > change. I do not consider the line in the release notes sufficient for > this kind of change given the scale and scope it imposes. The release > notes also do not indicate which release users should prepare for this > change, simply that it will be that way in future releases. The warnings section of the release notes state that EL6 packages will likely not be provided in 1.13, but I'll update them now to state clearly that they won't, with pointers to our existing migration information. This can certainly be expanded with more help if somebody wishes to write it, and there's plenty of time to do that in. I don't think I've done anything differently to previous OS deprecations and removals, which seem to have gone without incident. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] "Team AL-GTD - 1" deleted
I've deleted the the "Team AL-GTD - 1" version that somebody had added to the Foreman project in Redmine, as it's project-wide and so is set on every issue. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Foreman core, avoid merging
On 10/08/16 12:20, Dominic Cleal wrote: > I'd caution against anybody merging to Foreman right now, as functional, > integration and lib tests aren't running and are failing quietly. > > http://projects.theforeman.org/issues/16046 contains more info. This should be fixed now. If PRs were updated today, you may want to rebase/re-test them in case the full suite didn't run. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Slave disk space errors
A number of Jenkins test jobs will have failed within the last hour or so due to slaves running out of disk space. This is mostly due to large node_modules directories causing job workspaces to expand rapidly. I've deployed a fix to clean them up and have freed space on slaves so jobs should be back to normal. Please re-run any that failed for space reasons. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] List moderation "always allow posts" errors
Are any other list moderators (of either -dev or -users) getting the following errors when allowing the current plus future posts from a user? "One message has been posted. Failed to always allow posts from u...@example.com due to errors." This seems to be occurring every time for me and is increasing the amount of moderated messages significantly. If it's affecting others then I'll try getting some help from Google Groups. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] systest_katello not destroying VMs
Could somebody look at the systest_katello job on Jenkins please? It doesn't appear to be destroying VMs once the job completes. The job script has a trap set up to call vagrant destroy, but this appears to error: + exit 0 + vagrant destroy There are errors in the configuration of this machine. Please fix the following errors and try again: vm: * The 'main' provisioner could not be found. ++ vagrant destroy There are errors in the configuration of this machine. Please fix the following errors and try again: vm: * The 'main' provisioner could not be found. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] qpid-cpp-client-devel required on slaves?
On 12/08/16 12:28, Eric D Helms wrote: > Should be good to remove. Thanks, I've removed the Yum repo and the package will be left wherever it's currently installed. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Foreman core, avoid merging
I'd caution against anybody merging to Foreman right now, as functional, integration and lib tests aren't running and are failing quietly. http://projects.theforeman.org/issues/16046 contains more info. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Foreman images and CSS
On 12/07/16 10:56, colm.scan...@gmail.com wrote: > In Foreman i see the images and scss files in ~foreman/app/assets/images > and /stylesheets however the live website seems to be looking in > ~/foreman/public/assets > > Can anyone shed some light on where Foreman is looking for its style and > images and how it compiles them into the public/assets folder to be > viewed in real time? app/assets/ contains the source/original files, and to run the app in the production Rails environment with public/assets/, they're compiled using the rake assets:precompile task. This combines, compresses and minifies the source files. If you're using our packages, this is done at build time and the generated files in public/assets/ are shipped inside the package. If you're running from source, you will run rake assets:precompile manually. It's technically possible to re-run the precompilation on a package installation if you install foreman-assets to get the dependencies, but I'd not recommend it as it'll overwrite, delete and otherwise mess with packaged files. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Foreman images and CSS
On 12/07/16 11:58, colm.scan...@gmail.com wrote: > Thanks Dominic. > > When i run that command i first got an error re spice-html5. After i > installed that gem it went past that stage but now errors at couldn't > find file 'jquery_pwstrength_bootstrap' with type > 'application/javascript' even though i have the gem installed. Any ideas? If you're on a source installation then "bundle install" without excluding the assets group should install all of these dependencies. A package installation provides them through the foreman-assets package. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Missing Labels on Katello project
On 12/07/16 22:25, Eric D Helms wrote: > After the latest merge of code (from myself) to the prprocessor, labels > are not being applied to the katello/katello project. I am guessing > there is an error somewhere being thrown that prevents completion to > that point. Can someone with access to the prprocessor logs please check > them to see if there are errors being thrown? NoMethodError - undefined method `[]' for nil:NilClass: /var/lib/openshift/53be8f9c5973caa7ad000a13/app-root/runtime/repo/redmine/issue.rb:26:in `release' /var/lib/openshift/53be8f9c5973caa7ad000a13/app-root/runtime/repo/app.rb:44:in `block (2 levels) in ' I've pushed a possible fix to handle a missing release field (2cb3b8a), hopefully that'll do the trick. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Setting[:remote_addr] in ip_from_request_env in unattended_controller.rb.
On 17/07/16 18:33, adrian wrote: > Nevermind, I can't push, so here's the diff: If you push your branch to your GitHub fork, you can open up a pull request from the web UI against the original repo. See https://help.github.com/articles/using-pull-requests/ for details. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Out of space on koji.katello.org
The Koji server at koji.katello.org has run out of disk space on the /mnt/koji mountpoint, which is causing build and repo build failures. Is anybody with a knowledge of how it's configured able to free up space on the server? Is it possible to remove any more unsupported OSes (Foreman tags require EL6, EL7, F21 and F24)? I may delete some of the older Foreman release mashes, but it'll free up relatively little space. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] external_node_v2 refactor!
On 19/07/16 18:23, otheus uibk wrote:
> https://theforeman.org/manuals/1.12/index.html#3.5.5FactsandtheENC
> <https://theforeman.org/manuals/1.12/index.html#3.5.5FactsandtheENC>
> briefly describes these functions at the bottom of the section.
>
>
> Thanks for pointing me to the specific doc! The documentation is
> certainly better and more detailed than I expected.
>
> After, I still don't get:
>
> * what SETTINGS[:facts] is for. Here's the comment:
>
> # send facts to Foreman - enable 'facts' setting to activate
> # if you use this option below, make sure that you don't send
> facts to foreman via the rake task or push facts alternatives.
>
> This looks like process_all_facts but for the given certname only. It
> uploads the facts to the #{url} via the mapped hostname, and then
> downloads them from the given certname. What's the use-case here? In
> the docs, :facts is always set to true, but I'm not sure it actually
> does anything most of the time. (that might be just our environment, though)
It doesn't download _facts_, it downloads the ENC output. It should be
uploading facts to Foreman, then retrieving the ENC output that contains
lists of classes, parameters etc in YAML, which may depend on the facts
previously uploaded.
This is the normal fact upload method if the ENC is in use, not using
process_all_facts/push.
> * What is no_env for? I see what it does: it removes "environment" from
> the facts that are *reported*. I see what the documentation says about
> it. The questions are (1) shouldn't this be in SETTINGS? and (2) how
> does the presence force puppet to use a particular environment?
(1) Yes, probably - it pre-dates the settings file.
(2) Agents make two calls to the master during a run that cause the ENC
script to run. The first is an environment ("node") query. If the ENC
script returns an environment then the agent and master will use that
configured environment, ignoring anything the agent has set on the CLI
or in puppet.conf. This allows users to disable that on the Puppet
master by passing --no-environment.
> * Why is the watch functionality incorporated into this script?
> Shouldn't this really be a separate task/script altogether? (I'm
> thinking of partitioning of activities via sudo, for instance)
Perhaps. It's probably just convenience to put them together, given that
this script has all of the code to upload and track facts. If it was
split into many files (e.g. library and binaries) it should probably
also move into a package so it's easier to deploy.
--
Dominic Cleal
domi...@cleal.org
--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Foreman 1.13 branching in a month
Foreman 1.13 will be branched in approximately a month's time for release around October. Schedule: http://projects.theforeman.org/projects/foreman/wiki/Foreman_113_Schedule Issues: http://projects.theforeman.org/projects/foreman/issues?query_id=103 -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] jenkins jobs
On 05/08/16 12:43, pronix pronix wrote: > hello > i want repeat some jenkins jobs on my own infrastructure. > where can i see setting for jenkins jobs? by default they are hidden. > thanks Some are configured via Jenkins Job Builder with config files under https://github.com/theforeman/foreman-infra/tree/master/puppet/modules/jenkins_job_builder/files/theforeman.org. Others you can probably see the commands from the console output. Most are simply running standard rake tasks for tests, and are not doing anything particularly special. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Revamping the news section of the website frontpage - design discussion
On 01/07/16 13:28, Greg Sutcliffe wrote: > On 30 June 2016 at 15:42, Dominic Cleal <domi...@cleal.org > <mailto:domi...@cleal.org>> wrote: > Only the frontpage is fine, especially if there are navigation links > anyway to get through to news, events and whatever else is present on > the site. Not everything needs to be on every page of the site. > > > Out of curiosity, let me invert that then - do you think there is ever a > situation that > would warrant such a banner? No, I can't think of any instances where the news item is that important that it should be placed so prominently. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Development of new plugin - assets
On 04/07/16 03:00, Matthew Ceroni wrote: > I am attempting to develop a plugin. > > The main functionality of the plugin is going to be to automatically set > the Virtual machine network based off the subnet set on the interface > tab. The initial version would just match the name set in the interface > tab to the name of the network on the virtual machine tab. Future > versions might take a config file to set that mapping. > > I believe the change should be pretty simple, just run a javascript > function onchange when the subnet is selected. Therefore I need to > include a new javascript (asset) on the host edit page. I see that > plugins such as foreman_salt and foreman_bootdisk do just that. In my > plugin I created a new asset and created the javascript file. However I > am not sure how to tie that asset to the host edit page. Using the Deface gem (https://github.com/spree/deface) is perhaps the easiest method, which will allow you to inject the following into the page template: <% javascript "foreman_example/your_asset" %> Add deface ~> 1.0 as a dependency to the plugin, then create a file under app/overrides/ containing something like: Deface::Override.new(:virtual_path => "hosts/_form", :name => "foreman_example/js", :insert_before => "erb[loud]:contains(:javascript)", :text => "<% javascript "foreman_example/your_asset" %>") Untested, but the idea is that will match the <%= javascript %> at the top of app/views/hosts/_form.html.erb and insert your own line there. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] qpid-cpp-client-devel required on slaves?
On 15/08/16 17:34, Justin Sherrill wrote: > On 08/12/2016 07:48 AM, Dominic Cleal wrote: >> On 12/08/16 12:28, Eric D Helms wrote: >>> Should be good to remove. >> Thanks, I've removed the Yum repo and the package will be left wherever >> it's currently installed. >> > I believe this is actually required as now seen by the new katello test > failures: > > *00:03:32.077* An error occurred while installing qpid_messaging (0.34.1), > and Bundler cannot > *00:03:32.077* continue. > *00:03:32.077* Make sure that `gem install qpid_messaging -v '0.34.1'` > succeeds before > *00:03:32.077* bundling. > *00:03:32.132* + exit 1 > > The EL6 source is now in the copr qpid repo > (https://copr.fedorainfracloud.org/coprs/g/qpid/qpid/) Restored using that repo for EL6 and base OS for EL7. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Plan for dropping Puppet 3 in the installer modules
On 23/01/17 13:30, Ewoud Kohl van Wijngaarden wrote: > Officially Puppet 3 is already EOL since 1-1-2017. We also know that > both puppetlabs and voxpupuli (our only dependencies) are dropping > Puppet 3 support. > > That said we also know that many of our users are still on Puppet 3 and > upgrading is hard for many. > > My proposal is to deprecate using our modules with 1.15 and drop it in > master for 1.16. Sure, or sooner. I've no desire to maintain Puppet 3 support now as it'll quickly become difficult to use the latest dependencies in the next couple of months. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] [Feature request] Enable visibility of class parameters at hostgoup level
On 16/02/17 11:54, Angel Stoyanov wrote: > Hello, > > Firstly, I've very much like to thank the dev team and all contributors > for making Foreman the excellent piece of software it has become today. > > I'd very much like to see a simple checkbox feature included where [..] This list is for development/technical discussions. Please file feature requests in the issue tracker (Redmine) at http://projects.theforeman.org/projects/foreman/issues/new. More details at https://theforeman.org/support.html#Issuetracker. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Extending the host's otp field for Active Directory offline join
On 19/08/16 10:43, Andreas Rogge wrote: > Hello Everyone, > > we're looking into deploying Windows workstations and servers with > theforeman. > Happily there's already something that supports realms (right now only > FreeIPA). Having had a look at the API I guess it should be quite > straightforward to add another provider for Active Directory using DJoin > (the Active Directoy Offline Join tool). > The only issue I see is that the host's otp field in the database is > limited to 255 chars whereas DJoin produces a quite large base64 encoded > blob. > As the length of that blob is not documented anywhere I guess it may > differ from domain to domain and from Windows version to Windows version. > > So here's my request: can we please upgrade the host's otp field to > store an arbitrary length string? Sure, it's best if you just submit a new database migration to Foreman to fix it. There are examples of DB migrations in db/migrate/, e.g. db/migrate/20120607074318_convert_params_to_text.rb which changes some columns to text types. https://theforeman.org/contribute.html has info on submitting pull requests, and installing a dev environment to try it in. http://guides.rubyonrails.org/active_record_migrations.html#creating-a-standalone-migration has more information on database migrations in Rails. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: OpenPGP digital signature
[foreman-dev] Testing for deprecations
develop now contains the as_deprecation_tracker test dependency to track known deprecation warnings. This helps prevent new code being committed that depends on deprecated functionality, and will warn you (by failing tests) of existing usage that becomes deprecated, either by Rails or Foreman. It's disabled for plugins, but there's now information on the wiki for any developer who wishes to enable and use it there: http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin#Testing-for-deprecations -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Requesting 1-2 week branch warning
On 23/08/16 21:05, Eric D Helms wrote: > I'd like to request a 1-2 week branch warning for 1.13 (future releases > would be great too). The month warning is great for helping finalize > priorities. On top of that, I think having a 1 week warning with the > date would help developers work to wrap up anything they are working on > and begin planning plugin release tasks in congruence with the Foreman > release. Consider this your two week warning then! Watching http://projects.theforeman.org/projects/foreman/wiki/Foreman_113_Schedule is a good idea - every release is linked from the dev resources, and usually from my announcements. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] PR test maintenance on Foreman tomorrow
I intend to make some disruptive changes on the PR tests running on the main Foreman repository tomorrow (Sat 3rd Sept), so please wait if you wish to open or update PRs that day. This should improve performance when many PRs are queued. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Jenkins slaves not responding
On 31/08/16 08:33, Dominic Cleal wrote: > On 30/08/16 16:24, Eric D Helms wrote: >> I'd like to propose adding the Jenkins Pipeline plugin as a way to help >> reduce load through number of jobs [1]. [..] >> >> [1] https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Plugin > > I'll install the plugin at the next maintenance opportunity. The plugin is installed now. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Fwd: [Transifex] The source content of a resource in the project Foreman has been updated
If you're receiving regular notifications about foreman_cockpit/hammer_cli_foreman_admin resources being updated in Transifex, then please ignore them for now. They're aware of the issue and are working on a fix soon. Dominic Forwarded Message Subject:[Transifex] The source content of a resource in the project Foreman has been updated Date: Tue, 06 Sep 2016 08:55:32 - From: Transifex <ad...@transifex.com> To: domi...@cleal.org Transifex Notification Hi Dominic Cleal, The source content of the resource foreman_cockpit of the project Foreman has been updated. -- The Transifex Robot -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] 1.13 being branched
On 06/09/16 14:29, Dominic Cleal wrote: > 3. Koji tags are copied from nightly to 1.13 tags, rpm/develop branched > to rpm/1.13. I'll copy the Debian repos shortly and branch that too. Debian repos are complete as well now. As usual in the branching to RC1 period, we don't have any builds of Foreman itself in the 1.13 repos, so plugin releases due for 1.13 will need building once RC1's ready. I created https://github.com/theforeman/foreman-packaging/milestone/2 to help keep note of these. > 5. Core projects will be branched shortly, probably at their current > revisions. All four branched to 1.13-stable now. I've also updated the schedules for 1.13 and 1.14 (three months from now), and will list any issues that will block the 1.13.0 RCs: http://projects.theforeman.org/projects/foreman/wiki/Foreman_113_Schedule http://projects.theforeman.org/projects/foreman/wiki/Foreman_114_Schedule There are also open tickets in Redmine with the 1.13.0 release set where they appear to be regressions against 1.12, so please keep an eye on these and help out where possible: http://projects.theforeman.org/projects/foreman/issues?query_id=103 -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Redmine repo sync config changed
I've made some changes to the prprocessor and Redmine repo syncing configuration which should make it easier to add and configure GitHub repos for Redmine projects. The list of repos and projects is now centralised in https://github.com/theforeman/prprocessor/blob/master/config/repos.yaml, which anybody can change via a PR to the repo. This list contains both the project that the repo should be linked to (so issues are automatically associated to commits and closed) and the config for whether to enforce commit messages styles with mandatory Redmine ticket numbers, plus some other behaviour settings. Previously the list of synced repos was held in theforeman/redmine and the list of repos with commit message enforcement in theforeman/prprocessor. The Redmine hourly sync script now loads the list of repos/projects from the prprocessor API, syncs the repos and configures the Redmine projects. Please let me know if you see any new issues with repo syncing or prprocessor hooks (e.g. labelling). -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Setting.EXAMPLE deprecated
The name-based accessors for settings at Setting.EXAMPLE and EXAMPLE= have been deprecated in develop for removal in Foreman 1.16. If you use this in a plugin, please change it to Setting[:EXAMPLE] which is available in all current releases. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Re: Cannot select salt states
On 05/10/16 09:39, lakier wrote: > Thanks, will check this. > I don't insult you so why you say this? moreover I also offer you my help... > But as a open-source project owner/maintaner you should provide at least > some up-to-date documentation for newcomers to quickly dive in. There is a lot of documentation available, and we do try to keep it up to date. For foreman_salt, the best documentation is on the main website at https://theforeman.org/plugins/foreman_salt/7.0/index.html (for 7.0, used with 1.13). It recommends to use the installer as this will install the packaged version of the plugin and will take care of any necessary configuration. I'd suggest only using source installation instructions for plugins if you're installing onto a source installation of Foreman too, else you'll hit the asset compilation issue and you also need to worry about migrating the database etc. Less so with the Debian packages, but our packages aren't really designed with mixing in mind - both for Foreman and the smart proxy. There are instructions at https://theforeman.org/manuals/1.13/index.html#3.4InstallFromSource for installing a production version of Foreman from source, and at https://theforeman.org/contribute.html for a development installation from source. Stick with packages unless you have good reason to change. Please file bugs in Redmine, or better, pull requests to https://github.com/theforeman/theforeman.org if the docs are incorrect or outdated. Thanks. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Changes to PR tests on Foreman repo
On 03/09/16 14:02, Dominic Cleal wrote: > I've changed the PR test jobs in Jenkins for the main Foreman repo > (theforeman/foreman) to try and improve performance. You'll see that PRs > now receive "foreman", "upgrade" and "katello" test statuses, replacing > "default". > > The old [test] phrase changes to the following commands: > > 1. "[test foreman]" or "[test upgrade]" to re-test a PR that has failed > tests (as always, use this sparingly please) > 2. "ok to test" to run tests for an unknown user, if the patch is not > malicious (the plugin will unfortunately add three comments to ask, one > per test) > 3. "add to PR whitelist" to always run tests from a trusted user > > If you forget, they're on the wiki at > http://projects.theforeman.org/projects/foreman/wiki/Jenkins#Quick-reference-for-maintainers. > > Aside from these cosmetic changes, the tests should work identically to > before. There have been some test failures occurring when the base branch (develop) has been updated while the tests are queued in Jenkins, you'll see these as git checkout failures. This happens because the PR merge commit changes and original SHA is no longer available from GitHub. I've changed the job configurations now to test the PR commit _only_ and not the merge commit, which should ensure they always work. If there are changes in develop that you want to test a PR with, please ask the author to rebase it. Note that this also matches how other PR tests (such as Travis CI, Hound) already work. I will probably try and restore the original merge behaviour in future. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Rails 5.0 compatibility help wanted
I've been working a little on making Foreman compatible with Rails 5.0, starting with running the test suite, but I could do with some help as there are a lot of tasks. (I am not in any way proposing migrating Foreman to use Rails 5.0 now.) Some fixes are written and can be tidied for PRs to develop, others still need work, and some need work in dependencies of Foreman. https://trello.com/b/hZVVli8F/foreman-rails-5-fixes tracks each task, as this is still in a state of development. Tasks are separated into required or optional (i.e. failures vs new 5.0 deprecations) and those that can be fixed in develop or only on Rails 5.0. The "rails5" branch on my GitHub fork at domcleal/foreman is updated frequently with a commit per item. About 20 unit tests currently fail, unknown functional or integration test status. If anybody would like to help, please let me know - I'd suggest picking and self-assigning required items from the board, fixing them on both rails5 and develop, then opening tickets and PRs to Foreman's develop. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] RFC for foreman_api_v3
On 26/08/16 06:58, Joseph Magen wrote: > I created a RFC for a plugin called foreman_api_v3 > <https://github.com/isratrade/rfcs/blob/master/-foreman-api-v3.md> and > the initial repo at github.com/isratrade/foreman_api_v3 > <https://github.com/isratrade/foreman_api_v3>. If the community accepts, > I am happy to move this repo to theforeman/foreman_api_v3 > > I choose to make this a plugin rather than a PR so it is optional for > users and doesn't affect the core code. Please consider calling it something else that won't cause confusion for users with Foreman's own API versioning. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Move rsync to rsync.theforeman.org
Ohad, could you create another CNAME at rsync.theforeman.org to point
back to web02.theforeman.org?
I'd like to begin moving rsync traffic from {apt,downloads,yum} to use a
separate rsync name so it's separate from HTTP(S) traffic, then
eventually we might be able to use a CDN or mirrors for HTTP.
--
Dominic Cleal
domi...@cleal.org
--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Issue #16306 : Need help understanding hammer-cli options config
On 09/11/16 09:42, Swapnil Abnave wrote: > In case of foreman a delete on architecture with --id='' is actually > making an API call which it shouldn't and validate *--id *option prior. > > | > [vagrant@centos7-hammer-devel hammer-cli-katello]$ hammer -s > localhost:3000architecture delete--id='' > Couldnotdeletethe architecture: > 404NotFound > | > > Debug trace for above query: https://da.gd/Q58G > > -- > > I found `class Number` is a normalizer > https://github.com/theforeman/hammer-cli/blob/36419717ad2ea6e012e8a6bb7623258e6e48f009/lib/hammer_cli/options/normalizers.rb#L94 > But not sure how options are defined of that type(Numeric in this case). Foreman's "id" fields are not numeric, they're identifiers which permit either numbers or strings and so the numeric normaliser would not be used automatically. An empty string is of the correct type. The API docs describe the fields as strings but with a human-readable validator description alongside. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Creating a plugin-for-tests (was [foreman-dev] Plugin test failures)
On 07/11/16 15:39, Stephen Benjamin wrote: > The wiki says that public methods will be deprecated and given a chance > to adjust our code in a reasonable time where possible: > > "Foreman will always strive to make no incompatible changes in a minor > release, but be prepared > to make updates on major releases. Where possible, deprecation warnings > will be added for old > public methods before their removal. Warnings will be issued for two > major releases and then the > old method removed in the third release, giving plenty of time to update > plugins." > > I read that as being quasi-official to be able to do alias_method_chain on > public methods No, this means public methods should still be able to be called, not redefined. There's no mention of support for redefining methods via alias_method_chain (or others) in the plugin documentation. There's little Foreman can do if a method is being redefined and is later deprecated in favour of something else, since Foreman would no longer call the deprecated method. The deprecation is only useful when it's called, not modified. > but very often - nearly always - they are not deprecated and > the signature just changes or maybe the method is even removed. It constantly > breaks > my plugin. Be more defensive against signature changes by redefining the method with a splat operator, e.g. def foo(*args) and passing *args to the original method. If arguments with defaults are added, no change is required to the redefined method. > And the plugin API (which itself is a mess given it grows organically and ad > hoc instead > of some team spending time to get it right) is pretty limited if you want > to add on to Foreman objects. Please expand it then, or at least ensure a ticket is filed in the Plugins category in Foreman's issue tracker for the functionality you require. It's good that it's ad-hoc because those are the extensions points that plugin authors have needed, and they can be specifically tested. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Removal of Ruby 1.8.7 in Puppet module tests
I'm updating the Travis CI matrix for our puppet-* repositories in https://github.com/theforeman/foreman-installer-modulesync/pull/40. This includes a proposed removal of Ruby 1.8.7 tests from master (only), matching the majority of our dependencies which have already dropped support, and to reduce the matrix size. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Smart or Foreman Proxy? Let's do Foreman Smart Proxy
On 14/10/16 08:34, Lukas Zapletal wrote:
> Hello,
>
> we have Smart Proxy in the Foreman Core, WebUI/API/CLI and also in our
> Core documentation, but in the installer and package name it's
> foreman-proxy. This creates confusion.
>
> I suggest to "communicate" it from now on with new official name:
>
> Foreman Smart Proxy
>
> This will help us to "teach" our users that this is essentially the same
> thing. The suggested changes are easy and non-intrusive:
>
> * Rename "Smart Proxy" to "Foreman Smart Proxy" in our documentation
> * Rename "Smart Proxy" to "Foreman Smart Proxy" in our codebase
>
> Controller names, API/CLI and internals all stays with "smart-proxy" of
> course, the idea is only to logically connect these terms.
This appears more inconsistent than the current situation, as there will
now be three terms, differing between the UI names ("Foreman Smart
Proxy"), API/module names ("smart proxy"), and package names ("foreman
proxy").
If only the installer module name and package name differ from
everything else, it would make more sense to rename them to "smart
proxy" so all three are the same.
--
Dominic Cleal
domi...@cleal.org
--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: OpenPGP digital signature
Re: [foreman-dev] Issues needed in 1.13.1
On 25/10/16 17:33, Eric D Helms wrote: > Can we please have the following two issues included into Foreman 1.13.1 > via puppet-foreman_proxy release update? > > https://github.com/theforeman/puppet-foreman_proxy/commit/9b75833407377bc08cc821dd9e51f41ef1234f11 Released in 4.0.3. > https://github.com/theforeman/puppet-foreman_proxy/commit/90a98bb918802e7dd155518b8298108c66ca88d0 New classes aren't suitable for a patch release, and I'm not going to create a new minor release now. In future open up pull requests against the stable branches if there's no associated Redmine ticket on the release, and earlier (release was prepared yesterday). -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Foreman 1.14 branching in a month
Foreman 1.14 will be branched in about a month's time (end of November) to be released around January. Schedule: http://projects.theforeman.org/projects/foreman/wiki/Foreman_114_Schedule Open issues: http://projects.theforeman.org/projects/foreman/issues?query_id=112 -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] RoutingError (No route matches [GET] "/mod_status")
On 13/10/16 11:17, Jonathan Del Campo wrote: > Hello, > > We are running theforman 1.11.4 on a centos 6.8. > I very often get this event log in the production.log file, and it seems > to be related to several problems we encountered on performances. Please use the foreman-users mailing list for questions and support, this list is for development discussions only, which this isn't. (http://groups.google.com/group/foreman-users, https://theforeman.org/support.html#Mailinglists) > Do you know if it's due to a known bug or a configuration problem on our > side ? > > / > / > /2016-10-13 12:06:05 [app] [I] Started GET "/mod_status?auto" for > 127.0.0.1 at 2016-10-13 12:06:05 +0200/ > /2016-10-13 12:06:05 [app] [F] / > / | ActionController::RoutingError (No route matches [GET] "/mod_status"):/ This is a request being made against your server, not one that Foreman knows how to handle. It looks like a monitoring system trying to access an Apache mod_status page, check for load balancers or tools such as Nagios & collectd that may be configured to monitor your host. I doubt a 404 response has much impact on performance unless it's very frequent. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Foreman 1.14 deprecations, affects plugins
Foreman 1.14.0-RC1 is now available and deprecates a number of internal APIs that may be used by plugins. See https://theforeman.org/manuals/1.14/index.html#Deprecations for the details. Most are deprecations where support for the old method will remain in 1.14 and 1.15 branches, then will be removed in 1.16. One change (help_path/button UI helper) is being made in 1.14 with no deprecation period, please ensure you update this. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] 1.14 branched
1.14-stable has been branched in all main repositories for the Foreman 1.14.0 release. Sorry for being a week behind schedule (http://projects.theforeman.org/projects/foreman/wiki/Foreman_114_Schedule). I aim to release 1.14.0-RC1 in a week or so once the installer modules are ready, some initial release notes are written and it all looks reasonably stable. RCs of .0 will follow about every two weeks until it's stable enough to release. 1. community-templates is branched - maintainers please cherry-pick fixes to 1.14-stable as you wish and I'll run the sync script on each release of Foreman. 2. theforeman.org 1.14 manual is present - there's a task list at https://github.com/theforeman/theforeman.org/issues/708 and I'd love help with this. 3. Packages and repositories have all been branched. This means that 1.11 plugin repositories are no longer maintained (keeping nightly + three stable branches). 4. Installer modules all need changelogs and to be released. 5. Foreman's POT is now up to date, Transifex should be updated automatically in a day's time. 6. A new Hammer CLI release would be appreciated for inclusion in RC1. 7. Plugin authors should release new versions if necessary for compatibility with 1.14-stable (i.e. if you have fixes for develop, release them now.) 8. Issues are tracked on http://projects.theforeman.org/projects/foreman/issues?query_id=112, please keep it refreshed as it'll change frequently when the RCs are available. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] OpenStack V3 APi Compute Resource Provider
On 05/01/17 18:27, Matthew Ceroni wrote: > However I want to validate that the code still works. Really all that > was needed was to drop in the provider code in > > | > foreman/app/models/compute_resources/foreman/model/openstackv3.rb > > module Foreman::Model > class OpenstackV3 < ComputeResource This filename doesn't look right for the class name - it may need to be openstack_v3.rb (because "Foreman::Model::OpenstackV3".underscore returns "foreman/model/openstack_v3"). [..] > > However, when I do that on Foreman 1.13 I get > > uninitialized constant Foreman::Model::OpenstackV3 (NameError) > > /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_hooks-0.3.12/lib/foreman_hooks.rb:90:in > `load_missing_constant_with_hooks' > /usr/share/foreman/app/models/concerns/fog_extensions.rb:54:in ` (required)>' > > /opt/rh/rh-ruby22/root/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in > `require' > > /opt/rh/rh-ruby22/root/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in > `require' > > /opt/rh/sclo-ror42/root/usr/share/gems/gems/polyglot-0.3.4/lib/polyglot.rb:65:in > `require' > /usr/share/foreman/config/initializers/foreman.rb:12:in ` > > > Which if I am understanding the error correctly means it can't find the > OpenstackV3 class. Yes, the Rails autoloader probably can't find it at the current location. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] scoped_search changed to 4.x
scoped_search was updated to 4.x, which renames a couple of options (:in and :alias). Update them in any plugin targeted only at Foreman 1.15 and beyond. The previous options will continue working and will simply issue warnings. Also note if you're using the "sort" helper with HTML options (unlikely) then they must be given via the :html_options keyword argument instead of the third positional argument. https://github.com/wvanbergen/scoped_search/blob/v4.0.0/CHANGELOG.rdoc contains the full changelog and details. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] undefined method `sub!' for nil:NilClass on foreman 1.14
On 19/12/16 11:13, Karen Harutyunyan wrote: > Hi guys , > > I`m getting "undefined method `sub!' for nil:NilClass" error on foreman > 1.14 when i try to edit host. A lot of forums pointing to ruby 2.2 and > rails > 4.2 so i have successfully installed those requirements but > still getting error . i did not get any similar error at foreman 1.13 The stacktrace would provide more information about what is calling the method, and show you the likely location to fix (particularly if it's a plugin). Otherwise please use the bug tracker and attach the log with the full error message: http://projects.theforeman.org/projects/foreman/issues/new -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Re: 1.15 branching in approximately 2 weeks
On 30/03/17 04:25, Eric D Helms wrote: > foreman-packaging RPMs have been branched to rpm/1.15 and updated per > the release process instructions Where are the 1.15 build targets and tags? -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Nominating Daniel Lobato for commiter to release related tasks
On 25/04/17 12:45, Marek Hulán wrote: > On úterý 25. dubna 2017 9:19:40 CEST Dominic Cleal wrote: >> On 24/04/17 12:59, Marek Hulán wrote: >>> based on our handbook [1]. I'd like to nominate Daniel for commit access >>> to >>> >>> the following repositories: >>> - foreman-infra >>> - foreman-installer >>> - foreman-packaging ( to branch and cherry-pick to the release branch ) >>> >>> Daniel contributes to the project for a long time, also in this area >>> [2][3][4] and always has only the best intentions. He worked on 1.15 RC1 >>> and I think there's no reason why he shouldn't have access to places >>> which are needed to update during the release process. >> These repos all have active maintainers and so making a pull request (as >> Daniel's done on two of them) is a better way to make changes. I don't >> think commit access is necessary to submit updates to these repos and >> shouldn't be encouraged here for Foreman releases. > I'm happy to hear that there are active maintainers. I'm not sure whether you > suggest that it is the reason why commit access should not be granted? I > think > the more active committers the better. Doing this through PR is fine and as > you say, it can find issues. But if other devs send PRs, I think it makes > sense if Daniel can merge them. Commit access is also required to create > branches and tags which I don't think needs any form of reviewing. > > I'm sorry if it seemed like I'm encouraging pushing commits directly without > PR during release process. That was not subject of this nomination. OK, sorry, that's what I thought you were suggesting. In that case, I don't think Daniel's had much involvement with the foreman-infra or foreman-installer projects to warrant commit access. He's opened a lot of PRs against foreman-packaging, but I'd want to see fewer common errors in recent PRs before seconding him for commit access. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Nominating Daniel Lobato for commiter to release related tasks
On 24/04/17 12:59, Marek Hulán wrote: > based on our handbook [1]. I'd like to nominate Daniel for commit access to > the following repositories: > > - foreman-infra > - foreman-installer > - foreman-packaging ( to branch and cherry-pick to the release branch ) > > Daniel contributes to the project for a long time, also in this area > [2][3][4] > and always has only the best intentions. He worked on 1.15 RC1 and I think > there's no reason why he shouldn't have access to places which are needed to > update during the release process. These repos all have active maintainers and so making a pull request (as Daniel's done on two of them) is a better way to make changes. I don't think commit access is necessary to submit updates to these repos and shouldn't be encouraged here for Foreman releases. Reviews have found a few issues, so I'd suggest continuing to submit commits through pull requests. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Is there a way to exclude hosts from the dashboard/reports?
On 03/05/17 11:56, Iain Hallam wrote: > I've got a few hosts that are out of action for a few months, so I'd > expect them to be out of sync. That means they're cluttering up reports > that would otherwise show where I need to find out what's happened. Is > there a way to mark these hosts as "expected to be down" so that Foreman > ignores them for reporting for now? Edit the host, untick "Enabled" under the Additional Information tab. The host will be categorised separately (hosts with alerts disabled). Please use the foreman-users list for usage and installation questions, this list is for development discussions. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Re: 1.15.0 release status
On 11/05/17 02:16, Daniel Lobato wrote: > Thanks, it seems like either I don't understand the combination filter > or it didn't work > (https://github.com/theforeman/foreman-infra/blob/cb03c58b7b2bf3b5c61a125e4c32841a07a6a274/puppet/modules/jenkins_job_builder/files/theforeman.org/yaml/jobs/release_test.yaml#L33) > > combination-filter: 'os == "el7" || os == "f24" || os == "jessie" || > (os == "stretch" && version != "1.14" && version != "1.15") || os == > "trusty" || os == "xenial"' It should have been using major_version, fixed. > http://ci.theforeman.org/job/release_push_deb/ doesn't have a > combination filter so it just publishes to the other 3 repos.(jessie > trusty and xenial). Fixed, added stretch. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] 1.15.0 release status
On 09/05/17 12:04, Daniel Lobato wrote: > Our 1.15 release is almost there! Tagging is done. I kicked off the > release pipeline, which means the first release tarballs are on their way. I guess you don't want Hammer CLI 0.10.2 packages to be merged at this point then - do you want them merged after this release for 1.15.1, or do not include it in the 1.15 series? (There were requests at https://github.com/theforeman/foreman-packaging/pull/1641 and 1638 that would have needed your approval. They also require a number of dependency changes/additions.) -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Migration to Copr POC
On 16/05/17 13:32, Lukas Zapletal wrote: > Delete existing testing Copr repositories in @theforeman Copr group, > it's not shown in the UI who created them but I believe it was Dominic > or Eric: https://copr.fedorainfracloud.org/groups/g/theforeman/coprs/ Those are mine, you can delete them if you need to. I can always re-create them. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Registry anti-pattern
I've written a few notes at http://projects.theforeman.org/projects/foreman/wiki/Registry_pattern about the use of registry-type objects in Foreman that hold global state through class variables or singletons. It lists some of the problems they introduce and some basic notes about how to rewrite/remove them. If you're writing or reviewing code, please look out for them and try to prevent new ones being introduced. This should help prevent new types of test failures, reloading bugs in development and make code more testable. Existing ones remain in app/registries/ until they're refactored, an autoload_once version of app/services/. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] hammer-cli, -foreman version numbers on master
On 05/05/17 14:21, Tomas Strachota wrote: > Is it enough just to bump the version to 0.11-develop or do I need to > do whole new release? Bumping/changing the version number is fine, thanks. -- Dominic Cleal domi...@cleal.org -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
