[Freeciv-Dev] [patch #3327] Ranian nation
URL: http://gna.org/patch/?3327 Summary: Ranian nation Project: Freeciv Submitted by: artaxes Submitted on: Sun 17 Jun 2012 09:39:51 AM CEST Category: rulesets Priority: 1 - Later Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: The Slavic Ranians or Rugians. Flag based on Western Pommeranian with Ranian coat. ___ File Attachments: --- Date: Sun 17 Jun 2012 09:39:51 AM CEST Name: ranian.ruleset Size: 3kB By: artaxes http://gna.org/patch/download.php?file_id=15823 --- Date: Sun 17 Jun 2012 09:39:51 AM CEST Name: ranian.svg Size: 48kB By: artaxes http://gna.org/patch/download.php?file_id=15824 ___ Reply to this item at: http://gna.org/patch/?3327 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3328] Cimmerian nation
URL: http://gna.org/patch/?3328 Summary: Cimmerian nation Project: Freeciv Submitted by: artaxes Submitted on: Sun 17 Jun 2012 09:43:23 AM CEST Category: rulesets Priority: 1 - Later Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: The Cimmerians of Herodotus. Flag based on an ancient figure of horse. ___ File Attachments: --- Date: Sun 17 Jun 2012 09:43:23 AM CEST Name: cimmerian.ruleset Size: 2kB By: artaxes http://gna.org/patch/download.php?file_id=15825 --- Date: Sun 17 Jun 2012 09:43:23 AM CEST Name: cimmerian.svg Size: 16kB By: artaxes http://gna.org/patch/download.php?file_id=15826 ___ Reply to this item at: http://gna.org/patch/?3328 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3329] Lusitanian nation
URL: http://gna.org/patch/?3329 Summary: Lusitanian nation Project: Freeciv Submitted by: artaxes Submitted on: Sun 17 Jun 2012 09:47:07 AM CEST Category: rulesets Priority: 1 - Later Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: The Lusitanians. Flag with Celtic knut from Wikimedia. ___ File Attachments: --- Date: Sun 17 Jun 2012 09:47:07 AM CEST Name: lusitanian.ruleset Size: 1kB By: artaxes http://gna.org/patch/download.php?file_id=15827 --- Date: Sun 17 Jun 2012 09:47:07 AM CEST Name: lusitanian.svg Size: 26kB By: artaxes http://gna.org/patch/download.php?file_id=15828 ___ Reply to this item at: http://gna.org/patch/?3329 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3330] Varangian nation
URL: http://gna.org/patch/?3330 Summary: Varangian nation Project: Freeciv Submitted by: artaxes Submitted on: Sun 17 Jun 2012 09:57:38 AM CEST Category: rulesets Priority: 1 - Later Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: The Varangians or Eastern Vikings of Gardariki. Flag based on Nordic cross (dualistic meaning of this cross who also may indicate a sword), colours of former Russian flag and Odala rune (from Wikimedia) to added pagan character to these people. ___ File Attachments: --- Date: Sun 17 Jun 2012 09:57:38 AM CEST Name: varangian.ruleset Size: 2kB By: artaxes http://gna.org/patch/download.php?file_id=15829 --- Date: Sun 17 Jun 2012 09:57:38 AM CEST Name: gardariki.svg Size: 4kB By: artaxes http://gna.org/patch/download.php?file_id=15830 ___ Reply to this item at: http://gna.org/patch/?3330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19820] Sanity checks for veteran system not as effective as they should be
Update of bug #19820 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_4-veteran-sanitychecks.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?19820 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3322] Resource requirements
Follow-up Comment #3, patch #3322 (project freeciv): Hm, I see what you're saying, but there's no reason it should be limited to a terrain+resource combination. You could reasonably require other combinations of properties on a single tile: terrain, resources, specials, roads, bases, a city, ... e.g., Terrain(Mountains) + Resource(Gold) + Base(Gold mine). So rather than calling this Resource, I think it would be a new universal called something like Tile or TileProperties. Its argument would have a mini expression language for specifying combinations of things (possibly with some disambiguation syntax for the case where, say, a special and a resource have the same name). Off-hand, I don't see any reason in principle why such a thing couldn't be done; I think the most complicated aspect would be for those parts of the system that take apart requirements and try to analyse them, such as the AI (to work out how to meet them) and the on-line help. I think those things suggest that the expression language should only be additive (Lake AND Fish, but not Plains AND NOT Road), at least at first. Covering all tile properties with this is unlikely to be much more work than just Terrain+Resources. However... knowing how much effort we have available, I'm inclined to aim for the simple Resource universal first, because that should be easy and obvious, and gets you some capability before we get round to the complicated thing. ___ Reply to this item at: http://gna.org/patch/?3322 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3323] Allow requirement range within city workable radius for tile-based requirements?
Follow-up Comment #5, patch #3323 (project freeciv): After night's sleep I don't see need for explicit CityTile Range requirement, as tile output effects are only used when tile is within city range (or in case of ai evaluating city placement; it will be within city range once city has been founded) We already have SuperHighways, Colossus, King Richard... ___ Reply to this item at: http://gna.org/patch/?3323 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19817] plrcolormode=PLR_SET and PLR_RANDOM issues
Additional Item Attachment, bug #19817 (project freeciv): File name: trunk-S2_4-playercolor-revamp-bis.diff Size:25 KB ___ Reply to this item at: http://gna.org/bugs/?19817 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3325] Allow custom types for governments to be used in effect requirements.
Follow-up Comment #1, patch #3325 (project freeciv): O.k. I've spent all day working on it and I am starting to get my head around it. I am not messing with requirements yet, just working on getting flags read from the ruleset, stored in the government struct and passed around correctly. In this sense, I think I have finished with ruleset.c and have gotten fair far in fc_types.h, governments.h/c. Could someone look over my in progress ruleset.c and see if I have done anything drastically stupid? As I keep saying, I am not a programmer, but I would love to get this working. (uploaded file to bugtracker) (file #15833) ___ Additional Item Attachment: File name: ruleset.c Size:184 KB ___ Reply to this item at: http://gna.org/patch/?3325 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2876] [lua] files needed for the win32 client if client lua script is added
Update of patch #2876 (project freeciv): Status:None = Wont Do Open/Closed:Open = Closed ___ Follow-up Comment #2: We have client Lua script on S2_4. But the Win32 client is already out of sync with the rest of the project and won't have compiled for several major versions. It's gone from the tarball in 2.5 (patch #2597) and is scheduled to begone from source control in 2.6 (see comments in patch #2700). Hence, closing this as Wont Do. The patch is still here in Gna in the unlikely event that someone needs it. ___ Reply to this item at: http://gna.org/patch/?2876 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3325] Allow custom types for governments to be used in effect requirements.
Follow-up Comment #2, patch #3325 (project freeciv): You remember me, but I've spent months with #1339. Gmake result in SVN (rev. 21329) with your ruleset.c ruleset.c: In function 'load_government_names': ruleset.c:2488:24: error: 'MAX_NUM_USER_GOV_FLAGS' undeclared (first use in this function) ruleset.c:2488:24: note: each undeclared identifier is reported only once for each function it appears in ruleset.c:2494:5: warning: implicit declaration of function 'set_user_gov_flag_name' [-Wimplicit-function-declaration] ruleset.c:2494:28: error: 'F_USER_GOV_FLAG_1' undeclared (first use in this function) ruleset.c: In function 'load_ruleset_governments': ruleset.c:2590:5: warning: implicit declaration of function 'gtype_index' [-Wimplicit-function-declaration] ruleset.c:2592:5: error: 'struct government' has no member named 'flags' ruleset.c:2592:5: error: 'struct government' has no member named 'flags' ruleset.c:2593:5: warning: implicit declaration of function 'gtype_has_flag' [-Wimplicit-function-declaration] ruleset.c:2595:5: error: 'slist' undeclared (first use in this function) ruleset.c:2595:43: error: 'nval' undeclared (first use in this function) ruleset.c:2597:9: error: 'j' undeclared (first use in this function) ruleset.c:2598:7: error: 'sval' undeclared (first use in this function) ruleset.c:2599:16: warning: left-hand operand of comma expression has no effect [-Wunused-value] ruleset.c:2599:16: warning: value computed is not used [-Wunused-value] ruleset.c:2599:16: warning: left-hand operand of comma expression has no effect [-Wunused-value] ruleset.c:2602:7: error: 'ival' undeclared (first use in this function) ruleset.c:2602:7: warning: implicit declaration of function 'gov_flag_by_rule_name' [-Wimplicit-function-declaration] ruleset.c:2604:9: warning: implicit declaration of function 'gtype_rule_name' [-Wimplicit-function-declaration] ruleset.c:2607:9: error: 'struct government' has no member named 'flags' ruleset.c: In function 'send_ruleset_governments': ruleset.c:4339:2: error: 'packet' undeclared (first use in this function) ruleset.c:4339:18: error: 'struct government' has no member named 'flags' ___ Reply to this item at: http://gna.org/patch/?3325 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19582] No GTK3 theme
Update of bug #19582 (project freeciv): Status:None = Duplicate Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19582 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3095] Freeciv theme for gtk3-client
Update of patch #3095 (project freeciv): Summary: Theme for gtk3-client = Freeciv theme for gtk3-client ___ Follow-up Comment #4: We probably want some sort of theme with the Gtk3 client for 2.4.0, if we're pushing Gtk3 as the default (especially in Windows). I think that's the last major missing thing for Gtk3? Is what we've got in this patch, while unfinished, better than having no theme at all? Or would it need work to be worth shipping, even in a beta? I do finally have (occasional) access to a machine with gtk3, but not right this minute, so I can't try it. (Presumably we'll also need to move some of the copy-of-Gtk2-theme stuff left by patch #3050 out of the way as part of this.) ___ Reply to this item at: http://gna.org/patch/?3095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19672] Bright border around the main menu for Sonar dark gtk theme
Follow-up Comment #1, bug #19672 (project freeciv): Bug #18088 is another report of Freeciv run with a system dark theme (rather than its own Freeciv theme) having unexpected bright bits (not exactly the same). Bug #18363 collects woes with Freeciv-with-Freeciv-theme run on a system with another theme (often a dark one). Common theme (haha) is that we could use guidance from someone who understands Gtk theming in detail... ___ Reply to this item at: http://gna.org/bugs/?19672 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18088] Chat tab has white background when using a dark GTK theme
Follow-up Comment #2, bug #18088 (project freeciv): See also bug #19672. ___ Reply to this item at: http://gna.org/bugs/?18088 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3095] Freeciv theme for gtk3-client
Follow-up Comment #5, patch #3095 (project freeciv): With gtk+ 3.4, this theme needs a minor fix: it seems that the background is now tiled, so it looks a bit silly in places, where the grid of tiles shows. Fix is most likely trivial, but I haven't yet found time for it. ___ Reply to this item at: http://gna.org/patch/?3095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19778] National border dashed line of colour green gets confused with grassland tile in trident tileset
Follow-up Comment #2, bug #19778 (project freeciv): While we're collecting things that are wrong with the player colours, see also Debian bug 602562 http://bugs.debian.org/602562 for another reason why white is a bad colour (you can't see city sizes in the SDL client because they're white-on-white). ___ Reply to this item at: http://gna.org/bugs/?19778 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16184] Governor minimal surplus of -20 not low enough
Follow-up Comment #3, bug #16184 (project freeciv): See also Debian bug 659644 http://bugs.debian.org/659644. ___ Reply to this item at: http://gna.org/bugs/?16184 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18243] Client hangs with with gtk+ 2.24.5 (and Ubuntu Oneiric's 2.24.6) and Freeciv theme
Follow-up Comment #35, bug #18243 (project freeciv): So, where are we with this? = Perhaps we can ignore it again = I've checked Ubuntu, and it seems they dropped the troublesome 010_make_bg_changes_queue_repaint.patch from their Gtk2+ packages again -- it's not in their gtk+2.0_2.24.10-0ubuntu6 package, which shipped with Precise and is also their latest revision. (Possibly it was re-reverted in LP #889019 https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/889019.) Also, Ubuntu's Precise and current Freeciv packages no longer contain their GDK_NATIVE_WINDOWS=1 patch. So, there's every reason to hope that freeciv-gtk2 builds from source will work on Ubuntu Precise and later. The troublesome code isn't in the latest upstream gtk2 either (2.24.10). So, perhaps we get away with it, with Ubuntu Oneiric being the only distro where trouble remains (for which a workaround exists). I think I have built and briefly run both the S2_3 gtk2 and S2_4 gtk3 clients on Ubuntu Precise, having forgotten all about this issue, and didn't notice any trouble. So that's encouraging. (But I can't re-test more thoroughly right now.) == Remaining confusion == However, I'm a bit confused by the last conversation here (even though I was involved). There was some hope that patch #2715 would perturb the problem away even in the presence of the troublesome Gtk code. But that patch only affects the gtk3 client. But comment #29 et al suggest that patch #2715 didn't help. For the hard-of-thinking (me), does that imply that you guys have seen this issue with the gtk3 client? I was hoping it was gtk2-specific. (I'm a bit surprised if it does happen with gtk3, given that with the Gtk2 client it required the Freeciv theme, and we don't have a theme for freeciv-gtk3 at all yet -- patch #3095.) = Thoughts on root cause = Obviously it would be even better to understand what's going on, rather than just hoping it goes away. To summarise some stuff from re-reading this bug: * Marko found that it only happens with the Freeciv theme. * He found commenting out bg_pixmap bits of the theme made the issue go away (comment #29). * The troublesome Gtk patch is in functions called gdk_window_set_background() and gdk_window_set_back_pixmap(), which seems very likely to be related to the bg_pixmap part of theming. Those observations seem related. Maybe that helps someone get to the root cause? (I thought the warning 'Unable to locate theme engine in module_path: pixmap' might also be a clue. But after digging, I think that's just a symptom of not having the pixmap engine installed -- package gtk2-engines-pixbuf on Debian/Ubuntu. In particular, I don't think this engine is used for bg_pixmap, despite the name -- I think that's part of the core of Gtk. Inter alia, I've raised Debian bug 677891 http://bugs.debian.org/677891 to make sure the Freeciv package declares a dependency on this package.) ___ Reply to this item at: http://gna.org/bugs/?18243 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17124] Freeciv Gtk client theme looks bad on some installations
Follow-up Comment #4, bug #17124 (project freeciv): Ended up having to educate myself slightly about Gtk theming architecture today. Some starting points in case I get more time to dig into it in future: 1 http://orford.org/gtk/, 2 https://live.gnome.org/GnomeArt/Tutorials/GtkThemes. ___ Reply to this item at: http://gna.org/bugs/?17124 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18232] Cheating AI level should not override max tax rates by default
Update of bug #18232 (project freeciv): Summary: Cheating AI level should not overide max tax rates by default = Cheating AI level should not override max tax rates by default ___ Follow-up Comment #3: Is this likely to happen for 2.4.0? ___ Reply to this item at: http://gna.org/bugs/?18232 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18227] Qt-client configure check test program compilation fails
Follow-up Comment #11, bug #18227 (project freeciv): Is this going to make 2.4.0? The Qt client is only a stub in S2_4, so I wouldn't consider it very important, unless it can screw up ordinary configure even if user doesn't ask for Qt client? ___ Reply to this item at: http://gna.org/bugs/?18227 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18228] Configure does not support Mac OS Framework-style SDL installation
Follow-up Comment #7, bug #18228 (project freeciv): This has a release target of 2.4.0, but I see no evidence of regression compared to S2_3, so since this hasn't moved for a year, I plan to remove that target. ___ Reply to this item at: http://gna.org/bugs/?18228 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18200] Configure does not support Mac OS Framework-style Qt installation
Follow-up Comment #14, bug #18200 (project freeciv): This looks stalled. Since it looks like it only affects the Qt client, which isn't in an interesting state in S2_4, I'm inclined to remove the 2.4.0 release target. ___ Reply to this item at: http://gna.org/bugs/?18200 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18196] gtk2-client - gtk3-client settings migration
Update of bug #18196 (project freeciv): Severity: 3 - Normal = 4 - Important ___ Follow-up Comment #1: We had probably better fix this for 2.4, ideally for first beta (since this is a one-time migration). ___ Reply to this item at: http://gna.org/bugs/?18196 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17859] typo in settings' window
Update of bug #17859 (project freeciv): Status:None = Duplicate Open/Closed:Open = Closed ___ Follow-up Comment #1: Since fixed by patch #3021. ___ Reply to this item at: http://gna.org/bugs/?17859 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17582] [metaticket] Headers depend on config.h
Update of bug #17582 (project freeciv): Planned Release: 2.4.0 = 2.5.0 ___ Follow-up Comment #1: If time runs short, this refactoring can be retargeted to 2.5. Done... ___ Reply to this item at: http://gna.org/bugs/?17582 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
Follow-up Comment #7, bug #16864 (project freeciv): I didn't see this, so in bug #19817 I proposed to stop # being a mandatory part of the /playercolor syntax (it's still accepted). I still don't see any reason to force people to enter a hash, so I think I'm going to stick with that, but the ideas for changing command parsing in this ticket may still be good. ___ Reply to this item at: http://gna.org/bugs/?16864 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17579] Ocean city gfx uses memory many times
Update of bug #17579 (project freeciv):
Status:None = Confirmed
Planned Release: 2.4.0 =
___
Follow-up Comment #2:
I think this is still true.
Looking at tilespec.c:scan_specfile(), there are a couple of things we can do
about this.
First, the tileset loading code already supports a way for multiple tags to
share the same sprite in memory, but it needs explicit markup in the tilespec
file -- you have to put all tags on the same line.
See the following example. I've tested it works, but not that it saves memory.
There are existing examples of this being used.
--- a/data/amplio2/ancientcities.spec
+++ b/data/amplio2/ancientcities.spec
@@ -43,11 +43,7 @@ tiles = { row, column, tag
; used by all city styles
- 2, 11, city.asian_occupied_0
- 2, 11, city.tropical_occupied_0
- 2, 11, city.celtic_occupied_0
- 2, 11, city.classical_occupied_0
- 2, 11, city.babylonian_occupied_0
+ 2, 11, city.asian_occupied_0, city.tropical_occupied_0,
city.celtic_occupied_0, city.classical_occupied_0,
city.babylonian_occupied_0
;
However, that's not great for readability/maintainability of the tilespec
file.
I think it would be a simple matter to create a temporary hash of
small_sprite structures in scan_specfile(), lasting for the lifetime of a
grid_XXX section, and keyed by {row,column,hot_x,hot_y}. That would allow tags
defined on separate lines to share the same graphics data in memory; the above
example should start saving memory with no change to syntax.
All the reference counting and many:1 tag:small_sprite mechanism is already in
place and apparently working.
However, this doesn't seem particularly urgent, so I'm removing the 2.4.0
target.
___
Reply to this item at:
http://gna.org/bugs/?17579
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3095] Freeciv theme for gtk3-client
Follow-up Comment #6, patch #3095 (project freeciv): Well, yes, there's a fix for the mentioned problem and I even managed to fix a couple bugs in the old version independently,... there's a catch though: the fix for gtk+ 3.4 (only for this problem, not those old bugs) is backwards incompatible - 'background-size: cover' got introduced in 3.4 and undefined property means whole theme not getting applied. 2 files this time: updated gtk.css and paired menubar.css (perhaps I should just put it in one file, but whatever...). (file #15834, file #15835) ___ Additional Item Attachment: File name: gtk.cssSize:4 KB File name: menubar.cssSize:0 KB ___ Reply to this item at: http://gna.org/patch/?3095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7599] Windows packages for 2.4.0-beta1 (placeholder)
URL: http://gna.org/task/?7599 Summary: Windows packages for 2.4.0-beta1 (placeholder) Project: Freeciv Submitted by: jtn Submitted on: Sun Jun 17 19:00:10 2012 Should Start On: Sun Jun 17 00:00:00 2012 Should be Finished on: Mon Dec 31 00:00:00 2012 Category: None Priority: 5 - Normal Status: Need Info Privacy: Public Percent Complete: 0% Assigned to: cproc Open/Closed: Open Discussion Lock: Any Effort: 0.00 Planned Release: 2.4.0-beta1 ___ Details: Don't panic, the beta isn't imminent... However, I want somewhere to note Windows-specific extra work that's going to be needed for the first 2.4.0 release, in plenty of time. (The task end date is not meaningful.) So far I've thought of the following. (See also doc/README.packaging.) 1. Need to work out which Gtk client we're shipping for Windows -- Gtk2 or Gtk3. (There doesn't seem to be any point packaging both.) By default I'd like to try for Gtk3. That presumably means work for you getting Gtk3 libraries and so on for Windows. Might be a good idea to start putting together a test build from head of S2_4, so we can work out the kinks. (But if we go for Gtk3, don't throw away ability to build Gtk2 for Windows just yet; we may need it as a backup plan -- I'm not sure how heavily exercised the Gtk3 client has been so far.) 2. Installer scripts. For a start, we should get the installer material onto the S2_4 branch (and trunk) -- bug #19088 only put it on S2_3. Then I expect it will need some tweaks. 3. New mandatory dependency: libcurl (for HTTP). 4. Optional new dependency: liblzma (for .xz compressed files). Not too bothered if we don't get this. 5. Don't bother to try to build the Qt client yet; it doesn't do anything. ___ Reply to this item at: http://gna.org/task/?7599 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17579] Ocean city gfx uses memory many times
Follow-up Comment #3, bug #17579 (project freeciv): I investigated this a bit some months back, but it seems I have failed to update the ticket with my findings. At least for the cases listed so far there's no problem. Sprites are already hashed by tag name. So if several city_styles (or base_types) use identical tag, gfx is loaded only once. I'm not closing this ticket as there's one case which we could improve. If given ruleset is used with several tilesets of which one does have different gfx for different era ocean cities, ruleset cannot use identical tag for them. Then the other tileset with just one ocean gfx will have several copies of its only gfx in memory. That's not pressing problem with what we currently officially distribute, but we could have separate full-featured tileset for high-end systems and minimal tileset for embedded systems. ___ Reply to this item at: http://gna.org/bugs/?17579 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17440] Update CodingStyle to take C++ files into account
Follow-up Comment #1, bug #17440 (project freeciv): Bump -- this has a 2.4.0 target. (But it's not going to block a release.) Unfortunately I can't contribute. ___ Reply to this item at: http://gna.org/bugs/?17440 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7599] Windows packages for 2.4.0-beta1 (placeholder)
Follow-up Comment #1, task #7599 (project freeciv): 1. Need to work out which Gtk client we're shipping for Windows -- Gtk2 or Gtk3. If I have understood correctly, official Windows builds use gtk+ bundles from http://www.gtk.org/download/win32.php (to see also old available versions see http://ftp.gnome.org/pub/gnome/binaries/win32/gtk+/ ) There seems to be no gtk3 version of the bundles at the moment, current is 2.24. ___ Reply to this item at: http://gna.org/task/?7599 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19526] Guest fallback on database error doesn't work
Follow-up Comment #1, bug #19526 (project freeciv): Probably the same situation applies to Warning: the guest name '%s' has been taken, renaming to user '%s'. ___ Reply to this item at: http://gna.org/bugs/?19526 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7599] Windows packages for 2.4.0-beta1 (placeholder)
Follow-up Comment #2, task #7599 (project freeciv): Oh, rats. Bit of digging: there is hope for official Windows binaries, but they're not available yet and work doesn't look overly fast. 2011-03: Tor (tml) says he's not maintaining it any more http://tml-blog.blogspot.co.uk/2011/03/gtk-on-windows-i-am-not-really-doing-it.html (source: SO http://stackoverflow.com/questions/5269657/precompiled-gtk3-for-windows) 2011-05: OpenSUSE Build System binaries suggested http://stackoverflow.com/questions/6006689/where-can-i-download-precompiled-gtk-3-binaries-or-windows-installer as an alternative 2011-11: A new maintainer?, Alexander Larsson, reports http://blogs.gnome.org/alexl/2011/11/25/gtk-work-on-windows/ Gtk2 binary releases have resumed, and talks about work in progress towards Gtk3 2012-03: Alex reports http://blogs.gnome.org/alexl/2012/03/27/moar-windows-themes/ more work on Gtk3; We hope to have window binaries out for [Gtk+ 3.4.0] soon 2012-04: Alex says dieterv is working on the binaries. Not sure when they will be finished... 2012-06: Alex says I know dieter is working on an official win32 binary release, but I don’t know the status of it. So I guess we can either: * wait patiently for the official Gtk3 binaries; or * try to use the OpenSUSE binaries; or * ship the Gtk2 client ___ Reply to this item at: http://gna.org/task/?7599 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7599] Windows packages for 2.4.0-beta1 (placeholder)
Follow-up Comment #3, task #7599 (project freeciv): Another link to watch: https://live.gnome.org/GTK+/Win32 Lots of dated content, but Dieter Verfaillie (new maintainer?) has edited relatively recently. ___ Reply to this item at: http://gna.org/task/?7599 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17354] Client tries to load game in spawned server before requesting hack access
Update of bug #17354 (project freeciv): Planned Release: 2.4.0 = Summary: error messages at game load from the client = Client tries to load game in spawned server before requesting hack access ___ Follow-up Comment #4: After some time looking, I suspect there may not be anything actually preventing the client sending a /load command if the user is incredibly quick off the mark -- clicking the Load Saved Game button on the front page causes the client to send JOIN_REQ and then switch page to PAGE_LOAD, and I suspect there's nothing interlocking the GUI callbacks that end up sending /load. The server would accept it because it would be after the JOIN_REQ. Once the client has processed JOIN_REPLY, it immediately sends SINGLE_WANT_HACK_REQ, and I see no way for the /load to jump the queue. Since this is a local server and Matthias reproduced it readily, I find the scenario above unlikely, unless there's something slowing down client/server communication such that the round trip JOIN_REQ/JOIN_REPLY takes place on human timescales. (Perhaps the server preparing all the ruleset data to send to the client -- I think it might batch it up?) For a similar report, see bug #18467 (not the original symptom of that bug, but comment 4). Anyway. Not a frequent report, so I'm unhooking it from 2.4.0. ___ Reply to this item at: http://gna.org/bugs/?17354 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3322] Resource requirements
Follow-up Comment #5, patch #3322 (project freeciv):
; only lake fish
reqs =
{ type, name, range
Terrain, Lake (Fish), Adjacent
}
Do you plan to give city a bonus if it's adjacent to at least one Fish tile?
I think tile bonus (such as increase to food/shield/trade) applied to every
applicable tile adjacent to city center is more like what you are after:
reqs =
{ type, name, range
Resource, Fish, Local
Terrain, Lake, Local
CityTile, Center, Adjacent
}
As range here for Resource and Terrain requirements is Local (the tile
itself) it's guaranteed that it's the same tile fulfilling both requirements.
___
Reply to this item at:
http://gna.org/patch/?3322
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3325] Allow custom types for governments to be used in effect requirements.
Follow-up Comment #3, patch #3325 (project freeciv):
fc_assert(!gtype_has_flag(g, F_LAST - 1));
F_LAST (last unit type flag) seems like copypaste error here...
if (F_LAST == ival) {
...and here.
for(j=0; jnval; j++) {
Spaces: for (j = 0; j nval; j++) {
log_error(%s government %s: bad flag name %s.,
filename, gtype_rule_name(g), sval);
This would never happen for end-user if ruleset developer had found out about
it and fixed it - it wouldn't hurt end-user to make this ruleset_error() but
it would make it absolutely certain that ruleset author notices his/her typo
at once (even if we let it pass, ruleset lacking that government flag doesn't
work correctly)
___
Reply to this item at:
http://gna.org/patch/?3325
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3221] Add Land tile as requirement for all road types
Update of patch #3221 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3221 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] Numerous issues with wipe_unit() wiping transporter with cargo
URL:
http://gna.org/bugs/?19821
Summary: Numerous issues with wipe_unit() wiping transporter
with cargo
Project: Freeciv
Submitted by: jtn
Submitted on: Sun Jun 17 23:56:36 2012
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.2.7, 2.3.2, S2_4
Discussion Lock: Any
Operating System: Any
Planned Release: 2.3.3, 2.4.0, 2.5.0
___
Details:
Noticed in passing, found through code review, some confirmed through testing
(S2_4):
0 S2_4 only: when looking for noble cargo (gameloss/undisbandable) to save, it
mistakenly calls unit_transported(punit) where punit is the recently destroyed
transporter. Could lead to nobility not saved before proletariat (seen in
testing) or, presumably, a crash.
0 On S2_4 with recursive transports, if cargo was itself carrying cargo and is
to be lost, there are assertion failures (confirmed in testing) and other bad
things, as unit_lost_with_transport() calls server_remove_unit() which expects
cargo to have been removed first.
0 Units that go down with the transport don't get a unit_lost script signal,
only the transporter does. (tested)
0 Nor do they get counted in units_lost or units_killed (wipe_unit() doesn't
handle this at all, callers do, but callers don't and can't account for
cargo). Affects scores.
0 Cosmetic: calls city_units_upkeep() unnecessarily after removing
transporter; server_remove_unit() did it already.
0 Cosmetic: the variable 'drowning' is improperly maintained, being
incremented twice for every decrement. It's used to bail out of iterations
early, so the worst effect is that time will be wasted in rare circumstances.
(This is what drew my eye to this area.)
I believe issues 3, 4, 5, 6 apply on S2_3 as well.
Issues 3, 5, and 6 affect S2_2, FWIW.
On S2_4, the right fix to some of this clearly involves recursion of
wipe_unit(). That may be true for previous branches too.
Moving units_{lost,killed} accounting and signal generation into wipe_unit()
seems like the only answer given the possibility of transport on allied
vessels. But it will need careful handling, with different behaviour depending
on unit_loss_reason (e.g., unit_change_owner() calls wipe_unit(), as does the
editor). But we don't have unit_loss_reason on S2_3 :( -- it came in in patch
#2548.
May also need to pass in aggressor player to wipe_unit() to update their
units_killed.
There are so many issues here, some with different solutions, that this may
become a metaticket...
___
Reply to this item at:
http://gna.org/bugs/?19821
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19822] wipe_unit() can access freed memory, fail to save undisbandable/gameloss units
URL: http://gna.org/bugs/?19822 Summary: wipe_unit() can access freed memory, fail to save undisbandable/gameloss units Project: Freeciv Submitted by: jtn Submitted on: Sun Jun 17 23:58:26 2012 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: S2_4 Discussion Lock: Any Operating System: Any Planned Release: 2.4.0,2.5.0 ___ Details: Issue 1 from bug #19821. ___ Reply to this item at: http://gna.org/bugs/?19822 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19823] Cosmetic fixes in wipe_unit()
URL: http://gna.org/bugs/?19823 Summary: Cosmetic fixes in wipe_unit() Project: Freeciv Submitted by: jtn Submitted on: Mon Jun 18 00:00:23 2012 Category: None Severity: 2 - Minor Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: 2.3.2, S2_4 Discussion Lock: Any Operating System: Any Planned Release: 2.3.3,2.4.0 ___ Details: Issues 5 and 6 from bug #19821. Won't fix 5 on S2_3, since it's not actually broken. Will fix 6 but will only add an assertion for it on S2_4/trunk. ___ Reply to this item at: http://gna.org/bugs/?19823 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] Numerous issues with wipe_unit() wiping transporter with cargo
Update of bug #19821 (project freeciv): Depends on: = bugs #19822 ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Update of bug #19821 (project freeciv): Summary: Numerous issues with wipe_unit() wiping transporter with cargo = [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19818] Experimental ruleset: worker veteran system has problems
Follow-up Comment #2, bug #19818 (project freeciv): Personally, i prefer apprentice, journeyman, master over working man, journeyman, foreman. As far as Engineers go, it makes sense to apply a similar system to them once Worker veteran system is stable. I think we could use the same titles. Presumably the upgrade process will then automatically carry over the level? ___ Reply to this item at: http://gna.org/bugs/?19818 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3331] Make .zip archive
URL: http://gna.org/patch/?3331 Summary: Make .zip archive Project: Freeciv Submitted by: cazfi Submitted on: Mon 18 Jun 2012 02:42:34 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0, 2.5.0 ___ Details: In patch #3301 it was mentioned that we manually build zip archives as part of our release process. This patch makes zip archive building part of make dist. ___ File Attachments: --- Date: Mon 18 Jun 2012 02:42:34 AM EEST Name: DistZip.diff Size: 473B By: cazfi http://gna.org/patch/download.php?file_id=15836 ___ Reply to this item at: http://gna.org/patch/?3331 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19821] [metaticket] Numerous issues with wipe_unit() wiping transporter with cargo
Follow-up Comment #1, bug #19821 (project freeciv): 7. On S2_3, wipe_unit() moving a unit to another transporter doesn't cause the client to be updated -- transporter still looks empty. I suspect that it's due to put_unit_onto_transporter() not doing send_unit_info() for the new transporter (unlike load_unit_onto_transporter()). (I suspect a similar issue applies to the other emergency loading, player_restore_units()' aircraft rescue.) I don't see why a similar issue can't apply to S2_4 (unit_transport_load() vs unit_transport_load_send(), but I didn't notice it in testing. ___ Reply to this item at: http://gna.org/bugs/?19821 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19824] make dist fails to generate meta_mpgui_qt.cpp
URL: http://gna.org/bugs/?19824 Summary: make dist fails to generate meta_mpgui_qt.cpp Project: Freeciv Submitted by: cazfi Submitted on: Mon 18 Jun 2012 02:57:42 AM EEST Category: bootstrap Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0 ___ Details: modinst/meta_mpgui_qt.cpp is listed to be generated with moc in conditional Makefile.am block. make dist fails to see it there and complains that it cannot generate it. Attached fix moves MOC_FILES listing out of conditional block. ___ File Attachments: --- Date: Mon 18 Jun 2012 02:57:42 AM EEST Name: UncondMocFile.diff Size: 386B By: cazfi http://gna.org/bugs/download.php?file_id=15837 ___ Reply to this item at: http://gna.org/bugs/?19824 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19825] in dbv_isset() [bitvector.c::116]: assertion 'bit pdbv-bits' failed.
URL: http://gna.org/bugs/?19825 Summary: in dbv_isset() [bitvector.c::116]: assertion 'bit pdbv-bits' failed. Project: Freeciv Submitted by: jtn Submitted on: Mon Jun 18 01:01:04 2012 Category: editor Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_4 r21328ish Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Just seen a bunch of these on my client console with S2_4 r21328ish. I did use edit mode (cf bug #19300). Here's the one from nearest the top of my scrollback (not the first, there were many): 1: in dbv_isset() [bitvector.c::116]: assertion 'bit pdbv-bits' failed. 2: Backtrace: 2: 0: client/freeciv-gtk2() [0x6383ae] 2: 1: client/freeciv-gtk2(vdo_log+0x11d) [0x626156] 2: 2: client/freeciv-gtk2(do_log+0xef) [0x626668] 2: 3: client/freeciv-gtk2(fc_assert_fail+0xca) [0x62674e] 2: 4: client/freeciv-gtk2(dbv_isset+0xd6) [0x643cbc] 2: 5: client/freeciv-gtk2() [0x45ce49] 2: 6: client/freeciv-gtk2() [0x515f0a] 2: 7: client/freeciv-gtk2() [0x518fa3] 2: 8: client/freeciv-gtk2() [0x51e183] 2: 9: /usr/lib/libgobject-2.0.so.0(g_closure_invoke+0x15e) [0x7ff40d6e45de] 2:10: /usr/lib/libgobject-2.0.so.0(+0x21598) [0x7ff40d6f8598] 2:11: /usr/lib/libgobject-2.0.so.0(g_signal_emit_valist+0x7f6) [0x7ff40d6f9a76] 2:12: /usr/lib/libgobject-2.0.so.0(g_signal_emit+0x83) [0x7ff40d6fa033] 2:13: /usr/lib/libgtk-x11-2.0.so.0(gtk_tree_selection_select_path+0xa8) [0x7ff40f4b8718] 2:14: /usr/lib/libgtk-x11-2.0.so.0(gtk_tree_selection_select_iter+0x8d) [0x7ff40f4b87fd] 2:15: client/freeciv-gtk2() [0x520681] 2:16: client/freeciv-gtk2() [0x5208ad] 2:17: client/freeciv-gtk2(property_editor_load_tiles+0x74) [0x5224fa] 2:18: client/freeciv-gtk2(editgui_popup_properties+0x59) [0x4f04c2] 2:19: client/freeciv-gtk2() [0x46c08c] 2:20: client/freeciv-gtk2(editor_mouse_button_press+0x149) [0x46c1fe] 2:21: client/freeciv-gtk2(handle_edit_mouse_button_press+0x68) [0x4ee315] 2:22: client/freeciv-gtk2(butt_down_mapcanvas+0x39) [0x453c67] 2:23: /usr/lib/libgtk-x11-2.0.so.0(+0x142188) [0x7ff40f3d4188] 2:24: /usr/lib/libgobject-2.0.so.0(g_closure_invoke+0x15e) [0x7ff40d6e45de] 2:25: /usr/lib/libgobject-2.0.so.0(+0x21598) [0x7ff40d6f8598] 2:26: /usr/lib/libgobject-2.0.so.0(g_signal_emit_valist+0x639) [0x7ff40d6f98b9] 2:27: /usr/lib/libgobject-2.0.so.0(g_signal_emit+0x83) [0x7ff40d6fa033] 2:28: /usr/lib/libgtk-x11-2.0.so.0(+0x2590cf) [0x7ff40f4eb0cf] 2:29: /usr/lib/libgtk-x11-2.0.so.0(gtk_propagate_event+0xc3) [0x7ff40f3cc653] 2:30: /usr/lib/libgtk-x11-2.0.so.0(gtk_main_do_event+0x2eb) [0x7ff40f3cd72b] 2:31: /usr/lib/libgdk-x11-2.0.so.0(+0x5c86c) [0x7ff40f04186c] 2:32: /lib/libglib-2.0.so.0(g_main_context_dispatch+0x1f2) [0x7ff40ce268c2] 2:33: /lib/libglib-2.0.so.0(+0x42748) [0x7ff40ce2a748] 2:34: /lib/libglib-2.0.so.0(g_main_loop_run+0x195) [0x7ff40ce2ac55] 2:35: /usr/lib/libgtk-x11-2.0.so.0(gtk_main+0xa7) [0x7ff40f3cdbc7] 2:36: client/freeciv-gtk2(ui_main+0x6f9) [0x451b52] 2:37: client/freeciv-gtk2(client_main+0x1014) [0x45c1a8] 2:38: client/freeciv-gtk2(main+0x20) [0x451457] 2:39: /lib/libc.so.6(__libc_start_main+0xfd) [0x7ff410ef4c4d] 2:40: client/freeciv-gtk2() [0x44d969] ___ Reply to this item at: http://gna.org/bugs/?19825 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19825] in dbv_isset() [bitvector.c::116]: assertion 'bit pdbv-bits' failed.
Follow-up Comment #1, bug #19825 (project freeciv):
Aha, this is reproducible.
Just spawn a new game from the client, go into edit mode, and middle-click on
the tile with your initial units.
Here's a gdb backtrace (fortunately this is a -O0 build):
#0 0x7fc846aff7bb in raise (sig=value optimised out)
at ../nptl/sysdeps/unix/sysv/linux/pt-raise.c:42
No locals.
#1 0x0062684b in fc_assert_fail (file=0x6d47b9 bitvector.c,
function=0x6d4939 dbv_isset, line=116,
assertion=0x6d4849 bit pdbv-bits, message=0x6d0a54 nologmsg:%s)
at log.c:525
level = LOG_FATAL
#2 0x00643cbc in dbv_isset (pdbv=0x3aa85e8, bit=631)
at bitvector.c:116
__FUNCTION__ = dbv_isset
#3 0x00515da6 in objbind_get_value_from_object (ob=0x3935d50,
op=0x382efc0) at editprop.c:1508
pplayer = 0x3aa7b00
_pslot = 0x3979f78
tile_y = 8
nat_y = 8
ptile = 0x3bdcdf0
tile_x = 7
nat_x = 7
objtype = OBJTYPE_TILE
propid = OPID_TILE_VISION
pv = 0xcf4100
__FUNCTION__ = objbind_get_value_from_object
#4 0x00518fa3 in objprop_refresh_widget (op=0x382efc0, ob=0x3935d50)
at editprop.c:2931
w = 0x38efa00
label = 0x38ef040
image = 0x38e2820
entry = 0xd14b70
spin = 0x199c3f0
button = 0x7fc841198c04
ev = 0x386cda0
pv = 0x382ebe0
modified = false
propid = OPID_TILE_VISION
min = 2.9223919711107065e-316
max = 0
step = 1.4821969375237396e-323
big_step = 6.7468418838530609e-317
buf =
03 00 00 00 00 00 00 00200321 25352377177 00 00 00 00 00 00 00 00 00 00_245
31A310177 00 00@256320D310177 00 00z251240D310177 00 00 02200 00 00377177 00
00@256320D310177 00 00340ղ 06 00 00 00 00̠ 31A310177 00 00 02200 00@,
' 00' repeats 12 times320,
61320 00 00 00 00 00Ӡ240D310177 00 00 01200 00 00 00 00 00 70207230 32A310177
00 00 60345202 03 00 00 00 00`_320 00 00 00 00 00 60345202 03,
' 00' repeats 12 times210,
247267@310177 00 00357344 32A310177 00 00 00 00 00 00 00 00 00 00`C323 00
00 00 00 30$220 01 00 00 00 00240321 25352377177 00 00200321 25352377177 00 00
60216206 03,
' 00' repeats 20 times300, 321 25352377177 00 00 20216X 02 00 00 00
#5 0x0051e183 in property_page_selection_changed (sel=0x3863800,
userdata=0x38198d0) at editprop.c:4210
MY_mem_op = 0x7fffea15d1e0 246233c
MY_it_op = 0x7fffea15d1e0
op = 0x382efc0
pp = 0x38198d0
ob = 0x3935d50
#6 0x7fc84119a5de in g_closure_invoke () from
/usr/lib/libgobject-2.0.so.0
No symbol table info available.
#7 0x7fc8411ae598 in ?? () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#8 0x7fc8411afa76 in g_signal_emit_valist ()
from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#9 0x7fc8411b0033 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#10 0x7fc842f6e718 in gtk_tree_selection_select_path ()
from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#11 0x7fc842f6e7fd in gtk_tree_selection_select_iter ()
from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#12 0x00520681 in property_page_fill_widgets (pp=0x38198d0)
at editprop.c:4967
sel = 0x3863800
iter = {stamp = 2031265885, user_data = 0x6b3daa0, user_data2 = 0x0,
user_data3 = 0x0}
rr = 0x3934be0
model = 0x2588e10
path = 0x6b3de10
ob = 0x7fffea15d690
#13 0x005208ad in property_page_load_tiles (pp=0x38198d0,
tiles=0x7947620) at editprop.c:5034
__FUNCTION__ = property_page_load_tiles
#14 0x005224fa in property_editor_load_tiles (pe=0x191e3b0,
tiles=0x7947620) at editprop.c:5807
pp = 0x38198d0
objtype = OBJTYPE_TILE
i = 59950416
preferred = {OBJTYPE_CITY, OBJTYPE_UNIT, OBJTYPE_STARTPOS,
OBJTYPE_TILE}
#15 0x004f04c2 in editgui_popup_properties (tiles=0x7947620,
objtype=6)
at editgui.c:1836
pe = 0x191e3b0
#16 0x0046c08c in popup_properties (ptile=0x3bdcdf0) at editor.c:544
tiles = 0x7947620
#17 0x0046c1fe in editor_mouse_button_press (canvas_x=700,
canvas_y=339, button=2, modifiers=0) at editor.c:601
ptile = 0x3bdcdf0
#18 0x004ee315 in handle_edit_mouse_button_press (ev=0x78b58e0)
at editgui.c:944
No locals.
#19 0x00453c67 in butt_down_mapcanvas (w=0xddf490, ev=0x78b58e0,
data=0x0) at mapctrl.c:237
pcity = 0x0
ptile = 0x0
#20 0x7fc842e8a188 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#21 0x7fc84119a5de in g_closure_invoke () from
/usr/lib/libgobject-2.0.so.0
No symbol table info available.
#22 0x7fc8411ae598 in ?? () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#23 0x7fc8411af8b9 in g_signal_emit_valist ()
[Freeciv-Dev] [bug #19300] in dbv_isset() [bitvector.c::120]: assertion 'pdbv-vec != ((void *)0)' failed.
Follow-up Comment #2, bug #19300 (project freeciv): See also bug #19825. ___ Reply to this item at: http://gna.org/bugs/?19300 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19822] wipe_unit() can access freed memory, fail to save undisbandable/gameloss units
Update of bug #19822 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_4-wipe-transporter-freed-memory.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?19822 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19823] Cosmetic fixes in wipe_unit()
Update of bug #19823 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_4-wipe_unit-cosmetics.diff Size:1 KB File name: S2_3-wipe_unit-cosmetics.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?19823 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19822] wipe_unit() can access freed memory, fail to save undisbandable/gameloss cargo
Update of bug #19822 (project freeciv): Summary: wipe_unit() can access freed memory, fail to save undisbandable/gameloss units = wipe_unit() can access freed memory, fail to save undisbandable/gameloss cargo ___ Reply to this item at: http://gna.org/bugs/?19822 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3322] Resource requirements
Update of patch #3322 (project freeciv): Category:None = general Status:None = Ready For Test Planned Release: = 2.5.0 ___ Follow-up Comment #6: Untested patch (file #15841) ___ Additional Item Attachment: File name: ResourceReq.diff Size:12 KB ___ Reply to this item at: http://gna.org/patch/?3322 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17312] if a city is remove do to migration, the units are not checked
Update of bug #17312 (project freeciv): Planned Release: 2.4.0 = ___ Follow-up Comment #2: Bug #16429 finally yielded an explanation for some of those sorts of messages. However, I don't think it can explain a sentried sea unit on land (which must therefore be in a city). A more likely explanation IMO is bug #18613. I agree that the patch should be unnecessary -- remove_city() looks like it deals with all that. Any point keeping this open? I'm removing the 2.4.0 target, anyway. ___ Reply to this item at: http://gna.org/bugs/?17312 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17248] Dead player scores not revealed on game over
Update of bug #17248 (project freeciv): Planned Release: 2.4.0 = Summary: Player scores not revealed on game over = Dead player scores not revealed on game over ___ Reply to this item at: http://gna.org/bugs/?17248 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16596] Mark capital cities on map
Update of bug #16596 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/bugs/?16596 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16559] Display no-citybuilding area
Update of bug #16559 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/bugs/?16559 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16558] Display ZOCs
Update of bug #16558 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/bugs/?16558 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16490] Server blocks waiting for connection hostname
Update of bug #16490 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/bugs/?16490 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16480] Usability of Help checkbox on research window
Update of bug #16480 (project freeciv): Planned Release: 2.4.0 = Summary: Usability of Help button on research window = Usability of Help checkbox on research window ___ Reply to this item at: http://gna.org/bugs/?16480 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16444] Changing the ruleset doesn't update the ruleset combo box
Update of bug #16444 (project freeciv): Planned Release: 2.4.0 = ___ Follow-up Comment #4: I'm going to guess that a *good* solution to this involves changing the network protocol. Removing 2.4.0 target. ___ Reply to this item at: http://gna.org/bugs/?16444 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16417] Graphical glitches when FOW (graphically) turned off
Update of bug #16417 (project freeciv): Planned Release: 2.4.0 = ___ Follow-up Comment #1: I don't think this is a bug... in Amplio at least, some terrain extends outside of its tile boundaries. I think this is deliberate, for nice blending between tiles. ___ Reply to this item at: http://gna.org/bugs/?16417 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15090] Replace BC and AD by CE and BCE
Follow-up Comment #10, bug #15090 (project freeciv): Best get on with the nation legends soon, if it's going to make 2.4.0... I could about 100 affected lines. ___ Reply to this item at: http://gna.org/bugs/?15090 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15090] Replace BC and AD by CE and BCE
Follow-up Comment #11, bug #15090 (project freeciv): *count ___ Reply to this item at: http://gna.org/bugs/?15090 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14775] The server appears to have gotten into an infinite loop in the allocation of starting positions.
Update of bug #14775 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/bugs/?14775 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14210] optionally include advance benefits in output message
Update of bug #14210 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/bugs/?14210 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13943] Allow unit to choose which transport to load onto
Follow-up Comment #2, bug #13943 (project freeciv): We have an opportunity to fix this (for units in the field and potentially cities) with S2_4's new transport dialog. But it's not there yet. ___ Reply to this item at: http://gna.org/bugs/?13943 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13701] game_remove_unit(), homecity invalid
Follow-up Comment #7, bug #13701 (project freeciv): Bump. Previous comments said that bug #18194 might fix this. Now that bug is fixed, is there anything left to do here? ___ Reply to this item at: http://gna.org/bugs/?13701 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15570] Paradrop always displays turns to target as Unreachable
Update of bug #15570 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/bugs/?15570 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18196] gtk2-client - gtk3-client settings migration
Update of bug #18196 (project freeciv): Planned Release: 2.4.0,2.5.0 = 2.4.0-beta1,2.5.0 ___ Reply to this item at: http://gna.org/bugs/?18196 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3029] overview_window_finished()
Update of patch #3029 (project freeciv): Planned Release:2.4.0, 2.5.0 = ___ Follow-up Comment #1: It looks like this wasn't needed for the Cairo in the end. Wouldn't hurt to apply it, but removing release target. ___ Reply to this item at: http://gna.org/patch/?3029 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2998] Update README.ruleset_experimental for recent changes
Follow-up Comment #6, patch #2998 (project freeciv): Yes, the S2_4/trunk work stalled when I realised that S2_4 wasn't in a documentable state at that point... I'll sort it out before a 2.4.x release. ___ Reply to this item at: http://gna.org/patch/?2998 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3325] Allow custom types for governments to be used in effect requirements.
Follow-up Comment #4, patch #3325 (project freeciv): Thanks for the pickup. I've fixed it all (all enums related to gov flag now start with G_). I've taken gorbs advice and been running make clean / make every time I save a file, so now I am compiling with no warnings/errors w/ regard to: cityturn.c requirements.c effects.c fc_types.h packets.h packets.def helpdata.c unittype.h I've mostly got government.h done. Just need to make sure my prototyping matches and mostly I just need to finish filling out functions in government.c. The only real problem I am having is that I REALLY want to add government flags as an optional requirement for units. I have everything done in that respect except lookup_government_flag. I know it has to work differently from lookup_government as instead of counting through sections, I have to look for the section government_flags.names, count through it and match to unit_type.govflag_req. I am sure I can do it with a bit more time but it is giving me a headache. On the whole though, I am pretty confident I'll get it working within the next few days, and that makes me happy. Food for thought; with this implemented, should 'Default' and 'NoGov' be turned into flags to match with how it is done with units? Furthermore, it seems that 'Fanatics' could be done by the ruleset maker, meaning it can be removed from the code... Ah well, back to it! ___ Reply to this item at: http://gna.org/patch/?3325 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2959] add README.fcdb
Update of patch #2959 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Follow-up Comment #10: I don't think we're going to find time to backport this to S2_3. In the meantime, S2_4's has been rewritten (bug #19166). Closing this. ___ Reply to this item at: http://gna.org/patch/?2959 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2607] Allow minimum city size for rapture growth to be greater than that for celebration
Update of patch #2607 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?2607 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2542] server/ruleset settings
Update of patch #2542 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?2542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2076] Crazy caravan patch
Update of patch #2076 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?2076 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1864] Make many territory claiming bases possible on a same tile
Update of patch #1864 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?1864 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1338] [Metaticket] Generalize requirements
Update of patch #1338 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?1338 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1342] Unit type negated requirements
Update of patch #1342 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?1342 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1341] Improvement negated requirements
Update of patch #1341 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?1341 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1340] Technology requirements
Update of patch #1340 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?1340 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1339] Unit type requirements
Update of patch #1339 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?1339 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1446] [Metaticket] Ruleset object
Update of patch #1446 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?1446 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1448] Make a ruleset structure
Update of patch #1448 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?1448 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1447] Merge ruleset files in 1 file
Update of patch #1447 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?1447 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1464] cleanup ai_choice
Update of patch #1464 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?1464 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3325] Allow custom types for governments to be used in effect requirements.
Follow-up Comment #5, patch #3325 (project freeciv): Hmm. I have another problem I need to sort through in rulesets.c. Are requirements in [unit_type] or ||? That is, if a unit has gov_req = SomeMilitaryGov and govflag_req = NotAMilitaryGov, does that mean that a unit can never be built, does it mean that if either are true it can be built, or does it cause an error? If it is the former, a valid req list would only be where gov_req was a subset of govflag_req. In that case, should I make it an error if both are filled, and have only the gov_req applied? In other words, if gov_req!=NULL : govflag_req=NULL ? ___ Reply to this item at: http://gna.org/patch/?3325 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3322] Resource requirements
Follow-up Comment #7, patch #3322 (project freeciv): Wow! Thanks for your work. ___ Reply to this item at: http://gna.org/patch/?3322 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3325] Allow custom types for governments to be used in effect requirements.
Follow-up Comment #6, patch #3325 (project freeciv): Heck yeah, 9 functions left to write and this is ready! (for testing) The only warnings/errors I am getting are for undefined functions. Everything else seems to be in order an I even got the unit govflag_req thing working. I have decided that if a gov_req exists for unit production, you don't even check govflag_req. It is still loaded and validated in ruleset.c but when it is time to actually check if you can build it, govflag_req gets skipped. It seems the most logical thing to do. Whoever wrote those mindboggling #define structures was either a genius or a madman. Possibly both. I am too afraid to use most of them. ___ Reply to this item at: http://gna.org/patch/?3325 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
