[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #141, patch #3469 (project freeciv): OK, this is the patch fixing the typo. Should be god for both S2_4 and trunk. (file #17714) ___ Additional Item Attachment: File name: 0001-fix-rates-dialog-typo.patch Size:0 KB ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #142, patch #3469 (project freeciv): OK, this is the patch fixing the typo. Ah, we already raised a new ticket (bug #20706), sorry for not mentioning it here. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #140, patch #3469 (project freeciv): ...and this is why having your own patches rechecked by someone else is a good thing. Back in trunk patches, I've made a minor typo, that I've later noticed and fixed in S2_4 branch, but the fix never made trunk and as such the typo is still present in the revision 22542 (originally in revision 21947). However file #17382 (IIRC) should have that typo already fixed. In client/gui-gtk-3.0/gamedlgs.c, around line 278, in rates_lux_scale block, in gtk_range_set_increments call, rates_sci_scale is used by mistake. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Update of patch #3469 (project freeciv): Planned Release: 2.5.0 = 2.4.0,2.5.0 ___ Follow-up Comment #139: No-one screamed... ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #92, patch #3469 (project freeciv): Thanks. Here's my version of the patch series backported from commits on trunk. There were a few conflicts, but they were all explicable and easily resolved (unfortunately I lost my notes on the origins of the conflicts, so you'll have to take my word for it). It compiles and my minimal testing so far didn't show any problems relative to trunk. Compared to Rafał's patch series it has the following differences: * I took the arguably unrelated cleanup patch #2908 from trunk too * ...but I didn't take the fix for bug #14205 * Patches which have not yet been applied to trunk have not been applied here either: ** 11/60 and 12/60 (patch #3550) ** 21/60 (patch #3560) ** 53/60 (patch #3572) * Patches are in a slightly different order (matching the order they were committed to trunk) Are there any objections to committing this patch series? (Commits would appear under relevant tickets, and I'd update the ticket statuses to reflect this.) Couple of random notes on behavioural differences resulting from these changes (on trunk and S2_4) * minimap, unit list etc appears on the right of the main map rather than the left * option dialogs are more spaced out ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Additional Item Attachment, patch #3469 (project freeciv): File name: S2_4-gtk3-grids-etc-patches.mbox Size:340 KB ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #91, patch #3469 (project freeciv): This is what I have on my 2.4 branch. It includes all the patches that got into trunk and a few that didn't. Obviously, cherry-picking Use g_strdup_printf() or g_strdup()... patch has muddled the patchset a bit and is probably not really valid for 2.4. There's also some some minor things like: - 0001 patch, which got accepted and 0019, which didn't (patch #3560), do basically the same thing in different places - gtk-button-images is an upstream invention, not mine and arguably gui_gtkX_small_display_layout is sort of similar idea (using display space as efficiently as possible) - 0004 patch is technically a bugfix, so it should have been picked up already - patch #3572 is yet to be fully tested (file #17382) ___ Additional Item Attachment: File name: freeciv-2.4-deprecation-patchset.tar.xz Size:53 KB ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #90, patch #3469 (project freeciv): To avoid the risk of accidentally introducing changes that didn't go through Gna, it's probably best to backport from trunk svn. I plan to do this; I've got a shortlist of changes to backport already. They don't cherry-pick trivially but I think the conflicts will be easy to resolve. Next step is to post a massive patch stack from git here for review, and test it a bit. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #89, patch #3469 (project freeciv): Actually, most of my testing was done on 2.4 branch, so I still have my changes rebased on top of S2_4 branch. Though I did cherry-pick a few other patches from trunk, including one or two that I probably didn't need that much, so you'd need to clean them up a bit. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #87, patch #3469 (project freeciv): Months ago, I remember looking at some of the earlier commits to trunk in this ticket and thinking that they were visible improvements we might well want for S2_4. On a brief look now I can't remember what exactly I was thinking of, unhelpfully. But anyway, in principle, is there a reason not to port the changes to the Gtk3 client code wholesale to S2_4? It's not like S2_4 gtk3 has a long history of testing behind it (I've noticed no feedback from users), and having two different gtk3 codebases to maintain seems like making a rod for our own backs. Unless all these GtkGrid changes are particularly risky, or bump the minimum required Gtk version or something? (I haven't actually tried trunk gtk3 myself since the GtkGrid stuff went in.) ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #88, patch #3469 (project freeciv): But anyway, in principle, is there a reason not to port the changes to the Gtk3 client code wholesale to S2_4? It's not like S2_4 gtk3 has a long history of testing behind it Note that S2_4 gtk3-client is as much copy of gtk2-client as possible, and gtk2-client has been tested a lot during the years. But you are right that gtk3-client is all new client anyway, so we could still add stuff to S2_4 version quite liberally. Only that it would require weeding out any differences in the S2_4 and TRUNK codebases because of network protocol or client common code differences. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Update of patch #3469 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #79, patch #3469 (project freeciv): 53/60 raised as patch #3572, just because I'm yet to test it. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #55, patch #3469 (project freeciv): 29/60 raised as patch #3565 as it depends on patch #3561 and cannot be committed yet. (I want to go though patches in this ticket in order so every one is certainly handled) ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #57, patch #3469 (project freeciv): 31/60 raised as patch #3566 for bug found in testing ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #53, patch #3469 (project freeciv): 27/60 raised as patch #3561 for problem found in testing. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #41, patch #3469 (project freeciv): 16/60 is duplicate of patch #3348 ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #44, patch #3469 (project freeciv): 19/60 raised as patch #3558 ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #45, patch #3469 (project freeciv): 20/60 is duplicate of bug #20095 ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #47, patch #3469 (project freeciv): 21/60 raised as patch #3560, since it seems not to work. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #39, patch #3469 (project freeciv): I've raised new version of 14/60 as patch #3557 ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #37, patch #3469 (project freeciv): Also 12/60 handled as part of patch #3550. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #36, patch #3469 (project freeciv): I've raised 11/60 as patch #3550 for discussion as from quick glance it seems unacceptable to me. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #28, patch #3469 (project freeciv): 3/60 is being handled as patch #3543 ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #25, patch #3469 (project freeciv): Usually we've enforced 1 patch/ticket policy to avoid tickets being in some pseudo state of being partly resolved (some patches committed) and partly not. With patchset of 60 patches I think we can try different approach here - forcing you to create 60 new tickets doesn't sound like good use of development time. We resolve everything trivial (anything I end up committing without further comments) as part of this ticket. When ever some patch needs further discussion, it won't block this ticket, but new ticket will be created for the particular patch at that point. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Update of patch #3469 (project freeciv): Status:None = Ready For Test Assigned to:None = cazfi Planned Release: = 2.5.0 ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #24, patch #3469 (project freeciv): When looking at row-selected description, it seems to me it can't be made to both act as it currently does and coded correctly: * The row-activated signal is emitted when the method * gtk_tree_view_row_activated() is called or the user double clicks * a treeview row. It is also emitted when a non-editable row is * selected and one of the keys: Space, Shift+Space, Return or * Enter is pressed. As this is not a simple event, but a set of alternates, it can't be reasonably reimplemented either. On not quite related note: today I've stumbled upon the explanation of the reason of bug #19846 - and it's nasty: https://bugzilla.gnome.org/show_bug.cgi?id=671939 ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #23, patch #3469 (project freeciv): This tarball carries complete patchset against r21858 trunk. There are quite a few patches here, that are already attached to other bugs/patches here, but there are just too many changes already to show the current state in any other way. This isn't final yet - while grids have a few upsides, one downside in regard of boxes is that there's no real equivalent of gtk_box_pack_end - attaching *at* the end is simple, *from* - not so. To do that, I'll need to fix a few things. It's not quite 1:1 - I think I went in the other direction this time and added too much spacing - but it should mostly match previous behavior. But - unless I've missed something - it's more or less done. Probably made a mistake or two there, so please review (especially votebar wasn't quite tested - didn't came up with an easy test setup). Among the changes there are a few minor enhancements (i.e. in rates dialog - though I'm not sure I've made it in the right part of it (namely in regard of refreshing the dialog on govt. change)). Most of my testing was on S2_4, but the patches were cherry-picked from one branch to the other, so it *should* be fine. (file #16493) ___ Additional Item Attachment: File name: freeciv-trunk-patches.tar.xz Size:48 KB ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #22, patch #3469 (project freeciv):
I've been a little busy lately, so the progress is a bit slower than I
expected.
On the other hand, as I'm reviewing my own changes, I notice a few places I
can improve them.
I.e., for all those little rants about TOCTOU, I was doing the same in
move_mapcanvas. Now, I've simplified that block to
if (rbutton_down (ev-state GDK_BUTTON3_MASK)) {
update_selection_rectangle(ev-x, ev-y);
}
Yet another unrelated note: I wonder how long will it take till gna.org renews
its ssl certificate.
___
Reply to this item at:
http://gna.org/patch/?3469
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #21, patch #3469 (project freeciv):
News update: git 1.7.12 was released.
It's with svn 1.7 patch here, so I'm slowly working on separating the changes
I've already made (and tweaking them a little) into a series of git patches.
Unless something significant happens, within a week or two those patches will
slowly be attached here.
Plans for a few callbacks:
- as create_line_at_mouse_pos is redundant, it will most likely become '{}'
- update_rect_at_mouse_pos probably likewise, after adjusting move_mapcanvas
- overlay_workers_at_city will simply be merged into butt_down_mapcanvas
Still planing to lean heavily on GtkGrid.
On semi-related note: complete 'git svn clone' took about 5 hours - ouch.
___
Reply to this item at:
http://gna.org/patch/?3469
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #20, patch #3469 (project freeciv): Due to previously mentioned reasons, things are a bit stuck right now, but I've ran a little test today in regard of create_line_at_mouse_pos. It's already redundant - move_mapcanvas and move_overviewcanvas already cover it. Though it might be a good idea to add the conditions from create_line_at_mouse_pos to both of them - I'll need to check if that makes sense. As for gridding, as I mentioned elsewhere, it's mostly done, I'll just need to restore the spacing and check a few things in the few places where I done something more than searchreplace. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #11, patch #3469 (project freeciv): Well, here's a funny thing: while tinkering with update_rect_at_mouse_pos, I thought I've made a regression, but gtk2 client seems to have the same problem. Holding right mouse button, select an area. Without releasing the button, scroll with mouse wheel. When you stop scrolling, move the mouse a bit, while not releasing the button - observe part one of the problem. Now release it - second part of the problem (selection rectangle is drawn till map_canvas gets redrawn). On a semi-related note: is toggle_focus_unit_state the function responsible for drawing focus circle ? Also, it seems I'll go into total grid conversion, including converting *all* the boxes into grids. Crazy, ain't it ? But I wonder: it seems that there's a good chance to make a few options switchable without restart via gtk_orientable_set_orientation (that's gtk+ 2.16, actually). I'll go back to this idea once I'm done with grids. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #12, patch #3469 (project freeciv):
I'm tempted to do something really annoying from common client code side of
view - implement update_rect_at_mouse_pos as '{}' and just handle it in
move_mapcanvas.
I still dont understood what you are trying to achieve
___
Reply to this item at:
http://gna.org/patch/?3469
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #13, patch #3469 (project freeciv): Now, for something bit annoying, for a change: kind of similar test, but in c case, in gtk3 client leads to not quite correct display till mapcanvas gets redrawn - I'm not sure if it's related to my changes or not. But in gtk2 client, it leads to mouse getting *permanently* being grabbed by mapcanvas - can't access menu, trying to close the window (with mouse) leads to getting messages about application not responding. The exact procedure: - select a unit - center the map on a different tile - select an area, don't release the button - press c Can someone else reproduce this in gtk2 client ? ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #14, patch #3469 (project freeciv):
@comment 12:
I want to put something like:
{
GdkModifierType state;
gdk_device_get_state(ev-device, ev-window, NULL, state);
if (rbutton_down (state GDK_BUTTON3_MASK)) {
update_selection_rectangle(ev-x, ev-y);
}
}
in move_mapcanvas instead of update_rect_at_mouse_pos.
(and whoever you were, you forgot to login)
___
Reply to this item at:
http://gna.org/patch/?3469
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #15, patch #3469 (project freeciv): you asked what does earlier center_tile_mapcanvas() - it center map on unit when c is pressed, also probably center on some event via message output. I assume you changed it so of course its your fault, that 'c' make mess now. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #16, patch #3469 (project freeciv): I've made those changes in gtk3 client, not gtk2, where the permanent grab happens. (and I didn't exactly ask what does center_tile_mapcanvas do ?, but more along the lines of is there anything I should know about update_rect_at_mouse_pos in regard of common client code ?) ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #17, patch #3469 (project freeciv): On gtk2 client - select a unit (I selected ) - center the map on a different tile ( I chosen via messages and it centereed ) - select an area, don't release the button ( I chosen ) - press c ( nothing happened, unit was still centered ) ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #18, patch #3469 (project freeciv): sorry I was wrong. Centered was some vent. It centered on new place but cursor still remained strange. After clicking new turn everything was ok ( client was almost ok except cursor and I was unable to select another unit) ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #19, patch #3469 (project freeciv): Seems a more detailed description is necessary: - select a unit - right click on a tile, that's far enough to make a visible difference but still being able to see the unit - press and hold right mouse button, drag to select an area - without releasing the button, press c map *does* get centered, but the mouse is permanently grabbed (gtk2 version might matter, it's 2.24.11 here) ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #10, patch #3469 (project freeciv): I've made not-quite-a-typo in the first version of the second - it worked, but generated new compiler warnings. (file #16300) ___ Additional Item Attachment: File name: pointer-pos-changes-1.patchSize:3 KB ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #8, patch #3469 (project freeciv):
I'm tempted to do something really annoying from common client code side of
view - implement update_rect_at_mouse_pos as '{}' and just handle it in
move_mapcanvas.
Initial tests look good - that is as I select things with mouse, the rectangle
seems to be drawn at correct time and place.
What does Called by center_tile_mapcanvas().. part of its description refers
to (just to make sure the test is close to complete) ?
Also, I've noticed something odd (both in gtk3 and gtk2): once a unit is
selected, cpu usage instantly spikes. I suspect it has something to do with
selection circle under the unit, but need to find the place where it's drawn
first.
___
Reply to this item at:
http://gna.org/patch/?3469
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #9, patch #3469 (project freeciv):
I hope that whatever issues there are lately in 'git svn', they'll going to
get reasonably fixed soon, cause that's likely the most simple solution on my
side - I'll simply import svn repo into git then.
Anyway, there has been some progress in the last few hours, but it's quite
hard to isolate the changes in the older patches from the more recent ones.
Looks like I'll lean very heavy on the grids - though it's sometimes quite
hard to figure out which {h,v}boxes were functional and which only decorative.
Probably won't get it completely right in the first go.
On a semi-related note: it seems I've stumbled on one or two places with a
similar problem to that bug with editor mode and GtkScrolledWindow (can't
recall the number atm.).
No luck in finding that focus circle yet.
___
Reply to this item at:
http://gna.org/patch/?3469
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #5, patch #3469 (project freeciv): So, step 2 will regard the simple part of gdk_window_get_pointer - in chatline .c, one call was doing nothing, the other was connected to a signal that seems to have been redundant (AFAICT, things work correctly without handling that signal) - one of the calls in mapctrl.c was made in a callback to an event where the pointer device wasn't really important (the little testing I've done suggest things work just like there use to with this change) Now, I've got a little problem: city_activated_callback (cityrep.c) and impr_callback (citydlg.c) - AFAICT, these two, while *seem* to be working, are actually incorrect both in gtk3 and gtk2; the problem is that, unless I'm missing something, they check for Ctrl being pressed *during* the callback, not when the event takes place; while in most cases, human reaction time will make it a non issue, it won't make it correct Still left are those three functions in mapctrl.c - the plan for overlay_workers_at_city is unchanged atm., other two are a bit more complicated (want to made a significant change, but not break common client code in the process). (file #16284) ___ Additional Item Attachment: File name: pointer-pos-changes-1.patchSize:3 KB ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #6, patch #3469 (project freeciv): Remember to keep bug fixes and cleanup and feature development separate. First one should go to S2_4 too, last one only to TRUNK, and middle one usually to TRUNK only except when being requirement for later bugfix. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning
Follow-up Comment #3, patch #3469 (project freeciv): Also, there's a little thing I've missed in the initial port (mainly cause it was still hybrid then) - except for most gdk_window_get_pointer calls, those calls can be made far more simple via the content of events they handle. ___ Reply to this item at: http://gna.org/patch/?3469 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
