Re: [Freeipa-devel] [PATCH 62] Tweak the session auth to reflect developer consensus.

2012-02-20 Thread John Dennis
On 02/20/2012 01:49 PM, JR Aquino wrote: On Feb 17, 2012, at 3:18 PM, John Dennis wrote: -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

Re: [Freeipa-devel] [PATCH 62] Tweak the session auth to reflect developer consensus.

2012-02-20 Thread John Dennis
On 02/20/2012 04:00 PM, JR Aquino wrote: On Feb 20, 2012, at 12:48 PM, "John Dennis" wrote: On 02/20/2012 01:49 PM, JR Aquino wrote: On Feb 17, 2012, at 3:18 PM, John Dennis wrote: -- John Dennis Looking to carve out IT costs? www.redhat.com/car

Re: [Freeipa-devel] [PATCH 62] Tweak the session auth to reflect developer consensus.

2012-02-20 Thread John Dennis
On 02/20/2012 04:00 PM, JR Aquino wrote: On Feb 20, 2012, at 12:48 PM, "John Dennis" wrote: On 02/20/2012 01:49 PM, JR Aquino wrote: On Feb 17, 2012, at 3:18 PM, John Dennis wrote: -- John Dennis Looking to carve out IT costs? www.redhat.com/car

Re: [Freeipa-devel] Please refresh Transifex pot file

2012-02-21 Thread John Dennis
and in our git repo were updated today for both master and ipa-2-2. Thank you very much Jérôme for your help! -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] IPA service user(s)

2012-02-22 Thread John Dennis
ch major process should be running under a system dedicated id, except in those limited cases where there is very tightly coupled interactions (e.g. where both processes need to read/write the same file system objects, which at the moment only applies to apache/memcache) Make sens

Re: [Freeipa-devel] [PATCH 62] Tweak the session auth to reflect developer consensus.

2012-02-24 Thread John Dennis
On 02/24/2012 09:45 AM, Petr Vobornik wrote: On 02/23/2012 10:10 PM, Rob Crittenden wrote: John Dennis wrote: This works great, particularly with patch 63. The only thing I wasn't able to test at all is logout. Is there a way to test that as-is or will the UI guys need to make

Re: [Freeipa-devel] [PATCH 62] Tweak the session auth to reflect developer consensus.

2012-02-24 Thread John Dennis
rebased patch against current ipa-2-2 branch -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ >From 39296b1e77d3b1d8c1d085e463906d1af6bb6816 Mon Sep 17 00:00:00 2001 From: John Dennis Date: Wed, 15 Feb 2012 10:26:42 -0500 Subject: [PATCH 62-1] Tweak the session a

[Freeipa-devel] plugin limitations and more URL modifications

2012-02-24 Thread John Dennis
new URL layout so tweaking the URL's a bit should be an issue, plus the URL's under consideration are NEVER invoked directly by the user, instead the UI does so on behalf of the user via javascript code. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ __

Re: [Freeipa-devel] plugin limitations and more URL modifications

2012-02-24 Thread John Dennis
On 02/24/2012 01:18 PM, John Dennis wrote: We haven't shipped anything with the new URL layout so tweaking the URL's a bit should be an issue opps, that should have read "shouldn't be an issue" -- John Dennis Looking to carve out IT costs? www

Re: [Freeipa-devel] plugin limitations and more URL modifications

2012-02-24 Thread John Dennis
On 02/24/2012 01:18 PM, John Dennis wrote: * Move the existing /ipa/login URL to /ipa/session/login_kerberos. The URL change is to be consistent with the above new URL. The URL change reflects the fact it is only used to initialize a session when the user already has a valid kerberos ticket. As

[Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-26 Thread John Dennis
should work. Attached is a curl script I used to test (send_login_password). There is one other minor issue not included in any previous patches nor this one, the VERSION file should be updated to force the apache configuration to be updated. -- John Dennis Looking to carve out IT costs

Re: [Freeipa-devel] [PATCH 62] Tweak the session auth to reflect developer consensus.

2012-02-26 Thread John Dennis
scripts, we have one WSGI script that dispatches on the path component. Therefore the keys used to dispatch are based on the full URL path. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailin

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-26 Thread John Dennis
On 02/26/2012 03:38 PM, Rob Crittenden wrote: John Dennis wrote: This patch adds support for password based session login (see detailed comments in patch) Only the server side is implemented, someone will have to add password based login to the UI, when they do they should update the

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-26 Thread John Dennis
On 02/26/2012 03:54 PM, John Dennis wrote: I assume you're running the script I attached. The reason why you keep getting new sessions is because the script does not send the previous cookie back, from the server's perspective these all appear to be new login requests. Sessions are n

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-26 Thread John Dennis
On 02/26/2012 04:40 PM, Rob Crittenden wrote: John Dennis wrote: On 02/26/2012 03:54 PM, John Dennis wrote: I assume you're running the script I attached. The reason why you keep getting new sessions is because the script does not send the previous cookie back, from the server's p

Re: [Freeipa-devel] [PATCH 62] Tweak the session auth to reflect developer consensus.

2012-02-26 Thread John Dennis
On 02/26/2012 04:41 PM, Rob Crittenden wrote: John Dennis wrote: rebased patch against current ipa-2-2 branch I'm seeing two test failures with patches 62, 63 and 64 applied: ==

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread John Dennis
added and the other was for a change in the wsgi dispatch route() method that showed up in test_rpcserver.py -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ >From 0a3758276e75d540cecce72703a744fa37e26f14 Mon Sep 17 00:00:00 2001 From: John Dennis Date: Sat, 25

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread John Dennis
On 02/27/2012 01:50 PM, Rob Crittenden wrote: John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate session cookies being returned. As far as I can tell this was due to a

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread John Dennis
On 02/27/2012 05:53 PM, Rob Crittenden wrote: John Dennis wrote: On 02/27/2012 01:50 PM, Rob Crittenden wrote: John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate

[Freeipa-devel] [PATCH 65] Log a message when returning non-success HTTP result

2012-02-28 Thread John Dennis
The routines used to return a non-success HTTP result from WSGI failed to log the aberrant event, this corrects that omission. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 5f8deeb262cbb8d969b23ce0c2a3e04c5561576c Mon Sep 17 00:00:00 2001 From: John Dennis

[Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-22 Thread John Dennis
n logic ignore the use of $ as a shell prompt without adding a special case exception. Since shell prompts are rarity in strings my suggestion would be to pick a different shell prompt character, something other than $ and be done with the issue and not try to over-engineer the validation logic. --

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-22 Thread John Dennis
On 03/22/2012 02:59 PM, Petr Viktorin wrote: On 03/22/2012 06:01 PM, John Dennis wrote: This addresses tickets 2044 and 1958. Ticket 2044 was on my short list but the code had already been written for ticket 1958 (validation of substitution variables). It had been sitting in my home directory

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-22 Thread John Dennis
le in Python >= 2.7 so that's not an option (no pun intended) I suppose I could convert to optparse for project consistency even if it's deprecated. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Fre

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-22 Thread John Dennis
New patch attached which addresses Petr's review comments. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ >From 20fc57e1995aeab074cbb586187aedda4be5c1b0 Mon Sep 17 00:00:00 2001 From: John Dennis Date: Fri, 23 Mar 2012 01:44:04 -0400 Subject: [PATCH 66-1]

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-23 Thread John Dennis
tput the offending string(s). This if off by default for brevity purposes but is useful for those having to make fixes or just to better understand the nature of the error. I tried to make the error output a bit less verbose with better formatting. I updated .gitignore to ignore the gene

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-26 Thread John Dennis
Also fixed. Updated patch attached. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ >From 0d74736954efca3bdafa1967f1f6f97c43528fa8 Mon Sep 17 00:00:00 2001 From: John Dennis Date: Fri, 23 Mar 2012 01:44:04 -0400 Subject: [PATCH 66-3] Replace broken i18n shell t

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-26 Thread John Dennis
slation strings (e.g. '%s') because they do not allow translators to reorder the wording. Instead keyword substitutions should be used when there are more than one. ACK if that's fixed Done, patch attached. -- John Dennis Looking to carve out IT costs?

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-26 Thread John Dennis
On 03/26/2012 04:34 PM, John Dennis wrote: On 03/26/2012 01:11 PM, Petr Viktorin wrote: Just a one-liner: The docstring of validate_anonymous_substitutions isn't up to par ­­– there's a missing quote, extra “a”, and the '%s occurred' has no context. I suggest: We do

[Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread John Dennis
This patch addresses ticket 2582, see comments in commit message. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ >From fff7d0a42f7643039987d49c4de69b248f9baa9f Mon Sep 17 00:00:00 2001 From: John Dennis Date: Tue, 27 Mar 2012 10:18:24 -0400 Subject: [PATCH 68] t

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread John Dennis
On 03/27/2012 10:34 AM, John Dennis wrote: This patch addresses ticket 2582, see comments in commit message. Sorry, the patch I originally posted was incorrect, the work had been done in several commits but I forgot to "squash" them into one commit and patch before posting it. This

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread John Dennis
ust with a different path (albeit perhaps a more logical cleaner path). -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] web ui error

2012-03-28 Thread John Dennis
or point us to a pastebin? Thanks. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH 69] Use indexed format specifiers in i18n strings

2012-03-29 Thread John Dennis
. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 02fbab6602c545f0eb3dc4a455955f904d5b53fc Mon Sep 17 00:00:00 2001 From: John Dennis Date: Thu, 29 Mar 2012 21:34:19 -0400 Subject: [PATCH 69] Use indexed format specifiers in i18n strings Content-Type: text/plain

[Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-03-29 Thread John Dennis
se we do not want to modify the pot file under source code control and exported to Transifex. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ >From b8c85678fd8ec0aabc23a795610c438f0fb667b6 Mon Sep 17 00:00:00 2001 From: John Dennis Date: Tue, 27 Mar 2012 15:54:

[Freeipa-devel] [PATCH 71] improve handling of ds instances during uninstall

2012-04-04 Thread John Dennis
-- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ >From 032ebced279d32bb3e6d51ef23fecaca36774ec7 Mon Sep 17 00:00:00 2001 From: John Dennis Date: Wed, 4 Apr 2012 15:19:29 -0400 Subject: [PATCH 71] improve handling of ds instances during uninstall Content-Type: t

Re: [Freeipa-devel] [PATCH 71] improve handling of ds instances during uninstall

2012-04-05 Thread John Dennis
On 04/05/2012 01:26 AM, Alexander Bokovoy wrote: On Wed, 04 Apr 2012, John Dennis wrote: +# Strip off prefix +instance = basename[len(instance_prefix):] +# Must be non-empty +if instance: +instances.append

Re: [Freeipa-devel] [PATCH 69] Use indexed format specifiers in i18n strings

2012-04-05 Thread John Dennis
On 04/04/2012 09:01 AM, Petr Viktorin wrote: On 04/02/2012 03:15 PM, Rob Crittenden wrote: John Dennis wrote: Translators need to reorder messages to suit the needs of the target language. The conventional positional format specifiers (e.g. %s %d) do not permit reordering because their order

[Freeipa-devel] parameter validation

2012-04-05 Thread John Dennis
le time, thus there is no need to pass ugettext to them. If for some reason they did, they should call the proper version o fugettext from text.py, thus I still don't see the need or value of always passing ugettext as a parameter to the validator, do you? -- John Dennis Looking to carve

[Freeipa-devel] [PATCH 72] Validate DN & RDN parameters for migrate command

2012-04-05 Thread John Dennis
-- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ >From b33aaad1058c78eedd00ce24e3b41531b5340294 Mon Sep 17 00:00:00 2001 From: John Dennis Date: Thu, 5 Apr 2012 21:18:09 -0400 Subject: [PATCH 72] Validate DN & RDN parameters for migrate command Content-Typ

Re: [Freeipa-devel] [PATCH 72] Validate DN & RDN parameters for migrate command

2012-04-06 Thread John Dennis
s what was the original intent. All good suggestions, a revised patch will follow shortly. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 72] Validate DN & RDN parameters for migrate command

2012-04-10 Thread John Dennis
On 04/06/2012 10:11 AM, John Dennis wrote: On 04/06/2012 04:40 AM, Martin Kosek wrote: 1) We still crash when the parameter is empty. We may want to make it required (the same fix Rob did for cert rejection reason): # echo "secret123" | ipa migrate-ds ldap://vm-054.idm.lab.bos.

[Freeipa-devel] param type issues

2012-04-11 Thread John Dennis
rision. That's not robust. There are no guarantees concerning the ordering of keys in a dict, nor the string values produced by repr(). If you want to compare dicts for equality then you should compare dicts for equality. If you want to use strings for comparison purposes you have to be a lot mo

Re: [Freeipa-devel] param type issues

2012-04-11 Thread John Dennis
On 04/11/2012 01:44 PM, Rob Crittenden wrote: John Dennis wrote: >> The default value should be treated just as if the user had supplied >> the value passing through all the same normization and conversion steps. > Params have always been rather primitive types so this has neve

Re: [Freeipa-devel] [PATCH 72] Validate DN & RDN parameters for migrate command

2012-04-11 Thread John Dennis
param required (actually it would have been adding the flag 'nonempty') because you should be able to say you don't want to introduce a container into the search bases (see commit comment) -- John Dennis Looking to carve out IT costs? www.redhat.com/

Re: [Freeipa-devel] [PATCH 72] Validate DN & RDN parameters for migrate command

2012-04-12 Thread John Dennis
On 04/12/2012 04:17 AM, Martin Kosek wrote: On Wed, 2012-04-11 at 22:05 -0400, John Dennis wrote: Revised patch attached. We'll leave the DN parameter changes till later. This is essentially the same as the original patch with the addition of the fixes necessary to support passing an

Re: [Freeipa-devel] [PATCH] 0033 Pass make-test arguments through to Nose + Test coverage

2012-04-12 Thread John Dennis
Yes, this looks fine, it's a perfectly reasonable approach. The thing I was trying to address in my patch 54 was the fact you couldn't start the tests from within the debugger which prevented you from setting breakpoints. Petr's patch solves the same problem, but in a more ge

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-12 Thread John Dennis
manager bound to it). It better to reference log_mgr.configure_state than to make assumptions about the internals of the class. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redha

Re: [Freeipa-devel] [PATCH 72] Validate DN & RDN parameters for migrate command

2012-04-13 Thread John Dennis
On 04/13/2012 07:53 AM, Martin Kosek wrote: On Thu, 2012-04-12 at 10:03 -0400, John Dennis wrote: On 04/12/2012 04:17 AM, Martin Kosek wrote: On Wed, 2012-04-11 at 22:05 -0400, John Dennis wrote: Revised patch attached. We'll leave the DN parameter changes till later. This is essentiall

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-16 Thread John Dennis
s because of the existing configuration perhaps we should look at the historical configuration and ask if it needs to be modified. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-16 Thread John Dennis
On 04/16/2012 01:31 PM, Rob Crittenden wrote: John Dennis wrote: On 04/13/2012 06:25 AM, Petr Viktorin wrote: When the utility sets logging to console, the extra log message gets printed out there. I agree this isn't optimal. Attached patch removes the console log handler before loggin

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-16 Thread John Dennis
On 04/12/2012 09:26 AM, Petr Viktorin wrote: On 03/30/2012 03:45 AM, John Dennis wrote: Translatable strings have certain requirements for proper translation and run time behaviour. We should routinely validate those strings. A recent checkin to install/po/test_i18n.py makes it possible to

[Freeipa-devel] Generating files from .in template files

2012-04-16 Thread John Dennis
s as well as what's in the distribution, where the build is occurring, and how, when and what we choose to validate. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-16 Thread John Dennis
On 04/16/2012 04:15 PM, Rob Crittenden wrote: John Dennis wrote: On 04/16/2012 01:31 PM, Rob Crittenden wrote: John Dennis wrote: On 04/13/2012 06:25 AM, Petr Viktorin wrote: When the utility sets logging to console, the extra log message gets printed out there. I agree this isn't op

Re: [Freeipa-devel] [PATCH] 1007 remove all state when uninstalling

2012-04-16 Thread John Dennis
and if we don't call restore_state() cruft is left in the state file that somehow confuses things later on? -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH 73] don't append basedn to container if it is included

2012-04-16 Thread John Dennis
-- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ >From bdcbdc28eb4c70042daa5424895f991ff4886a79 Mon Sep 17 00:00:00 2001 From: John Dennis Date: Mon, 16 Apr 2012 18:48:57 -0400 Subject: [PATCH 73] don't append basedn to container if it is included Content-Ty

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread John Dennis
band with respect to logging resulting in a duplicate message (however before application of the patch I don't see why logging would re-emit the message). -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-d

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread John Dennis
his?" and "Is this any less invasive than simply fixing the messages in the utilities cleanly and not introducing a hack?" -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-18 Thread John Dennis
On 04/18/2012 07:33 AM, Petr Viktorin wrote: On 04/16/2012 10:32 PM, John Dennis wrote: On 04/12/2012 09:26 AM, Petr Viktorin wrote: On 03/30/2012 03:45 AM, John Dennis wrote: Translatable strings have certain requirements for proper translation and run time behaviour. We should routinely

[Freeipa-devel] [PATCH 74] Fix name error in hbactest

2012-04-19 Thread John Dennis
m not sure ignoring all errors is really the right behavior. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From e0bc546f8e35d5781f0edf58500abca2c8c424cc Mon Sep 17 00:00:00 2001 From: John Dennis Date: Thu, 19 Apr 2012 08:56:07 -0400 Subject: [PATCH 74] Fix name error i

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-19 Thread John Dennis
On 04/19/2012 07:04 AM, Petr Viktorin wrote: On 04/18/2012 09:32 PM, John Dennis wrote: Now that there are warnings, is pedantic mode necessary? Great question, I also pondered that as well. My conclusion was there was value in separating aggressiveness of error checking from the verbosity of

[Freeipa-devel] samba4 woes

2012-04-20 Thread John Dennis
So how are others working on master and how are you getting around this problem? -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] samba4 woes

2012-04-20 Thread John Dennis
On 04/20/2012 01:35 PM, Alexander Bokovoy wrote: Hi John, On Fri, 20 Apr 2012, John Dennis wrote: We're supposed to be working on master now, not 2.2. But master has dependencies on samba4. Those dependencies can only be resolved on F17, an unreleased platform. I think it's reasonab

[Freeipa-devel] [PATCH 75] log dogtag errors

2012-04-20 Thread John Dennis
both the log and use it to initialize the CertificateOperationError exception. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 9a8bfc30e044c837724160b7b6bb863a7d0d3e33 Mon Sep 17 00:00:00 2001 From: John Dennis Date: Fri, 20 Apr 2012 13:56:25 -0400 Subject

Re: [Freeipa-devel] samba4 woes

2012-04-20 Thread John Dennis
oc, libtdb, libtevent, SSSD and possibly openchange, so an update like that has to be carefully coordinated. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.

Re: [Freeipa-devel] samba4 woes

2012-04-20 Thread John Dennis
27;ll discover there are number of packages that require libsmbclient on a normal f16 system. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/ma

Re: [Freeipa-devel] [PATCH] 0040 Move install script error handling to a common function

2012-04-23 Thread John Dennis
right direction. I have not installed and exercised the patch so I can't comment on any runtime time issues that might be present, but from code inspection only it has my ACK. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ __

[Freeipa-devel] have you been running master?

2012-04-23 Thread John Dennis
regular basis and have you experienced any issues? Just curious, I want to make sure those changes are rock solid. I haven't heard of any issues, but I thought I would sanity check now that our attention is back on master again. -- John Dennis Looking to carve out IT costs? www.redha

Re: [Freeipa-devel] have you been running master?

2012-04-23 Thread John Dennis
On 04/23/2012 12:00 PM, Jan Cholasta wrote: On 23.4.2012 17:51, John Dennis wrote: Just curious, some changes went into master that modified how we call into ldap (for both the installer and normal server operation). But those changes occurred when many of us we working on 2.2 almost

Re: [Freeipa-devel] [PATCH 75] log dogtag errors

2012-04-28 Thread John Dennis
On 04/27/2012 04:45 AM, Petr Viktorin wrote: On 04/20/2012 08:07 PM, John Dennis wrote: Ticket #2622 If we get an error from dogtag we always did raise a CertificateOperationError exception with a message describing the problem. Unfortuanately that error message did not go into the log, just

Re: [Freeipa-devel] Build problems with FreeIPA v2.2.0

2012-05-14 Thread John Dennis
compatible versions, what version of python do you have, what version of python-ldap? -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] dns.py question

2012-05-24 Thread John Dennis
rrors so if in fact there was no self.base_dn that error would be silently ignored. So is self.base_dn a typo and we're supposed to be using the local base_dn that's computed but never used? Code snipped attached so it won't be mangled by line wrapping. -- John Dennis Loo

Re: [Freeipa-devel] dns.py question

2012-05-25 Thread John Dennis
On 05/25/2012 02:41 AM, Martin Kosek wrote: base_dn is defined in dns_is_enabled command class along with filter: Thanks Martin! I missed the fact it was defined in class scope, not method scope. Duh on my part :-( I thought I was nuts, now I know for sure :-) -- John Dennis Looking to

[Freeipa-devel] keys[-1] idiom?

2012-06-08 Thread John Dennis
gs) why is is called "keys"? That seems really confusing because keys usually has an entirely different meaning (i.e. keys of a dict). Why isn't it named "args"? -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ __

Re: [Freeipa-devel] keys[-1] idiom?

2012-06-11 Thread John Dennis
On 06/10/2012 03:33 PM, Martin Kosek wrote: On Fri, 2012-06-08 at 10:56 -0400, John Dennis wrote: I frequently see this idiom in the code in plugins and pre/post callbacks: keys[-1] My understanding is that keys in the positional parameter list of the command, correct? Correct. keys

[Freeipa-devel] Python debugging tip

2012-06-12 Thread John Dennis
= arg if isinstance(value, TypeError): print ">>> Exception %s" % value print ''.join(traceback.format_tb(tb)) return tracefunc sys.settrace(tracefunc) -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/

[Freeipa-devel] test_changepw is failing on master

2012-06-28 Thread John Dennis
'ok' ------ Ran 4 tests in 31.398s FAILED (failures=3) == FAILED under '/usr/bin/python2.7' -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] please use DN objects

2012-06-29 Thread John Dennis
sequence of RDN's and a RDN is an unordered set of AVA's. But in most cases an RDN is a simple attribute/value pair. If you want to think of DN's as a sequence of attribute/value pairs it's a valid mental shortcut, just be aware there is the possibility for greater compl

[Freeipa-devel] DN patch and documentation

2012-07-07 Thread John Dennis
ssible. I may check in during the week but I'm going to try and discipline myself not to and take an actual much needed break. John -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Free

Re: [Freeipa-devel] DN patch and documentation

2012-07-17 Thread John Dennis
orator: https://github.com/Pylons/pyramid/blob/master/pyramid/decorator.py#L1 Hmm... I wasn't aware of reify. A quick look at it and it smacks of self-modifying code, more hidden weirdness that's not obvious in static code reading. Personally I vastly prefer things to be obvious and n

Re: [Freeipa-devel] [PATCH] 0056 Framework for admin/install tools, with ipa-ldap-updater

2012-07-19 Thread John Dennis
message is internationalized it's even more important for multi-line text to appear in it entirety to give translators the greatest context and latitude for their translation rather than arbitrarily splitting it up into fragments according to English norms (fragments that might not even transla

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-19 Thread John Dennis
nt TX version first!) or we have to go into TX and edit the offending msgstr's. Some of these errors are exactly the kind of thing which will cause us to throw an exception at run time if the locale is ES. Anyway, in summary the patch is great, the ide

Re: [Freeipa-devel] [PATCH] 1035 case sensitivity when calculating indirect members

2012-07-19 Thread John Dennis
ecause I was getting different results than what was happening with an unmodified master. I worked this out with Rob on the phone I believe. Rob was being good by getting a fix in immediately, thank you Rob. But my suggestion would be to just pick up the fix with the dn patch which will hopefully

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-20 Thread John Dennis
contents of the tree specifically to avoid overwriting the pot file. I suppose having a conversation about when the pot file gets updated is a good one to have, we don't do it often enough IMHO. But I'm not sure it's correct to modify a file under SCM control if it wasn't intentio

Re: [Freeipa-devel] [PATCH] 0056 Framework for admin/install tools, with ipa-ldap-updater

2012-07-20 Thread John Dennis
good, although there might be one minor thing that needs fixing. Shouldn't the logging setup be done first? That way any code that executes has the ability to emit a message. For example what if validate_options() wants to emit a message? -- John Dennis Looking to carve out IT c

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-20 Thread John Dennis
On 07/20/2012 12:28 PM, Petr Viktorin wrote: On 07/20/2012 05:39 PM, John Dennis wrote: Great I agree with everything you said. I'm happy to have the file list be derived from the directory contents. Are you planning on doing that in another patch? Yes, I want to do it in a new patch. I

Re: [Freeipa-devel] [PATCH] 0056 Framework for admin/install tools, with ipa-ldap-updater

2012-07-20 Thread John Dennis
On 07/20/2012 12:34 PM, Petr Viktorin wrote: On 07/20/2012 05:59 PM, John Dennis wrote: A fair amount of the code in the framework is doing this now, but the install code was never cleaned up. That was left for another day, I guess that day is here. Updated. I also added the necessary lint

[Freeipa-devel] slow response (was: 2.20 dirsrv memory usage)

2012-07-23 Thread John Dennis
all RPC commands. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ commands: batch(({u'params': [[], {}], u'method': u'i18n_messages'}, {u'params': [[], {u'all': True, u'whoami': True}], u

Re: [Freeipa-devel] slow response

2012-07-23 Thread John Dennis
create any problems for you. John (with his tail between his legs) -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] slow response

2012-07-23 Thread John Dennis
On 07/23/2012 01:23 PM, Stephen Ingram wrote: On Mon, Jul 23, 2012 at 9:37 AM, John Dennis wrote: Stephen provided Alexander and myself with debug output. I quickly wrote a little script to parse the output looking for the session timestamps, what commands were executed for each RPC, and

Re: [Freeipa-devel] slow response

2012-07-23 Thread John Dennis
On 07/23/2012 12:37 PM, John Dennis wrote: Note the timestamps only have 1 second resolution, something which would be easy to fix, so bear that in mind when looking at the output of the script. This is partially as a note to myself, but also to others who want to test. The following patch

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-23 Thread John Dennis
On 07/23/2012 06:27 AM, Petr Viktorin wrote: On 07/20/2012 07:14 PM, John Dennis wrote: On 07/20/2012 12:28 PM, Petr Viktorin wrote: On 07/20/2012 05:39 PM, John Dennis wrote: Great I agree with everything you said. I'm happy to have the file list be derived from the directory contents

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-23 Thread John Dennis
eed to go back to a non-TX workflow we can always retrieve the deleted code from git. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] slow response

2012-07-24 Thread John Dennis
On 07/24/2012 12:03 PM, Stephen Ingram wrote: On Mon, Jul 23, 2012 at 11:25 AM, John Dennis wrote: On 07/23/2012 12:37 PM, John Dennis wrote: Note the timestamps only have 1 second resolution, something which would be easy to fix, so bear that in mind when looking at the output of the script

Re: [Freeipa-devel] slow response

2012-07-25 Thread John Dennis
t simple fix doesn't work then let me know the version you've got and I'll make up a new patch against that version. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-25 Thread John Dennis
On 07/24/2012 06:39 AM, Petr Viktorin wrote: On 07/24/2012 01:12 AM, John Dennis wrote: On 07/23/2012 06:27 AM, Petr Viktorin wrote: As a translator (for another project), I don't like Transifex and prefer to send good old Git pull requests. I understand a "traditional" work

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-25 Thread John Dennis
On 07/24/2012 04:17 AM, Petr Viktorin wrote: On 07/23/2012 10:46 PM, John Dennis wrote: [...] The only thing holding up the ACK is the question of why po-files now has update_pot as a dependency. If files simply depend on $(DOMAIN).pot, then they are considered up-to-date even after they&#x

Re: [Freeipa-devel] DN patch and documentation

2012-07-26 Thread John Dennis
thod had a number of programming errors (i.e. modification during list traversal), all that's been fixed now. Line 1609: indirect = memberof[:] # make a copy of the list I believe the list() is more readable ­— doesn't need a comment: indirect = list(memberof) Yup,

Re: [Freeipa-devel] DN patch and documentation

2012-07-26 Thread John Dennis
On 07/17/2012 06:47 PM, John Dennis wrote: ipapython/dn.py: in docstring: DN(arg0, ..., locked=False, first_key_match=True) followed by: def __init__(self, *args, **kwds): and: kwds.get('first_key_match', True) I don't see the reason for this. Just writ

Re: [Freeipa-devel] DN patch and documentation

2012-07-26 Thread John Dennis
have not exercised those components. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] DN patch and documentation

2012-07-27 Thread John Dennis
On 07/27/2012 05:06 AM, Petr Viktorin wrote: On 07/26/2012 10:11 PM, John Dennis wrote: On 07/17/2012 06:47 PM, John Dennis wrote: ipapython/dn.py: in docstring: DN(arg0, ..., locked=False, first_key_match=True) followed by: def __init__(self, *args, **kwds): and

<    1   2   3   4   5   6   >