Re: [gem5-dev] Packet ID messages in the protobuf packet trace format

2017-09-15 Thread Andreas Hansson
Hi Gabe, The pkt_id field was intentionally left up to the user to populate as they see fit. Master ID, stream ID, or PC as in the case of the mem_probe used by the CommMonitor. If you think there is need for another ID, then by all means we should add it. The question is, could you use the ID

Re: [gem5-dev] "RamBank" SimObject

2017-08-08 Thread Andreas Hansson
Hi Gabe, It is not that simple. The whole point is that the crossbar does any address interleaving, so that it can be used both for memories and caches (or really any slave downstream). Moreover, there is no need for a single level of crossbars to actually have all addresses represented. It can

Re: [gem5-dev] running system C models as gem5 SimObjects

2017-07-27 Thread Andreas Hansson
Hi Gabe, The similarity between TLM2 and gem5 is not accidental. We did a lot of work in 2011 and 2012 to make it that way. In fact, we even created a version of the gem5 ports that use the 4-phase TLM2 non-blocking protocol, but ended up never pushing it as it has a fairly sizeable negative

Re: [gem5-dev] system C reading material

2017-06-02 Thread Andreas Hansson
Hi Gabe, I think the best resource is Doulos: https://www.doulos.com/knowhow/systemc/ For an up-to-date view of what is going on, it is usually best to see what is being presented at recent events: http://www.accellera.org/news/events with the latest SystemC evolution day being a great example:

Re: [gem5-dev] use of C++ exceptions

2017-05-11 Thread Andreas Hansson
t; to the caller, assuming a stray exception didn't escape somehow. I >>>think >>> it >>> would be a little nicer that way, but not so much that I'd want to >>>argue >>> for it very strongly. >>> >>> Gabe >>> >>> On

Re: [gem5-dev] use of C++ exceptions

2017-05-10 Thread Andreas Hansson
Hi Gabe, I do not think adding exceptions will make things any less cluttered. It will simply move that complexity to any caller, will it not? I am not a fan of exceptions in general as it mucks with the control flow. Andreas On 10/05/2017, 07:31, "gem5-dev on behalf of Gabe Black"

Re: [gem5-dev] testing the gem5 library

2017-04-29 Thread Andreas Hansson
Hi Gabe, The best would be to test the SystemC main.cc which is in util/systemc and links to libgem5. I know that Matthias has worked on getting SystemC included in ext so that we can build this all as part of the regressions. Andreas On 28/04/2017, 22:13, "gem5-dev on behalf of Gabe Black"

Re: [gem5-dev] annoying rebuild of swig wrappers during NULL build

2017-04-22 Thread Andreas Hansson
Note that Swig is about to be removed and replaced with Pybind11. Perhaps the problem will still be there, but don’t invest time if that’s not the case. Andreas On 22/04/2017, 00:55, "gem5-dev on behalf of Steve Reinhardt" wrote: >Yup, I

Re: [gem5-dev] scons question

2017-04-13 Thread Andreas Hansson
The best solution, in my view, would be to link the various subdirectories into static libraries, libbase.a etc, and do so independent of the ISA that is being built. Everything besides the arch and dev tree should then be able to be built once, and the linking also ends up being hierarchical.

Re: [gem5-dev] More problems in SE land

2017-03-10 Thread Andreas Hansson
Great. Thanks Brandon. Just shout if you need any help testing it out. Andreas From: "Potter, Brandon" <brandon.pot...@amd.com<mailto:brandon.pot...@amd.com>> Date: Friday, 10 March 2017 at 08:31 To: Andreas Hansson <andreas.hans...@arm.com<mailto:andreas.hans...@arm

Re: [gem5-dev] More problems in SE land

2017-03-10 Thread Andreas Hansson
Merely a reminder that this is still broken. Andreas From: Andreas Hansson <andreas.hans...@arm.com<mailto:andreas.hans...@arm.com>> Date: Tuesday, 7 March 2017 at 08:54 To: gem5 Developer List <gem5-dev@gem5.org<mailto:gem5-dev@gem5.org>> Subject: More problems in SE l

[gem5-dev] More problems in SE land

2017-03-07 Thread Andreas Hansson
Hi all (and Brandon in particular), More problems in SE land I’m afraid. The following changeset prevents gem5 from building on macOS: commit 2367198921765848a4f5b3d020a7cc5776209f80 Author: Brandon Potter Date: Mon Feb 27 14:10:15 2017 -0500 syscall_emul: [PATCH

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

2017-03-07 Thread Andreas Hansson
you also update http://gem5.org/Submitting_Contributions accordingly? - Andreas Hansson On Feb. 21, 2017, 5:34 p.m., Jason Lowe-Power wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://review

Re: [gem5-dev] Best method for adding code to ext/

2017-03-03 Thread Andreas Hansson
Hi Jason, How would we keep the external repos in sync? Can a subrepo refer to a specific version? Also note that we need to keep GPL code out of gem5 (including binaries), not just the source tree, so your bad point (3) below doesn’t change either way. Andreas On 03/03/2017, 19:35,

Re: [gem5-dev] ISA Deprecation

2017-03-01 Thread Andreas Hansson
Hi all, I am in favour of revisiting this on a regular basis. Our previous discussion started with SPARC being the #1 candidate for removal (due to level of functionality and lack of testing as well as maintainers), but eventually we landed on ALPHA being a more likely candidate (due to absence

Re: [gem5-dev] Review Request 3812: ext: Include SystemC 2.3.1 into gem5

2017-02-26 Thread Andreas Hansson
work very well for state machines. Clearly this is off topic for the patch, but I am keen to know if anyone has already progress this train of thought, or would be keen to discuss the options. - Andreas Hansson On Feb. 14, 2017, 8:33 p.m., Matthias

Re: [gem5-dev] Review Request 3827: python: Use PyBind11 instead of SWIG for Python wrappers

2017-02-26 Thread Andreas Hansson
t; docstring and naming the method's parameters. > > The new wrappers has the following known issues: > > * Global events can't be memory managed correctly. This was the > case in SWIG as well. > > Change-Id: I88c5a95b6cf6c32fa9e1ad31dfc08b2e8199a763 > Signed-off-by: An

Re: [gem5-dev] Review Request 3838: ext: Update DRAMPower

2017-02-26 Thread Andreas Hansson
the functionality is matched by the DRAMCtrl? Is there anyone that already played around with bank-wise refresh? - Andreas Hansson On Feb. 24, 2017, 9:56 p.m., Matthias Jung wrote: > > --- > This is an automatically generated e-mail. To rep

Re: [gem5-dev] Review Request 3841: gpu-compute: mark functions with override if replacing virtual

2017-02-26 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3841/#review9482 --- Ship it! Ship It! - Andreas Hansson On Feb. 25, 2017, 7:33 p.m

Re: [gem5-dev] Review Request 3840: gpu-compute: remove unnecessary member from class

2017-02-26 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3840/#review9481 --- Ship it! Ship It! - Andreas Hansson On Feb. 25, 2017, 7:31 p.m

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

2017-02-23 Thread Andreas Hansson
14/#comment7980> Is there a step where tests/regressions are added and/or updated, or is that perhaps too much detail for this doc? - Andreas Hansson On Feb. 21, 2017, 5:34 p.m., Jason Lowe-Power wrote: > > --- > This is an automatically

[gem5-dev] changeset in gem5: mem: Fix memory footprint includes

2017-02-19 Thread Andreas Hansson
changeset 77b4fd593427 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=77b4fd593427 description: mem: Fix memory footprint includes Fix compilation errors due to missing include. diffstat: src/mem/probes/mem_footprint.hh | 2 +- 1 files changed, 1

[gem5-dev] changeset in gem5: sim: Ensure draining is deterministic

2017-02-19 Thread Andreas Hansson
changeset 76c36516e0ae in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=76c36516e0ae description: sim: Ensure draining is deterministic The traversal of drainable objects could potentially be non-deterministic when using an unordered set containing

[gem5-dev] changeset in gem5: mem: Ensure deferred snoops are cache-line al...

2017-02-19 Thread Andreas Hansson
changeset 5869c83bc8c7 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=5869c83bc8c7 description: mem: Ensure deferred snoops are cache-line aligned This patch fixes a bug where a deferred snoop ended up being to a partial cache line, and not

[gem5-dev] changeset in gem5: stats: Get all stats updated to reflect curre...

2017-02-19 Thread Andreas Hansson
changeset 67dee11badea in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=67dee11badea description: stats: Get all stats updated to reflect current behaviour Line everything up again. diffstat:

Re: [gem5-dev] Review Request 3806: sparc: fix bugs caused by cd7f3a1dbf55

2017-02-16 Thread Andreas Hansson
is a good idea. - Andreas Hansson On Feb. 10, 2017, 8:31 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Andreas Hansson
Great! Thanks Jason. On 15/02/2017, 21:06, "gem5-dev on behalf of Jason Lowe-Power" wrote: >I just pushed the other patch. > >Cheers, >Jason > >On Wed, Feb 15, 2017 at 2:48 PM Brandon Potter >wrote: > >> This

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Andreas Hansson
> On Feb. 15, 2017, 8:46 p.m., Andreas Hansson wrote: > > It's not the third time this is resolved :-) > > > > http://reviews.gem5.org/r/3801/ > > > > Jason, is there any chance you could push the aforemention

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Andreas Hansson
/3801/ Jason, is there any chance you could push the aforementioned patch? - Andreas Hansson On Feb. 15, 2017, 8:43 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://revi

Re: [gem5-dev] Thoughts On Project Using C++14

2017-02-14 Thread Andreas Hansson
Hi Brandon, I suggest we stick to a compiler/stdlib version that is already part of shipping LTS distros and RHE or similar. If I’m not mistaken, for Ubuntu that means gcc 5.3, and for RHE7 that means gcc 4.8.5. Andreas On 14/02/2017, 23:40, "gem5-dev on behalf of Potter, Brandon"

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

2017-02-12 Thread Andreas Hansson
> On Jan. 25, 2017, 11:28 a.m., Andreas Sandberg wrote: > > Ship It! What was the verdict? Is it just a matter of an updated patch description/summary and then this should be pushed? - Andreas --- This is an automatically generated

Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]

2017-02-11 Thread Andreas Hansson
? - Andreas Hansson On Feb. 5, 2017, 1:15 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3804: sim: fix build breakage in process.cc after brandon@11801

2017-02-04 Thread Andreas Hansson
here. After a bit of reading on stackoverflow it seems it could be because the member is default initialized... - Andreas Hansson On Feb. 3, 2017, 4:29 p.m., Bjoern A. Zeeb wrote: > > --- > This is an automatically generat

Re: [gem5-dev] Review Request 3803: sim: Patch to fix the statfs build

2017-02-04 Thread Andreas Hansson
, but it does indeed seem to do the trick also for OSX. Thanks! - Andreas Hansson On Feb. 3, 2017, 4:25 p.m., Bjoern A. Zeeb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3378: scons: make build better on FreeBSD

2017-02-03 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3378/#review9389 --- Ship it! Ship It! - Andreas Hansson On Feb. 3, 2017, 4:20 p.m

Re: [gem5-dev] Review Request 3801: mem, misc: fix building issue with CommMonitor (unused variables)

2017-02-03 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3801/#review9387 --- Ship it! Ship It! - Andreas Hansson On Feb. 3, 2017, 9:04 a.m

Re: [gem5-dev] Review Request 3801: misc: fix building issue (undefined variables)

2017-02-03 Thread Andreas Hansson
ommMonitor in the description. I also expect this is due to unused variables in fast builds? Not undefined variables. - Andreas Hansson On Feb. 3, 2017, 8:37 a.m., Pierre-Yves Péneau wrote: > > --- > This is an automatical

Re: [gem5-dev] Review Request 3801: misc: fix building issue (undefined variables)

2017-02-03 Thread Andreas Hansson
801/#comment7951> the (const bool) part seems excessive - Andreas Hansson On Feb. 3, 2017, 8:37 a.m., Pierre-Yves Péneau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://revie

Re: [gem5-dev] Review Request 3800: x86 fix Mul1u instructions

2017-02-02 Thread Andreas Hansson
? Is it not possible to avoid using the non-standard type? - Andreas Hansson On Feb. 2, 2017, 12:32 a.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Compilation error for gem5 after statfs change

2017-02-02 Thread Andreas Hansson
rm. > >If you have a github mirror, every time you push to it, Travis-CI kicks >off >4 builds (for the matrix of OS and compiler). > >https://github.com/powerjg/gem5-ci-test/blob/master/.travis.yml > >It would be great if you could take a look at this, Brandon. > >Thanks

Re: [gem5-dev] Review Request 3796: misc: Clean up and complete the gem5<->SystemC-TLM bridge [7/6]

2017-02-01 Thread Andreas Hansson
> On Feb. 1, 2017, 1:29 p.m., Andreas Hansson wrote: > > It would be tremendously helpful if we could get some regressions tests, > > but until core SystemC is available with Apache v2 (which supposedly should > > happen) I do not see a good way. Any thoughts?

Re: [gem5-dev] Review Request 3378: scons: make build better on FreeBSD

2017-02-01 Thread Andreas Hansson
949> Before committing this, could you add a comment before this line to explain that is is for BSD? - Andreas Hansson On Jan. 31, 2017, 1:44 p.m., Bjoern A. Zeeb wrote: > > --- > This is an automatically generated e-mail.

Re: [gem5-dev] Compilation error for gem5 after statfs change

2017-01-26 Thread Andreas Hansson
ge errors on >platforms that don't support what's necessary under the covers. (Correct >me if there's a better way to handle this.) > >I'll post a patch and respond to the mailing list when I have it working. > >Regards, >Brandon > >-Original Message----- >From:

Re: [gem5-dev] Compilation error for gem5 after statfs change

2017-01-26 Thread Andreas Hansson
Hi all, While I agree about the end goal (test every commit on every platform) I would suggest we go about this one step at a time. The likelihood of breakage is only high for anything related to syscall emulation, so it really only affects a small part of the developer community. Agreed? With

Re: [gem5-dev] Ideas for sprint projects

2017-01-25 Thread Andreas Hansson
contribution to gem5. Andreas On 23/01/2017, 16:57, "gem5-dev on behalf of Andreas Hansson" <gem5-dev-boun...@gem5.org on behalf of andreas.hans...@arm.com> wrote: >Hi all, > >Another medium-sized idea: Embed the generated system SVG in a web page >that can be used to interacti

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

2017-01-24 Thread Andreas Hansson
Hi Alec, Don’t worry about it. It is the reviewboard being silly. Andreas On 24/01/2017, 16:34, "gem5-dev on behalf of Alec Roelke" wrote: > > >> On Jan. 24, 2017, 9:43 a.m., Andreas Sandberg wrote: >> > Did you remove all files from

Re: [gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression --scratch all

2017-01-24 Thread Andreas Hansson
Hi Joel, We have been stalling on getting http://reviews.gem5.org/r/3781/ shipped. Once that is done we can update the stats. If Jason can help the patch then I am happy to bump the stats. Andreas On 24/01/2017, 06:09, "gem5-dev on behalf of Joel Hestness"

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

2017-01-24 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/#review9298 --- Ship it! Ship It! - Andreas Hansson On Jan. 23, 2017, 7:36 p.m

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

2017-01-23 Thread Andreas Hansson
directory. This will turn the test into a functional-only test. In fact that may be there better option here as we also don't have to worry about distributing a new binary. - Andreas Hansson On Jan. 18, 2017, 4:42 p.m., Alec Roelke wrote

Re: [gem5-dev] Ideas for sprint projects

2017-01-23 Thread Andreas Hansson
Hi all, Another medium-sized idea: Embed the generated system SVG in a web page that can be used to interactively navigate the simulation results This should be fairly easy for anyone skilled in client-side scripting. It may even be used to view incremental results while the simulation is

Re: [gem5-dev] Review Request 3783: mem: Update DRAM configuration names

2017-01-18 Thread Andreas Hansson
Hi Jason, I don’t see a reason why it could not be refactored as you suggest. Definitely something to consider going forward. Andreas On 18/01/2017, 07:21, "gem5-dev on behalf of Jason Lowe-Power" wrote: >

Re: [gem5-dev] changeset in gem5: syscall_emul: add support for x86 statfs syst...

2017-01-13 Thread Andreas Hansson
tors to >fix fundamental flaws when adding useful features. Hopefully we can come >up with a solution as a community. > >-Original Message- >From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Andreas >Hansson >Sent: Thursday, January 12, 2017 12:45 AM >To:

Re: [gem5-dev] changeset in gem5: syscall_emul: add support for x86 statfs syst...

2017-01-12 Thread Andreas Hansson
Hi Brandon, Could you have a look at this and come up with some form of solution so that gem5 compiles on BSD and OSX as well? Thanks, Andreas On 22/12/2016, 10:30, "gem5-dev on behalf of Bjoern A. Zeeb" wrote: >On 15 Dec

Re: [gem5-dev] A complete gem5 <-> SystemC TLM bridge

2017-01-11 Thread Andreas Hansson
Hi Christian, Great work! Thanks for getting this in shape. Regarding your question on delays, the packet.hh header has a fairly elaborate description (and yes, I am to blame). The delays are set and incremented by the CoherentXBar and Cache for cases where the request packets must make

Re: [gem5-dev] protobuf error

2017-01-09 Thread Andreas Hansson
Hi Kritik, Thanks for all the diligence. To me this sounds like an issue in the protobuf headers, do you not think so? Andreas On 06/01/2017, 17:09, "gem5-dev on behalf of kritik bhimani" wrote: >I got the following as error

Re: [gem5-dev] Review Request 2691: mem: implement x86 locked accesses in timing-mode classic cache

2017-01-05 Thread Andreas Hansson
> On Jan. 5, 2017, 4:32 p.m., Tony Gutierrez wrote: > > Is there anything holding this up from being shipped? In my view the patch needs two things: 1) Some thought around the design. I am still hoping there is a less invasive way of accommodating the functionality, possibly with some changes

[gem5-dev] changeset in gem5: mem: Ensure InvalidateReq is considered isFor...

2016-12-05 Thread Andreas Hansson
to targets arriving after an InvalidateReq. To address this the InvalidateReq is now treated as isForward, much like an UpgradeReq that did not hit in the cache. Change-Id: Ia878444d949539b5c33fd19f3e12b0b8a872275e Reviewed-by: Andreas Hansson <andreas.hans...@arm.

Re: [gem5-dev] Review Request 3711: ruby: Detect garnet network-level deadlock.

2016-12-02 Thread Andreas Hansson
> On Nov. 17, 2016, 10:36 p.m., Andreas Hansson wrote: > > src/mem/ruby/network/garnet2.0/NetworkInterface.cc, line 326 > > <http://reviews.gem5.org/r/3711/diff/2/?file=63632#file63632line326> > > > > this should not be a panic, perhaps a fatal? > >

[gem5-dev] Review Request 3747: ruby: Remove RubyMemoryControl and associated files

2016-11-30 Thread Andreas Hansson
: http://reviews.gem5.org/r/3747/diff/ Testing --- Thanks, Andreas Hansson ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] changeset in gem5: tests: Check for TrafficGen as part of memche...

2016-11-30 Thread Andreas Hansson
/memcheck.py Wed Nov 30 11:15:21 2016 -0500 @@ -39,6 +39,13 @@ # Authors: Jason Lowe-Power # Andreas Hansson +import m5 +from m5.objects import * + +# the traffic generator is only available if we have protobuf support, +# so potentially skip this test +require_sim_object("Traff

Re: [gem5-dev] Review Request 3745: scons: fix how flags are passed to the compiler when more than one sanitizer at a time is enabled

2016-11-24 Thread Andreas Hansson
outside the 65 char limit. - Andreas Hansson On Nov. 23, 2016, 10:25 p.m., Joe Gross wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3686: misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port

2016-11-17 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3686/#review9119 --- Ship it! Ship It! - Andreas Hansson On Oct. 28, 2016, 4:55 p.m

Re: [gem5-dev] Review Request 3711: ruby: Detect garnet network-level deadlock.

2016-11-17 Thread Andreas Hansson
t2.0/NetworkInterface.cc (line 328) <http://reviews.gem5.org/r/3711/#comment7857> seems the arguments are wrong? curTick should also be llu if I remember correctly - Andreas Hansson On Nov. 17, 2016

[gem5-dev] changeset in gem5: alpha: Remove ALPHA tru64 support and associa...

2016-11-17 Thread Andreas Hansson
changeset d40bdd3c5778 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=d40bdd3c5778 description: alpha: Remove ALPHA tru64 support and associated tests No one appears to be using it, and it is causing build issues and increases the development and

[gem5-dev] changeset in gem5: stats, alpha: Update ALPHA stats

2016-11-17 Thread Andreas Hansson
changeset 1d085f66c4ca in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=1d085f66c4ca description: stats, alpha: Update ALPHA stats Reflect the removal of the syscall tracking. diffstat: tests/long/fs/10.linux-boot/ref/alpha/linux/tsunami-minor/stats.txt

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

2016-11-16 Thread Andreas Hansson
if the parameter is not populated? - Andreas Hansson On Nov. 15, 2016, 9:22 p.m., Michael LeBeane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

2016-11-16 Thread Andreas Hansson
matically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3688/#review9047 ------- On Oct. 27, 2016, 7:45 a.m., Andreas Hansson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://revie

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port

2016-11-15 Thread Andreas Hansson
e assumption use SimClock::Int::ps for the "conversion" util/tlm/sc_master_port.cc (line 289) <http://reviews.gem5.org/r/3528/#comment7838> do things work even if this is not TLM_UPDATED? - Andreas Hansson On Nov. 7, 2016, 2:56

Re: [gem5-dev] Status of RISC-V patches

2016-11-14 Thread Andreas Hansson
Hi all, Merely a thought when it comes to adding tests: I would suggest we ditch all proprietary/closed-source tests and move in the direction of something that is open and maintained. My proposal would be to adopt a few of the tests from the llvm test suite. There are both very short

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

2016-11-13 Thread Andreas Hansson
> On Oct. 27, 2016, 7:47 a.m., Andreas Hansson wrote: > > src/arch/alpha/kernel_stats.cc, line 185 > > <http://reviews.gem5.org/r/3688/diff/1/?file=62591#file62591line185> > > > > Could someone skilled in the arts help out with this? > > > &g

Re: [gem5-dev] Review Request 3502: mem: Split the hit_latency into tag_latency and data_latency

2016-10-27 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/#review8995 --- Ship it! thanks for getting this in shape - Andreas Hansson On Oct

Re: [gem5-dev] Review Request 3686: misc: use a simple_initiator_socket to implement the SystemC TLM slave port

2016-10-27 Thread Andreas Hansson
> On Oct. 26, 2016, 7:22 p.m., Andreas Hansson wrote: > > Somehow the patch is not displaying. Did you use hg postreview? > > Christian Menard wrote: > Hi Andreas! Thanks for your reviews, I will give them a look soon. I > wanted to do some cleaning up anyway as

[gem5-dev] Review Request 3689: tests, ruby: Move rubytests from ALPHA (linux) to NULL (none)

2016-10-27 Thread Andreas Hansson
/3689/diff/ Testing --- Thanks, Andreas Hansson ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

2016-10-27 Thread Andreas Hansson
-added. Please let me know asap. - Andreas Hansson On Oct. 27, 2016, 7:45 a.m., Andreas Hansson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://revie

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

2016-10-27 Thread Andreas Hansson
around: http://reviews.gem5.org/r/3684/. It the tru64 removal is fine with everyone we can proceed with this patch and I'll rebase the complete removal for further discussion. - Andreas Hansson On Oct. 27, 2016, 7:45 a.m., Andreas Hansson wrote

[gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

2016-10-27 Thread Andreas Hansson
/diff/ Testing --- Thanks, Andreas Hansson ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3686: misc: use a simple_initiator_socket to implement the SystemC TLM slave port

2016-10-26 Thread Andreas Hansson
? - Andreas Hansson On Oct. 26, 2016, 4:26 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3528: misc: add a TLM to Gem5 Master Port implementation

2016-10-26 Thread Andreas Hansson
? :-) util/tlm/sc_master_port.cc (line 126) <http://reviews.gem5.org/r/3528/#comment7746> odd indentation util/tlm/sc_master_port.cc (line 138) <http://reviews.gem5.org/r/3528/#comment7747> what is this

Re: [gem5-dev] Review Request 3527: misc: prepare the TLM sources for the addition of a TLM->Gem5 Master Port

2016-10-26 Thread Andreas Hansson
difficult to grasp. util/tlm/sc_port.hh (line 6) <http://reviews.gem5.org/r/3527/#comment7734> Same as before util/tlm/sc_port.cc (line 89) <http://reviews.gem5.org/r/3527/#comment7735> You may want to call this SCSlavePort or TLMSlavePort or similar to avoid co

Re: [gem5-dev] Review Request 3480: misc: add a MasterId to the ExternalPort

2016-10-26 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/#review8987 --- Ship it! Ship It! - Andreas Hansson On Oct. 26, 2016, 4:06 p.m

[gem5-dev] changeset in gem5: config: Break out base options for usage with...

2016-10-26 Thread Andreas Hansson
changeset 725fef71f376 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=725fef71f376 description: config: Break out base options for usage with NULL ISA This patch breaks out the most basic configuration options into a set of base options, to allow

Re: [gem5-dev] Review Request 3502: mem: Split the hit_latency into tag_latency and data_latency

2016-10-26 Thread Andreas Hansson
e goes for the copy in FA-LRU Thanks! - Andreas Hansson On Oct. 25, 2016, 9:18 a.m., Sophiane SENNI wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://revie

Re: [gem5-dev] Review Request 3684: alpha: Remove ALPHA support and supplemental files

2016-10-25 Thread Andreas Hansson
ests for other Ruby protocols around. I think it's fine to just > > switch them to using x86 instead of Alpha. As far as I know, most Ruby > > users are using x86 anyway. > > Andreas Hansson wrote: > Why X86 and not NULL? I would suggest to let all the ruby testers

Re: [gem5-dev] Review Request 3684: alpha: Remove ALPHA support and supplemental files

2016-10-25 Thread Andreas Hansson
en nicer if we didn't have to compile gem5 for every protocol, but that may be asking too much. - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3684/#review8981

Re: [gem5-dev] Review Request 3684: alpha: Remove ALPHA support and supplemental files

2016-10-24 Thread Andreas Hansson
684/#comment7708> It would be great if someone familiar with the o3 model could double check this modification. - Andreas Hansson On Oct. 24, 2016, 8:43 p.m., Andreas Hansson wrote: > > --- > This is an automatically g

[gem5-dev] Removal of ALPHA from gem5

2016-10-24 Thread Andreas Hansson
Hi all, The day has come. As previously discussed, http://reviews.gem5.org/r/3684/ removes support for ALPHA from gem5. Ultimately this has to be a community decision. Thus, if anyone is actually relying on ALPHA for their work please let us know within the next two weeks. If there are any

[gem5-dev] Review Request 3684: alpha: Remove ALPHA support and supplemental files

2016-10-24 Thread Andreas Hansson
b3d5f0e9e258 tests/long/se/50.vortex/ref/alpha/tru64/o3-timing/smred.out b3d5f0e9e258 Diff: http://reviews.gem5.org/r/3684/diff/ Testing --- Thanks, Andreas Hansson ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo

Re: [gem5-dev] Review Request 3502: mem: Split the hit_latency into tag_latency and data_latency

2016-10-24 Thread Andreas Hansson
> On July 27, 2016, 4:52 p.m., Andreas Hansson wrote: > > src/mem/cache/tags/base_set_assoc.hh, line 228 > > <http://reviews.gem5.org/r/3502/diff/12/?file=57342#file57342line228> > > > > Could you add a comment here? > > > > It see

Re: [gem5-dev] Review Request 3683: config: Break out base options for usage with NULL ISA

2016-10-24 Thread Andreas Hansson
se" and "common" saying roughly the same thing. - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3683/#review8958 ---------

Re: [gem5-dev] Review Request 3683: config: Break out base options for usage with NULL ISA

2016-10-24 Thread Andreas Hansson
configs/example/ruby_mem_test.py b3d5f0e9e258 configs/example/ruby_random_test.py b3d5f0e9e258 Diff: http://reviews.gem5.org/r/3683/diff/ Testing --- Thanks, Andreas Hansson ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman

Re: [gem5-dev] Review Request 3683: config: Break out base options for usage with NULL ISA

2016-10-21 Thread Andreas Hansson
things were somewhat less broken again and that people could use the existing scripts without things blowing up. - Andreas ----------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3683/#review8944

[gem5-dev] Review Request 3683: config: Break out base options for usage with NULL ISA

2016-10-20 Thread Andreas Hansson
b3d5f0e9e258 configs/example/garnet_synth_traffic.py b3d5f0e9e258 Diff: http://reviews.gem5.org/r/3683/diff/ Testing --- Thanks, Andreas Hansson ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] changeset in gem5: stats: Update stats to reflect recent changes...

2016-10-19 Thread Andreas Hansson
changeset b3d5f0e9e258 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=b3d5f0e9e258 description: stats: Update stats to reflect recent changes to floats Mostly just splitting out the floats ops and corresponding reads/writes. diffstat:

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

2016-10-17 Thread Andreas Hansson
Jason > >On Mon, Oct 17, 2016 at 9:28 AM Potter, Brandon <brandon.pot...@amd.com> >wrote: > >> Switching this over to the dev mailing list since it seems more >> suitable (and I don’t have a user account; need to rectify that at some >>point). >> >>

[gem5-dev] changeset in gem5: config: Make configs/common a Python package

2016-10-14 Thread Andreas Hansson
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +# +# Authors: Andreas Hansson diff -r 074694750c5d -r 612f75cf36a0 configs/dist/sw.py --- a/configs/dist/sw.pyFri Oct 14 09:02:03 2016 -0500 +++ b/configs/

Re: [gem5-dev] Review Request 3604: base: Output all AddrRange parameters to config.ini

2016-10-14 Thread Andreas Hansson
> On Aug. 17, 2016, 10:35 a.m., Andreas Hansson wrote: > > No objections. We have been thinking of making this simpler, by creating a > > notion of PortGroups, and let the group be responsible for any > > hash/interleaving. Until we actually get to the point of implement

Re: [gem5-dev] Review Request 3663: config: Make configs/common a Python package

2016-10-14 Thread Andreas Hansson
b4d943429dc6 configs/example/garnet_synth_traffic.py b4d943429dc6 configs/example/hmctest.py b4d943429dc6 Diff: http://reviews.gem5.org/r/3663/diff/ Testing --- Thanks, Andreas Hansson ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-13 Thread Andreas Hansson
review this as well. - Andreas Hansson On Oct. 13, 2016, 4:48 p.m., Alec Roelke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-13 Thread Andreas Hansson
will have a (more) proper implementation of the files in the linux/ > directory. Currently the system calls technically work, but the structure of > the data structures for calls like stat aren't what RISC-V programs are > expecting. So far I've only run into this for stat and fstat.

[gem5-dev] Review Request 3663: config: Make configs/common a Python package

2016-10-13 Thread Andreas Hansson
tests/configs/x86_generic.py 6ce719503eae Diff: http://reviews.gem5.org/r/3663/diff/ Testing --- Thanks, Andreas Hansson ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

  1   2   3   4   5   6   7   8   9   10   >